@qooxdoo/framework 7.9.1 → 8.0.0-beta.1

package/source/class/qx/ui/core/MExecutable.js

@@ -61,7 +61,11 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
 
   members: {
     __executableBindingIds: null,
-    __semaphore: false,
+    
+    /**
+     * @type {Boolean} Whether the command already executed. The protection flag to stop the second command execution.
+     */
+    __commandExecuted: false,
     __executeListenerId: null,
 
     /**
@@ -83,10 +87,10 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
       var cmd = this.getCommand();
 
       if (cmd) {
-        if (this.__semaphore) {
-          this.__semaphore = false;
+        if (this.__commandExecuted) {
+          this.__commandExecuted = false;
         } else {
-          this.__semaphore = true;
+          this.__commandExecuted = true;
           cmd.execute(this);
         }
       }
@@ -100,15 +104,13 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
      * @param e {qx.event.type.Event} The execute event of the command.
      */
     __onCommandExecute(e) {
+      if (this.__commandExecuted) {
+        this.__commandExecuted = false;
+        return;
+      }
+      this.__commandExecuted = true;
       if (this.isEnabled()) {
-        if (this.__semaphore) {
-          this.__semaphore = false;
-          return;
-        }
-        if (this.isEnabled()) {
-          this.__semaphore = true;
-          this.execute();
-        }
+        this.execute();
       }
     },
 
@@ -119,11 +121,7 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
         old.removeListenerById(this.__executeListenerId);
       }
       if (value != null) {
-        this.__executeListenerId = value.addListener(
-          "execute",
-          this.__onCommandExecute,
-          this
-        );
+        this.__executeListenerId = value.addListener("execute", this.__onCommandExecute, this);
       }
 
       // binding stuff
@@ -132,42 +130,22 @@ qx.Mixin.define("qx.ui.core.MExecutable", {
         this.__executableBindingIds = ids = {};
       }
 
-      var selfPropertyValue;
       for (var i = 0; i < this._bindableProperties.length; i++) {
-        var property = this._bindableProperties[i];
+        let property = this._bindableProperties[i];
 
         // remove the old binding
         if (old != null && !old.isDisposed() && ids[property] != null) {
-          old.removeBinding(ids[property]);
+          old.removeListenerById(ids[property]);
           ids[property] = null;
         }
 
         // add the new binding
         if (value != null && qx.Class.hasProperty(this.constructor, property)) {
-          // handle the init value (don't sync the initial null)
-          var cmdPropertyValue = value.get(property);
-          if (cmdPropertyValue == null) {
-            selfPropertyValue = this.get(property);
-            // check also for themed values [BUG #5906]
-            if (selfPropertyValue == null) {
-              // update the appearance to make sure every themed property is up to date
-              this.$$resyncNeeded = true;
-              this.syncAppearance();
-              selfPropertyValue = qx.util.PropertyUtil.getThemeValue(
-                this,
-                property
-              );
-            }
-          } else {
-            // Reset the self property value [BUG #4534]
-            selfPropertyValue = null;
-          }
-          // set up the binding
-          ids[property] = value.bind(property, this, property);
-          // reapply the former value
-          if (selfPropertyValue) {
-            this.set(property, selfPropertyValue);
+          let cmdPropertyValue = value.get(property);
+          if (cmdPropertyValue !== null) {
+            this.set(property, cmdPropertyValue);
           }
+          ids[property] = value.addListener("change" + qx.lang.String.firstUp(property), evt => this.set(property, evt.getData()));
         }
       }
     }

package/source/class/qx/ui/core/MNativeOverflow.js

@@ -35,7 +35,8 @@ qx.Mixin.define("qx.ui.core.MNativeOverflow", {
     overflowX: {
       check: ["hidden", "visible", "scroll", "auto"],
       nullable: true,
-      apply: "_applyOverflowX"
+      apply: "_applyOverflowX",
+      autoApply: false
     },
 
     /**
@@ -44,7 +45,8 @@ qx.Mixin.define("qx.ui.core.MNativeOverflow", {
     overflowY: {
       check: ["hidden", "visible", "scroll", "auto"],
       nullable: true,
-      apply: "_applyOverflowY"
+      apply: "_applyOverflowY",
+      autoApply: false
     },
 
     /**

package/source/class/qx/ui/core/Widget.js

@@ -788,9 +788,7 @@ qx.Class.define("qx.ui.core.Widget", {
         if (qx.core.Environment.get("qx.debug")) {
           qx.core.Assert.assertTrue(
             (!element.$$qxObjectHash && !element.$$qxObject) ||
-              (element.$$qxObject &&
-                element.$$qxObjectHash &&
-                element.$$qxObject.toHashCode() === element.$$qxObjectHash)
+              (element.$$qxObject && element.$$qxObjectHash && element.$$qxObject.toHashCode() === element.$$qxObjectHash)
           );
         }
         var widget = element.$$qxObject;
@@ -960,8 +958,7 @@ qx.Class.define("qx.ui.core.Widget", {
           var decorator = this.getDecorator();
           var decoratorPadding = { left: 0, right: 0, top: 0, bottom: 0 };
           if (decorator) {
-            decorator =
-              qx.theme.manager.Decoration.getInstance().resolve(decorator);
+            decorator = qx.theme.manager.Decoration.getInstance().resolve(decorator);
             decoratorPadding = decorator.getPadding();
           }
 
@@ -974,11 +971,7 @@ qx.Class.define("qx.ui.core.Widget", {
 
           this.__layoutManager.renderLayout(innerWidth, innerHeight, padding);
         } else if (this.hasLayoutChildren()) {
-          throw new Error(
-            "At least one child in control " +
-              this._findTopControl() +
-              " requires a layout, but no one was defined!"
-          );
+          throw new Error("At least one child in control " + this._findTopControl() + " requires a layout, but no one was defined!");
         }
       }
 
@@ -1029,9 +1022,7 @@ qx.Class.define("qx.ui.core.Widget", {
     // overridden
     renderSeparator(separator, bounds) {
       // Insert
-      var widget = qx.ui.core.Widget.__separatorPool.getObject(
-        qx.ui.core.Widget
-      );
+      var widget = qx.ui.core.Widget.__separatorPool.getObject(qx.ui.core.Widget);
 
       widget.set({
         decorator: separator
@@ -1084,16 +1075,10 @@ qx.Class.define("qx.ui.core.Widget", {
 
       if (qx.core.Environment.get("qx.debug")) {
         if (minWidth !== null && maxWidth !== null) {
-          this.assert(
-            minWidth <= maxWidth,
-            "minWidth is larger than maxWidth!"
-          );
+          this.assert(minWidth <= maxWidth, "minWidth is larger than maxWidth!");
         }
         if (minHeight !== null && maxHeight !== null) {
-          this.assert(
-            minHeight <= maxHeight,
-            "minHeight is larger than maxHeight!"
-          );
+          this.assert(minHeight <= maxHeight, "minHeight is larger than maxHeight!");
         }
       }
 
@@ -1198,11 +1183,12 @@ qx.Class.define("qx.ui.core.Widget", {
         if (this.hasLayoutChildren()) {
           var hint = layout.getSizeHint();
 
+          if (isNaN(hint.width) || isNaN(hint.height) || typeof hint.minWidth == "string" || typeof hint.minHeight == "string") {
+            hint = layout.getSizeHint();
+          }
+
           if (qx.core.Environment.get("qx.debug")) {
-            var msg =
-              "The layout of the widget" +
-              this.toString() +
-              " returned an invalid size hint!";
+            var msg = "The layout of the widget" + this.toString() + " returned an invalid size hint!";
             this.assertInteger(hint.width, "Wrong 'left' argument. " + msg);
             this.assertInteger(hint.height, "Wrong 'top' argument. " + msg);
           }
@@ -1277,32 +1263,18 @@ qx.Class.define("qx.ui.core.Widget", {
       var bottom = this.getPaddingBottom();
       var left = this.getPaddingLeft();
       if (this.getDecorator()) {
-        var decorator = qx.theme.manager.Decoration.getInstance().resolve(
-          this.getDecorator()
-        );
+        var decorator = qx.theme.manager.Decoration.getInstance().resolve(this.getDecorator());
 
         var inset = decorator.getInsets();
 
         if (qx.core.Environment.get("qx.debug")) {
-          this.assertNumber(
-            inset.top,
-            "Invalid top decorator inset detected: " + inset.top
-          );
+          this.assertNumber(inset.top, "Invalid top decorator inset detected: " + inset.top);
 
-          this.assertNumber(
-            inset.right,
-            "Invalid right decorator inset detected: " + inset.right
-          );
+          this.assertNumber(inset.right, "Invalid right decorator inset detected: " + inset.right);
 
-          this.assertNumber(
-            inset.bottom,
-            "Invalid bottom decorator inset detected: " + inset.bottom
-          );
+          this.assertNumber(inset.bottom, "Invalid bottom decorator inset detected: " + inset.bottom);
 
-          this.assertNumber(
-            inset.left,
-            "Invalid left decorator inset detected: " + inset.left
-          );
+          this.assertNumber(inset.left, "Invalid left decorator inset detected: " + inset.left);
         }
 
         top += inset.top;
@@ -1701,11 +1673,7 @@ qx.Class.define("qx.ui.core.Widget", {
      */
     _add(child, options) {
       if (qx.core.Environment.get("qx.debug")) {
-        this.assertInstance(
-          child,
-          qx.ui.core.LayoutItem.constructor,
-          "'Child' must be an instance of qx.ui.core.LayoutItem!"
-        );
+        this.assertInstance(child, qx.ui.core.LayoutItem.constructor, "'Child' must be an instance of qx.ui.core.LayoutItem!");
       }
 
       // When moving in the same widget, remove widget first
@@ -1765,11 +1733,7 @@ qx.Class.define("qx.ui.core.Widget", {
      */
     _addBefore(child, before, options) {
       if (qx.core.Environment.get("qx.debug")) {
-        this.assertInArray(
-          before,
-          this._getChildren(),
-          "The 'before' widget is not a child of this widget!"
-        );
+        this.assertInArray(before, this._getChildren(), "The 'before' widget is not a child of this widget!");
       }
 
       if (child == before) {
@@ -1800,11 +1764,7 @@ qx.Class.define("qx.ui.core.Widget", {
      */
     _addAfter(child, after, options) {
       if (qx.core.Environment.get("qx.debug")) {
-        this.assertInArray(
-          after,
-          this._getChildren(),
-          "The 'after' widget is not a child of this widget!"
-        );
+        this.assertInArray(after, this._getChildren(), "The 'after' widget is not a child of this widget!");
       }
 
       if (child == after) {
@@ -1921,17 +1881,9 @@ qx.Class.define("qx.ui.core.Widget", {
      */
     __addHelper(child, options) {
       if (qx.core.Environment.get("qx.debug")) {
-        this.assertInstance(
-          child,
-          qx.ui.core.LayoutItem,
-          "Invalid widget to add: " + child
-        );
-
-        this.assertNotIdentical(
-          child,
-          this,
-          "Could not add widget to itself: " + child
-        );
+        this.assertInstance(child, qx.ui.core.LayoutItem, "Invalid widget to add: " + child);
+
+        this.assertNotIdentical(child, this, "Could not add widget to itself: " + child);
 
         if (options != null) {
           this.assertType(options, "object", "Invalid layout data: " + options);
@@ -1974,9 +1926,7 @@ qx.Class.define("qx.ui.core.Widget", {
       }
 
       if (child.getLayoutParent() !== this) {
-        throw new Error(
-          "Remove Error: " + child + " is not a child of this widget!"
-        );
+        throw new Error("Remove Error: " + child + " is not a child of this widget!");
       }
 
       // Clear parent connection
@@ -2107,15 +2057,12 @@ qx.Class.define("qx.ui.core.Widget", {
           return;
         }
         var manager = qx.locale.Manager.getInstance();
-        this.__toolTipTextListenerId = manager.addListener(
-          "changeLocale",
-          () => {
-            var toolTipText = this.getToolTipText();
-            if (toolTipText && toolTipText.translate) {
-              this.setToolTipText(toolTipText.translate());
-            }
+        this.__toolTipTextListenerId = manager.addListener("changeLocale", () => {
+          var toolTipText = this.getToolTipText();
+          if (toolTipText && toolTipText.translate) {
+            this.setToolTipText(toolTipText.translate());
           }
-        );
+        });
       }
     },
 
@@ -2136,13 +2083,7 @@ qx.Class.define("qx.ui.core.Widget", {
         } // only force a layout update if visibility change from/to "exclude"
       }
       var parent = this.$$parent;
-      if (
-        parent &&
-        (old == null ||
-          value == null ||
-          old === "excluded" ||
-          value === "excluded")
-      ) {
+      if (parent && (old == null || value == null || old === "excluded" || value === "excluded")) {
         parent.invalidateLayoutChildren();
       }
 
@@ -2163,11 +2104,7 @@ qx.Class.define("qx.ui.core.Widget", {
 
       // In Opera the cursor must be set directly.
       // http://bugzilla.qooxdoo.org/show_bug.cgi?id=1729
-      this.getContentElement().setStyle(
-        "cursor",
-        value,
-        qx.core.Environment.get("engine.name") == "opera"
-      );
+      this.getContentElement().setStyle("cursor", value, qx.core.Environment.get("engine.name") == "opera");
     },
 
     // property apply
@@ -2384,10 +2321,6 @@ qx.Class.define("qx.ui.core.Widget", {
       var selector = this.__appearanceSelector;
       var manager = qx.theme.manager.Appearance.getInstance();
 
-      // Cache deep accessor
-      var styler = qx.core.Property.$$method.setThemed;
-      var unstyler = qx.core.Property.$$method.resetThemed;
-
       // Check for requested selector update
       if (this.__updateSelector) {
         // Clear flag
@@ -2396,12 +2329,7 @@ qx.Class.define("qx.ui.core.Widget", {
         // Check if the selector was created previously
         if (selector) {
           // Query old selector
-          var oldData = manager.styleFrom(
-            selector,
-            states,
-            null,
-            this.getAppearance()
-          );
+          var oldData = manager.styleFrom(selector, states, null, this.getAppearance());
 
           // Clear current selector (to force recompute)
           selector = null;
@@ -2427,18 +2355,14 @@ qx.Class.define("qx.ui.core.Widget", {
       }
 
       // Query current selector
-      var newData = manager.styleFrom(
-        selector,
-        states,
-        null,
-        this.getAppearance()
-      );
+      var newData = manager.styleFrom(selector, states, null, this.getAppearance());
 
       if (newData) {
         if (oldData) {
           for (var prop in oldData) {
             if (newData[prop] === undefined) {
-              this[unstyler[prop]]();
+              let propertyFirstUp = qx.Bootstrap.firstUp(prop);
+              this[`resetThemed${propertyFirstUp}`]();
             }
           }
         }
@@ -2446,28 +2370,23 @@ qx.Class.define("qx.ui.core.Widget", {
         // Check property availability of new data
         if (qx.core.Environment.get("qx.debug")) {
           for (var prop in newData) {
-            if (!this[styler[prop]]) {
-              throw new Error(
-                this.classname +
-                  ' has no themeable property "' +
-                  prop +
-                  '" while styling ' +
-                  selector
-              );
+            let propertyFirstUp = qx.Bootstrap.firstUp(prop);
+            if (!this[`setThemed${propertyFirstUp}`]) {
+              throw new Error(this.classname + ' has no themeable property "' + prop + '" while styling ' + selector);
             }
           }
         }
 
         // Apply new data
         for (var prop in newData) {
-          newData[prop] === undefined
-            ? this[unstyler[prop]]()
-            : this[styler[prop]](newData[prop]);
+          let propertyFirstUp = qx.Bootstrap.firstUp(prop);
+          newData[prop] === undefined ? this[`resetThemed${propertyFirstUp}`]() : this[`setThemed${propertyFirstUp}`](newData[prop]);
         }
       } else if (oldData) {
         // Clear old data
         for (var prop in oldData) {
-          this[unstyler[prop]]();
+          let propertyFirstUp = qx.Bootstrap.firstUp(prop);
+          this[`resetThemed${propertyFirstUp}`]();
         }
       }
 
@@ -2738,11 +2657,7 @@ qx.Class.define("qx.ui.core.Widget", {
         if (!value) {
           this.removeListener("contextmenu", this._onContextMenuOpen);
           this.removeListener("longtap", this._onContextMenuOpen);
-          old.removeListener(
-            "changeVisibility",
-            this._onBeforeContextMenuOpen,
-            this
-          );
+          old.removeListener("changeVisibility", this._onBeforeContextMenuOpen, this);
         }
       }
 
@@ -2753,11 +2668,7 @@ qx.Class.define("qx.ui.core.Widget", {
         if (!old) {
           this.addListener("contextmenu", this._onContextMenuOpen);
           this.addListener("longtap", this._onContextMenuOpen);
-          value.addListener(
-            "changeVisibility",
-            this._onBeforeContextMenuOpen,
-            this
-          );
+          value.addListener("changeVisibility", this._onBeforeContextMenuOpen, this);
         }
       }
     },
@@ -2787,10 +2698,7 @@ qx.Class.define("qx.ui.core.Widget", {
      * @param e {qx.event.type.Data} The data event
      */
     _onBeforeContextMenuOpen(e) {
-      if (
-        e.getData() == "visible" &&
-        this.hasListener("beforeContextmenuOpen")
-      ) {
+      if (e.getData() == "visible" && this.hasListener("beforeContextmenuOpen")) {
         this.fireDataEvent("beforeContextmenuOpen", e);
       }
     },
@@ -3005,11 +2913,7 @@ qx.Class.define("qx.ui.core.Widget", {
      *   directly when possible
      */
     scrollChildIntoViewX(child, align, direct) {
-      this.getContentElement().scrollChildIntoViewX(
-        child.getContentElement(),
-        align,
-        direct
-      );
+      this.getContentElement().scrollChildIntoViewX(child.getContentElement(), align, direct);
     },
 
     /**
@@ -3024,11 +2928,7 @@ qx.Class.define("qx.ui.core.Widget", {
      *   directly when possible
      */
     scrollChildIntoViewY(child, align, direct) {
-      this.getContentElement().scrollChildIntoViewY(
-        child.getContentElement(),
-        align,
-        direct
-      );
+      this.getContentElement().scrollChildIntoViewY(child.getContentElement(), align, direct);
     },
 
     /*
@@ -3254,19 +3154,10 @@ qx.Class.define("qx.ui.core.Widget", {
         if (pos == -1) {
           var control = this._createChildControlImpl(id);
         } else {
-          var control = this._createChildControlImpl(
-            id.substring(0, pos),
-            id.substring(pos + 1, id.length)
-          );
+          var control = this._createChildControlImpl(id.substring(0, pos), id.substring(pos + 1, id.length));
         }
       } catch (exc) {
-        exc.message =
-          "Exception while creating child control '" +
-          id +
-          "' of widget " +
-          this.toString() +
-          ": " +
-          exc.message;
+        exc.message = "Exception while creating child control '" + id + "' of widget " + this.toString() + ": " + exc.message;
         throw exc;
       }
 
@@ -3513,11 +3404,7 @@ qx.Class.define("qx.ui.core.Widget", {
       let idArr = [];
       for (const widget of widgets) {
         if (!(widget instanceof qx.ui.core.Widget)) {
-          throw new Error(
-            "Given widget " +
-              widget +
-              " is not an instance of qx.ui.core.Widget!"
-          );
+          throw new Error("Given widget " + widget + " is not an instance of qx.ui.core.Widget!");
         }
         const contentEl = widget.getContentElement();
         let widgetId = contentEl.getAttribute("id");
@@ -3603,9 +3490,7 @@ qx.Class.define("qx.ui.core.Widget", {
     if (!qx.core.ObjectRegistry.inShutDown) {
       if (qx.core.Environment.get("qx.dynlocale")) {
         if (this.__toolTipTextListenerId) {
-          qx.locale.Manager.getInstance().removeListenerById(
-            this.__toolTipTextListenerId
-          );
+          qx.locale.Manager.getInstance().removeListenerById(this.__toolTipTextListenerId);
         }
       }
 

package/source/class/qx/ui/core/scroll/IScrollBar.js

@@ -67,7 +67,9 @@ qx.Interface.define("qx.ui.core.scroll.IScrollBar", {
      * @param duration {Number} The time in milliseconds the slide to should take.
      */
     scrollTo(position, duration) {
-      this.assertNumber(position);
+      if (qx.core.Environment.get("qx.debug")) {
+        this.assertNumber(position);
+      }
     },
 
     /**
@@ -80,7 +82,9 @@ qx.Interface.define("qx.ui.core.scroll.IScrollBar", {
      * @param duration {Number} The time in milliseconds the slide to should take.
      */
     scrollBy(offset, duration) {
-      this.assertNumber(offset);
+      if (qx.core.Environment.get("qx.debug")) {
+        this.assertNumber(offset);
+      }
     },
 
     /**
@@ -93,7 +97,9 @@ qx.Interface.define("qx.ui.core.scroll.IScrollBar", {
      * @param duration {Number} The time in milliseconds the slide to should take.
      */
     scrollBySteps(steps, duration) {
-      this.assertNumber(steps);
+      if (qx.core.Environment.get("qx.debug")) {
+        this.assertNumber(steps);
+      }
     }
   }
 });

package/source/class/qx/ui/core/scroll/ScrollBar.js

@@ -132,7 +132,13 @@ qx.Class.define("qx.ui.core.scroll.ScrollBar", {
      * on this, please use {@link #scrollTo} instead.
      */
     position: {
-      check: "qx.lang.Type.isNumber(value)&&value>=0&&value<=this.getMaximum()",
+      check: function(value)
+      {
+        return (
+          qx.lang.Type.isNumber(value) &&
+            value >= 0 &&
+            value <= this.getMaximum());
+      },
       init: 0,
       apply: "_applyPosition",
       event: "scroll"

package/source/class/qx/ui/core/scroll/ScrollPane.js

@@ -79,8 +79,12 @@ qx.Class.define("qx.ui.core.scroll.ScrollPane", {
   properties: {
     /** The horizontal scroll position */
     scrollX: {
-      check:
-        "qx.lang.Type.isNumber(value)&&value>=0&&value<=this.getScrollMaxX()",
+      check: function(value) {
+        return (
+          qx.lang.Type.isNumber(value) &&
+            value >= 0 &&
+            value <= this.getScrollMaxX());
+      },
       apply: "_applyScrollX",
       transform: "_transformScrollX",
       event: "scrollX",
@@ -89,8 +93,12 @@ qx.Class.define("qx.ui.core.scroll.ScrollPane", {
 
     /** The vertical scroll position */
     scrollY: {
-      check:
-        "qx.lang.Type.isNumber(value)&&value>=0&&value<=this.getScrollMaxY()",
+      check: function(value) {
+        return (
+          qx.lang.Type.isNumber(value) &&
+            value >= 0 &&
+            value <= this.getScrollMaxY());
+      },
       apply: "_applyScrollY",
       transform: "_transformScrollY",
       event: "scrollY",

package/source/class/qx/ui/embed/Html.js

@@ -136,8 +136,12 @@ qx.Class.define("qx.ui.embed.Html", {
 
     // property apply
     _applyCssClass(value, old) {
-      this.getContentElement().removeClass(old);
-      this.getContentElement().addClass(value);
+      if (old) {
+        this.getContentElement().removeClass(old);
+      }
+      if (value) {
+        this.getContentElement().addClass(value);
+      }
     },
 
     // overridden

package/source/class/qx/ui/form/AbstractField.js

@@ -385,21 +385,13 @@ qx.Class.define("qx.ui.form.AbstractField", {
      */
     _renderContentElement(innerHeight, element) {
       //use it in child classes
-    },
-
-    // overridden
+    }, // overridden
     _createContentElement() {
       // create and add the input element
-      var el = this._createInputElement();
-
-      // initialize the html input
+      var el = this._createInputElement(); // initialize the html input
       el.setSelectable(this.getSelectable());
-      el.setEnabled(this.getEnabled());
-
-      // Add listener for input event
-      el.addListener("input", this._onHtmlInput, this);
-
-      // Disable HTML5 spell checking
+      el.setEnabled(this.getEnabled()); // Add listener for input event
+      el.addListener("input", this._onHtmlInput, this); // Disable HTML5 spell checking
       el.setAttribute("spellcheck", "false");
       el.addClass("qx-abstract-field");