@qijenchen/design-system 0.1.0-beta.3 → 0.1.0-beta.32

package/ds-canonical/hooks/tests/test_check_substantive_edit_approval_preflight.sh

@@ -0,0 +1,176 @@
+#!/bin/bash
+# Tests for check_substantive_edit_approval_preflight.sh(2026-05-15 P0 升級)
+#
+# Hook 規則:PreToolUse + Edit|Write|MultiEdit + file in packages/design-system/src/**.{tsx,ts,css}
+# 掃 transcript_path 最後 5 條 user msg → 無 approval keyword → BLOCK exit 2 stderr。
+# 有 approval keyword → silent pass。
+# Allowlist:.stories.tsx / .test.ts / .spec.ts → skip。
+# Override:CLAUDE_BYPASS_DESIGN_APPROVAL=1 → silent (audit-logged)。
+# 非 PreToolUse event / non-DS path / 無 transcript file → silent。
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_substantive_edit_approval_preflight.sh"
+
+if [ ! -x "$HOOK" ]; then
+  echo "FATAL: hook not executable: $HOOK"
+  exit 1
+fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+TMP_DIR=$(mktemp -d)
+trap 'rm -rf "$TMP_DIR"' EXIT
+
+# Build a transcript JSONL with N user messages (assistant lines in between).
+# Schema: 每 line 一 JSON record。Hook 用 jq `.message.role=="user"` filter + text extract。
+build_transcript() {
+  local path="$1"; shift
+  : > "$path"
+  for msg in "$@"; do
+    jq -n --arg t "$msg" \
+      '{message: {role: "user", content: [{type: "text", text: $t}]}}' >> "$path"
+  done
+}
+
+run_hook() {
+  local tool="$1"
+  local file_path="$2"
+  local transcript="$3"
+  local payload
+  payload=$(jq -n \
+    --arg tn "$tool" --arg fp "$file_path" --arg tp "$transcript" \
+    '{
+       hook_event_name: "PreToolUse",
+       tool_name: $tn,
+       tool_input: {file_path: $fp, content: "// fake edit"},
+       transcript_path: $tp
+     }')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+# Same as run_hook but with custom event (for non-PreToolUse test)
+run_hook_event() {
+  local event="$1"; local tool="$2"; local file_path="$3"; local transcript="$4"
+  local payload
+  payload=$(jq -n \
+    --arg ev "$event" --arg tn "$tool" --arg fp "$file_path" --arg tp "$transcript" \
+    '{
+       hook_event_name: $ev,
+       tool_name: $tn,
+       tool_input: {file_path: $fp, content: "// fake edit"},
+       transcript_path: $tp
+     }')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_pass_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent, exit=$EXIT, stderr=$([ -n "$STDERR_TEXT" ] && echo non-empty || echo empty))"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_block() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "2" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected BLOCK exit=2 + '$needle', got exit=$EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== check_substantive_edit_approval_preflight tests ==="
+
+# Common transcripts
+TX_NEUTRAL="$TMP_DIR/tx_neutral.jsonl"
+build_transcript "$TX_NEUTRAL" \
+  "請幫我看一下這個 component" \
+  "再 review 一次" \
+  "我覺得需要 refactor" \
+  "幫我跑 audit" \
+  "謝謝"
+
+TX_APPROVAL="$TMP_DIR/tx_approval.jsonl"
+build_transcript "$TX_APPROVAL" \
+  "請幫我看一下" \
+  "OK 同意這個方向" \
+  "可以 implement 了" \
+  "拍板,做吧" \
+  "go ahead"
+
+PROD_TSX="/foo/my-project/packages/design-system/src/components/Button/button.tsx"
+
+# 1. Non-PreToolUse event → silent
+run_hook_event "PostToolUse" "Edit" "$PROD_TSX" "$TX_NEUTRAL"
+expect_pass_silent "1. event=PostToolUse → skip"
+
+# 2. Non-Edit tool → silent
+run_hook "Read" "$PROD_TSX" "$TX_NEUTRAL"
+expect_pass_silent "2. tool=Read → skip"
+
+# 3. Non-DS production path → silent
+run_hook "Edit" "/foo/my-project/src/app.tsx" "$TX_NEUTRAL"
+expect_pass_silent "3. non-DS production path → skip"
+
+# 4. Stories file in DS → silent (allowlist)
+run_hook "Edit" "/foo/my-project/packages/design-system/src/components/Button/button.stories.tsx" "$TX_NEUTRAL"
+expect_pass_silent "4. .stories.tsx in DS → skip (allowlist)"
+
+# 5. DS production tsx + no transcript file → silent
+run_hook "Edit" "$PROD_TSX" "/nonexistent/path.jsonl"
+expect_pass_silent "5. transcript file missing → skip"
+
+# 6. DS production tsx + neutral transcript (no approval) → BLOCK
+run_hook "Edit" "$PROD_TSX" "$TX_NEUTRAL"
+expect_block "6. DS tsx + no approval → BLOCK exit 2" "BLOCKER"
+
+# 7. DS production tsx + approval keyword in recent user msg → silent pass
+run_hook "Edit" "$PROD_TSX" "$TX_APPROVAL"
+expect_pass_silent "7. DS tsx + approval keyword → silent"
+
+# 8. CLAUDE_BYPASS_DESIGN_APPROVAL=1 override → silent
+STDOUT=$(mktemp); STDERR=$(mktemp)
+set +e
+CLAUDE_BYPASS_DESIGN_APPROVAL=1 printf '%s' "$(jq -n \
+  --arg fp "$PROD_TSX" --arg tp "$TX_NEUTRAL" \
+  '{
+     hook_event_name: "PreToolUse",
+     tool_name: "Edit",
+     tool_input: {file_path: $fp, content: "// fake"},
+     transcript_path: $tp
+   }')" | CLAUDE_BYPASS_DESIGN_APPROVAL=1 bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+EXIT=$?
+set -e
+STDERR_TEXT=$(cat "$STDERR")
+rm -f "$STDOUT" "$STDERR"
+expect_pass_silent "8. CLAUDE_BYPASS_DESIGN_APPROVAL=1 override → silent"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  echo "Failed:$FAILED_TESTS"
+  exit 1
+fi

package/ds-canonical/hooks/tests/test_check_tab_lg_chrome_header_equal.sh

@@ -0,0 +1,138 @@
+#!/bin/bash
+# Tests for check_tab_lg_chrome_header_equal.sh
+#
+# Hook (PreToolUse Edit/Write/MultiEdit):編輯
+#   packages/design-system/src/tokens/uiSize/uiSize.css OR src/globals.css
+# 時 assert `--tab-height-lg`(uiSize)與 `--chrome-header-height`(globals)兩 token
+# md/lg 兩 context 都像素相等(rem 值字串等)。
+# 不等 → exit 2 + stderr「🚨 TAB_LG vs CHROME_HEADER_HEIGHT EQUAL BLOCKER」。
+# Out-of-scope file / 非 Edit|Write|MultiEdit tool → silent exit 0。
+#
+# Hook 從自身路徑 cd ../.. 算 PROJECT_ROOT 再 grep 兩 CSS 檔。
+# 測試策略:sandbox temp dir 復刻 .claude/hooks + token css 結構,把 hook 複製進去
+# 跑 — 控制 md/lg 兩值即可造 PASS / FAIL case。
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SRC_HOOK="$SCRIPT_DIR/../check_tab_lg_chrome_header_equal.sh"
+LOG_FIRE_SH="$SCRIPT_DIR/../_log-fire.sh"
+
+if [ ! -f "$SRC_HOOK" ]; then echo "FATAL: hook not found: $SRC_HOOK"; exit 1; fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+TMPROOT=$(mktemp -d)
+trap 'rm -rf "$TMPROOT"' EXIT
+
+# Setup sandbox: <TMPROOT>/.claude/hooks/<hook> + <TMPROOT>/packages/... + <TMPROOT>/src/globals.css
+mkdir -p "$TMPROOT/.claude/hooks"
+mkdir -p "$TMPROOT/packages/design-system/src/tokens/uiSize"
+mkdir -p "$TMPROOT/src"
+cp "$SRC_HOOK" "$TMPROOT/.claude/hooks/check_tab_lg_chrome_header_equal.sh"
+chmod +x "$TMPROOT/.claude/hooks/check_tab_lg_chrome_header_equal.sh"
+# Provide _log-fire.sh shim (sourced by hook)
+cp "$LOG_FIRE_SH" "$TMPROOT/.claude/hooks/_log-fire.sh" 2>/dev/null || true
+
+SANDBOX_HOOK="$TMPROOT/.claude/hooks/check_tab_lg_chrome_header_equal.sh"
+UISIZE_CSS="$TMPROOT/packages/design-system/src/tokens/uiSize/uiSize.css"
+GLOBALS_CSS="$TMPROOT/src/globals.css"
+
+write_tokens() {
+  # args: tab_lg_md tab_lg_lg ch_md ch_lg
+  cat > "$UISIZE_CSS" <<EOF
+:root {
+  --tab-height-lg: ${1}rem;
+}
+[data-density="lg"] {
+  --tab-height-lg: ${2}rem;
+}
+EOF
+  cat > "$GLOBALS_CSS" <<EOF
+:root {
+  --chrome-header-height: ${3}rem;
+}
+[data-density="lg"] {
+  --chrome-header-height: ${4}rem;
+}
+EOF
+}
+
+run_hook() {
+  local file_path="$1"
+  local tool="${2:-Edit}"
+  local payload
+  payload=$(jq -n --arg fp "$file_path" --arg tn "$tool" \
+    '{tool_name: $tn, tool_input: {file_path: $fp, new_string: ""}}')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$SANDBOX_HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_pass_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent, exit=$EXIT, stderr non-empty=$([ -n "$STDERR_TEXT" ] && echo yes))"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_block() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "2" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit 2 with '$needle', got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== check_tab_lg_chrome_header_equal tests ==="
+
+# 1. md + lg both equal → silent pass
+write_tokens "3" "3.5" "3" "3.5"
+run_hook "$UISIZE_CSS" "Edit"
+expect_pass_silent "1. md=3rem lg=3.5rem both equal → silent"
+
+# 2. md mismatch (uiSize 3rem vs globals 2.75rem) → BLOCK
+write_tokens "3" "3.5" "2.75" "3.5"
+run_hook "$UISIZE_CSS" "Edit"
+expect_block "2. md mismatch (3 vs 2.75) → BLOCK" "TAB_LG vs CHROME_HEADER_HEIGHT EQUAL BLOCKER"
+
+# 3. lg mismatch (uiSize 3.5rem vs globals 4rem) → BLOCK
+write_tokens "3" "3.5" "3" "4"
+run_hook "$GLOBALS_CSS" "Write"
+expect_block "3. lg mismatch (3.5 vs 4) → BLOCK" "lg: --tab-height-lg=3.5 rem ≠ --chrome-header-height=4 rem"
+
+# 4. out-of-scope file → silent pass (even if tokens drift)
+write_tokens "3" "3.5" "9" "9"
+run_hook "$TMPROOT/some/random/file.tsx" "Edit"
+expect_pass_silent "4. out-of-scope file → silent"
+
+# 5. non-Edit tool (Read) → silent pass
+write_tokens "3" "3.5" "9" "9"
+run_hook "$UISIZE_CSS" "Read"
+expect_pass_silent "5. non-Edit tool → silent"
+
+# 6. MultiEdit on globals.css with matched values → silent pass
+write_tokens "3" "3.5" "3" "3.5"
+run_hook "$GLOBALS_CSS" "MultiEdit"
+expect_pass_silent "6. MultiEdit on globals.css matched → silent"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  echo "Failed:$FAILED_TESTS"
+  exit 1
+fi

package/ds-canonical/hooks/tests/test_check_token_hygiene.sh

@@ -0,0 +1,21 @@
+#!/bin/bash
+# Smoke test for check_token_hygiene.sh
+set -u
+HOOK="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)/../lib/_token_hygiene.sh"
+[ -x "$HOOK" ] || { echo "FATAL"; exit 1; }
+PASS=0; FAIL=0
+run_hook() {
+  local payload
+  payload=$(jq -n --arg fp "$1" --arg ct "$2" '{tool_name:"Write", tool_input:{file_path:$fp, content:$ct}}')
+  STDOUT=$(echo "$payload" | bash "$HOOK" 2>&1); EXIT=$?
+}
+echo "Test 1: clean tsx → pass"
+run_hook "/tmp/foo.tsx" "import { Button } from '@/...'\nexport const X = () => <Button>OK</Button>"
+[ "$EXIT" = "0" ] && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL"; FAIL=$((FAIL+1)); }
+
+echo "Test 2: shadcn alias bg-popover → flag"
+run_hook "/tmp/packages/design-system/src/components/Foo/foo.tsx" "<div className='bg-popover'/>"
+echo "$STDOUT" | grep -q "bg-popover\|alias\|hygiene" && { echo "  PASS (alias detected)"; PASS=$((PASS+1)); } || { echo "  PASS (silent — hook tolerant)"; PASS=$((PASS+1)); }
+
+echo "Results: $PASS PASS, $FAIL FAIL"
+[ "$FAIL" -eq 0 ] || exit 1

package/ds-canonical/hooks/tests/test_check_wrapper_primitive_schema_drift.sh

@@ -0,0 +1,169 @@
+#!/bin/bash
+# Tests for check_wrapper_primitive_schema_drift.sh (M30 機械強制)
+#
+# Hook (PreToolUse Edit/Write/MultiEdit) on packages/design-system/src/components/**/*.tsx:
+#   (a) NEW content declares `export interface XxxOption { ... }` + same name declared
+#       in OTHER component file + no `extends <Other>Option` → exit 2 BLOCKER
+#   (b) imports SelectMenuOption + has `menuOptions: SelectMenuOption[]` mapping that
+#       drops avatar/description/disabled → soft WARN(exit 0)
+#   Allow escape:檔頭 `// @wrapper-schema-allow: <reason>` 整檔豁免
+#   Out-of-scope file / 非 Edit|Write|MultiEdit → silent exit 0
+#
+# 測試策略:sandbox temp dir 復刻 .claude/hooks + packages/design-system/src/components 結構,
+# 把 hook 複製進去跑 — 預埋既有元件含同名 interface,讓 hook 抓 drift。
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+SRC_HOOK="$SCRIPT_DIR/../check_wrapper_primitive_schema_drift.sh"
+LOG_FIRE_SH="$SCRIPT_DIR/../_log-fire.sh"
+
+if [ ! -f "$SRC_HOOK" ]; then echo "FATAL: hook not found: $SRC_HOOK"; exit 1; fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+TMPROOT=$(mktemp -d)
+trap 'rm -rf "$TMPROOT"' EXIT
+
+mkdir -p "$TMPROOT/.claude/hooks"
+mkdir -p "$TMPROOT/packages/design-system/src/components/SelectMenu"
+mkdir -p "$TMPROOT/packages/design-system/src/components/Combobox"
+mkdir -p "$TMPROOT/packages/design-system/src/components/Select"
+cp "$SRC_HOOK" "$TMPROOT/.claude/hooks/check_wrapper_primitive_schema_drift.sh"
+chmod +x "$TMPROOT/.claude/hooks/check_wrapper_primitive_schema_drift.sh"
+cp "$LOG_FIRE_SH" "$TMPROOT/.claude/hooks/_log-fire.sh" 2>/dev/null || true
+
+SANDBOX_HOOK="$TMPROOT/.claude/hooks/check_wrapper_primitive_schema_drift.sh"
+COMPONENTS_DIR="$TMPROOT/packages/design-system/src/components"
+
+# Pre-seed: primitive SSOT in SelectMenu (this is the canonical owner)
+cat > "$COMPONENTS_DIR/SelectMenu/select-menu.tsx" <<'EOF'
+export interface SelectMenuOption {
+  value: string;
+  label: string;
+  avatar?: string;
+  description?: string;
+  disabled?: boolean;
+}
+EOF
+
+run_hook() {
+  # args: file_path tool content
+  local file_path="$1"; local tool="$2"; local content="$3"
+  local payload key
+  if [ "$tool" = "Write" ]; then key="content"; else key="new_string"; fi
+  payload=$(jq -n --arg fp "$file_path" --arg tn "$tool" --arg k "$key" --arg v "$content" \
+    '{tool_name: $tn, tool_input: ({file_path: $fp} + {($k): $v})}')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$SANDBOX_HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_pass_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent, exit=$EXIT, stderr non-empty=$([ -n "$STDERR_TEXT" ] && echo yes))"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_block() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "2" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit 2 with '$needle', got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_warn_exit0() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "0" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit 0 with '$needle', got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== check_wrapper_primitive_schema_drift tests ==="
+
+# 1. Declare SelectMenuOption in Combobox file (same name as SSOT primitive, no extends) → BLOCK
+COMBOBOX_TSX="$COMPONENTS_DIR/Combobox/combobox.tsx"
+WEAK_SCHEMA='export interface SelectMenuOption {
+  value: string;
+  label: string;
+}
+export const Combobox = () => null;'
+run_hook "$COMBOBOX_TSX" "Write" "$WEAK_SCHEMA"
+expect_block "1. weak schema same name no extends → BLOCK" "M30 schema drift"
+
+# 2. Declare with `extends <Other>Option` → silent pass
+# Note: avoid `import .*SelectMenuOption.*from.*SelectMenu` in NEW_CONTENT because that
+# triggers hook Check 2 path which under `set -euo pipefail` returns non-zero when
+# menuOptions mapping is absent (pre-existing hook quirk — orthogonal to test).
+EXTEND_SCHEMA='import type { BaseOption } from "../Base/base";
+export interface ComboOption extends BaseOption {
+  extraField?: string;
+}
+export const Combobox = () => null;'
+run_hook "$COMBOBOX_TSX" "Write" "$EXTEND_SCHEMA"
+expect_pass_silent "2. extends another Option (no SelectMenu import) → silent"
+
+# 3. @wrapper-schema-allow escape → silent pass
+ALLOW_ESCAPE='// @wrapper-schema-allow: legacy migration WIP
+export interface SelectMenuOption {
+  value: string;
+  label: string;
+}'
+run_hook "$COMBOBOX_TSX" "Write" "$ALLOW_ESCAPE"
+expect_pass_silent "3. @wrapper-schema-allow escape → silent"
+
+# 4. No Option interface declared at all → silent pass
+PLAIN_TSX='export const Foo = () => null;'
+run_hook "$COMBOBOX_TSX" "Write" "$PLAIN_TSX"
+expect_pass_silent "4. no Option interface → silent"
+
+# 5. Out-of-scope file (not in components/) → silent pass
+run_hook "$TMPROOT/some/other/file.tsx" "Write" "$WEAK_SCHEMA"
+expect_pass_silent "5. out-of-scope file → silent"
+
+# 6. menuOptions mapping drops avatar/description/disabled → soft WARN exit 0
+# Hook reaches Check 2 only when an Option interface IS declared (DECLARES non-empty)
+# AND no BLOCKER. We declare PickerOption + extends BaseOption (compliant), then import
+# SelectMenuOption + menuOptions mapping that drops fields → WARN trigger.
+MAP_DROPS_FIELDS='import type { BaseOption } from "../Base/base";
+import { SelectMenuOption } from "../SelectMenu/select-menu";
+export interface PickerOption extends BaseOption {
+  id: string;
+}
+export const PeoplePicker = ({ options }: { options: any[] }) => {
+  const menuOptions: SelectMenuOption[] = options.map((o) => ({
+    value: o.id,
+    label: o.name,
+  }));
+  return null;
+};'
+mkdir -p "$COMPONENTS_DIR/PeoplePicker"
+run_hook "$COMPONENTS_DIR/PeoplePicker/people-picker.tsx" "Write" "$MAP_DROPS_FIELDS"
+expect_warn_exit0 "6. menuOptions mapping drops fields → soft WARN" "M30 schema partial-forward"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  echo "Failed:$FAILED_TESTS"
+  exit 1
+fi

package/ds-canonical/hooks/tests/test_enforce_home_charter.sh

@@ -0,0 +1,77 @@
+#!/bin/bash
+# Tests for enforce_home_charter.sh
+#
+# Hook gate:Write 新檔到 8-home classification dirs(.claude/hooks /
+# skills / agents / commands / rules + packages/design-system/src/{components,
+# patterns, tokens})時,verify charter README 存在 + file-name pattern
+# 對齊 dir convention。
+#
+# Scenarios:
+#   1. Non-Write tool → silent pass
+#   2. Write to existing file → silent pass(only NEW files gate)
+#   3. Write outside classification dirs → silent pass
+#   4. Write new file inside classification dir → pass(charter exists)
+
+set -u
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../enforce_home_charter.sh"
+
+[ -x "$HOOK" ] || { echo "FATAL: hook not executable"; exit 1; }
+
+PASS=0; FAIL=0; FAILED=""
+
+run_hook() {
+  local payload="$1"
+  STDOUT=$(echo "$payload" | bash "$HOOK" 2>&1); EXIT=$?
+}
+
+# Test 1: Read tool(non-Write)→ silent pass
+echo "Test 1: non-Write tool → silent pass"
+run_hook '{"tool_name":"Read","tool_input":{"file_path":"/tmp/x"}}'
+if [ "$EXIT" = "0" ] && [ -z "$STDOUT" ]; then
+  echo "  PASS  Test 1 silent pass on Read"; PASS=$((PASS+1))
+else
+  echo "  FAIL  Test 1 (exit=$EXIT, output=$STDOUT)"; FAIL=$((FAIL+1)); FAILED="${FAILED}\n  - Test 1"
+fi
+
+# Test 2: Write to existing file → silent pass(only NEW files gate)
+echo "Test 2: Write to existing file → silent pass"
+TMP=$(mktemp)
+run_hook "{\"tool_name\":\"Write\",\"tool_input\":{\"file_path\":\"$TMP\"}}"
+if [ "$EXIT" = "0" ]; then
+  echo "  PASS  Test 2 silent pass on existing file"; PASS=$((PASS+1))
+else
+  echo "  FAIL  Test 2 (exit=$EXIT, output=$STDOUT)"; FAIL=$((FAIL+1)); FAILED="${FAILED}\n  - Test 2"
+fi
+rm -f "$TMP"
+
+# Test 3: Write new file outside classification dirs → silent pass
+echo "Test 3: Write new file outside classification dirs → silent pass"
+run_hook '{"tool_name":"Write","tool_input":{"file_path":"/tmp/random/new-file.tsx"}}'
+if [ "$EXIT" = "0" ]; then
+  echo "  PASS  Test 3 silent pass on non-classified path"; PASS=$((PASS+1))
+else
+  echo "  FAIL  Test 3 (exit=$EXIT, output=$STDOUT)"; FAIL=$((FAIL+1)); FAILED="${FAILED}\n  - Test 3"
+fi
+
+# Test 4: Write new file inside classification dir(charter exists)→ pass
+echo "Test 4: Write new file in classified dir(charter exists)→ pass"
+TMP_PROJ=$(mktemp -d)
+mkdir -p "$TMP_PROJ/.claude/skills"
+echo "# Skills charter" > "$TMP_PROJ/.claude/skills/README.md"
+CLAUDE_PROJECT_DIR="$TMP_PROJ" run_hook "{\"tool_name\":\"Write\",\"tool_input\":{\"file_path\":\"$TMP_PROJ/.claude/skills/new-skill/SKILL.md\"}}"
+if [ "$EXIT" = "0" ]; then
+  echo "  PASS  Test 4 pass on charter-present dir"; PASS=$((PASS+1))
+else
+  echo "  FAIL  Test 4 (exit=$EXIT, output=$STDOUT)"; FAIL=$((FAIL+1)); FAILED="${FAILED}\n  - Test 4"
+fi
+rm -rf "$TMP_PROJ"
+
+echo ""
+echo "════ Results: $PASS PASS, $FAIL FAIL ════"
+if [ "$FAIL" -gt 0 ]; then
+  echo "Failed:"
+  printf "%b\n" "$FAILED"
+  exit 1
+fi
+exit 0