@qijenchen/design-system 0.1.0-beta.3 → 0.1.0-beta.32

package/ds-canonical/hooks/tests/test_check_main_branch_workbench.sh

@@ -0,0 +1,147 @@
+#!/bin/bash
+# Tests for check_main_branch_workbench.sh(M28 main-as-workbench BLOCKER)
+#
+# Hook 規則:PreToolUse Edit/Write/MultiEdit + 目標 file 為 production code
+# (`packages/design-system/src/**/*.{tsx,ts,css}` OR `src/app/**` OR `src/explorations/**`)
+# + current git branch == main/master + transcript 近 5 user msg 無 branch trigger keyword
+# → exit 2 BLOCKER。
+# Allow:`CLAUDE_BYPASS_MAIN_WORKBENCH=1` / branch != main / out-of-scope path /
+#        trigger keyword(開 branch / 開 分支 / 新 branch / working branch / 在 branch 上做 / on branch)。
+#
+# 測試手法:`CLAUDE_PROJECT_DIR` 指向 fixture git repo(可控 current branch)。
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_main_branch_workbench.sh"
+
+if [ ! -x "$HOOK" ]; then
+  echo "FATAL: hook not executable: $HOOK"
+  exit 1
+fi
+
+TMP_ROOT=$(mktemp -d)
+trap 'rm -rf "$TMP_ROOT"' EXIT
+
+# Build fake git repos:one on main, one on feature branch
+REPO_MAIN="$TMP_ROOT/repo-main"
+REPO_FEAT="$TMP_ROOT/repo-feat"
+
+setup_repo() {
+  local dir="$1"; local branch="$2"
+  mkdir -p "$dir"
+  (
+    cd "$dir"
+    git init -q -b main 2>/dev/null || { git init -q && git checkout -q -b main; }
+    git config user.email test@example.com
+    git config user.name test
+    echo seed > seed.txt
+    git add seed.txt
+    git commit -q -m "seed"
+    if [ "$branch" != "main" ]; then
+      git checkout -q -b "$branch"
+    fi
+  )
+}
+
+setup_repo "$REPO_MAIN" "main"
+setup_repo "$REPO_FEAT" "feature-x"
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+run_hook() {
+  local file_path="$1"; local project_dir="$2"; local transcript="${3:-}"
+  local payload
+  payload=$(jq -n --arg fp "$file_path" \
+    '{tool_name: "Edit", tool_input: {file_path: $fp, new_string: "x"}}')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  CLAUDE_PROJECT_DIR="$project_dir" CLAUDE_TRANSCRIPT_PATH="$transcript" \
+    printf '%s' "$payload" | CLAUDE_PROJECT_DIR="$project_dir" CLAUDE_TRANSCRIPT_PATH="$transcript" \
+    bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_pass_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent, exit=$EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_blocker() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "2" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit 2 + '$needle', got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== check_main_branch_workbench tests ==="
+
+# 1. Non Edit/Write tool → skip (use payload with different tool)
+payload=$(jq -n '{tool_name: "Read", tool_input: {file_path: "/repo/packages/design-system/src/foo.tsx"}}')
+STDOUT=$(mktemp); STDERR=$(mktemp)
+set +e
+CLAUDE_PROJECT_DIR="$REPO_MAIN" printf '%s' "$payload" | CLAUDE_PROJECT_DIR="$REPO_MAIN" bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+EXIT=$?
+set -e
+STDERR_TEXT=$(cat "$STDERR")
+rm -f "$STDOUT" "$STDERR"
+expect_pass_silent "1. non Edit/Write tool → skip"
+
+# 2. Out-of-scope path (random file) → skip
+run_hook "/repo/.claude/foo.md" "$REPO_MAIN"
+expect_pass_silent "2. out-of-scope path (.claude/) → skip"
+
+# 3. Production code path + branch=feature-x → skip
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" "$REPO_FEAT"
+expect_pass_silent "3. on feature branch → skip"
+
+# 4. Production code path + branch=main + no trigger transcript → BLOCKER
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" "$REPO_MAIN"
+expect_blocker "4. main + production code + no trigger → BLOCKER" "MAIN-AS-WORKBENCH BLOCKER"
+
+# 5. CLAUDE_BYPASS_MAIN_WORKBENCH=1 escape → skip
+payload=$(jq -n '{tool_name: "Edit", tool_input: {file_path: "/repo/packages/design-system/src/components/Foo/foo.tsx", new_string: "x"}}')
+STDOUT=$(mktemp); STDERR=$(mktemp)
+set +e
+printf '%s' "$payload" | CLAUDE_PROJECT_DIR="$REPO_MAIN" CLAUDE_BYPASS_MAIN_WORKBENCH=1 bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+EXIT=$?
+set -e
+STDERR_TEXT=$(cat "$STDERR")
+rm -f "$STDOUT" "$STDERR"
+expect_pass_silent "5. CLAUDE_BYPASS_MAIN_WORKBENCH=1 → skip"
+
+# 6. Transcript with branch trigger keyword → skip
+TRANSCRIPT="$TMP_ROOT/transcript.jsonl"
+cat >"$TRANSCRIPT" <<'EOF'
+{"role":"user","content":"我們開 working branch 來做這個 batch"}
+{"role":"assistant","content":"OK"}
+EOF
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" "$REPO_MAIN" "$TRANSCRIPT"
+expect_pass_silent "6. transcript has 'working branch' trigger → skip"
+
+# 7. src/app/** also intercepted on main → BLOCKER
+run_hook "/repo/src/app/page.tsx" "$REPO_MAIN"
+expect_blocker "7. src/app/ on main → BLOCKER" "MAIN-AS-WORKBENCH BLOCKER"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  echo "Failed:$FAILED_TESTS"
+  exit 1
+fi

package/ds-canonical/hooks/tests/test_check_naming_and_abstraction.sh

@@ -0,0 +1,136 @@
+#!/bin/bash
+# Tests for check_naming_and_abstraction.sh — merged 3 sub-rules
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_naming_and_abstraction.sh"
+[ -x "$HOOK" ] || { echo "FATAL: hook not executable"; exit 1; }
+
+PASS=0; FAIL=0; FAILED_TESTS=""
+
+run_hook() {
+  local file_path="$1" content="$2" tool="${3:-Write}"
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  jq -n --arg tool "$tool" --arg fp "$file_path" --arg c "$content" \
+    '{tool_name:$tool, tool_input:{file_path:$fp, content:$c}}' \
+    | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR"); rm -f "$STDOUT" "$STDERR"
+}
+
+expect_exit() {
+  local name="$1" expect="$2" needle="${3:-}"
+  if [ "$EXIT" = "$expect" ] && { [ -z "$needle" ] || echo "$STDERR_TEXT" | grep -qF "$needle"; }; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit $expect${needle:+ + needle '$needle'}, got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== D.1 premature abstraction ==="
+
+# Setup: temp components/ — create Button base so suffix matching can find it
+TMP_DS=$(mktemp -d)
+mkdir -p "$TMP_DS/packages/design-system/src/components/Button"
+echo "// existing base" > "$TMP_DS/packages/design-system/src/components/Button/button.tsx"
+
+# 1. New ButtonOutline without rationale → BLOCK (suffix=Outline, base=Button exists)
+run_hook "$TMP_DS/packages/design-system/src/components/ButtonOutline/button-outline.tsx" '
+import * as React from "react"
+export const ButtonOutline = () => <div />
+' Write
+expect_exit "D.1.1 new ButtonOutline w/o rationale → BLOCK" 2 "premature abstraction"
+
+# 2. New ButtonOutline with rationale comment → silent
+run_hook "$TMP_DS/packages/design-system/src/components/ButtonOutline/button-outline.tsx" '// @separate-component-rationale: 3-test passed; cite Linear / Notion / Stripe — separate components
+import * as React from "react"
+' Write
+expect_exit "D.1.2 with rationale → silent" 0 ""
+
+# 3. New component name not matching any suffix → silent
+run_hook "$TMP_DS/packages/design-system/src/components/Sparkline/sparkline.tsx" '
+export const Sparkline = () => null
+' Write
+expect_exit "D.1.3 no suffix match → silent" 0 ""
+
+# 4. Edit existing file (not Write) → silent
+run_hook "$TMP_DS/packages/design-system/src/components/Button/button.tsx" 'edit' Edit
+expect_exit "D.1.4 edit tool → silent" 0 ""
+
+rm -rf "$TMP_DS"
+
+echo ""
+echo "=== D.2 internal namespace consistency ==="
+
+# Setup: temp dir with conflicting sibling stories
+TMP_NS=$(mktemp -d)
+mkdir -p "$TMP_NS/SelectionControl"
+cat >"$TMP_NS/SelectionControl/sibling.stories.tsx" <<'EOF'
+const meta = { title: 'Design System/Internal/SelectionControl' }
+export default meta
+EOF
+
+# 5. New stories file with Components ns + sibling has Internal → BLOCK
+run_hook "$TMP_NS/SelectionControl/new.stories.tsx" "
+const meta = { title: 'Design System/Components/SelectionControl/設計原則' }
+export default meta
+" Write
+expect_exit "D.2.1 sibling ns mismatch → BLOCK" 2 "namespace BLOCKER"
+
+# 6. New stories with consistent Internal ns → silent
+run_hook "$TMP_NS/SelectionControl/aligned.stories.tsx" "
+const meta = { title: 'Design System/Internal/SelectionControl/Foo' }
+export default meta
+" Write
+expect_exit "D.2.2 consistent ns → silent" 0 ""
+
+rm -rf "$TMP_NS"
+
+# 7. Story without title → skip
+run_hook "/r/packages/design-system/src/components/Foo/foo.stories.tsx" '
+const meta = { title: "Other/Foo" }
+' Write
+expect_exit "D.2.3 no DS title → silent" 0 ""
+
+echo ""
+echo "=== D.3 primitive color var in tsx ==="
+
+# 8. tsx with var(--color-neutral-5) → WARN stderr
+run_hook "/r/packages/design-system/src/components/Foo/foo.tsx" '
+const cls = "border-[var(--color-neutral-5)]"
+' Write
+expect_exit "D.3.1 primitive var color → WARN stderr" 0 "primitive color var"
+
+# 9. tsx with semantic alias → silent
+run_hook "/r/packages/design-system/src/components/Foo/foo.tsx" '
+const cls = "border-border"
+' Write
+expect_exit "D.3.2 semantic alias → silent" 0 ""
+
+# 10. Tag scope skip → silent
+run_hook "/r/packages/design-system/src/components/Tag/tag.tsx" '
+const cls = "var(--color-blue-3)"
+' Write
+expect_exit "D.3.3 Tag scope skip → silent" 0 ""
+
+# 11. allowlist (line-level) → silent
+run_hook "/r/packages/design-system/src/components/Foo/foo.tsx" '
+const cls = "border-[var(--color-neutral-5)] // @primitive-color-allow: legacy migration"
+' Write
+expect_exit "D.3.4 allowlist line → silent" 0 ""
+
+# 12. blanket allowlist → silent
+run_hook "/r/packages/design-system/src/components/Foo/foo.tsx" '// primitive-color-allow-blanket
+const cls = "var(--color-neutral-5)"
+' Write
+expect_exit "D.3.5 blanket allowlist → silent" 0 ""
+
+echo ""
+echo "═══ Results: $PASS PASS, $FAIL FAIL ═══"
+[ "$FAIL" -gt 0 ] && { printf "Failed:%b\n" "$FAILED_TESTS"; exit 1; }
+exit 0

package/ds-canonical/hooks/tests/test_check_opacity_token_usage.sh

@@ -0,0 +1,110 @@
+#!/bin/bash
+# Tests for check_opacity_token_usage.sh(2026-05-06 v14.5.2)
+#
+# Hook 規則:*.tsx 寫 raw `opacity-{N}`(N 是數字非 0/100)→ soft warn 用 DS opacity token。
+# 允許白名單:opacity-0 / opacity-100 / opacity-disabled。
+# 排除:.stories.tsx / .test.* / .spec.tsx / tokens/opacity/*。
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_opacity_token_usage.sh"
+
+if [ ! -x "$HOOK" ]; then
+  echo "FATAL: hook not executable: $HOOK"
+  exit 1
+fi
+
+PASS=0
+FAIL=0
+FAILED_TESTS=""
+
+run_hook() {
+  local file_path="$1"
+  local content="$2"
+  local payload
+  payload=$(jq -n --arg fp "$file_path" --arg c "$content" \
+    '{tool_name: "Write", tool_input: {file_path: $fp, content: $c}}')
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  printf '%s' "$payload" | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR")
+  rm -f "$STDOUT" "$STDERR"
+}
+
+expect_pass_silent() {
+  local name="$1"
+  if [ "$EXIT" = "0" ] && [ -z "$STDERR_TEXT" ]; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected silent, exit=$EXIT, stderr non-empty=$([ -n "$STDERR_TEXT" ] && echo yes))"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+expect_warn() {
+  local name="$1"; local needle="$2"
+  if [ "$EXIT" = "0" ] && echo "$STDERR_TEXT" | grep -qF "$needle"; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected warn '$needle', got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== check_opacity_token_usage tests ==="
+
+# 1. raw opacity-30 → warn
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '
+className="bg-surface opacity-30"
+'
+expect_warn "1. opacity-30 raw → warn" "M23 / Dim 47 violation"
+
+# 2. raw opacity-50 → warn
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '
+className="opacity-50"
+'
+expect_warn "2. opacity-50 raw → warn" "M23 / Dim 47 violation"
+
+# 3. opacity-disabled token utility → silent
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '
+className="opacity-disabled pointer-events-none"
+'
+expect_pass_silent "3. opacity-disabled token → silent"
+
+# 4. opacity-0(visibility toggle)→ silent
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '
+className="opacity-0 group-hover:opacity-100"
+'
+expect_pass_silent "4. opacity-0 / opacity-100 visibility → silent"
+
+# 5. story file → skip
+run_hook "/repo/packages/design-system/src/components/Foo/foo.stories.tsx" '
+className="opacity-30 opacity-50"
+'
+expect_pass_silent "5. .stories.tsx → skip"
+
+# 6. token spec internal → skip
+run_hook "/repo/packages/design-system/src/tokens/opacity/opacity.css" '
+opacity: 0.30;
+'
+expect_pass_silent "6. tokens/opacity/* → skip"
+
+# 7. multiple raw opacity values → warn(catch all)
+run_hook "/repo/packages/design-system/src/components/Foo/foo.tsx" '
+const a = "opacity-25"
+const b = "opacity-75"
+'
+expect_warn "7. multi opacity-N values → warn" "opacity-25"
+
+echo ""
+echo "=== Summary ==="
+echo "Passed: $PASS / $((PASS + FAIL))"
+if [ "$FAIL" -gt 0 ]; then
+  echo "Failed:$FAILED_TESTS"
+  exit 1
+fi

package/ds-canonical/hooks/tests/test_check_overlay_handcraft.sh

@@ -0,0 +1,126 @@
+#!/bin/bash
+# Tests for check_overlay_handcraft.sh
+# Focus: Check 6(2026-05-01)— overlay body 重新引入 stripped-padding boolean variant 攔阻
+set -u
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../lib/_overlay_handcraft.sh"
+[ -x "$HOOK" ] || { echo "FATAL: hook not executable"; exit 1; }
+PASS=0; FAIL=0
+
+setup() { TMP=$(mktemp -d); mkdir -p "$TMP/.claude/hooks"; echo 'log_hook_fire(){ :; }' > "$TMP/.claude/hooks/_log-fire.sh"; }
+teardown() { rm -rf "$TMP"; }
+
+run() {
+  local fp="$1"
+  STDOUT=$(echo "{\"tool_input\":{\"file_path\":\"$fp\"}}" | bash "$HOOK" 2>&1)
+  EXIT=$?
+}
+
+# Test 1: out-of-scope file(non-overlay path)→ silent
+echo "Test 1: out-of-scope path → silent for Check 6"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Button"
+cat > "$TMP/packages/design-system/src/components/Button/button.tsx" <<'EOF'
+interface ButtonProps { flush?: boolean }
+EOF
+run "$TMP/packages/design-system/src/components/Button/button.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  FAIL: false positive on Button"; FAIL=$((FAIL+1)); } || { echo "  PASS"; PASS=$((PASS+1)); }
+teardown
+
+# Test 2: DialogBody re-introducing flush?: boolean → flagged
+echo "Test 2: DialogBody flush?: boolean → flagged"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Dialog"
+cat > "$TMP/packages/design-system/src/components/Dialog/dialog.tsx" <<'EOF'
+interface DialogBodyProps {
+  flush?: boolean
+}
+EOF
+run "$TMP/packages/design-system/src/components/Dialog/dialog.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 3: SheetBody flush = false destructure default → flagged
+echo "Test 3: SheetBody flush = false destructure → flagged"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Sheet"
+cat > "$TMP/packages/design-system/src/components/Sheet/sheet.tsx" <<'EOF'
+const SheetBody = ({ flush = false }) => null
+interface X { flush?: boolean }
+EOF
+run "$TMP/packages/design-system/src/components/Sheet/sheet.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 4: PopoverBody naked?: boolean(equivalent rename)→ flagged
+echo "Test 4: PopoverBody naked?: boolean → flagged"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Popover"
+cat > "$TMP/packages/design-system/src/components/Popover/popover.tsx" <<'EOF'
+interface PopoverBodyProps { naked?: boolean }
+EOF
+run "$TMP/packages/design-system/src/components/Popover/popover.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 5: bare?: boolean(equivalent rename)→ flagged
+echo "Test 5: DialogBody bare?: boolean → flagged"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Dialog"
+cat > "$TMP/packages/design-system/src/components/Dialog/dialog.tsx" <<'EOF'
+interface Y { bare?: boolean }
+EOF
+run "$TMP/packages/design-system/src/components/Dialog/dialog.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 6: noPadding?: boolean(equivalent rename)→ flagged
+echo "Test 6: SheetBody noPadding?: boolean → flagged"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Sheet"
+cat > "$TMP/packages/design-system/src/components/Sheet/sheet.tsx" <<'EOF'
+interface Z { noPadding?: boolean }
+EOF
+run "$TMP/packages/design-system/src/components/Sheet/sheet.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  PASS"; PASS=$((PASS+1)); } || { echo "  FAIL: $STDOUT"; FAIL=$((FAIL+1)); }
+teardown
+
+# Test 7: stories.tsx 內出現 flush?: boolean → silent(stories scope skip)
+echo "Test 7: stories.tsx flush?: boolean → skipped(out-of-scope)"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Dialog"
+cat > "$TMP/packages/design-system/src/components/Dialog/dialog.stories.tsx" <<'EOF'
+interface ExampleProps { flush?: boolean }
+EOF
+run "$TMP/packages/design-system/src/components/Dialog/dialog.stories.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  FAIL: false positive on stories"; FAIL=$((FAIL+1)); } || { echo "  PASS"; PASS=$((PASS+1)); }
+teardown
+
+# Test 8: allowlist comment escape hatch → silent
+echo "Test 8: allowlist escape hatch → silent"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Dialog"
+cat > "$TMP/packages/design-system/src/components/Dialog/dialog.tsx" <<'EOF'
+// overlay-body-stripped-variant-allow: 已對照 Polaris/Material/X 三家,multi-row 已驗證 hold
+interface DialogBodyProps { flush?: boolean }
+EOF
+run "$TMP/packages/design-system/src/components/Dialog/dialog.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  FAIL: allowlist not honored"; FAIL=$((FAIL+1)); } || { echo "  PASS"; PASS=$((PASS+1)); }
+teardown
+
+# Test 9: clean DialogBody(post-2026-05-01 canonical)→ silent
+echo "Test 9: clean DialogBody(no flush variant)→ silent"
+setup
+mkdir -p "$TMP/packages/design-system/src/components/Dialog"
+cat > "$TMP/packages/design-system/src/components/Dialog/dialog.tsx" <<'EOF'
+const DialogBody = React.forwardRef<HTMLDivElement, React.ComponentPropsWithoutRef<typeof ScrollArea>>(
+  ({ className, children, ...props }, ref) => null
+)
+EOF
+run "$TMP/packages/design-system/src/components/Dialog/dialog.tsx"
+echo "$STDOUT" | grep -q "stripped-padding boolean variant" && { echo "  FAIL: false positive on clean canonical"; FAIL=$((FAIL+1)); } || { echo "  PASS"; PASS=$((PASS+1)); }
+teardown
+
+echo ""
+echo "Summary: $PASS passed / $FAIL failed"
+[ "$FAIL" -eq 0 ] || exit 1

package/ds-canonical/hooks/tests/test_check_pattern_invariants.sh

@@ -0,0 +1,148 @@
+#!/bin/bash
+# Tests for check_pattern_invariants.sh — merged 4 sub-rules(C.1-C.4)
+
+set -u
+
+SCRIPT_DIR="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
+HOOK="$SCRIPT_DIR/../check_pattern_invariants.sh"
+[ -x "$HOOK" ] || { echo "FATAL: hook not executable"; exit 1; }
+
+PASS=0; FAIL=0; FAILED_TESTS=""
+
+run_hook() {
+  local file_path="$1" content="$2"
+  STDOUT=$(mktemp); STDERR=$(mktemp)
+  set +e
+  jq -n --arg fp "$file_path" --arg c "$content" \
+    '{tool_name:"Write", tool_input:{file_path:$fp, content:$c}}' \
+    | bash "$HOOK" >"$STDOUT" 2>"$STDERR"
+  EXIT=$?
+  set -e
+  STDERR_TEXT=$(cat "$STDERR"); rm -f "$STDOUT" "$STDERR"
+}
+
+expect_exit() {
+  local name="$1" expect="$2" needle="${3:-}"
+  if [ "$EXIT" = "$expect" ] && { [ -z "$needle" ] || echo "$STDERR_TEXT" | grep -qF "$needle"; }; then
+    echo "  PASS  $name"; PASS=$((PASS+1))
+  else
+    echo "  FAIL  $name (expected exit $expect${needle:+ + needle '$needle'}, got exit $EXIT)"
+    echo "  --- stderr ---"; echo "$STDERR_TEXT" | sed 's/^/    /'; echo "  --- end ---"
+    FAIL=$((FAIL+1)); FAILED_TESTS="${FAILED_TESTS}\n  - $name"
+  fi
+}
+
+echo "=== C.1 overlay panel scroll chain ==="
+
+# 1. SurfaceBody + wrapper without flex flex-col h-full → WARN stderr (exit 0)
+run_hook "/r/src/app/foo.tsx" '
+function Panel() {
+  return (
+    <div className="w-[640px]">
+      <SurfaceHeader>x</SurfaceHeader>
+      <SurfaceBody>y</SurfaceBody>
+    </div>
+  )
+}
+'
+expect_exit "C.1.1 SurfaceBody w/o flex chain → WARN stderr" 0 "overlay scroll chain"
+
+# 2. SurfaceBody + correct flex chain → silent
+run_hook "/r/src/app/foo.tsx" '
+function Panel() {
+  return (
+    <div className="w-[640px] flex flex-col h-full min-h-0">
+      <SurfaceBody>y</SurfaceBody>
+    </div>
+  )
+}
+'
+expect_exit "C.1.2 SurfaceBody w/ flex chain → silent" 0 ""
+
+# 3. allowlist → silent
+run_hook "/r/src/app/foo.tsx" '
+// @scroll-chain-allow: fixed widget no scroll
+function Panel() { return <div className="w-[640px]"><SurfaceBody/></div> }
+'
+expect_exit "C.1.3 allowlist → silent" 0 ""
+
+echo ""
+echo "=== C.2 inline-action canonical gap ==="
+
+# 4. components/ ItemInlineAction + gap-3 → WARN stderr
+run_hook "/r/packages/design-system/src/components/Foo/foo.tsx" '
+<div className="flex gap-3"><ItemInlineAction /></div>
+'
+expect_exit "C.2.1 gap-3 inline-action → WARN" 0 "inline-action gap"
+
+# 5. components/ ItemInlineAction + gap-2 → silent
+run_hook "/r/packages/design-system/src/components/Foo/foo.tsx" '
+<div className="flex gap-2"><ItemInlineAction /></div>
+'
+expect_exit "C.2.2 gap-2 inline-action → silent" 0 ""
+
+# 6. SSOT host item-anatomy → skip
+run_hook "/r/packages/design-system/src/patterns/element-anatomy/item-anatomy.tsx" '
+<div className="flex gap-3"><ItemInlineAction /></div>
+'
+expect_exit "C.2.3 SSOT host skip → silent" 0 ""
+
+echo ""
+echo "=== C.3 primitive wrapper padding (BLOCK) ==="
+
+# 7. <div p-2><DateGrid /></div> → BLOCK
+run_hook "/r/src/app/foo.tsx" '
+function Foo() {
+  return <div className="p-2"><DateGrid /></div>
+}
+'
+expect_exit "C.3.1 p-2 wrapping DateGrid → BLOCK" 2 "primitive wrapper padding"
+
+# 8. <DateGrid /> direct → silent
+run_hook "/r/src/app/foo.tsx" '
+function Foo() { return <DateGrid /> }
+'
+expect_exit "C.3.2 DateGrid direct → silent" 0 ""
+
+# 9. file-level allowlist (first 5 lines) → silent
+run_hook "/r/src/app/foo.tsx" '// @primitive-padding-allow: legacy migration
+
+function Foo() {
+  return <div className="p-2"><DateGrid /></div>
+}
+'
+expect_exit "C.3.3 file allowlist → silent" 0 ""
+
+echo ""
+echo "=== C.4 row slot handcraft (BLOCK) ==="
+
+# 10. components/ self-coded h-[1lh] shrink-0 flex items-center → BLOCK
+run_hook "/r/packages/design-system/src/components/Bad/bad.tsx" '
+function F() { return <span className="h-[1lh] shrink-0 flex items-center"><Icon/></span> }
+'
+expect_exit "C.4.1 row slot handcraft → BLOCK" 2 "row slot handcraft"
+
+# 11. SSOT host item-anatomy → skip
+run_hook "/r/packages/design-system/src/patterns/element-anatomy/item-anatomy.tsx" '
+const x = "h-[1lh] shrink-0 flex items-center"
+'
+expect_exit "C.4.2 item-anatomy SSOT skip → silent" 0 ""
+
+# 12. Using ItemPrefix → silent
+run_hook "/r/packages/design-system/src/components/Good/good.tsx" '
+import { ItemPrefix } from "@/design-system/patterns/element-anatomy/item-anatomy"
+function F() { return <ItemPrefix><Icon/></ItemPrefix> }
+'
+expect_exit "C.4.3 ItemPrefix consume → silent" 0 ""
+
+# 13. allowlist → silent
+run_hook "/r/packages/design-system/src/components/Edge/edge.tsx" '
+// @row-slot-handcraft-allow: forced width
+function F() { return <span className="h-[1lh] shrink-0 flex items-center"><Icon/></span> }
+'
+expect_exit "C.4.4 row slot allowlist → silent" 0 ""
+
+echo ""
+echo "═══ Results: $PASS PASS, $FAIL FAIL ═══"
+[ "$FAIL" -gt 0 ] && { printf "Failed:%b\n" "$FAILED_TESTS"; exit 1; }
+exit 0