@probelabs/visor 0.1.79 → 0.1.81

package/dist/sdk/sdk.js

@@ -326,7 +326,9 @@ var init_session_registry = __esm({
     SessionRegistry = class _SessionRegistry {
       static instance;
       sessions = /* @__PURE__ */ new Map();
+      exitHandlerRegistered = false;
       constructor() {
+        this.registerExitHandlers();
       }
       /**
        * Get the singleton instance of SessionRegistry
@@ -360,7 +362,15 @@ var init_session_registry = __esm({
       unregisterSession(sessionId) {
         if (this.sessions.has(sessionId)) {
           console.error(`\u{1F5D1}\uFE0F  Unregistering AI session: ${sessionId}`);
+          const agent = this.sessions.get(sessionId);
           this.sessions.delete(sessionId);
+          if (agent && typeof agent.cleanup === "function") {
+            try {
+              agent.cleanup();
+            } catch (error) {
+              console.error(`\u26A0\uFE0F  Warning: Failed to cleanup ProbeAgent: ${error}`);
+            }
+          }
         }
       }
       /**
@@ -368,6 +378,14 @@ var init_session_registry = __esm({
        */
       clearAllSessions() {
         console.error(`\u{1F9F9} Clearing all AI sessions (${this.sessions.size} sessions)`);
+        for (const [, agent] of this.sessions.entries()) {
+          if (agent && typeof agent.cleanup === "function") {
+            try {
+              agent.cleanup();
+            } catch {
+            }
+          }
+        }
         this.sessions.clear();
       }
       /**
@@ -382,6 +400,44 @@ var init_session_registry = __esm({
       hasSession(sessionId) {
         return this.sessions.has(sessionId);
       }
+      /**
+       * Register process exit handlers to cleanup sessions on exit
+       */
+      registerExitHandlers() {
+        if (this.exitHandlerRegistered) {
+          return;
+        }
+        const cleanupAndExit = (signal) => {
+          if (this.sessions.size > 0) {
+            console.error(`
+\u{1F9F9} [${signal}] Cleaning up ${this.sessions.size} active AI sessions...`);
+            this.clearAllSessions();
+          }
+        };
+        process.on("exit", () => {
+          if (this.sessions.size > 0) {
+            console.error(`\u{1F9F9} [exit] Cleaning up ${this.sessions.size} active AI sessions...`);
+            for (const [, agent] of this.sessions.entries()) {
+              if (agent && typeof agent.cleanup === "function") {
+                try {
+                  agent.cleanup();
+                } catch {
+                }
+              }
+            }
+            this.sessions.clear();
+          }
+        });
+        process.on("SIGINT", () => {
+          cleanupAndExit("SIGINT");
+          process.exit(0);
+        });
+        process.on("SIGTERM", () => {
+          cleanupAndExit("SIGTERM");
+          process.exit(0);
+        });
+        this.exitHandlerRegistered = true;
+      }
     };
   }
 });
@@ -2283,20 +2339,6 @@ var init_liquid_extensions = __esm({
   }
 });
 
-// src/providers/claude-code-types.ts
-async function safeImport(moduleName) {
-  try {
-    return await import(moduleName);
-  } catch {
-    return null;
-  }
-}
-var init_claude_code_types = __esm({
-  "src/providers/claude-code-types.ts"() {
-    "use strict";
-  }
-});
-
 // src/providers/ai-check-provider.ts
 var import_promises2, import_path2, AICheckProvider;
 var init_ai_check_provider = __esm({
@@ -2309,7 +2351,6 @@ var init_ai_check_provider = __esm({
     init_liquid_extensions();
     import_promises2 = __toESM(require("fs/promises"));
     import_path2 = __toESM(require("path"));
-    init_claude_code_types();
     AICheckProvider = class extends CheckProvider {
       aiReviewService;
       liquidEngine;
@@ -2587,54 +2628,6 @@ var init_ai_check_provider = __esm({
           );
         }
       }
-      /**
-       * Setup MCP tools based on AI configuration
-       */
-      async setupMcpTools(aiConfig) {
-        const tools = [];
-        if (aiConfig.mcpServers) {
-          try {
-            const mcpModule = await safeImport("@modelcontextprotocol/sdk");
-            if (!mcpModule) {
-              console.warn("@modelcontextprotocol/sdk package not found. MCP servers disabled.");
-              return tools;
-            }
-            const createSdkMcpServer = mcpModule.createSdkMcpServer || mcpModule.default?.createSdkMcpServer;
-            if (typeof createSdkMcpServer === "function") {
-              for (const [serverName, serverConfig] of Object.entries(aiConfig.mcpServers)) {
-                try {
-                  const server = await createSdkMcpServer({
-                    name: serverName,
-                    command: serverConfig.command,
-                    args: serverConfig.args || [],
-                    env: { ...process.env, ...serverConfig.env }
-                  });
-                  const serverTools = await server.listTools();
-                  tools.push(
-                    ...serverTools.map((tool) => ({
-                      name: tool.name,
-                      server: serverName
-                    }))
-                  );
-                } catch (serverError) {
-                  console.warn(
-                    `Failed to setup MCP server ${serverName}: ${serverError instanceof Error ? serverError.message : "Unknown error"}`
-                  );
-                }
-              }
-            } else {
-              console.warn(
-                "createSdkMcpServer function not found in @modelcontextprotocol/sdk. MCP servers disabled."
-              );
-            }
-          } catch (error) {
-            console.warn(
-              `Failed to import MCP SDK: ${error instanceof Error ? error.message : "Unknown error"}. MCP servers disabled.`
-            );
-          }
-        }
-        return tools;
-      }
       async execute(prInfo, config, _dependencyResults, sessionInfo) {
         if (config.env) {
           const result = EnvironmentResolver.withTemporaryEnv(config.env, () => {
@@ -2691,11 +2684,9 @@ var init_ai_check_provider = __esm({
         }
         if (Object.keys(mcpServers).length > 0) {
           aiConfig.mcpServers = mcpServers;
-          const mcpConfig = { mcpServers };
-          const mcpTools = await this.setupMcpTools(mcpConfig);
           if (aiConfig.debug) {
             console.error(
-              `\u{1F527} Debug: AI check MCP configured with ${Object.keys(mcpServers).length} servers; discovered ${mcpTools.length} tools`
+              `\u{1F527} Debug: AI check MCP configured with ${Object.keys(mcpServers).length} servers`
             );
           }
         }
@@ -3566,6 +3557,20 @@ var init_log_check_provider = __esm({
   }
 });
 
+// src/providers/claude-code-types.ts
+async function safeImport(moduleName) {
+  try {
+    return await import(moduleName);
+  } catch {
+    return null;
+  }
+}
+var init_claude_code_types = __esm({
+  "src/providers/claude-code-types.ts"() {
+    "use strict";
+  }
+});
+
 // src/providers/claude-code-check-provider.ts
 function isClaudeCodeConstructor(value) {
   return typeof value === "function";
@@ -3679,59 +3684,6 @@ var init_claude_code_check_provider = __esm({
           );
         }
       }
-      /**
-       * Setup MCP tools based on configuration
-       */
-      async setupMcpTools(config) {
-        const tools = [];
-        if (config.allowedTools) {
-          for (const toolName of config.allowedTools) {
-            tools.push({ name: toolName });
-          }
-        }
-        if (config.mcpServers) {
-          try {
-            const mcpModule = await safeImport("@modelcontextprotocol/sdk");
-            if (!mcpModule) {
-              console.warn("@modelcontextprotocol/sdk package not found. MCP servers disabled.");
-              return tools;
-            }
-            const createSdkMcpServer = mcpModule.createSdkMcpServer || mcpModule.default?.createSdkMcpServer;
-            if (typeof createSdkMcpServer === "function") {
-              for (const [serverName, serverConfig] of Object.entries(config.mcpServers)) {
-                try {
-                  const server = await createSdkMcpServer({
-                    name: serverName,
-                    command: serverConfig.command,
-                    args: serverConfig.args || [],
-                    env: { ...process.env, ...serverConfig.env }
-                  });
-                  const serverTools = await server.listTools();
-                  tools.push(
-                    ...serverTools.map((tool) => ({
-                      name: tool.name,
-                      server: serverName
-                    }))
-                  );
-                } catch (serverError) {
-                  console.warn(
-                    `Failed to setup MCP server ${serverName}: ${serverError instanceof Error ? serverError.message : "Unknown error"}`
-                  );
-                }
-              }
-            } else {
-              console.warn(
-                "createSdkMcpServer function not found in @modelcontextprotocol/sdk. MCP servers disabled."
-              );
-            }
-          } catch (error) {
-            console.warn(
-              `Failed to import MCP SDK: ${error instanceof Error ? error.message : "Unknown error"}. MCP servers disabled.`
-            );
-          }
-        }
-        return tools;
-      }
       /**
        * Group files by their file extension for template context
        */
@@ -3962,14 +3914,18 @@ var init_claude_code_check_provider = __esm({
         const startTime = Date.now();
         try {
           const client = await this.initializeClaudeCodeClient();
-          const tools = await this.setupMcpTools(claudeCodeConfig);
           const query = {
             query: processedPrompt,
-            tools: tools.length > 0 ? tools : void 0,
             maxTurns: claudeCodeConfig.maxTurns || 5,
             systemPrompt: claudeCodeConfig.systemPrompt,
             subagent: claudeCodeConfig.subagent
           };
+          if (claudeCodeConfig.allowedTools && claudeCodeConfig.allowedTools.length > 0) {
+            query.tools = claudeCodeConfig.allowedTools.map((name) => ({ name }));
+          }
+          if (claudeCodeConfig.mcpServers && Object.keys(claudeCodeConfig.mcpServers).length > 0) {
+            query.mcpServers = claudeCodeConfig.mcpServers;
+          }
           let response;
           if (sessionInfo?.reuseSession && sessionInfo.parentSessionId) {
             response = await client.query({
@@ -3997,8 +3953,7 @@ var init_claude_code_check_provider = __esm({
             // Claude Code specific debug info
             sessionId: response.session_id,
             turnCount: response.turn_count,
-            usage: response.usage,
-            toolsUsed: tools.map((t) => t.name)
+            usage: response.usage
           };
           const suppressionEnabled = config.suppressionEnabled !== false;
           const issueFilter = new IssueFilter(suppressionEnabled);
@@ -4173,7 +4128,19 @@ var init_command_check_provider = __esm({
             const parsed = JSON.parse(rawOutput);
             output = parsed;
           } catch {
-            output = rawOutput;
+            const extracted2 = this.extractJsonFromEnd(rawOutput);
+            if (extracted2) {
+              try {
+                output = JSON.parse(extracted2);
+                logger.debug(
+                  `\u{1F527} Debug: Extracted and parsed JSON from end of output (${extracted2.length} chars from ${rawOutput.length} total)`
+                );
+              } catch {
+                output = rawOutput;
+              }
+            } else {
+              output = rawOutput;
+            }
           }
           let finalOutput = output;
           if (transform) {
@@ -4392,6 +4359,7 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
        *  - If it's a JSON string, expose parsed properties via Proxy (e.g., value.key)
        *  - When coerced to string (toString/valueOf/Symbol.toPrimitive), return the original raw string
        *  - If parsing fails or value is not a string, return the value unchanged
+       *  - Attempts to extract JSON from the end of the output if full parse fails
        */
       makeJsonSmart(value) {
         if (typeof value !== "string") {
@@ -4402,7 +4370,19 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
         try {
           parsed = JSON.parse(raw);
         } catch {
-          return raw;
+          const jsonMatch = this.extractJsonFromEnd(raw);
+          if (jsonMatch) {
+            try {
+              parsed = JSON.parse(jsonMatch);
+              logger.debug(
+                `\u{1F527} Debug: Extracted JSON from end of output (${jsonMatch.length} chars from ${raw.length} total)`
+              );
+            } catch {
+              return raw;
+            }
+          } else {
+            return raw;
+          }
         }
         const boxed = new String(raw);
         const handler = {
@@ -4451,6 +4431,24 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
         };
         return new Proxy(boxed, handler);
       }
+      /**
+       * Extract JSON from the end of a string that may contain logs/debug output
+       * Looks for the last occurrence of { or [ and tries to parse from there
+       */
+      extractJsonFromEnd(text) {
+        const lines = text.split("\n");
+        for (let i = lines.length - 1; i >= 0; i--) {
+          const trimmed = lines[i].trim();
+          if (trimmed.startsWith("{") || trimmed.startsWith("[")) {
+            const candidate = lines.slice(i).join("\n");
+            const trimmedCandidate = candidate.trim();
+            if (trimmedCandidate.startsWith("{") && trimmedCandidate.endsWith("}") || trimmedCandidate.startsWith("[") && trimmedCandidate.endsWith("]")) {
+              return trimmedCandidate;
+            }
+          }
+        }
+        return null;
+      }
       /**
        * Recursively apply JSON-smart wrapper to outputs object values
        */
@@ -7257,11 +7255,15 @@ ${expr}
               for (const depId of directDeps) {
                 const depRes = results.get(depId);
                 if (!depRes) continue;
-                const hasFatalCommandFailure = (depRes.issues || []).some((issue) => {
+                const wasSkipped = (depRes.issues || []).some((issue) => {
                   const id = issue.ruleId || "";
-                  return id.endsWith("/command/execution_error") || id.endsWith("/command/transform_js_error") || id.endsWith("/command/transform_error");
+                  return id.endsWith("/__skipped");
                 });
-                if (hasFatalCommandFailure) failedDeps.push(depId);
+                const hasFatalFailure = (depRes.issues || []).some((issue) => {
+                  const id = issue.ruleId || "";
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error");
+                });
+                if (wasSkipped || hasFatalFailure) failedDeps.push(depId);
               }
               if (failedDeps.length > 0) {
                 this.recordSkip(checkName, "dependency_failed");
@@ -7327,7 +7329,9 @@ ${expr}
                     `\u{1F504} Debug: Check "${checkName}" depends on forEach check "${forEachParentName}", executing ${forEachItems.length} times`
                   );
                 }
-                logger.info(`  Processing ${forEachItems.length} items...`);
+                logger.info(
+                  `  forEach: processing ${forEachItems.length} items from "${forEachParentName}"...`
+                );
                 const allIssues = [];
                 const allOutputs = [];
                 const aggregatedContents = [];
@@ -7404,11 +7408,16 @@ ${expr}
                       parent: forEachParentName
                     }
                   );
+                  const hadFatalError = (itemResult.issues || []).some((issue) => {
+                    const id = issue.ruleId || "";
+                    return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+                  });
                   const iterationDuration = (Date.now() - iterationStart) / 1e3;
                   this.recordIterationComplete(
                     checkName,
                     iterationStart,
-                    true,
+                    !hadFatalError,
+                    // Success if no fatal errors
                     itemResult.issues || [],
                     itemResult.output
                   );
@@ -7433,7 +7442,22 @@ ${expr}
                 );
                 for (const result of forEachResults) {
                   if (result.status === "rejected") {
-                    throw result.reason;
+                    const error = result.reason;
+                    const errorMessage = error instanceof Error ? error.message : String(error);
+                    allIssues.push({
+                      ruleId: `${checkName}/forEach/iteration_error`,
+                      severity: "error",
+                      category: "logic",
+                      message: `forEach iteration failed: ${errorMessage}`,
+                      file: "",
+                      line: 0
+                    });
+                    if (debug) {
+                      log2(
+                        `\u{1F504} Debug: forEach iteration for check "${checkName}" failed: ${errorMessage}`
+                      );
+                    }
+                    continue;
                   }
                   if (result.value.skipped) {
                     continue;
@@ -7501,10 +7525,15 @@ ${expr}
                   debug,
                   results
                 );
+                const hadFatalError = (finalResult.issues || []).some((issue) => {
+                  const id = issue.ruleId || "";
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+                });
                 this.recordIterationComplete(
                   checkName,
                   checkStartTime,
-                  true,
+                  !hadFatalError,
+                  // Success if no fatal errors
                   finalResult.issues || [],
                   finalResult.output
                 );
@@ -7592,8 +7621,20 @@ ${expr}
             if (result.status === "fulfilled" && result.value.result && !result.value.error) {
               if (result.value.skipped) {
                 if (debug) {
-                  log2(`\u{1F527} Debug: Not storing result for skipped check "${checkName}"`);
+                  log2(`\u{1F527} Debug: Storing skip marker for skipped check "${checkName}"`);
                 }
+                results.set(checkName, {
+                  issues: [
+                    {
+                      ruleId: `${checkName}/__skipped`,
+                      severity: "info",
+                      category: "logic",
+                      message: "Check was skipped",
+                      file: "",
+                      line: 0
+                    }
+                  ]
+                });
                 continue;
               }
               const reviewResult = result.value.result;
@@ -7618,6 +7659,7 @@ ${expr}
                 } else {
                   normalizedOutput = [rawOutput];
                 }
+                logger.info(`  Found ${normalizedOutput.length} items for forEach iteration`);
                 try {
                   const preview = JSON.stringify(normalizedOutput);
                   logger.debug(
@@ -7676,14 +7718,6 @@ ${expr}
             }
           }
         }
-        const executionStatistics = this.buildExecutionStatistics();
-        if (logFn === console.log) {
-          this.logExecutionSummary(executionStatistics);
-        }
-        if (shouldStopExecution) {
-          logger.info("");
-          logger.warn(`\u26A0\uFE0F  Execution stopped early due to fail-fast`);
-        }
         if (debug) {
           if (shouldStopExecution) {
             log2(
@@ -7704,6 +7738,14 @@ ${expr}
             }
           }
         }
+        const executionStatistics = this.buildExecutionStatistics();
+        if (logFn === console.log) {
+          this.logExecutionSummary(executionStatistics);
+        }
+        if (shouldStopExecution) {
+          logger.info("");
+          logger.warn(`\u26A0\uFE0F  Execution stopped early due to fail-fast`);
+        }
         return this.aggregateDependencyAwareResults(
           results,
           dependencyGraph,
@@ -7922,7 +7964,10 @@ ${expr}
                 `\u2705 Check "${checkName}" completed: ${(result.issues || []).length} issues found (level ${executionGroup.level})`
               );
             }
-            aggregatedIssues.push(...result.issues || []);
+            const nonInternalIssues = (result.issues || []).filter(
+              (issue) => !issue.ruleId?.endsWith("/__skipped")
+            );
+            aggregatedIssues.push(...nonInternalIssues);
             const resultSummary = result;
             const resultContent = resultSummary.content;
             if (typeof resultContent === "string" && resultContent.trim()) {