@probelabs/visor 0.1.79 → 0.1.81

package/dist/providers/claude-code-check-provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"claude-code-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/claude-code-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAqB5C;;GAEG;AACH,qBAAa,8BAA+B,SAAQ,KAAK;;CAOxD;AAED;;GAEG;AACH,qBAAa,4BAA6B,SAAQ,KAAK;;CAOtD;AAED;;;GAGG;AACH,qBAAa,uBAAwB,SAAQ,aAAa;IACxD,OAAO,CAAC,YAAY,CAAS;IAC7B,OAAO,CAAC,gBAAgB,CAAiC;;IAOzD,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAwDvD;;OAEG;YACW,0BAA0B;IAyCxC;;OAEG;YACW,aAAa;IAqE3B;;OAEG;IACH,OAAO,CAAC,qBAAqB;IAiB7B;;OAEG;YACW,aAAa;IAmB3B;;OAEG;YACW,UAAU;IAkExB;;OAEG;YACW,kBAAkB;IA0ChC;;OAEG;YACW,oBAAoB;IA4GlC;;OAEG;IACH,OAAO,CAAC,uBAAuB;IAiBzB,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,EAC9C,WAAW,CAAC,EAAE;QAAE,eAAe,CAAC,EAAE,MAAM,CAAC;QAAC,YAAY,CAAC,EAAE,OAAO,CAAA;KAAE,GACjE,OAAO,CAAC,aAAa,CAAC;YAgBX,iBAAiB;IAoI/B,sBAAsB,IAAI,MAAM,EAAE;IAiB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IA0BrC,eAAe,IAAI,MAAM,EAAE;CAQ5B"}
+{"version":3,"file":"claude-code-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/claude-code-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAE,MAAM,aAAa,CAAC;AAqB5C;;GAEG;AACH,qBAAa,8BAA+B,SAAQ,KAAK;;CAOxD;AAED;;GAEG;AACH,qBAAa,4BAA6B,SAAQ,KAAK;;CAOtD;AAED;;;GAGG;AACH,qBAAa,uBAAwB,SAAQ,aAAa;IACxD,OAAO,CAAC,YAAY,CAAS;IAC7B,OAAO,CAAC,gBAAgB,CAAiC;;IAOzD,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAwDvD;;OAEG;YACW,0BAA0B;IAyCxC;;OAEG;IACH,OAAO,CAAC,qBAAqB;IAiB7B;;OAEG;YACW,aAAa;IAmB3B;;OAEG;YACW,UAAU;IAkExB;;OAEG;YACW,kBAAkB;IA0ChC;;OAEG;YACW,oBAAoB;IA4GlC;;OAEG;IACH,OAAO,CAAC,uBAAuB;IAiBzB,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,EAC9C,WAAW,CAAC,EAAE;QAAE,eAAe,CAAC,EAAE,MAAM,CAAC;QAAC,YAAY,CAAC,EAAE,OAAO,CAAA;KAAE,GACjE,OAAO,CAAC,aAAa,CAAC;YAgBX,iBAAiB;IA0I/B,sBAAsB,IAAI,MAAM,EAAE;IAiB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IA0BrC,eAAe,IAAI,MAAM,EAAE;CAQ5B"}

package/dist/providers/command-check-provider.d.ts

@@ -20,8 +20,14 @@ export declare class CommandCheckProvider extends CheckProvider {
      *  - If it's a JSON string, expose parsed properties via Proxy (e.g., value.key)
      *  - When coerced to string (toString/valueOf/Symbol.toPrimitive), return the original raw string
      *  - If parsing fails or value is not a string, return the value unchanged
+     *  - Attempts to extract JSON from the end of the output if full parse fails
      */
     private makeJsonSmart;
+    /**
+     * Extract JSON from the end of a string that may contain logs/debug output
+     * Looks for the last occurrence of { or [ and tries to parse from there
+     */
+    private extractJsonFromEnd;
     /**
      * Recursively apply JSON-smart wrapper to outputs object values
      */

package/dist/providers/command-check-provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"command-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/command-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAe,MAAM,aAAa,CAAC;AAMzD;;;GAGG;AACH,qBAAa,oBAAqB,SAAQ,aAAa;IACrD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,OAAO,CAAC,CAAU;;IAY1B,OAAO,CAAC,mBAAmB;IAW3B,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAejD,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,GAC7C,OAAO,CAAC,aAAa,CAAC;IA2TzB,OAAO,CAAC,kBAAkB;IAkB1B;;;;;OAKG;IACH,OAAO,CAAC,aAAa;IA+DrB;;OAEG;IACH,OAAO,CAAC,oBAAoB;IAQ5B,OAAO,CAAC,2BAA2B;IAgBnC,sBAAsB,IAAI,MAAM,EAAE;IAgB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IAKrC,eAAe,IAAI,MAAM,EAAE;IAQ3B,OAAO,CAAC,uBAAuB;IAkD/B,OAAO,CAAC,uBAAuB;IAkB/B,OAAO,CAAC,mBAAmB;IAc3B,OAAO,CAAC,cAAc;IAmEtB,OAAO,CAAC,eAAe;IAYvB,OAAO,CAAC,QAAQ;YAWF,qBAAqB;IAiBnC,OAAO,CAAC,uBAAuB;CA6ChC"}
+{"version":3,"file":"command-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/command-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAe,MAAM,aAAa,CAAC;AAMzD;;;GAGG;AACH,qBAAa,oBAAqB,SAAQ,aAAa;IACrD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,OAAO,CAAC,CAAU;;IAY1B,OAAO,CAAC,mBAAmB;IAW3B,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAejD,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,GAC7C,OAAO,CAAC,aAAa,CAAC;IAyUzB,OAAO,CAAC,kBAAkB;IAkB1B;;;;;;OAMG;IACH,OAAO,CAAC,aAAa;IAgFrB;;;OAGG;IACH,OAAO,CAAC,kBAAkB;IAyB1B;;OAEG;IACH,OAAO,CAAC,oBAAoB;IAQ5B,OAAO,CAAC,2BAA2B;IAgBnC,sBAAsB,IAAI,MAAM,EAAE;IAgB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IAKrC,eAAe,IAAI,MAAM,EAAE;IAQ3B,OAAO,CAAC,uBAAuB;IAkD/B,OAAO,CAAC,uBAAuB;IAkB/B,OAAO,CAAC,mBAAmB;IAc3B,OAAO,CAAC,cAAc;IAmEtB,OAAO,CAAC,eAAe;IAYvB,OAAO,CAAC,QAAQ;YAWF,qBAAqB;IAiBnC,OAAO,CAAC,uBAAuB;CA6ChC"}

package/dist/sdk/{check-execution-engine-XBKOCBEK.mjs → check-execution-engine-47OZJFUV.mjs}

@@ -1,9 +1,9 @@
 import {
   CheckExecutionEngine
-} from "./chunk-HDGNSOMS.mjs";
+} from "./chunk-V5PUTL5N.mjs";
 import "./chunk-FIL2OGF6.mjs";
 import "./chunk-WMJKH4XE.mjs";
 export {
   CheckExecutionEngine
 };
-//# sourceMappingURL=check-execution-engine-XBKOCBEK.mjs.map
+//# sourceMappingURL=check-execution-engine-47OZJFUV.mjs.map

package/dist/sdk/{chunk-HDGNSOMS.mjs → chunk-V5PUTL5N.mjs}

@@ -20,7 +20,9 @@ var init_session_registry = __esm({
     SessionRegistry = class _SessionRegistry {
       static instance;
       sessions = /* @__PURE__ */ new Map();
+      exitHandlerRegistered = false;
       constructor() {
+        this.registerExitHandlers();
       }
       /**
        * Get the singleton instance of SessionRegistry
@@ -54,7 +56,15 @@ var init_session_registry = __esm({
       unregisterSession(sessionId) {
         if (this.sessions.has(sessionId)) {
           console.error(`\u{1F5D1}\uFE0F  Unregistering AI session: ${sessionId}`);
+          const agent = this.sessions.get(sessionId);
           this.sessions.delete(sessionId);
+          if (agent && typeof agent.cleanup === "function") {
+            try {
+              agent.cleanup();
+            } catch (error) {
+              console.error(`\u26A0\uFE0F  Warning: Failed to cleanup ProbeAgent: ${error}`);
+            }
+          }
         }
       }
       /**
@@ -62,6 +72,14 @@ var init_session_registry = __esm({
        */
       clearAllSessions() {
         console.error(`\u{1F9F9} Clearing all AI sessions (${this.sessions.size} sessions)`);
+        for (const [, agent] of this.sessions.entries()) {
+          if (agent && typeof agent.cleanup === "function") {
+            try {
+              agent.cleanup();
+            } catch {
+            }
+          }
+        }
         this.sessions.clear();
       }
       /**
@@ -76,6 +94,44 @@ var init_session_registry = __esm({
       hasSession(sessionId) {
         return this.sessions.has(sessionId);
       }
+      /**
+       * Register process exit handlers to cleanup sessions on exit
+       */
+      registerExitHandlers() {
+        if (this.exitHandlerRegistered) {
+          return;
+        }
+        const cleanupAndExit = (signal) => {
+          if (this.sessions.size > 0) {
+            console.error(`
+\u{1F9F9} [${signal}] Cleaning up ${this.sessions.size} active AI sessions...`);
+            this.clearAllSessions();
+          }
+        };
+        process.on("exit", () => {
+          if (this.sessions.size > 0) {
+            console.error(`\u{1F9F9} [exit] Cleaning up ${this.sessions.size} active AI sessions...`);
+            for (const [, agent] of this.sessions.entries()) {
+              if (agent && typeof agent.cleanup === "function") {
+                try {
+                  agent.cleanup();
+                } catch {
+                }
+              }
+            }
+            this.sessions.clear();
+          }
+        });
+        process.on("SIGINT", () => {
+          cleanupAndExit("SIGINT");
+          process.exit(0);
+        });
+        process.on("SIGTERM", () => {
+          cleanupAndExit("SIGTERM");
+          process.exit(0);
+        });
+        this.exitHandlerRegistered = true;
+      }
     };
   }
 });
@@ -1493,7 +1549,7 @@ var PRReviewer = class {
   async reviewPR(owner, repo, prNumber, prInfo, options = {}) {
     const { debug = false, config, checks } = options;
     if (config && checks && checks.length > 0) {
-      const { CheckExecutionEngine: CheckExecutionEngine2 } = await import("./check-execution-engine-XBKOCBEK.mjs");
+      const { CheckExecutionEngine: CheckExecutionEngine2 } = await import("./check-execution-engine-47OZJFUV.mjs");
       const engine = new CheckExecutionEngine2();
       const { results } = await engine.executeGroupedChecks(
         prInfo,
@@ -2141,17 +2197,6 @@ var IssueFilter = class {
 // src/providers/ai-check-provider.ts
 import fs3 from "fs/promises";
 import path3 from "path";
-
-// src/providers/claude-code-types.ts
-async function safeImport(moduleName) {
-  try {
-    return await import(moduleName);
-  } catch {
-    return null;
-  }
-}
-
-// src/providers/ai-check-provider.ts
 var AICheckProvider = class extends CheckProvider {
   aiReviewService;
   liquidEngine;
@@ -2429,54 +2474,6 @@ var AICheckProvider = class extends CheckProvider {
       );
     }
   }
-  /**
-   * Setup MCP tools based on AI configuration
-   */
-  async setupMcpTools(aiConfig) {
-    const tools = [];
-    if (aiConfig.mcpServers) {
-      try {
-        const mcpModule = await safeImport("@modelcontextprotocol/sdk");
-        if (!mcpModule) {
-          console.warn("@modelcontextprotocol/sdk package not found. MCP servers disabled.");
-          return tools;
-        }
-        const createSdkMcpServer = mcpModule.createSdkMcpServer || mcpModule.default?.createSdkMcpServer;
-        if (typeof createSdkMcpServer === "function") {
-          for (const [serverName, serverConfig] of Object.entries(aiConfig.mcpServers)) {
-            try {
-              const server = await createSdkMcpServer({
-                name: serverName,
-                command: serverConfig.command,
-                args: serverConfig.args || [],
-                env: { ...process.env, ...serverConfig.env }
-              });
-              const serverTools = await server.listTools();
-              tools.push(
-                ...serverTools.map((tool) => ({
-                  name: tool.name,
-                  server: serverName
-                }))
-              );
-            } catch (serverError) {
-              console.warn(
-                `Failed to setup MCP server ${serverName}: ${serverError instanceof Error ? serverError.message : "Unknown error"}`
-              );
-            }
-          }
-        } else {
-          console.warn(
-            "createSdkMcpServer function not found in @modelcontextprotocol/sdk. MCP servers disabled."
-          );
-        }
-      } catch (error) {
-        console.warn(
-          `Failed to import MCP SDK: ${error instanceof Error ? error.message : "Unknown error"}. MCP servers disabled.`
-        );
-      }
-    }
-    return tools;
-  }
   async execute(prInfo, config, _dependencyResults, sessionInfo) {
     if (config.env) {
       const result = EnvironmentResolver.withTemporaryEnv(config.env, () => {
@@ -2533,11 +2530,9 @@ var AICheckProvider = class extends CheckProvider {
     }
     if (Object.keys(mcpServers).length > 0) {
       aiConfig.mcpServers = mcpServers;
-      const mcpConfig = { mcpServers };
-      const mcpTools = await this.setupMcpTools(mcpConfig);
       if (aiConfig.debug) {
         console.error(
-          `\u{1F527} Debug: AI check MCP configured with ${Object.keys(mcpServers).length} servers; discovered ${mcpTools.length} tools`
+          `\u{1F527} Debug: AI check MCP configured with ${Object.keys(mcpServers).length} servers`
         );
       }
     }
@@ -3367,6 +3362,17 @@ var LogCheckProvider = class extends CheckProvider {
 // src/providers/claude-code-check-provider.ts
 import fs4 from "fs/promises";
 import path4 from "path";
+
+// src/providers/claude-code-types.ts
+async function safeImport(moduleName) {
+  try {
+    return await import(moduleName);
+  } catch {
+    return null;
+  }
+}
+
+// src/providers/claude-code-check-provider.ts
 function isClaudeCodeConstructor(value) {
   return typeof value === "function";
 }
@@ -3468,59 +3474,6 @@ var ClaudeCodeCheckProvider = class extends CheckProvider {
       );
     }
   }
-  /**
-   * Setup MCP tools based on configuration
-   */
-  async setupMcpTools(config) {
-    const tools = [];
-    if (config.allowedTools) {
-      for (const toolName of config.allowedTools) {
-        tools.push({ name: toolName });
-      }
-    }
-    if (config.mcpServers) {
-      try {
-        const mcpModule = await safeImport("@modelcontextprotocol/sdk");
-        if (!mcpModule) {
-          console.warn("@modelcontextprotocol/sdk package not found. MCP servers disabled.");
-          return tools;
-        }
-        const createSdkMcpServer = mcpModule.createSdkMcpServer || mcpModule.default?.createSdkMcpServer;
-        if (typeof createSdkMcpServer === "function") {
-          for (const [serverName, serverConfig] of Object.entries(config.mcpServers)) {
-            try {
-              const server = await createSdkMcpServer({
-                name: serverName,
-                command: serverConfig.command,
-                args: serverConfig.args || [],
-                env: { ...process.env, ...serverConfig.env }
-              });
-              const serverTools = await server.listTools();
-              tools.push(
-                ...serverTools.map((tool) => ({
-                  name: tool.name,
-                  server: serverName
-                }))
-              );
-            } catch (serverError) {
-              console.warn(
-                `Failed to setup MCP server ${serverName}: ${serverError instanceof Error ? serverError.message : "Unknown error"}`
-              );
-            }
-          }
-        } else {
-          console.warn(
-            "createSdkMcpServer function not found in @modelcontextprotocol/sdk. MCP servers disabled."
-          );
-        }
-      } catch (error) {
-        console.warn(
-          `Failed to import MCP SDK: ${error instanceof Error ? error.message : "Unknown error"}. MCP servers disabled.`
-        );
-      }
-    }
-    return tools;
-  }
   /**
    * Group files by their file extension for template context
    */
@@ -3751,14 +3704,18 @@ var ClaudeCodeCheckProvider = class extends CheckProvider {
     const startTime = Date.now();
     try {
       const client = await this.initializeClaudeCodeClient();
-      const tools = await this.setupMcpTools(claudeCodeConfig);
       const query = {
         query: processedPrompt,
-        tools: tools.length > 0 ? tools : void 0,
         maxTurns: claudeCodeConfig.maxTurns || 5,
         systemPrompt: claudeCodeConfig.systemPrompt,
         subagent: claudeCodeConfig.subagent
       };
+      if (claudeCodeConfig.allowedTools && claudeCodeConfig.allowedTools.length > 0) {
+        query.tools = claudeCodeConfig.allowedTools.map((name) => ({ name }));
+      }
+      if (claudeCodeConfig.mcpServers && Object.keys(claudeCodeConfig.mcpServers).length > 0) {
+        query.mcpServers = claudeCodeConfig.mcpServers;
+      }
       let response;
       if (sessionInfo?.reuseSession && sessionInfo.parentSessionId) {
         response = await client.query({
@@ -3786,8 +3743,7 @@ var ClaudeCodeCheckProvider = class extends CheckProvider {
         // Claude Code specific debug info
         sessionId: response.session_id,
         turnCount: response.turn_count,
-        usage: response.usage,
-        toolsUsed: tools.map((t) => t.name)
+        usage: response.usage
       };
       const suppressionEnabled = config.suppressionEnabled !== false;
       const issueFilter = new IssueFilter(suppressionEnabled);
@@ -3953,7 +3909,19 @@ var CommandCheckProvider = class extends CheckProvider {
         const parsed = JSON.parse(rawOutput);
         output = parsed;
       } catch {
-        output = rawOutput;
+        const extracted2 = this.extractJsonFromEnd(rawOutput);
+        if (extracted2) {
+          try {
+            output = JSON.parse(extracted2);
+            logger.debug(
+              `\u{1F527} Debug: Extracted and parsed JSON from end of output (${extracted2.length} chars from ${rawOutput.length} total)`
+            );
+          } catch {
+            output = rawOutput;
+          }
+        } else {
+          output = rawOutput;
+        }
       }
       let finalOutput = output;
       if (transform) {
@@ -4172,6 +4140,7 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
    *  - If it's a JSON string, expose parsed properties via Proxy (e.g., value.key)
    *  - When coerced to string (toString/valueOf/Symbol.toPrimitive), return the original raw string
    *  - If parsing fails or value is not a string, return the value unchanged
+   *  - Attempts to extract JSON from the end of the output if full parse fails
    */
   makeJsonSmart(value) {
     if (typeof value !== "string") {
@@ -4182,7 +4151,19 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
     try {
       parsed = JSON.parse(raw);
     } catch {
-      return raw;
+      const jsonMatch = this.extractJsonFromEnd(raw);
+      if (jsonMatch) {
+        try {
+          parsed = JSON.parse(jsonMatch);
+          logger.debug(
+            `\u{1F527} Debug: Extracted JSON from end of output (${jsonMatch.length} chars from ${raw.length} total)`
+          );
+        } catch {
+          return raw;
+        }
+      } else {
+        return raw;
+      }
     }
     const boxed = new String(raw);
     const handler = {
@@ -4231,6 +4212,24 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
     };
     return new Proxy(boxed, handler);
   }
+  /**
+   * Extract JSON from the end of a string that may contain logs/debug output
+   * Looks for the last occurrence of { or [ and tries to parse from there
+   */
+  extractJsonFromEnd(text) {
+    const lines = text.split("\n");
+    for (let i = lines.length - 1; i >= 0; i--) {
+      const trimmed = lines[i].trim();
+      if (trimmed.startsWith("{") || trimmed.startsWith("[")) {
+        const candidate = lines.slice(i).join("\n");
+        const trimmedCandidate = candidate.trim();
+        if (trimmedCandidate.startsWith("{") && trimmedCandidate.endsWith("}") || trimmedCandidate.startsWith("[") && trimmedCandidate.endsWith("]")) {
+          return trimmedCandidate;
+        }
+      }
+    }
+    return null;
+  }
   /**
    * Recursively apply JSON-smart wrapper to outputs object values
    */
@@ -6987,11 +6986,15 @@ ${expr}
           for (const depId of directDeps) {
             const depRes = results.get(depId);
             if (!depRes) continue;
-            const hasFatalCommandFailure = (depRes.issues || []).some((issue) => {
+            const wasSkipped = (depRes.issues || []).some((issue) => {
               const id = issue.ruleId || "";
-              return id.endsWith("/command/execution_error") || id.endsWith("/command/transform_js_error") || id.endsWith("/command/transform_error");
+              return id.endsWith("/__skipped");
             });
-            if (hasFatalCommandFailure) failedDeps.push(depId);
+            const hasFatalFailure = (depRes.issues || []).some((issue) => {
+              const id = issue.ruleId || "";
+              return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error");
+            });
+            if (wasSkipped || hasFatalFailure) failedDeps.push(depId);
           }
           if (failedDeps.length > 0) {
             this.recordSkip(checkName, "dependency_failed");
@@ -7057,7 +7060,9 @@ ${expr}
                 `\u{1F504} Debug: Check "${checkName}" depends on forEach check "${forEachParentName}", executing ${forEachItems.length} times`
               );
             }
-            logger.info(`  Processing ${forEachItems.length} items...`);
+            logger.info(
+              `  forEach: processing ${forEachItems.length} items from "${forEachParentName}"...`
+            );
             const allIssues = [];
             const allOutputs = [];
             const aggregatedContents = [];
@@ -7134,11 +7139,16 @@ ${expr}
                   parent: forEachParentName
                 }
               );
+              const hadFatalError = (itemResult.issues || []).some((issue) => {
+                const id = issue.ruleId || "";
+                return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+              });
               const iterationDuration = (Date.now() - iterationStart) / 1e3;
               this.recordIterationComplete(
                 checkName,
                 iterationStart,
-                true,
+                !hadFatalError,
+                // Success if no fatal errors
                 itemResult.issues || [],
                 itemResult.output
               );
@@ -7163,7 +7173,22 @@ ${expr}
             );
             for (const result of forEachResults) {
               if (result.status === "rejected") {
-                throw result.reason;
+                const error = result.reason;
+                const errorMessage = error instanceof Error ? error.message : String(error);
+                allIssues.push({
+                  ruleId: `${checkName}/forEach/iteration_error`,
+                  severity: "error",
+                  category: "logic",
+                  message: `forEach iteration failed: ${errorMessage}`,
+                  file: "",
+                  line: 0
+                });
+                if (debug) {
+                  log2(
+                    `\u{1F504} Debug: forEach iteration for check "${checkName}" failed: ${errorMessage}`
+                  );
+                }
+                continue;
               }
               if (result.value.skipped) {
                 continue;
@@ -7231,10 +7256,15 @@ ${expr}
               debug,
               results
             );
+            const hadFatalError = (finalResult.issues || []).some((issue) => {
+              const id = issue.ruleId || "";
+              return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+            });
             this.recordIterationComplete(
               checkName,
               checkStartTime,
-              true,
+              !hadFatalError,
+              // Success if no fatal errors
               finalResult.issues || [],
               finalResult.output
             );
@@ -7322,8 +7352,20 @@ ${expr}
         if (result.status === "fulfilled" && result.value.result && !result.value.error) {
           if (result.value.skipped) {
             if (debug) {
-              log2(`\u{1F527} Debug: Not storing result for skipped check "${checkName}"`);
+              log2(`\u{1F527} Debug: Storing skip marker for skipped check "${checkName}"`);
             }
+            results.set(checkName, {
+              issues: [
+                {
+                  ruleId: `${checkName}/__skipped`,
+                  severity: "info",
+                  category: "logic",
+                  message: "Check was skipped",
+                  file: "",
+                  line: 0
+                }
+              ]
+            });
             continue;
           }
           const reviewResult = result.value.result;
@@ -7348,6 +7390,7 @@ ${expr}
             } else {
               normalizedOutput = [rawOutput];
             }
+            logger.info(`  Found ${normalizedOutput.length} items for forEach iteration`);
             try {
               const preview = JSON.stringify(normalizedOutput);
               logger.debug(
@@ -7406,14 +7449,6 @@ ${expr}
         }
       }
     }
-    const executionStatistics = this.buildExecutionStatistics();
-    if (logFn === console.log) {
-      this.logExecutionSummary(executionStatistics);
-    }
-    if (shouldStopExecution) {
-      logger.info("");
-      logger.warn(`\u26A0\uFE0F  Execution stopped early due to fail-fast`);
-    }
     if (debug) {
       if (shouldStopExecution) {
         log2(
@@ -7434,6 +7469,14 @@ ${expr}
         }
       }
     }
+    const executionStatistics = this.buildExecutionStatistics();
+    if (logFn === console.log) {
+      this.logExecutionSummary(executionStatistics);
+    }
+    if (shouldStopExecution) {
+      logger.info("");
+      logger.warn(`\u26A0\uFE0F  Execution stopped early due to fail-fast`);
+    }
     return this.aggregateDependencyAwareResults(
       results,
       dependencyGraph,
@@ -7652,7 +7695,10 @@ ${expr}
             `\u2705 Check "${checkName}" completed: ${(result.issues || []).length} issues found (level ${executionGroup.level})`
           );
         }
-        aggregatedIssues.push(...result.issues || []);
+        const nonInternalIssues = (result.issues || []).filter(
+          (issue) => !issue.ruleId?.endsWith("/__skipped")
+        );
+        aggregatedIssues.push(...nonInternalIssues);
         const resultSummary = result;
         const resultContent = resultSummary.content;
         if (typeof resultContent === "string" && resultContent.trim()) {
@@ -8587,4 +8633,4 @@ export {
   logger,
   CheckExecutionEngine
 };
-//# sourceMappingURL=chunk-HDGNSOMS.mjs.map
+//# sourceMappingURL=chunk-V5PUTL5N.mjs.map