@probelabs/visor 0.1.78 → 0.1.80

package/dist/sdk/sdk.js

@@ -4173,7 +4173,19 @@ var init_command_check_provider = __esm({
             const parsed = JSON.parse(rawOutput);
             output = parsed;
           } catch {
-            output = rawOutput;
+            const extracted2 = this.extractJsonFromEnd(rawOutput);
+            if (extracted2) {
+              try {
+                output = JSON.parse(extracted2);
+                logger.debug(
+                  `\u{1F527} Debug: Extracted and parsed JSON from end of output (${extracted2.length} chars from ${rawOutput.length} total)`
+                );
+              } catch {
+                output = rawOutput;
+              }
+            } else {
+              output = rawOutput;
+            }
           }
           let finalOutput = output;
           if (transform) {
@@ -4392,6 +4404,7 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
        *  - If it's a JSON string, expose parsed properties via Proxy (e.g., value.key)
        *  - When coerced to string (toString/valueOf/Symbol.toPrimitive), return the original raw string
        *  - If parsing fails or value is not a string, return the value unchanged
+       *  - Attempts to extract JSON from the end of the output if full parse fails
        */
       makeJsonSmart(value) {
         if (typeof value !== "string") {
@@ -4402,7 +4415,19 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
         try {
           parsed = JSON.parse(raw);
         } catch {
-          return raw;
+          const jsonMatch = this.extractJsonFromEnd(raw);
+          if (jsonMatch) {
+            try {
+              parsed = JSON.parse(jsonMatch);
+              logger.debug(
+                `\u{1F527} Debug: Extracted JSON from end of output (${jsonMatch.length} chars from ${raw.length} total)`
+              );
+            } catch {
+              return raw;
+            }
+          } else {
+            return raw;
+          }
         }
         const boxed = new String(raw);
         const handler = {
@@ -4451,6 +4476,24 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
         };
         return new Proxy(boxed, handler);
       }
+      /**
+       * Extract JSON from the end of a string that may contain logs/debug output
+       * Looks for the last occurrence of { or [ and tries to parse from there
+       */
+      extractJsonFromEnd(text) {
+        const lines = text.split("\n");
+        for (let i = lines.length - 1; i >= 0; i--) {
+          const trimmed = lines[i].trim();
+          if (trimmed.startsWith("{") || trimmed.startsWith("[")) {
+            const candidate = lines.slice(i).join("\n");
+            const trimmedCandidate = candidate.trim();
+            if (trimmedCandidate.startsWith("{") && trimmedCandidate.endsWith("}") || trimmedCandidate.startsWith("[") && trimmedCandidate.endsWith("]")) {
+              return trimmedCandidate;
+            }
+          }
+        }
+        return null;
+      }
       /**
        * Recursively apply JSON-smart wrapper to outputs object values
        */
@@ -7257,11 +7300,15 @@ ${expr}
               for (const depId of directDeps) {
                 const depRes = results.get(depId);
                 if (!depRes) continue;
-                const hasFatalCommandFailure = (depRes.issues || []).some((issue) => {
+                const wasSkipped = (depRes.issues || []).some((issue) => {
+                  const id = issue.ruleId || "";
+                  return id.endsWith("/__skipped");
+                });
+                const hasFatalFailure = (depRes.issues || []).some((issue) => {
                   const id = issue.ruleId || "";
-                  return id.endsWith("/command/execution_error") || id.endsWith("/command/transform_js_error") || id.endsWith("/command/transform_error");
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error");
                 });
-                if (hasFatalCommandFailure) failedDeps.push(depId);
+                if (wasSkipped || hasFatalFailure) failedDeps.push(depId);
               }
               if (failedDeps.length > 0) {
                 this.recordSkip(checkName, "dependency_failed");
@@ -7327,7 +7374,9 @@ ${expr}
                     `\u{1F504} Debug: Check "${checkName}" depends on forEach check "${forEachParentName}", executing ${forEachItems.length} times`
                   );
                 }
-                logger.info(`  Processing ${forEachItems.length} items...`);
+                logger.info(
+                  `  forEach: processing ${forEachItems.length} items from "${forEachParentName}"...`
+                );
                 const allIssues = [];
                 const allOutputs = [];
                 const aggregatedContents = [];
@@ -7404,11 +7453,16 @@ ${expr}
                       parent: forEachParentName
                     }
                   );
+                  const hadFatalError = (itemResult.issues || []).some((issue) => {
+                    const id = issue.ruleId || "";
+                    return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+                  });
                   const iterationDuration = (Date.now() - iterationStart) / 1e3;
                   this.recordIterationComplete(
                     checkName,
                     iterationStart,
-                    true,
+                    !hadFatalError,
+                    // Success if no fatal errors
                     itemResult.issues || [],
                     itemResult.output
                   );
@@ -7433,7 +7487,22 @@ ${expr}
                 );
                 for (const result of forEachResults) {
                   if (result.status === "rejected") {
-                    throw result.reason;
+                    const error = result.reason;
+                    const errorMessage = error instanceof Error ? error.message : String(error);
+                    allIssues.push({
+                      ruleId: `${checkName}/forEach/iteration_error`,
+                      severity: "error",
+                      category: "logic",
+                      message: `forEach iteration failed: ${errorMessage}`,
+                      file: "",
+                      line: 0
+                    });
+                    if (debug) {
+                      log2(
+                        `\u{1F504} Debug: forEach iteration for check "${checkName}" failed: ${errorMessage}`
+                      );
+                    }
+                    continue;
                   }
                   if (result.value.skipped) {
                     continue;
@@ -7501,10 +7570,15 @@ ${expr}
                   debug,
                   results
                 );
+                const hadFatalError = (finalResult.issues || []).some((issue) => {
+                  const id = issue.ruleId || "";
+                  return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+                });
                 this.recordIterationComplete(
                   checkName,
                   checkStartTime,
-                  true,
+                  !hadFatalError,
+                  // Success if no fatal errors
                   finalResult.issues || [],
                   finalResult.output
                 );
@@ -7592,8 +7666,20 @@ ${expr}
             if (result.status === "fulfilled" && result.value.result && !result.value.error) {
               if (result.value.skipped) {
                 if (debug) {
-                  log2(`\u{1F527} Debug: Not storing result for skipped check "${checkName}"`);
+                  log2(`\u{1F527} Debug: Storing skip marker for skipped check "${checkName}"`);
                 }
+                results.set(checkName, {
+                  issues: [
+                    {
+                      ruleId: `${checkName}/__skipped`,
+                      severity: "info",
+                      category: "logic",
+                      message: "Check was skipped",
+                      file: "",
+                      line: 0
+                    }
+                  ]
+                });
                 continue;
               }
               const reviewResult = result.value.result;
@@ -7618,6 +7704,7 @@ ${expr}
                 } else {
                   normalizedOutput = [rawOutput];
                 }
+                logger.info(`  Found ${normalizedOutput.length} items for forEach iteration`);
                 try {
                   const preview = JSON.stringify(normalizedOutput);
                   logger.debug(
@@ -7922,7 +8009,10 @@ ${expr}
                 `\u2705 Check "${checkName}" completed: ${(result.issues || []).length} issues found (level ${executionGroup.level})`
               );
             }
-            aggregatedIssues.push(...result.issues || []);
+            const nonInternalIssues = (result.issues || []).filter(
+              (issue) => !issue.ruleId?.endsWith("/__skipped")
+            );
+            aggregatedIssues.push(...nonInternalIssues);
             const resultSummary = result;
             const resultContent = resultSummary.content;
             if (typeof resultContent === "string" && resultContent.trim()) {