@probelabs/visor 0.1.78 → 0.1.80

package/dist/providers/command-check-provider.d.ts

@@ -20,8 +20,14 @@ export declare class CommandCheckProvider extends CheckProvider {
      *  - If it's a JSON string, expose parsed properties via Proxy (e.g., value.key)
      *  - When coerced to string (toString/valueOf/Symbol.toPrimitive), return the original raw string
      *  - If parsing fails or value is not a string, return the value unchanged
+     *  - Attempts to extract JSON from the end of the output if full parse fails
      */
     private makeJsonSmart;
+    /**
+     * Extract JSON from the end of a string that may contain logs/debug output
+     * Looks for the last occurrence of { or [ and tries to parse from there
+     */
+    private extractJsonFromEnd;
     /**
      * Recursively apply JSON-smart wrapper to outputs object values
      */

package/dist/providers/command-check-provider.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"command-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/command-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAe,MAAM,aAAa,CAAC;AAMzD;;;GAGG;AACH,qBAAa,oBAAqB,SAAQ,aAAa;IACrD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,OAAO,CAAC,CAAU;;IAY1B,OAAO,CAAC,mBAAmB;IAW3B,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAejD,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,GAC7C,OAAO,CAAC,aAAa,CAAC;IA2TzB,OAAO,CAAC,kBAAkB;IAkB1B;;;;;OAKG;IACH,OAAO,CAAC,aAAa;IA+DrB;;OAEG;IACH,OAAO,CAAC,oBAAoB;IAQ5B,OAAO,CAAC,2BAA2B;IAgBnC,sBAAsB,IAAI,MAAM,EAAE;IAgB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IAKrC,eAAe,IAAI,MAAM,EAAE;IAQ3B,OAAO,CAAC,uBAAuB;IAkD/B,OAAO,CAAC,uBAAuB;IAkB/B,OAAO,CAAC,mBAAmB;IAc3B,OAAO,CAAC,cAAc;IAmEtB,OAAO,CAAC,eAAe;IAYvB,OAAO,CAAC,QAAQ;YAWF,qBAAqB;IAiBnC,OAAO,CAAC,uBAAuB;CA6ChC"}
+{"version":3,"file":"command-check-provider.d.ts","sourceRoot":"","sources":["file:///home/runner/work/visor/visor/src/providers/command-check-provider.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,aAAa,EAAE,mBAAmB,EAAE,MAAM,4BAA4B,CAAC;AAChF,OAAO,EAAE,MAAM,EAAE,MAAM,gBAAgB,CAAC;AACxC,OAAO,EAAE,aAAa,EAAe,MAAM,aAAa,CAAC;AAMzD;;;GAGG;AACH,qBAAa,oBAAqB,SAAQ,aAAa;IACrD,OAAO,CAAC,MAAM,CAAS;IACvB,OAAO,CAAC,OAAO,CAAC,CAAU;;IAY1B,OAAO,CAAC,mBAAmB;IAW3B,OAAO,IAAI,MAAM;IAIjB,cAAc,IAAI,MAAM;IAIlB,cAAc,CAAC,MAAM,EAAE,OAAO,GAAG,OAAO,CAAC,OAAO,CAAC;IAejD,OAAO,CACX,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,mBAAmB,EAC3B,iBAAiB,CAAC,EAAE,GAAG,CAAC,MAAM,EAAE,aAAa,CAAC,GAC7C,OAAO,CAAC,aAAa,CAAC;IAyUzB,OAAO,CAAC,kBAAkB;IAkB1B;;;;;;OAMG;IACH,OAAO,CAAC,aAAa;IAgFrB;;;OAGG;IACH,OAAO,CAAC,kBAAkB;IAyB1B;;OAEG;IACH,OAAO,CAAC,oBAAoB;IAQ5B,OAAO,CAAC,2BAA2B;IAgBnC,sBAAsB,IAAI,MAAM,EAAE;IAgB5B,WAAW,IAAI,OAAO,CAAC,OAAO,CAAC;IAKrC,eAAe,IAAI,MAAM,EAAE;IAQ3B,OAAO,CAAC,uBAAuB;IAkD/B,OAAO,CAAC,uBAAuB;IAkB/B,OAAO,CAAC,mBAAmB;IAc3B,OAAO,CAAC,cAAc;IAmEtB,OAAO,CAAC,eAAe;IAYvB,OAAO,CAAC,QAAQ;YAWF,qBAAqB;IAiBnC,OAAO,CAAC,uBAAuB;CA6ChC"}

package/dist/sdk/{check-execution-engine-XBKOCBEK.mjs → check-execution-engine-2EQWRXWI.mjs}

@@ -1,9 +1,9 @@
 import {
   CheckExecutionEngine
-} from "./chunk-HDGNSOMS.mjs";
+} from "./chunk-GNA5GPF7.mjs";
 import "./chunk-FIL2OGF6.mjs";
 import "./chunk-WMJKH4XE.mjs";
 export {
   CheckExecutionEngine
 };
-//# sourceMappingURL=check-execution-engine-XBKOCBEK.mjs.map
+//# sourceMappingURL=check-execution-engine-2EQWRXWI.mjs.map

package/dist/sdk/{chunk-HDGNSOMS.mjs → chunk-GNA5GPF7.mjs}

@@ -1493,7 +1493,7 @@ var PRReviewer = class {
   async reviewPR(owner, repo, prNumber, prInfo, options = {}) {
     const { debug = false, config, checks } = options;
     if (config && checks && checks.length > 0) {
-      const { CheckExecutionEngine: CheckExecutionEngine2 } = await import("./check-execution-engine-XBKOCBEK.mjs");
+      const { CheckExecutionEngine: CheckExecutionEngine2 } = await import("./check-execution-engine-2EQWRXWI.mjs");
       const engine = new CheckExecutionEngine2();
       const { results } = await engine.executeGroupedChecks(
         prInfo,
@@ -3953,7 +3953,19 @@ var CommandCheckProvider = class extends CheckProvider {
         const parsed = JSON.parse(rawOutput);
         output = parsed;
       } catch {
-        output = rawOutput;
+        const extracted2 = this.extractJsonFromEnd(rawOutput);
+        if (extracted2) {
+          try {
+            output = JSON.parse(extracted2);
+            logger.debug(
+              `\u{1F527} Debug: Extracted and parsed JSON from end of output (${extracted2.length} chars from ${rawOutput.length} total)`
+            );
+          } catch {
+            output = rawOutput;
+          }
+        } else {
+          output = rawOutput;
+        }
       }
       let finalOutput = output;
       if (transform) {
@@ -4172,6 +4184,7 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
    *  - If it's a JSON string, expose parsed properties via Proxy (e.g., value.key)
    *  - When coerced to string (toString/valueOf/Symbol.toPrimitive), return the original raw string
    *  - If parsing fails or value is not a string, return the value unchanged
+   *  - Attempts to extract JSON from the end of the output if full parse fails
    */
   makeJsonSmart(value) {
     if (typeof value !== "string") {
@@ -4182,7 +4195,19 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
     try {
       parsed = JSON.parse(raw);
     } catch {
-      return raw;
+      const jsonMatch = this.extractJsonFromEnd(raw);
+      if (jsonMatch) {
+        try {
+          parsed = JSON.parse(jsonMatch);
+          logger.debug(
+            `\u{1F527} Debug: Extracted JSON from end of output (${jsonMatch.length} chars from ${raw.length} total)`
+          );
+        } catch {
+          return raw;
+        }
+      } else {
+        return raw;
+      }
     }
     const boxed = new String(raw);
     const handler = {
@@ -4231,6 +4256,24 @@ ${stderrOutput}` : `Command execution failed: ${errorMessage}`;
     };
     return new Proxy(boxed, handler);
   }
+  /**
+   * Extract JSON from the end of a string that may contain logs/debug output
+   * Looks for the last occurrence of { or [ and tries to parse from there
+   */
+  extractJsonFromEnd(text) {
+    const lines = text.split("\n");
+    for (let i = lines.length - 1; i >= 0; i--) {
+      const trimmed = lines[i].trim();
+      if (trimmed.startsWith("{") || trimmed.startsWith("[")) {
+        const candidate = lines.slice(i).join("\n");
+        const trimmedCandidate = candidate.trim();
+        if (trimmedCandidate.startsWith("{") && trimmedCandidate.endsWith("}") || trimmedCandidate.startsWith("[") && trimmedCandidate.endsWith("]")) {
+          return trimmedCandidate;
+        }
+      }
+    }
+    return null;
+  }
   /**
    * Recursively apply JSON-smart wrapper to outputs object values
    */
@@ -6987,11 +7030,15 @@ ${expr}
           for (const depId of directDeps) {
             const depRes = results.get(depId);
             if (!depRes) continue;
-            const hasFatalCommandFailure = (depRes.issues || []).some((issue) => {
+            const wasSkipped = (depRes.issues || []).some((issue) => {
+              const id = issue.ruleId || "";
+              return id.endsWith("/__skipped");
+            });
+            const hasFatalFailure = (depRes.issues || []).some((issue) => {
               const id = issue.ruleId || "";
-              return id.endsWith("/command/execution_error") || id.endsWith("/command/transform_js_error") || id.endsWith("/command/transform_error");
+              return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error") || id.endsWith("/forEach/iteration_error");
             });
-            if (hasFatalCommandFailure) failedDeps.push(depId);
+            if (wasSkipped || hasFatalFailure) failedDeps.push(depId);
           }
           if (failedDeps.length > 0) {
             this.recordSkip(checkName, "dependency_failed");
@@ -7057,7 +7104,9 @@ ${expr}
                 `\u{1F504} Debug: Check "${checkName}" depends on forEach check "${forEachParentName}", executing ${forEachItems.length} times`
               );
             }
-            logger.info(`  Processing ${forEachItems.length} items...`);
+            logger.info(
+              `  forEach: processing ${forEachItems.length} items from "${forEachParentName}"...`
+            );
             const allIssues = [];
             const allOutputs = [];
             const aggregatedContents = [];
@@ -7134,11 +7183,16 @@ ${expr}
                   parent: forEachParentName
                 }
               );
+              const hadFatalError = (itemResult.issues || []).some((issue) => {
+                const id = issue.ruleId || "";
+                return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+              });
               const iterationDuration = (Date.now() - iterationStart) / 1e3;
               this.recordIterationComplete(
                 checkName,
                 iterationStart,
-                true,
+                !hadFatalError,
+                // Success if no fatal errors
                 itemResult.issues || [],
                 itemResult.output
               );
@@ -7163,7 +7217,22 @@ ${expr}
             );
             for (const result of forEachResults) {
               if (result.status === "rejected") {
-                throw result.reason;
+                const error = result.reason;
+                const errorMessage = error instanceof Error ? error.message : String(error);
+                allIssues.push({
+                  ruleId: `${checkName}/forEach/iteration_error`,
+                  severity: "error",
+                  category: "logic",
+                  message: `forEach iteration failed: ${errorMessage}`,
+                  file: "",
+                  line: 0
+                });
+                if (debug) {
+                  log2(
+                    `\u{1F504} Debug: forEach iteration for check "${checkName}" failed: ${errorMessage}`
+                  );
+                }
+                continue;
               }
               if (result.value.skipped) {
                 continue;
@@ -7231,10 +7300,15 @@ ${expr}
               debug,
               results
             );
+            const hadFatalError = (finalResult.issues || []).some((issue) => {
+              const id = issue.ruleId || "";
+              return id === "command/execution_error" || id.endsWith("/command/execution_error") || id === "command/transform_js_error" || id.endsWith("/command/transform_js_error") || id === "command/transform_error" || id.endsWith("/command/transform_error");
+            });
             this.recordIterationComplete(
               checkName,
               checkStartTime,
-              true,
+              !hadFatalError,
+              // Success if no fatal errors
               finalResult.issues || [],
               finalResult.output
             );
@@ -7322,8 +7396,20 @@ ${expr}
         if (result.status === "fulfilled" && result.value.result && !result.value.error) {
           if (result.value.skipped) {
             if (debug) {
-              log2(`\u{1F527} Debug: Not storing result for skipped check "${checkName}"`);
+              log2(`\u{1F527} Debug: Storing skip marker for skipped check "${checkName}"`);
             }
+            results.set(checkName, {
+              issues: [
+                {
+                  ruleId: `${checkName}/__skipped`,
+                  severity: "info",
+                  category: "logic",
+                  message: "Check was skipped",
+                  file: "",
+                  line: 0
+                }
+              ]
+            });
             continue;
           }
           const reviewResult = result.value.result;
@@ -7348,6 +7434,7 @@ ${expr}
             } else {
               normalizedOutput = [rawOutput];
             }
+            logger.info(`  Found ${normalizedOutput.length} items for forEach iteration`);
             try {
               const preview = JSON.stringify(normalizedOutput);
               logger.debug(
@@ -7652,7 +7739,10 @@ ${expr}
             `\u2705 Check "${checkName}" completed: ${(result.issues || []).length} issues found (level ${executionGroup.level})`
           );
         }
-        aggregatedIssues.push(...result.issues || []);
+        const nonInternalIssues = (result.issues || []).filter(
+          (issue) => !issue.ruleId?.endsWith("/__skipped")
+        );
+        aggregatedIssues.push(...nonInternalIssues);
         const resultSummary = result;
         const resultContent = resultSummary.content;
         if (typeof resultContent === "string" && resultContent.trim()) {
@@ -8587,4 +8677,4 @@ export {
   logger,
   CheckExecutionEngine
 };
-//# sourceMappingURL=chunk-HDGNSOMS.mjs.map
+//# sourceMappingURL=chunk-GNA5GPF7.mjs.map