@probelabs/visor 0.1.10 → 0.1.18

package/dist/reviewer.js

@@ -32,27 +32,55 @@ var __importStar = (this && this.__importStar) || (function () {
         return result;
     };
 })();
-var __importDefault = (this && this.__importDefault) || function (mod) {
-    return (mod && mod.__esModule) ? mod : { "default": mod };
-};
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.PRReviewer = void 0;
+exports.convertReviewSummaryToGroupedResults = convertReviewSummaryToGroupedResults;
 exports.calculateTotalIssues = calculateTotalIssues;
 exports.calculateCriticalIssues = calculateCriticalIssues;
 exports.convertIssuesToComments = convertIssuesToComments;
 const github_comments_1 = require("./github-comments");
 const ai_review_service_1 = require("./ai-review-service");
-const liquidjs_1 = require("liquidjs");
-const promises_1 = __importDefault(require("fs/promises"));
-const path_1 = __importDefault(require("path"));
-const crypto = __importStar(require("crypto"));
-// Helper functions for calculating metrics from issues
+// Test utility function - Convert old ReviewSummary to new GroupedCheckResults format
+// This is for backward compatibility with tests only
+function convertReviewSummaryToGroupedResults(reviewSummary, checkName = 'test-check', groupName = 'default') {
+    // Create a simple content string from issues and suggestions
+    let content = '';
+    if (reviewSummary.issues && reviewSummary.issues.length > 0) {
+        content += `## Issues Found (${reviewSummary.issues.length})\n\n`;
+        reviewSummary.issues.forEach(issue => {
+            content += `- **${issue.severity.toUpperCase()}**: ${issue.message} (${issue.file}:${issue.line})\n`;
+        });
+        content += '\n';
+    }
+    if (reviewSummary.suggestions && reviewSummary.suggestions.length > 0) {
+        content += `## Suggestions\n\n`;
+        reviewSummary.suggestions.forEach(suggestion => {
+            content += `- ${suggestion}\n`;
+        });
+    }
+    if (!content) {
+        content = 'No issues found.';
+    }
+    const checkResult = {
+        checkName,
+        content: content.trim(),
+        group: groupName,
+        debug: reviewSummary.debug,
+        issues: reviewSummary.issues, // Include structured issues
+    };
+    const groupedResults = {};
+    groupedResults[groupName] = [checkResult];
+    return groupedResults;
+}
+// Helper functions for GitHub checks - ONLY for structured schemas that have issues
+// These are the ONLY acceptable hardcoded schema dependencies, and only for GitHub integration
 function calculateTotalIssues(issues) {
-    return issues.length;
+    return (issues || []).length;
 }
 function calculateCriticalIssues(issues) {
-    return issues.filter(i => i.severity === 'critical').length;
+    return (issues || []).filter(i => i.severity === 'critical').length;
 }
+// Legacy converter - ONLY for GitHub integration compatibility
 function convertIssuesToComments(issues) {
     return issues.map(issue => ({
         file: issue.file,
@@ -62,7 +90,7 @@ function convertIssuesToComments(issues) {
         category: issue.category,
         suggestion: issue.suggestion,
         replacement: issue.replacement,
-        ruleId: issue.ruleId, // Preserve ruleId for check-based grouping
+        ruleId: issue.ruleId,
     }));
 }
 class PRReviewer {
@@ -76,277 +104,52 @@ class PRReviewer {
     }
     async reviewPR(owner, repo, prNumber, prInfo, options = {}) {
         const { debug = false, config, checks } = options;
-        // If we have a config and checks, use CheckExecutionEngine
         if (config && checks && checks.length > 0) {
-            // Import CheckExecutionEngine dynamically to avoid circular dependencies
             const { CheckExecutionEngine } = await Promise.resolve().then(() => __importStar(require('./check-execution-engine')));
             const engine = new CheckExecutionEngine();
-            // Execute checks using the engine
-            const reviewSummary = await engine['executeReviewChecks'](prInfo, checks, undefined, config, undefined, debug);
-            // Return all issues - no filtering needed
-            return reviewSummary;
+            const groupedResults = await engine.executeGroupedChecks(prInfo, checks, undefined, config, undefined, debug);
+            return groupedResults;
         }
-        // No config provided - require configuration
         throw new Error('No configuration provided. Please create a .visor.yaml file with check definitions. ' +
             'Built-in prompts have been removed - all checks must be explicitly configured.');
     }
-    async postReviewComment(owner, repo, prNumber, summary, options = {}) {
-        // Group issues by their group property
-        const issuesByGroup = this.groupIssuesByGroup(summary.issues);
-        // If no groups or only one group, still use consistent group-based comment IDs
-        if (Object.keys(issuesByGroup).length <= 1) {
-            const comment = await this.formatReviewCommentWithVisorFormat(summary, options, {
-                owner,
-                repo,
-                prNumber,
-                commitSha: options.commitSha,
-            });
-            // Use consistent group-based comment ID even for single group
-            const baseCommentId = options.commentId || 'visor-review';
-            const groupName = Object.keys(issuesByGroup)[0] || 'default';
-            const consistentCommentId = `${baseCommentId}-${groupName}`;
-            await this.commentManager.updateOrCreateComment(owner, repo, prNumber, comment, {
-                commentId: consistentCommentId,
-                triggeredBy: options.triggeredBy || 'unknown',
-                allowConcurrentUpdates: false,
-                commitSha: options.commitSha,
-            });
-            return;
-        }
-        // Sort groups by the earliest timestamp of issues in each group
-        // This ensures comments are posted in the order checks completed
-        const sortedGroups = Object.entries(issuesByGroup).sort(([_aName, aIssues], [_bName, bIssues]) => {
-            // Find the earliest timestamp in each group
-            const aEarliest = Math.min(...aIssues.map(i => i.timestamp || Infinity));
-            const bEarliest = Math.min(...bIssues.map(i => i.timestamp || Infinity));
-            return aEarliest - bEarliest;
-        });
-        // Create separate comments for each group
-        for (const [groupName, groupIssues] of sortedGroups) {
-            const groupSummary = {
-                ...summary,
-                issues: groupIssues,
-            };
-            // Use group name in comment ID to create separate comments
-            // Always include the group name suffix to ensure uniqueness
-            const baseCommentId = options.commentId || 'visor-review';
-            const groupCommentId = `${baseCommentId}-${groupName}`;
-            const comment = await this.formatReviewCommentWithVisorFormat(groupSummary, options, {
+    async postReviewComment(owner, repo, prNumber, groupedResults, options = {}) {
+        // Post separate comments for each group
+        for (const [groupName, checkResults] of Object.entries(groupedResults)) {
+            const comment = await this.formatGroupComment(checkResults, options, {
                 owner,
                 repo,
                 prNumber,
                 commitSha: options.commitSha,
             });
+            const commentId = options.commentId
+                ? `${options.commentId}-${groupName}`
+                : `visor-review-${groupName}`;
             await this.commentManager.updateOrCreateComment(owner, repo, prNumber, comment, {
-                commentId: groupCommentId,
+                commentId,
                 triggeredBy: options.triggeredBy || 'unknown',
                 allowConcurrentUpdates: false,
                 commitSha: options.commitSha,
             });
         }
     }
-    async formatReviewCommentWithVisorFormat(summary, _options, githubContext) {
-        const totalIssues = calculateTotalIssues(summary.issues);
+    async formatGroupComment(checkResults, _options, _githubContext) {
         let comment = '';
-        // Add main header
-        if (totalIssues === 0) {
-            comment += `## ✅ All Checks Passed\n\n**No issues found – changes LGTM.**\n\n`;
-        }
-        else {
-            comment += `## 🔍 Code Analysis Results\n\n`;
-            // Use new schema-template system for content generation
-            const templateContent = await this.renderWithSchemaTemplate(summary, githubContext);
-            comment += templateContent;
-        }
-        // Add debug section if available
-        if (summary.debug) {
-            comment += '\n\n' + this.formatDebugSection(summary.debug);
+        comment += `## 🔍 Code Analysis Results\n\n`;
+        // Simple concatenation of all check outputs in this group
+        const checkContents = checkResults
+            .map(result => result.content)
+            .filter(content => content.trim());
+        comment += checkContents.join('\n\n');
+        // Add debug info if any check has it
+        const debugInfo = checkResults.find(result => result.debug)?.debug;
+        if (debugInfo) {
+            comment += '\n\n' + this.formatDebugSection(debugInfo);
             comment += '\n\n';
         }
-        // Simple footer
-        comment += `---\n*Powered by [Visor](https://probelabs.com/visor) from [Probelabs](https://probelabs.com)*`;
+        comment += `\n---\n*Powered by [Visor](https://probelabs.com/visor) from [Probelabs](https://probelabs.com)*`;
         return comment;
     }
-    async renderWithSchemaTemplate(summary, githubContext) {
-        try {
-            // Group issues by check name and render each check separately
-            const issuesByCheck = this.groupIssuesByCheck(summary.issues);
-            if (Object.keys(issuesByCheck).length === 0) {
-                return 'No issues found in this group.';
-            }
-            const renderedSections = [];
-            for (const [checkName, checkIssues] of Object.entries(issuesByCheck)) {
-                const checkSchema = checkIssues[0]?.schema || 'code-review';
-                const customTemplate = checkIssues[0]?.template;
-                const renderedSection = await this.renderSingleCheckTemplate(checkName, checkIssues, checkSchema, customTemplate, githubContext);
-                renderedSections.push(renderedSection);
-            }
-            // Combine all check sections with proper spacing
-            return renderedSections.join('\n\n');
-        }
-        catch (error) {
-            console.warn('Failed to render with schema-template system, falling back to old system:', error);
-            // Fallback to old system if template fails
-            const comments = convertIssuesToComments(summary.issues);
-            return this.formatIssuesTable(comments);
-        }
-    }
-    generateGitHubDiffHash(filePath) {
-        // GitHub uses SHA256 hash of the file path for diff anchors
-        return crypto.createHash('sha256').update(filePath).digest('hex');
-    }
-    enhanceIssuesWithGitHubLinks(issues, githubContext) {
-        if (!githubContext) {
-            return issues;
-        }
-        // Use commit SHA for permalink format that auto-expands
-        // If no commit SHA provided, fall back to PR files view
-        const baseUrl = githubContext.commitSha
-            ? `https://github.com/${githubContext.owner}/${githubContext.repo}/blob/${githubContext.commitSha}`
-            : `https://github.com/${githubContext.owner}/${githubContext.repo}/pull/${githubContext.prNumber}/files`;
-        return issues.map(issue => ({
-            ...issue,
-            githubUrl: githubContext.commitSha && issue.line
-                ? `${baseUrl}/${issue.file}#L${issue.line}${issue.endLine && issue.endLine !== issue.line ? `-L${issue.endLine}` : ''}`
-                : baseUrl,
-            fileHash: this.generateGitHubDiffHash(issue.file),
-        }));
-    }
-    async renderSingleCheckTemplate(checkName, issues, schema, customTemplate, githubContext) {
-        const liquid = new liquidjs_1.Liquid({
-            // Configure Liquid to handle whitespace better
-            trimTagLeft: false, // Don't auto-trim left side of tags
-            trimTagRight: false, // Don't auto-trim right side of tags
-            trimOutputLeft: false, // Don't auto-trim left side of output
-            trimOutputRight: false, // Don't auto-trim right side of output
-            greedy: false, // Don't be greedy with whitespace trimming
-        });
-        // Load template content based on configuration
-        let templateContent;
-        if (customTemplate) {
-            templateContent = await this.loadCustomTemplate(customTemplate);
-        }
-        else {
-            // Sanitize schema name to prevent path traversal attacks
-            const sanitizedSchema = schema.replace(/[^a-zA-Z0-9-]/g, '');
-            if (!sanitizedSchema) {
-                throw new Error('Invalid schema name');
-            }
-            // Load the appropriate template based on schema
-            const templatePath = path_1.default.join(__dirname, `../output/${sanitizedSchema}/template.liquid`);
-            templateContent = await promises_1.default.readFile(templatePath, 'utf-8');
-        }
-        // Enhance issues with GitHub links if context is available
-        const enhancedIssues = this.enhanceIssuesWithGitHubLinks(issues, githubContext);
-        // Pass enhanced issues with GitHub links
-        const templateData = {
-            issues: enhancedIssues,
-            checkName: checkName,
-            github: githubContext,
-        };
-        // Render with Liquid template and trim any extra whitespace at the start/end
-        const rendered = await liquid.parseAndRender(templateContent, templateData);
-        return rendered.trim();
-    }
-    groupIssuesByCheck(issues) {
-        const grouped = {};
-        for (const issue of issues) {
-            const checkName = this.extractCheckNameFromRuleId(issue.ruleId || 'uncategorized');
-            if (!grouped[checkName]) {
-                grouped[checkName] = [];
-            }
-            grouped[checkName].push(issue);
-        }
-        return grouped;
-    }
-    extractCheckNameFromRuleId(ruleId) {
-        if (ruleId && ruleId.includes('/')) {
-            return ruleId.split('/')[0];
-        }
-        return 'uncategorized';
-    }
-    groupIssuesByGroup(issues) {
-        const grouped = {};
-        for (const issue of issues) {
-            const groupName = issue.group || 'default';
-            if (!grouped[groupName]) {
-                grouped[groupName] = [];
-            }
-            grouped[groupName].push(issue);
-        }
-        return grouped;
-    }
-    formatReviewComment(summary, options) {
-        const { format = 'table' } = options;
-        // Calculate metrics from issues
-        const totalIssues = calculateTotalIssues(summary.issues);
-        const criticalIssues = calculateCriticalIssues(summary.issues);
-        const comments = convertIssuesToComments(summary.issues);
-        let comment = `## 🤖 AI Code Review\n\n`;
-        comment += `**Issues Found:** ${totalIssues} (${criticalIssues} critical)\n\n`;
-        if (summary.suggestions.length > 0) {
-            comment += `### 💡 Suggestions\n`;
-            for (const suggestion of summary.suggestions) {
-                comment += `- ${suggestion}\n`;
-            }
-            comment += '\n';
-        }
-        if (comments.length > 0) {
-            comment += `### 🔍 Code Issues\n`;
-            for (const reviewComment of comments) {
-                const emoji = reviewComment.severity === 'error'
-                    ? '❌'
-                    : reviewComment.severity === 'warning'
-                        ? '⚠️'
-                        : 'ℹ️';
-                comment += `${emoji} **${reviewComment.file}:${reviewComment.line}** (${reviewComment.category})\n`;
-                comment += `   ${reviewComment.message}\n\n`;
-            }
-        }
-        if (format === 'table' && totalIssues > 5) {
-            comment += `*Showing top 5 issues. Use \`/review --format=markdown\` for complete analysis.*\n\n`;
-        }
-        // Add debug section if debug information is available
-        if (summary.debug) {
-            comment += '\n\n' + this.formatDebugSection(summary.debug);
-            comment += '\n\n';
-        }
-        comment += `---\n`;
-        comment += `*Powered by [Visor](https://probelabs.com/visor) from [Probelabs](https://probelabs.com)*`;
-        return comment;
-    }
-    groupCommentsByCategory(comments) {
-        const grouped = {
-            security: [],
-            performance: [],
-            style: [],
-            logic: [],
-            documentation: [],
-        };
-        for (const comment of comments) {
-            if (!grouped[comment.category]) {
-                grouped[comment.category] = [];
-            }
-            grouped[comment.category].push(comment);
-        }
-        return grouped;
-    }
-    groupCommentsByCheck(comments) {
-        const grouped = {};
-        for (const comment of comments) {
-            // Extract check name from ruleId prefix (e.g., "security/sql-injection" -> "security")
-            let checkName = 'uncategorized';
-            if (comment.ruleId && comment.ruleId.includes('/')) {
-                const parts = comment.ruleId.split('/');
-                checkName = parts[0];
-            }
-            if (!grouped[checkName]) {
-                grouped[checkName] = [];
-            }
-            grouped[checkName].push(comment);
-        }
-        return grouped;
-    }
     formatDebugSection(debug) {
         const formattedContent = [
             `**Provider:** ${debug.provider}`,
@@ -364,7 +167,6 @@ class PRReviewer {
                 formattedContent.push(`- ${error}`);
             });
         }
-        // Check if debug content would be too large for GitHub comment
         const fullDebugContent = [
             ...formattedContent,
             '',
@@ -378,9 +180,7 @@ class PRReviewer {
             debug.rawResponse,
             '```',
         ].join('\n');
-        // GitHub comment limit is 65536 characters, leave some buffer
         if (fullDebugContent.length > 60000) {
-            // Save debug info to artifact and provide link
             const artifactPath = this.saveDebugArtifact(debug);
             formattedContent.push('');
             formattedContent.push('### Debug Details');
@@ -388,7 +188,6 @@ class PRReviewer {
             if (artifactPath) {
                 formattedContent.push(`📁 **Full debug information saved to artifact:** \`${artifactPath}\``);
                 formattedContent.push('');
-                // Try to get GitHub context for artifact link
                 const runId = process.env.GITHUB_RUN_ID;
                 const repoUrl = process.env.GITHUB_SERVER_URL && process.env.GITHUB_REPOSITORY
                     ? `${process.env.GITHUB_SERVER_URL}/${process.env.GITHUB_REPOSITORY}`
@@ -404,7 +203,6 @@ class PRReviewer {
             }
         }
         else {
-            // Include full debug content if it fits
             formattedContent.push('');
             formattedContent.push('### AI Prompt');
             formattedContent.push('```');
@@ -416,356 +214,47 @@ class PRReviewer {
             formattedContent.push(debug.rawResponse);
             formattedContent.push('```');
         }
-        return this.commentManager.createCollapsibleSection('🐛 Debug Information', formattedContent.join('\n'), false // Start collapsed
-        );
+        return this.commentManager.createCollapsibleSection('🐛 Debug Information', formattedContent.join('\n'), false);
     }
     saveDebugArtifact(debug) {
         try {
             const fs = require('fs');
             const path = require('path');
-            // Create debug directory if it doesn't exist
             const debugDir = path.join(process.cwd(), 'debug-artifacts');
             if (!fs.existsSync(debugDir)) {
                 fs.mkdirSync(debugDir, { recursive: true });
             }
-            // Create debug file with timestamp
             const timestamp = new Date().toISOString().replace(/[:.]/g, '-');
             const filename = `visor-debug-${timestamp}.md`;
-            const filePath = path.join(debugDir, filename);
-            // Parse the combined prompts and responses to extract individual checks
-            const markdownContent = this.formatDebugAsMarkdown(debug);
-            fs.writeFileSync(filePath, markdownContent);
+            const filepath = path.join(debugDir, filename);
+            const content = [
+                `# Visor Debug Information`,
+                ``,
+                `**Timestamp:** ${debug.timestamp}`,
+                `**Provider:** ${debug.provider}`,
+                `**Model:** ${debug.model}`,
+                `**Processing Time:** ${debug.processingTime}ms`,
+                ``,
+                `## AI Prompt`,
+                ``,
+                '```',
+                debug.prompt,
+                '```',
+                ``,
+                `## Raw AI Response`,
+                ``,
+                '```json',
+                debug.rawResponse,
+                '```',
+            ].join('\n');
+            fs.writeFileSync(filepath, content, 'utf8');
             return filename;
         }
         catch (error) {
-            console.error(`❌ Failed to save debug artifact: ${error}`);
+            console.error('Failed to save debug artifact:', error);
             return null;
         }
     }
-    formatDebugAsMarkdown(debug) {
-        const lines = [
-            '# Visor AI Debug Information',
-            '',
-            `**Generated:** ${debug.timestamp}`,
-            `**Provider:** ${debug.provider}`,
-            `**Model:** ${debug.model}`,
-            `**API Key Source:** ${debug.apiKeySource}`,
-            `**Schema Type:** ${debug.schemaName || 'default (code-review)'}`,
-            `**Total Processing Time:** ${debug.processingTime}ms`,
-            `**Total Prompt Length:** ${debug.promptLength} characters`,
-            `**Total Response Length:** ${debug.responseLength} characters`,
-            `**JSON Parse Success:** ${debug.jsonParseSuccess ? '✅' : '❌'}`,
-            '',
-        ];
-        if (debug.errors && debug.errors.length > 0) {
-            lines.push('## ❌ Errors');
-            debug.errors.forEach(error => {
-                lines.push(`- ${error}`);
-            });
-            lines.push('');
-        }
-        // Add schema information if available
-        if (debug.schema) {
-            lines.push('## 📋 Schema Options Passed to ProbeAgent');
-            lines.push('```json');
-            lines.push(debug.schema);
-            lines.push('```');
-            lines.push('');
-        }
-        // Parse combined prompt and response to extract individual checks
-        const promptSections = this.parseCheckSections(debug.prompt);
-        const responseSections = this.parseCheckSections(debug.rawResponse);
-        lines.push('## 📊 Check Results Summary');
-        lines.push('');
-        promptSections.forEach(section => {
-            const responseSection = responseSections.find(r => r.checkName === section.checkName);
-            lines.push(`- **${section.checkName}**: ${responseSection ? 'Success' : 'Failed'}`);
-        });
-        lines.push('');
-        // Add detailed information for each check
-        promptSections.forEach((promptSection, index) => {
-            const responseSection = responseSections.find(r => r.checkName === promptSection.checkName);
-            lines.push(`## ${index + 1}. ${promptSection.checkName.toUpperCase()} Check`);
-            lines.push('');
-            lines.push('### 📝 AI Prompt');
-            lines.push('');
-            lines.push('```');
-            lines.push(promptSection.content);
-            lines.push('```');
-            lines.push('');
-            lines.push('### 🤖 AI Response');
-            lines.push('');
-            if (responseSection) {
-                lines.push('```json');
-                lines.push(responseSection.content);
-                lines.push('```');
-            }
-            else {
-                lines.push('❌ No response available for this check');
-            }
-            lines.push('');
-            lines.push('---');
-            lines.push('');
-        });
-        // Add raw unprocessed prompt and response at the end for complete transparency
-        lines.push('## 📄 Raw Prompt (Complete)');
-        lines.push('');
-        lines.push('```');
-        lines.push(debug.prompt);
-        lines.push('```');
-        lines.push('');
-        lines.push('## 📄 Raw Response (Complete)');
-        lines.push('');
-        lines.push('```');
-        lines.push(debug.rawResponse);
-        lines.push('```');
-        lines.push('');
-        return lines.join('\n');
-    }
-    parseCheckSections(combinedText) {
-        const sections = [];
-        // Split by check sections like [security], [performance], etc.
-        const parts = combinedText.split(/\[(\w+)\]\s*\n/);
-        for (let i = 1; i < parts.length; i += 2) {
-            const checkName = parts[i];
-            const content = parts[i + 1]?.trim() || '';
-            if (checkName && content) {
-                sections.push({ checkName, content });
-            }
-        }
-        return sections;
-    }
-    formatIssuesTable(comments) {
-        let content = `## 🔍 Code Analysis Results\n\n`;
-        // Group comments by check (extracted from ruleId prefix)
-        const groupedComments = this.groupCommentsByCheck(comments);
-        // Create a table for each check that has issues
-        for (const [checkName, checkComments] of Object.entries(groupedComments)) {
-            if (checkComments.length === 0)
-                continue;
-            const checkTitle = checkName.charAt(0).toUpperCase() + checkName.slice(1);
-            // Check heading
-            content += `### ${checkTitle} Issues (${checkComments.length})\n\n`;
-            // Start HTML table for this category
-            content += `<table>\n`;
-            content += `  <thead>\n`;
-            content += `    <tr>\n`;
-            content += `      <th>Severity</th>\n`;
-            content += `      <th>File</th>\n`;
-            content += `      <th>Line</th>\n`;
-            content += `      <th>Issue</th>\n`;
-            content += `    </tr>\n`;
-            content += `  </thead>\n`;
-            content += `  <tbody>\n`;
-            // Sort comments within check by severity, then by file
-            const sortedCheckComments = checkComments.sort((a, b) => {
-                const severityOrder = { critical: 0, error: 1, warning: 2, info: 3 };
-                const severityDiff = (severityOrder[a.severity] || 4) - (severityOrder[b.severity] || 4);
-                if (severityDiff !== 0)
-                    return severityDiff;
-                return a.file.localeCompare(b.file);
-            });
-            for (const comment of sortedCheckComments) {
-                const severityEmoji = comment.severity === 'critical'
-                    ? '🔴'
-                    : comment.severity === 'error'
-                        ? '🔴'
-                        : comment.severity === 'warning'
-                            ? '🟡'
-                            : '🟢';
-                const severityText = comment.severity.charAt(0).toUpperCase() + comment.severity.slice(1);
-                // Build the issue description with suggestion/replacement if available
-                // Wrap content in a div for better table layout control
-                let issueContent = '';
-                // Pass the message as-is - Liquid template will handle escaping
-                issueContent += comment.message;
-                if (comment.suggestion) {
-                    // Pass suggestion as-is - Liquid template will handle escaping
-                    issueContent += `\n<details><summary>💡 <strong>Suggestion</strong></summary>${comment.suggestion}</details>`;
-                }
-                if (comment.replacement) {
-                    // Extract language hint from file extension
-                    const fileExt = comment.file.split('.').pop()?.toLowerCase() || 'text';
-                    const languageHint = this.getLanguageHint(fileExt);
-                    // Pass replacement as-is - Liquid template will handle escaping
-                    issueContent += `\n<details><summary>🔧 <strong>Suggested Fix</strong></summary><pre><code class="language-${languageHint}">${comment.replacement}</code></pre></details>`;
-                }
-                // Wrap all content in a div for better table cell containment
-                const issueDescription = `<div>${issueContent}</div>`;
-                content += `    <tr>\n`;
-                content += `      <td>${severityEmoji} ${severityText}</td>\n`;
-                content += `      <td><code>${comment.file}</code></td>\n`;
-                content += `      <td>${comment.line}</td>\n`;
-                content += `      <td>${issueDescription}</td>\n`;
-                content += `    </tr>\n`;
-            }
-            // Close HTML table for this category
-            content += `  </tbody>\n`;
-            content += `</table>\n\n`;
-            // No hardcoded recommendations - all guidance comes from .visor.yaml prompts
-        }
-        return content;
-    }
-    getLanguageHint(fileExtension) {
-        const langMap = {
-            ts: 'typescript',
-            tsx: 'typescript',
-            js: 'javascript',
-            jsx: 'javascript',
-            py: 'python',
-            java: 'java',
-            kt: 'kotlin',
-            swift: 'swift',
-            go: 'go',
-            rs: 'rust',
-            cpp: 'cpp',
-            c: 'c',
-            cs: 'csharp',
-            php: 'php',
-            rb: 'ruby',
-            scala: 'scala',
-            sh: 'bash',
-            bash: 'bash',
-            zsh: 'bash',
-            sql: 'sql',
-            json: 'json',
-            yaml: 'yaml',
-            yml: 'yaml',
-            xml: 'xml',
-            html: 'html',
-            css: 'css',
-            scss: 'scss',
-            sass: 'sass',
-            md: 'markdown',
-            dockerfile: 'dockerfile',
-            tf: 'hcl',
-        };
-        return langMap[fileExtension] || fileExtension;
-    }
-    /**
-     * Load custom template content from file or raw content
-     */
-    async loadCustomTemplate(config) {
-        if (config.content) {
-            // Auto-detect if content is actually a file path
-            if (await this.isFilePath(config.content)) {
-                return await this.loadTemplateFromFile(config.content);
-            }
-            else {
-                // Use raw template content directly
-                return config.content;
-            }
-        }
-        if (config.file) {
-            // Legacy explicit file property
-            return await this.loadTemplateFromFile(config.file);
-        }
-        throw new Error('Custom template configuration must specify either "file" or "content"');
-    }
-    /**
-     * Detect if a string is likely a file path and if the file exists
-     */
-    async isFilePath(str) {
-        // Quick checks to exclude obvious non-file-path content
-        if (!str || str.trim() !== str || str.length > 512) {
-            return false;
-        }
-        // Exclude strings that are clearly content (contain common content indicators)
-        // But be more careful with paths that might contain common words as directory names
-        if (/\s{2,}/.test(str) || // Multiple consecutive spaces
-            /\n/.test(str) || // Contains newlines
-            /^(please|analyze|review|check|find|identify|look|search)/i.test(str.trim()) || // Starts with command words
-            str.split(' ').length > 8 // Too many words for a typical file path
-        ) {
-            return false;
-        }
-        // For strings with path separators, be more lenient about common words
-        // as they might be legitimate directory names
-        if (!/[\/\\]/.test(str)) {
-            // Only apply strict English word filter to non-path strings
-            if (/\b(the|and|or|but|for|with|by|from|in|on|at|as)\b/i.test(str)) {
-                return false;
-            }
-        }
-        // Positive indicators for file paths
-        const hasFileExtension = /\.[a-zA-Z0-9]{1,10}$/i.test(str);
-        const hasPathSeparators = /[\/\\]/.test(str);
-        const isRelativePath = /^\.{1,2}\//.test(str);
-        const isAbsolutePath = path_1.default.isAbsolute(str);
-        const hasTypicalFileChars = /^[a-zA-Z0-9._\-\/\\:~]+$/.test(str);
-        // Must have at least one strong indicator
-        if (!(hasFileExtension || isRelativePath || isAbsolutePath || hasPathSeparators)) {
-            return false;
-        }
-        // Must contain only typical file path characters
-        if (!hasTypicalFileChars) {
-            return false;
-        }
-        // Additional validation for suspected file paths
-        try {
-            // Try to resolve and check if file exists
-            let resolvedPath;
-            if (path_1.default.isAbsolute(str)) {
-                resolvedPath = path_1.default.normalize(str);
-            }
-            else {
-                // Resolve relative to current working directory
-                resolvedPath = path_1.default.resolve(process.cwd(), str);
-            }
-            // Check if file exists
-            try {
-                const stat = await promises_1.default.stat(resolvedPath);
-                return stat.isFile();
-            }
-            catch {
-                // File doesn't exist, but might still be a valid file path format
-                // Return true if it has strong file path indicators
-                return hasFileExtension && (isRelativePath || isAbsolutePath || hasPathSeparators);
-            }
-        }
-        catch {
-            return false;
-        }
-    }
-    /**
-     * Safely load template from file with security checks
-     */
-    async loadTemplateFromFile(templatePath) {
-        // Resolve the path (handles both relative and absolute paths)
-        let resolvedPath;
-        if (path_1.default.isAbsolute(templatePath)) {
-            // Absolute path - use as-is but validate it's not trying to escape expected directories
-            resolvedPath = path_1.default.normalize(templatePath);
-        }
-        else {
-            // Relative path - resolve relative to current working directory
-            resolvedPath = path_1.default.resolve(process.cwd(), templatePath);
-        }
-        // Security: Normalize and check for path traversal attempts
-        const normalizedPath = path_1.default.normalize(resolvedPath);
-        // Security: For relative paths, ensure they don't escape the current directory
-        if (!path_1.default.isAbsolute(templatePath)) {
-            const currentDir = path_1.default.resolve(process.cwd());
-            if (!normalizedPath.startsWith(currentDir)) {
-                throw new Error('Invalid template file path: path traversal detected');
-            }
-        }
-        // Security: Additional check for obvious path traversal patterns
-        if (templatePath.includes('../..')) {
-            throw new Error('Invalid template file path: path traversal detected');
-        }
-        // Security: Check file extension
-        if (!normalizedPath.endsWith('.liquid')) {
-            throw new Error('Invalid template file: must have .liquid extension');
-        }
-        try {
-            const templateContent = await promises_1.default.readFile(normalizedPath, 'utf-8');
-            return templateContent;
-        }
-        catch (error) {
-            throw new Error(`Failed to load custom template from ${normalizedPath}: ${error instanceof Error ? error.message : 'Unknown error'}`);
-        }
-    }
 }
 exports.PRReviewer = PRReviewer;
 //# sourceMappingURL=reviewer.js.map