@probelabs/visor 0.1.10 → 0.1.18

package/README.md

@@ -1011,6 +1011,84 @@ checks:
 - **Structured Output**: JSON Schema validation ensures consistent data
 - **Flexible Rendering**: Different templates for different output types
 
+### GitHub Integration Schema Requirements
+
+Visor is **fully schema-agnostic** - checks can return any structure and templates handle all formatting logic. However, for GitHub Checks API integration (status checks, outputs), specific structure may be required:
+
+#### Unstructured Checks (No Schema / Plain Schema)
+```yaml
+# ✅ No-schema and plain schema behave identically
+overview:
+  type: ai
+  # No schema - returns raw markdown directly to PR comments
+  prompt: "Analyze this PR and provide an overview"
+
+documentation:
+  type: ai
+  schema: plain  # Equivalent to no schema
+  prompt: "Generate documentation for these changes"
+```
+
+**Behavior**: AI returns raw text/markdown → Posted as-is to PR comments → GitHub integration reports 0 issues
+
+#### Structured Checks (GitHub Checks API Compatible)
+```yaml
+security:
+  type: ai
+  schema: code-review  # Built-in schema, works out of the box
+  prompt: "Review for security issues and return findings as JSON"
+
+# Custom schema example
+custom-check:
+  type: ai
+  schema: |
+    {
+      "$schema": "http://json-schema.org/draft-07/schema#",
+      "type": "object",
+      "required": ["issues"],
+      "properties": {
+        "issues": {
+          "type": "array",
+          "items": {
+            "type": "object",
+            "required": ["file", "line", "message", "severity"],
+            "properties": {
+              "file": { "type": "string" },
+              "line": { "type": "integer" },
+              "ruleId": { "type": "string" },
+              "message": { "type": "string" },
+              "severity": { "enum": ["critical", "error", "warning", "info"] },
+              "category": { "type": "string" }
+            }
+          }
+        }
+      }
+    }
+  prompt: "Review the code and return JSON matching the schema"
+```
+
+**Required Structure for GitHub Checks API Integration**:
+- `issues`: Array of issue objects (required for GitHub status checks)
+- `issues[].severity`: Must be `"critical"`, `"error"`, `"warning"`, or `"info"`
+- `issues[].file`: File path (required for GitHub annotations)
+- `issues[].line`: Line number (required for GitHub annotations)
+- `issues[].message`: Issue description (required for GitHub annotations)
+
+#### GitHub Checks API Features
+When checks return the structured format above:
+- ✅ **GitHub Status Checks**: Pass/fail based on severity thresholds
+- ✅ **GitHub Annotations**: Issues appear as file annotations in PR
+- ✅ **Action Outputs**: `issues-found`, `critical-issues-found` outputs
+- ✅ **PR Comments**: Structured table format with issue details
+
+#### Schema Behavior Summary
+| Schema Type | AI Output | Comment Rendering | GitHub Checks API |
+|-------------|-----------|-------------------|-------------------|
+| **None/Plain** | Raw text/markdown | ✅ Posted as-is | ❌ No status checks, 0 issues |
+| **Structured** | JSON with `issues[]` | ✅ Table format | ✅ Full GitHub integration |
+
+**Key Design**: Use unstructured (none/plain) for narrative content like overviews and documentation. Use structured schemas for actionable code review findings that integrate with GitHub's checking system.
+
 ## 🧠 Advanced AI Features
 
 ### XML-Formatted Analysis

package/defaults/.visor.yaml

@@ -22,6 +22,49 @@ max_parallelism: 1
 fail_if: "output.issues && output.issues.some(i => i.severity === 'critical')"
 
 checks:
+  # AI-powered release notes generation - manual execution only for release workflows
+  release-notes:
+    type: ai
+    group: release
+    schema: plain
+    prompt: |
+      Generate professional release notes for version {{ env.TAG_NAME }} of this project.
+
+      Analyze the git commits since the last release:
+      ```
+      {{ env.GIT_LOG }}
+      ```
+
+      And the file changes summary:
+      ```
+      {{ env.GIT_DIFF_STAT }}
+      ```
+
+      Create release notes with these sections:
+
+      ## 🚀 What's New in {{ env.TAG_NAME }}
+
+      ### ✨ New Features
+      List any new features added (look for feat: commits)
+
+      ### 🐛 Bug Fixes
+      List any bugs fixed (look for fix: commits)
+
+      ### 📈 Improvements
+      List any improvements or refactoring (look for refactor:, perf:, chore:, build: commits)
+
+      ### 🔥 Breaking Changes
+      List any breaking changes if present (look for BREAKING CHANGE or ! in commits)
+
+      ### 📊 Statistics
+      - Number of commits since last release
+      - Number of contributors involved
+      - Number of files changed
+
+      Keep descriptions concise and user-friendly. Focus on what changed from a user perspective, not implementation details.
+      Use present tense and action-oriented language. Group similar changes together.
+    on: [manual]
+
   # PR overview with intelligent analysis - runs first to establish context
   overview:
     type: ai
@@ -198,10 +241,21 @@ checks:
     reuse_ai_session: true  # 🔄 Reuses the performance check's AI session for context continuity
     on: [pr_opened, pr_updated]
 
+  # Command orchestrator - demonstrates noop type for triggering multiple checks
+  review-all:
+    type: noop
+    command: '/review'
+    depends_on: [overview, security, performance, quality]
+    on: [issue_comment]
+    if: "event.isPullRequest"  # Only trigger on PR comments, not issues
+    group: orchestrator
+
   # Intelligent Issue Assistant - provides sophisticated issue triage and assistance
   issue-assistant:
     type: ai
     group: issue-support
+    command: "ask"
+    if: "event.name === 'issues' && event.action === 'opened' || (event.name === 'issue_comment' && event.comment && event.comment.body && event.comment.body.trim().startsWith('/ask'))"
     prompt: |
         You are an intelligent GitHub issue assistant for the {{ event.repository.fullName }} repository. Your role is to provide professional, knowledgeable assistance based on the trigger event.
 

package/dist/ai-review-service.d.ts

@@ -33,6 +33,10 @@ export interface AIDebugInfo {
     schema?: string;
     /** Schema name/type requested */
     schemaName?: string;
+    /** Checks executed during this review */
+    checksExecuted?: string[];
+    /** Whether parallel execution was used */
+    parallelExecution?: boolean;
     /** Timestamp when request was made */
     timestamp: string;
     /** Total API calls made */
@@ -94,6 +98,15 @@ export declare class AIReviewService {
      * Parse AI response JSON
      */
     private parseAIResponse;
+    /**
+     * Extract JSON from a response that might contain surrounding text
+     * Uses proper bracket matching to find valid JSON objects or arrays
+     */
+    private extractJsonFromResponse;
+    /**
+     * Find JSON with proper bracket matching to avoid false positives
+     */
+    private findJsonWithBracketMatching;
     /**
      * Generate mock response for testing
      */

package/dist/ai-review-service.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"ai-review-service.d.ts","sourceRoot":"","sources":["../src/ai-review-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAC;AAE9C,OAAO,EAAE,MAAM,EAAE,MAAM,eAAe,CAAC;AACvC,OAAO,EAAE,aAAa,EAAe,MAAM,YAAY,CAAC;AAcxD,MAAM,WAAW,cAAc;IAC7B,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,QAAQ,CAAC,EAAE,QAAQ,GAAG,WAAW,GAAG,QAAQ,GAAG,MAAM,CAAC;IACtD,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED,MAAM,WAAW,WAAW;IAC1B,gCAAgC;IAChC,MAAM,EAAE,MAAM,CAAC;IACf,uCAAuC;IACvC,WAAW,EAAE,MAAM,CAAC;IACpB,gDAAgD;IAChD,QAAQ,EAAE,MAAM,CAAC;IACjB,iBAAiB;IACjB,KAAK,EAAE,MAAM,CAAC;IACd,4DAA4D;IAC5D,YAAY,EAAE,MAAM,CAAC;IACrB,sCAAsC;IACtC,cAAc,EAAE,MAAM,CAAC;IACvB,kCAAkC;IAClC,YAAY,EAAE,MAAM,CAAC;IACrB,oCAAoC;IACpC,cAAc,EAAE,MAAM,CAAC;IACvB,6BAA6B;IAC7B,MAAM,CAAC,EAAE,MAAM,EAAE,CAAC;IAClB,qCAAqC;IACrC,gBAAgB,EAAE,OAAO,CAAC;IAC1B,0CAA0C;IAC1C,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,iCAAiC;IACjC,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,sCAAsC;IACtC,SAAS,EAAE,MAAM,CAAC;IAClB,2BAA2B;IAC3B,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,mCAAmC;IACnC,cAAc,CAAC,EAAE,KAAK,CAAC;QACrB,SAAS,EAAE,MAAM,CAAC;QAClB,QAAQ,EAAE,MAAM,CAAC;QACjB,KAAK,EAAE,MAAM,CAAC;QACd,cAAc,EAAE,MAAM,CAAC;QACvB,OAAO,EAAE,OAAO,CAAC;KAClB,CAAC,CAAC;CACJ;AAoBD,qBAAa,eAAe;IAC1B,OAAO,CAAC,MAAM,CAAiB;IAC/B,OAAO,CAAC,eAAe,CAAkB;gBAE7B,MAAM,GAAE,cAAmB;IA4BvC;;OAEG;IACG,aAAa,CACjB,MAAM,EAAE,MAAM,EACd,YAAY,EAAE,MAAM,EACpB,MAAM,CAAC,EAAE,MAAM,EACf,UAAU,CAAC,EAAE,MAAM,EACnB,SAAS,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,aAAa,CAAC;IA6GzB;;OAEG;IACG,6BAA6B,CACjC,MAAM,EAAE,MAAM,EACd,YAAY,EAAE,MAAM,EACpB,eAAe,EAAE,MAAM,EACvB,MAAM,CAAC,EAAE,MAAM,EACf,SAAS,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,aAAa,CAAC;IAyFzB;;OAEG;IACH,eAAe,CAAC,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,UAAU,GAAG,IAAI;IAI3D;;OAEG;IACH,cAAc,CAAC,SAAS,EAAE,MAAM,GAAG,IAAI;IAIvC;;OAEG;YACW,iBAAiB;IA8C/B;;OAEG;IACH,OAAO,CAAC,eAAe;IAoEvB;;OAEG;IACH,OAAO,CAAC,SAAS;IAIjB;;OAEG;YACW,iCAAiC;IAiE/C;;OAEG;YACW,cAAc;IA0J5B;;OAEG;YACW,iBAAiB;IAwB/B;;OAEG;IACH,OAAO,CAAC,eAAe;IAuMvB;;OAEG;YACW,oBAAoB;IAgDlC;;OAEG;IACH,OAAO,CAAC,eAAe;CAYxB"}
+{"version":3,"file":"ai-review-service.d.ts","sourceRoot":"","sources":["../src/ai-review-service.ts"],"names":[],"mappings":"AAAA,OAAO,EAAE,UAAU,EAAE,MAAM,kBAAkB,CAAC;AAE9C,OAAO,EAAE,MAAM,EAAE,MAAM,eAAe,CAAC;AACvC,OAAO,EAAE,aAAa,EAAe,MAAM,YAAY,CAAC;AAcxD,MAAM,WAAW,cAAc;IAC7B,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,KAAK,CAAC,EAAE,MAAM,CAAC;IACf,OAAO,CAAC,EAAE,MAAM,CAAC;IACjB,QAAQ,CAAC,EAAE,QAAQ,GAAG,WAAW,GAAG,QAAQ,GAAG,MAAM,CAAC;IACtD,KAAK,CAAC,EAAE,OAAO,CAAC;CACjB;AAED,MAAM,WAAW,WAAW;IAC1B,gCAAgC;IAChC,MAAM,EAAE,MAAM,CAAC;IACf,uCAAuC;IACvC,WAAW,EAAE,MAAM,CAAC;IACpB,gDAAgD;IAChD,QAAQ,EAAE,MAAM,CAAC;IACjB,iBAAiB;IACjB,KAAK,EAAE,MAAM,CAAC;IACd,4DAA4D;IAC5D,YAAY,EAAE,MAAM,CAAC;IACrB,sCAAsC;IACtC,cAAc,EAAE,MAAM,CAAC;IACvB,kCAAkC;IAClC,YAAY,EAAE,MAAM,CAAC;IACrB,oCAAoC;IACpC,cAAc,EAAE,MAAM,CAAC;IACvB,6BAA6B;IAC7B,MAAM,CAAC,EAAE,MAAM,EAAE,CAAC;IAClB,qCAAqC;IACrC,gBAAgB,EAAE,OAAO,CAAC;IAC1B,0CAA0C;IAC1C,MAAM,CAAC,EAAE,MAAM,CAAC;IAChB,iCAAiC;IACjC,UAAU,CAAC,EAAE,MAAM,CAAC;IACpB,yCAAyC;IACzC,cAAc,CAAC,EAAE,MAAM,EAAE,CAAC;IAC1B,0CAA0C;IAC1C,iBAAiB,CAAC,EAAE,OAAO,CAAC;IAC5B,sCAAsC;IACtC,SAAS,EAAE,MAAM,CAAC;IAClB,2BAA2B;IAC3B,aAAa,CAAC,EAAE,MAAM,CAAC;IACvB,mCAAmC;IACnC,cAAc,CAAC,EAAE,KAAK,CAAC;QACrB,SAAS,EAAE,MAAM,CAAC;QAClB,QAAQ,EAAE,MAAM,CAAC;QACjB,KAAK,EAAE,MAAM,CAAC;QACd,cAAc,EAAE,MAAM,CAAC;QACvB,OAAO,EAAE,OAAO,CAAC;KAClB,CAAC,CAAC;CACJ;AAoBD,qBAAa,eAAe;IAC1B,OAAO,CAAC,MAAM,CAAiB;IAC/B,OAAO,CAAC,eAAe,CAAkB;gBAE7B,MAAM,GAAE,cAAmB;IA4BvC;;OAEG;IACG,aAAa,CACjB,MAAM,EAAE,MAAM,EACd,YAAY,EAAE,MAAM,EACpB,MAAM,CAAC,EAAE,MAAM,EACf,UAAU,CAAC,EAAE,MAAM,EACnB,SAAS,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,aAAa,CAAC;IAmHzB;;OAEG;IACG,6BAA6B,CACjC,MAAM,EAAE,MAAM,EACd,YAAY,EAAE,MAAM,EACpB,eAAe,EAAE,MAAM,EACvB,MAAM,CAAC,EAAE,MAAM,EACf,SAAS,CAAC,EAAE,MAAM,GACjB,OAAO,CAAC,aAAa,CAAC;IAyFzB;;OAEG;IACH,eAAe,CAAC,SAAS,EAAE,MAAM,EAAE,KAAK,EAAE,UAAU,GAAG,IAAI;IAI3D;;OAEG;IACH,cAAc,CAAC,SAAS,EAAE,MAAM,GAAG,IAAI;IAIvC;;OAEG;YACW,iBAAiB;IA8C/B;;OAEG;IACH,OAAO,CAAC,eAAe;IAoEvB;;OAEG;IACH,OAAO,CAAC,SAAS;IAIjB;;OAEG;YACW,iCAAiC;IAuE/C;;OAEG;YACW,cAAc;IAgK5B;;OAEG;YACW,iBAAiB;IAwB/B;;OAEG;IACH,OAAO,CAAC,eAAe;IAmMvB;;;OAGG;IACH,OAAO,CAAC,uBAAuB;IAc/B;;OAEG;IACH,OAAO,CAAC,2BAA2B;IAqDnC;;OAEG;YACW,oBAAoB;IAgDlC;;OAEG;IACH,OAAO,CAAC,eAAe;CAYxB"}

package/dist/ai-review-service.js

@@ -104,14 +104,14 @@ class AIReviewService {
             }
         }
         try {
-            const response = await this.callProbeAgent(prompt, schema, debugInfo, _checkName, sessionId);
+            const { response, effectiveSchema } = await this.callProbeAgent(prompt, schema, debugInfo, _checkName, sessionId);
             const processingTime = Date.now() - startTime;
             if (debugInfo) {
                 debugInfo.rawResponse = response;
                 debugInfo.responseLength = response.length;
                 debugInfo.processingTime = processingTime;
             }
-            const result = this.parseAIResponse(response, debugInfo, schema);
+            const result = this.parseAIResponse(response, debugInfo, effectiveSchema);
             if (debugInfo) {
                 result.debug = debugInfo;
             }
@@ -176,14 +176,14 @@ class AIReviewService {
         }
         try {
             // Use existing agent's answer method instead of creating new agent
-            const response = await this.callProbeAgentWithExistingSession(existingAgent, prompt, schema, debugInfo, checkName);
+            const { response, effectiveSchema } = await this.callProbeAgentWithExistingSession(existingAgent, prompt, schema, debugInfo, checkName);
             const processingTime = Date.now() - startTime;
             if (debugInfo) {
                 debugInfo.rawResponse = response;
                 debugInfo.responseLength = response.length;
                 debugInfo.processingTime = processingTime;
             }
-            const result = this.parseAIResponse(response, debugInfo, schema);
+            const result = this.parseAIResponse(response, debugInfo, effectiveSchema);
             if (debugInfo) {
                 result.debug = debugInfo;
             }
@@ -343,16 +343,18 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
         // Handle mock model/provider for testing
         if (this.config.model === 'mock' || this.config.provider === 'mock') {
             log('🎭 Using mock AI model/provider for testing (session reuse)');
-            return this.generateMockResponse(prompt);
+            const response = await this.generateMockResponse(prompt);
+            return { response, effectiveSchema: schema };
         }
         log('🔄 Reusing existing ProbeAgent session for AI review...');
         log(`📝 Prompt length: ${prompt.length} characters`);
         log(`⚙️ Model: ${this.config.model || 'default'}, Provider: ${this.config.provider || 'auto'}`);
         try {
             log('🚀 Calling existing ProbeAgent with answer()...');
-            // Load and pass the actual schema content if provided
+            // Load and pass the actual schema content if provided (skip for plain schema)
             let schemaString = undefined;
-            if (schema) {
+            let effectiveSchema = schema;
+            if (schema && schema !== 'plain') {
                 try {
                     schemaString = await this.loadSchemaContent(schema);
                     log(`📋 Loaded schema content for: ${schema}`);
@@ -361,11 +363,15 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
                 catch (error) {
                     log(`⚠️ Failed to load schema ${schema}, proceeding without schema:`, error);
                     schemaString = undefined;
+                    effectiveSchema = undefined; // Schema loading failed, treat as no schema
                     if (debugInfo && debugInfo.errors) {
                         debugInfo.errors.push(`Failed to load schema: ${error}`);
                     }
                 }
             }
+            else if (schema === 'plain') {
+                log(`📋 Using plain schema - no JSON validation will be applied`);
+            }
             // Pass schema in options object with 'schema' property
             const schemaOptions = schemaString ? { schema: schemaString } : undefined;
             // Store the exact schema options being passed to ProbeAgent in debug info
@@ -381,7 +387,7 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
             const response = await agent.answer(prompt, undefined, schemaOptions);
             log('✅ ProbeAgent session reuse completed successfully');
             log(`📤 Response length: ${response.length} characters`);
-            return response;
+            return { response, effectiveSchema };
         }
         catch (error) {
             console.error('❌ ProbeAgent session reuse failed:', error);
@@ -395,7 +401,8 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
         // Handle mock model/provider for testing
         if (this.config.model === 'mock' || this.config.provider === 'mock') {
             log('🎭 Using mock AI model/provider for testing');
-            return this.generateMockResponse(prompt);
+            const response = await this.generateMockResponse(prompt);
+            return { response, effectiveSchema: schema };
         }
         // Create ProbeAgent instance with proper options
         const sessionId = providedSessionId ||
@@ -440,9 +447,10 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
             }
             const agent = new probe_1.ProbeAgent(options);
             log('🚀 Calling ProbeAgent...');
-            // Load and pass the actual schema content if provided
+            // Load and pass the actual schema content if provided (skip for plain schema)
             let schemaString = undefined;
-            if (schema) {
+            let effectiveSchema = schema;
+            if (schema && schema !== 'plain') {
                 try {
                     schemaString = await this.loadSchemaContent(schema);
                     log(`📋 Loaded schema content for: ${schema}`);
@@ -451,11 +459,15 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
                 catch (error) {
                     log(`⚠️ Failed to load schema ${schema}, proceeding without schema:`, error);
                     schemaString = undefined;
+                    effectiveSchema = undefined; // Schema loading failed, treat as no schema
                     if (debugInfo && debugInfo.errors) {
                         debugInfo.errors.push(`Failed to load schema: ${error}`);
                     }
                 }
             }
+            else if (schema === 'plain') {
+                log(`📋 Using plain schema - no JSON validation will be applied`);
+            }
             // ProbeAgent now handles schema formatting internally!
             // Pass schema in options object with 'schema' property
             const schemaOptions = schemaString ? { schema: schemaString } : undefined;
@@ -504,7 +516,7 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
                 this.registerSession(sessionId, agent);
                 log(`🔧 Debug: Registered AI session for potential reuse: ${sessionId}`);
             }
-            return response;
+            return { response, effectiveSchema };
         }
         catch (error) {
             console.error('❌ ProbeAgent failed:', error);
@@ -561,43 +573,27 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
         try {
             // Handle different schema types differently
             let reviewData;
+            // Handle plain schema or no schema - no JSON parsing, return response as-is
+            if (_schema === 'plain' || !_schema) {
+                log(`📋 ${_schema === 'plain' ? 'Plain' : 'No'} schema detected - returning raw response without JSON parsing`);
+                return {
+                    issues: [],
+                    suggestions: [response.trim()],
+                    debug: debugInfo,
+                };
+            }
             {
                 // For other schemas (code-review, etc.), extract and parse JSON with boundary detection
                 log('🔍 Extracting JSON from AI response...');
-                // Simple JSON extraction: find first { or [ and last } or ], with {} taking priority
-                let jsonString = response.trim();
-                // Find the first occurrence of { or [
-                const firstBrace = jsonString.indexOf('{');
-                const firstBracket = jsonString.indexOf('[');
-                let startIndex = -1;
-                let endChar = '';
-                // Determine which comes first (or if only one exists), {} takes priority
-                if (firstBrace !== -1 && (firstBracket === -1 || firstBrace < firstBracket)) {
-                    // Object comes first or only objects exist
-                    startIndex = firstBrace;
-                    endChar = '}';
-                }
-                else if (firstBracket !== -1) {
-                    // Array comes first or only arrays exist
-                    startIndex = firstBracket;
-                    endChar = ']';
-                }
-                if (startIndex !== -1) {
-                    // Find the last occurrence of the matching end character
-                    const lastEndIndex = jsonString.lastIndexOf(endChar);
-                    if (lastEndIndex !== -1 && lastEndIndex > startIndex) {
-                        jsonString = jsonString.substring(startIndex, lastEndIndex + 1);
-                    }
-                }
-                // Parse the extracted JSON
+                // Try direct parsing first - if AI returned pure JSON
                 try {
-                    reviewData = JSON.parse(jsonString);
-                    log('✅ Successfully parsed probe agent JSON response');
+                    reviewData = JSON.parse(response.trim());
+                    log('✅ Successfully parsed direct JSON response');
                     if (debugInfo)
                         debugInfo.jsonParseSuccess = true;
                 }
-                catch (initialError) {
-                    log('🔍 Initial parsing failed, trying to extract JSON from response...');
+                catch {
+                    log('🔍 Direct parsing failed, trying to extract JSON from response...');
                     // If the response starts with "I cannot" or similar, it's likely a refusal
                     if (response.toLowerCase().includes('i cannot') ||
                         response.toLowerCase().includes('unable to')) {
@@ -609,38 +605,50 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
                             ],
                         };
                     }
-                    // Try to find JSON within the response
-                    const jsonMatches = response.match(/\{[\s\S]*\}/g);
-                    if (jsonMatches && jsonMatches.length > 0) {
-                        log('🔧 Found potential JSON in response, attempting to parse...');
-                        // Try the largest JSON-like string (likely the complete response)
-                        const largestJson = jsonMatches.reduce((a, b) => (a.length > b.length ? a : b));
-                        log('🔧 Attempting to parse extracted JSON...');
-                        reviewData = JSON.parse(largestJson);
-                        log('✅ Successfully parsed extracted JSON');
-                        if (debugInfo)
-                            debugInfo.jsonParseSuccess = true;
-                    }
-                    else {
-                        // Check if response is plain text and doesn't contain structured data
-                        if (!response.includes('{') && !response.includes('}')) {
-                            log('🔧 Plain text response detected, creating structured fallback...');
-                            const isNoChanges = response.toLowerCase().includes('no') &&
-                                (response.toLowerCase().includes('changes') ||
-                                    response.toLowerCase().includes('code'));
-                            reviewData = {
-                                issues: [],
-                                suggestions: isNoChanges
-                                    ? ['No code changes detected in this analysis']
-                                    : [
-                                        `AI response: ${response.substring(0, 200)}${response.length > 200 ? '...' : ''}`,
-                                    ],
-                            };
+                    // Try to extract JSON using improved method with proper bracket matching
+                    const jsonString = this.extractJsonFromResponse(response);
+                    if (jsonString) {
+                        try {
+                            reviewData = JSON.parse(jsonString);
+                            log('✅ Successfully parsed extracted JSON');
+                            if (debugInfo)
+                                debugInfo.jsonParseSuccess = true;
                         }
-                        else {
-                            throw initialError;
+                        catch {
+                            log('🔧 Extracted JSON parsing failed, falling back to plain text handling...');
+                            // Check if response is plain text and doesn't contain structured data
+                            if (!response.includes('{') && !response.includes('}')) {
+                                log('🔧 Plain text response detected, creating structured fallback...');
+                                const isNoChanges = response.toLowerCase().includes('no') &&
+                                    (response.toLowerCase().includes('changes') ||
+                                        response.toLowerCase().includes('code'));
+                                reviewData = {
+                                    issues: [],
+                                    suggestions: isNoChanges
+                                        ? ['No code changes detected in this analysis']
+                                        : [
+                                            `AI response: ${response.substring(0, 200)}${response.length > 200 ? '...' : ''}`,
+                                        ],
+                                };
+                            }
+                            else {
+                                // Fallback: treat the entire response as a suggestion
+                                log('🔧 Creating fallback response from non-JSON content...');
+                                reviewData = {
+                                    issues: [],
+                                    suggestions: [response.trim()],
+                                };
+                            }
                         }
                     }
+                    else {
+                        // No JSON found at all - treat as plain text response
+                        log('🔧 No JSON found in response, treating as plain text...');
+                        reviewData = {
+                            issues: [],
+                            suggestions: [response.trim()],
+                        };
+                    }
                 }
             }
             // Standard code-review schema processing
@@ -673,11 +681,11 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
                 suggestions: Array.isArray(reviewData.suggestions) ? reviewData.suggestions : [],
             };
             // Log issue counts
-            const criticalCount = result.issues.filter(i => i.severity === 'critical').length;
+            const criticalCount = (result.issues || []).filter(i => i.severity === 'critical').length;
             if (criticalCount > 0) {
                 log(`🚨 Found ${criticalCount} critical severity issue(s)`);
             }
-            log(`📈 Total issues: ${result.issues.length}`);
+            log(`📈 Total issues: ${(result.issues || []).length}`);
             log('✅ Successfully created ReviewSummary');
             return result;
         }
@@ -717,6 +725,67 @@ ${prInfo.fullDiff ? this.escapeXml(prInfo.fullDiff) : ''}
             throw new Error(`Invalid AI response format: ${error instanceof Error ? error.message : 'Unknown error'}`);
         }
     }
+    /**
+     * Extract JSON from a response that might contain surrounding text
+     * Uses proper bracket matching to find valid JSON objects or arrays
+     */
+    extractJsonFromResponse(response) {
+        const text = response.trim();
+        // Try to find JSON objects first (higher priority)
+        let bestJson = this.findJsonWithBracketMatching(text, '{', '}');
+        // If no object found, try arrays
+        if (!bestJson) {
+            bestJson = this.findJsonWithBracketMatching(text, '[', ']');
+        }
+        return bestJson;
+    }
+    /**
+     * Find JSON with proper bracket matching to avoid false positives
+     */
+    findJsonWithBracketMatching(text, openChar, closeChar) {
+        const firstIndex = text.indexOf(openChar);
+        if (firstIndex === -1)
+            return null;
+        let depth = 0;
+        let inString = false;
+        let escaping = false;
+        for (let i = firstIndex; i < text.length; i++) {
+            const char = text[i];
+            if (escaping) {
+                escaping = false;
+                continue;
+            }
+            if (char === '\\' && inString) {
+                escaping = true;
+                continue;
+            }
+            if (char === '"' && !escaping) {
+                inString = !inString;
+                continue;
+            }
+            if (!inString) {
+                if (char === openChar) {
+                    depth++;
+                }
+                else if (char === closeChar) {
+                    depth--;
+                    if (depth === 0) {
+                        // Found matching closing bracket
+                        const candidate = text.substring(firstIndex, i + 1);
+                        try {
+                            JSON.parse(candidate); // Validate it's actually valid JSON
+                            return candidate;
+                        }
+                        catch {
+                            // This wasn't valid JSON, keep looking
+                            break;
+                        }
+                    }
+                }
+            }
+        }
+        return null;
+    }
     /**
      * Generate mock response for testing
      */