@polymorphism-tech/morph-spec 2.4.0 → 3.0.0

package/src/lib/validation-runner.js

@@ -11,17 +11,32 @@ import { existsSync, readFileSync } from 'fs';
 import { join } from 'path';
 import chalk from 'chalk';
 import { loadState } from './state-manager.js';
+import { loadConstraints } from './decision-constraint-loader.js';
 
 /**
- * Validator registry — maps agent IDs to the validators they activate
+ * Load agent → validators map from agents.json (data-driven)
+ * @param {string} projectPath - Root path of the project
+ * @returns {Object} Map of agent IDs to validator arrays
  */
-const AGENT_VALIDATOR_MAP = {
-  'blazor-builder': ['architecture', 'blazor', 'blazor-concurrency', 'blazor-state', 'css'],
-  'nextjs-expert': ['packages'],
-  'ef-modeler': ['blazor-concurrency'],
-  'standards-architect': ['architecture', 'packages'],
-  'ui-ux-designer': ['css', 'contrast']
-};
+function loadAgentValidatorMap(projectPath) {
+  try {
+    const agentsPath = join(projectPath, 'content/.morph/config/agents.json');
+    const agentsConfig = JSON.parse(readFileSync(agentsPath, 'utf8'));
+
+    const map = {};
+    Object.entries(agentsConfig.agents || {}).forEach(([agentId, agent]) => {
+      if (!agentId.startsWith('_comment') && agent.validators && agent.validators.length > 0) {
+        map[agentId] = agent.validators;
+      }
+    });
+
+    return map;
+  } catch (err) {
+    console.warn(chalk.yellow('⚠️  Failed to load agents.json - no validators will run'));
+    console.warn(chalk.gray(`   Run 'morph-spec init' to set up MORPH-SPEC configuration`));
+    return {}; // Empty map = honest failure
+  }
+}
 
 /**
  * Run all relevant validators for a feature
@@ -39,11 +54,18 @@ export async function runValidation(projectPath, featureName, options = {}) {
     errors: 0,
     warnings: 0,
     issues: [],
-    summary: ''
+    summary: '',
+    results: {} // Per-validator results for hooks integration
   };
 
+  // Load decision constraints from decisions.md
+  const constraints = loadConstraints(projectPath, featureName);
+
   // Determine which validators to run
-  const validatorIds = options.validators || detectValidators(featureName);
+  const validatorIds = options.validators || detectValidators(featureName, projectPath);
+
+  // Merge constraint-enabled validators
+  validatorIds.push(...constraints.enabledValidators);
 
   if (validatorIds.length === 0) {
     result.summary = 'No validators applicable for this feature';
@@ -52,6 +74,9 @@ export async function runValidation(projectPath, featureName, options = {}) {
 
   if (options.verbose) {
     console.log(chalk.gray(`\n  Running validators: ${validatorIds.join(', ')}`));
+    if (constraints.enabledValidators.length > 0) {
+      console.log(chalk.gray(`  (+ ${constraints.enabledValidators.length} from decisions)`));
+    }
   }
 
   // Always run contract compliance if contracts.cs exists
@@ -66,7 +91,13 @@ export async function runValidation(projectPath, featureName, options = {}) {
   // Run each validator
   for (const validatorId of uniqueValidators) {
     try {
-      const validatorResult = await runSingleValidator(validatorId, projectPath, featureName, options);
+      // Pass validator-specific constraints from decisions.md
+      const validatorOptions = {
+        ...options,
+        constraints: constraints.validators[validatorId] || {}
+      };
+
+      const validatorResult = await runSingleValidator(validatorId, projectPath, featureName, validatorOptions);
 
       if (validatorResult) {
         result.errors += validatorResult.errors || 0;
@@ -75,11 +106,21 @@ export async function runValidation(projectPath, featureName, options = {}) {
         if (validatorResult.issues) {
           result.issues.push(...validatorResult.issues);
         }
+
+        // Store per-validator results for hooks
+        result.results[validatorId] = {
+          passed: (validatorResult.errors || 0) === 0,
+          issues: validatorResult.issues || []
+        };
       }
     } catch (err) {
       if (options.verbose) {
         console.log(chalk.yellow(`  ⚠ Validator '${validatorId}' failed: ${err.message}`));
       }
+      result.results[validatorId] = {
+        passed: false,
+        error: err.message
+      };
     }
   }
 
@@ -93,8 +134,11 @@ export async function runValidation(projectPath, featureName, options = {}) {
 
 /**
  * Detect which validators to run based on feature's active agents
+ * @param {string} featureName - Feature name
+ * @param {string} projectPath - Project root path (default: current directory)
+ * @returns {string[]} Array of validator IDs to run
  */
-function detectValidators(featureName) {
+function detectValidators(featureName, projectPath = '.') {
   const state = loadState(false);
   if (!state || !state.features[featureName]) {
     return ['architecture', 'packages']; // Default validators
@@ -104,8 +148,11 @@ function detectValidators(featureName) {
   const agents = feature.activeAgents || [];
   const validatorSet = new Set();
 
+  // Load agent → validators map from agents.json (data-driven)
+  const agentValidatorMap = loadAgentValidatorMap(projectPath);
+
   for (const agentId of agents) {
-    const validators = AGENT_VALIDATOR_MAP[agentId] || [];
+    const validators = agentValidatorMap[agentId] || [];
     validators.forEach(v => validatorSet.add(v));
   }
 
@@ -177,6 +224,11 @@ async function runSingleValidator(validatorId, projectPath, featureName, options
       return await validateContracts(projectPath, featureName, options);
     }
 
+    case 'design-system': {
+      const { validateDesignSystem } = await import('./validators/design-system-validator.js');
+      return await validateDesignSystem(projectPath, featureName, options);
+    }
+
     default:
       if (options.verbose) {
         console.log(chalk.gray(`  Unknown validator: ${validatorId}`));