@polymorphism-tech/morph-spec 2.4.0 → 3.0.0

package/src/lib/spec-validator.js

@@ -0,0 +1,258 @@
+/**
+ * Spec Validator
+ *
+ * Validates spec.md and contracts.cs at design time (Phase 2) to catch
+ * architectural and coding standard violations early.
+ *
+ * MORPH-SPEC 3.0 - Phase 4: Spec-Time Validation
+ */
+
+import { readFileSync, existsSync } from 'fs';
+import { join } from 'path';
+
+/**
+ * Validate spec.md and contracts.cs at design time
+ *
+ * @param {string} projectPath - Project root path
+ * @param {string} featureName - Feature name
+ * @param {Object} options - Options
+ * @returns {Object} { status, errors, warnings, issues }
+ */
+export async function validateSpec(projectPath, featureName, options = {}) {
+  const outputsPath = join(projectPath, '.morph/project/outputs', featureName);
+  const specPath = join(outputsPath, 'spec.md');
+  const contractsPath = join(outputsPath, 'contracts.cs');
+
+  const issues = [];
+
+  // Validate spec.md
+  if (existsSync(specPath)) {
+    const specContent = readFileSync(specPath, 'utf8');
+    const specIssues = validateSpecMd(specContent);
+    issues.push(...specIssues);
+  }
+
+  // Validate contracts.cs
+  if (existsSync(contractsPath)) {
+    const contractsContent = readFileSync(contractsPath, 'utf8');
+    const contractsIssues = validateContractsCs(contractsContent);
+    issues.push(...contractsIssues);
+  }
+
+  const errors = issues.filter(i => i.level === 'error').length;
+  const warnings = issues.filter(i => i.level === 'warning').length;
+
+  return {
+    status: errors > 0 ? 'error' : (warnings > 0 ? 'warning' : 'ok'),
+    errors,
+    warnings,
+    issues,
+    passed: errors === 0
+  };
+}
+
+/**
+ * Validate spec.md structure and content
+ */
+function validateSpecMd(content) {
+  const issues = [];
+
+  // Required sections
+  const requiredSections = [
+    { name: 'Overview', pattern: /^##\s+(?:1\.\s+)?Overview/mi },
+    { name: 'Functional Requirements', pattern: /^##\s+(?:\d+\.\s+)?Functional Requirements/mi },
+    { name: 'Non-Functional Requirements', pattern: /^##\s+(?:\d+\.\s+)?Non-Functional Requirements/mi },
+    { name: 'Technical Architecture', pattern: /^##\s+(?:\d+\.\s+)?Technical Architecture/mi },
+    { name: 'Data Model', pattern: /^##\s+(?:\d+\.\s+)?Data Model/mi }
+  ];
+
+  for (const section of requiredSections) {
+    if (!section.pattern.test(content)) {
+      issues.push({
+        level: 'error',
+        type: 'spec',
+        message: `Missing required section: "${section.name}"`,
+        solution: `Add ## ${section.name} section to spec.md`
+      });
+    }
+  }
+
+  // Check for manual infrastructure creation (anti-pattern)
+  const manualInfraPatterns = [
+    /create.*manually/i,
+    /portal.*azure/i,
+    /click.*portal/i,
+    /via.*portal/i,
+    /manual.*setup/i
+  ];
+
+  for (const pattern of manualInfraPatterns) {
+    if (pattern.test(content)) {
+      issues.push({
+        level: 'error',
+        type: 'spec',
+        message: 'Spec references manual Azure portal creation (anti-pattern)',
+        solution: 'Use Infrastructure as Code (Bicep) instead of manual portal operations'
+      });
+      break; // One error is enough
+    }
+  }
+
+  // Check for Bicep reference (best practice)
+  const hasBicep = /bicep/i.test(content) || /infrastructure\s+as\s+code/i.test(content) || /\.bicep/i.test(content);
+  if (!hasBicep && /azure|sql|storage|container/i.test(content)) {
+    issues.push({
+      level: 'warning',
+      type: 'spec',
+      message: 'Spec mentions Azure resources but no Bicep/IaC reference found',
+      solution: 'Add Infrastructure section with Bicep module references'
+    });
+  }
+
+  return issues;
+}
+
+/**
+ * Validate contracts.cs coding standards
+ */
+function validateContractsCs(content) {
+  const issues = [];
+
+  // 1. Interface naming: Must start with 'I' and be PascalCase
+  const interfaceRegex = /public\s+interface\s+(\w+)/g;
+  let match;
+
+  while ((match = interfaceRegex.exec(content)) !== null) {
+    const name = match[1];
+
+    if (!name.startsWith('I')) {
+      issues.push({
+        level: 'error',
+        type: 'contracts',
+        message: `Interface '${name}' must start with 'I' (e.g., I${name})`,
+        solution: `Rename to I${name}`
+      });
+    } else if (!isPascalCase(name)) {
+      issues.push({
+        level: 'error',
+        type: 'contracts',
+        message: `Interface '${name}' must use PascalCase`,
+        solution: `Rename to ${toPascalCase(name)}`
+      });
+    }
+  }
+
+  // 2. Async methods must have CancellationToken parameter
+  const asyncMethodRegex = /Task(?:<[^>]+>)?\s+(\w+Async)\s*\(([^)]*)\)/g;
+  while ((match = asyncMethodRegex.exec(content)) !== null) {
+    const methodName = match[1];
+    const params = match[2];
+
+    if (!params.includes('CancellationToken')) {
+      issues.push({
+        level: 'error',
+        type: 'contracts',
+        message: `Async method '${methodName}' missing CancellationToken parameter`,
+        solution: `Add 'CancellationToken ct = default' parameter to ${methodName}`
+      });
+    }
+  }
+
+  // 3. DTOs should use records (not classes)
+  const classRegex = /public\s+class\s+(\w+(?:Dto|Response|Request|Command|Query))/g;
+  while ((match = classRegex.exec(content)) !== null) {
+    const className = match[1];
+    issues.push({
+      level: 'warning',
+      type: 'contracts',
+      message: `DTO '${className}' defined as class instead of record`,
+      solution: `Use 'public record ${className}' for immutable DTOs`
+    });
+  }
+
+  // 4. Classes should be sealed (unless abstract/base)
+  const unsealedClassRegex = /public\s+class\s+(\w+)(?!\s*:\s*\w+Base)/g;
+  while ((match = unsealedClassRegex.exec(content)) !== null) {
+    const className = match[1];
+    // Skip if already sealed
+    const lineStart = content.lastIndexOf('\n', match.index) + 1;
+    const lineEnd = content.indexOf('\n', match.index);
+    const line = content.substring(lineStart, lineEnd);
+
+    if (!line.includes('sealed') && !line.includes('abstract')) {
+      issues.push({
+        level: 'warning',
+        type: 'contracts',
+        message: `Class '${className}' should be sealed (unless designed for inheritance)`,
+        solution: `Change to 'public sealed class ${className}'`
+      });
+    }
+  }
+
+  // 5. PascalCase for constants (NOT UPPER_SNAKE_CASE)
+  const upperSnakeRegex = /const\s+\w+\s+([A-Z_][A-Z0-9_]+)\s*=/g;
+  while ((match = upperSnakeRegex.exec(content)) !== null) {
+    const constName = match[1];
+    if (constName.includes('_') && constName === constName.toUpperCase()) {
+      issues.push({
+        level: 'error',
+        type: 'contracts',
+        message: `Constant '${constName}' uses UPPER_SNAKE_CASE (anti-pattern in C#)`,
+        solution: `Use PascalCase: '${toPascalCase(constName)}'`
+      });
+    }
+  }
+
+  // 6. Methods returning Task must end with Async
+  const taskMethodRegex = /Task(?:<[^>]+>)?\s+(\w+)\s*\(/g;
+  while ((match = taskMethodRegex.exec(content)) !== null) {
+    const methodName = match[1];
+    if (!methodName.endsWith('Async') && !['get', 'set', 'init'].includes(methodName)) {
+      issues.push({
+        level: 'error',
+        type: 'contracts',
+        message: `Method '${methodName}' returns Task but doesn't end with 'Async'`,
+        solution: `Rename to '${methodName}Async'`
+      });
+    }
+  }
+
+  // 7. Enum members should be PascalCase (NOT UPPER_SNAKE_CASE)
+  const enumRegex = /enum\s+\w+\s*\{([^}]+)\}/gs;
+  while ((match = enumRegex.exec(content)) !== null) {
+    const enumBody = match[1];
+    const memberRegex = /\n\s*([A-Z_][A-Z0-9_]+)/g;
+    let memberMatch;
+
+    while ((memberMatch = memberRegex.exec(enumBody)) !== null) {
+      const memberName = memberMatch[1];
+      if (memberName.includes('_') && memberName === memberName.toUpperCase()) {
+        issues.push({
+          level: 'error',
+          type: 'contracts',
+          message: `Enum member '${memberName}' uses UPPER_SNAKE_CASE (must be PascalCase)`,
+          solution: `Use PascalCase: '${toPascalCase(memberName)}'`
+        });
+      }
+    }
+  }
+
+  return issues;
+}
+
+/**
+ * Check if a string is PascalCase
+ */
+function isPascalCase(str) {
+  return /^[A-Z][a-z0-9]*([A-Z][a-z0-9]*)*$/.test(str);
+}
+
+/**
+ * Convert string to PascalCase
+ */
+function toPascalCase(str) {
+  return str
+    .split('_')
+    .map(word => word.charAt(0).toUpperCase() + word.slice(1).toLowerCase())
+    .join('');
+}

package/src/lib/standards-context-injector.js

@@ -0,0 +1,287 @@
+/**
+ * @fileoverview Standards Context Injector
+ *
+ * Automatically loads and surfaces relevant standards content for agents.
+ * Resolution order: project overrides → framework standards → content standards
+ *
+ * @module standards-context-injector
+ */
+
+import { readFileSync, existsSync } from 'fs';
+import { join } from 'path';
+
+/**
+ * Agent → Standards mapping
+ * Maps each agent ID to relevant standard files (without .md extension)
+ */
+const AGENT_STANDARDS_MAP = {
+  // Tier 1: Orchestrators
+  'standards-architect': [
+    'architecture',
+    'coding',
+    'azure',
+    'dotnet10-compatibility',
+    'program-cs-checklist'
+  ],
+  'ai-system-architect': [
+    'agent-framework-setup',
+    'agent-framework-workflows',
+    'agent-framework-production',
+    'agent-framework-blazor-ui',
+    'architecture',
+    'coding'
+  ],
+  'popm-advisor': [], // No technical standards
+
+  // Tier 2: Domain Leaders
+  'dotnet-senior': [
+    'coding',
+    'architecture',
+    'dotnet10-compatibility',
+    'program-cs-checklist'
+  ],
+  'azure-architect': [
+    'azure',
+    'architecture',
+    'dotnet10-compatibility'
+  ],
+  'ui-designer': [
+    'css-naming',
+    'css-animations',
+    'fluent-ui-setup',
+    'fluent-ui-blazor'
+  ],
+
+  // Tier 3: Specialists - Backend Squad
+  'ef-modeler': [
+    'blazor-efcore',
+    'architecture',
+    'coding',
+    'dotnet10-compatibility'
+  ],
+  'event-architect': [
+    'architecture',
+    'coding',
+    'dotnet10-compatibility'
+  ],
+  'api-designer': [
+    'architecture',
+    'coding',
+    'dotnet10-compatibility'
+  ],
+  'nosql-cache-expert': [
+    'architecture',
+    'coding'
+  ],
+  'ddd-expert': [
+    'architecture',
+    'coding'
+  ],
+  'hangfire-orchestrator': [
+    'architecture',
+    'coding',
+    'blazor-lifecycle', // Background jobs + Blazor lifecycle
+    'dotnet10-compatibility'
+  ],
+  'ms-agent-expert': [
+    'agent-framework-setup',
+    'agent-framework-workflows',
+    'agent-framework-production',
+    'agent-framework-blazor-ui',
+    'coding',
+    'architecture'
+  ],
+  'asaas-financial': [
+    'coding',
+    'architecture'
+  ],
+  'clerk-auth': [
+    'coding',
+    'architecture',
+    'passkeys-auth'
+  ],
+  'resend-email': [
+    'coding',
+    'architecture'
+  ],
+
+  // Tier 3: Specialists - Frontend Squad
+  'blazor-builder': [
+    'blazor-lifecycle',
+    'blazor-state',
+    'blazor-efcore',
+    'blazor-pitfalls',
+    'html-to-blazor',
+    'fluent-ui-blazor',
+    'css-naming',
+    'css-animations',
+    'coding',
+    'architecture'
+  ],
+  'nextjs-expert': [
+    'coding'
+  ],
+  'css-specialist': [
+    'css-naming',
+    'css-animations',
+    'fluent-ui-blazor'
+  ],
+
+  // Tier 3: Specialists - Infrastructure Squad
+  'bicep-architect': [
+    'azure',
+    'architecture'
+  ],
+  'devops-engineer': [
+    'azure',
+    'dotnet10-compatibility'
+  ],
+  'container-specialist': [
+    'azure',
+    'dotnet10-compatibility'
+  ],
+  'observability-expert': [
+    'azure',
+    'architecture'
+  ],
+  'azure-identity': [
+    'azure',
+    'architecture',
+    'passkeys-auth'
+  ],
+
+  // Tier 3: Specialists - Quality Squad
+  'testing-specialist': [
+    'coding',
+    'architecture',
+    'dotnet10-compatibility'
+  ],
+  'code-analyzer': [
+    'coding',
+    'architecture',
+    'dotnet10-compatibility',
+    'program-cs-checklist'
+  ],
+  'troubleshooting-expert': [
+    'architecture',
+    'blazor-pitfalls',
+    'dotnet10-compatibility'
+  ],
+  'load-testing-expert': [
+    'architecture',
+    'azure'
+  ],
+  'documentation-specialist': [], // No technical standards
+
+  // Tier 4: Validators
+  'security-expert': [
+    'coding',
+    'architecture',
+    'passkeys-auth'
+  ]
+};
+
+/**
+ * Load a single standard file with project override support
+ * @param {string} standardName - Standard filename without .md extension
+ * @param {string} projectPath - Root path of the project
+ * @returns {string|null} Standard content or null if not found
+ */
+function loadStandard(standardName, projectPath) {
+  const locations = [
+    // 1. Project override
+    join(projectPath, '.morph/project/standards', `${standardName}.md`),
+    // 2. Content standards (AI/Agent Framework, Azure, etc.)
+    join(projectPath, 'content/.morph/standards', `${standardName}.md`),
+    // 3. Framework standards (Blazor, CSS, .NET)
+    join(projectPath, 'framework/standards', `${standardName}.md`)
+  ];
+
+  for (const path of locations) {
+    if (existsSync(path)) {
+      try {
+        return readFileSync(path, 'utf8');
+      } catch (err) {
+        // Continue to next location
+      }
+    }
+  }
+
+  return null;
+}
+
+/**
+ * Load all relevant standards for a given agent
+ * @param {string} agentId - Agent ID (e.g., 'blazor-builder')
+ * @param {string} projectPath - Root path of the project
+ * @returns {Object} { sections: [{standard, content}], fullContent: string }
+ */
+export function loadStandardsForAgent(agentId, projectPath = '.') {
+  const standardNames = AGENT_STANDARDS_MAP[agentId] || [];
+  const sections = [];
+  const contentParts = [];
+
+  // Load inferred standards if exists (project-specific learnings)
+  const inferredPath = join(projectPath, '.morph/project/standards/inferred.md');
+  if (existsSync(inferredPath)) {
+    try {
+      const inferredContent = readFileSync(inferredPath, 'utf8');
+      sections.push({
+        standard: 'inferred',
+        content: inferredContent
+      });
+      contentParts.push(`# Project-Specific Standards (Inferred)\n\n${inferredContent}`);
+    } catch (err) {
+      // Ignore if can't read
+    }
+  }
+
+  // Load each standard
+  for (const standardName of standardNames) {
+    const content = loadStandard(standardName, projectPath);
+    if (content) {
+      sections.push({
+        standard: standardName,
+        content
+      });
+      contentParts.push(`# ${standardName}\n\n${content}`);
+    }
+  }
+
+  return {
+    sections,
+    fullContent: contentParts.join('\n\n---\n\n'),
+    standardNames // For debugging/introspection
+  };
+}
+
+/**
+ * Get list of standards for an agent (without loading content)
+ * @param {string} agentId - Agent ID
+ * @returns {string[]} Array of standard names
+ */
+export function getStandardsListForAgent(agentId) {
+  return AGENT_STANDARDS_MAP[agentId] || [];
+}
+
+/**
+ * Check if a standard exists in any location
+ * @param {string} standardName - Standard filename without .md extension
+ * @param {string} projectPath - Root path of the project
+ * @returns {Object} { exists: boolean, location: string|null }
+ */
+export function checkStandardExists(standardName, projectPath = '.') {
+  const locations = [
+    { type: 'project', path: join(projectPath, '.morph/project/standards', `${standardName}.md`) },
+    { type: 'content', path: join(projectPath, 'content/.morph/standards', `${standardName}.md`) },
+    { type: 'framework', path: join(projectPath, 'framework/standards', `${standardName}.md`) }
+  ];
+
+  for (const loc of locations) {
+    if (existsSync(loc.path)) {
+      return { exists: true, location: loc.type, path: loc.path };
+    }
+  }
+
+  return { exists: false, location: null, path: null };
+}