@polymorphism-tech/morph-spec 2.2.0 → 2.4.0

package/content/.claude/skills/specialists/azure-architect.md

@@ -1,142 +1,142 @@
-# Azure Architect
-
-Especialista em infraestrutura Azure com foco em Infrastructure as Code (Bicep).
-
-## Responsabilidades
-
-1. **Desenhar infraestrutura Azure** para projetos
-2. **Criar templates Bicep** para provisionar recursos
-3. **Estimar custos** antes de aprovar recursos
-4. **Garantir zero portal** - tudo via código
-
-## Triggers
-
-Ativado automaticamente em todo projeto MORPH-SPEC (Core Agent).
-
-Keywords: `azure`, `infrastructure`, `bicep`, `deploy`, `container apps`, `sql`, `storage`, `provision`
-
-## Princípio: Zero Portal
-
-> **NUNCA** criar recursos Azure manualmente no portal. Tudo via Bicep.
-
-## Estrutura IaC
-
-```
-infra/
-├── main.bicep                # Entry point
-├── parameters.dev.json       # Ambiente dev
-├── parameters.prod.json      # Ambiente prod
-└── modules/
-    ├── container-app.bicep   # Container Apps
-    ├── sql-database.bicep    # Azure SQL
-    ├── storage.bicep         # Storage Account
-    ├── key-vault.bicep       # Key Vault
-    ├── app-insights.bicep    # Monitoring
-    └── service-bus.bicep     # Mensageria
-```
-
-## Template Bicep Base
-
-```bicep
-// infra/main.bicep
-targetScope = 'resourceGroup'
-
-@description('Environment name')
-param environment string = 'dev'
-
-@description('Location for resources')
-param location string = resourceGroup().location
-
-@description('Application name')
-param appName string
-
-// Variables
-var resourcePrefix = '${appName}-${environment}'
-
-// Container App Environment
-module containerAppEnv 'modules/container-app-env.bicep' = {
-  name: 'containerAppEnv'
-  params: {
-    name: '${resourcePrefix}-env'
-    location: location
-  }
-}
-
-// Container App
-module containerApp 'modules/container-app.bicep' = {
-  name: 'containerApp'
-  params: {
-    name: resourcePrefix
-    location: location
-    environmentId: containerAppEnv.outputs.id
-  }
-}
-```
-
-## Recursos Recomendados por Tier
-
-### Free Tier (Sem aprovação)
-
-| Recurso | Config | Custo |
-|---------|--------|-------|
-| Azure SQL | Free 32GB | $0 |
-| Container Apps | Scale to zero | ~$0 |
-| Storage | LRS 5GB | ~$0 |
-| App Insights | Free tier | $0 |
-
-### Basic Tier (Até $10/mês)
-
-| Recurso | Config | Custo |
-|---------|--------|-------|
-| Azure SQL | Basic DTU | ~$5 |
-| Service Bus | Basic | ~$0.05 |
-| Key Vault | Standard | ~$0.03 |
-
-## Comandos de Deploy
-
-```powershell
-# Criar resource group
-az group create --name rg-{app}-{env} --location brazilsouth
-
-# Deploy com Bicep
-az deployment group create \
-  --resource-group rg-{app}-{env} \
-  --template-file infra/main.bicep \
-  --parameters @infra/parameters.{env}.json
-
-# Validar antes de deploy
-az deployment group what-if \
-  --resource-group rg-{app}-{env} \
-  --template-file infra/main.bicep \
-  --parameters @infra/parameters.{env}.json
-```
-
-## Quando usar SDK .NET vs Bicep
-
-| Recurso | Abordagem | Motivo |
-|---------|-----------|--------|
-| SQL, Storage, Container Apps | Bicep | Infra estática, declarativa |
-| Azure AI, Fabric | SDK .NET | Recursos dinâmicos, runtime |
-| Secrets | Key Vault + Bicep | Segurança |
-
-## Documentação de Referência
-
-- [Azure Bicep](https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/)
-- [Container Apps](https://learn.microsoft.com/en-us/azure/container-apps/)
-- [Azure SQL](https://learn.microsoft.com/en-us/azure/azure-sql/)
-- [Azure SDK for .NET](https://learn.microsoft.com/en-us/dotnet/azure/)
-- [Pricing Calculator](https://azure.microsoft.com/en-us/pricing/calculator/)
-
-## Checklist de Infraestrutura
-
-- [ ] Bicep válido (`az bicep build`)
-- [ ] Parâmetros para dev e prod
-- [ ] Custos estimados e documentados
-- [ ] Secrets no Key Vault (não hardcoded)
-- [ ] Logs configurados (App Insights)
-- [ ] Scale-to-zero onde possível
-- [ ] Naming convention consistente
-
----
-
-*MORPH-SPEC by Polymorphism Tech*
+# Azure Architect
+
+Especialista em infraestrutura Azure com foco em Infrastructure as Code (Bicep).
+
+## Responsabilidades
+
+1. **Desenhar infraestrutura Azure** para projetos
+2. **Criar templates Bicep** para provisionar recursos
+3. **Estimar custos** antes de aprovar recursos
+4. **Garantir zero portal** - tudo via código
+
+## Triggers
+
+Ativado automaticamente em todo projeto MORPH-SPEC (Core Agent).
+
+Keywords: `azure`, `infrastructure`, `bicep`, `deploy`, `container apps`, `sql`, `storage`, `provision`
+
+## Princípio: Zero Portal
+
+> **NUNCA** criar recursos Azure manualmente no portal. Tudo via Bicep.
+
+## Estrutura IaC
+
+```
+infra/
+├── main.bicep                # Entry point
+├── parameters.dev.json       # Ambiente dev
+├── parameters.prod.json      # Ambiente prod
+└── modules/
+    ├── container-app.bicep   # Container Apps
+    ├── sql-database.bicep    # Azure SQL
+    ├── storage.bicep         # Storage Account
+    ├── key-vault.bicep       # Key Vault
+    ├── app-insights.bicep    # Monitoring
+    └── service-bus.bicep     # Mensageria
+```
+
+## Template Bicep Base
+
+```bicep
+// infra/main.bicep
+targetScope = 'resourceGroup'
+
+@description('Environment name')
+param environment string = 'dev'
+
+@description('Location for resources')
+param location string = resourceGroup().location
+
+@description('Application name')
+param appName string
+
+// Variables
+var resourcePrefix = '${appName}-${environment}'
+
+// Container App Environment
+module containerAppEnv 'modules/container-app-env.bicep' = {
+  name: 'containerAppEnv'
+  params: {
+    name: '${resourcePrefix}-env'
+    location: location
+  }
+}
+
+// Container App
+module containerApp 'modules/container-app.bicep' = {
+  name: 'containerApp'
+  params: {
+    name: resourcePrefix
+    location: location
+    environmentId: containerAppEnv.outputs.id
+  }
+}
+```
+
+## Recursos Recomendados por Tier
+
+### Free Tier (Sem aprovação)
+
+| Recurso | Config | Custo |
+|---------|--------|-------|
+| Azure SQL | Free 32GB | $0 |
+| Container Apps | Scale to zero | ~$0 |
+| Storage | LRS 5GB | ~$0 |
+| App Insights | Free tier | $0 |
+
+### Basic Tier (Até $10/mês)
+
+| Recurso | Config | Custo |
+|---------|--------|-------|
+| Azure SQL | Basic DTU | ~$5 |
+| Service Bus | Basic | ~$0.05 |
+| Key Vault | Standard | ~$0.03 |
+
+## Comandos de Deploy
+
+```powershell
+# Criar resource group
+az group create --name rg-{app}-{env} --location brazilsouth
+
+# Deploy com Bicep
+az deployment group create \
+  --resource-group rg-{app}-{env} \
+  --template-file infra/main.bicep \
+  --parameters @infra/parameters.{env}.json
+
+# Validar antes de deploy
+az deployment group what-if \
+  --resource-group rg-{app}-{env} \
+  --template-file infra/main.bicep \
+  --parameters @infra/parameters.{env}.json
+```
+
+## Quando usar SDK .NET vs Bicep
+
+| Recurso | Abordagem | Motivo |
+|---------|-----------|--------|
+| SQL, Storage, Container Apps | Bicep | Infra estática, declarativa |
+| Azure AI, Fabric | SDK .NET | Recursos dinâmicos, runtime |
+| Secrets | Key Vault + Bicep | Segurança |
+
+## Documentação de Referência
+
+- [Azure Bicep](https://learn.microsoft.com/en-us/azure/azure-resource-manager/bicep/)
+- [Container Apps](https://learn.microsoft.com/en-us/azure/container-apps/)
+- [Azure SQL](https://learn.microsoft.com/en-us/azure/azure-sql/)
+- [Azure SDK for .NET](https://learn.microsoft.com/en-us/dotnet/azure/)
+- [Pricing Calculator](https://azure.microsoft.com/en-us/pricing/calculator/)
+
+## Checklist de Infraestrutura
+
+- [ ] Bicep válido (`az bicep build`)
+- [ ] Parâmetros para dev e prod
+- [ ] Custos estimados e documentados
+- [ ] Secrets no Key Vault (não hardcoded)
+- [ ] Logs configurados (App Insights)
+- [ ] Scale-to-zero onde possível
+- [ ] Naming convention consistente
+
+---
+
+*MORPH-SPEC by Polymorphism Tech*

package/content/.claude/skills/specialists/code-analyzer.md

@@ -0,0 +1,235 @@
+# Code Analyzer
+
+> **Layer:** 2 | **Load:** on-keyword | **Keywords:** analyze, review, refactor, clean, smell, duplicate, architecture, quality, debt, unused, dead code, code review, code quality
+
+Deep code analysis specialist. Automates architecture review, clean code checks, and duplication detection.
+
+> **Ref:** `framework/standards/coding.md` for naming conventions.
+> **Ref:** `framework/standards/architecture.md` for architectural patterns.
+> **Ref:** `.claude/skills/checklists/code-review.md` for runtime pattern checks.
+
+---
+
+## When to Run
+
+| Trigger | Automatic? | Scope |
+|---------|-----------|-------|
+| FASE 5 completion (`/morph-apply` done) | Yes | Full feature code |
+| Checkpoint (every 3 tasks) | Yes | Code since last checkpoint |
+| Manual: `analyze`, `review code`, `code quality` | No | Specified scope |
+| Pre-merge review | Recommended | All changed files |
+
+---
+
+## 3 Analysis Modes
+
+Run all 3 modes by default. Use `--mode architecture`, `--mode clean`, or `--mode duplication` for targeted analysis.
+
+---
+
+### Mode 1: Architecture Analysis
+
+Analyze the codebase for structural and architectural issues.
+
+#### Checklist
+
+**Layer Integrity:**
+- [ ] `[CRITICAL]` Domain project has zero references to Infrastructure or Web
+- [ ] `[CRITICAL]` Application does NOT reference Web project
+- [ ] `[HIGH]` No circular dependencies between projects
+- [ ] `[HIGH]` Infrastructure details don't leak into Application (no EF types in DTOs)
+
+**Responsibility Separation:**
+- [ ] `[HIGH]` Each class has a single, clear responsibility (< 300 lines)
+- [ ] `[HIGH]` Controllers/pages are thin (< 50 lines logic, delegate to services)
+- [ ] `[MEDIUM]` Interfaces are focused (< 7 methods per interface)
+- [ ] `[MEDIUM]` No "God classes" (classes with 10+ dependencies)
+
+**Abstractions:**
+- [ ] `[MEDIUM]` External services accessed through interfaces (testable)
+- [ ] `[LOW]` No over-abstraction (interfaces with exactly 1 implementation that's never mocked)
+- [ ] `[MEDIUM]` Missing abstractions: direct HTTP calls, file I/O, or DB access without interface
+
+**File Organization:**
+- [ ] `[MEDIUM]` One class per file (file name matches class name)
+- [ ] `[MEDIUM]` Files in correct project/folder per architecture.md
+- [ ] `[LOW]` Consistent folder structure across all layers
+
+**Configuration:**
+- [ ] `[HIGH]` No hardcoded connection strings, URLs, or secrets
+- [ ] `[MEDIUM]` Configuration via Options pattern (`IOptions<T>`)
+- [ ] `[LOW]` No duplicate configuration across projects
+
+**Unused Code:**
+- [ ] `[MEDIUM]` No unused classes or interfaces (search for zero references)
+- [ ] `[MEDIUM]` No dead code paths (unreachable branches)
+- [ ] `[LOW]` No commented-out code blocks (> 3 lines)
+- [ ] `[LOW]` No empty or near-empty files (< 10 lines of actual code)
+
+---
+
+### Mode 2: Clean Code Analysis
+
+Analyze for code smells, style violations, and improvement opportunities.
+
+#### Checklist
+
+**Naming (ref: coding.md):**
+- [ ] `[HIGH]` All naming follows coding.md conventions (PascalCase constants, _camelCase fields, etc.)
+- [ ] `[HIGH]` No Hungarian notation (`strName`, `iCount`, `btnSubmit`)
+- [ ] `[HIGH]` No ALL_CAPS constants (`MAX_RETRY` -> `MaxRetry`)
+- [ ] `[MEDIUM]` Descriptive names (no `data`, `info`, `item`, `result` without context)
+- [ ] `[MEDIUM]` No abbreviations in public APIs (`repo` -> `repository`)
+
+**Method Quality:**
+- [ ] `[HIGH]` No methods > 30 lines (extract sub-methods)
+- [ ] `[HIGH]` No methods with > 4 parameters (use request object)
+- [ ] `[MEDIUM]` No nested conditionals > 3 levels (extract or use early return)
+- [ ] `[MEDIUM]` No complex conditionals (> 3 conditions in one `if` — extract to named bool or method)
+
+**Class Quality:**
+- [ ] `[HIGH]` No classes > 300 lines (SRP violation — split)
+- [ ] `[HIGH]` No classes with > 7 constructor dependencies (God class — split)
+- [ ] `[MEDIUM]` Classes are `sealed` unless designed for inheritance
+
+**Magic Values:**
+- [ ] `[HIGH]` No magic strings in comparisons (`if (status == "active")` -> use enum or constant)
+- [ ] `[HIGH]` No magic numbers (`if (items.Count > 50)` -> extract `const int MaxItemsPerPage = 50`)
+- [ ] `[MEDIUM]` No hardcoded URLs, file paths, or configuration values
+
+**Dead Code:**
+- [ ] `[MEDIUM]` No unused private methods (zero callers)
+- [ ] `[MEDIUM]` No unused parameters in methods
+- [ ] `[LOW]` No TODO/FIXME/HACK comments older than 2 sprints
+- [ ] `[LOW]` No `#if DEBUG` blocks with substantial logic
+
+**Error Handling:**
+- [ ] `[CRITICAL]` No empty catch blocks
+- [ ] `[HIGH]` No generic `catch (Exception)` without re-throw
+- [ ] `[HIGH]` Result pattern used for business errors (not exceptions)
+- [ ] `[MEDIUM]` Consistent error handling pattern across all services
+
+**Logging:**
+- [ ] `[HIGH]` No `$""` string interpolation in log methods (use message templates)
+- [ ] `[HIGH]` Critical operations have entry/exit/error logging
+- [ ] `[MEDIUM]` Log messages include correlation IDs (OrderId, UserId)
+- [ ] `[MEDIUM]` Consistent log levels across similar operations
+
+---
+
+### Mode 3: Duplication Detection
+
+Find redundant, duplicate, and unnecessary code.
+
+#### Targets
+
+**Exact/Near-Exact Duplicates:**
+- [ ] `[HIGH]` Methods with identical or near-identical logic in different classes
+  - Same method body, different class -> extract to shared service or extension
+  - Same logic with different types -> extract to generic method
+- [ ] `[HIGH]` Repeated code blocks (> 5 lines identical in 2+ locations)
+
+**Thin Wrappers:**
+- [ ] `[MEDIUM]` Methods that only delegate to another method with same parameters
+  ```csharp
+  // SMELL: Thin wrapper with no added value
+  public Task<Order> GetOrderAsync(int id, CancellationToken ct)
+      => _innerService.GetOrderAsync(id, ct);
+  ```
+- [ ] `[MEDIUM]` Service methods that only call a repository method (no logic added)
+
+**Interface Redundancy:**
+- [ ] `[MEDIUM]` Same method signature appearing in multiple interfaces (extract base interface)
+- [ ] `[LOW]` Interface that exactly mirrors another interface (merge or inherit)
+
+**Passthrough Delegates:**
+- [ ] `[MEDIUM]` Controller/page methods that only call one service method and return result
+  - If no validation, auth, or mapping: consider simplifying the layer
+
+**DTO/Model Duplication:**
+- [ ] `[HIGH]` Duplicate model definitions (same properties in different classes)
+- [ ] `[MEDIUM]` Request/Response DTOs that are identical (merge or use shared base)
+- [ ] `[MEDIUM]` Enums defined in multiple projects (centralize in Domain)
+
+---
+
+## Output Format
+
+For each finding, report:
+
+```
+### [{SEVERITY}] {Category}: {Short Description}
+
+**File:** `path/to/file.cs:42`
+**Rule:** {rule reference from checklist above}
+
+**Current code:**
+```csharp
+// problematic code snippet
+```
+
+**Suggested fix:**
+```csharp
+// corrected code snippet
+```
+
+**Why:** {brief explanation of the problem and impact}
+```
+
+---
+
+## Summary Template
+
+After analysis, generate a summary:
+
+```markdown
+## Code Analysis Summary
+
+**Scope:** {files/feature analyzed}
+**Date:** {date}
+**Modes:** Architecture | Clean Code | Duplication
+
+### Findings by Severity
+
+| Severity | Count |
+|----------|-------|
+| CRITICAL | {n} |
+| HIGH     | {n} |
+| MEDIUM   | {n} |
+| LOW      | {n} |
+
+### Top 5 Priorities
+
+1. {Most critical finding with file:line}
+2. {Second most critical}
+3. ...
+
+### Estimated Effort
+
+| Category | Findings | Effort |
+|----------|----------|--------|
+| Quick fixes (naming, style) | {n} | ~{h}h |
+| Refactoring (extraction, splitting) | {n} | ~{h}h |
+| Architecture (layer changes) | {n} | ~{h}h |
+
+### Recommendations
+
+- {Key recommendation 1}
+- {Key recommendation 2}
+- {Key recommendation 3}
+```
+
+---
+
+## Integration with Other Specialists
+
+| Specialist | Handoff |
+|------------|---------|
+| **Standards Architect** | Code Analyzer validates naming rules defined by Standards Architect |
+| **.NET Senior Engineer** | Code Analyzer reviews code produced by dotnet-senior |
+| **Code Review Checklist** | Code Analyzer runs architecture/clean code checks; code-review.md covers runtime patterns |
+| **Testing Specialist** | Findings may generate new test requirements |
+
+---
+
+*MORPH-SPEC by Polymorphism Tech*