@polymorphism-tech/morph-spec 2.2.0 → 2.4.0

package/src/lib/validators/contract-compliance-validator.js

@@ -0,0 +1,273 @@
+/**
+ * Contract Compliance Validator
+ *
+ * Parses contracts.cs from feature outputs and verifies that the project code
+ * actually implements all defined interfaces, methods, DTOs, and enums.
+ *
+ * MORPH-SPEC 3.0 - Phase A: Active Validation Pipeline
+ */
+
+import { readFileSync, existsSync } from 'fs';
+import { join } from 'path';
+import { glob } from 'glob';
+import chalk from 'chalk';
+
+/**
+ * Validate that contracts.cs interfaces are implemented in project code
+ *
+ * @param {string} projectPath - Project root path
+ * @param {string} featureName - Feature name
+ * @param {Object} options - Options
+ * @returns {Object} { status, errors, warnings, issues, coverage }
+ */
+export async function validateContracts(projectPath, featureName, options = {}) {
+  const contractsPath = join(projectPath, '.morph/project/outputs', featureName, 'contracts.cs');
+
+  if (!existsSync(contractsPath)) {
+    return {
+      status: 'ok',
+      errors: 0,
+      warnings: 0,
+      issues: [],
+      coverage: null,
+      message: 'No contracts.cs found — skipping'
+    };
+  }
+
+  const contractsContent = readFileSync(contractsPath, 'utf-8');
+  const contracts = parseContracts(contractsContent);
+
+  if (contracts.interfaces.length === 0 && contracts.records.length === 0 && contracts.enums.length === 0) {
+    return {
+      status: 'ok',
+      errors: 0,
+      warnings: 1,
+      issues: [{ level: 'warning', message: 'contracts.cs exists but no interfaces/records/enums found' }],
+      coverage: null
+    };
+  }
+
+  // Find all .cs files in the project (excluding .morph outputs, bin, obj)
+  const csFiles = await glob('**/*.cs', {
+    cwd: projectPath,
+    ignore: ['.morph/**', '**/bin/**', '**/obj/**', '**/node_modules/**']
+  });
+
+  const projectCode = {};
+  for (const file of csFiles) {
+    const fullPath = join(projectPath, file);
+    try {
+      projectCode[file] = readFileSync(fullPath, 'utf-8');
+    } catch {
+      // Skip unreadable files
+    }
+  }
+
+  const issues = [];
+  let implemented = 0;
+  let total = 0;
+  const interfaceResults = [];
+
+  // Validate interfaces
+  for (const iface of contracts.interfaces) {
+    total++;
+    const result = validateInterface(iface, projectCode, options);
+    interfaceResults.push(result);
+
+    if (result.implemented) {
+      implemented++;
+      if (options.verbose) {
+        console.log(chalk.green(`    ✓ ${iface.name} → ${result.implementingClass} (${result.implementedMethods}/${result.totalMethods} methods)`));
+      }
+    } else {
+      issues.push({
+        level: 'error',
+        message: `Interface ${iface.name} not implemented in project code`,
+        solution: `Create a class that implements ${iface.name} with all ${iface.methods.length} method(s)`
+      });
+    }
+
+    // Check for missing methods
+    for (const method of result.missingMethods || []) {
+      issues.push({
+        level: 'error',
+        message: `Method ${method} missing from ${result.implementingClass || iface.name} implementation`,
+        file: result.implementingFile,
+        solution: `Add method ${method} to the class implementing ${iface.name}`
+      });
+    }
+  }
+
+  // Validate records/DTOs
+  for (const record of contracts.records) {
+    total++;
+    const found = Object.entries(projectCode).some(([, content]) =>
+      new RegExp(`(class|record|struct)\\s+${escapeRegex(record.name)}`, 'g').test(content)
+    );
+
+    if (found) {
+      implemented++;
+      if (options.verbose) {
+        console.log(chalk.green(`    ✓ ${record.name} (${record.type})`));
+      }
+    } else {
+      issues.push({
+        level: 'warning',
+        message: `${record.type} ${record.name} defined in contracts but not found in project code`,
+        solution: `Create ${record.type} ${record.name} matching the contract definition`
+      });
+    }
+  }
+
+  // Validate enums
+  for (const enumDef of contracts.enums) {
+    total++;
+    const found = Object.entries(projectCode).some(([, content]) =>
+      new RegExp(`enum\\s+${escapeRegex(enumDef.name)}`, 'g').test(content)
+    );
+
+    if (found) {
+      implemented++;
+      if (options.verbose) {
+        console.log(chalk.green(`    ✓ ${enumDef.name} (enum)`));
+      }
+    } else {
+      issues.push({
+        level: 'warning',
+        message: `Enum ${enumDef.name} defined in contracts but not found in project code`,
+        solution: `Create enum ${enumDef.name} matching the contract definition`
+      });
+    }
+  }
+
+  const coveragePercent = total > 0 ? Math.round((implemented / total) * 100) : 100;
+  const errors = issues.filter(i => i.level === 'error').length;
+  const warnings = issues.filter(i => i.level === 'warning').length;
+
+  if (options.verbose) {
+    console.log(chalk.cyan(`\n    Contract coverage: ${coveragePercent}% (${implemented}/${total})`));
+  }
+
+  return {
+    status: errors > 0 ? 'error' : 'ok',
+    errors,
+    warnings,
+    issues,
+    coverage: {
+      percentage: coveragePercent,
+      implemented,
+      total,
+      interfaces: interfaceResults
+    }
+  };
+}
+
+/**
+ * Parse contracts.cs content and extract interfaces, records, and enums
+ */
+function parseContracts(content) {
+  const interfaces = [];
+  const records = [];
+  const enums = [];
+
+  // Extract interfaces with their methods
+  const interfaceRegex = /public\s+interface\s+(I\w+)(?:\s*:\s*[\w<>,\s]+)?\s*\{([^}]*)\}/gs;
+  let match;
+
+  while ((match = interfaceRegex.exec(content)) !== null) {
+    const name = match[1];
+    const body = match[2];
+    const methods = extractMethods(body);
+
+    interfaces.push({ name, methods });
+  }
+
+  // Extract records/classes (DTOs)
+  const recordRegex = /public\s+(record|class|struct)\s+(\w+)/g;
+  while ((match = recordRegex.exec(content)) !== null) {
+    const type = match[1];
+    const name = match[2];
+    // Skip interface names that were already captured
+    if (!name.startsWith('I') || !interfaces.some(i => i.name === name)) {
+      records.push({ type, name });
+    }
+  }
+
+  // Extract enums
+  const enumRegex = /public\s+enum\s+(\w+)/g;
+  while ((match = enumRegex.exec(content)) !== null) {
+    enums.push({ name: match[1] });
+  }
+
+  return { interfaces, records, enums };
+}
+
+/**
+ * Extract method signatures from an interface body
+ */
+function extractMethods(body) {
+  const methods = [];
+
+  // Match method signatures like: Task<Result> DoSomethingAsync(params);
+  const methodRegex = /(?:Task<[^>]+>|Task|void|string|int|bool|decimal|[\w<>[\],\s?]+)\s+(\w+)\s*\(/g;
+  let match;
+
+  while ((match = methodRegex.exec(body)) !== null) {
+    const methodName = match[1];
+    // Skip property getters/setters
+    if (!['get', 'set', 'init'].includes(methodName)) {
+      methods.push(methodName);
+    }
+  }
+
+  return methods;
+}
+
+/**
+ * Validate that an interface is implemented in project code
+ */
+function validateInterface(iface, projectCode, options) {
+  const result = {
+    name: iface.name,
+    implemented: false,
+    implementingClass: null,
+    implementingFile: null,
+    totalMethods: iface.methods.length,
+    implementedMethods: 0,
+    missingMethods: []
+  };
+
+  // Search for classes implementing this interface
+  const implRegex = new RegExp(`class\\s+(\\w+)\\s*(?:<[^>]*>)?\\s*:\\s*[^{]*${escapeRegex(iface.name)}`, 'g');
+
+  for (const [file, content] of Object.entries(projectCode)) {
+    const match = implRegex.exec(content);
+    if (match) {
+      result.implemented = true;
+      result.implementingClass = match[1];
+      result.implementingFile = file;
+
+      // Check which methods are implemented
+      for (const method of iface.methods) {
+        const methodExists = new RegExp(`(public|protected|private|internal)?\\s*(async\\s+)?\\S+\\s+${escapeRegex(method)}\\s*\\(`, 'g').test(content);
+        if (methodExists) {
+          result.implementedMethods++;
+        } else {
+          result.missingMethods.push(method);
+        }
+      }
+
+      break; // Found the implementation
+    }
+    implRegex.lastIndex = 0; // Reset for next file
+  }
+
+  return result;
+}
+
+/**
+ * Escape special regex characters in a string
+ */
+function escapeRegex(str) {
+  return str.replace(/[.*+?^${}()|[\]\\]/g, '\\$&');
+}

package/src/lib/validators/package-validator.js

@@ -0,0 +1,360 @@
+/**
+ * Package Compatibility Validator
+ *
+ * Validates NuGet package versions against .NET compatibility matrix.
+ * Critical for .NET 10 migration - prevents runtime errors.
+ *
+ * MORPH-SPEC 3.0 - Sprint 4
+ */
+
+import { readFileSync } from 'fs';
+import { glob } from 'glob';
+import chalk from 'chalk';
+
+/**
+ * Compatibility matrix for .NET versions
+ * Source: framework/standards/dotnet10-compatibility.md
+ */
+const COMPATIBILITY_MATRIX = {
+  'MudBlazor': {
+    9: '6.21.0',
+    10: '8.15.0',
+    breaking: true,
+    reason: 'Theme API changed: Palette → PaletteLight/PaletteDark',
+    migration: 'See framework/standards/dotnet10-compatibility.md'
+  },
+  'Microsoft.FluentUI.AspNetCore.Components': {
+    9: '4.10.0',
+    10: '5.0.0',
+    breaking: false,
+    reason: 'API stable, version bump for .NET 10 compatibility'
+  },
+  'Hangfire.AspNetCore': {
+    9: '1.8.0',
+    10: '1.8.22',
+    breaking: false,
+    reason: '.NET 10 runtime compatibility'
+  },
+  'Hangfire.Core': {
+    9: '1.8.0',
+    10: '1.8.22',
+    breaking: false
+  },
+  'Microsoft.EntityFrameworkCore': {
+    9: '9.0.0',
+    10: '10.0.0',
+    breaking: true,
+    reason: 'EF Core 10 required for .NET 10 runtime'
+  },
+  'Microsoft.EntityFrameworkCore.SqlServer': {
+    9: '9.0.0',
+    10: '10.0.0',
+    breaking: true
+  },
+  'Microsoft.EntityFrameworkCore.Design': {
+    9: '9.0.0',
+    10: '10.0.0',
+    breaking: true
+  },
+  'Microsoft.AspNetCore.Components.WebAssembly': {
+    9: '9.0.0',
+    10: '10.0.0',
+    breaking: false
+  },
+  'Microsoft.SemanticKernel': {
+    9: null, // Not compatible with .NET 10
+    10: null,
+    deprecated: true,
+    replacement: 'Microsoft.Extensions.AI.Abstractions',
+    reason: 'Use Microsoft Agent Framework for .NET 10'
+  }
+};
+
+/**
+ * Package Validator Class
+ */
+export class PackageValidator {
+  constructor(projectPath = '.') {
+    this.projectPath = projectPath;
+  }
+
+  /**
+   * Validate all .csproj files in project
+   */
+  async validateAll() {
+    const csprojFiles = await glob('**/*.csproj', {
+      cwd: this.projectPath,
+      ignore: ['**/obj/**', '**/bin/**', '**/node_modules/**']
+    });
+
+    if (csprojFiles.length === 0) {
+      return {
+        status: 'ok',
+        message: 'No .csproj files found'
+      };
+    }
+
+    const results = [];
+
+    for (const file of csprojFiles) {
+      const result = await this.validateFile(file);
+      if (result.issues.length > 0) {
+        results.push({ file, ...result });
+      }
+    }
+
+    return {
+      status: results.length === 0 ? 'ok' : 'error',
+      totalFiles: csprojFiles.length,
+      filesWithIssues: results.length,
+      results
+    };
+  }
+
+  /**
+   * Validate single .csproj file
+   */
+  async validateFile(filePath) {
+    const content = readFileSync(filePath, 'utf-8');
+
+    // Extract .NET version
+    const tfmMatch = content.match(/<TargetFramework>(.*?)<\/TargetFramework>/);
+    if (!tfmMatch) {
+      return {
+        dotnetVersion: null,
+        issues: [{
+          level: 'warning',
+          message: 'Could not detect TargetFramework'
+        }]
+      };
+    }
+
+    const targetFramework = tfmMatch[1];
+    const dotnetVersion = parseInt(targetFramework.replace('net', ''));
+
+    if (dotnetVersion < 9) {
+      return {
+        dotnetVersion,
+        issues: [{
+          level: 'info',
+          message: `Using .NET ${dotnetVersion} (no validation rules for versions < 9)`
+        }]
+      };
+    }
+
+    // Extract package references
+    const packages = this.extractPackages(content);
+
+    // Validate each package
+    const issues = [];
+
+    for (const pkg of packages) {
+      const issue = this.validatePackage(pkg, dotnetVersion);
+      if (issue) {
+        issues.push(issue);
+      }
+    }
+
+    return {
+      dotnetVersion,
+      packages,
+      issues
+    };
+  }
+
+  /**
+   * Extract package references from .csproj content
+   */
+  extractPackages(csprojContent) {
+    const packages = [];
+    const packageRegex = /<PackageReference\s+Include="([^"]+)"\s+Version="([^"]+)"/g;
+    let match;
+
+    while ((match = packageRegex.exec(csprojContent)) !== null) {
+      packages.push({
+        name: match[1],
+        version: match[2]
+      });
+    }
+
+    return packages;
+  }
+
+  /**
+   * Validate single package against compatibility matrix
+   */
+  validatePackage(pkg, dotnetVersion) {
+    const rule = COMPATIBILITY_MATRIX[pkg.name];
+
+    if (!rule) {
+      // Package not in matrix - no validation
+      return null;
+    }
+
+    // Check if deprecated
+    if (rule.deprecated) {
+      return {
+        level: 'error',
+        package: pkg.name,
+        installedVersion: pkg.version,
+        message: `${pkg.name} is deprecated for .NET ${dotnetVersion}`,
+        reason: rule.reason,
+        replacement: rule.replacement,
+        autoFix: false
+      };
+    }
+
+    // Check if version is sufficient
+    const requiredVersion = rule[dotnetVersion];
+
+    if (!requiredVersion) {
+      return {
+        level: 'info',
+        package: pkg.name,
+        installedVersion: pkg.version,
+        message: `No validation rule for ${pkg.name} on .NET ${dotnetVersion}`
+      };
+    }
+
+    const comparison = this.compareVersions(pkg.version, requiredVersion);
+
+    if (comparison < 0) {
+      return {
+        level: rule.breaking ? 'error' : 'warning',
+        package: pkg.name,
+        installedVersion: pkg.version,
+        requiredVersion,
+        message: `${pkg.name} ${pkg.version} is incompatible with .NET ${dotnetVersion} (requires ≥${requiredVersion})`,
+        reason: rule.reason,
+        migration: rule.migration,
+        breaking: rule.breaking,
+        autoFix: {
+          available: true,
+          command: `dotnet add package ${pkg.name} --version ${requiredVersion}`
+        }
+      };
+    }
+
+    return null; // Package is compatible
+  }
+
+  /**
+   * Compare semantic versions
+   * Returns: -1 (v1 < v2), 0 (equal), 1 (v1 > v2)
+   */
+  compareVersions(v1, v2) {
+    const parts1 = v1.split('.').map(p => parseInt(p.replace(/[^0-9]/g, '')) || 0);
+    const parts2 = v2.split('.').map(p => parseInt(p.replace(/[^0-9]/g, '')) || 0);
+
+    const maxLength = Math.max(parts1.length, parts2.length);
+
+    for (let i = 0; i < maxLength; i++) {
+      const p1 = parts1[i] || 0;
+      const p2 = parts2[i] || 0;
+
+      if (p1 < p2) return -1;
+      if (p1 > p2) return 1;
+    }
+
+    return 0;
+  }
+
+  /**
+   * Format validation results for console output
+   */
+  formatResults(results) {
+    if (results.status === 'ok') {
+      console.log(chalk.green('✅ All packages are compatible'));
+      return;
+    }
+
+    console.log(chalk.yellow(`\n⚠️  Found issues in ${results.filesWithIssues} of ${results.totalFiles} .csproj files:\n`));
+
+    for (const fileResult of results.results) {
+      console.log(chalk.cyan(`📄 ${fileResult.file} (.NET ${fileResult.dotnetVersion})`));
+
+      const errors = fileResult.issues.filter(i => i.level === 'error');
+      const warnings = fileResult.issues.filter(i => i.level === 'warning');
+      const infos = fileResult.issues.filter(i => i.level === 'info');
+
+      if (errors.length > 0) {
+        console.log(chalk.red(`\n  ❌ ${errors.length} error(s):`));
+        errors.forEach(e => {
+          console.log(chalk.red(`    - ${e.message}`));
+          if (e.reason) {
+            console.log(chalk.gray(`      Reason: ${e.reason}`));
+          }
+          if (e.replacement) {
+            console.log(chalk.cyan(`      Use instead: ${e.replacement}`));
+          }
+          if (e.autoFix?.available) {
+            console.log(chalk.green(`      Auto-fix: ${e.autoFix.command}`));
+          }
+        });
+      }
+
+      if (warnings.length > 0) {
+        console.log(chalk.yellow(`\n  ⚠️  ${warnings.length} warning(s):`));
+        warnings.forEach(w => {
+          console.log(chalk.yellow(`    - ${w.message}`));
+          if (w.autoFix?.available) {
+            console.log(chalk.green(`      Auto-fix: ${w.autoFix.command}`));
+          }
+        });
+      }
+
+      if (infos.length > 0) {
+        console.log(chalk.gray(`\n  ℹ️  ${infos.length} info(s):`));
+        infos.forEach(i => {
+          console.log(chalk.gray(`    - ${i.message}`));
+        });
+      }
+
+      console.log('');
+    }
+  }
+
+  /**
+   * Auto-fix compatible issues
+   */
+  async autoFix(results) {
+    const { execSync } = await import('child_process');
+    let fixedCount = 0;
+
+    for (const fileResult of results.results) {
+      for (const issue of fileResult.issues) {
+        if (issue.autoFix?.available) {
+          try {
+            console.log(chalk.cyan(`🔧 Fixing ${issue.package}...`));
+            execSync(issue.autoFix.command, { stdio: 'inherit' });
+            fixedCount++;
+            console.log(chalk.green(`  ✅ Fixed: ${issue.package} → ${issue.requiredVersion}`));
+          } catch (error) {
+            console.log(chalk.red(`  ❌ Failed to fix ${issue.package}: ${error.message}`));
+          }
+        }
+      }
+    }
+
+    return fixedCount;
+  }
+}
+
+/**
+ * Quick validation function (for imports)
+ */
+export async function validatePackages(projectPath = '.', options = {}) {
+  const validator = new PackageValidator(projectPath);
+  const results = await validator.validateAll();
+
+  if (options.verbose) {
+    validator.formatResults(results);
+  }
+
+  if (options.autoFix && results.status !== 'ok') {
+    const fixedCount = await validator.autoFix(results);
+    console.log(chalk.green(`\n✅ Auto-fixed ${fixedCount} issue(s)`));
+  }
+
+  return results;
+}