@pmelab/gtd 55.0.0 → 57.0.0

package/src/workflows/fix/fix-quality.feature

@@ -1,11 +1,12 @@
 @inmem
-Feature: fix's quality lap is triaged, and its leftovers go to the hand-off review
+Feature: fix's quality lap is triaged, and its leftovers are decided at the finding gate
 
   A judge sorts the lap's findings: mechanical ones are fixed for up to three
-  turns, noise is dropped, and design ones — with whatever the fix turns left —
-  are added to the reviewer's `.gtd/REVIEW.md` by gtd, never to a person's
-  gate before the review. With no requirements to check against, the
-  `criteria-coverage` lens runs no turn.
+  turns, and the design ones — with whatever the fix turns left, and the
+  noise — wait at the finding gate, never at an escalation. A ticked one is
+  fixed on the spot; the hand-off review lists what became of each in its
+  summary and carries no finding on to the next `fix`. With no requirements
+  to check against, the `criteria-coverage` lens runs no turn.
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
@@ -57,6 +58,8 @@ Feature: fix's quality lap is triaged, and its leftovers go to the hand-off revi
       The glossary says plus.
       """
     And step "build.quality.sorting" runs its script
+    And step "build.quality.gating" runs its script
+    And step "build.quality.picking" runs its script
     And step "build.quality.closing" runs its script
     And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -71,7 +74,7 @@ Feature: fix's quality lap is triaged, and its leftovers go to the hand-off revi
       """
     And step "build.review.carrying" runs its script
 
-  Scenario: a design finding and one the fix cap left reach the reviewer, never an escalation
+  Scenario: a design finding and one the fix cap left reach the finding gate, and a ticked one is fixed there
     Given judge step "build.quality.triage" answers:
       """
       [{"id":"Q1","answer":"mechanical","p":0.9},{"id":"Q2","answer":"design","p":0.9}]
@@ -79,36 +82,72 @@ Feature: fix's quality lap is triaged, and its leftovers go to the hand-off revi
     And step "build.fix.quality.fixing" changes nothing
     When gtd opens door "fix"
     And the process is driven
-    Then the process rests at "build.review.await-review"
-    And ".gtd/QUALITY.md" does not exist
+    Then the process rests at "build.quality.gate"
     And no commit body contains "build.health.describe"
     And no commit body contains "build.quality.criteria-coverage"
-    And ".gtd/REVIEW.md" contains:
+    And ".gtd/QUALITY.md" contains:
       """
-      ## sum has no negative test
+      ## sum should be named plus
 
       _From lens correctness._
 
-      _The fixer left this unresolved._
+      The glossary says plus.
+
+      - [ ] fix
+
+      ## sum has no negative test
+
+      _From lens correctness. The fixer left it unresolved._
+
+      Add a test summing negative numbers.
+
+      - [ ] fix
       """
-    And ".gtd/REVIEW.md" contains:
+    Given a file ".gtd/QUALITY.md" with:
       """
-      ## sum should be named plus
+      # Quality
 
-      _From lens correctness._
+      ## sum should be named plus
 
       The glossary says plus.
+
+      - [x] fix
+
+      ## sum has no negative test
+
+      Add a test summing negative numbers.
+
+      - [ ] fix
+      """
+    And step "build.fix.quality.fixing" is no longer scripted
+    And step "build.fix.quality.fixing" writes "src/calc.ts" with:
+      """
+      export const plus = (a: number, b: number) => a + b
+      """
+    And step "build.fix.quality.fixing" deletes ".gtd/QUALITY.md"
+    When gtd lands
+    And the process is driven
+    Then the process rests at "build.review.await-review"
+    And ".gtd/QUALITY.md" does not exist
+    And ".gtd/REVIEW.md" contains:
       """
+      Fixed at the finding gate:
+
+      - sum should be named plus (
+      """
+    And ".gtd/REVIEW.md" contains:
+      """
+      Dropped at the finding gate:
+
+      - sum has no negative test (lens correctness)
+      """
+    And ".gtd/REVIEW.md" does not contain "Tick exactly one:"
     And the commit subjects end with:
       """
-      gtd(agent): build.quality.correctness.reviewing → build.quality.triage
-      gtd(judge): build.quality.triage → build.quality.sorting
-      gtd(check): build.quality.sorting → build.fix.quality.fixing
-      gtd(agent): build.fix.quality.fixing
-      gtd(agent): build.fix.quality.fixing
+      gtd(human): build.quality.gate → build.quality.picking
+      gtd(check): build.quality.picking → build.fix.quality.fixing
       gtd(agent): build.fix.quality.fixing → build.health.check
-      gtd(check): build.health.check → build.quality.closing
-      gtd(check): build.quality.closing → build.review.reviewing
+      gtd(check): build.health.check → build.review.reviewing
       gtd(agent): build.review.reviewing → build.review.carrying
       gtd(check): build.review.carrying → build.review.await-review
       """
@@ -123,11 +162,51 @@ Feature: fix's quality lap is triaged, and its leftovers go to the hand-off revi
       it("sums negative numbers", () => {})
       """
     And step "build.fix.quality.fixing" deletes ".gtd/QUALITY.md"
+    And step "build.quality.gate" changes nothing
     When gtd opens door "fix"
     And the process is driven
     Then the process rests at "build.review.await-review"
-    And no commit body contains "build.quality.closing"
-    And ".gtd/REVIEW.md" contains "## Fixed automatically"
+    And ".gtd/REVIEW.md" contains "Fixed automatically:"
     And ".gtd/REVIEW.md" contains "- sum has no negative test ("
     And ".gtd/REVIEW.md" contains the short hash of the commit "gtd(agent): build.fix.quality.fixing → build.health.check"
     And ".gtd/REVIEW.md" contains "- sum should be named plus (p=0.9, lens correctness)"
+
+  Scenario: a risk the hand-off reviewer marks is fixed and re-reviewed in its own draft, the summary added once
+    Given judge step "build.quality.triage" answers:
+      """
+      [{"id":"Q1","answer":"mechanical","p":0.9},{"id":"Q2","answer":"noise","p":0.9}]
+      """
+    And step "build.fix.quality.fixing" deletes ".gtd/QUALITY.md"
+    And step "build.quality.gate" changes nothing
+    And step "build.review.reviewing" is no longer scripted
+    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
+      """
+      # Review: abc1234
+
+      <!-- base: 0000000 -->
+
+      ## calc
+
+      - [ ] ./src/calc.ts#1-1 — Risk: overflows on large numbers
+      """
+    When gtd opens door "fix"
+    And the process is driven
+    Then the process rests at "build.review.fix.risks.fixing"
+    And ".gtd/REVIEW.md" does not contain "## Quality lap"
+    Given step "build.review.reviewing" is no longer scripted
+    And step "build.review.reviewing" replaces the text "Risk: overflows on large numbers" in ".gtd/REVIEW.md" with "sum, now guarded"
+    And step "build.review.fix.risks.fixing" changes nothing
+    When the process is driven
+    Then the process rests at "build.review.await-review"
+    And ".gtd/REVIEW.md" contains "sum, now guarded"
+    And ".gtd/REVIEW.md" contains "## Quality lap" exactly once
+    And ".gtd/REVIEW.md" contains "## calc" exactly once
+    And the commit subjects end with:
+      """
+      gtd(check): build.quality.closing → build.review.reviewing
+      gtd(agent): build.review.reviewing → build.review.fix.risks.fixing
+      gtd(agent): build.review.fix.risks.fixing → build.health.check
+      gtd(check): build.health.check → build.review.reviewing
+      gtd(agent): build.review.reviewing → build.review.carrying
+      gtd(check): build.review.carrying → build.review.await-review
+      """

package/src/workflows/review/review-door.feature

@@ -2,9 +2,10 @@
 Feature: the review door fixes its notes in the same process
 
   `gtd door review` runs the feature's review over everything since its base:
-  the triaged quality lap writes `.gtd/REVIEW.md`, the human answers each note,
-  and what they ask for is fixed in place under the health loop before the
-  review comes back. A sign-off ends the process; nothing is left for `fix`.
+  the triaged quality lap and its finding gate, then a reviewer's walkthrough
+  of the change with the lap's summary, where the human's notes are fixed in
+  place under the health loop before the review comes back. A sign-off ends
+  the process; nothing is left for `fix`.
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
@@ -24,15 +25,27 @@ Feature: the review door fixes its notes in the same process
 
       Add a test for add.
       """
-    And step "build.quality.sorting" runs its script
     And judge step "build.quality.triage" answers:
       """
       [{"id":"Q1","answer":"design","p":0.9}]
       """
-    And step "build.review.composing" runs its script
+    And step "build.quality.gating" runs its script
+    And step "build.quality.gate" changes nothing
+    And step "build.quality.closing" runs its script
+    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
+      """
+      # Review: abc1234
+
+      <!-- base: 0000000 -->
+
+      ## Calculator
+
+      - [ ] ./src/calc.ts#1-1 — add(a, b)
+      """
+    And step "build.review.carrying" runs its script
     And step "build.review.closing" runs its script
 
-  Scenario: the review is composed from the lap's notes, with answer boxes
+  Scenario: the review is a walkthrough, its summary listing what the finding gate dropped
     When gtd opens door "review" with "HEAD~1"
     And the process is driven
     Then the process rests at "build.review.await-review"
@@ -41,72 +54,65 @@ Feature: the review door fixes its notes in the same process
       gtd(human): review-gate.check
       gtd(check): review-gate.check → build.quality.correctness.reviewing
       gtd(agent): build.quality.correctness.reviewing → build.quality.triage
-      gtd(judge): build.quality.triage → build.quality.sorting
-      gtd(check): build.quality.sorting → build.review.composing
-      gtd(check): build.review.composing → build.review.await-review
+      gtd(judge): build.quality.triage → build.quality.gating
+      gtd(check): build.quality.gating → build.quality.gate
+      gtd(human): build.quality.gate → build.quality.closing
+      gtd(check): build.quality.closing → build.review.reviewing
+      gtd(agent): build.review.reviewing → build.review.carrying
+      gtd(check): build.review.carrying → build.review.await-review
       """
     And ".gtd/REVIEW.md" contains:
       """
-      ## add has no test
-
-      Add a test for add.
+      ## Calculator
 
-      Tick exactly one:
+      - [ ] ./src/calc.ts#1-1 — add(a, b)
 
-      - [ ] fix as suggested
-      - [ ] won't fix
-      - [ ] _your answer_
+      ## Quality lap
       """
-
-  Scenario: a won't-fix signs off, and no review is left for fix
-    Given judge step "build.review.standards.judge" answers:
+    And ".gtd/REVIEW.md" contains:
       """
-      [{"id":"standard-1","answer":"no","p":0.9}]
+      Dropped at the finding gate:
+
+      - add has no test (lens correctness)
       """
-    When gtd opens door "review" with "HEAD~1"
-    And the process is driven
-    And the text "- [ ] won't fix" in ".gtd/REVIEW.md" is replaced with "- [x] won't fix"
-    And gtd lands
+    And ".gtd/REVIEW.md" does not contain "Tick exactly one:"
+    When gtd lands
     And the process is driven
     Then the process rests at "idle"
     And ".gtd/REVIEW.md" does not exist
     And ".gtd/REVIEW.orig.md" does not exist
 
-  Scenario: a note ticked fix as suggested is fixed in place, then reviewed again
-    Given step "build.review.fix.nits.fixing" writes "src/calc.test.ts" with:
+  Scenario: a nit note is fixed in place, then reviewed again
+    Given judge step "build.review.triage" answers:
+      """
+      [{"id":"note-1","answer":"nit","p":0.9}]
+      """
+    And step "build.review.fix.nits.fixing" writes "src/calc.test.ts" with:
       """
       it("adds", () => {})
       """
     When gtd opens door "review" with "HEAD~1"
     And the process is driven
-    And the text "- [ ] fix as suggested" in ".gtd/REVIEW.md" is replaced with "- [x] fix as suggested"
+    And the text "— add(a, b)" in ".gtd/REVIEW.md" is replaced with "— add(a, b) — add a test for it"
     And gtd lands
     And the process is driven
     Then the process rests at "build.review.await-review"
     And the commit subjects end with:
       """
-      gtd(human): build.review.await-review → build.review.fix.nits.fixing
+      gtd(human): build.review.await-review → build.review.triage
+      gtd(judge): build.review.triage → build.review.fix.nits.fixing
       gtd(agent): build.review.fix.nits.fixing → build.health.check
       gtd(check): build.health.check → build.review.closing
-      gtd(check): build.review.closing → build.review.composing
-      gtd(check): build.review.composing → build.review.await-review
+      gtd(check): build.review.closing → build.review.reviewing
+      gtd(agent): build.review.reviewing → build.review.carrying
+      gtd(check): build.review.carrying → build.review.await-review
       """
-    And ".gtd/REVIEW.md" contains "## Fixed from your notes"
     And "src/calc.test.ts" contains "adds"
-    When gtd lands
-    And the process is driven
-    Then the process rests at "idle"
-    And ".gtd/REVIEW.md" does not exist
-    And ".gtd/REVIEW.orig.md" does not exist
 
-  Scenario: an own answer asking for a change is fixed in place, then reviewed again
-    Given judge step "build.review.standards.judge" answers:
-      """
-      [{"id":"standard-1","answer":"no","p":0.9}]
-      """
-    And judge step "build.review.triage" answers:
+  Scenario: a note asking for a change is fixed in place, then reviewed again
+    Given judge step "build.review.triage" answers:
       """
-      [{"id":"answer-1","answer":"edit","p":0.9}]
+      [{"id":"note-1","answer":"edit","p":0.9}]
       """
     And step "build.review.collecting" writes ".gtd/REQUIREMENTS.md" with:
       """
@@ -125,14 +131,13 @@ Feature: the review door fixes its notes in the same process
     And step "feedback.closing" runs its script
     When gtd opens door "review" with "HEAD~1"
     And the process is driven
-    And the text "- [ ] _your answer_" in ".gtd/REVIEW.md" is replaced with "- [x] test negatives too"
+    And the text "— add(a, b)" in ".gtd/REVIEW.md" is replaced with "— add(a, b) — test negatives too"
     And gtd lands
     And the process is driven
     Then the process rests at "build.review.await-review"
     And the commit subjects end with:
       """
-      gtd(human): build.review.await-review → build.review.standards.judge
-      gtd(judge): build.review.standards.judge → build.review.triage
+      gtd(human): build.review.await-review → build.review.triage
       gtd(judge): build.review.triage → build.review.closing
       gtd(check): build.review.closing → build.review.collecting
       gtd(agent): build.review.collecting → re-unwind
@@ -141,9 +146,12 @@ Feature: the review door fixes its notes in the same process
       gtd(check): feedback.closing → build.health.check
       gtd(check): build.health.check → build.quality.correctness.reviewing
       gtd(agent): build.quality.correctness.reviewing → build.quality.triage
-      gtd(judge): build.quality.triage → build.quality.sorting
-      gtd(check): build.quality.sorting → build.review.composing
-      gtd(check): build.review.composing → build.review.await-review
+      gtd(judge): build.quality.triage → build.quality.gating
+      gtd(check): build.quality.gating → build.quality.gate
+      gtd(human): build.quality.gate → build.quality.closing
+      gtd(check): build.quality.closing → build.review.reviewing
+      gtd(agent): build.review.reviewing → build.review.carrying
+      gtd(check): build.review.carrying → build.review.await-review
       """
     And ".gtd/REQUIREMENTS.md" does not exist
     And "src/calc.test.ts" contains "adds negatives"
@@ -158,17 +166,12 @@ Feature: the review door fixes its notes in the same process
     Then opening door "review" is refused with ".gtd/REQUIREMENTS.md is left over"
 
   Scenario: a note added with its own boxes is fixed as ticked, never judged
-    Given judge step "build.review.standards.judge" answers:
-      """
-      [{"id":"standard-1","answer":"no","p":0.9}]
-      """
-    And step "build.review.fix.nits.fixing" writes "src/calc.ts" with:
+    Given step "build.review.fix.nits.fixing" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number): number => a + b
       """
     When gtd opens door "review" with "HEAD~1"
     And the process is driven
-    And the text "- [ ] won't fix" in ".gtd/REVIEW.md" is replaced with "- [x] won't fix"
     And ".gtd/REVIEW.md" gets appended:
       """
       ## src/calc.ts:1 (thread PRRT_1)
@@ -186,11 +189,11 @@ Feature: the review door fixes its notes in the same process
     Then the process rests at "build.review.await-review"
     And the commit subjects end with:
       """
-      gtd(human): build.review.await-review → build.review.standards.judge
-      gtd(judge): build.review.standards.judge → build.review.fix.nits.fixing
+      gtd(human): build.review.await-review → build.review.fix.nits.fixing
       gtd(agent): build.review.fix.nits.fixing → build.health.check
       gtd(check): build.health.check → build.review.closing
-      gtd(check): build.review.closing → build.review.composing
-      gtd(check): build.review.composing → build.review.await-review
+      gtd(check): build.review.closing → build.review.reviewing
+      gtd(agent): build.review.reviewing → build.review.carrying
+      gtd(check): build.review.carrying → build.review.await-review
       """
     And "src/calc.ts" contains "): number =>"

package/src/workflows/shared/learn.test.ts

@@ -117,20 +117,6 @@ describe("learnStandards", () => {
 })
 
 describe("learnStandards, from a won't-fix", () => {
-  it("states the finding, not gtd's banner", async () => {
-    state.answers = { "standard-1": yes }
-    await learnStandards([
-      {
-        anchor: "Slow loop",
-        // As the review parser hands it over: paragraphs joined by a space.
-        body: "_The fixer left this unresolved._ The loop is quadratic.",
-        choice: "wontfix",
-        text: "",
-      },
-    ])
-    expect(kept()).toBe(file("- Won't fix: Slow loop — The loop is quadratic."))
-  })
-
   it("replaces an old standard hand-edited in case only", async () => {
     state.files[STANDARDS] = file(
       "- use classes.",

package/src/workflows/shared/learn.ts

@@ -32,13 +32,8 @@ interface Candidate {
 
 const SUMMARY_MAX = 200
 
-// The banners composedReview opens a note with say nothing about the finding; the
-// parsed body has its paragraphs joined, so they are matched by their own text.
-const BANNER =
-  /^_(?:The fixer left this unresolved\.|A fix turn removed this while renaming another finding — check whether it was fixed\.|No detail given\.)_\s*/
-
 const summary = (body: string): string => {
-  const text = oneLine(body).replace(BANNER, "")
+  const text = oneLine(body)
   return text.length > SUMMARY_MAX ? `${text.slice(0, SUMMARY_MAX - 1)}…` : text
 }