@pmelab/gtd 55.0.0 → 57.0.0

package/src/workflows/feature/refactor-review.feature

@@ -9,7 +9,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_PROTOTYPEROUNDS" set to "0"
     And an environment variable "GTD_QUALITYREVIEWS" set to ""
     And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
 
@@ -83,10 +82,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -185,10 +180,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -211,9 +202,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       """
       gtd(check): refactor.closing → refactor.build.quality.correctness.reviewing
       gtd(agent): refactor.build.quality.correctness.reviewing → refactor.build.review.reviewing
-      gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-      gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-      gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+      gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
       """
 
 
@@ -288,10 +277,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         """
       And step "refactor.health.check" changes nothing
       And step "refactor.closing" runs its script
-      And judge step "refactor.build.review.ranking" answers:
-        """
-        []
-        """
       And step "refactor.build.review.carrying" runs its script
       And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
         """
@@ -315,9 +300,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^why]
@@ -354,9 +337,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op
@@ -380,9 +361,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         gtd(agent): refactor.building → refactor.health.check
         gtd(check): refactor.health.check → refactor.closing
         gtd(check): refactor.closing → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
     Scenario: a question answered at the refactor review reaches the re-derived package as ### Answered Questions
@@ -394,9 +373,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-1
           why a shared op?
@@ -473,9 +450,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         gtd(agent): refactor.building → refactor.health.check
         gtd(check): refactor.health.check → refactor.closing
         gtd(check): refactor.closing → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
     Scenario: an edit note the collecting turn leaves out refuses the landing and never signs off
@@ -487,9 +462,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — this should change behaviour, not just structure
@@ -533,9 +506,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2 rename the helper
           add built on the shared op
@@ -562,9 +533,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work
@@ -583,9 +552,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -635,9 +602,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -669,9 +634,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -718,9 +681,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -746,9 +707,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -775,9 +734,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -809,9 +766,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -837,9 +792,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op - this should change behaviour, not just structure[^q]
@@ -871,9 +824,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op - this should change behaviour, not just structure[^q]
@@ -918,9 +869,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -952,9 +901,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -1000,9 +947,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work[^q]
@@ -1034,9 +979,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work[^q]
@@ -1087,9 +1030,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [x] ./src/calc.ts#1-2
           add built on the shared op
@@ -1112,9 +1053,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — rename `sign` to `direction`
@@ -1143,9 +1082,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — rename `sign` to `direction`
@@ -1166,9 +1103,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       And the commit subjects end with:
         """
         gtd(check): refactor.closing → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
     Scenario: a reviewer walks the human through the whole refactor, every chunk pointing at its code
@@ -1176,9 +1111,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       Then the process rests at "refactor.build.review.await-review"
       And ".gtd/REVIEW.md" contains:
         """
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op
@@ -1206,21 +1139,17 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       Then the process rests at "refactor.build.review.await-review"
       And ".gtd/REVIEW.md" contains:
         """
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2 — Risk: still drops the sign
         """
-      And ".gtd/REVIEW.md" contains "## Walkthrough" exactly once
+      And ".gtd/REVIEW.md" contains "## calc" exactly once
       And the commit subjects end with:
         """
         gtd(agent): refactor.build.review.reviewing → refactor.build.review.fix.risks.fixing
         gtd(agent): refactor.build.review.fix.risks.fixing → refactor.build.health.check
         gtd(check): refactor.build.health.check → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
   Rule: with a quality lens on both the refactor and the feature
@@ -1295,10 +1224,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         """
       And step "refactor.health.check" changes nothing
       And step "refactor.closing" runs its script
-      And judge step "refactor.build.review.ranking" answers:
-        """
-        []
-        """
       And step "refactor.build.review.carrying" runs its script
       And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
         """
@@ -1338,9 +1263,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [x] ./src/calc.ts#1-2
           add built on the shared op
@@ -1509,10 +1432,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         """
       And step "refactor.health.check" changes nothing
       And step "refactor.closing" runs its script
-      And judge step "refactor.build.review.ranking" answers:
-        """
-        []
-        """
       And step "refactor.build.review.carrying" runs its script
       And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
         """
@@ -1533,9 +1452,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^why]
@@ -1575,9 +1492,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op

package/src/workflows/feature/refactor.test.ts

@@ -930,8 +930,6 @@ describe("reviewedRefactor", () => {
       "refactor.build.quality.ponytail-review.reviewing",
       "refactor.build.quality.conventions.reviewing",
       "refactor.build.review.reviewing",
-      "refactor.build.review.ranking",
-      "refactor.build.review.carrying",
       "refactor.build.review.await-review",
       "refactor.build.review.closing",
     ])

package/src/workflows/feature/refactor.ts

@@ -355,7 +355,6 @@ export const reviewedRefactor = async (
         fixAccess: strayAccess(p.strays),
         lensBase: entry,
         rules: t.refactorRules(p.strays, p.pattern),
-        walkthrough: true,
         lap: "refactor",
       })
       if (outcome.verdict === "signoff") return true

package/src/workflows/feature/review-gate.feature

@@ -4,13 +4,12 @@ Feature: a feature process ends at the human review
   After the quality lap the process rests at the review gate,
   `.gtd/REVIEW.md`. A sign-off ends the process. A note asking for a change in
   behaviour starts a feedback lap — design, then implement with no new naive
-  pass or seam judge, the hands-on test, the quality lap — and the review
+  pass or seam judge, the quality lap — and the review
   again. Its design keeps a built criterion's ID and numbers
   new behaviour above every ID handed out.
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_PROTOTYPEROUNDS" set to "0"
     And an environment variable "GTD_QUALITYREVIEWS" set to ""
     And an environment variable "GTD_FLAGMODE" set to "false"
     And a file "src/calc.ts" with:
@@ -71,10 +70,6 @@ Feature: a feature process ends at the human review
       """
     And step "build.review.closing" runs its script
     And step "build.review.carrying" runs its script
-    And judge step "build.review.ranking" answers:
-      """
-      []
-      """
 
   Scenario: a feature process ends at the review gate
     When the process is driven
@@ -85,9 +80,7 @@ Feature: a feature process ends at the human review
       """
       gtd(check): implement.health.check → implement.closing
       gtd(check): implement.closing → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.ranking
-      gtd(judge): build.review.ranking → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
+      gtd(agent): build.review.reviewing → build.review.await-review
       """
 
   Scenario: a sign-off ends the process at idle
@@ -99,9 +92,7 @@ Feature: a feature process ends at the human review
 
       <!-- base: 0000000 -->
 
-      ## Walkthrough
-
-      ### calc
+      ## calc
 
       - [x] ./src/calc.ts#2-2
         new subtract function
@@ -112,9 +103,7 @@ Feature: a feature process ends at the human review
     And ".gtd/REVIEW.md" does not exist
     And the commit subjects end with:
       """
-      gtd(agent): build.review.reviewing → build.review.ranking
-      gtd(judge): build.review.ranking → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
+      gtd(agent): build.review.reviewing → build.review.await-review
       gtd(human): build.review.await-review → build.review.closing
       gtd(check): build.review.closing → idle
       """
@@ -156,9 +145,7 @@ Feature: a feature process ends at the human review
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#2-2
           new subtract function[^why]
@@ -176,9 +163,7 @@ Feature: a feature process ends at the human review
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#2-2
           new subtract function
@@ -229,9 +214,7 @@ Feature: a feature process ends at the human review
         gtd(agent): implement.building → implement.health.check
         gtd(check): implement.health.check → implement.closing
         gtd(check): implement.closing → build.review.reviewing
-        gtd(agent): build.review.reviewing → build.review.ranking
-        gtd(judge): build.review.ranking → build.review.carrying
-        gtd(check): build.review.carrying → build.review.await-review
+        gtd(agent): build.review.reviewing → build.review.await-review
         """
 
     Scenario: a design numbering new behaviour at or below an earlier ID is refused