@pmelab/gtd 54.0.0 → 56.0.0

package/src/workflows/feature/refactor-review.feature

@@ -83,10 +83,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -185,10 +181,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -211,9 +203,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       """
       gtd(check): refactor.closing → refactor.build.quality.correctness.reviewing
       gtd(agent): refactor.build.quality.correctness.reviewing → refactor.build.review.reviewing
-      gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-      gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-      gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+      gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
       """
 
 
@@ -288,10 +278,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         """
       And step "refactor.health.check" changes nothing
       And step "refactor.closing" runs its script
-      And judge step "refactor.build.review.ranking" answers:
-        """
-        []
-        """
       And step "refactor.build.review.carrying" runs its script
       And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
         """
@@ -315,9 +301,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^why]
@@ -354,9 +338,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op
@@ -380,9 +362,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         gtd(agent): refactor.building → refactor.health.check
         gtd(check): refactor.health.check → refactor.closing
         gtd(check): refactor.closing → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
     Scenario: a question answered at the refactor review reaches the re-derived package as ### Answered Questions
@@ -394,9 +374,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-1
           why a shared op?
@@ -473,9 +451,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         gtd(agent): refactor.building → refactor.health.check
         gtd(check): refactor.health.check → refactor.closing
         gtd(check): refactor.closing → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
     Scenario: an edit note the collecting turn leaves out refuses the landing and never signs off
@@ -487,9 +463,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — this should change behaviour, not just structure
@@ -533,9 +507,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2 rename the helper
           add built on the shared op
@@ -562,9 +534,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work
@@ -583,9 +553,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -635,9 +603,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -669,9 +635,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -718,9 +682,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -746,9 +708,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -775,9 +735,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -809,9 +767,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^n1]
@@ -837,9 +793,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op - this should change behaviour, not just structure[^q]
@@ -871,9 +825,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op - this should change behaviour, not just structure[^q]
@@ -918,9 +870,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -952,9 +902,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^q]
@@ -1000,9 +948,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work[^q]
@@ -1034,9 +980,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op, lovely work[^q]
@@ -1087,9 +1031,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [x] ./src/calc.ts#1-2
           add built on the shared op
@@ -1112,9 +1054,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — rename `sign` to `direction`
@@ -1143,9 +1083,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op — rename `sign` to `direction`
@@ -1166,9 +1104,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       And the commit subjects end with:
         """
         gtd(check): refactor.closing → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
     Scenario: a reviewer walks the human through the whole refactor, every chunk pointing at its code
@@ -1176,9 +1112,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       Then the process rests at "refactor.build.review.await-review"
       And ".gtd/REVIEW.md" contains:
         """
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op
@@ -1206,21 +1140,17 @@ Feature: the refactor is reviewed on its own before the feature is implemented
       Then the process rests at "refactor.build.review.await-review"
       And ".gtd/REVIEW.md" contains:
         """
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2 — Risk: still drops the sign
         """
-      And ".gtd/REVIEW.md" contains "## Walkthrough" exactly once
+      And ".gtd/REVIEW.md" contains "## calc" exactly once
       And the commit subjects end with:
         """
         gtd(agent): refactor.build.review.reviewing → refactor.build.review.fix.risks.fixing
         gtd(agent): refactor.build.review.fix.risks.fixing → refactor.build.health.check
         gtd(check): refactor.build.health.check → refactor.build.review.reviewing
-        gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-        gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-        gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+        gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
   Rule: with a quality lens on both the refactor and the feature
@@ -1295,10 +1225,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         """
       And step "refactor.health.check" changes nothing
       And step "refactor.closing" runs its script
-      And judge step "refactor.build.review.ranking" answers:
-        """
-        []
-        """
       And step "refactor.build.review.carrying" runs its script
       And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
         """
@@ -1338,9 +1264,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [x] ./src/calc.ts#1-2
           add built on the shared op
@@ -1509,10 +1433,6 @@ Feature: the refactor is reviewed on its own before the feature is implemented
         """
       And step "refactor.health.check" changes nothing
       And step "refactor.closing" runs its script
-      And judge step "refactor.build.review.ranking" answers:
-        """
-        []
-        """
       And step "refactor.build.review.carrying" runs its script
       And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
         """
@@ -1533,9 +1453,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op[^why]
@@ -1575,9 +1493,7 @@ Feature: the refactor is reviewed on its own before the feature is implemented
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#1-2
           add built on the shared op

package/src/workflows/feature/refactor.test.ts

@@ -930,8 +930,6 @@ describe("reviewedRefactor", () => {
       "refactor.build.quality.ponytail-review.reviewing",
       "refactor.build.quality.conventions.reviewing",
       "refactor.build.review.reviewing",
-      "refactor.build.review.ranking",
-      "refactor.build.review.carrying",
       "refactor.build.review.await-review",
       "refactor.build.review.closing",
     ])

package/src/workflows/feature/refactor.ts

@@ -355,7 +355,6 @@ export const reviewedRefactor = async (
         fixAccess: strayAccess(p.strays),
         lensBase: entry,
         rules: t.refactorRules(p.strays, p.pattern),
-        walkthrough: true,
         lap: "refactor",
       })
       if (outcome.verdict === "signoff") return true

package/src/workflows/feature/review-gate.feature

@@ -71,10 +71,6 @@ Feature: a feature process ends at the human review
       """
     And step "build.review.closing" runs its script
     And step "build.review.carrying" runs its script
-    And judge step "build.review.ranking" answers:
-      """
-      []
-      """
 
   Scenario: a feature process ends at the review gate
     When the process is driven
@@ -85,9 +81,7 @@ Feature: a feature process ends at the human review
       """
       gtd(check): implement.health.check → implement.closing
       gtd(check): implement.closing → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.ranking
-      gtd(judge): build.review.ranking → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
+      gtd(agent): build.review.reviewing → build.review.await-review
       """
 
   Scenario: a sign-off ends the process at idle
@@ -99,9 +93,7 @@ Feature: a feature process ends at the human review
 
       <!-- base: 0000000 -->
 
-      ## Walkthrough
-
-      ### calc
+      ## calc
 
       - [x] ./src/calc.ts#2-2
         new subtract function
@@ -112,9 +104,7 @@ Feature: a feature process ends at the human review
     And ".gtd/REVIEW.md" does not exist
     And the commit subjects end with:
       """
-      gtd(agent): build.review.reviewing → build.review.ranking
-      gtd(judge): build.review.ranking → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
+      gtd(agent): build.review.reviewing → build.review.await-review
       gtd(human): build.review.await-review → build.review.closing
       gtd(check): build.review.closing → idle
       """
@@ -156,9 +146,7 @@ Feature: a feature process ends at the human review
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#2-2
           new subtract function[^why]
@@ -176,9 +164,7 @@ Feature: a feature process ends at the human review
 
         <!-- base: 0000000 -->
 
-        ## Walkthrough
-
-        ### calc
+        ## calc
 
         - [ ] ./src/calc.ts#2-2
           new subtract function
@@ -229,9 +215,7 @@ Feature: a feature process ends at the human review
         gtd(agent): implement.building → implement.health.check
         gtd(check): implement.health.check → implement.closing
         gtd(check): implement.closing → build.review.reviewing
-        gtd(agent): build.review.reviewing → build.review.ranking
-        gtd(judge): build.review.ranking → build.review.carrying
-        gtd(check): build.review.carrying → build.review.await-review
+        gtd(agent): build.review.reviewing → build.review.await-review
         """
 
     Scenario: a design numbering new behaviour at or below an earlier ID is refused

package/src/workflows/feature/reviewer-walkthrough.feature

@@ -3,16 +3,15 @@ Feature: a reviewer walks the human through the feature's code
 
   The feature's final review is written by a reviewer turn
   (`build.review.reviewing`): chunks grouped by concern, each pointing at its
-  code, so the phone shows it. Every finding the quality laps left gets a chunk
-  of its own, headed exactly as the prompt gives it, holding the pointers to the
-  code it cites; gtd then adds the finding's text and the answer boxes
-  (`build.review.carrying`). A chunk pointing at no code, or a finding left out,
-  is refused.
+  code, so the phone shows it. The quality lap's findings were decided at the
+  finding gate: the reviewer is told nothing of them, and gtd only appends
+  the lap's summary (`build.review.carrying`). A chunk pointing at no code is
+  refused.
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
     And an environment variable "GTD_PROTOTYPEROUNDS" set to "0"
-    And an environment variable "GTD_QUALITYREVIEWS" set to "correctness"
+    And an environment variable "GTD_QUALITYREVIEWS" set to ""
     And an environment variable "GTD_FLAGMODE" set to "false"
     And a file "src/calc.ts" with:
       """
@@ -53,30 +52,9 @@ Feature: a reviewer walks the human through the feature's code
     And step "implement.applying" runs its script
     And step "implement.health.check" changes nothing
     And step "implement.closing" runs its script
-    And step "build.quality.correctness.reviewing" writes ".gtd/QUALITY.md" with:
-      """
-      # Quality
-
-      ## AC-1 ignores floating point
-
-      Should subtract round? The criterion does not say.
-      """
-    And judge step "build.quality.triage" answers:
-      """
-      [{"id":"Q1","answer":"design","p":0.9}]
-      """
-    And step "build.quality.sorting" runs its script
-    And step "build.quality.closing" runs its script
-    And step "build.review.carrying" runs its script
-    And judge step "build.review.ranking" answers:
-      """
-      []
-      """
 
-  Scenario: the finding gets its text and answer boxes under the reviewer's pointers
-    Given step "build.review.reviewing" is prompted with "- `## AC-1 ignores floating point`:"
-    And step "build.review.reviewing" is prompted with "> Should subtract round? The criterion does not say."
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
+  Scenario: the review is the reviewer's walkthrough, as it wrote it
+    Given step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
       # Review: abc1234
 
@@ -87,47 +65,24 @@ Feature: a reviewer walks the human through the feature's code
       The new export.
 
       - [ ] ./src/calc.ts#2-2 — subtract(a, b)
-
-      ## AC-1 ignores floating point
-
-      - [ ] ./src/calc.ts#2-2 — returns the raw difference
       """
     When the process is driven
     Then the process rests at "build.review.await-review"
+    And the resting step's content does not contain "Tick exactly one"
     And ".gtd/REVIEW.md" contains:
       """
-      ## Findings
-
-      ### AC-1 ignores floating point
-
-      _critical: judge unsure_
-
-      Should subtract round? The criterion does not say.
-
-      In the code:
-
-      - [ ] ./src/calc.ts#2-2 — returns the raw difference
-
-      Tick exactly one:
-
-      - [ ] fix as suggested
-      - [ ] won't fix
-      - [ ] _your answer_
-
-      ## Walkthrough
+      <!-- base: 0000000 -->
 
-      ### Subtract
+      ## Subtract
 
       The new export.
 
       - [ ] ./src/calc.ts#2-2 — subtract(a, b)
       """
-    And no commit body contains "build.review.composing"
     And the commit subjects end with:
       """
-      gtd(agent): build.review.reviewing → build.review.ranking
-      gtd(judge): build.review.ranking → build.review.carrying
-      gtd(check): build.review.carrying → build.review.await-review
+      gtd(check): implement.closing → build.review.reviewing
+      gtd(agent): build.review.reviewing → build.review.await-review
       """
 
   Scenario: a chunk pointing at no code is refused
@@ -140,10 +95,6 @@ Feature: a reviewer walks the human through the feature's code
       ## Subtract
 
       The new export, with no pointer.
-
-      ## AC-1 ignores floating point
-
-      - [ ] ./src/calc.ts#2-2 — returns the raw difference
       """
     Then driving the process is refused with "Subtract — points at no code"
 
@@ -158,26 +109,9 @@ Feature: a reviewer walks the human through the feature's code
 
       ### Subtract
 
-      - [ ] ./src/calc.ts#2-2 — subtract(a, b)
-
-      ### AC-1 ignores floating point
-
-      - [ ] ./src/calc.ts#2-2 — returns the raw difference
-      """
-    Then driving the process is refused with "Walkthrough — gtd sorts the chunks into sections; write `## ` chunks only"
-
-  Scenario: a finding the reviewer left out is refused
-    Given step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## Subtract
-
       - [ ] ./src/calc.ts#2-2 — subtract(a, b)
       """
-    Then driving the process is refused with "AC-1 ignores floating point — no chunk of its own"
+    Then driving the process is refused with "Walkthrough — write `## ` chunks only"
 
   Scenario: a standard conflict the reviewer writes itself is refused
     Given step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
@@ -189,31 +123,10 @@ Feature: a reviewer walks the human through the feature's code
       ## Standard conflict 0123abcd
 
       - [ ] ./src/calc.ts#2-2 — copied over
-
-      ## AC-1 ignores floating point
-
-      - [ ] ./src/calc.ts#2-2 — returns the raw difference
       """
     Then driving the process is refused with "Standard conflict 0123abcd — gtd writes conflicts"
 
   Scenario: two chunks with one title are refused
-    Given step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## AC-1 ignores floating point
-
-      - [ ] ./src/calc.ts#2-2 — subtract(a, b)
-
-      ## AC-1 ignores floating point
-
-      - [ ] ./src/calc.ts#2-2 — returns the raw difference
-      """
-    Then driving the process is refused with "AC-1 ignores floating point — a second chunk with this title"
-
-  Scenario: a risk marked in a finding's chunk is refused, never fixed
     Given step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
       # Review: abc1234
@@ -224,8 +137,8 @@ Feature: a reviewer walks the human through the feature's code
 
       - [ ] ./src/calc.ts#2-2 — subtract(a, b)
 
-      ## AC-1 ignores floating point
+      ## Subtract
 
-      - [ ] ./src/calc.ts#2-2 — Risk: no rounding
+      - [ ] ./src/calc.ts#2-2 — returns the raw difference
       """
-    Then driving the process is refused with "no `Risk:` in a quality finding's chunk"
+    Then driving the process is refused with "Subtract — a second chunk with this title"