@pmelab/gtd 54.0.0 → 56.0.0

package/src/workflows/feature/naive-acceptance.feature

@@ -1,11 +1,10 @@
 @inmem
-Feature: a naive pass ends only when a test names every criterion and the suite is green
+Feature: a naive pass ends only when its tests reach no file it added and the suite is green
 
-  `seam.naive` writes behaviour-level acceptance tests, each naming its
-  criterion's ID. A pass whose tests leave an ID out or import a file the
-  pass added is sent back; `seam.check` then runs the suite with the kept
-  pass applied, and a red run sends it back too, before the judge sees it.
-  Three failed attempts rest at `seam.steer`.
+  `seam.naive` needs no test at all. A pass whose test imports a file the pass
+  added is sent back; `seam.check` then runs the suite with the kept pass
+  applied, and a red run sends it back too, before the judge sees it. Three
+  failed attempts rest at `seam.steer`.
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
@@ -44,15 +43,30 @@ Feature: a naive pass ends only when a test names every criterion and the suite
       export const subtract = (a: number, b: number) => a - b
       """
 
-  Scenario: a pass whose tests leave a criterion's ID out is sent back, and an overrule runs the check and sticks
-    Given step "seam.naive" writes "tests/calc.test.ts" with:
+  Scenario: a pass without a test goes on to the check and the judge
+    Given step "seam.check" changes nothing
+    When the process is driven
+    Then the process rests at "seam.judge"
+    And the commit subjects end with:
       """
-      import { add, subtract } from "../src/calc.js"
-      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
+      gtd(human): design.gate.answer → seam.naive
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
+      """
+
+  Scenario: a test importing a file the pass added is sent back, and an overrule runs the check and sticks
+    Given step "seam.naive" writes "src/subtract.ts" with:
+      """
+      export const subtract = (a: number, b: number) => a - b
+      """
+    And step "seam.naive" writes "src/subtract.test.ts" with:
+      """
+      import { subtract } from "./subtract.js"
+      it("subtracts", () => expect(subtract(5, 3)).toBe(2))
       """
     When the process is driven
     Then the process rests at "seam.steer"
-    And the resting step's content contains "acceptance-tests: no test of the naive pass names AC-2"
+    And the resting step's content contains "src/subtract.test.ts → src/subtract.ts"
 
     Given step "seam.check" changes nothing
     When gtd lands
@@ -87,27 +101,12 @@ Feature: a naive pass ends only when a test names every criterion and the suite
       gtd(judge): seam.judge → seam.steer
       """
 
-  Scenario: a test importing a file the pass added is sent back
-    Given step "seam.naive" writes "src/subtract.ts" with:
-      """
-      export const subtract = (a: number, b: number) => a - b
-      """
-    And step "seam.naive" writes "src/subtract.test.ts" with:
-      """
-      import { subtract } from "./subtract.js"
-      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
-      it("[AC-2] still adds", () => {})
-      """
-    When the process is driven
-    Then the process rests at "seam.steer"
-    And the resting step's content contains "src/subtract.test.ts → src/subtract.ts"
-
   Scenario: a red suite sends the pass back, and it moves on only once green
     Given step "seam.naive" writes "tests/calc.test.ts" with:
       """
       import { add, subtract } from "../src/calc.js"
-      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
-      it("[AC-2] still adds", () => expect(add(1, 1)).toBe(2))
+      it("subtracts", () => expect(subtract(5, 3)).toBe(2))
+      it("still adds", () => expect(add(1, 1)).toBe(2))
       """
     When the process is driven
     Then the process rests at "seam.check"
@@ -118,18 +117,18 @@ Feature: a naive pass ends only when a test names every criterion and the suite
     Given step "seam.naive" is no longer scripted
     And step "seam.check" writes ".gtd/FEEDBACK.md" with:
       """
-      FAIL tests/calc.test.ts > [AC-1] subtracts
+      FAIL tests/calc.test.ts > subtracts
       """
     When the process is driven
     Then the process rests at "seam.naive"
     And the resting step's content contains "left the suite red"
-    And ".gtd/FEEDBACK.md" contains "[AC-1] subtracts"
+    And ".gtd/FEEDBACK.md" contains "> subtracts"
 
     Given step "seam.naive" writes "tests/calc.test.ts" with:
       """
       import { add, subtract } from "../src/calc.js"
-      it("[AC-1] subtracts", () => expect(subtract(5, 3)).toBe(2))
-      it("[AC-2] still adds", () => expect(add(2, 2)).toBe(4))
+      it("subtracts", () => expect(subtract(5, 3)).toBe(2))
+      it("still adds", () => expect(add(2, 2)).toBe(4))
       """
     And step "seam.check" from now on changes nothing
     When the process is driven

package/src/workflows/feature/prototype.ts

@@ -3,7 +3,6 @@ import { HEADING, markFenced } from "../shared/fences.js"
 import { coder, PROTOTYPE, REQUIREMENTS } from "../shared/steps.js"
 import * as t from "../shared/text.js"
 import { defaults } from "../shared/vars.js"
-import type { Guard } from "../shared/health.js"
 import { green } from "./green.js"
 import { criteriaOf, criterionIds, handsOnIds, requireCriteriaFrozen } from "./criteria.js"
 
@@ -130,7 +129,7 @@ const testing = async (
   return requireReport(ids, retest)
 }
 
-const fixing = async (guard?: Guard): Promise<void> => {
+const fixing = async (): Promise<void> => {
   await scope("fix", () =>
     t.agentWithSkills("fixing", t.prototypeFixingPrompt(), {
       label: "Fixing what the hands-on test found",
@@ -145,7 +144,6 @@ const fixing = async (guard?: Guard): Promise<void> => {
   if (changes().some((c) => c.path === PROTOTYPE))
     refuse(`gtd land: prototype-fix: leave ${PROTOTYPE} as it is — the next round re-tests from it`)
   frozen()
-  guard?.()
 }
 
 /** A person's rest; resolves `true` when they changed something to test again, `false` on a clean overrule. */
@@ -161,10 +159,9 @@ const askPerson = async (name: string, message: string, label: string): Promise<
  * Use the change by hand: a testing turn reports on every criterion a person
  * can observe, a fix turn takes each failure, and the change is tested again —
  * until the report is clean, or `prototypeRounds` fixes are spent and a person
- * decides. A change with no such criterion is not tested by hand. `guard`
- * holds every fix turn, as it holds the implementation's.
+ * decides. A change with no such criterion is not tested by hand.
  */
-export const prototypeTest = async (guard?: Guard): Promise<void> => {
+export const prototypeTest = async (): Promise<void> => {
   const cap = prototypeRounds()
   if (cap === 0) return
   await scope("prototype", async () => {
@@ -185,7 +182,7 @@ export const prototypeTest = async (guard?: Guard): Promise<void> => {
       } else if (open.length === 0) return
       else if (fixes < cap && open.some((i) => i.verdict === "fail")) {
         fixes++
-        await fixing(guard)
+        await fixing()
       } else {
         const changed = await askPerson(
           "open",
@@ -195,7 +192,7 @@ export const prototypeTest = async (guard?: Guard): Promise<void> => {
         if (!changed) return
         fixes = 0
       }
-      await green(guard)
+      await green()
     }
   })
 }

package/src/workflows/feature/refactor-absorbs.feature

@@ -74,10 +74,6 @@ Feature: a refactor that carried the whole feature still gets a quality lap over
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -100,9 +96,7 @@ Feature: a refactor that carried the whole feature still gets a quality lap over
 
       <!-- base: 0000000 -->
 
-      ## Walkthrough
-
-      ### calc
+      ## calc
 
       - [x] ./src/calc.ts#1-2
         subtract next to add

package/src/workflows/feature/refactor-first.feature

@@ -77,10 +77,6 @@ Feature: a refactor-first judgment walks one fixed path to the review gate
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -104,9 +100,7 @@ Feature: a refactor-first judgment walks one fixed path to the review gate
 
       <!-- base: 0000000 -->
 
-      ## Walkthrough
-
-      ### calc
+      ## calc
 
       - [x] ./src/calc.ts#1-2
         add built on the shared op
@@ -147,9 +141,7 @@ Feature: a refactor-first judgment walks one fixed path to the review gate
       gtd(agent): refactor.building → refactor.health.check
       gtd(check): refactor.health.check → refactor.closing
       gtd(check): refactor.closing → refactor.build.review.reviewing
-      gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-      gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-      gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+      gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
       gtd(human): refactor.build.review.await-review → refactor.build.review.closing
       gtd(check): refactor.build.review.closing → implement.building
       gtd(agent): implement.building → implement.health.check

package/src/workflows/feature/refactor-rebuild.feature

@@ -5,8 +5,9 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
   On a refactor-first judgment the naive pass is never applied. `seam.note`
   reads the whole naive diff and writes `.gtd/REFACTOR-NOTE.md`; the refactor
   lands on its own with the existing suite green; the rebuild re-implements the
-  change on the refactored base and lands only once it carries the naive pass's
-  acceptance tests and the suite is green. The note reaches both turns.
+  change on the refactored base, is asked to carry over every test file the
+  naive pass added or changed, and lands once the suite is green. The note
+  reaches both turns.
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
@@ -18,6 +19,10 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
       """
       export const add = (a: number, b: number) => a + b
       """
+    And a file "src/calc.test.ts" with:
+      """
+      it("adds", () => {})
+      """
     And the working tree is committed as "feat: add calculator"
     And a file "TODO.md" with:
       """
@@ -49,7 +54,12 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
     And step "seam.check" changes nothing
     And step "seam.naive" writes "src/acceptance.test.ts" with:
       """
-      it("[AC-1] subtracts", () => {})
+      it("subtracts", () => {})
+      """
+    And step "seam.naive" writes "src/calc.test.ts" with:
+      """
+      it("adds", () => {})
+      it("subtracts a larger number", () => {})
       """
     And step "seam.naive" writes "src/calc.ts" with:
       """
@@ -88,10 +98,6 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -114,9 +120,7 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
 
       <!-- base: 0000000 -->
 
-      ## Walkthrough
-
-      ### calc
+      ## calc
 
       - [x] ./src/calc.ts#1-2
         add built on the shared op
@@ -125,7 +129,8 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
     And the process is driven
     Then the process rests at "implement.building"
     And the resting step's content contains "shared `op(a, b, sign)`"
-    And the resting step's content contains "acceptance tests for AC-1"
+    And the resting step's content contains "Carry over the naive pass's acceptance tests"
+    And the resting step's content contains "'src/acceptance.test.ts' 'src/calc.test.ts'"
 
   Scenario: a note turn that changes anything but the note is refused
     Given step "seam.note" writes "src/calc.ts" with:
@@ -159,10 +164,6 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -185,9 +186,7 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
 
       <!-- base: 0000000 -->
 
-      ## Walkthrough
-
-      ### calc
+      ## calc
 
       - [x] ./src/calc.ts#1-2
         add built on the shared op
@@ -198,7 +197,7 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
     And "src/calc.ts" contains "op(a, b, 1)"
     And "src/calc.ts" does not contain "subtract"
 
-  Scenario: the rebuild lands only once it carries the naive pass's acceptance tests, green
+  Scenario: the rebuild lands once green, whichever tests it carried
     Given step "seam.note" writes ".gtd/REFACTOR-NOTE.md" with:
       """
       Seam: a shared `op` in src/calc.ts.
@@ -211,10 +210,6 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
       """
     And step "refactor.health.check" changes nothing
     And step "refactor.closing" runs its script
-    And judge step "refactor.build.review.ranking" answers:
-      """
-      []
-      """
     And step "refactor.build.review.carrying" runs its script
     And step "refactor.build.review.reviewing" writes ".gtd/REVIEW.md" with:
       """
@@ -237,9 +232,7 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
 
       <!-- base: 0000000 -->
 
-      ## Walkthrough
-
-      ### calc
+      ## calc
 
       - [x] ./src/calc.ts#1-2
         add built on the shared op
@@ -254,18 +247,11 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
       export const add = (a: number, b: number) => op(a, b, 1)
       export const subtract = (a: number, b: number) => op(a, b, -1)
       """
-    Then driving the process is refused with "rebuild-acceptance"
-
-    Given step "implement.building" writes "src/acceptance.test.ts" with:
-      """
-      it("[AC-1] subtracts", () => {})
-      """
     And step "implement.health.check" changes nothing
     And step "implement.closing" runs its script
     When the process is driven
     Then the process rests at "build.review.reviewing"
     And "src/calc.ts" contains "op(a, b, -1)"
-    And "src/acceptance.test.ts" contains "[AC-1]"
     And ".gtd/REFACTOR-NOTE.md" does not exist
     And the commit subjects end with:
       """
@@ -275,9 +261,7 @@ Feature: refactor-first writes a refactor note, refactors on its own, then rebui
       gtd(agent): refactor.building → refactor.health.check
       gtd(check): refactor.health.check → refactor.closing
       gtd(check): refactor.closing → refactor.build.review.reviewing
-      gtd(agent): refactor.build.review.reviewing → refactor.build.review.ranking
-      gtd(judge): refactor.build.review.ranking → refactor.build.review.carrying
-      gtd(check): refactor.build.review.carrying → refactor.build.review.await-review
+      gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
       gtd(human): refactor.build.review.await-review → refactor.build.review.closing
       gtd(check): refactor.build.review.closing → implement.building
       gtd(agent): implement.building → implement.health.check