@pmelab/gtd 32.1.0 → 34.0.0

package/src/workflows/feature/refactor-review.feature

@@ -3,8 +3,8 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
 
   After a refactor-first judgment the refactor is built, quality-lapped and
   reviewed in its own slice. Review edits re-run the refactor, never the design;
-  the feature review that follows covers only what came after the refactor's
-  sign-off. The flags are pinned so the per-flag test runs never move it off
+  the feature slice that follows is quality-lapped from the refactor's
+  sign-off, with no feature review. The flags are pinned so the per-flag test runs never move it off
   its path.
 
   Background:
@@ -52,6 +52,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
+    And step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
     And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
@@ -136,6 +141,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       - AC-1: the change behaves as described.
       """
     And step "design.gate.answer" changes nothing
+    And step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
     And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
@@ -219,6 +229,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
@@ -322,7 +337,7 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         gtd(agent): refactor.build.review.reviewing → refactor.build.review.await-review
         """
 
-    Scenario: the refactor review says the whole refactor on its second round, the feature's feedback review only what is new
+    Scenario: the refactor review says the whole refactor on its second round
       Given step "refactor.build.review.reviewing" is prompted with "it covers the whole refactor since it started, on every round"
       And step "implement.building" writes "src/calc.ts" with:
         """
@@ -332,17 +347,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -404,79 +408,7 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       Then the process rests at "refactor.build.review.await-review"
       When gtd lands
       And the process is driven
-      Then the process rests at "build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op[^m]
-
-        [^m]:
-            - H: also export multiply
-        """
-      And step "build.review.collecting" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        - multiply
-        """
-      And step "build.review.collecting" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op[^m]
-
-        [^m]:
-            - H: also export multiply
-            - A: noted.
-        """
-      When gtd lands
-      And the process is driven
-      Then the process rests at "build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
-      And step "build.review.closing" runs its script
-      And step "re-unwind" runs its script
-      And step "design.triage" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        - multiply, designed
-
-        ## Acceptance Criteria
-
-        - AC-1: the change behaves as described.
-        """
-      And step "implement.building" writes "src/calc.ts" with:
-        """
-        export const op = (a: number, b: number, sign: number) => a + sign * b
-        export const add = (a: number, b: number) => op(a, b, 1)
-        export const subtract = (a: number, b: number) => op(a, b, -1)
-        export const multiply = (a: number, b: number) => a * b
-        """
-      And step "build.review.reviewing" is prompted with "it covers only what is new since the previous review"
-      When gtd lands
-      And the process is driven
-      Then the process rests at "build.review.await-review"
+      Then the process rests at "idle"
 
     Scenario: a question answered at the refactor review reaches the re-derived package as ### Answered Questions
       When the process is driven
@@ -704,17 +636,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -778,7 +699,8 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       When gtd lands
       And the process is driven
-      Then the process rests at "build.review.await-review"
+      Then the process rests at "idle"
+      And "src/calc.ts" contains "subtract"
 
     Scenario: a praise-only one-shot footnote signs off and the feature slice follows
       Given step "implement.building" writes "src/calc.ts" with:
@@ -789,17 +711,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -822,7 +733,8 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       When gtd lands
       And the process is driven
-      Then the process rests at "build.review.await-review"
+      Then the process rests at "idle"
+      And "src/calc.ts" contains "subtract"
 
     Scenario: a one-shot footnote judged edit that collecting leaves out refuses naming its anchor
       When the process is driven
@@ -1061,17 +973,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -1139,7 +1040,8 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       When gtd lands
       And the process is driven
-      Then the process rests at "build.review.await-review"
+      Then the process rests at "idle"
+      And "src/calc.ts" contains "subtract"
 
     Scenario: a praise-only refactor review still signs off and the feature slice follows
       Given step "implement.building" writes "src/calc.ts" with:
@@ -1150,92 +1052,6 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "implement.health.check" changes nothing
       And step "implement.closing" runs its script
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
-      When the process is driven
-      Then the process rests at "refactor.build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [x] ./src/calc.ts#1-2
-          add built on the shared op
-        """
-      When gtd lands
-      And the process is driven
-      Then the process rests at "build.review.await-review"
-
-    Scenario: the feature review after a refactor covers only the commits since the refactor's sign-off
-      Given step "implement.building" writes "src/calc.ts" with:
-        """
-        export const op = (a: number, b: number, sign: number) => a + sign * b
-        export const add = (a: number, b: number) => op(a, b, 1)
-        export const subtract = (a: number, b: number) => op(a, b, -1)
-        """
-      And step "implement.health.check" changes nothing
-      And step "implement.closing" runs its script
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
-      When the process is driven
-      Then the process rests at "refactor.build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [x] ./src/calc.ts#1-2
-          add built on the shared op
-        """
-      When gtd lands
-      And the process is driven
-      Then the process rests at "build.review.await-review"
-      And the resting step's content contains the hash of the commit "gtd(check): refactor.build.review.closing → implement.building"
-
-    Scenario: feature feedback after a refactor re-plans design and implement, never the seam phase
-      Given step "implement.building" writes "src/calc.ts" with:
-        """
-        export const op = (a: number, b: number, sign: number) => a + sign * b
-        export const add = (a: number, b: number) => op(a, b, 1)
-        export const subtract = (a: number, b: number) => op(a, b, -1)
-        """
-      And step "implement.health.check" changes nothing
-      And step "implement.closing" runs its script
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
       When the process is driven
       Then the process rests at "refactor.build.review.await-review"
       Given a file ".gtd/REVIEW.md" with:
@@ -1251,72 +1067,8 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       When gtd lands
       And the process is driven
-      Then the process rests at "build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op[^why]
-
-        [^why]:
-            - H: also export multiply
-        """
-      And step "build.review.collecting" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Concerns
-
-        ### Multiply
-
-        - Export `multiply()`.
-        """
-      And step "build.review.collecting" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op[^why]
-
-        [^why]:
-            - H: also export multiply
-            - A: noted in the requirements.
-        """
-      When gtd lands
-      And the process is driven
-      Then the process rests at "build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
-      And step "build.review.closing" runs its script
-      And step "re-unwind" runs its script
-      When gtd lands
-      And the process is driven
-      Then the process rests at "implement.building"
-      And the commit subjects end with:
-        """
-        gtd(check): re-unwind → design.triage
-        gtd(agent): design.triage → design.gate.answer
-        gtd(human): design.gate.answer → implement.building
-        gtd(agent): implement.building
-        """
+      Then the process rests at "idle"
+      And "src/calc.ts" contains "subtract"
 
     Scenario: a nit fix in the refactor slice that changes a non-stray is refused, though a glob stray widens the write access
       Given step "seam.naive" writes "src/*.ts" with:
@@ -1426,6 +1178,11 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
@@ -1456,7 +1213,7 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
       And step "refactor.build.review.closing" runs its script
 
-    Scenario: each slice's quality lap reviews from that slice's base, before and after a feature feedback lap
+    Scenario: each slice's quality lap reviews from that slice's base
       When the process is driven
       Then the process rests at "refactor.build.quality.correctness.reviewing"
       And the resting step's content contains the hash of the commit "gtd(judge): seam.judge → refactor.deriving"
@@ -1487,88 +1244,13 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       Then the process rests at "build.quality.correctness.reviewing"
       And the resting step's content contains the hash of the commit "gtd(check): refactor.build.review.closing → implement.building"
       Given step "build.quality.correctness.reviewing" changes nothing
-      And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
       When the process is driven
-      Then the process rests at "build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op[^why]
-
-        [^why]:
-            - H: also export multiply
-        """
-      And step "build.review.collecting" writes ".gtd/REQUIREMENTS.md" with:
-        """
-        # Requirements
-
-        ## Concerns
-
-        ### Multiply
-
-        - Export `multiply()`.
-        """
-      And step "build.review.collecting" writes ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op[^why]
-
-        [^why]:
-            - H: also export multiply
-            - A: noted in the requirements.
-        """
-      When gtd lands
-      And the process is driven
-      Then the process rests at "build.review.await-review"
-      Given a file ".gtd/REVIEW.md" with:
-        """
-        # Review: abc1234
-
-        <!-- base: 0000000 -->
-
-        ## calc
-
-        - [ ] ./src/calc.ts#1-3
-          subtract built on the shared op
-        """
-      And step "build.review.closing" runs its script
-      And step "re-unwind" runs its script
-      And step "build.quality.correctness.reviewing" is no longer scripted
-      And step "implement.building" writes "src/calc.ts" with:
+      Then the process rests at "idle"
+      And the commit subjects end with:
         """
-        export const op = (a: number, b: number, sign: number) => a + sign * b
-        export const add = (a: number, b: number) => op(a, b, 1)
-        export const subtract = (a: number, b: number) => op(a, b, -1)
-        export const multiply = (a: number, b: number) => a * b
+        gtd(check): implement.closing → build.quality.correctness.reviewing
+        gtd(agent): build.quality.correctness.reviewing → idle
         """
-      And step "implement.health.check" changes nothing
-      And step "implement.closing" runs its script
-      When gtd lands
-      And the process is driven
-      Then the process rests at "build.quality.correctness.reviewing"
-      And the resting step's content contains the hash of the commit "gtd(check): refactor.build.review.closing → implement.building"
 
   Rule: a refactor package never carries a test file, and demoted headings stop at ######
 
@@ -1614,7 +1296,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
         """
 
     Scenario: a test-file stray is dropped from the derived refactor package
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
         export const subtract = (a: number, b: number) => a - b
@@ -1631,7 +1318,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       And ".gtd/REFACTOR.md" does not contain "src/calc.test.ts"
 
     Scenario: the refactor updates an existing test's call sites to the seam's new shape
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = ({ a, b }: { a: number; b: number }) => a + b
         export const subtract = ({ a, b }: { a: number; b: number }) => a - b
@@ -1651,7 +1343,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       Then the process rests at "refactor.health.check"
 
     Scenario: the refactor may not drop an assertion from an existing test
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
         export const subtract = (a: number, b: number) => a - b
@@ -1665,7 +1362,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       Then driving the process is refused with "refactor-tests"
 
     Scenario: a refactor-first whose strays are all test files goes straight to implement
-      Given step "seam.naive" writes "src/calc.test.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.test.ts" with:
         """
         import { expect, it } from "vitest"
         it("subtracts", () => expect(3 - 1).toBe(2))
@@ -1675,7 +1377,12 @@ Feature: the refactor slice is reviewed on its own before the feature is impleme
       And ".gtd/REFACTOR.md" does not exist
 
     Scenario: collected review headings re-derive at ### with the deepest capped at ######
-      Given step "seam.naive" writes "src/calc.ts" with:
+      Given step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
+      And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
         export const subtract = (a: number, b: number) => a - b

package/src/workflows/feature/refactor.ts

@@ -42,7 +42,8 @@ export const requireWithin = (allowed: readonly string[]): void => {
 }
 
 // A fixed list, not `seamAllow`: narrowing that setting must not let a test file through.
-const isTestFile = (path: string): boolean => testFileGlobs.some((glob) => matches(path, glob))
+export const isTestFile = (path: string): boolean =>
+  testFileGlobs.some((glob) => matches(path, glob))
 
 // The bundled refactor uses `requireTestCallSitesOnly`; this stays a public export.
 export const requireNoTestFiles = (): void => {
@@ -56,11 +57,11 @@ export const requireNoTestFiles = (): void => {
 }
 
 // Call sites live in code: a `.feature` file or a snapshot holds only expectations.
-const holdsCallSites = (path: string): boolean =>
+export const holdsCallSites = (path: string): boolean =>
   !path.endsWith(".feature") && !path.endsWith(".snap")
 
 // `//` after a `:` (a URL) and `/*` after `*` or `/` (a glob) sit in strings, not comments.
-const COMMENT = /(?<![*/])\/\*[\s\S]*?\*\/|(?<!:)\/\/.*$/gm
+export const COMMENT = /(?<![*/])\/\*[\s\S]*?\*\/|(?<!:)\/\/.*$/gm
 const ASSERTION = /\b(?:expect|assert\w*)\s*[.(]/g
 const TEST_CASE = /(?<![.\w])x?(?:it|test|describe)\s*[.(]/g
 const MODIFIER =

package/src/workflows/feature/risk-tier.feature

@@ -146,6 +146,11 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
 
         - AC-1: the change behaves as described.
         """
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b
@@ -254,6 +259,11 @@ Feature: the risk tier is proposed at triage and recorded behind GTD_FLAG_RISK_T
         - AC-1: the change behaves as described.
         """
       And step "design.gate.answer" changes nothing
+      And step "seam.check" changes nothing
+      And step "seam.naive" writes "src/acceptance.test.ts" with:
+        """
+        it("[AC-1] holds", () => {})
+        """
       And step "seam.naive" writes "src/calc.ts" with:
         """
         export const add = (a: number, b: number) => a + b