@pmelab/gtd 32.1.0 → 34.0.0

package/src/workflows/feature/refactor-absorbs.feature

@@ -1,16 +1,16 @@
 # One SDLC path per file, so a changed path reds exactly one fixture — do not merge.
 @inmem
-Feature: a refactor that carried the whole feature still gets a feature review
+Feature: a refactor that carried the whole feature still gets a quality lap over all of it
 
   With GTD_FLAG_RISK_TIER off, a refactor-first
   refactor can land everything the requirements ask for. The feature slice's
   implement turn then has nothing to author: its empty turn completes the
-  step, and with no code changed since the refactor the feature review covers
-  the whole change, refactor included.
+  step, and with no code changed since the refactor the feature slice's
+  quality lap covers the whole change, refactor included.
 
   Background:
     Given the shipped workflows, as gtd install scaffolds them
-    And an environment variable "GTD_QUALITYREVIEWS" set to ""
+    And an environment variable "GTD_QUALITYREVIEWS" set to "correctness"
     And an environment variable "GTD_REFACTORQUALITYREVIEWS" set to ""
     And an environment variable "GTD_FLAG_RISK_TIER" set to "0"
     And a file "src/calc.ts" with:
@@ -42,8 +42,13 @@ Feature: a refactor that carried the whole feature still gets a feature review
       """
     And step "design.gate.answer" changes nothing
 
-  Scenario: an empty implement turn after a refactor that did it all reaches review and idle
-    Given step "seam.naive" writes "src/calc.ts" with:
+  Scenario: an empty implement turn after a refactor that did it all reaches the quality lap and idle
+    Given step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
+    And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
       export const subtract = (a: number, b: number) => a - b
@@ -89,25 +94,14 @@ Feature: a refactor that carried the whole feature still gets a feature review
     And step "implement.building" changes nothing
     And step "implement.health.check" changes nothing
     And step "implement.closing" runs its script
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-2
-        subtract next to add
-      """
     When gtd lands
     And the process is driven
-    Then the process rests at "build.review.await-review"
+    Then the process rests at "build.quality.correctness.reviewing"
+    And the resting step's content contains the hash of the commit "feat: add calculator"
     And ".gtd/REQUIREMENTS.md" does not exist
 
-    Given step "build.review.closing" runs its script
-    When gtd lands
-    And the process is driven
+    Given step "build.quality.correctness.reviewing" changes nothing
+    When the process is driven
     Then the process rests at "idle"
     And "src/calc.ts" contains "subtract"
     And the commit subjects end with:
@@ -116,10 +110,8 @@ Feature: a refactor that carried the whole feature still gets a feature review
       gtd(check): refactor.build.review.closing → implement.building
       gtd(agent): implement.building → implement.health.check
       gtd(check): implement.health.check → implement.closing
-      gtd(check): implement.closing → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.await-review
-      gtd(human): build.review.await-review → build.review.closing
-      gtd(check): build.review.closing → idle
+      gtd(check): implement.closing → build.quality.correctness.reviewing
+      gtd(agent): build.quality.correctness.reviewing → idle
       """
     And the output lines of gtd "slices" start with:
       """

package/src/workflows/feature/refactor-first.feature

@@ -4,7 +4,7 @@ Feature: a refactor-first judgment walks one fixed path to idle
 
   With GTD_FLAG_RISK_TIER off, a naive pass touching
   an existing non-allowlisted file is ruled refactor-first, is refactored and
-  that refactor reviewed, and only then implemented. The flags are
+  that refactor reviewed, and only then implemented, with no feature review. The flags are
   pinned so the per-flag test runs never move it off its path.
 
   Background:
@@ -42,7 +42,12 @@ Feature: a refactor-first judgment walks one fixed path to idle
     And step "design.gate.answer" changes nothing
 
   Scenario: a refactor-first judgment runs refactor, its review, implement and review to idle
-    Given step "seam.naive" writes "src/calc.ts" with:
+    Given step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
+    And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
       export const subtract = (a: number, b: number) => a - b
@@ -90,18 +95,6 @@ Feature: a refactor-first judgment walks one fixed path to idle
       - [x] ./src/calc.ts#1-2
         add built on the shared op
       """
-    And step "build.review.reviewing" writes ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [ ] ./src/calc.ts#1-3
-        subtract built on the shared op
-      """
-    And step "build.review.closing" runs its script
     When gtd lands
     And the process is driven
     Then the process rests at "implement.building"
@@ -116,21 +109,6 @@ Feature: a refactor-first judgment walks one fixed path to idle
     And step "implement.health.check" changes nothing
     And step "implement.closing" runs its script
     When the process is driven
-    Then the process rests at "build.review.await-review"
-
-    Given a file ".gtd/REVIEW.md" with:
-      """
-      # Review: abc1234
-
-      <!-- base: 0000000 -->
-
-      ## calc
-
-      - [x] ./src/calc.ts#1-3
-        subtract built on the shared op
-      """
-    When gtd lands
-    And the process is driven
     Then the process rests at "idle"
     And "src/calc.ts" contains "op(a, b, 1)"
     And "src/calc.ts" contains "subtract"
@@ -141,7 +119,8 @@ Feature: a refactor-first judgment walks one fixed path to idle
       gtd(check): start-gate.check → design.triage
       gtd(agent): design.triage → design.gate.answer
       gtd(human): design.gate.answer → seam.naive
-      gtd(agent): seam.naive → seam.judge
+      gtd(agent): seam.naive → seam.check
+      gtd(check): seam.check → seam.judge
       gtd(judge): seam.judge → refactor.deriving
       gtd(check): refactor.deriving → refactor.building
       gtd(agent): refactor.building → refactor.health.check
@@ -152,13 +131,10 @@ Feature: a refactor-first judgment walks one fixed path to idle
       gtd(check): refactor.build.review.closing → implement.building
       gtd(agent): implement.building → implement.health.check
       gtd(check): implement.health.check → implement.closing
-      gtd(check): implement.closing → build.review.reviewing
-      gtd(agent): build.review.reviewing → build.review.await-review
-      gtd(human): build.review.await-review → build.review.closing
-      gtd(check): build.review.closing → idle
+      gtd(check): implement.closing → idle
       """
     And the commit "gtd(human): idle → unwind" has a body containing "Gtd-Var: flag_risk_tier=0"
-    And the commit "gtd(agent): seam.naive → seam.judge" has a body containing "Gtd-Kept:"
+    And the commit "gtd(agent): seam.naive → seam.check" has a body containing "Gtd-Kept:"
     And the commit "gtd(judge): seam.judge → refactor.deriving" has a body containing "\"answer\":\"refactor-first\""
     And no commit body contains "Gtd-Approved:"
     And the output lines of gtd "slices" start with:

package/src/workflows/feature/refactor-lens-models.feature

@@ -36,7 +36,12 @@ Feature: the refactor review's lenses take their model hints from refactorQualit
     And step "design.gate.answer" changes nothing
 
   Scenario: a refactor lens runs on its refactorQualityReviews hint, else its default
-    Given step "seam.naive" writes "src/calc.ts" with:
+    Given step "seam.check" changes nothing
+    And step "seam.naive" writes "src/acceptance.test.ts" with:
+      """
+      it("[AC-1] holds", () => {})
+      """
+    And step "seam.naive" writes "src/calc.ts" with:
       """
       export const add = (a: number, b: number) => a + b
       export const subtract = (a: number, b: number) => a - b