@pmelab/gtd 24.4.0 → 26.0.0

package/dist/workflow-kit.mjs

@@ -67,102 +67,59 @@ const fixFindings = async (f) => {
 };
 //#endregion
 //#region src/workflow-kit/scenarios.ts
-const DOC_STRING = /^(\s*)("""|```)/;
-/**
-* Gherkin wording only: lines trimmed; blank, `#` comment and `@` tag lines
-* dropped — except inside a doc string, whose content is test input: kept
-* whole, indented relative to its opening delimiter (as Gherkin reads it).
-*/
-const scenarioText = (source) => {
+const DOC_STRING = /^("""|```)/;
+const THEN = /^Then\s/;
+const CONTINUATION = /^(And|But|\*)\s/;
+const HEADING = /^(Feature|Rule|Background|Scenario|Scenario Outline|Scenario Template|Example):/;
+/** Trimmed lines outside doc strings, whose content is test input, not steps. */
+const stepLines = (source) => {
 	const out = [];
-	let doc;
-	for (const line of source.split("\n")) {
-		const delimiter = DOC_STRING.exec(line);
-		if (doc === void 0 && delimiter !== null) {
-			doc = {
-				indent: delimiter[1].length,
-				fence: delimiter[2]
-			};
-			out.push(line.trim());
-		} else if (doc !== void 0 && line.trim().startsWith(doc.fence)) {
-			doc = void 0;
-			out.push(line.trim());
-		} else if (doc !== void 0) {
-			const lead = line.length - line.trimStart().length;
-			out.push(line.slice(Math.min(lead, doc.indent)).trimEnd());
-		} else {
-			const trimmed = line.trim();
-			if (trimmed !== "" && !trimmed.startsWith("#") && !trimmed.startsWith("@")) out.push(trimmed);
-		}
-	}
-	return out.join("\n");
-};
-const textOf = (path) => {
-	const source = read(path);
-	return source === void 0 ? void 0 : scenarioText(source);
-};
-/** Snapshot `.feature` paths at `head()`, merged over `previous`; `undefined` when nothing is frozen. */
-const freezeScenarios = (paths, previous) => {
-	if (paths.length === 0) return previous;
-	const texts = { ...previous?.texts };
-	for (const path of paths) {
-		const text = textOf(path);
-		if (text !== void 0) texts[path] = text;
+	let fence;
+	for (const trimmed of source.split("\n").map((l) => l.trim())) {
+		const opening = fence === void 0 ? DOC_STRING.exec(trimmed)?.[1] : void 0;
+		if (opening !== void 0) fence = opening;
+		else if (fence === void 0) out.push(trimmed);
+		else if (trimmed.startsWith(fence)) fence = void 0;
 	}
-	return Object.keys(texts).length === 0 ? previous : {
-		at: head(),
-		texts
-	};
-};
-/** Paths whose wording differs from the snapshot (a deleted file counts). */
-const driftedScenarios = (frozen) => Object.entries(frozen.texts).filter(([path, text]) => textOf(path) !== text).map(([path]) => path);
-const lines = (text) => text === void 0 || text === "" ? [] : text.split("\n");
-/** `table[i][j]`: the longest common subsequence of `a[i..]` and `b[j..]`. */
-const lcsTable = (a, b) => {
-	const table = Array.from({ length: a.length + 1 }, () => Array(b.length + 1).fill(0));
-	for (let i = a.length - 1; i >= 0; i--) for (let j = b.length - 1; j >= 0; j--) table[i][j] = a[i] === b[j] ? table[i + 1][j + 1] + 1 : Math.max(table[i + 1][j], table[i][j + 1]);
-	return table;
+	return out;
 };
-/** Changed lines in file order, `- ` / `+ `-prefixed, so a moved or repeated step still shows. */
-const lineDiff = (a, b) => {
-	const table = lcsTable(a, b);
+const neutral = (line) => line === "" || line.startsWith("#") || line.startsWith("|");
+/** Trimmed `Then` step lines, an `And`/`But`/`*` continuing one included; doc strings skipped. */
+const assertionLines = (source) => {
 	const out = [];
-	let i = 0;
-	let j = 0;
-	while (i < a.length && j < b.length) if (a[i] === b[j]) {
-		i++;
-		j++;
-	} else if (table[i + 1][j] >= table[i][j + 1]) out.push(`- ${a[i++]}`);
-	else out.push(`+ ${b[j++]}`);
-	return [
-		...out,
-		...a.slice(i).map((l) => `- ${l}`),
-		...b.slice(j).map((l) => `+ ${l}`)
-	];
+	let inThen = false;
+	let scenario = "";
+	for (const line of stepLines(source)) {
+		if (HEADING.test(line)) scenario = line;
+		if (THEN.test(line)) inThen = true;
+		else if (!CONTINUATION.test(line) && !neutral(line)) inThen = false;
+		if (inThen && !neutral(line)) out.push({
+			scenario,
+			line
+		});
+	}
+	return out;
 };
-const wordingDrift = (frozen, path) => ({
-	path,
-	lines: lineDiff(lines(frozen.texts[path]), lines(textOf(path)))
-});
+const key = (a) => `${a.scenario}\n${a.line}`;
 /**
-* After a turn: rest at `stop` while wording drifted from `frozen`. Whatever
-* still differs after it is accepted and moves the snapshot; what was
-* restored stays frozen as it was.
+* Assertions a `.feature` file that existed before `changes` lost — the one
+* way rewording a scenario can weaken it. Matched within each scenario and
+* counted, so a line moving to another scenario, or one of two identical
+* `Then`s dropped, still shows. A renamed scenario reports all of its own.
 */
-const holdWording = async (frozen, stop) => {
-	if (frozen === void 0) return;
-	const drifted = driftedScenarios(frozen);
-	if (drifted.length === 0) return;
-	await stop(frozen.at, drifted.map((path) => wordingDrift(frozen, path)));
-	const accepted = driftedScenarios(frozen);
-	if (accepted.length === 0) return;
-	for (const path of accepted) {
-		const text = textOf(path);
-		if (text === void 0) delete frozen.texts[path];
-		else frozen.texts[path] = text;
-	}
-	frozen.at = head();
-};
+const removedAssertions = (changes) => changes.filter((c) => c.path.endsWith(".feature") && c.before !== void 0).map((c) => {
+	const left = /* @__PURE__ */ new Map();
+	for (const a of assertionLines(c.after ?? "")) left.set(key(a), (left.get(key(a)) ?? 0) + 1);
+	const lines = assertionLines(c.before ?? "").filter((a) => {
+		const n = left.get(key(a)) ?? 0;
+		left.set(key(a), n - 1);
+		return n <= 0;
+	});
+	return {
+		path: c.path,
+		lines
+	};
+}).filter((r) => r.lines.length > 0);
 //#endregion
 //#region src/workflow-kit/review.ts
 const collect = async (p, capture) => {
@@ -351,4 +308,4 @@ const reviewToHandOff = async (base, p) => {
 	}
 };
 //#endregion
-export { driftedScenarios, escalation, fixFindings, freezeScenarios, gate, healthy, holdWording, lensScopes, lensesOf, qualityLap, review, reviewToHandOff, routeNotes, scenarioText, untilSettled, wordingDrift };
+export { assertionLines, escalation, fixFindings, gate, healthy, lensScopes, lensesOf, qualityLap, removedAssertions, review, reviewToHandOff, routeNotes, untilSettled };

package/dist/workflows/feature.mjs

@@ -1,6 +1,6 @@
 import { answered, changes, changesSince, glob, hasThreadFor, head, human, judge, numeric, read, refuse, removeScript, requireAnswers, requireProgress, requireReplies, requireRevert, requireThreadsClosed, restoreScript, revertScript, run, scope, start, vars } from "../flows.mjs";
-import { freezeScenarios, review as review$1 } from "../workflow-kit.mjs";
-import { $ as startGateBlockedMessage, A as architectureAuthorPrompt, B as designGateAnswerMessage, C as fixCheck, D as reviewing, E as reviewMissing, F as buildReviewCollectingPrompt, G as idleMessage, H as designTriagePrompt, I as buildReviewFixNitsPrompt, J as reviewEditNotesCapture, K as packagesItemBuildingPrompt, L as buildReviewTriageMessage, M as architectureGateAnswerMessage, N as buildReviewAnswerQuestionsPrompt, O as agentWithSkills, P as buildReviewAwaitAfterDeferMessage, Q as reviewerSystem, R as builderSystem, S as coder, T as planner, V as designSystem, Y as reviewEditsCapture, Z as reviewNotesCapture, _ as ARCHITECTURE, b as REVIEW, c as refusePendingHandOff, d as shipped, et as unwindFailedMessage, f as defaults, g as healthy, h as gate, i as skills, j as architectureDecomposePrompt, k as architectSystem, l as tail, n as summary, o as closeReview, p as envDefaults, q as packagesItemFixSuitePrompt, r as access, t as steering, tt as unwindFailure, u as guarded, v as FEEDBACK, w as fixRisks, x as awaitReview, y as REQUIREMENTS, z as deferNotesScript } from "../chunks/reserved-B9pG93Fc.mjs";
+import { review as review$1 } from "../workflow-kit.mjs";
+import { $ as unwindFailedMessage, A as architectureDecomposePrompt, B as designSystem, C as fixRisks, D as agentWithSkills, E as reviewing, F as buildReviewFixNitsPrompt, G as packagesItemBuildingPrompt, I as buildReviewTriageMessage, J as reviewEditsCapture, K as packagesItemFixSuitePrompt, L as builderSystem, M as buildReviewAnswerQuestionsPrompt, N as buildReviewAwaitAfterDeferMessage, O as architectSystem, P as buildReviewCollectingPrompt, Q as startGateBlockedMessage, R as deferNotesScript, S as fixCheck, T as reviewMissing, V as designTriagePrompt, W as idleMessage, X as reviewNotesCapture, Z as reviewerSystem, _ as FEEDBACK, b as awaitReview, c as refusePendingHandOff, d as defaults, et as unwindFailure, f as envDefaults, g as ARCHITECTURE, h as healthy, i as skills, j as architectureGateAnswerMessage, k as architectureAuthorPrompt, l as tail, m as gate, n as summary, o as closeReview, q as reviewEditNotesCapture, r as access, t as steering, u as shipped, v as REQUIREMENTS, w as planner, x as coder, y as REVIEW, z as designGateAnswerMessage } from "../chunks/reserved-6pAgFGgB.mjs";
 //#region src/workflows/feature/steps.ts
 /** Turn the sketch since `base` into `.gtd/REQUIREMENTS.md`. */
 const triage = (base) => agentWithSkills("triage", designTriagePrompt(base), {
@@ -78,8 +78,6 @@ const deferNotes = (notes, round) => run("review.defer", deferNotesScript(notes,
 });
 //#endregion
 //#region src/workflows/feature/packages.ts
-/** Package 0: the e2e scenarios, written red. */
-const SCENARIO_PACKAGE = ".gtd/packages/00-e2e-scenarios.md";
 const TEST_LINE = /^\s*-\s+(unit|e2e):\s+`([^`]+)`/;
 /** The `## Tests` entries of a package file; malformed lines are ignored. */
 const declaredTests = (packageText) => {
@@ -109,47 +107,29 @@ const requireDeclaredTests = (pkg, since) => {
 	if (missing.length === 0) return;
 	refuse(`gtd land: declared-tests: ${pkg} declares tests that are ${satisfied ? "missing from the tree" : "not in the package's diff"} — write them first:\n${missing.map((path) => `  - ${path}`).join("\n")}`);
 };
-/** Build `pkg`, check its declared tests, keep the fast suite green, and close it out, which removes it. */
-const packageItem = async (pkg, frozen) => {
+/**
+* Build `pkg`, check its declared tests, keep the full suite green, and close
+* it out, which removes it — and `.gtd/ARCHITECTURE.md` with the last one.
+*/
+const packageItem = async (pkg) => {
 	const from = head();
 	const declared = (turn) => async () => {
 		await turn();
 		requireDeclaredTests(pkg, from);
 	};
-	await guarded(frozen, declared(() => build(pkg)))();
-	await healthy(guarded(frozen, declared(fixSuite)), { suite: "fast" });
-	await run("closing", removeScript([pkg, ".gtd/SATISFIED.md"]), { label: "Closing out the package" });
-	return {
+	await declared(() => build(pkg))();
+	await healthy(declared(fixSuite));
+	await run("closing", removeScript([
 		pkg,
-		from,
-		to: head()
-	};
+		".gtd/SATISFIED.md",
+		...glob(".gtd/packages/*.md").length === 1 ? [ARCHITECTURE] : []
+	]), { label: "Closing out the package" });
 };
 /** The first queued package — the one a package step works on. */
 const nextPackage = () => [...glob(".gtd/packages/*.md")].sort()[0];
-const outsideGtd = (path) => path !== ".gtd" && !path.startsWith(".gtd/");
 /** Build every package file under `.gtd/packages/`, in name order. */
-const packages = (carried) => scope("packages", async () => {
-	let frozen = carried;
-	const ranges = [];
-	let touched = [];
-	for (let pkg = nextPackage(); pkg !== void 0; pkg = nextPackage()) {
-		const range = await scope("item", () => packageItem(pkg, pkg === ".gtd/packages/00-e2e-scenarios.md" ? void 0 : frozen));
-		ranges.push(range);
-		if (pkg === ".gtd/packages/00-e2e-scenarios.md") {
-			touched = changesSince(range.from).filter((c) => outsideGtd(c.path) && c.status !== "deleted");
-			frozen = freezeScenarios(touched.filter((c) => c.path.endsWith(".feature")).map((c) => c.path), frozen);
-		}
-	}
-	const paths = (status) => touched.filter((c) => c.status === status).map((c) => c.path);
-	return {
-		ranges,
-		scenarios: {
-			added: paths("added"),
-			changed: paths("modified")
-		},
-		frozen
-	};
+const packages = () => scope("packages", async () => {
+	for (let pkg = nextPackage(); pkg !== void 0; pkg = nextPackage()) await scope("item", () => packageItem(pkg));
 });
 //#endregion
 //#region src/workflows/feature/planning.ts
@@ -182,7 +162,7 @@ const architecture = () => scope("architecture", async () => {
 	} while (await noteGate(ARCHITECTURE, answerTechnicalQuestions));
 	await decompose();
 	if (changes(".gtd/packages/**").length === 0) refuse("gtd land: decompose: write at least one package under .gtd/packages/");
-	if (changes(".gtd/ARCHITECTURE.md").some((c) => c.status === "deleted")) refuse("gtd land: decompose: keep .gtd/ARCHITECTURE.md — the build tail's full run needs it; it is removed only once that run is green");
+	if (changes(".gtd/ARCHITECTURE.md").some((c) => c.status === "deleted")) refuse("gtd land: decompose: keep .gtd/ARCHITECTURE.md — the packages are built from it; it is removed with the last package");
 });
 //#endregion
 //#region src/workflows/feature/review.ts
@@ -308,7 +288,7 @@ const isCode = (path) => path !== ".gtd" && !path.startsWith(".gtd/");
 * another planning lap, questions are answered in place, nits fixed in one
 * batch, praise dropped.
 */
-const review = (base, escalations = { rounds: 0 }, frozen) => {
+const review = (base, escalations = { rounds: 0 }) => {
 	const severities = /* @__PURE__ */ new Map();
 	let deferred = [];
 	return review$1(base, {
@@ -319,8 +299,8 @@ const review = (base, escalations = { rounds: 0 }, frozen) => {
 			deferred = [];
 			return reviewing(b, carry);
 		},
-		fixRisks: (risks) => guarded(frozen, () => fixRisks(risks), "review")(),
-		keepGreen: () => healthy(guarded(frozen, fixCheck, "review"), { escalations }),
+		fixRisks,
+		keepGreen: () => healthy(fixCheck, { escalations }),
 		awaitReview: (b) => {
 			const notes = deferred;
 			deferred = [];
@@ -339,7 +319,7 @@ const review = (base, escalations = { rounds: 0 }, frozen) => {
 			return deferNotes(deferred, head());
 		},
 		answerQuestions: answerReviewQuestions,
-		fixNits: (notes) => guarded(frozen, () => fixNits(notes), "review")(),
+		fixNits,
 		close: closeReview,
 		captures: {
 			edits: reviewEditsCapture,
@@ -361,8 +341,8 @@ const review = (base, escalations = { rounds: 0 }, frozen) => {
 		}
 	});
 };
-/** The build tail: fix (when entered red), keep green, the quality lap, then human review since `base`. */
-const buildTail = (fixFirst, base, built) => tail(fixFirst, (escalations, frozen) => review(base, escalations, frozen), built);
+/** The build tail: fix (when entered red), keep green unless `green`, the quality lap, then human review since `base`. */
+const buildTail = (fixFirst, base, green = false) => tail(fixFirst, (escalations) => review(base, escalations), green);
 //#endregion
 //#region src/workflows/feature/feature.ts
 /** Revert the sketch that started the process out of the working tree; its intent survives in history. */
@@ -389,13 +369,11 @@ const reUnwind = async (feedback) => {
 /** Plan, build and review until a review round signs off; feedback re-plans from scratch. */
 const planAndBuild = async (firstBase) => {
 	let base = firstBase;
-	let carried;
 	for (;;) {
 		await design(base);
 		await architecture();
-		const built = await packages(carried);
-		carried = built.frozen;
-		const outcome = await buildTail(false, base, built);
+		await packages();
+		const outcome = await buildTail(false, base, true);
 		if (outcome.verdict === "signoff") return;
 		await reUnwind(outcome);
 		base = outcome.base;
@@ -429,4 +407,4 @@ const feature = shipped(ordinaryStart);
 //#region src/workflows/feature/index.ts
 var feature_default = feature;
 //#endregion
-export { SCENARIO_PACKAGE, access, afterTail, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, build, buildTail, collecting, declaredTests, decompose, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, fixSuite, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, reUnwind, requireDeclaredTests, skills, steering, summary, triage, unwind };
+export { access, afterTail, answerProductQuestions, answerReviewQuestions, answerTechnicalQuestions, architecture, author, build, buildTail, collecting, declaredTests, decompose, feature_default as default, defaults, deferNotes, design, envDefaults, feature, fixNits, fixSuite, nextPackage, ordinaryStart, packageItem, packages, planAndBuild, reUnwind, requireDeclaredTests, skills, steering, summary, triage, unwind };

package/dist/workflows/fix.mjs

@@ -1,6 +1,6 @@
 import { read, refuse, removeScript, run, scope, start } from "../flows.mjs";
 import { d as reviewNotes, f as reviewRisks } from "../chunks/steering-DVILanVf.mjs";
-import { O as agentWithSkills, S as coder, U as finisherSystem, W as fixReviewNotesPrompt, a as REVIEW_ORIG, b as REVIEW, d as shipped, f as defaults, i as skills, m as baseline, n as summary, p as envDefaults, r as access, s as handOffTail, t as steering } from "../chunks/reserved-B9pG93Fc.mjs";
+import { D as agentWithSkills, H as finisherSystem, U as fixReviewNotesPrompt, a as REVIEW_ORIG, d as defaults, f as envDefaults, i as skills, n as summary, p as baseline, r as access, s as handOffTail, t as steering, u as shipped, x as coder, y as REVIEW } from "../chunks/reserved-6pAgFGgB.mjs";
 //#region src/workflows/fix/fix.ts
 /**
 * Fix every note a human left in a handed-off `.gtd/REVIEW.md` and every

package/dist/workflows/review.mjs

@@ -1,5 +1,5 @@
 import { start } from "../flows.mjs";
-import { X as reviewGateBlockedMessage, c as refusePendingHandOff, d as shipped, f as defaults, h as gate, i as skills, n as summary, p as envDefaults, r as access, s as handOffTail, t as steering } from "../chunks/reserved-B9pG93Fc.mjs";
+import { Y as reviewGateBlockedMessage, c as refusePendingHandOff, d as defaults, f as envDefaults, i as skills, m as gate, n as summary, r as access, s as handOffTail, t as steering, u as shipped } from "../chunks/reserved-6pAgFGgB.mjs";
 //#region src/workflows/review/review.ts
 /**
 * Pure review of everything since `reviewBase`: a green gate, the quality