@platformos/platformos-check-common 0.0.6 → 0.0.8

package/src/{AugmentedThemeDocset.spec.ts → AugmentedPlatformOSDocset.spec.ts}

@@ -1,12 +1,12 @@
 import { describe, beforeEach, it, expect } from 'vitest';
-import { AugmentedThemeDocset } from './AugmentedThemeDocset';
-import { ThemeDocset } from './types';
+import { AugmentedPlatformOSDocset } from './AugmentedPlatformOSDocset';
+import { PlatformOSDocset } from './types';
 
-describe('Module: AugmentedThemeDocset', async () => {
-  let themeDocset: ThemeDocset;
+describe('Module: AugmentedPlatformOSDocset', async () => {
+  let platformosDocset: PlatformOSDocset;
 
   beforeEach(async () => {
-    themeDocset = new AugmentedThemeDocset({
+    platformosDocset = new AugmentedPlatformOSDocset({
       graphQL: async () => null,
       filters: async () => [],
       objects: async () => [
@@ -51,25 +51,24 @@ describe('Module: AugmentedThemeDocset', async () => {
       ],
       liquidDrops: async () => [],
       tags: async () => [],
-      systemTranslations: async () => ({}),
     });
   });
 
   describe('filters', async () => {
     it('should return filters with undocumented filters', async () => {
-      const filters = await themeDocset.filters();
+      const filters = await platformosDocset.filters();
 
-      expect(filters).to.have.length.greaterThanOrEqual(30);
+      expect(filters).to.have.length.greaterThanOrEqual(10);
     });
 
     it('should return valid filter entries', async () => {
-      const filters = await themeDocset.filters();
+      const filters = await platformosDocset.filters();
 
       expect(filters).to.deep.include({ name: 'h' });
     });
 
     it('should expand aliases from filter entries', async () => {
-      const docset = new AugmentedThemeDocset({
+      const docset = new AugmentedPlatformOSDocset({
         graphQL: async () => null,
         filters: async () => [
           {
@@ -82,7 +81,6 @@ describe('Module: AugmentedThemeDocset', async () => {
         objects: async () => [],
         liquidDrops: async () => [],
         tags: async () => [],
-        systemTranslations: async () => ({}),
       });
 
       const filters = await docset.filters();
@@ -93,7 +91,7 @@ describe('Module: AugmentedThemeDocset', async () => {
     });
 
     it('should copy all properties from base filter to alias entry', async () => {
-      const docset = new AugmentedThemeDocset({
+      const docset = new AugmentedPlatformOSDocset({
         graphQL: async () => null,
         filters: async () => [
           {
@@ -115,7 +113,6 @@ describe('Module: AugmentedThemeDocset', async () => {
         objects: async () => [],
         liquidDrops: async () => [],
         tags: async () => [],
-        systemTranslations: async () => ({}),
       });
 
       const filters = await docset.filters();
@@ -128,7 +125,7 @@ describe('Module: AugmentedThemeDocset', async () => {
     });
 
     it('should expand multiple aliases for a single filter', async () => {
-      const docset = new AugmentedThemeDocset({
+      const docset = new AugmentedPlatformOSDocset({
         graphQL: async () => null,
         filters: async () => [
           {
@@ -140,7 +137,6 @@ describe('Module: AugmentedThemeDocset', async () => {
         objects: async () => [],
         liquidDrops: async () => [],
         tags: async () => [],
-        systemTranslations: async () => ({}),
       });
 
       const filters = await docset.filters();
@@ -152,7 +148,7 @@ describe('Module: AugmentedThemeDocset', async () => {
     });
 
     it('should not add aliases for filters without aliases', async () => {
-      const docset = new AugmentedThemeDocset({
+      const docset = new AugmentedPlatformOSDocset({
         graphQL: async () => null,
         filters: async () => [
           { name: 'upcase', summary: 'Uppercases a string' },
@@ -161,7 +157,6 @@ describe('Module: AugmentedThemeDocset', async () => {
         objects: async () => [],
         liquidDrops: async () => [],
         tags: async () => [],
-        systemTranslations: async () => ({}),
       });
 
       const filters = await docset.filters();
@@ -169,39 +164,57 @@ describe('Module: AugmentedThemeDocset', async () => {
 
       expect(officialNames).toHaveLength(2);
     });
+
+    it('should normalize filters with deprecated:false but deprecation_reason:"true" to deprecated:true', async () => {
+      const docset = new AugmentedPlatformOSDocset({
+        graphQL: async () => null,
+        filters: async () => [
+          { name: 'asset_path', deprecated: false, deprecation_reason: 'true' },
+          { name: 'sha1', deprecated: false, deprecation_reason: 'true' },
+          { name: 'active_filter', deprecated: false, deprecation_reason: 'false' },
+        ],
+        objects: async () => [],
+        liquidDrops: async () => [],
+        tags: async () => [],
+      });
+
+      const filters = await docset.filters();
+      const assetPath = filters.find((f) => f.name === 'asset_path');
+      const sha1 = filters.find((f) => f.name === 'sha1');
+      const active = filters.find((f) => f.name === 'active_filter');
+
+      expect(assetPath?.deprecated).toBe(true);
+      expect(assetPath?.deprecation_reason).toBeUndefined();
+      expect(sha1?.deprecated).toBe(true);
+      expect(sha1?.deprecation_reason).toBeUndefined();
+      expect(active?.deprecated).toBeFalsy();
+    });
   });
 
   describe('objects', async () => {
-    it('should return objects with undocumented objects', async () => {
-      const objects = await themeDocset.objects();
+    it('should return objects from the official docset', async () => {
+      const objects = await platformosDocset.objects();
 
-      expect(objects).to.have.length.greaterThanOrEqual(15);
+      expect(objects).to.have.length.greaterThanOrEqual(4);
     });
 
     it('should return valid object entries', async () => {
-      const objects = await themeDocset.objects();
+      const objects = await platformosDocset.objects();
 
-      expect(objects).to.deep.include({ name: 'customer_address' });
       expect(objects).to.deep.include({
-        name: 'locale',
+        name: 'test-object',
         access: {
           global: false,
           parents: [],
           template: [],
         },
-        return_type: [
-          {
-            type: 'string',
-            name: '',
-          },
-        ],
       });
     });
   });
 
   describe('liquidDrops', async () => {
     it('should return non-deprecated objects', async () => {
-      const objects = await themeDocset.liquidDrops();
+      const objects = await platformosDocset.liquidDrops();
 
       expect(objects).to.have.lengthOf(2);
       expect(objects).to.deep.include({
@@ -215,7 +228,7 @@ describe('Module: AugmentedThemeDocset', async () => {
     });
 
     it("should return objects that aren't exclusively global", async () => {
-      const objects = await themeDocset.liquidDrops();
+      const objects = await platformosDocset.liquidDrops();
 
       expect(objects).to.have.lengthOf(2);
       expect(objects).to.deep.include({
@@ -236,13 +249,13 @@ describe('Module: AugmentedThemeDocset', async () => {
 
   describe('tags', async () => {
     it('should return tags with undocumented tags', async () => {
-      const tags = await themeDocset.tags();
+      const tags = await platformosDocset.tags();
 
-      expect(tags).have.length.greaterThanOrEqual(4);
+      expect(tags).have.length.greaterThanOrEqual(3);
     });
 
     it('should return valid tag entries', async () => {
-      const tags = await themeDocset.tags();
+      const tags = await platformosDocset.tags();
 
       expect(tags).to.deep.include({ name: 'elsif' });
     });

package/src/AugmentedPlatformOSDocset.ts

@@ -0,0 +1,89 @@
+import { FilterEntry, ObjectEntry, TagEntry, PlatformOSDocset } from './types';
+import { memo } from './utils';
+
+const toFilterEntry = (name: string): FilterEntry => ({ name });
+
+const expandAliases = (entries: FilterEntry[]): FilterEntry[] => {
+  return entries.flatMap((entry) => {
+    const aliases: string[] = (entry as any).aliases ?? [];
+    return aliases.map((alias) => ({ ...entry, name: alias }));
+  });
+};
+
+/**
+ * The platformOS API has a data inconsistency where some deprecated filters
+ * have `deprecated: false` but `deprecation_reason: "true"` (the string).
+ * Normalize these to have `deprecated: true` with no deprecation reason message.
+ */
+const normalizeDeprecation = (entry: FilterEntry): FilterEntry => {
+  if (!entry.deprecated && entry.deprecation_reason === 'true') {
+    return { ...entry, deprecated: true, deprecation_reason: undefined };
+  }
+  return entry;
+};
+
+/**
+ * Filters that are valid in platformOS but not yet in the official docs.
+ */
+const undocumentedFilters = [
+  'debug',
+  'distance_from',
+  'encode_url_component',
+  'excerpt',
+  'format_code',
+  'h',
+  'handle_from',
+  'pad_spaces',
+  'paragraphize',
+  'sentence',
+  'unit',
+  'weight',
+];
+
+const toTagEntry = (name: string): TagEntry => ({ name });
+
+/**
+ * Tags that are valid in platformOS Liquid but not yet in the official docs.
+ */
+const undocumentedTags = ['elsif', 'ifchanged', 'when'];
+
+export class AugmentedPlatformOSDocset implements PlatformOSDocset {
+  constructor(private platformosDocset: PlatformOSDocset) {}
+  graphQL = memo(async (): Promise<string | null> => {
+    return await this.platformosDocset.graphQL();
+  });
+
+  public isAugmented = true;
+
+  filters = memo(async (): Promise<FilterEntry[]> => {
+    const officialFilters = (await this.platformosDocset.filters()).map(normalizeDeprecation);
+    return [
+      ...officialFilters,
+      ...expandAliases(officialFilters),
+      ...undocumentedFilters.map(toFilterEntry),
+    ];
+  });
+
+  objects = memo(async (): Promise<ObjectEntry[]> => {
+    return await this.platformosDocset.objects();
+  });
+
+  liquidDrops = memo(async (): Promise<ObjectEntry[]> => {
+    return (await this.platformosDocset.objects()).filter((obj) => {
+      if (!obj.access) {
+        return true;
+      }
+
+      if (obj.deprecated) {
+        return false;
+      }
+
+      // objects that are accessible outside Global context
+      return !obj.access.global || (obj.access.global && obj.access.parents.length > 0);
+    });
+  });
+
+  tags = memo(async (): Promise<TagEntry[]> => {
+    return [...(await this.platformosDocset.tags()), ...undocumentedTags.map(toTagEntry)];
+  });
+}

package/src/JSONValidator.ts

@@ -11,7 +11,7 @@ export class JSONValidator {
     config: Config,
   ): Promise<JSONValidator | undefined> {
     if (!jsonValidationSet) return;
-    return new JSONValidator(await jsonValidationSet.schemas(config.context));
+    return new JSONValidator(await jsonValidationSet.schemas());
   }
 
   constructor(schemas: SchemaDefinition[]) {

package/src/checks/deprecated-filter/index.spec.ts

@@ -1,274 +1,102 @@
 import { expect, describe, it } from 'vitest';
-import { highlightedOffenses, applySuggestions, runLiquidCheck, applyFix } from '../../test';
+import { highlightedOffenses, runLiquidCheck } from '../../test';
 import { DeprecatedFilter } from './index';
-import { Offense } from '../../types';
+
+const mockDependencies = {
+  platformosDocset: {
+    async graphQL() {
+      return null;
+    },
+    async filters() {
+      return [
+        {
+          name: 'old_filter',
+          deprecated: true,
+          deprecation_reason: '`old_filter` has been replaced by [`new_filter`](/docs/...).',
+        },
+        {
+          name: 'deprecated_no_replacement',
+          deprecated: true,
+        },
+        {
+          name: 'new_filter',
+        },
+        {
+          name: 'active_filter',
+        },
+      ];
+    },
+    async objects() {
+      return [];
+    },
+    async liquidDrops() {
+      return [];
+    },
+    async tags() {
+      return [];
+    },
+  },
+};
 
 describe('Module: DeprecatedFilter', () => {
   it('should report an offense when a deprecated filter is used', async () => {
     const sourceCode = `
-      {{ '#EA5AB9' | hex_to_rgba }}
-      {{ '#EA5AB9' | hex_to_rgba: 0.5 }}
+      {{ value | old_filter }}
+      {{ value | old_filter: 'arg' }}
     `;
 
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
+    const offenses = await runLiquidCheck(
+      DeprecatedFilter,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
     expect(offenses.map((e) => e.message)).toEqual([
-      "Deprecated filter 'hex_to_rgba', consider using 'color_to_rgb'.",
-      "Deprecated filter 'hex_to_rgba', consider using 'color_to_rgb'.",
+      "Deprecated filter 'old_filter', consider using 'new_filter'.",
+      "Deprecated filter 'old_filter', consider using 'new_filter'.",
     ]);
 
     const highlights = highlightedOffenses({ 'file.liquid': sourceCode }, offenses);
-    expect(highlights).toEqual(['| hex_to_rgba', '| hex_to_rgba: 0.5']);
+    expect(highlights).toEqual(['| old_filter', "| old_filter: 'arg'"]);
   });
 
   it('should not report an offense when a non-deprecated filter is used', async () => {
     const sourceCode = `
-      {{ '#EA5AB9' | color_to_rgb }}
-      {{ '#EA5AB9' | color_to_rgb | color_modify: 'alpha', 0.5 }}
+      {{ value | active_filter }}
+      {{ value | new_filter }}
     `;
 
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-
+    const offenses = await runLiquidCheck(
+      DeprecatedFilter,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
     expect(offenses).toHaveLength(0);
   });
 
-  it("should suggest a fix to replace the deprecated 'hex_to_rgba' filter", async () => {
-    const sourceCode = '{{ "#EA5AB9" | hex_to_rgba }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const fixedCode = applyFix(sourceCode, offenses[0]);
-
-    expect(fixedCode).toEqual('{{ "#EA5AB9" | color_to_rgb }}');
+  it('should report a message without replacement when no alternative exists', async () => {
+    const sourceCode = `{{ value | deprecated_no_replacement }}`;
+
+    const offenses = await runLiquidCheck(
+      DeprecatedFilter,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
+    expect(offenses).toHaveLength(1);
+    expect(offenses[0].message).toEqual("Deprecated filter 'deprecated_no_replacement'.");
   });
 
-  it("should suggest a fix to replace the deprecated 'hex_to_rgba' filter when an alpha value is passed", async () => {
-    const sourceCode = '{{ "#EA5AB9" | hex_to_rgba: 0.5 }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const fixedCode = applyFix(sourceCode, offenses[0]);
+  it('should report multiple offenses for multiple deprecated filter usages', async () => {
+    const sourceCode = `{{ a | old_filter }} {{ b | deprecated_no_replacement }}`;
 
-    expect(fixedCode).toEqual(`{{ "#EA5AB9" | color_to_rgb | color_modify: 'alpha', 0.5 }}`);
-  });
-
-  it("should suggest a fix to replace the deprecated 'img_url' filter", async () => {
-    const sourceCode = `
-      {{ product.featured_image | img_url: '200x', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: '200x', scale: 2 }}
-      {{ product.featured_image | img_url: '200x' }}
-      {{ product.featured_image | img_url: '200x300' }}
-      {{ product.featured_image | img_url: 'x300' }}
-      {{ product.featured_image | img_url }}
-      {{ product.featured_image
-        | img_url: '200x'
-      }}
-      {{ product.featured_image
-        | img_url: '200x',
-          format: format
-        | image_tag
-      }}
-      {{product.featured_image | img_url: '200x'}}
-      {{-product.featured_image | img_url: '200x'-}}
-      {% assign url = product.featured_image | img_url: '200x' %}
-      {% assign url =
-        product.featured_image | img_url: '200x'
-      %}
-      {{ product.featured_image | img_url: 'master' }}
-      {{ product.featured_image | img_url: '4000x', scale: 2 }}
-
-      // not supported:
-      {{ product.featured_image | img_url: variable }}
-      {{ product.featured_image | img_url: '200x', scale: variable }}
-    `;
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const fixedCode = fixSourceCode(sourceCode, offenses);
-
-    const expected = `
-      {{ product.featured_image | image_url: width: 400, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 400 }}
-      {{ product.featured_image | image_url: width: 200 }}
-      {{ product.featured_image | image_url: width: 200, height: 300 }}
-      {{ product.featured_image | image_url: height: 300 }}
-      {{ product.featured_image | image_url: width: 100, height: 100 }}
-      {{ product.featured_image
-        | image_url: width: 200
-      }}
-      {{ product.featured_image
-        | image_url: width: 200, format: format
-        | image_tag
-      }}
-      {{product.featured_image | image_url: width: 200}}
-      {{-product.featured_image | image_url: width: 200-}}
-      {% assign url = product.featured_image | image_url: width: 200 %}
-      {% assign url =
-        product.featured_image | image_url: width: 200
-      %}
-      {{ product.featured_image | image_url: width: 100 }}
-      {{ product.featured_image | image_url: width: 5760 }}
-
-      // not supported:
-      {{ product.featured_image | img_url: variable }}
-      {{ product.featured_image | img_url: '200x', scale: variable }}
-    `;
-
-    expect(fixedCode).toEqual(expected);
-  });
-
-  it("should suggest a fix to replace the deprecated 'img_url' filter with named sizes", async () => {
-    const sourceCode = `
-      {{ product.featured_image | img_url: 'pico', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'pico' }}
-
-      {{ product.featured_image | img_url: 'icon', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'icon' }}
-
-      {{ product.featured_image | img_url: 'thumb', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'thumb' }}
-
-      {{ product.featured_image | img_url: 'small', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'small' }}
-
-      {{ product.featured_image | img_url: 'compact', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'compact' }}
-
-      {{ product.featured_image | img_url: 'medium', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'medium' }}
-
-      {{ product.featured_image | img_url: 'large', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'large' }}
-
-      {{ product.featured_image | img_url: 'grande', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'grande' }}
-
-      {{ product.featured_image | img_url: 'original', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'original' }}
-
-      {{ product.featured_image | img_url: 'master', scale: 2, crop: 'center' }}
-      {{ product.featured_image | img_url: 'master' }}
-    `;
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const fixedCode = fixSourceCode(sourceCode, offenses);
-
-    const expected = `
-      {{ product.featured_image | image_url: width: 32, height: 32, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 16, height: 16 }}
-
-      {{ product.featured_image | image_url: width: 64, height: 64, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 32, height: 32 }}
-
-      {{ product.featured_image | image_url: width: 100, height: 100, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 50, height: 50 }}
-
-      {{ product.featured_image | image_url: width: 200, height: 200, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 100, height: 100 }}
-
-      {{ product.featured_image | image_url: width: 320, height: 320, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 160, height: 160 }}
-
-      {{ product.featured_image | image_url: width: 480, height: 480, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 240, height: 240 }}
-
-      {{ product.featured_image | image_url: width: 960, height: 960, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 480, height: 480 }}
-
-      {{ product.featured_image | image_url: width: 1200, height: 1200, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 600, height: 600 }}
-
-      {{ product.featured_image | image_url: width: 2048, height: 2048, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 1024, height: 1024 }}
-
-      {{ product.featured_image | image_url: width: 100, crop: 'center' }}
-      {{ product.featured_image | image_url: width: 100 }}
-    `;
-
-    expect(fixedCode).toEqual(expected);
-  });
-
-  it("should suggest a fix to replace the deprecated 'article_img_url' filter", async () => {
-    const sourceCode = '{{ article.image | article_img_url }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const suggestions = applySuggestions(sourceCode, offenses[0]);
-
-    expect(suggestions).toEqual(['{{ article.image | image_url: width: 100, height: 100 }}']);
-  });
-
-  it("should suggest a fix to replace the deprecated 'article_img_url' filter with named sizes", async () => {
-    const sourceCode = '{{ article.image | article_img_url: "grande" }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const suggestions = applySuggestions(sourceCode, offenses[0]);
-
-    expect(suggestions).toEqual(['{{ article.image | image_url: width: 600, height: 600 }}']);
-  });
-
-  it("should suggest a fix to replace the deprecated 'collection_img_url' filter", async () => {
-    const sourceCode = '{{ collection.image | collection_img_url }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const suggestions = applySuggestions(sourceCode, offenses[0]);
-
-    expect(suggestions).toEqual(['{{ collection.image | image_url: width: 100, height: 100 }}']);
-  });
-
-  it("should suggest a fix to replace the deprecated 'collection_img_url' filter with named sizes", async () => {
-    const sourceCode = '{{ collection.image | collection_img_url: "grande" }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const suggestions = applySuggestions(sourceCode, offenses[0]);
-
-    expect(suggestions).toEqual(['{{ collection.image | image_url: width: 600, height: 600 }}']);
-  });
-
-  it("should suggest a fix to replace the deprecated 'product_img_url' filter", async () => {
-    const sourceCode = '{{ p.featured_image | product_img_url }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const suggestions = applySuggestions(sourceCode, offenses[0]);
-
-    expect(suggestions).toEqual(['{{ p.featured_image | image_url: width: 100, height: 100 }}']);
-  });
-
-  it("should suggest a fix to replace the deprecated 'product_img_url' filter with named sizes", async () => {
-    const sourceCode = '{{ p.featured_image | product_img_url: "grande" }}';
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const suggestions = applySuggestions(sourceCode, offenses[0]);
-
-    expect(suggestions).toEqual(['{{ p.featured_image | image_url: width: 600, height: 600 }}']);
-  });
-
-  it("should suggest a fix to replace the deprecated 'img_tag' filter", async () => {
-    const sourceCode = `
-      {{ product | img_tag }}
-      {{ product | img_tag: 'image alt text' }}
-      {{ product | img_tag: 'image alt text', 'my-css-class' }}
-      {{ product | img_tag: 'image alt text', 'my-css-class', '200x300' }}
-      {{ product | img_tag: 'image alt text', 'my-css-class', 'grande' }}
-    `;
-
-    const offenses = await runLiquidCheck(DeprecatedFilter, sourceCode);
-    const fixedCode = fixSourceCode(sourceCode, offenses);
-
-    const expected = `
-      {{ product | image_url: width: 100 | image_tag }}
-      {{ product | image_url: width: 100 | image_tag: alt: 'image alt text' }}
-      {{ product | image_url: width: 100 | image_tag: alt: 'image alt text', class: 'my-css-class' }}
-      {{ product | image_url: width: 200, height: 300 | image_tag: width: 200, height: 300, alt: 'image alt text', class: 'my-css-class' }}
-      {{ product | image_url: width: 600, height: 600 | image_tag: width: 600, height: 600, alt: 'image alt text', class: 'my-css-class' }}
-    `;
-
-    expect(fixedCode).toEqual(expected);
+    const offenses = await runLiquidCheck(
+      DeprecatedFilter,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
+    expect(offenses).toHaveLength(2);
   });
 });
-
-function fixSourceCode(source: string, offenses: Offense[]) {
-  offenses
-    .reverse()
-    .filter((offense) => offense.suggest)
-    .forEach((offense) => {
-      source = applySuggestions(source, offense)?.join('') || source;
-    });
-
-  return source;
-}