@platformos/platformos-check-common 0.0.6 → 0.0.8

package/src/checks/deprecated-filter/index.ts

@@ -1,13 +1,5 @@
 import { LiquidFilter } from '@platformos/liquid-html-parser';
-import {
-  Severity,
-  SourceCodeType,
-  LiquidCheckDefinition,
-  LiquidHtmlSuggestion,
-  FilterEntry,
-  Fixer,
-} from '../../types';
-import { fixHexToRgba, suggestImageUrlFix, suggestImgTagFix, suggestImgUrlFix } from './fixes';
+import { Severity, SourceCodeType, LiquidCheckDefinition, FilterEntry } from '../../types';
 
 export const DeprecatedFilter: LiquidCheckDefinition = {
   meta: {
@@ -15,8 +7,8 @@ export const DeprecatedFilter: LiquidCheckDefinition = {
     aliases: ['DeprecatedFilters'],
     name: 'Deprecated Filter',
     docs: {
-      description: 'Discourages using deprecated filters in themes.',
-      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/deprecated-filter',
+      description: 'Discourages using deprecated filters.',
+      url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/deprecated-filter',
       recommended: true,
     },
     type: SourceCodeType.LiquidHtml,
@@ -26,13 +18,13 @@ export const DeprecatedFilter: LiquidCheckDefinition = {
   },
 
   create(context) {
-    if (!context.themeDocset) {
+    if (!context.platformosDocset) {
       return {};
     }
 
     return {
       LiquidFilter: async (node: LiquidFilter) => {
-        const filters = await context.themeDocset!.filters();
+        const filters = await context.platformosDocset!.filters();
 
         const deprecatedFilter = filters.find((f) => {
           return f.deprecated && f.name === node.name;
@@ -46,13 +38,9 @@ export const DeprecatedFilter: LiquidCheckDefinition = {
         const recommendedFilter = filters.find((f) => f.name === recommendedFilterName);
 
         const message = deprecatedFilterMessage(deprecatedFilter, recommendedFilter);
-        const suggest = deprecatedFilterSuggestion(node);
-        const fix = deprecatedFilterFix(node);
 
         context.report({
           message,
-          suggest,
-          fix,
           startIndex: node.position.start + 1,
           endIndex: node.position.end,
         });
@@ -61,42 +49,6 @@ export const DeprecatedFilter: LiquidCheckDefinition = {
   },
 };
 
-function deprecatedFilterSuggestion(node: LiquidFilter): LiquidHtmlSuggestion[] | undefined {
-  const filter = node.name;
-
-  switch (filter) {
-    case 'img_tag':
-      return suggestImgTagFix(node);
-    case 'img_url':
-      return suggestImgUrlFix(node);
-    case 'article_img_url':
-    case 'collection_img_url':
-    case 'product_img_url':
-      /**
-       * These filters rely on the usage of the `image_url`
-       * filter as the fix.
-       */
-      return suggestImageUrlFix(filter, node);
-    case 'currency_selector':
-      /**
-       * Cannot be fixed.
-       *
-       * Deprecated without a direct replacement because the
-       * currency form has also been deprecated. The currency
-       * form was replaced by the localization form.
-       */
-      return;
-  }
-}
-
-function deprecatedFilterFix(node: LiquidFilter): Fixer<SourceCodeType.LiquidHtml> | undefined {
-  const filter = node.name;
-
-  if (filter === 'hex_to_rgba') {
-    return fixHexToRgba(node);
-  }
-}
-
 function deprecatedFilterMessage(deprecated: FilterEntry, recommended?: FilterEntry) {
   if (recommended) {
     return `Deprecated filter '${deprecated.name}', consider using '${recommended.name}'.`;

package/src/checks/deprecated-tag/index.spec.ts

@@ -2,66 +2,117 @@ import { expect, describe, it } from 'vitest';
 import { highlightedOffenses, runLiquidCheck } from '../../test';
 import { DeprecatedTag } from './index';
 
-describe.skip('Module: DeprecatedTag', () => {
-  it('should report an offense when include tag is used', async () => {
-    const sourceCode = `
-      {% include 'templates/foo.liquid' %}
-    `;
-    const offenses = await runLiquidCheck(DeprecatedTag, sourceCode);
+const mockDependencies = {
+  platformosDocset: {
+    async graphQL() {
+      return null;
+    },
+    async filters() {
+      return [];
+    },
+    async objects() {
+      return [];
+    },
+    async liquidDrops() {
+      return [];
+    },
+    async tags() {
+      return [
+        {
+          name: 'include',
+          deprecated: true,
+          deprecation_reason: "Use the 'render' tag instead.",
+        },
+        {
+          name: 'deprecated_no_reason',
+          deprecated: true,
+        },
+        {
+          name: 'render',
+        },
+      ];
+    },
+  },
+};
+
+describe('Module: DeprecatedTag', () => {
+  it('should report an offense when a deprecated tag is used', async () => {
+    const sourceCode = `{% include 'templates/foo.liquid' %}`;
+
+    const offenses = await runLiquidCheck(
+      DeprecatedTag,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
 
     expect(offenses).toHaveLength(1);
-    expect(offenses[0].message).toEqual(`Use the 'render' tag instead of 'include'`);
+    expect(offenses[0].message).toEqual(`Deprecated tag 'include': Use the 'render' tag instead.`);
 
     const highlights = highlightedOffenses({ 'file.liquid': sourceCode }, offenses);
     expect(highlights).toEqual(['include']);
   });
 
-  it('should not report an offense when render tag is used', async () => {
-    const sourceCode = `
-      {% render 'templates/foo.liquid' %}
-    `;
-    const offenses = await runLiquidCheck(DeprecatedTag, sourceCode);
+  it('should not report an offense when a non-deprecated tag is used', async () => {
+    const sourceCode = `{% render 'templates/foo.liquid' %}`;
+
+    const offenses = await runLiquidCheck(
+      DeprecatedTag,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
 
     expect(offenses).toHaveLength(0);
+  });
 
-    const highlights = highlightedOffenses({ 'file.liquid': sourceCode }, offenses);
-    expect(highlights).toHaveLength(0);
+  it('should report a generic message when no deprecation_reason is provided', async () => {
+    const sourceCode = `{% deprecated_no_reason %}`;
+
+    const offenses = await runLiquidCheck(
+      DeprecatedTag,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
+
+    expect(offenses).toHaveLength(1);
+    expect(offenses[0].message).toEqual(`Deprecated tag 'deprecated_no_reason'.`);
   });
 
-  it('should suggest replacing include tag with render tag', async () => {
+  it('should report multiple offenses when multiple deprecated tags are used', async () => {
     const sourceCode = `
       {% include 'foo.liquid' %}
       {% assign greeting = "hello world" %}
       {% include 'greeting.liquid' %}
     `;
-    const offenses = await runLiquidCheck(DeprecatedTag, sourceCode);
 
-    expect(offenses).toHaveLength(2);
-    if (!offenses[0].suggest || !offenses[1].suggest) return;
+    const offenses = await runLiquidCheck(
+      DeprecatedTag,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
 
-    expect(offenses[0].suggest[0].message).toEqual(`Replace 'include' with 'render'`);
-    expect(offenses[1].suggest[0].message).toEqual(`Replace 'include' with 'render'`);
+    expect(offenses).toHaveLength(2);
+    expect(offenses[0].message).toEqual(`Deprecated tag 'include': Use the 'render' tag instead.`);
+    expect(offenses[1].message).toEqual(`Deprecated tag 'include': Use the 'render' tag instead.`);
 
     const highlights = highlightedOffenses({ 'file.liquid': sourceCode }, offenses);
-    expect(highlights).toHaveLength(2);
-    expect(highlights[0]).toBe('include');
-    expect(highlights[1]).toBe('include');
+    expect(highlights).toEqual(['include', 'include']);
   });
 
-  it('should report multiple offenses when multiple include tags are used in the same line', async () => {
-    const sourceCode = "{% include 'foo.liquid' %} Some text {% include 'bar.liquid' %}";
-    const offenses = await runLiquidCheck(DeprecatedTag, sourceCode);
+  it('should highlight only the tag name', async () => {
+    const sourceCode = `{% include 'foo.liquid' %}`;
 
-    expect(offenses).toHaveLength(2);
-  });
-
-  it('should report offenses when include tags are nested', async () => {
-    const sourceCode = "{% if true %} {% include 'foo.liquid' %} {% endif %}";
-    const offenses = await runLiquidCheck(DeprecatedTag, sourceCode);
+    const offenses = await runLiquidCheck(
+      DeprecatedTag,
+      sourceCode,
+      'file.liquid',
+      mockDependencies,
+    );
 
     expect(offenses).toHaveLength(1);
-    expect(offenses[0].message).toEqual(`Use the 'render' tag instead of 'include'`);
-
     const highlights = highlightedOffenses({ 'file.liquid': sourceCode }, offenses);
     expect(highlights).toEqual(['include']);
   });

package/src/checks/deprecated-tag/index.ts

@@ -7,7 +7,7 @@ export const DeprecatedTag: LiquidCheckDefinition = {
     name: 'Deprecated Tag',
     docs: {
       description: 'This check is aimed at eliminating the use of deprecated tags.',
-      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/deprecated-tag',
+      url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/deprecated-tag',
       recommended: true,
     },
     type: SourceCodeType.LiquidHtml,
@@ -17,29 +17,34 @@ export const DeprecatedTag: LiquidCheckDefinition = {
   },
 
   create(context) {
+    if (!context.platformosDocset) {
+      return {};
+    }
+
     return {
       async LiquidTag(node) {
-        // commenting this out to stop include from getting flagged
-        // if (node.name === 'include') {
-        //   const start = node.source.substring(node.position.start);
-        //   const includeStartIndex = start.indexOf('include');
-        //   const includeEndIndex = includeStartIndex + 'include'.length;
-        //   const includeStart = node.position.start + includeStartIndex;
-        //   const includeEnd = node.position.start + includeEndIndex;
-        //   context.report({
-        //     message: `Use the 'render' tag instead of 'include'`,
-        //     startIndex: includeStart,
-        //     endIndex: includeEnd,
-        //     suggest: [
-        //       {
-        //         message: `Replace 'include' with 'render'`,
-        //         fix: (corrector) => {
-        //           corrector.replace(includeStart, includeEnd, 'render');
-        //         },
-        //       },
-        //     ],
-        //   });
-        // }
+        const tags = await context.platformosDocset!.tags();
+
+        const deprecatedTag = tags.find((t) => t.deprecated && t.name === node.name);
+
+        if (!deprecatedTag) {
+          return;
+        }
+
+        const source = node.source.substring(node.position.start);
+        const tagNameIndex = source.indexOf(node.name);
+        const startIndex = node.position.start + tagNameIndex;
+        const endIndex = startIndex + node.name.length;
+
+        const message = deprecatedTag.deprecation_reason
+          ? `Deprecated tag '${node.name}': ${deprecatedTag.deprecation_reason}`
+          : `Deprecated tag '${node.name}'.`;
+
+        context.report({
+          message,
+          startIndex,
+          endIndex,
+        });
       },
     };
   },

package/src/checks/duplicate-function-arguments/index.ts

@@ -11,7 +11,7 @@ export const DuplicateFunctionArguments: LiquidCheckDefinition = {
       description:
         'This check ensures that no duplicate argument names are provided when invoking partial as a function.',
       recommended: true,
-      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/duplicate-function-arguments',
+      url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/duplicate-function-arguments',
     },
     type: SourceCodeType.LiquidHtml,
     severity: Severity.WARNING,

package/src/checks/duplicate-render-partial-arguments/index.ts

@@ -11,7 +11,7 @@ export const DuplicateRenderPartialArguments: LiquidCheckDefinition = {
       description:
         'This check ensures that no duplicate argument names are provided when rendering a partial.',
       recommended: true,
-      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/duplicate-render-partial-arguments',
+      url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/duplicate-render-partial-arguments',
     },
     type: SourceCodeType.LiquidHtml,
     severity: Severity.WARNING,

package/src/checks/graphql/index.ts

@@ -35,7 +35,7 @@ export const GraphQLCheck: GraphQLCheckDefinition = {
 
   create(context) {
     const validateContent = async (content: string) => {
-      const graphQLSchemaString = await context.themeDocset?.graphQL();
+      const graphQLSchemaString = await context.platformosDocset?.graphQL();
       if (!graphQLSchemaString) {
         return;
       }

package/src/checks/img-width-and-height/index.ts

@@ -9,7 +9,7 @@ export const ImgWidthAndHeight: LiquidCheckDefinition = {
       description:
         'This check is aimed at eliminating content layout shift in themes by enforcing the use of the width and height attributes on img tags.',
       recommended: true,
-      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/img-width-and-height',
+      url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/img-width-and-height',
     },
     type: SourceCodeType.LiquidHtml,
     severity: Severity.ERROR,

package/src/checks/index.ts

@@ -3,140 +3,71 @@ import {
   GraphQLCheckDefinition,
   JSONCheckDefinition,
   LiquidCheckDefinition,
+  YAMLCheckDefinition,
 } from '../types';
 
-import { AppBlockValidTags } from './app-block-valid-tags';
-import { AssetPreload } from './asset-preload';
-import { AssetSizeAppBlockCSS } from './asset-size-app-block-css';
-import { AssetSizeAppBlockJavaScript } from './asset-size-app-block-javascript';
-import { AssetSizeCSS } from './asset-size-css';
-import { AssetSizeJavaScript } from './asset-size-javascript';
-import { BlockIdUsage } from './block-id-usage';
-import { CdnPreconnect } from './cdn-preconnect';
-import { ContentForHeaderModification } from './content-for-header-modification';
-import { DeprecateBgsizes } from './deprecate-bgsizes';
-import { DeprecateLazysizes } from './deprecate-lazysizes';
 import { DeprecatedFilter } from './deprecated-filter';
-import { DeprecatedFontsOnSectionsAndBlocks } from './deprecated-fonts-on-sections-and-blocks';
-import { DeprecatedFontsOnSettingsSchema } from './deprecated-fonts-on-settings-schema';
 import { DeprecatedTag } from './deprecated-tag';
 import { DuplicateRenderPartialArguments } from './duplicate-render-partial-arguments';
-import { DuplicateContentForArguments } from './duplicate-content-for-arguments';
-import { EmptyBlockContent } from './empty-block-content';
-import { HardcodedRoutes } from './hardcoded-routes';
 import { ImgWidthAndHeight } from './img-width-and-height';
-import { JSONMissingBlock } from './json-missing-block';
 import { JSONSyntaxError } from './json-syntax-error';
-import { LiquidFreeSettings } from './liquid-free-settings';
 import { LiquidHTMLSyntaxError } from './liquid-html-syntax-error';
 import { MatchingTranslations } from './matching-translations';
 import { MissingAsset } from './missing-asset';
-import { MissingContentForArguments } from './missing-content-for-arguments';
-import { MissingTemplate } from './missing-template';
+import { MissingPartial } from './missing-partial';
 import { OrphanedPartial } from './orphaned-partial';
-import { PaginationSize } from './pagination-size';
 import { ParserBlockingScript } from './parser-blocking-script';
-import { SchemaPresetsBlockOrder } from './schema-presets-block-order';
-import { SchemaPresetsStaticBlocks } from './schema-presets-static-blocks';
-import { RemoteAsset } from './remote-asset';
-import { ReservedDocParamNames } from './reserved-doc-param-names';
-import { StaticStylesheetAndJavascriptTags } from './static-stylesheet-and-javascript-tags';
 import { TranslationKeyExists } from './translation-key-exists';
 import { UnclosedHTMLElement } from './unclosed-html-element';
 import { UndefinedObject } from './undefined-object';
 import { UniqueDocParamNames } from './unique-doc-param-names';
-import { UniqueStaticBlockId } from './unique-static-block-id';
 import { UnknownFilter } from './unknown-filter';
-import { UnrecognizedContentForArguments } from './unrecognized-content-for-arguments';
 import { UnrecognizedRenderPartialArguments } from './unrecognized-render-partial-arguments';
 import { UnusedAssign } from './unused-assign';
 import { UnusedDocParam } from './unused-doc-param';
-import { ValidContentForArguments } from './valid-content-for-arguments';
-import { ValidContentForArgumentTypes } from './valid-content-for-argument-types';
-import { ValidBlockTarget } from './valid-block-target';
 import { ValidHTMLTranslation } from './valid-html-translation';
 import { ValidJSON } from './valid-json';
 import { ValidDocParamTypes } from './valid-doc-param-types';
-import { ValidLocalBlocks } from './valid-local-blocks';
 import { ValidRenderPartialArgumentTypes } from './valid-render-partial-argument-types';
-import { ValidSchema } from './valid-schema';
-import { ValidSchemaName } from './valid-schema-name';
-import { ValidSettingsKey } from './valid-settings-key';
-import { ValidStaticBlockType } from './valid-static-block-type';
-import { ValidVisibleIf, ValidVisibleIfSettingsSchema } from './valid-visible-if';
 import { VariableName } from './variable-name';
-import { AppBlockMissingSchema } from './app-block-missing-schema';
-import { UniqueSettingIds } from './unique-settings-id';
 import { MetadataParamsCheck } from './metadata-params';
 import { GraphQLVariablesCheck } from './graphql-variables';
 import { GraphQLCheck } from './graphql';
 import { UnknownProperty } from './unknown-property';
 import { InvalidHashAssignTarget } from './invalid-hash-assign-target';
+import { DuplicateFunctionArguments } from './duplicate-function-arguments';
 
-export const allChecks: (LiquidCheckDefinition | JSONCheckDefinition | GraphQLCheckDefinition)[] = [
-  AppBlockValidTags,
-  AssetPreload,
-  AssetSizeAppBlockCSS,
-  AssetSizeAppBlockJavaScript,
-  AssetSizeCSS,
-  AssetSizeJavaScript,
-  BlockIdUsage,
-  CdnPreconnect,
-  ContentForHeaderModification,
-  DeprecateBgsizes,
-  DeprecateLazysizes,
+export const allChecks: (
+  | LiquidCheckDefinition
+  | JSONCheckDefinition
+  | GraphQLCheckDefinition
+  | YAMLCheckDefinition
+)[] = [
   DeprecatedFilter,
-  DeprecatedFontsOnSectionsAndBlocks,
-  DeprecatedFontsOnSettingsSchema,
   DeprecatedTag,
-  DuplicateContentForArguments,
+  DuplicateFunctionArguments,
   DuplicateRenderPartialArguments,
-  EmptyBlockContent,
-  HardcodedRoutes,
   ImgWidthAndHeight,
-  JSONMissingBlock,
   JSONSyntaxError,
-  LiquidFreeSettings,
   LiquidHTMLSyntaxError,
   MatchingTranslations,
   MissingAsset,
-  MissingContentForArguments,
-  MissingTemplate,
-  AppBlockMissingSchema,
+  MissingPartial,
   OrphanedPartial,
-  PaginationSize,
   ParserBlockingScript,
-  SchemaPresetsBlockOrder,
-  SchemaPresetsStaticBlocks,
-  RemoteAsset,
-  ReservedDocParamNames,
-  StaticStylesheetAndJavascriptTags,
   TranslationKeyExists,
   UnclosedHTMLElement,
   UndefinedObject,
   UniqueDocParamNames,
-  UniqueSettingIds,
-  UniqueStaticBlockId,
   UnknownFilter,
-  UnrecognizedContentForArguments,
   UnrecognizedRenderPartialArguments,
   UnusedAssign,
   UnusedDocParam,
-  ValidBlockTarget,
   ValidHTMLTranslation,
-  ValidContentForArguments,
-  ValidContentForArgumentTypes,
   ValidJSON,
   ValidDocParamTypes,
-  ValidLocalBlocks,
   ValidRenderPartialArgumentTypes,
-  ValidSchema,
-  ValidSettingsKey,
-  ValidStaticBlockType,
-  ValidVisibleIf,
-  ValidVisibleIfSettingsSchema,
   VariableName,
-  ValidSchemaName,
   MetadataParamsCheck,
   GraphQLVariablesCheck,
   GraphQLCheck,

package/src/checks/invalid-hash-assign-target/index.spec.ts

@@ -1,10 +1,10 @@
 import { describe, it, expect } from 'vitest';
 import { InvalidHashAssignTarget } from './index';
-import { check, MockTheme } from '../../test';
+import { check, MockApp } from '../../test';
 
 describe('Module: InvalidHashAssignTarget', () => {
   it('should report an error when hash_assign is used on a number', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% assign x = 10 %}
         {% hash_assign x['key'] = 'value' %}
@@ -18,7 +18,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should report an error when hash_assign is used on a string', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% assign x = 'hello' %}
         {% hash_assign x['key'] = 'value' %}
@@ -31,7 +31,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should report an error when hash_assign is used on a boolean', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% assign x = true %}
         {% hash_assign x['key'] = 'value' %}
@@ -44,7 +44,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should report an error when hash_assign is used on an array (range)', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% assign x = (1..5) %}
         {% hash_assign x['key'] = 'value' %}
@@ -57,7 +57,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should not report an error when hash_assign is used on an object from parse_json', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% assign x = '{}' | parse_json %}
         {% hash_assign x['key'] = 'value' %}
@@ -69,7 +69,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should not report an error when hash_assign is used on an object from parse_json tag', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% parse_json x %}
           {}
@@ -83,7 +83,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should not report an error when hash_assign is used on an object from graphql', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% graphql result %}
           query { user { id } }
@@ -97,7 +97,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should not report an error when hash_assign is used on an untyped variable', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% hash_assign unknown_var['key'] = 'value' %}
       `,
@@ -108,7 +108,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should not report an error when hash_assign is used on a function return', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% function data = 'lib/get_data' %}
         {% hash_assign data['extra'] = 'value' %}
@@ -120,7 +120,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should track reassignment and report error on new type', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% assign x = '{}' | parse_json %}
         {% hash_assign x['key1'] = 'value1' %}
@@ -135,7 +135,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should handle increment/decrement as numbers', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% increment counter %}
         {% hash_assign counter['key'] = 'value' %}
@@ -148,7 +148,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should handle capture as string', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% capture x %}hello{% endcapture %}
         {% hash_assign x['key'] = 'value' %}
@@ -161,7 +161,7 @@ describe('Module: InvalidHashAssignTarget', () => {
   });
 
   it('should allow multiple hash_assign on same object', async () => {
-    const theme: MockTheme = {
+    const theme: MockApp = {
       'file.liquid': `
         {% assign x = '{}' | parse_json %}
         {% hash_assign x['key1'] = 'value1' %}

package/src/checks/json-syntax-error/index.ts

@@ -15,7 +15,7 @@ export const JSONSyntaxError: JSONCheckDefinition = {
     docs: {
       description: 'This check exists to prevent invalid JSON files in themes.',
       recommended: true,
-      url: 'https://shopify.dev/docs/storefronts/themes/tools/theme-check/checks/json-syntax-error',
+      url: 'https://documentation.platformos.com/developer-guide/platformos-check/checks/json-syntax-error',
     },
     type: SourceCodeType.JSON,
     severity: Severity.ERROR,

package/src/checks/liquid-html-syntax-error/checks/InvalidBooleanExpression.spec.ts

@@ -12,17 +12,6 @@ describe('detectTrailingAssignValue', async () => {
     }
   });
 
-  it('should not report when the boolean expression is in a schema tag', async () => {
-    const sourceCode = `{% schema %}
-      {
-        "visible_if": "{{ this > that }}"
-      }
-    {% endschema %}`;
-
-    const offenses = await runLiquidCheck(LiquidHTMLSyntaxError, sourceCode);
-    expect(offenses).to.have.length(0);
-  });
-
   it('should report all use of boolean expressions', async () => {
     const testCases = [
       [`{% assign foo = something == else %}`, '{% assign foo = something %}'],