@perspective-dev/viewer 5.3.1 → 5.4.0

package/src/rust/components/column_selector/active_column.rs

@@ -70,6 +70,9 @@ pub struct ActiveColumnProps {
     #[prop_or_default]
     pub is_window: bool,
 
+    #[prop_or_default]
+    pub is_last_column: bool,
+
     /// Whether the expression/config edit button should be shown.  Computed
     /// by the parent (`is_expression || can_render_column_styles`).
     #[prop_or_default]
@@ -287,7 +290,7 @@ impl Component for ActiveColumn {
                     <div
                         class={outer_classes}
                         data-label={label}
-                        style={format!("--default-column-title:var(--column-selector-column-{path}--content)")}
+                        style={format!("--default-column-title:var(--psp-label--column-{path}--content)")}
                         data-index={ctx.props().idx.to_string()}
                         ondragenter={ondragenter.clone()}
                     >
@@ -301,7 +304,7 @@ impl Component for ActiveColumn {
                     <div
                         class={outer_classes}
                         data-label={label}
-                        style={format!("--default-column-title:var(--column-selector-column-{path}--content)")}
+                        style={format!("--default-column-title:var(--psp-label--column-{path}--content)")}
                         data-index={ctx.props().idx.to_string()}
                         ondragenter={ondragenter.clone()}
                     >
@@ -310,7 +313,9 @@ impl Component for ActiveColumn {
                 }
             },
             ((label, ColumnState::Named(name)), Some(col_type)) => {
-                let is_required = ctx.props().get_is_required(ctx.props().idx);
+                let is_required =
+                    ctx.props().is_last_column || ctx.props().get_is_required(ctx.props().idx);
+
                 let remove_column = if is_required {
                     None
                 } else {
@@ -330,11 +335,12 @@ impl Component for ActiveColumn {
                     let event_name = name.to_owned();
                     let presentation = ctx.props().presentation.clone();
                     move |event: DragEvent| {
-                        presentation.set_drag_image(&event).unwrap();
-                        presentation.notify_drag_start(
-                            event_name.to_string(),
-                            DragEffect::Move(DragTarget::Active),
-                        );
+                        if presentation.set_drag_image(&event) {
+                            presentation.notify_drag_start(
+                                event_name.to_string(),
+                                DragEffect::Move(DragTarget::Active),
+                            );
+                        }
 
                         MouseLeave(false)
                     }
@@ -359,7 +365,7 @@ impl Component for ActiveColumn {
                     <div
                         class={outer_classes}
                         data-label={label}
-                        style={format!("--default-column-title:var(--column-selector-column-{path}--content)")}
+                        style={format!("--default-column-title:var(--psp-label--column-{path}--content)")}
                         data-index={ctx.props().idx.to_string()}
                         {onmouseover}
                         {onmouseout}

package/src/rust/components/column_selector/aggregate_selector.rs

@@ -16,10 +16,10 @@ use itertools::Itertools;
 use perspective_client::config::*;
 use yew::prelude::*;
 
-use crate::components::containers::select::*;
 use crate::renderer::*;
 use crate::session::*;
 use crate::tasks::apply_and_render;
+use crate::ui::{Select, SelectItem};
 use crate::utils::{PtrEqRc, spawn_owned};
 
 #[derive(Properties)]

package/src/rust/components/column_selector/config_selector.rs

@@ -21,8 +21,7 @@ use super::filter_column::*;
 use super::pivot_column::*;
 use super::sort_column::*;
 use crate::components::column_dropdown::{ColumnDropDownElement, ColumnDropDownPortal};
-use crate::components::containers::dragdrop_list::*;
-use crate::components::containers::select::{Select, SelectItem};
+use crate::components::dragdrop_list::*;
 use crate::components::filter_dropdown::{FilterDropDownElement, FilterDropDownPortal};
 use crate::config::PluginStaticConfig;
 use crate::presentation::Presentation;
@@ -30,6 +29,7 @@ use crate::renderer::*;
 use crate::session::drag_drop_update::*;
 use crate::session::*;
 use crate::tasks::apply_and_render;
+use crate::ui::{Select, SelectItem};
 use crate::utils::*;
 
 #[derive(Clone, Properties)]

package/src/rust/components/column_selector/filter_column.rs

@@ -19,14 +19,14 @@ use wasm_bindgen::JsCast;
 use web_sys::*;
 use yew::prelude::*;
 
-use crate::components::containers::dragdrop_list::*;
-use crate::components::containers::select::*;
+use crate::components::dragdrop_list::*;
 use crate::components::filter_dropdown::FilterDropDownElement;
 use crate::components::type_icon::TypeIcon;
 use crate::presentation::Presentation;
 use crate::renderer::*;
 use crate::session::*;
 use crate::tasks::apply_and_render;
+use crate::ui::{Select, SelectItem};
 use crate::utils::*;
 
 #[derive(Clone, Properties)]
@@ -240,9 +240,12 @@ impl Component for FilterColumn {
             let event_name = ctx.props().filter.column().to_owned();
             let presentation = ctx.props().presentation.clone();
             move |event: DragEvent| {
-                presentation.set_drag_image(&event).unwrap();
-                presentation
-                    .notify_drag_start(event_name.to_string(), DragEffect::Move(DragTarget::Filter))
+                if presentation.set_drag_image(&event) {
+                    presentation.notify_drag_start(
+                        event_name.to_string(),
+                        DragEffect::Move(DragTarget::Filter),
+                    )
+                }
             }
         });
 

package/src/rust/components/column_selector/inactive_column.rs

@@ -141,8 +141,10 @@ impl Component for InactiveColumn {
             let event_name = ctx.props().name.to_owned();
             let presentation = ctx.props().presentation.clone();
             move |event: DragEvent| {
-                presentation.set_drag_image(&event).unwrap();
-                presentation.notify_drag_start(event_name.to_string(), DragEffect::Copy);
+                if presentation.set_drag_image(&event) {
+                    presentation.notify_drag_start(event_name.to_string(), DragEffect::Copy);
+                }
+
                 MouseLeave(true)
             }
         });

package/src/rust/components/column_selector/pivot_column.rs

@@ -14,7 +14,7 @@ use perspective_client::config::ColumnType;
 use web_sys::*;
 use yew::prelude::*;
 
-use crate::components::containers::dragdrop_list::*;
+use crate::components::dragdrop_list::*;
 use crate::components::type_icon::TypeIcon;
 use crate::presentation::Presentation;
 use crate::session::*;
@@ -73,8 +73,9 @@ impl Component for PivotColumn {
             let presentation = ctx.props().presentation.clone();
             let action = ctx.props().action;
             move |event: DragEvent| {
-                presentation.set_drag_image(&event).unwrap();
-                presentation.notify_drag_start(event_name.to_string(), DragEffect::Move(action))
+                if presentation.set_drag_image(&event) {
+                    presentation.notify_drag_start(event_name.to_string(), DragEffect::Move(action))
+                }
             }
         });
 

package/src/rust/components/column_selector/sort_column.rs

@@ -14,7 +14,7 @@ use perspective_client::config::*;
 use web_sys::*;
 use yew::prelude::*;
 
-use crate::components::containers::dragdrop_list::*;
+use crate::components::dragdrop_list::*;
 use crate::components::type_icon::TypeIcon;
 use crate::presentation::Presentation;
 use crate::renderer::*;
@@ -104,9 +104,12 @@ impl Component for SortColumn {
             let event_name = ctx.props().sort.0.to_owned();
             let presentation = ctx.props().presentation.clone();
             move |event: DragEvent| {
-                presentation.set_drag_image(&event).unwrap();
-                presentation
-                    .notify_drag_start(event_name.to_string(), DragEffect::Move(DragTarget::Sort))
+                if presentation.set_drag_image(&event) {
+                    presentation.notify_drag_start(
+                        event_name.to_string(),
+                        DragEffect::Move(DragTarget::Sort),
+                    )
+                }
             }
         });
 

package/src/rust/components/column_selector.rs

@@ -38,10 +38,7 @@ use self::active_column::*;
 use self::add_expression_button::AddExpressionButton;
 use self::config_selector::ConfigSelector;
 use self::inactive_column::*;
-use super::containers::scroll_panel::*;
-use super::containers::split_panel::{Orientation, SplitPanel};
 use crate::components::column_dropdown::{ColumnDropDownElement, ColumnDropDownPortal};
-use crate::components::containers::scroll_panel_item::ScrollPanelItem;
 use crate::config::PluginStaticConfig;
 use crate::presentation::{ColumnLocator, ColumnSettingsTarget, DragDropContainer, Presentation};
 use crate::queries::{
@@ -51,6 +48,7 @@ use crate::renderer::*;
 use crate::session::drag_drop_update::*;
 use crate::session::*;
 use crate::tasks::apply_and_render;
+use crate::ui::{Orientation, ScrollPanel, ScrollPanelItem, SplitPanel};
 use crate::utils::*;
 
 #[derive(Properties)]
@@ -333,6 +331,7 @@ impl Component for ColumnSelector {
             prop_config.clone()
         };
 
+        let is_last_column = config.columns.len() == 1;
         let is_aggregated = config.is_aggregated();
         let columns_iter = ColumnsIteratorSet::new(&config, metadata, renderer, presentation);
         let onselect = ctx.link().callback(|()| Redraw);
@@ -468,6 +467,7 @@ impl Component for ColumnSelector {
                             {is_window}
                             {show_edit_btn}
                             {col_type}
+                            {is_last_column}
                             view_config={config.clone()}
                             metadata={metadata.clone()}
                             {name}

package/src/rust/components/column_settings_sidebar/style_tab/agg_depth_selector.rs

@@ -13,8 +13,8 @@
 use perspective_client::clone;
 use yew::{Callback, Html, Properties, function_component, html};
 
-use crate::components::form::number_field::NumberField;
 use crate::config::ColumnConfigFieldUpdate;
+use crate::ui::NumberField;
 
 // ░░░█▀█░█▀▄░█▀█░█▀█░█▀▀░█▀▄░▀█▀░▀█▀░█▀▀░█▀▀░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░
 // ░░░█▀▀░█▀▄░█░█░█▀▀░█▀▀░█▀▄░░█░░░█░░█▀▀░▀▀█░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░░

package/src/rust/components/column_settings_sidebar/style_tab/primitive_field.rs

@@ -26,17 +26,14 @@ use wasm_bindgen::JsCast;
 use web_sys::{HtmlInputElement, MouseEvent};
 use yew::{Callback, Html, Properties, function_component, html, use_callback};
 
-use crate::components::containers::select::{Select, SelectItem};
-use crate::components::form::color_selector::ColorSelector;
-use crate::components::form::multi_stop_gradient_selector::MultiStopGradientSelector;
-use crate::components::form::named_value_picker::NamedValuePicker;
-use crate::components::form::number_field::NumberField;
-use crate::components::form::optional_field::OptionalField;
-use crate::components::form::palette_selector::PaletteSelector;
-use crate::config::{
-    ColumnConfigFieldUpdate, CssColor, CssGradient, CssKind, CssPalette, EnumVariant,
-    GradientStopSpec, NamedValue, canonicalize_css_color, discrete_pair, gradient_to_css,
-    palette_name_for,
+use crate::config::{ColumnConfigFieldUpdate, EnumVariant, discrete_pair};
+use crate::ui::{
+    ColorSelector, MultiStopGradientSelector, NamedValuePicker, NumberField, OptionalField,
+    PaletteSelector, Select, SelectItem,
+};
+use crate::utils::{
+    CssColor, CssGradient, CssKind, CssPalette, GradientStopSpec, NamedValue,
+    canonicalize_css_color, gradient_to_css, palette_name_for,
 };
 
 fn emit(on_change: &Callback<ColumnConfigFieldUpdate>, key: &str, value: Option<Value>) {
@@ -150,9 +147,10 @@ pub fn BoolField(props: &BoolFieldProps) -> Html {
                         checked={current}
                         {oninput}
                     />
-                    <label for={format!("{}-checkbox", props.field_key)} class="bool-field-desc">
-                        { if current { "Enabled" } else { "Disabled" } }
-                    </label>
+                    <label
+                        for={format!("{}-checkbox", props.field_key)}
+                        class={if current { "bool-field-desc enabled" } else { "bool-field-desc disabled" }}
+                    />
                 </div>
             </OptionalField>
         </div>
@@ -346,7 +344,7 @@ pub fn PaletteField(props: &PaletteFieldProps) -> Html {
                 on_change={on_change_palette}
                 {on_reset}
                 {is_modified}
-                title={Some(format!("{}-label", props.field_key))}
+                label={Some(props.field_key.clone())}
             />
         </div>
     }
@@ -459,7 +457,7 @@ pub fn GradientStopsField(props: &GradientStopsFieldProps) -> Html {
                 on_change={on_change_stops}
                 {on_reset}
                 {is_modified}
-                title={Some(format!("{}-label", props.field_key))}
+                label={Some(props.field_key.clone())}
             />
         </div>
     }
@@ -555,7 +553,7 @@ pub fn ColorField(props: &ColorFieldProps) -> Html {
                 {on_color}
                 {on_reset}
                 {is_modified}
-                title={Some(format!("{}-label", props.field_key))}
+                label={Some(props.field_key.clone())}
             />
         </div>
     }

package/src/rust/components/column_settings_sidebar/style_tab/symbol/symbol_selector.rs

@@ -13,7 +13,7 @@
 use itertools::Itertools;
 use yew::{Callback, Html, Properties, function_component, html};
 
-use crate::components::containers::select::{Select, SelectItem};
+use crate::ui::{Select, SelectItem};
 use crate::utils::PtrEqRc;
 
 #[derive(Properties, PartialEq)]

package/src/rust/components/column_settings_sidebar/style_tab.rs

@@ -26,22 +26,21 @@ use self::primitive_field::{
     BoolField, ColorField, EnumField, GradientStopsField, NumberFieldPrimitive, PaletteField,
 };
 use crate::components::column_settings_sidebar::style_tab::symbol::SymbolStyle;
-use crate::components::containers::control_group::ControlGroup;
 use crate::components::datetime_column_style::DatetimeColumnStyle;
 use crate::components::number_series_style::NumberSeriesStyle;
 use crate::components::string_column_style::StringColumnStyle;
 use crate::components::style_controls::CustomNumberFormat;
 use crate::config::{
-    ColumnConfigFieldUpdate, ControlSpec, CssKind, CustomNumberFormatConfig,
-    DatetimeColumnStyleConfig, NamedValue, NumberFormatDefaults, NumberSeriesStyleConfig,
-    StringColumnStyleConfig,
+    ColumnConfigFieldUpdate, ControlSpec, CustomNumberFormatConfig, DatetimeColumnStyleConfig,
+    NumberFormatDefaults, NumberSeriesStyleConfig, StringColumnStyleConfig,
 };
 use crate::presentation::Presentation;
 use crate::queries::{fetch_column_abs_max, get_column_config_schema, named_values};
 use crate::renderer::Renderer;
 use crate::session::Session;
 use crate::tasks::send_column_config;
-use crate::utils::PtrEqRc;
+use crate::ui::ControlGroup;
+use crate::utils::{CssKind, NamedValue, PtrEqRc};
 use crate::workspace::Workspace;
 
 #[derive(Clone, PartialEq, Properties)]

package/src/rust/components/column_settings_sidebar.rs

@@ -29,9 +29,7 @@ use crate::components::column_settings_sidebar::attributes_tab::AttributesTab;
 use crate::components::column_settings_sidebar::save_settings::SaveSettingsProps;
 use crate::components::column_settings_sidebar::style_tab::StyleTab;
 use crate::components::column_settings_sidebar::window_tab::{WindowTab, WindowTabProps};
-use crate::components::containers::sidebar::Sidebar;
-use crate::components::containers::tab_list::TabList;
-use crate::components::editable_header::EditableHeaderProps;
+use crate::components::editable_header::{EditableHeader, EditableHeaderProps};
 use crate::components::expression_editor::ExpressionEditorProps;
 use crate::components::type_icon::TypeIconType;
 use crate::components::window_editor::WindowEditorProps;
@@ -41,6 +39,7 @@ use crate::session::{Session, SessionMetadataRc};
 use crate::tasks::{
     delete_expr, delete_window, save_expr, save_window, update_expr, update_window,
 };
+use crate::ui::{Sidebar, TabList};
 use crate::utils::PtrEqRc;
 use crate::workspace::Workspace;
 
@@ -519,7 +518,7 @@ impl Component for ColumnSettingsPanel {
                     is_pinned={ctx.props().is_pinned}
                     on_toggle_pin={Some(ctx.props().on_toggle_pin.clone())}
                     selected_tab={selected_tab_idx}
-                    {header_props}
+                    header={html! { <EditableHeader ..header_props /> }}
                 >
                     <TabList<ColumnSettingsTab>
                         tabs={self.tabs.clone()}

package/src/rust/components/copy_dropdown.rs

@@ -14,9 +14,9 @@ use std::rc::Rc;
 
 use yew::prelude::*;
 
-use super::containers::dropdown_menu::*;
 use crate::config::*;
 use crate::renderer::*;
+use crate::ui::{DropDownMenu, DropDownMenuItem};
 
 type CopyDropDownMenuItem = DropDownMenuItem<ExportFile>;
 

package/src/rust/components/datetime_column_style/custom.rs

@@ -14,10 +14,8 @@ use std::rc::Rc;
 
 use yew::prelude::*;
 
-use crate::components::form::number_field::NumberField;
-use crate::components::form::select_value_field::SelectValueField;
-use crate::components::modal::{ModalLink, SetModalLink};
 use crate::config::*;
+use crate::ui::{ModalLink, NumberField, SelectValueField, SetModalLink};
 use crate::utils::WeakScope;
 
 #[derive(Properties)]

package/src/rust/components/datetime_column_style/simple.rs

@@ -12,9 +12,8 @@
 
 use yew::prelude::*;
 
-use crate::components::form::select_enum_field::SelectEnumField;
-use crate::components::modal::{ModalLink, SetModalLink};
 use crate::config::*;
+use crate::ui::{ModalLink, SelectEnumField, SetModalLink};
 use crate::utils::WeakScope;
 
 #[derive(Properties)]

package/src/rust/components/datetime_column_style.rs

@@ -22,11 +22,10 @@ use perspective_js::utils::global::navigator;
 use wasm_bindgen::prelude::*;
 use yew::prelude::*;
 
-use super::modal::{ModalLink, SetModalLink};
 use crate::components::datetime_column_style::custom::DatetimeStyleCustom;
 use crate::components::datetime_column_style::simple::DatetimeStyleSimple;
-use crate::components::form::select_value_field::SelectValueField;
 use crate::config::*;
+use crate::ui::{ModalLink, SelectValueField, SetModalLink};
 use crate::utils::WeakScope;
 
 /// Format-only widget for `datetime` columns. Renders the `date_format`

package/src/rust/components/{form/debug.rs → debug_panel.rs}

@@ -17,7 +17,7 @@ use perspective_js::utils::{ApiFuture, JsValueSerdeExt};
 use wasm_bindgen::prelude::*;
 use yew::prelude::*;
 
-use crate::components::form::code_editor::CodeEditor;
+use crate::components::code_editor::CodeEditor;
 use crate::js::{MimeType, copy_to_clipboard, paste_from_clipboard};
 use crate::presentation::*;
 use crate::renderer::*;
@@ -169,10 +169,10 @@ pub fn debug_panel(props: &DebugPanelProps) -> Html {
             <div id="debug-panel-overflow">
                 <div id="debug-panel" class="sidebar_column" ref={sizer}>
                     <div id="debug-panel-controls">
-                        <button disabled={!*modified} onclick={onapply}>{ "Apply" }</button>
-                        <button disabled={!*modified} onclick={onreset}>{ "Reset" }</button>
-                        <button onclick={oncopy}>{ "Copy" }</button>
-                        <button onclick={onpaste}>{ "Paste" }</button>
+                        <button id="debug-panel-apply" disabled={!*modified} onclick={onapply} />
+                        <button id="debug-panel-reset" disabled={!*modified} onclick={onreset} />
+                        <button id="debug-panel-copy" onclick={oncopy} />
+                        <button id="debug-panel-paste" onclick={onpaste} />
                     </div>
                     <div id="debug-panel-editor">
                         <CodeEditor

package/src/rust/components/{containers/dragdrop_list.rs → dragdrop_list.rs}

@@ -23,6 +23,7 @@ use crate::components::column_dropdown::ColumnDropDownElement;
 use crate::components::column_selector::{EmptyColumn, InPlaceColumn, InvalidColumn};
 use crate::components::type_icon::TypeIcon;
 use crate::presentation::{DragDropContainer, Presentation};
+use crate::ui::intl_slug;
 use crate::utils::DragTarget;
 
 #[derive(Properties, Derivative)]
@@ -405,16 +406,7 @@ where
         // here while the var VALUE stays in the stylesheets - custom
         // properties inherit, so the label's `:before` picks it up.
         let role_style = ctx.props().role_label.as_ref().map(|role| {
-            let slug = role
-                .chars()
-                .map(|x| {
-                    if x.is_ascii_alphanumeric() {
-                        x.to_ascii_lowercase()
-                    } else {
-                        '-'
-                    }
-                })
-                .collect::<String>();
+            let slug = intl_slug(role);
 
             // The second var is a PRESENCE FLAG: CSS cannot ask whether a
             // custom property is set, so the slot's stylesheet reads it as

package/src/rust/components/export_dropdown.rs

@@ -14,10 +14,10 @@ use std::rc::Rc;
 
 use yew::prelude::*;
 
-use super::containers::dropdown_menu::*;
 use crate::config::*;
 use crate::renderer::*;
 use crate::session::Session;
+use crate::ui::{DropDownMenu, DropDownMenuItem};
 
 pub type ExportDropDownMenuItem = DropDownMenuItem<ExportFile>;
 

package/src/rust/components/expression_editor.rs

@@ -15,7 +15,7 @@ use std::rc::Rc;
 use perspective_client::{ExprValidationError, clone};
 use yew::prelude::*;
 
-use super::form::code_editor::*;
+use super::code_editor::CodeEditor;
 use crate::session::{Session, SessionMetadataRc};
 use crate::tasks::{ExprValidation, validate_expression};
 

package/src/rust/components/filter_dropdown.rs

@@ -19,9 +19,9 @@ use web_sys::*;
 use yew::html::ImplicitClone;
 use yew::prelude::*;
 
-use super::portal::PortalModal;
 use super::style::StyleSurface;
 use crate::session::Session;
+use crate::ui::PortalModal;
 use crate::utils::*;
 use crate::*;
 
@@ -219,7 +219,7 @@ impl Component for FilterDropDownPortal {
             html! {
                 <PortalModal
                     tag_name="perspective-dropdown"
-                    surface={StyleSurface::FilterDropdown}
+                    sheet={StyleSurface::FilterDropdown.sheet()}
                     {target}
                     own_focus=false
                     {on_close}

package/src/rust/components/function_dropdown.rs

@@ -19,8 +19,8 @@ use web_sys::*;
 use yew::html::ImplicitClone;
 use yew::prelude::*;
 
-use super::portal::PortalModal;
 use super::style::StyleSurface;
+use crate::ui::PortalModal;
 use crate::utils::*;
 
 #[derive(Default)]
@@ -157,7 +157,7 @@ impl Component for FunctionDropDownPortal {
             html! {
                 <PortalModal
                     tag_name="perspective-dropdown"
-                    surface={StyleSurface::FunctionDropdown}
+                    sheet={StyleSurface::FunctionDropdown.sheet()}
                     {target}
                     own_focus=false
                     {on_close}

package/src/rust/components/main_panel/frame_theme.rs

@@ -21,42 +21,6 @@
 //! own per-panel themed background), but while the plugin is missing — not yet
 //! mounted, first draw pending, or torn down — the host-theme container shows
 //! through a panel themed differently, as a visible artifact.
-//!
-//! There is no native cascade channel from the light-DOM plugin to the frame
-//! (siblings in the flattened tree), so the value is mirrored imperatively:
-//! each panel's *plugin element* — light-DOM, slotted under the panel's slot,
-//! mounted eagerly at panel creation (`create_panel_model` /
-//! `Renderer::mount_active_plugin`) — is where the document theme rules
-//! actually resolve, so its computed `--psp--background-color` is copied onto
-//! the frame's inline style, where the frame's shadow parts inherit it. The
-//! plugin is the ONLY sound source element:
-//!
-//! - An owned hidden probe child of the viewer does NOT work: an *unslotted*
-//!   light-DOM child of a shadow host is outside the flattened tree, and
-//!   `getComputedStyle` returns all-empty for it even though the document rules
-//!   match it syntactically (selector matching is DOM-tree; style computation
-//!   is flat-tree).
-//! - The `<perspective-viewer-tab>` is slotted, but stamps its own `theme` attr
-//!   in `PanelTab::rendered` — an unordered sibling lifecycle relative to this
-//!   pass (the theme-stamp-lag class of bug).
-//! - The plugin's `theme` attr, by contrast, is stamped *synchronously at the
-//!   mutation sites* (`update_theme`, `restorePanel`, …) before the events that
-//!   schedule this render, so it is current when this pass reads it.
-//!
-//! A read is trusted ONLY when the plugin's stamped attr equals the theme
-//! being mirrored: a freshly-created panel's plugin is mounted *unstamped*
-//! (the attr first lands inside its first locked dispatch), and reading it
-//! early would silently mirror the HOST theme's values. Trusted reads seed
-//! [`MainPanel::theme_backgrounds`], the fallback for frames with no readable
-//! plugin (an unregistered plugin name stays lazily unmounted; plugin-switch
-//! and teardown transients). A frame with neither leaves the pass gate
-//! unlatched, so it retries on subsequent renders until the dispatch stamp
-//! lands (the render that follows that dispatch's `update_count` bump).
-//!
-//! Unlike the plugin `theme`/`active` stamps (see the NOTE in [`reconcile`]),
-//! the frame is pure viewer chrome — no plugin dispatch reads it — so
-//! stamping it from this async `rendered` pass cannot split a plugin draw
-//! across paints, and it needs no lock.
 
 use wasm_bindgen::prelude::*;
 use yew::prelude::*;
@@ -69,12 +33,7 @@ use crate::workspace::PanelId;
 /// `.rl-panel::part(container)` background resolves.
 const BACKGROUND_VAR: &str = "--psp--background-color";
 
-/// The inputs the frame backgrounds were last computed from; re-mirroring is
-/// skipped while these are unchanged, so the forced style recalcs of
-/// `getComputedStyle` don't run on every render (e.g. the per-update
-/// `update_count` renders of a streaming table). `available_themes` is part of
-/// the key because theme CSS registering late changes the *computed* value
-/// under an unchanged theme name.
+/// The inputs the frame backgrounds were last computed from.
 pub(super) type FrameThemeSnapshot = (
     Vec<PanelId>,
     Vec<(String, Option<String>)>,
@@ -82,12 +41,7 @@ pub(super) type FrameThemeSnapshot = (
 );
 
 impl MainPanel {
-    /// Mirror each panel's effective theme background (its own theme, else the
-    /// registry default — the same fallback the tab/menu use) onto its
-    /// `<regular-layout-frame>`'s inline `--psp--background-color`, read off
-    /// the panel's stamped plugin element (else the theme-keyed cache of prior
-    /// reads). A panel with no resolvable theme has the property removed,
-    /// falling back to the inherited host-theme value.
+    /// Mirror each panel's effective theme background.
     pub(super) fn stamp_frame_themes(&mut self, ctx: &Context<Self>) {
         let Some(layout) = self.layout_ref.cast::<web_sys::Element>() else {
             return;
@@ -104,8 +58,6 @@ impl MainPanel {
             return;
         }
 
-        // A theme-registry change can re-value an unchanged theme name, so
-        // cached reads from the previous registry are unsound.
         if let Some((_, _, prev_themes)) = &self.stamped_frame_themes
             && prev_themes != &snapshot.2
         {
@@ -155,19 +107,11 @@ impl MainPanel {
             }
         }
 
-        // Latch only a fully-resolved pass; an unresolved frame (unmounted or
-        // not-yet-stamped plugin) retries each render until its dispatch
-        // stamp lands.
         self.stamped_frame_themes = complete.then_some(snapshot);
     }
 }
 
-/// Read the computed [`BACKGROUND_VAR`] off `slot`'s plugin element — the
-/// viewer light-DOM child mounted under exactly that slot name (the tab and
-/// toolbar use `tab-`/`statusbar-extra-` prefixed slots). Requires the
-/// plugin's `theme` attr to already equal `theme` — during a plugin switch
-/// two elements briefly share the slot, and a freshly-mounted plugin is not
-/// yet stamped; both are disambiguated by the attr check.
+/// Read the computed [`BACKGROUND_VAR`] off `slot`'s plugin element.
 fn read_plugin_background(viewer: &web_sys::Element, slot: &str, theme: &str) -> Option<String> {
     let children = viewer.children();
     let plugin = (0..children.length())