@pennyfarthing/core 11.3.8 → 11.5.0-alpha.0

package/pennyfarthing-dist/pf/tests/test_package_structure.py

@@ -10,7 +10,25 @@ These tests verify:
 5. Backwards compatibility for existing imports
 """
 
+import os
+import subprocess
 import sys
+from pathlib import Path
+
+# pennyfarthing-dist/ must be on PYTHONPATH for subprocess -m calls
+_DIST_DIR = str(Path(__file__).resolve().parents[2])
+_ENV = {**os.environ, "PYTHONPATH": _DIST_DIR + os.pathsep + os.environ.get("PYTHONPATH", "")}
+
+
+def _run_module(*args: str) -> subprocess.CompletedProcess[str]:
+    """Run a pf module as subprocess with correct PYTHONPATH."""
+    return subprocess.run(
+        [sys.executable, "-m", *args],
+        capture_output=True,
+        text=True,
+        timeout=30,
+        env=_ENV,
+    )
 
 
 class TestCommonPackage:
@@ -40,20 +58,6 @@ class TestCommonPackage:
         assert hasattr(config, "load_yaml_config")
         assert hasattr(config, "load_pennyfarthing_config")
 
-    def test_output_backwards_compatibility(self) -> None:
-        """Old import path should still work for backwards compatibility."""
-        from pf import output
-
-        # Should re-export from common.output
-        assert hasattr(output, "success")
-        assert hasattr(output, "error")
-
-    def test_config_backwards_compatibility(self) -> None:
-        """Old import path should still work for backwards compatibility."""
-        from pf import config
-
-        # Should re-export from common.config
-        assert hasattr(config, "get_project_root")
 
 
 class TestJiraPackage:
@@ -71,7 +75,7 @@ class TestJiraPackage:
         from pf.jira import client
 
         assert hasattr(client, "JiraClient")
-        assert hasattr(client, "get_issue")
+        assert hasattr(client, "get_client")
         assert hasattr(client, "map_status_to_jira")
         assert hasattr(client, "map_jira_to_status")
         assert hasattr(client, "extract_jira_key")
@@ -128,11 +132,10 @@ class TestJiraPackage:
 
     def test_jira_backwards_compatibility(self) -> None:
         """Old-style imports should still work."""
-        # These imports should work for backwards compatibility
-        from pf.jira import STATUS_TO_JIRA, JiraClient, get_issue
+        from pf.jira import STATUS_TO_JIRA, JiraClient, get_client
 
         assert JiraClient is not None
-        assert callable(get_issue)
+        assert callable(get_client)
         assert isinstance(STATUS_TO_JIRA, dict)
 
 
@@ -251,13 +254,7 @@ class TestJiraCLI:
 
     def test_jira_cli_runnable_as_module(self) -> None:
         """python -m pf.jira should work."""
-        import subprocess
-
-        result = subprocess.run(
-            [sys.executable, "-m", "pf.jira", "--help"],
-            capture_output=True,
-            text=True,
-        )
+        result = _run_module("pf.jira", "--help")
         # Should exit 0 with help text
         assert result.returncode == 0
         assert "usage" in result.stdout.lower() or "Usage" in result.stdout
@@ -284,13 +281,7 @@ class TestSprintCLI:
 
     def test_sprint_cli_runnable_as_module(self) -> None:
         """python -m pf.sprint should work."""
-        import subprocess
-
-        result = subprocess.run(
-            [sys.executable, "-m", "pf.sprint", "--help"],
-            capture_output=True,
-            text=True,
-        )
+        result = _run_module("pf.sprint", "--help")
         assert result.returncode == 0
         assert "usage" in result.stdout.lower() or "Usage" in result.stdout
 
@@ -315,45 +306,8 @@ class TestStoryCLI:
 
     def test_story_cli_runnable_as_module(self) -> None:
         """python -m pf.story should work."""
-        import subprocess
-
-        result = subprocess.run(
-            [sys.executable, "-m", "pf.story", "--help"],
-            capture_output=True,
-            text=True,
-        )
+        result = _run_module("pf.story", "--help")
         assert result.returncode == 0
         assert "usage" in result.stdout.lower() or "Usage" in result.stdout
 
 
-class TestOldModuleCompatibility:
-    """Tests ensuring old flat modules still work."""
-
-    def test_jira_sync_module_works(self) -> None:
-        """jira_sync.py should still be importable and functional."""
-        from pf import jira_sync
-
-        assert hasattr(jira_sync, "sync_epic")
-        assert hasattr(jira_sync, "sync_story")
-        assert hasattr(jira_sync, "main")
-
-    def test_jira_bidirectional_sync_module_works(self) -> None:
-        """jira_bidirectional_sync.py should still be importable."""
-        from pf import jira_bidirectional_sync
-
-        assert hasattr(jira_bidirectional_sync, "generate_sync_plan")
-        assert hasattr(jira_bidirectional_sync, "main")
-
-    def test_jira_epic_creation_module_works(self) -> None:
-        """jira_epic_creation.py should still be importable."""
-        from pf import jira_epic_creation
-
-        assert hasattr(jira_epic_creation, "create_epic")
-        assert hasattr(jira_epic_creation, "main")
-
-    def test_jira_sync_story_module_works(self) -> None:
-        """jira_sync_story.py should still be importable."""
-        from pf import jira_sync_story
-
-        assert hasattr(jira_sync_story, "sync_story")
-        assert hasattr(jira_sync_story, "main")

package/pennyfarthing-dist/pf/tests/test_sprint_validator.py

@@ -288,6 +288,50 @@ class TestStoryValidation:
 
         assert result.valid is True
 
+    def test_short_project_key_passes(self) -> None:
+        """Short project key with fewer digits should pass (e.g., DPGD-17)."""
+        story = {
+            "id": "63-1",
+            "title": "Test",
+            "status": "backlog",
+            "points": 3,
+            "jira": "DPGD-17",
+        }
+
+        result = validate_story(story, "epic-63")
+
+        assert result.valid is True
+
+    def test_compound_jira_key_passes(self) -> None:
+        """Compound Jira key with slash separator should pass (e.g., DPGD-10 / DPGD-17)."""
+        story = {
+            "id": "63-1",
+            "title": "Test",
+            "status": "backlog",
+            "points": 3,
+            "jira": "DPGD-10 / DPGD-17",
+        }
+
+        result = validate_story(story, "epic-63")
+
+        assert result.valid is True
+
+    def test_sprint_without_number_and_jira_sprint_id_passes(self) -> None:
+        """Sprint without number and jira_sprint_id should pass (BMAD-imported sprints)."""
+        data = {
+            "sprint": {
+                "goal": "BMAD imported sprint",
+                "start_date": "2026-01-20",
+                "end_date": "2026-02-02",
+                "status": "active",
+            },
+            "epics": [],
+        }
+
+        result = validate_sprint(data)
+
+        assert result.valid is True
+
     def test_error_path_includes_epic_context(self) -> None:
         """Error path should include epic ID for context."""
         story = {"id": "63-1", "title": "Test", "points": 3}  # Missing status

package/pennyfarthing-dist/pf/validate/adapters/agent.py

@@ -13,6 +13,7 @@ from pathlib import Path
 
 import yaml
 
+from pf.common.config import get_dist_root
 from pf.validate import ValidateReport
 
 VALID_MODELS = {"haiku", "sonnet", "opus"}
@@ -191,7 +192,12 @@ def validate_subagent(path: Path) -> tuple[list[str], list[str]]:
 def run(root: Path, *, fix: bool = False, strict: bool = False) -> ValidateReport:
     """Validate all agent definition files."""
     report = ValidateReport(validator="agent")
-    agents_dir = root / "pennyfarthing-dist" / "agents"
+    dist_root = get_dist_root(project_root=root)
+    if dist_root is None:
+        report.details.append("[ERROR] agents directory not found")
+        report.errors += 1
+        return report
+    agents_dir = dist_root / "agents"
 
     if not agents_dir.is_dir():
         report.details.append("[ERROR] agents directory not found")
@@ -200,6 +206,10 @@ def run(root: Path, *, fix: bool = False, strict: bool = False) -> ValidateRepor
 
     main_agents, subagents, _skipped = classify_agent_files(agents_dir)
 
+    if not main_agents and not subagents:
+        report.warnings += 1
+        report.details.append("[WARN] No agent files found in agents directory")
+
     for path in main_agents:
         file_errors, file_warnings = validate_main_agent(path, agents_dir)
 

package/pennyfarthing-dist/pf/validate/adapters/skill_command.py

@@ -14,6 +14,7 @@ from pathlib import Path
 
 import yaml
 
+from pf.common.config import get_dist_root
 from pf.validate import ValidateReport
 
 _SEMVER_RE = re.compile(r"^\d+\.\d+\.\d+$")
@@ -25,7 +26,10 @@ def discover_skill_registry(root: Path) -> Path | None:
     Returns:
         Path to skill-registry.yaml, or None if not found.
     """
-    path = root / "pennyfarthing-dist" / "skills" / "skill-registry.yaml"
+    dist_root = get_dist_root(project_root=root)
+    if dist_root is None:
+        return None
+    path = dist_root / "skills" / "skill-registry.yaml"
     return path if path.is_file() else None
 
 
@@ -42,7 +46,10 @@ def discover_command_files(commands_dir: Path) -> list[Path]:
 
 def _load_schema(root: Path) -> dict | None:
     """Load the skill-registry.schema.json file."""
-    schema_path = root / "pennyfarthing-dist" / "skills" / "skill-registry.schema.json"
+    dist_root = get_dist_root(project_root=root)
+    if dist_root is None:
+        return None
+    schema_path = dist_root / "skills" / "skill-registry.schema.json"
     if not schema_path.is_file():
         return None
     try:
@@ -213,7 +220,10 @@ def _get_body(content: str) -> str:
 
 def _discover_registry(root: Path) -> dict | None:
     """Load command-registry.yaml if it exists."""
-    path = root / "pennyfarthing-dist" / "command-registry.yaml"
+    dist_root = get_dist_root(project_root=root)
+    if dist_root is None:
+        return None
+    path = dist_root / "command-registry.yaml"
     if not path.is_file():
         return None
     try:
@@ -413,7 +423,8 @@ def run(root: Path, *, fix: bool = False, strict: bool = False) -> ValidateRepor
         report.passed += 1
 
     # --- Command file validation ---
-    commands_dir = root / "pennyfarthing-dist" / "commands"
+    dist_root = get_dist_root(project_root=root)
+    commands_dir = (dist_root / "commands") if dist_root else root / "pennyfarthing-dist" / "commands"
     command_files = discover_command_files(commands_dir)
 
     for path in command_files:

package/pennyfarthing-dist/pf/validate/adapters/tandem_awareness.py

@@ -11,6 +11,7 @@ from __future__ import annotations
 import re
 from pathlib import Path
 
+from pf.common.config import get_dist_root
 from pf.validate import ValidateReport
 
 # Regex to extract <tandem-consultation> section content
@@ -178,7 +179,12 @@ def run(
 ) -> ValidateReport:
     """Validate agent tandem awareness sections."""
     report = ValidateReport(validator="tandem-awareness")
-    agents_dir = root / "pennyfarthing-dist" / "agents"
+    dist_root = get_dist_root(project_root=root)
+    if dist_root is None:
+        report.details.append("[ERROR] agents directory not found")
+        report.errors += 1
+        return report
+    agents_dir = dist_root / "agents"
 
     if not agents_dir.is_dir():
         report.details.append("[ERROR] agents directory not found")

package/pennyfarthing-dist/pf/validate/adapters/team_mode.py

@@ -11,6 +11,7 @@ from __future__ import annotations
 import re
 from pathlib import Path
 
+from pf.common.config import get_dist_root
 from pf.validate import ValidateReport
 
 # Regex to extract <team-mode> section content
@@ -253,7 +254,12 @@ def run(
     report = ValidateReport(validator="team-mode")
 
     # Validate behavior guide
-    guides_dir = root / "pennyfarthing-dist" / "guides"
+    dist_root = get_dist_root(project_root=root)
+    if dist_root is None:
+        report.errors += 1
+        report.details.append("[ERROR] pennyfarthing-dist not found")
+        return report
+    guides_dir = dist_root / "guides"
     behavior_guide = guides_dir / "agent-behavior.md"
     if behavior_guide.is_file():
         file_errors, file_warnings = validate_behavior_guide_team_mode(behavior_guide)
@@ -301,7 +307,7 @@ def run(
         report.details.append("[ERROR] agent-behavior.md guide not found")
 
     # Validate lead agents
-    agents_dir = root / "pennyfarthing-dist" / "agents"
+    agents_dir = dist_root / "agents"
     if agents_dir.is_dir():
         for agent_name in ("dev", "reviewer"):
             agent_path = agents_dir / f"{agent_name}.md"

package/pennyfarthing-dist/pf/validate/adapters/workflow.py

@@ -13,6 +13,7 @@ from pathlib import Path
 
 import yaml
 
+from pf.common.config import get_dist_root
 from pf.validate import ValidateReport
 
 # Known workflow types
@@ -315,16 +316,25 @@ def validate_procedural(
 def run(root: Path, *, fix: bool = False, strict: bool = False) -> ValidateReport:
     """Validate all workflow definition files."""
     report = ValidateReport(validator="workflow")
-    workflows_dir = root / "pennyfarthing-dist" / "workflows"
+    dist_root = get_dist_root(project_root=root)
+    if dist_root is None:
+        report.details.append("[ERROR] workflows directory not found")
+        report.errors += 1
+        return report
+    workflows_dir = dist_root / "workflows"
 
     if not workflows_dir.is_dir():
         report.details.append("[ERROR] workflows directory not found")
         report.errors += 1
         return report
 
-    agents_dir = root / "pennyfarthing-dist" / "agents"
+    agents_dir = dist_root / "agents"
     files = discover_workflow_files(workflows_dir)
 
+    if not files:
+        report.warnings += 1
+        report.details.append("[WARN] No workflow files found in workflows directory")
+
     for path in files:
         try:
             content = path.read_text()

package/pennyfarthing-dist/pyproject.toml

@@ -5,7 +5,7 @@ requires-python = ">=3.11"
 dependencies = ["pyyaml>=6.0", "ruamel.yaml>=0.18", "httpx>=0.28", "click>=8.0", "pydriller>=2.6"]
 
 [project.optional-dependencies]
-tui = ["textual>=1.0", "websockets>=12.0", "textual-image>=0.7.0"]
+tui = ["textual>=1.0", "websockets>=12.0", "textual-image>=0.7.0", "watchfiles>=1.0"]
 
 [project.scripts]
 pf = "pf.cli:main"

package/pennyfarthing-dist/scripts/core/check-context.sh

@@ -71,7 +71,7 @@ done
 
 # Derive Claude project path from current directory
 PROJECT_DIR="${PROJECT_ROOT:-$(pwd)}"
-CLAUDE_PROJECT_PATH="$HOME/.claude/projects/$(echo "$PROJECT_DIR" | tr '/' '-')"
+CLAUDE_PROJECT_PATH="$HOME/.claude/projects/$(echo "$PROJECT_DIR" | tr '/.' '-')"
 
 # Default config
 WARNING_THRESHOLD=60
@@ -156,7 +156,7 @@ if last_total:
     status = 'HIGH' if usable_pct > $WARNING_THRESHOLD else 'OK'
     relay = '$RELAY_MODE' == 'true'
     tirepump = (relay or '$PERMISSION_MODE' == 'turbo') and usable_pct > $TIREPUMP_THRESHOLD
-    is_cyclist = os.environ.get('CYCLIST') == '1' or Path('$PROJECT_DIR/packages/cyclist/.bikerack-port').exists()
+    is_cyclist = os.environ.get('CYCLIST') == '1' or Path('$PROJECT_DIR/.bikerack-port').exists() or Path('$PROJECT_DIR/packages/cyclist/.bikerack-port').exists()
 
     print(f'CONTEXT_TOKENS={last_total}')
     print(f'CONTEXT_PERCENT={total_pct}')