@pennyfarthing/core 11.3.8 → 11.5.0-alpha.0

package/pennyfarthing-dist/pf/bikerack/story_detail_screen.py

@@ -1,7 +1,8 @@
 """StoryDetailScreen — Mission dossier detail view for BikeRack TUI.
 
 Story 110-2: Story drill-through with dossier detail screen.
-Pushed via Screen.push() from SprintPanel when user presses Enter on a story.
+Story 120-8: Upgraded to use StoryDetailWidget with native Textual widgets.
+Pushed via Screen.push() from SprintPanel or ProgressPanel.
 """
 
 from __future__ import annotations
@@ -9,17 +10,17 @@ from __future__ import annotations
 import webbrowser
 from typing import Any
 
-from rich.text import Text
 from textual.binding import Binding
+from textual.containers import VerticalScroll
 from textual.screen import Screen
-from textual.widgets import Static
+
+from pf.bikerack.story_detail_widget import StoryDetailWidget
 
 
 class StoryDetailScreen(Screen):
     """Detail screen showing story dossier layout.
 
-    Displays AC checklist, workflow phase dots, git branch, PR link,
-    and session notes in a mission-dossier layout.
+    Delegates rendering to StoryDetailWidget inside a VerticalScroll.
     """
 
     BINDINGS = [
@@ -57,107 +58,11 @@ class StoryDetailScreen(Screen):
         return merged
 
     def compose(self):
-        """Compose the dossier layout with header, ACs, workflow, git info.
-
-        Absent sections are simply omitted (Tufte: absence is information).
-        """
-        data = self._story_data
-
-        # Header section
-        title = data.get("title", "Unknown Story")
-        points = data.get("points", "?")
-        status = data.get("status", "unknown")
-        jira_key = data.get("jiraKey", "")
-        assignee = data.get("assignee", "")
-        priority = data.get("priority", "")
-
-        header_text = Text()
-        if jira_key:
-            header_text.append(f"{jira_key}", style="bold cyan")
-            header_text.append("  ")
-        header_text.append(f"{title}", style="bold")
-        # Metadata line
-        meta_parts = [status]
-        if points and points != "?":
-            meta_parts.append(f"{points} pts")
-        if priority:
-            meta_parts.append(priority)
-        if assignee:
-            from pf.bikerack.sprint_panel import _format_assignee
-
-            name = _format_assignee(assignee)
-            if name:
-                meta_parts.append(name)
-        separator = " \u00b7 "
-        header_text.append(f"\n{separator.join(meta_parts)}", style="dim")
-        yield Static(header_text, id="dossier-header")
-
-        # Context section (only if context files exist)
-        has_epic_ctx = data.get("has_epic_context", False)
-        has_story_ctx = data.get("has_story_context", False)
-        if has_epic_ctx or has_story_ctx:
-            ctx_text = Text()
-            ctx_text.append("Context\n", style="bold underline")
-            if has_epic_ctx:
-                ctx_text.append("  \u2713 Epic context\n", style="green")
-            else:
-                ctx_text.append("  \u25cb Epic context\n", style="dim")
-            if has_story_ctx:
-                ctx_text.append("  \u2713 Story context\n", style="green")
-            else:
-                ctx_text.append("  \u25cb Story context\n", style="dim")
-            yield Static(ctx_text, id="dossier-context")
-
-        # Acceptance Criteria section
-        acs = data.get("acceptance_criteria", [])
-        if acs:
-            ac_text = Text()
-            done_count = sum(1 for ac in acs if ac.get("done"))
-            ac_text.append("Acceptance Criteria", style="bold underline")
-            ac_text.append(f"  {done_count}/{len(acs)}\n", style="dim")
-            for ac in acs:
-                check = "\u2713" if ac.get("done") else "\u25cb"
-                style = "green" if ac.get("done") else ""
-                ac_text.append(f"  {check} {ac.get('text', '')}\n", style=style)
-            yield Static(ac_text, id="dossier-ac")
-
-        # Workflow section
-        workflow = data.get("workflow", "")
-        phase = data.get("workflow_phase", "")
-        if workflow:
-            wf_text = Text()
-            wf_text.append("Workflow\n", style="bold underline")
-            wf_text.append(f"  {workflow}", style="cyan")
-            if phase:
-                wf_text.append(f"  Phase: {phase}", style="yellow")
-            wf_text.append("\n")
-            yield Static(wf_text, id="dossier-workflow")
-
-        # Git info section
-        branch = data.get("git_branch", "")
-        pr_url = data.get("pr_url")
-        if branch or pr_url:
-            git_text = Text()
-            git_text.append("Git\n", style="bold underline")
-            if branch:
-                git_text.append(f"  Branch: {branch}\n")
-            if pr_url:
-                git_text.append(f"  PR: {pr_url}\n", style="cyan")
-            yield Static(git_text, id="dossier-git")
-
-        # Session notes section
-        notes = data.get("session_notes", "")
-        if notes:
-            notes_text = Text()
-            notes_text.append("Session Notes\n", style="bold underline")
-            notes_text.append(f"  {notes}\n")
-            yield Static(notes_text, id="dossier-notes")
-
-        # Keybinding hint
-        hint = Text.from_markup(
-            "\n[dim][Escape] Back  [Enter] Open PR[/dim]"
+        """Compose the dossier layout using StoryDetailWidget."""
+        yield VerticalScroll(
+            StoryDetailWidget(story_data=self._story_data),
+            id="detail-scroll",
         )
-        yield Static(hint, id="dossier-hint")
 
     def action_pop_screen(self) -> None:
         """Pop this screen off the stack."""

package/pennyfarthing-dist/pf/bikerack/story_detail_widget.py

@@ -0,0 +1,167 @@
+"""StoryDetailWidget — Reusable story detail view using native Textual widgets.
+
+Story 120-8: Story details and progress page enrichment with native Textual widgets.
+Renders story data inside Collapsible sections with Rule separators.
+Used by both StoryDetailScreen and ProgressPanel drill-through.
+"""
+
+from __future__ import annotations
+
+from typing import Any
+
+from rich.text import Text
+from textual.widget import Widget
+from textual.widgets import Collapsible, Rule, Static
+
+
+class StoryDetailWidget(Widget):
+    """Reusable story detail view with native Textual widgets.
+
+    Renders story data as Collapsible sections for ACs, Workflow, Git,
+    Context, and Session Notes. Absent sections are omitted (Tufte pattern).
+    """
+
+    def __init__(self, story_data: dict[str, Any] | None = None, **kwargs: Any) -> None:
+        super().__init__(**kwargs)
+        self._story_data: dict[str, Any] = story_data or {}
+
+    def compose(self):
+        """Compose the detail layout with header and collapsible sections."""
+        data = self._story_data
+
+        # Header — always present
+        yield self._build_header(data)
+
+        # Sections — only yielded when data exists
+        sections_yielded = 0
+
+        # Acceptance Criteria
+        acs = data.get("acceptance_criteria", [])
+        if acs:
+            if sections_yielded > 0:
+                yield Rule()
+            done_count = sum(1 for ac in acs if ac.get("done"))
+            yield self._build_ac_section(acs, done_count)
+            sections_yielded += 1
+
+        # Workflow
+        workflow = data.get("workflow", "")
+        if workflow:
+            if sections_yielded > 0:
+                yield Rule()
+            phase = data.get("workflow_phase", "")
+            yield self._build_workflow_section(workflow, phase)
+            sections_yielded += 1
+
+        # Git
+        branch = data.get("git_branch", "")
+        pr_url = data.get("pr_url")
+        if branch or pr_url:
+            if sections_yielded > 0:
+                yield Rule()
+            yield self._build_git_section(branch, pr_url)
+            sections_yielded += 1
+
+        # Context
+        has_epic_ctx = data.get("has_epic_context", False)
+        has_story_ctx = data.get("has_story_context", False)
+        if has_epic_ctx or has_story_ctx:
+            if sections_yielded > 0:
+                yield Rule()
+            yield self._build_context_section(has_epic_ctx, has_story_ctx)
+            sections_yielded += 1
+
+        # Session Notes
+        notes = data.get("session_notes", "")
+        if notes:
+            if sections_yielded > 0:
+                yield Rule()
+            yield self._build_notes_section(notes)
+            sections_yielded += 1
+
+    @staticmethod
+    def _build_header(data: dict[str, Any]) -> Static:
+        """Build the story header with title and metadata."""
+        title = data.get("title", "Unknown Story")
+        points = data.get("points", "?")
+        status = data.get("status", "unknown")
+        jira_key = data.get("jiraKey", "")
+        assignee = data.get("assignee", "")
+        priority = data.get("priority", "")
+
+        header_text = Text()
+        if jira_key:
+            header_text.append(f"{jira_key}", style="bold cyan")
+            header_text.append("  ")
+        header_text.append(f"{title}", style="bold")
+        if points and points != "?":
+            header_text.append(f"  {points}pt", style="dim")
+
+        meta_parts = [status]
+        if priority:
+            meta_parts.append(priority)
+        if assignee:
+            meta_parts.append(assignee)
+        separator = " \u00b7 "
+        header_text.append(f"\n{separator.join(meta_parts)}", style="dim")
+
+        return Static(header_text, id="detail-header")
+
+    @staticmethod
+    def _build_ac_section(
+        acs: list[dict[str, Any]], done_count: int
+    ) -> Collapsible:
+        """Build the Acceptance Criteria collapsible section."""
+        ac_text = Text()
+        for ac in acs:
+            check = "\u2713" if ac.get("done") else "\u25cb"
+            style = "green" if ac.get("done") else ""
+            ac_text.append(f"  {check} {ac.get('text', '')}\n", style=style)
+
+        return Collapsible(
+            Static(ac_text),
+            title=f"Acceptance Criteria  {done_count}/{len(acs)}",
+        )
+
+    @staticmethod
+    def _build_workflow_section(workflow: str, phase: str) -> Collapsible:
+        """Build the Workflow collapsible section."""
+        wf_text = Text()
+        wf_text.append(f"  [{workflow}]", style="cyan")
+        if phase:
+            wf_text.append(f"  Phase: {phase}", style="yellow")
+
+        return Collapsible(Static(wf_text), title="Workflow")
+
+    @staticmethod
+    def _build_git_section(branch: str, pr_url: str | None) -> Collapsible:
+        """Build the Git collapsible section."""
+        git_text = Text()
+        if branch:
+            git_text.append(f"  Branch: {branch}\n")
+        if pr_url:
+            git_text.append(f"  PR: {pr_url}\n", style="cyan")
+
+        return Collapsible(Static(git_text), title="Git")
+
+    @staticmethod
+    def _build_context_section(
+        has_epic: bool, has_story: bool
+    ) -> Collapsible:
+        """Build the Context collapsible section."""
+        ctx_text = Text()
+        if has_epic:
+            ctx_text.append("  \u2713 Epic context\n", style="green")
+        else:
+            ctx_text.append("  \u25cb Epic context\n", style="dim")
+        if has_story:
+            ctx_text.append("  \u2713 Story context\n", style="green")
+        else:
+            ctx_text.append("  \u25cb Story context\n", style="dim")
+
+        return Collapsible(Static(ctx_text), title="Context")
+
+    @staticmethod
+    def _build_notes_section(notes: str) -> Collapsible:
+        """Build the Session Notes collapsible section."""
+        return Collapsible(Static(f"  {notes}"), title="Session Notes")

package/pennyfarthing-dist/pf/bikerack/tui.py

@@ -21,17 +21,14 @@ from textual.command import Hit, Hits, Provider
 from textual.containers import Horizontal, VerticalScroll
 from textual.message import Message
 from textual.reactive import reactive
-from textual.widgets import Footer, Header, Static, Tab, Tabs
+from textual.widgets import Header, Static, Tab, Tabs
 
 from pf.bc.focus import get_last_panel, save_last_panel
 from pf.bikerack.audit_log_panel import AuditLogPanel
-from pf.bikerack.background_panel import BackgroundPanel
 from pf.bikerack.base_panel import get_panel_icon
-from pf.bikerack.changed_panel import ChangedPanel
-from pf.bikerack.context_meter_footer import ContextMeterFooter
+from pf.bikerack.context_meter_footer import StatusFooter
 from pf.bikerack.debug_panel import DebugPanel
 from pf.bikerack.diffs_panel import DiffsPanel
-from pf.bikerack.events import NavigateToFile
 from pf.bikerack.git_panel import GitPanel
 from pf.bikerack.progress_panel import ProgressPanel
 from pf.bikerack.sprint_panel import SprintPanel
@@ -79,8 +76,6 @@ PANEL_REGISTRY: list[tuple[str, str]] = [
     ("sprint", "Sprint"),
     ("git", "Git"),
     ("diffs", "Diffs"),
-    ("changed", "Changed"),
-    ("background", "Background"),
     ("audit-log", "Audit Log"),
     ("debug", "Debug"),
     ("progress", "Progress"),
@@ -93,9 +88,7 @@ PANEL_DISPLAY_NAMES: dict[str, str] = {
     "diffs": "Diffs",
     "todo": "Todo",
     "workflow": "Workflow",
-    "background": "Background",
     "audit-log": "Audit Log",
-    "changed": "Changed",
     "ac": "Acceptance Criteria",
     "debug": "Debug",
     "progress": "Progress",
@@ -110,33 +103,11 @@ _PANEL_KEYS = [key for key, _ in PANEL_REGISTRY]
 # Story 110-4: Named presets for common side-by-side views.
 SPLIT_PRESETS: dict[str, tuple[str, str]] = {
     "sprint+diffs": ("sprint", "diffs"),
-    "changed+diffs": ("changed", "diffs"),
+    "git+diffs": ("git", "diffs"),
     "progress+debug": ("progress", "debug"),
 }
 
 
-class BindingFooter(Footer):
-    """Footer subclass that exposes active binding text via render().
-
-    Textual's Footer uses compose() for visual content, so render() returns
-    Blank. This override makes binding descriptions available through
-    str(footer.render()) for programmatic inspection.
-    """
-
-    def render(self) -> Any:
-        try:
-            bindings = self.screen.active_bindings
-            parts: list[str] = []
-            for _, binding, _enabled, _tooltip in bindings.values():
-                if binding.show:
-                    parts.append(f"{binding.key}:{binding.description}")
-            if parts:
-                return " ".join(parts)
-        except Exception:
-            pass
-        return super().render()
-
-
 def _build_panel_tabs() -> list[Tab]:
     """Build Tab widgets for each panel in the registry."""
     tabs: list[Tab] = []
@@ -402,11 +373,6 @@ class BikeRackApp(App):
         height: auto;
         width: 1fr;
     }
-    #project-dir {
-        height: 1;
-        padding: 0 1;
-        color: $text-muted;
-    }
     Tabs {
         dock: top;
     }
@@ -419,8 +385,9 @@ class BikeRackApp(App):
     #connection-status {
         height: 1;
     }
-    ContextMeterFooter {
+    StatusFooter {
         height: 1;
+        dock: bottom;
     }
     #split-container {
         display: none;
@@ -437,18 +404,16 @@ class BikeRackApp(App):
     COMMANDS = App.COMMANDS | {PanelCommands}
 
     BINDINGS = [
-        Binding("q", "quit", "Quit"),
-        Binding("shift+s", "toggle_split", "Split"),
+        Binding("q", "quit", "Quit", show=False),
+        Binding("shift+s", "toggle_split", "Split", show=False),
         Binding("1", "switch_panel('sprint')", "Sprint", show=False),
         Binding("2", "switch_panel('git')", "Git", show=False),
         Binding("3", "switch_panel('diffs')", "Diffs", show=False),
-        Binding("4", "switch_panel('changed')", "Changed", show=False),
-        Binding("5", "switch_panel('background')", "Background", show=False),
-        Binding("6", "switch_panel('audit-log')", "Audit Log", show=False),
-        Binding("7", "switch_panel('debug')", "Debug", show=False),
-        Binding("8", "switch_panel('progress')", "Progress", show=False),
-        Binding("bracketright", "next_panel", "]Next"),
-        Binding("bracketleft", "prev_panel", "[Prev"),
+        Binding("4", "switch_panel('audit-log')", "Audit Log", show=False),
+        Binding("5", "switch_panel('debug')", "Debug", show=False),
+        Binding("6", "switch_panel('progress')", "Progress", show=False),
+        Binding("bracketright", "next_panel", "Next panel", show=False),
+        Binding("bracketleft", "prev_panel", "Prev panel", show=False),
         Binding("tab", "next_panel", show=False, priority=True),
         Binding("shift+tab", "prev_panel", show=False, priority=True),
         Binding("n", "next_diff_file", "Next file", show=False),
@@ -468,7 +433,7 @@ class BikeRackApp(App):
         self._focused_panel: str = "sprint"
         self._previous_panel: str | None = None
         self._programmatic_tab_count: int = 0
-        self._context_meter: ContextMeterFooter | None = None
+        self._status_footer: StatusFooter | None = None
         # Split-pane state (Story 110-4)
         self._split_mode: bool = False
         self._active_split_pane: str = "left"
@@ -481,7 +446,6 @@ class BikeRackApp(App):
         ).name
         yield Header()
         yield AgentHeader(id="agent-header")
-        yield Static(f"[dim]{project_dir_name}[/dim]", id="project-dir")
         yield Tabs(*_build_panel_tabs(), id="tab-bar")
         yield ConnectionStatus(
             STATE_DISPLAY[ConnectionState.DISCONNECTED],
@@ -491,17 +455,17 @@ class BikeRackApp(App):
             yield SprintPanel(client=self._client, id="panel-sprint")
             yield GitPanel(client=self._client, id="panel-git")
             yield DiffsPanel(client=self._client, id="panel-diffs")
-            yield ChangedPanel(client=self._client, id="panel-changed")
-            yield BackgroundPanel(client=self._client, id="panel-background")
             yield AuditLogPanel(client=self._client, id="panel-audit-log")
             yield DebugPanel(client=self._client, id="panel-debug")
             yield ProgressPanel(client=self._client, id="panel-progress")
         with Horizontal(id="split-container"):
             yield VerticalScroll(id="split-left")
             yield VerticalScroll(id="split-right")
-        self._context_meter = ContextMeterFooter(client=self._client)
-        yield self._context_meter
-        yield BindingFooter()
+        self._status_footer = StatusFooter(
+            project_dir=project_dir_name,
+            client=self._client,
+        )
+        yield self._status_footer
 
     async def on_mount(self) -> None:
         # Restore last panel or default to sprint
@@ -537,15 +501,6 @@ class BikeRackApp(App):
             self._client.subscribe("persona", self._handle_persona_message)
             self.run_worker(self._client.connect(), exclusive=True, name="ws-client")
 
-    def on_navigate_to_file(self, event: NavigateToFile) -> None:
-        """Handle NavigateToFile — switch to diffs and navigate to file."""
-        self.action_switch_panel("diffs")
-        try:
-            diffs = self.query_one("#panel-diffs", DiffsPanel)
-            diffs.navigate_to_file(event.path)
-        except Exception:
-            pass
-
     def action_switch_panel(self, key: str) -> None:
         """Switch to a panel by key."""
         if key not in _PANEL_KEYS:
@@ -573,9 +528,9 @@ class BikeRackApp(App):
         save_last_panel(key, project_dir=None)
         self._update_tab_bar(key)
 
-        # Refresh context meter on panel switch (110-12)
-        if self._context_meter is not None:
-            self._context_meter.request_refresh()
+        # Refresh status footer on panel switch
+        if self._status_footer is not None:
+            self._status_footer.request_refresh()
 
     def action_next_panel(self) -> None:
         """Cycle to the next panel, or toggle pane focus in split mode."""
@@ -890,6 +845,82 @@ class BikeRackApp(App):
 DEFAULT_PORT = 2898
 
 
+def get_watch_paths() -> list[Path]:
+    """Return directories to watch for Python file changes in dev mode."""
+    base = Path(__file__).resolve().parent.parent  # pf/
+    return [
+        base / "bikerack",
+        base / "bc",
+    ]
+
+
+def watch_filter(change: str, path: str) -> bool:
+    """Filter file change events — only accept .py files, ignore caches."""
+    if "__pycache__" in path:
+        return False
+    if path.endswith(".pyc"):
+        return False
+    if not path.endswith(".py"):
+        return False
+    return True
+
+
+def _run_with_reload(app: BikeRackApp, watch_paths: list[Path], filter_func) -> None:
+    """Run the app with file watching and auto-reload via watchfiles."""
+    import sys
+
+    from watchfiles import run_process
+
+    # Build the command that launches the TUI normally
+    cmd = [sys.executable, "-m", "pf.bikerack.tui"]
+    if hasattr(app, "_client") and app._client is not None:
+        cmd.extend(["--port", str(app._client._port)])
+
+    run_process(
+        *watch_paths,
+        target=cmd,
+        callback=lambda changes: None,
+        watch_filter=filter_func,
+    )
+
+
+def _patch_tgp_for_tmux() -> None:
+    """Monkey-patch textual-image's TGP writer to wrap Kitty graphics
+    escapes in tmux DCS passthrough sequences.
+
+    tmux doesn't forward Kitty APC escapes (\\x1b_G...\\x1b\\\\) natively.
+    They must be wrapped: \\x1bPtmux;<escaped>\\x1b\\\\
+    with any \\x1b in the payload doubled to \\x1b\\x1b.
+    """
+    try:
+        import textual_image.renderable.tgp as tgp
+    except ImportError:
+        return
+
+    _original_send = tgp._send_tgp_message
+
+    def _tmux_send(*, payload: str | None = None, **kwargs: int | str | None) -> None:
+        import sys
+
+        if not sys.__stdout__:
+            return
+
+        inner = [
+            tgp._TGP_MESSAGE_START,
+            ",".join(f"{k}={v}" for k, v in kwargs.items() if v is not None),
+            f";{payload}" if payload else "",
+            tgp._TGP_MESSAGE_END,
+        ]
+        sequence = "".join(inner)
+
+        # Wrap in tmux DCS passthrough: double any ESC inside the payload
+        wrapped = "\x1bPtmux;" + sequence.replace("\x1b", "\x1b\x1b") + "\x1b\\"
+        sys.__stdout__.write(wrapped)
+        sys.__stdout__.flush()
+
+    tgp._send_tgp_message = _tmux_send
+
+
 def main(
     port: int | None = None,
     project_dir: Path | None = None,
@@ -905,6 +936,13 @@ def main(
 
     portrait_resolver.detect_image_protocol()
 
+    # Patch textual-image to wrap Kitty graphics escapes in tmux passthrough.
+    # tmux doesn't natively forward Kitty's APC graphics escapes — they must
+    # be wrapped in DCS passthrough sequences (\x1bPtmux;...\x1b\\).
+    # See: https://github.com/tmux/tmux/wiki/FAQ
+    if os.environ.get("TMUX") and portrait_resolver.detect_image_protocol() == "kitty":
+        _patch_tgp_for_tmux()
+
     if port is None:
         if project_dir is not None:
             port_file = project_dir / ".bikerack-port"
@@ -923,6 +961,43 @@ def main(
     app.run()
 
 
+def dev_main(
+    port: int | None = None,
+    project_dir: Path | None = None,
+) -> None:
+    """Launch BikeRack TUI in dev mode with auto-reload on Python file changes.
+
+    Sets TEXTUAL env var for CSS hot-reload and uses watchfiles for Python reload.
+    """
+    os.environ["TEXTUAL"] = "devtools"
+
+    from pf.bikerack import portrait_resolver
+
+    portrait_resolver.detect_image_protocol()
+
+    if os.environ.get("TMUX") and portrait_resolver.detect_image_protocol() == "kitty":
+        _patch_tgp_for_tmux()
+
+    if port is None:
+        if project_dir is not None:
+            port_file = project_dir / ".bikerack-port"
+            if port_file.exists():
+                try:
+                    port = int(port_file.read_text().strip())
+                except (ValueError, OSError):
+                    port = DEFAULT_PORT
+            else:
+                port = DEFAULT_PORT
+        else:
+            port = DEFAULT_PORT
+
+    client = WheelHubClient(port=port)
+    app = BikeRackApp(client=client)
+
+    watch_paths = get_watch_paths()
+    _run_with_reload(app, watch_paths, watch_filter)
+
+
 if __name__ == "__main__":
     import argparse
 

package/pennyfarthing-dist/pf/bmad/cli.py

@@ -11,7 +11,6 @@ Provides:
 
 from __future__ import annotations
 
-import sys
 from pathlib import Path
 
 import click

package/pennyfarthing-dist/pf/bmad/importer.py

@@ -14,7 +14,6 @@ from typing import Any
 from pf.bmad.parser import (
     discover_bmad_epics,
     discover_bmad_stories,
-    map_bmad_to_pf,
 )
 from pf.common.config import get_project_root, load_pennyfarthing_config