@pennyfarthing/core 11.3.7 → 11.4.0

package/pennyfarthing-dist/scripts/portraits/generate-portraits.py

@@ -21,8 +21,8 @@ import argparse
 import os
 import sys
 import warnings
-from pathlib import Path
 from datetime import datetime
+from pathlib import Path
 
 # Suppress progress bars before importing torch/diffusers
 os.environ["TQDM_DISABLE"] = "1"
@@ -38,7 +38,7 @@ except ImportError:
 
 try:
     import torch
-    from diffusers import StableDiffusionXLPipeline, DPMSolverMultistepScheduler
+    from diffusers import DPMSolverMultistepScheduler, StableDiffusionXLPipeline
     from diffusers.utils import logging as diffusers_logging
     from PIL import Image
     HAS_TORCH = True
@@ -188,7 +188,7 @@ def generate_portrait_filename(short_name: str, ocean: dict) -> str:
 
 def parse_theme_file(theme_path: Path) -> dict:
     """Parse theme YAML file to extract visual prompts for each agent."""
-    with open(theme_path, "r", encoding="utf-8") as f:
+    with open(theme_path, encoding="utf-8") as f:
         data = yaml.safe_load(f)
 
     theme_metadata = data.get("theme", {})
@@ -310,7 +310,7 @@ def load_pipeline(engine_name: str):
         }
     else:
         model_id = engine["model_id"]
-        print(f"\nLoading SDXL model on MPS...")
+        print("\nLoading SDXL model on MPS...")
         print(f"  Model: {model_id}")
         print("  (First run downloads ~6.5GB model)")
 
@@ -369,14 +369,14 @@ def generate_portrait(pipeline_components: dict, prompt: str, engine_name: str,
         pipe = pipeline_components["pipe"]
         generator = torch.Generator().manual_seed(seed)
 
-        kwargs = dict(
-            prompt=prompt,
-            width=gen_size,
-            height=gen_size,
-            num_inference_steps=engine["num_inference_steps"],
-            guidance_scale=engine["guidance_scale"],
-            generator=generator,
-        )
+        kwargs = {
+            "prompt": prompt,
+            "width": gen_size,
+            "height": gen_size,
+            "num_inference_steps": engine["num_inference_steps"],
+            "guidance_scale": engine["guidance_scale"],
+            "generator": generator,
+        }
         if engine["supports_negative_prompt"]:
             kwargs["negative_prompt"] = "color, grayscale, photorealistic, blurry, deformed"
 
@@ -445,7 +445,7 @@ def main():
             print(f"  Searched: {CUSTOM_THEMES_DIR}")
             sys.exit(1)
 
-    print(f"Theme sources:")
+    print("Theme sources:")
     print(f"  Built-in: {BUILTIN_THEMES_DIR}")
     for src in pkg_sources:
         print(f"  Package:  {src}")

package/pennyfarthing-dist/scripts/workflow/check.py

@@ -22,13 +22,11 @@ Returns exit code 0 on all passing, non-zero on any failure.
 import argparse
 import asyncio
 import json
-import os
 import shutil
 import sys
 from dataclasses import dataclass, field
 from enum import Enum
 from pathlib import Path
-from typing import Optional
 
 
 class CheckStatus(Enum):
@@ -41,8 +39,8 @@ class CheckStatus(Enum):
 class CheckResult:
     name: str
     status: CheckStatus
-    command: Optional[str] = None
-    message: Optional[str] = None
+    command: str | None = None
+    message: str | None = None
 
 
 @dataclass
@@ -105,12 +103,12 @@ class Colors:
 COLORS = Colors()
 
 
-def print_pass(name: str, command: Optional[str] = None) -> None:
+def print_pass(name: str, command: str | None = None) -> None:
     suffix = f" ({command})" if command else ""
     print(f"  {COLORS.GREEN}[PASS]{COLORS.NC} {name}{suffix}")
 
 
-def print_fail(name: str, command: Optional[str] = None) -> None:
+def print_fail(name: str, command: str | None = None) -> None:
     suffix = f" ({command})" if command else ""
     print(f"  {COLORS.RED}[FAIL]{COLORS.NC} {name}{suffix}")
 

package/pennyfarthing-dist/scripts/workflow/complete-step.py

@@ -15,7 +15,7 @@ If --step N provided, completes that specific step instead of current step.
 import argparse
 import re
 import sys
-from datetime import datetime, timezone
+from datetime import UTC, datetime
 from pathlib import Path
 
 try:
@@ -231,7 +231,7 @@ def main() -> int:
     new_status = "completed" if completed_count >= step_count else "in_progress"
 
     # Update timestamp
-    now = datetime.now(timezone.utc).strftime("%Y-%m-%dT%H:%M:%SZ")
+    now = datetime.now(UTC).strftime("%Y-%m-%dT%H:%M:%SZ")
 
     # Update session file content
     content = re.sub(

package/pennyfarthing-dist/skills/skill-registry.yaml

@@ -23,6 +23,25 @@ skills:
     keywords: [react, reflection, planning, tool-use, chain-of-thought]
     allowed_tools: [Read, Glob, Grep, Task]  # Reference material - read-only
 
+  pf-bc:
+    name: pf-bc
+    description: Panel focus management for Cyclist — set, clear, save, and load panel layouts
+    category: tools
+    tags: [cyclist, panels, layout, bikerack]
+    version: "1.0.0"
+    prerequisites: []
+    examples:
+      - context: Focusing the Sprint panel
+        invocation: /bc sprint
+      - context: Saving current layout
+        invocation: /bc save my-layout
+      - context: Resetting panel focus
+        invocation: /bc reset
+    anti_patterns:
+      - Don't manually edit config.local.yaml to set panel focus — use this skill
+    related_skills: [pf-cyclist]
+    keywords: [bikerack, cyclist, panel, focus, layout, dockview]
+
   pf-changelog:
     name: pf-changelog
     description: Maintain changelogs following Keep a Changelog format with conventional commits

package/pennyfarthing-dist/workflows/release/steps/step-10-publish.md

@@ -1,20 +1,29 @@
 # Step 10: Publish to npm
 
 <purpose>
-Publish all Pennyfarthing packages to the npm registry. Verifies authentication, checks for conflicts, publishes each package, and verifies registry state.
+Publish all Pennyfarthing packages to the npm registry. Uses `pnpm publish` to
+resolve `workspace:*` dependencies to real version numbers. Verifies authentication,
+checks for conflicts, publishes each package, and verifies registry state.
 </purpose>
 
+<critical>
+**MUST use `pnpm publish`** — not `npm publish`. Packages use `workspace:*` protocol
+for inter-package dependencies. `pnpm publish` resolves these to actual version numbers
+at publish time. `npm publish` does NOT — it publishes the literal `workspace:*` string,
+which breaks consumer installs.
+</critical>
+
 <instructions>
 1. Verify npm authentication
 2. Check that versions aren't already published
-3. Publish @pennyfarthing/core (root package)
-4. Publish @pennyfarthing/cyclist
-5. Publish all theme packs
-6. Verify published versions on registry
+3. Publish @pennyfarthing/core (root package) via pnpm
+4. Publish workspace packages via pnpm
+5. Verify published versions and resolved dependencies on registry
 </instructions>
 
 <output>
-npm publish results for each package, plus registry verification.
+pnpm publish results for each package, plus registry verification including
+dependency resolution check (no workspace:* in published metadata).
 </output>
 
 ## Execution
@@ -69,7 +78,7 @@ fi
 
 ```bash
 echo "Publishing @pennyfarthing/core@{new_version}..."
-npm publish --access public $NPM_TAG
+pnpm publish --access public --no-git-checks $NPM_TAG
 ```
 
 ### 10.5 Publish Workspace Packages
@@ -79,17 +88,20 @@ for pkg_dir in packages/cyclist packages/shared packages/themes-*; do
     if [[ -f "$pkg_dir/package.json" ]]; then
         PKG_NAME=$(node -e "console.log(require('./$pkg_dir/package.json').name)")
         echo "Publishing $PKG_NAME@{new_version}..."
-        (cd "$pkg_dir" && npm publish --access public $NPM_TAG) || echo "WARNING: Failed to publish $PKG_NAME"
+        (cd "$pkg_dir" && pnpm publish --access public --no-git-checks $NPM_TAG) || echo "WARNING: Failed to publish $PKG_NAME"
     fi
 done
 ```
 
-### 10.6 Verify Published
+### 10.6 Verify Published (including workspace:* resolution)
 
 ```bash
 echo "=== Registry Verification ==="
 echo "Waiting 10s for registry propagation..."
 sleep 10
+
+echo ""
+echo "=== Version Check ==="
 for PKG_JSON in package.json packages/*/package.json; do
     PKG_NAME=$(node -e "console.log(require('./$PKG_JSON').name)")
     npm view "$PKG_NAME@{new_version}" version 2>/dev/null \
@@ -97,6 +109,26 @@ for PKG_JSON in package.json packages/*/package.json; do
         || echo "  ✗ $PKG_NAME@{new_version} NOT FOUND"
 done
 
+echo ""
+echo "=== Dependency Resolution Check ==="
+echo "Verifying no workspace:* references leaked to npm..."
+LEAKED=0
+for PKG_JSON in package.json packages/*/package.json; do
+    PKG_NAME=$(node -e "console.log(require('./$PKG_JSON').name)")
+    DEPS=$(npm view "$PKG_NAME@{new_version}" dependencies --json 2>/dev/null || echo "{}")
+    if echo "$DEPS" | grep -q "workspace:"; then
+        echo "  ✗ $PKG_NAME has workspace: refs in published dependencies!"
+        echo "$DEPS" | grep "workspace:"
+        LEAKED=1
+    else
+        echo "  ✓ $PKG_NAME — no workspace: refs"
+    fi
+done
+if [[ $LEAKED -eq 1 ]]; then
+    echo ""
+    echo "ERROR: workspace:* references leaked to npm. Deprecate affected versions and re-publish."
+fi
+
 if [[ "$IS_PRERELEASE" == "true" ]]; then
     echo ""
     echo "=== Dist-Tag Verification ==="

package/pennyfarthing-dist/workflows/tdd-tandem.yaml

@@ -7,12 +7,13 @@
 # Tandem pairings:
 #   - RED phase: TEA + Architect (file-watch) — Architect reviews test strategy
 #   - GREEN phase: Dev + Architect (file-watch) — Architect guides implementation patterns
+#   - VERIFY phase: TEA + Architect (file-watch) — Architect reviews implementation quality
 #   - REVIEW phase: Reviewer + PM (file-watch) — PM validates business requirements
 #
 # Compared to base tdd: Adds tandem observers on every working phase.
 # The extra context from partner agents helps catch architectural drift early.
 #
-# Flow: SM → TEA (+Architect) → Dev (+Architect) → Reviewer (+PM) → SM
+# Flow: SM → TEA (+Architect) → Dev (+Architect) → TEA (+Architect, verify) → Reviewer (+PM) → SM
 
 workflow:
   name: tdd-tandem
@@ -52,9 +53,21 @@ workflow:
         partner: architect
         scope: file-watch
 
+    - name: verify
+      agent: tea
+      input: [implementation, passing_tests]
+      output: [quality_verified]
+      gate:
+        file: gates/quality-pass
+        type: quality_pass
+        condition: Lint, typecheck, and all tests passing
+      tandem:
+        partner: architect
+        scope: file-watch
+
     - name: review
       agent: reviewer
-      input: [implementation, passing_tests]
+      input: [implementation, passing_tests, quality_verified]
       output: [approval]
       gate:
         file: gates/approval

package/packages/core/dist/workflow/__test_context_watch__/.session/.tandem-turn-counter

@@ -1 +0,0 @@
-5

package/packages/core/dist/workflow/__test_context_watch__/.session/95-6-session.md

@@ -1,3 +0,0 @@
-# Session
-## Dev Assessment
-Working on feature X

package/packages/core/dist/workflow/__test_context_watch__/.session/95-6-tandem-architect.md

@@ -1,6 +0,0 @@
-# Tandem Observations: 95-6
-**Observer:** architect (Will Bailey)
-**Phase:** implement
-**Started:** 2026-02-19T20:04:47.898Z
-
----

package/packages/core/dist/workflow/__test_file_watch__/.session/95-4-tandem-architect.md

@@ -1,6 +0,0 @@
-# Tandem Observations: 95-4
-**Observer:** architect (Will Bailey)
-**Phase:** implement
-**Started:** 2026-02-19T20:04:47.943Z
-
----

package/packages/core/dist/workflow/__test_file_watch__/workdir/trigger.ts

@@ -1 +0,0 @@
-export const trigger = true;

package/packages/core/dist/workflow/__test_tool_watch__/.session/95-5-tandem-architect.md

@@ -1,6 +0,0 @@
-# Tandem Observations: 95-5
-**Observer:** architect (Will Bailey)
-**Phase:** implement
-**Started:** 2026-02-19T20:04:48.283Z
-
----

package/packages/core/dist/workflow/__test_tool_watch__/.session/95-5-tandem-toolcalls.jsonl

@@ -1 +0,0 @@
-{"timestamp":"2026-02-19T20:04:48.284Z","toolName":"Bash","params":{"command":"npm test"},"resultPreview":"All 42 tests passed","resultSize":19}

package/pennyfarthing-dist/pf/bikerack/changed_panel.py

@@ -1,201 +0,0 @@
-"""ChangedPanel — Changed file list with status for BikeRack TUI.
-
-Story 103-14: Subscribes to /ws/git, extracts dirtyFiles from all repos,
-renders Rich table with file path, change type icon, and status.
-
-Story 110-1: Selectable file list with arrow navigation and Enter to navigate.
-"""
-
-from __future__ import annotations
-
-from typing import Any
-
-from rich.text import Text
-from textual.binding import Binding
-
-from pf.bikerack.base_panel import PANEL_ICONS, BasePanel
-
-# Status code → (icon, label, style)
-_STATUS_MAP: dict[str, tuple[str, str, str]] = {
-    "M": ("~", "Modified", "yellow"),
-    "A": ("+", "Added", "green"),
-    "D": ("-", "Deleted", "red"),
-    "?": ("?", "Untracked", "dim"),
-    "R": ("→", "Renamed", "cyan"),
-}
-
-_DEFAULT_STATUS: tuple[str, str, str] = ("·", "Changed", "yellow")
-
-
-def _parse_status(status: str) -> tuple[str, str, str]:
-    """Parse 2-char git status code into (icon, label, style).
-
-    First char = index (staging area), second char = working tree.
-    Uses the most significant non-space character.
-    """
-    if len(status) < 2:
-        return _STATUS_MAP.get(status[:1], _DEFAULT_STATUS)
-
-    idx, wt = status[0], status[1]
-
-    # Untracked: both chars are '?'
-    if idx == "?" and wt == "?":
-        return _STATUS_MAP["?"]
-
-    # Index change takes priority if present
-    if idx not in (" ", "?"):
-        return _STATUS_MAP.get(idx, _DEFAULT_STATUS)
-
-    # Working tree change
-    if wt not in (" ", "?"):
-        return _STATUS_MAP.get(wt, _DEFAULT_STATUS)
-
-    return _DEFAULT_STATUS
-
-
-class ChangedPanel(BasePanel):
-    """Changed file list panel.
-
-    Subscribes to the ``git`` WebSocket channel and renders
-    dirty files from all repos as a Rich table with file path,
-    change type icon, and status. Supports arrow-key selection
-    and Enter to navigate to diffs.
-    """
-
-    channel: str = "git"
-    panel_name: str = "Changed"
-    icon: str = PANEL_ICONS["changed"][0]
-    can_focus = True
-
-    BINDINGS = [
-        Binding("up", "select_prev_key", "Up"),
-        Binding("down", "select_next_key", "Down"),
-        Binding("enter", "select_file", "Select file"),
-    ]
-
-    def __init__(self, client=None, **kwargs):
-        super().__init__(client=client, **kwargs)
-        self._selected_index: int = 0
-        self._file_paths: list[str] = []
-
-    def handle_message(self, message: dict[str, Any] | None) -> None:
-        """Handle incoming message — build file path index then render."""
-        if message is not None:
-            self._build_file_paths(message)
-        super().handle_message(message)
-
-    def _build_file_paths(self, payload: dict[str, Any]) -> None:
-        """Extract flat list of file paths from repos payload."""
-        paths: list[str] = []
-        repos = payload.get("repos", [])
-        if isinstance(repos, list):
-            for repo in repos:
-                if not isinstance(repo, dict):
-                    continue
-                dirty_files = repo.get("dirtyFiles", [])
-                if not isinstance(dirty_files, list):
-                    continue
-                for f in dirty_files:
-                    if isinstance(f, dict):
-                        path = f.get("path", "")
-                        if path:
-                            paths.append(path)
-        self._file_paths = paths
-        if self._selected_index >= len(paths):
-            self._selected_index = max(0, len(paths) - 1)
-
-    def select_next(self) -> None:
-        """Move selection to the next file."""
-        if self._file_paths and self._selected_index < len(self._file_paths) - 1:
-            self._selected_index += 1
-            self._rerender()
-
-    def select_prev(self) -> None:
-        """Move selection to the previous file."""
-        if self._selected_index > 0:
-            self._selected_index -= 1
-            self._rerender()
-
-    def action_select_next_key(self) -> None:
-        """Binding action: move selection down."""
-        self.select_next()
-
-    def action_select_prev_key(self) -> None:
-        """Binding action: move selection up."""
-        self.select_prev()
-
-    def _rerender(self) -> None:
-        """Re-render panel with current payload after selection change."""
-        if self._last_payload:
-            try:
-                self.update(self.render_panel(self._last_payload))
-            except Exception:
-                pass
-
-    def get_selected_path(self) -> str | None:
-        """Return the currently selected file path, or None if empty."""
-        if not self._file_paths:
-            return None
-        if self._selected_index >= len(self._file_paths):
-            return None
-        return self._file_paths[self._selected_index]
-
-    def action_select_file(self) -> None:
-        """Post NavigateToFile event for the selected file."""
-        path = self.get_selected_path()
-        if path is not None:
-            from pf.bikerack.events import NavigateToFile
-
-            self.post_message(NavigateToFile(path=path))
-
-    def render_panel(self, payload: dict[str, Any]) -> Any:
-        """Render changed files grouped by repository with selection highlight."""
-        repos = payload.get("repos", [])
-        if not isinstance(repos, list):
-            return Text("No changed files", style="dim italic")
-
-        # Group files by repo
-        repo_files: dict[str, list[dict[str, Any]]] = {}
-        for repo in repos:
-            if not isinstance(repo, dict):
-                continue
-            repo_name = repo.get("name", "unknown")
-            dirty_files = repo.get("dirtyFiles", [])
-            if not isinstance(dirty_files, list) or not dirty_files:
-                continue
-            repo_files[repo_name] = [f for f in dirty_files if isinstance(f, dict)]
-
-        if not repo_files:
-            return Text("No changed files", style="dim italic")
-
-        from rich.console import Group as RichGroup
-
-        parts: list[Any] = []
-        flat_idx = 0
-        for repo_name, files in repo_files.items():
-            count = len(files)
-            label = "file" if count == 1 else "files"
-            header = Text()
-            header.append(repo_name, style="bold cyan")
-            header.append(f" ({count} {label})", style="dim")
-            parts.append(header)
-
-            for f in files:
-                status_code = f.get("status", "  ")
-                path = f.get("path", "")
-                icon, label_text, style = _parse_status(status_code)
-                is_selected = flat_idx == self._selected_index
-                line = Text()
-                if is_selected:
-                    line.append("› ", style="bold reverse")
-                else:
-                    line.append("  ")
-                line.append(icon, style=f"bold {style}")
-                line.append(f" {path}", style="bold cyan reverse" if is_selected else "cyan")
-                line.append(f"  {label_text}", style=style)
-                parts.append(line)
-                flat_idx += 1
-
-            parts.append(Text(""))  # spacer between repos
-
-        return RichGroup(*parts)