@pennyfarthing/core 11.3.7 → 11.4.0

package/packages/core/src/public/utils/messageFilters.ts

@@ -0,0 +1,128 @@
+/**
+ * Message Filtering Utilities
+ *
+ * Story MSSCI-12783 - Bug: Skill Content Displayed as User Message
+ *
+ * Functions to detect and filter skill content from user messages.
+ * Skill content is meant for Claude's context, not for display in the UI.
+ * Detected skill invocations are replaced with a short label (e.g. "reviewer")
+ * so the user sees what happened without the raw skill dump.
+ */
+
+/**
+ * Skill content markers that indicate a message contains skill/command output
+ * that should be filtered from user message display.
+ */
+const SKILL_CONTENT_MARKERS = [
+  '<command-message>',
+  '<command-name>',
+  'Base directory for this skill:',
+  'Launching skill:',
+] as const;
+
+/**
+ * Patterns that detect skill body content leaked as separate user messages.
+ * These are the raw skill markdown bodies that Claude Code sends as user messages
+ * after the initial <command-message> wrapper.
+ */
+const SKILL_BODY_PATTERNS = [
+  /^```bash\s*\npf agent start\b/,      // Agent activation bash block
+  /^pf agent start\b/,                   // Bare agent start command
+  /^<purpose>/,                           // Skill body XML tags
+  /^<when-to-use>/,
+  /^<execution>/,
+  /^<critical>\s*\n/,                     // Skill body starting with critical block
+] as const;
+
+/**
+ * Agent name to human-readable label mapping.
+ */
+const AGENT_LABELS: Record<string, string> = {
+  sm: 'Scrum Master',
+  tea: 'Test Engineer',
+  dev: 'Developer',
+  reviewer: 'Reviewer',
+  architect: 'Architect',
+  pm: 'Product Manager',
+  'tech-writer': 'Tech Writer',
+  'ux-designer': 'UX Designer',
+  devops: 'DevOps',
+  orchestrator: 'Orchestrator',
+  ba: 'Business Analyst',
+};
+
+/**
+ * Check if a message content string contains skill/command content
+ * that should be filtered from user message display.
+ *
+ * @param content - The message content to check
+ * @returns true if the content contains skill markers and should be filtered
+ */
+export function isSkillContent(content: string | null | undefined): boolean {
+  if (!content || typeof content !== 'string') {
+    return false;
+  }
+
+  if (SKILL_CONTENT_MARKERS.some(marker => content.includes(marker))) {
+    return true;
+  }
+
+  const trimmed = content.trimStart();
+  return SKILL_BODY_PATTERNS.some(pattern => pattern.test(trimmed));
+}
+
+/**
+ * Extract the skill/agent name from skill content for labeling.
+ * Returns a human-readable label like "Scrum Master" or the raw skill name.
+ */
+export function extractSkillLabel(content: string | null | undefined): string | null {
+  if (!content || typeof content !== 'string') return null;
+
+  // Match <command-name>/foo</command-name>
+  const cmdMatch = content.match(/<command-name>\/?([^<]+)<\/command-name>/);
+  if (cmdMatch) {
+    const name = cmdMatch[1].trim();
+    return AGENT_LABELS[name] || name;
+  }
+
+  // Match <command-message>foo</command-message>
+  const msgMatch = content.match(/<command-message>([^<]+)<\/command-message>/);
+  if (msgMatch) {
+    const name = msgMatch[1].trim();
+    return AGENT_LABELS[name] || name;
+  }
+
+  // Match pf agent start "foo"
+  const agentMatch = content.match(/pf agent start\s+"([^"]+)"/);
+  if (agentMatch) {
+    const name = agentMatch[1].trim();
+    return AGENT_LABELS[name] || name;
+  }
+
+  // Match "Launching skill: foo"
+  const launchMatch = content.match(/Launching skill:\s*(\S+)/);
+  if (launchMatch) {
+    const name = launchMatch[1].trim();
+    return AGENT_LABELS[name] || name;
+  }
+
+  return null;
+}
+
+/**
+ * Filter an array of messages to remove skill content from user messages.
+ * Only user-type messages are filtered; assistant and tool messages pass through.
+ *
+ * @param messages - Array of messages to filter
+ * @returns Filtered array with skill content user messages removed
+ */
+export function filterSkillContentMessages<T extends { type: string; content?: string }>(
+  messages: T[]
+): T[] {
+  return messages.filter(msg => {
+    if (msg.type !== 'user') {
+      return true;
+    }
+    return !isSkillContent(msg.content);
+  });
+}

package/packages/core/src/public/utils/slash-commands.ts

@@ -0,0 +1,341 @@
+/**
+ * Slash Commands Module
+ * Provides command definitions and filtering for tab completion (B-9.5)
+ *
+ * AUTO-GENERATED - Do not edit manually!
+ * Run: npm run build:commands (or npm run build)
+ * Source: pennyfarthing-dist/commands/*.md
+ */
+
+// ============================================================================
+// Types
+// ============================================================================
+
+export interface SlashCommand {
+  name: string;
+  description: string;
+}
+
+export type CommandFrequency = Record<string, number>;
+
+// ============================================================================
+// Command Definitions
+// ============================================================================
+
+/**
+ * Array of available slash commands with name and description
+ * Generated from pennyfarthing-dist/commands/ at build time
+ * Sorted alphabetically by name
+ */
+export const SLASH_COMMANDS: SlashCommand[] = [
+  {
+    "name": "/add",
+    "description": "Add files to context"
+  },
+  {
+    "name": "/bug",
+    "description": "Report a bug"
+  },
+  {
+    "name": "/clear",
+    "description": "Clear conversation history"
+  },
+  {
+    "name": "/compact",
+    "description": "Toggle compact mode"
+  },
+  {
+    "name": "/config",
+    "description": "Show configuration"
+  },
+  {
+    "name": "/cost",
+    "description": "Show session cost"
+  },
+  {
+    "name": "/doctor",
+    "description": "Check system health"
+  },
+  {
+    "name": "/help",
+    "description": "Show available commands"
+  },
+  {
+    "name": "/init",
+    "description": "Initialize CLAUDE.md"
+  },
+  {
+    "name": "/login",
+    "description": "Authenticate with Anthropic"
+  },
+  {
+    "name": "/logout",
+    "description": "Clear authentication"
+  },
+  {
+    "name": "/memory",
+    "description": "Edit CLAUDE.md memory"
+  },
+  {
+    "name": "/model",
+    "description": "Switch Claude model"
+  },
+  {
+    "name": "/permissions",
+    "description": "View/edit permissions"
+  },
+  {
+    "name": "/pf-architect",
+    "description": "System Architect - Technical design and architecture"
+  },
+  {
+    "name": "/pf-ba",
+    "description": "Business Analyst - Requirements discovery and stakeholder analysis"
+  },
+  {
+    "name": "/pf-benchmark",
+    "description": "Compare an agent's performance against a stored baseline"
+  },
+  {
+    "name": "/pf-benchmark-control",
+    "description": "Create control baseline for a scenario (shortcut for /benchmark control <agent>)"
+  },
+  {
+    "name": "/pf-brainstorming",
+    "description": "Structured problem-solving brainstorm session"
+  },
+  {
+    "name": "/pf-check",
+    "description": "Run quality gates (lint, type check, tests) before handoff"
+  },
+  {
+    "name": "/pf-chore",
+    "description": "Quick commit for small changes without full git-cleanup ceremony"
+  },
+  {
+    "name": "/pf-ci",
+    "description": "Detect and run CI locally"
+  },
+  {
+    "name": "/pf-dev",
+    "description": "Developer - Feature implementation and coding"
+  },
+  {
+    "name": "/pf-devops",
+    "description": "DevOps Engineer - Infrastructure and deployment automation"
+  },
+  {
+    "name": "/pf-docs",
+    "description": "Domain documentation management"
+  },
+  {
+    "name": "/pf-epic",
+    "description": "Epic lifecycle - start epics for development and close completed epics"
+  },
+  {
+    "name": "/pf-fix-blocker",
+    "description": "Quick alias for /patch - fix blocking issue during story work"
+  },
+  {
+    "name": "/pf-git",
+    "description": "Repository operations - status, cleanup, branches, and release management"
+  },
+  {
+    "name": "/pf-health-check",
+    "description": "Check Pennyfarthing installation health and apply updates"
+  },
+  {
+    "name": "/pf-help",
+    "description": "Context-aware help for Pennyfarthing commands, agents, and workflows"
+  },
+  {
+    "name": "/pf-job-fair",
+    "description": "Discover which characters in a theme excel at each role"
+  },
+  {
+    "name": "/pf-orchestrator",
+    "description": "Orchestrator - Coordinator of all agents and meta operations"
+  },
+  {
+    "name": "/pf-party-mode",
+    "description": "Creative brainstorming and multi-agent discussion"
+  },
+  {
+    "name": "/pf-patch",
+    "description": "Interrupt-driven bug fix during active story work"
+  },
+  {
+    "name": "/pf-permissions",
+    "description": "View and manage runtime permission grants - list, grant, revoke, or show details"
+  },
+  {
+    "name": "/pf-pm",
+    "description": "Product Manager - Strategic planning and prioritization"
+  },
+  {
+    "name": "/pf-prime",
+    "description": "Load essential project context at agent activation"
+  },
+  {
+    "name": "/pf-retro",
+    "description": "Facilitate a sprint retrospective"
+  },
+  {
+    "name": "/pf-reviewer",
+    "description": "Code Reviewer - Critical code review and quality enforcement"
+  },
+  {
+    "name": "/pf-session",
+    "description": "Session lifecycle - start new work and resume checkpoints"
+  },
+  {
+    "name": "/pf-setup",
+    "description": "/setup - Interactive Project Setup"
+  },
+  {
+    "name": "/pf-sm",
+    "description": "Scrum Master - Story coordination and sprint management"
+  },
+  {
+    "name": "/pf-solo",
+    "description": "Run a single agent on a scenario with absolute rubric scoring"
+  },
+  {
+    "name": "/pf-sprint",
+    "description": "Sprint status, backlog, and story management - check status, find work, archive completed stories"
+  },
+  {
+    "name": "/pf-standalone",
+    "description": "Wrap current changes into a standalone Jira story, branch, PR, and merge"
+  },
+  {
+    "name": "/pf-tea",
+    "description": "Test Engineer/Architect - Test strategy and TDD"
+  },
+  {
+    "name": "/pf-tech-writer",
+    "description": "Technical Writer - Documentation creation and maintenance"
+  },
+  {
+    "name": "/pf-theme",
+    "description": "Manage persona themes - list, show, set, create, or interactive wizard"
+  },
+  {
+    "name": "/pf-ux-designer",
+    "description": "UX Designer - User experience design and UI patterns"
+  },
+  {
+    "name": "/pf-work",
+    "description": "Resume work or start new - smart entry point that picks up where you left off"
+  },
+  {
+    "name": "/pf-workflow",
+    "description": "List available workflows, show current workflow details, and switch workflows mid-session. Use when checking available workflow types (TDD, trivial, agent-docs), viewing current workflow phase, switching to a different workflow pattern, or managing BikeLane stepped workflows."
+  },
+  {
+    "name": "/pr-comments",
+    "description": "View PR comments"
+  },
+  {
+    "name": "/review",
+    "description": "Start code review"
+  },
+  {
+    "name": "/status",
+    "description": "Show session status"
+  },
+  {
+    "name": "/terminal-setup",
+    "description": "Configure terminal"
+  },
+  {
+    "name": "/vim",
+    "description": "Toggle vim mode"
+  }
+].sort((a, b) => a.name.localeCompare(b.name));
+
+// ============================================================================
+// Command Frequency Tracking (localStorage)
+// ============================================================================
+
+const COMMAND_FREQUENCY_KEY = 'cyclist:command-frequency';
+
+/**
+ * Get command usage frequency map from localStorage
+ */
+export function getCommandFrequency(): CommandFrequency {
+  if (typeof localStorage === 'undefined') return {};
+  try {
+    const stored = localStorage.getItem(COMMAND_FREQUENCY_KEY);
+    return stored ? JSON.parse(stored) : {};
+  } catch {
+    return {};
+  }
+}
+
+/**
+ * Track command usage - increment frequency counter
+ */
+export function trackCommandUsage(commandName: string): void {
+  if (typeof localStorage === 'undefined') return;
+  const freq = getCommandFrequency();
+  freq[commandName] = (freq[commandName] || 0) + 1;
+  localStorage.setItem(COMMAND_FREQUENCY_KEY, JSON.stringify(freq));
+}
+
+/**
+ * Clear command frequency data
+ */
+export function clearCommandFrequency(): void {
+  if (typeof localStorage === 'undefined') return;
+  localStorage.removeItem(COMMAND_FREQUENCY_KEY);
+}
+
+// ============================================================================
+// Filtering Functions
+// ============================================================================
+
+/**
+ * Filter commands by prefix (case-insensitive)
+ * Sorted by usage frequency (most used first), then alphabetically
+ */
+export function filterCommands(prefix: string): SlashCommand[] {
+  const search = prefix.toLowerCase();
+  const freq = getCommandFrequency();
+
+  return SLASH_COMMANDS
+    .filter(cmd => cmd.name.toLowerCase().startsWith(search))
+    .sort((a, b) => {
+      const freqA = freq[a.name] || 0;
+      const freqB = freq[b.name] || 0;
+      // Sort by frequency descending, then alphabetically
+      if (freqB !== freqA) return freqB - freqA;
+      return a.name.localeCompare(b.name);
+    });
+}
+
+// ============================================================================
+// Trigger Detection
+// ============================================================================
+
+/**
+ * Check if position in text is a valid completion trigger
+ * Valid triggers: "/" at start of line or after whitespace
+ */
+export function isCompletionTrigger(text: string, position: number): boolean {
+  // Support both: position AT the "/" or position AFTER the "/"
+  let slashPos = position;
+  if (text[position] !== '/') {
+    slashPos = position - 1;
+  }
+
+  // "/" must be at slashPos
+  if (slashPos < 0 || text[slashPos] !== '/') return false;
+
+  // Valid at start of text
+  if (slashPos === 0) return true;
+
+  // Valid after whitespace
+  const charBefore = text[slashPos - 1];
+  return charBefore === ' ' || charBefore === '\n' || charBefore === '\t';
+}

package/packages/core/src/public/utils/subagent-display.ts

@@ -0,0 +1,146 @@
+/**
+ * Subagent Display Module
+ *
+ * Theme-aware subagent message display utilities.
+ * Story MSSCI-12776 - Theme-Aware Subagent Display Messages
+ *
+ * Transforms raw subagent prompts into friendly, themed messages
+ * using the current agent's Helper persona from the theme.
+ */
+
+// Types
+export interface TaskInput {
+  prompt?: string;
+  description?: string;
+  subagent_type?: string;
+}
+
+export interface Helper {
+  name: string;
+  style: string;
+  plural?: boolean;
+}
+
+// Cache for helper lookups
+const helperCache = new Map<string, Helper>();
+
+// =============================================================================
+// AC1: Parse subagent type from Task tool invocation
+// =============================================================================
+
+export function parseSubagentType(input: TaskInput): string | null {
+  return input.subagent_type ?? null;
+}
+
+export function parseSubagentDescription(input: TaskInput): string | null {
+  return input.description ?? null;
+}
+
+// =============================================================================
+// AC2: Look up current agent's helper persona from theme
+// =============================================================================
+
+// Theme data cache
+let themeDataCache: { agents: Array<{ role: string; helper?: Helper }> } | null = null;
+
+async function loadThemeData(): Promise<void> {
+  if (themeDataCache) return;
+
+  try {
+    const response = await fetch('/api/theme-agents/full');
+    if (response.ok) {
+      themeDataCache = await response.json();
+    }
+  } catch {
+    // Ignore errors, cache stays null
+  }
+}
+
+export async function getAgentHelper(agentRole: string): Promise<Helper | null> {
+  // Check cache first
+  const cacheKey = `agent:${agentRole}`;
+  if (helperCache.has(cacheKey)) {
+    return helperCache.get(cacheKey)!;
+  }
+
+  try {
+    // Load theme data if not cached
+    await loadThemeData();
+
+    if (themeDataCache?.agents) {
+      const agent = themeDataCache.agents.find(a => a.role === agentRole);
+      if (agent?.helper) {
+        helperCache.set(cacheKey, agent.helper);
+        return agent.helper;
+      }
+    }
+    return null;
+  } catch {
+    return null;
+  }
+}
+
+export async function getSubagentHelper(subagentType: string): Promise<Helper | null> {
+  // Check cache first
+  const cacheKey = `subagent:${subagentType}`;
+  if (helperCache.has(cacheKey)) {
+    return helperCache.get(cacheKey)!;
+  }
+
+  try {
+    // Load theme data if not cached
+    await loadThemeData();
+
+    // Subagent helpers may be defined differently - for now just return null
+    // The theme data structure may need to be extended to support this
+    return null;
+  } catch {
+    return null;
+  }
+}
+
+export function clearHelperCache(): void {
+  helperCache.clear();
+}
+
+// =============================================================================
+// AC3: Generate friendly message from subagent context
+// =============================================================================
+
+// Mapping of subagent types to human-friendly action descriptions
+const SUBAGENT_TYPE_MESSAGES: Record<string, string> = {
+  'testing-runner': 'Running tests',
+  'Explore': 'Exploring codebase',
+  'sm-setup': 'Setting up story',
+  'sm-finish': 'Finishing story',
+  'handoff': 'Handing off',
+  'workflow-status-check': 'Checking workflow status',
+  'general-purpose': 'Processing task',
+  'Plan': 'Planning implementation',
+  'Bash': 'Running commands',
+};
+
+export function generateFriendlyMessage(context: TaskInput, options?: { plural?: boolean }): string {
+  const verb = options?.plural ? 'are' : 'is';
+  // If we have a description, include it
+  const description = context.description;
+
+  // If we have a known subagent type, use its friendly message
+  const subagentType = context.subagent_type;
+  if (subagentType && SUBAGENT_TYPE_MESSAGES[subagentType]) {
+    const action = SUBAGENT_TYPE_MESSAGES[subagentType];
+    const lowerAction = action.charAt(0).toLowerCase() + action.slice(1);
+    if (description) {
+      return `${verb} ${lowerAction}: ${description}`;
+    }
+    return `${verb} ${lowerAction}`;
+  }
+
+  // Fall back to description if available
+  if (description) {
+    return description;
+  }
+
+  // Default fallback
+  return 'Working...';
+}