@pellux/goodvibes-tui 2.0.21 → 2.1.0

package/src/panels/diff-review-panel.ts

@@ -1,395 +0,0 @@
-// ---------------------------------------------------------------------------
-// DiffReviewPanel, comment-on-hunk review loop.
-//
-// Shows the current session's file changes per-file and hunk-boundaried, lets
-// the user select a hunk, attach a comment, and submit that comment to the
-// session as a steering message carrying structured context (file path, new-file
-// line range, and a short patch excerpt) so the model knows exactly what the
-// comment targets.
-//
-// Data source (labelled honestly in the panel): `git diff <base> -- <files>`,
-// where <files> is the set the SDK SessionChangeTracker recorded this session.
-// That is CURRENT working-tree content vs the base ref, not a turn-start
-// snapshot. The panel never presents a stale diff as current.
-// ---------------------------------------------------------------------------
-
-import type { Line } from '@pellux/goodvibes-sdk/platform/types';
-import { createEmptyLine } from '@pellux/goodvibes-sdk/platform/types';
-import { truncateDisplay } from '../utils/terminal-width.ts';
-import { GitService } from '@pellux/goodvibes-sdk/platform/git';
-import { BasePanel } from './base-panel.ts';
-import { DIFF_TONES, UI_TONES } from '../renderer/ui-primitives.ts';
-import {
-  buildEmptyState,
-  buildPanelWorkspace,
-  buildStyledPanelLine,
-  resolveScrollablePanelSection,
-  DEFAULT_PANEL_PALETTE,
-  extendPalette,
-} from './polish.ts';
-import { isPanelSearchBackspace, isPanelSearchCancel, isPanelSearchCommit, isPanelSearchPrintable } from './search-focus.ts';
-import { appendSteerText } from './fleet-tabs.ts';
-import {
-  parseReviewDiff,
-  flattenHunks,
-  hunkLineRange,
-  buildSteerMessage,
-  type ReviewFile,
-  type ReviewHunk,
-  type HunkComment,
-} from './diff-review-model.ts';
-
-const COLOR = extendPalette(DEFAULT_PANEL_PALETTE, {
-  addition: DIFF_TONES.add,
-  deletion: DIFF_TONES.del,
-  hunk: DIFF_TONES.hunk,
-} as const);
-
-/** A comment attached to a hunk plus whether it has already been steered to the session. */
-interface CommentState {
-  comment: string;
-  submitted: boolean;
-}
-
-function basename(p: string): string {
-  const parts = p.replace(/\\/g, '/').split('/');
-  return parts[parts.length - 1] ?? p;
-}
-
-export class DiffReviewPanel extends BasePanel {
-  public override isTransient = true;
-
-  private readonly workingDirectory: string;
-  private readonly getChangedFiles: (() => string[]) | undefined;
-  private files: ReviewFile[] = [];
-  private hunks: ReviewHunk[] = [];
-  private cursor = 0;
-  private scrollOffset = 0;
-  /** Comments keyed by `${fileIndex}:${hunkIndex}`. */
-  private comments = new Map<string, CommentState>();
-  private composing = false;
-  private draft = '';
-  private submitSteer: ((text: string) => void) | null = null;
-  /** Injected by the /review command: reverse-apply (reject) the given hunk via checkpoints.revertHunk. */
-  private revertHunk: ((hunk: ReviewHunk) => void) | null = null;
-  private sourceLabel = 'working tree vs HEAD (files edited this session)';
-  private status: string | null = null;
-  /** True once a load has completed (so the empty state can distinguish "no changes" from "not loaded"). */
-  private loaded = false;
-
-  constructor(
-    workingDirectory: string,
-    private readonly requestRender: () => void = () => {},
-    getChangedFiles?: () => string[],
-  ) {
-    super('review', 'Review', 'R', 'development');
-    this.workingDirectory = workingDirectory;
-    this.getChangedFiles = getChangedFiles;
-  }
-
-  // -------------------------------------------------------------------------
-  // Public API, driven by the /review command
-  // -------------------------------------------------------------------------
-
-  /** Wire the steering submit path (the /review command passes ctx.submitInput). */
-  setSubmit(fn: (text: string) => void): void {
-    this.submitSteer = fn;
-  }
-
-  /** Wire the hunk-revert path (the /review command drives checkpoints.revertHunk). */
-  setRevertHandler(fn: (hunk: ReviewHunk) => void): void {
-    this.revertHunk = fn;
-  }
-
-  /** Surface a status line (the revert flow reports conflicts/outcomes here). */
-  note(message: string): void {
-    this.status = message;
-    this.markDirty();
-    this.requestRender();
-  }
-
-  /** Re-load the session diff, used after a revert mutates the working tree. */
-  async refresh(): Promise<void> {
-    await this.loadSessionReview();
-    this.requestRender();
-  }
-
-  private keyFor(hunk: ReviewHunk): string {
-    return `${hunk.fileIndex}:${hunk.hunkIndex}`;
-  }
-
-  private currentHunk(): ReviewHunk | null {
-    return this.hunks[this.cursor] ?? null;
-  }
-
-  /** Adopt a parsed review set with an explicit provenance label. */
-  loadReview(files: ReviewFile[], sourceLabel: string): void {
-    this.files = files;
-    this.hunks = flattenHunks(files);
-    this.cursor = 0;
-    this.scrollOffset = 0;
-    this.comments.clear();
-    this.composing = false;
-    this.draft = '';
-    this.sourceLabel = sourceLabel;
-    this.loaded = true;
-    this.markDirty();
-  }
-
-  /**
-   * Load the session's changed files as a git diff against `ref` (default HEAD)
-   * and parse it into per-file hunks. Honest source: current working-tree
-   * content vs the base ref, restricted to files this session edited.
-   */
-  async loadSessionReview(ref = 'HEAD'): Promise<void> {
-    if (!GitService.isGitRepo(this.workingDirectory)) {
-      this.status = 'Not a git repository: no working-tree diff to review.';
-      this.loaded = true;
-      this.markDirty();
-      return;
-    }
-    const files = (this.getChangedFiles?.() ?? []).filter(Boolean);
-    const args = ['diff', ref, '--', ...files];
-    const wholeRepo = files.length === 0;
-    const proc = Bun.spawn(['git', ...(wholeRepo ? ['diff', ref] : args)], { stdout: 'pipe', stderr: 'pipe', cwd: this.workingDirectory });
-    const [raw, errText] = await Promise.all([new Response(proc.stdout).text(), new Response(proc.stderr).text()]);
-    const exitCode = await proc.exited;
-    if (exitCode !== 0) {
-      this.status = `git diff failed: ${errText.trim() || 'unknown error'}`;
-      this.loaded = true;
-      this.markDirty();
-      return;
-    }
-    const label = wholeRepo
-      ? `working tree vs ${ref} (no session-tracked files; showing whole working tree)`
-      : `working tree vs ${ref} (${files.length} file${files.length === 1 ? '' : 's'} edited this session)`;
-    this.loadReview(parseReviewDiff(raw), label);
-  }
-
-  // -------------------------------------------------------------------------
-  // Input
-  // -------------------------------------------------------------------------
-
-  handleInput(key: string): boolean {
-    if (this.composing) return this.handleComposerInput(key);
-    switch (key) {
-      case 'up': case 'k': this.moveCursor(-1); return true;
-      case 'down': case 'j': this.moveCursor(1); return true;
-      case 'tab': this.jumpFile(1); return true;
-      case '\x1b[Z': case 'shift-tab': case 'backtab': this.jumpFile(-1); return true;
-      case 'pageup': this.moveCursor(-5); return true;
-      case 'pagedown': this.moveCursor(5); return true;
-      case 'c': this.openComposer(); return true;
-      case 'x': this.clearComment(); return true;
-      case 'a': this.submitAll(); return true;
-      case 'r': this.rejectCurrent(); return true;
-      case 'enter': case 'return': this.submitCurrent(); return true;
-      default: return false;
-    }
-  }
-
-  private handleComposerInput(key: string): boolean {
-    if (isPanelSearchCancel(key)) {
-      this.composing = false;
-      this.draft = '';
-      this.status = 'Comment cancelled.';
-      this.markDirty();
-      return true;
-    }
-    if (isPanelSearchCommit(key)) {
-      const hunk = this.currentHunk();
-      const text = this.draft.trim();
-      if (hunk && text.length > 0) {
-        this.comments.set(this.keyFor(hunk), { comment: text, submitted: false });
-        this.status = 'Comment attached. Press Enter to send it, or a to send all.';
-      } else {
-        this.status = 'Empty comment discarded.';
-      }
-      this.composing = false;
-      this.draft = '';
-      this.markDirty();
-      return true;
-    }
-    if (isPanelSearchBackspace(key)) {
-      this.draft = this.draft.slice(0, -1);
-      this.markDirty();
-      return true;
-    }
-    if (key.length === 1 && (isPanelSearchPrintable(key) || key === '\r' || key === '\n')) {
-      this.draft = appendSteerText(this.draft, key);
-      this.markDirty();
-      return true;
-    }
-    return true; // swallow other keys while composing
-  }
-
-  private moveCursor(delta: number): void {
-    if (this.hunks.length === 0) return;
-    this.cursor = Math.max(0, Math.min(this.hunks.length - 1, this.cursor + delta));
-    this.markDirty();
-  }
-
-  private jumpFile(direction: number): void {
-    const cur = this.currentHunk();
-    if (!cur) return;
-    const targetFile = cur.fileIndex + direction;
-    const idx = this.hunks.findIndex((h) => h.fileIndex === targetFile);
-    if (idx >= 0) {
-      this.cursor = idx;
-      this.markDirty();
-    }
-  }
-
-  private openComposer(): void {
-    const hunk = this.currentHunk();
-    if (!hunk) return;
-    this.composing = true;
-    this.draft = this.comments.get(this.keyFor(hunk))?.comment ?? '';
-    this.status = null;
-    this.markDirty();
-  }
-
-  private clearComment(): void {
-    const hunk = this.currentHunk();
-    if (!hunk) return;
-    if (this.comments.delete(this.keyFor(hunk))) {
-      this.status = 'Comment removed.';
-      this.markDirty();
-    }
-  }
-
-  private steer(items: HunkComment[]): boolean {
-    if (!this.submitSteer) {
-      this.status = 'No session is wired to receive steering here.';
-      this.markDirty();
-      return false;
-    }
-    if (items.length === 0) {
-      this.status = 'No comment to send. Press c to write one.';
-      this.markDirty();
-      return false;
-    }
-    this.submitSteer(buildSteerMessage(items, this.sourceLabel));
-    for (const { hunk } of items) {
-      const state = this.comments.get(this.keyFor(hunk));
-      if (state) state.submitted = true;
-    }
-    this.status = items.length === 1
-      ? 'Comment sent to the session as a steering message.'
-      : `${items.length} comments sent to the session as one steering message.`;
-    this.markDirty();
-    this.requestRender();
-    return true;
-  }
-
-  private submitCurrent(): void {
-    const hunk = this.currentHunk();
-    if (!hunk) return;
-    const state = this.comments.get(this.keyFor(hunk));
-    if (!state || state.comment.length === 0) {
-      this.status = 'This hunk has no comment yet. Press c to write one.';
-      this.markDirty();
-      return;
-    }
-    this.steer([{ hunk, comment: state.comment }]);
-  }
-
-  /** Reject the selected hunk: hand it to the revert flow (preview → confirm → revertHunk). */
-  private rejectCurrent(): void {
-    const hunk = this.currentHunk();
-    if (!hunk) return;
-    if (!this.revertHunk) {
-      this.note('Hunk revert is not wired in this session.');
-      return;
-    }
-    this.revertHunk(hunk);
-  }
-
-  private submitAll(): void {
-    const items: HunkComment[] = [];
-    for (const hunk of this.hunks) {
-      const state = this.comments.get(this.keyFor(hunk));
-      if (state && !state.submitted && state.comment.length > 0) items.push({ hunk, comment: state.comment });
-    }
-    this.steer(items);
-  }
-
-  // -------------------------------------------------------------------------
-  // Render
-  // -------------------------------------------------------------------------
-
-  private hunkRow(hunk: ReviewHunk, isCursor: boolean, width: number): Line {
-    const state = this.comments.get(this.keyFor(hunk));
-    const marker = !state ? '   ' : state.submitted ? '[✓]' : '[c]';
-    const range = hunkLineRange(hunk);
-    const label = `${marker} ${basename(hunk.filePath)}:${range.start}-${range.end}  +${hunk.added} -${hunk.removed}`;
-    return buildStyledPanelLine(width, [{
-      text: truncateDisplay(`${isCursor ? '▸ ' : '  '}${label}`, width),
-      fg: state?.submitted ? COLOR.addition : isCursor ? COLOR.value : COLOR.dim,
-      bg: isCursor ? UI_TONES.bg.selected : undefined,
-      bold: isCursor,
-    }]);
-  }
-
-  private detailLines(hunk: ReviewHunk, width: number): Line[] {
-    const lines: Line[] = [];
-    lines.push(buildStyledPanelLine(width, [{ text: truncateDisplay(` ${hunk.filePath}`, width), fg: COLOR.value, bold: true }]));
-    lines.push(buildStyledPanelLine(width, [{ text: truncateDisplay(` ${hunk.header}`, width), fg: COLOR.hunk }]));
-    for (const raw of hunk.bodyLines.slice(0, 8)) {
-      const fg = raw.startsWith('+') ? COLOR.addition : raw.startsWith('-') ? COLOR.deletion : COLOR.dim;
-      lines.push(buildStyledPanelLine(width, [{ text: truncateDisplay(` ${raw}`, width), fg }]));
-    }
-    const state = this.comments.get(this.keyFor(hunk));
-    if (this.composing) {
-      lines.push(buildStyledPanelLine(width, [{ text: truncateDisplay(` comment> ${this.draft}_`, width), fg: COLOR.value, bold: true }]));
-    } else if (state) {
-      const tag = state.submitted ? '(sent)' : '(unsent)';
-      lines.push(buildStyledPanelLine(width, [{ text: truncateDisplay(` comment ${tag}: ${state.comment}`, width), fg: state.submitted ? COLOR.addition : COLOR.value }]));
-    }
-    return lines;
-  }
-
-  private footer(width: number): Line {
-    const hints = this.composing
-      ? ' Enter attach  Esc cancel'
-      : ' ↑/↓ hunk  Tab file  c comment  Enter send  a send all  r revert  x clear';
-    const text = this.status ? `${hints}  •  ${this.status}` : hints;
-    return buildStyledPanelLine(width, [{ text: truncateDisplay(text, width), fg: COLOR.dim, bg: COLOR.sectionBg }], { fillBg: COLOR.sectionBg });
-  }
-
-  render(width: number, height: number): Line[] {
-    return this.trackedRender(() => {
-      if (height <= 0 || width <= 0) return [];
-      if (this.hunks.length === 0) {
-        const detail = this.loaded
-          ? (this.status ?? 'No changes to review. Files edited this session appear here as hunks.')
-          : 'Loading session changes…';
-        return buildPanelWorkspace(width, height, {
-          title: 'Review',
-          palette: COLOR,
-          sections: [{ title: 'Review', lines: buildEmptyState(width, ' Nothing to review yet.', detail, [{ command: '/review', summary: 'load this session\'s file changes as commentable hunks' }], COLOR) }],
-        });
-      }
-
-      const hunk = this.currentHunk();
-      const listLines = this.hunks.map((h, i) => this.hunkRow(h, i === this.cursor, width));
-      const section = resolveScrollablePanelSection(width, height, {
-        palette: COLOR,
-        footerLines: [this.footer(width)],
-        beforeSections: [{ title: `Selected hunk (${this.sourceLabel})`, lines: hunk ? this.detailLines(hunk, width) : [] }],
-        section: { title: `Hunks (${this.cursor + 1}/${this.hunks.length})`, scrollableLines: listLines, scrollOffset: this.scrollOffset, selectedIndex: this.cursor, minRows: 1 },
-      });
-      this.scrollOffset = section.scrollOffset;
-
-      return buildPanelWorkspace(width, height, {
-        title: 'Review',
-        palette: COLOR,
-        footerLines: [this.footer(width)],
-        sections: [
-          { title: `Selected hunk (${this.sourceLabel})`, lines: hunk ? this.detailLines(hunk, width) : [createEmptyLine(width)] },
-          { title: section.section.title, lines: section.section.lines },
-        ],
-      });
-    });
-  }
-}

package/src/panels/expandable-list-panel.ts

@@ -1,189 +0,0 @@
-import type { Line } from '@pellux/goodvibes-sdk/platform/types';
-import { createEmptyLine } from '@pellux/goodvibes-sdk/platform/types';
-import { ScrollableListPanel } from './scrollable-list-panel.ts';
-import {
-  buildKeyboardHints,
-  buildPanelWorkspace,
-  resolveScrollablePanelSection,
-} from './polish.ts';
-
-// ---------------------------------------------------------------------------
-// ExpandableListPanel<T>
-// ---------------------------------------------------------------------------
-
-/**
- * A list panel with a built-in master → detail drill-down.
- *
- * Encapsulates the collapse/expand + detail-view pattern that was previously
- * hand-rolled in git, tool-inspector, agent-inspector, approval, and wrfc
- * panels: a scrollable list where pressing Enter/→ on a row opens a scrollable
- * detail view for that item, and Esc/← returns to the list.
- *
- * Subclasses implement (in addition to the `ScrollableListPanel` contract):
- *   - `getDetailLines(item, width)`, the detail body for the expanded item.
- *
- * Optionally override:
- *   - `getDetailTitle(item)`, detail-view title (defaults to `this.name`).
- *   - `getListHints()` / `getDetailHints()`, footer keyboard hints per mode.
- *   - `renderListView(width, height)`, the list-mode body (defaults to
- *     `renderList` with the list hints footer).
- *
- * Do NOT override `render()`; it dispatches between list and detail modes.
- */
-export abstract class ExpandableListPanel<T> extends ScrollableListPanel<T> {
-  /** The item currently expanded into the detail view, or null in list mode. */
-  protected expandedItem: T | null = null;
-  /** First visible row of the detail view. */
-  protected detailScroll = 0;
-
-  /** Render the detail body lines for an expanded item. */
-  protected abstract getDetailLines(item: T, width: number): readonly Line[];
-
-  /** Title shown above the detail view. */
-  protected getDetailTitle(_item: T): string {
-    return this.name;
-  }
-
-  /** Keyboard hints shown in list mode. */
-  protected getListHints(): ReadonlyArray<{ keys: string; label: string }> {
-    return [
-      { keys: '↑/↓', label: 'move' },
-      { keys: 'Enter', label: 'open' },
-    ];
-  }
-
-  /** Keyboard hints shown in detail mode. */
-  protected getDetailHints(): ReadonlyArray<{ keys: string; label: string }> {
-    return [
-      { keys: '↑/↓', label: 'scroll' },
-      { keys: 'Esc', label: 'back' },
-    ];
-  }
-
-  protected isExpanded(): boolean {
-    return this.expandedItem !== null;
-  }
-
-  /** Expand the currently selected item into the detail view. */
-  protected expandSelected(): void {
-    const items = this.getItems();
-    const item = items[this.selectedIndex];
-    if (item === undefined) return;
-    this.expandedItem = item;
-    this.detailScroll = 0;
-    this.needsRender = true;
-  }
-
-  /** Collapse the detail view back to the list. */
-  protected collapse(): void {
-    if (this.expandedItem === null) return;
-    this.expandedItem = null;
-    this.detailScroll = 0;
-    this.needsRender = true;
-  }
-
-  // -------------------------------------------------------------------------
-  // Input
-  // -------------------------------------------------------------------------
-
-  handleInput(key: string): boolean {
-    if (this.expandedItem !== null) {
-      // Detail mode: scroll the detail body; Esc/← collapses.
-      if (this.lastError !== null) this.clearError();
-      switch (key) {
-        case 'escape':
-        case 'left':
-        case 'h':
-          this.collapse();
-          return true;
-        case 'up':
-        case 'k':
-          this.detailScroll = Math.max(0, this.detailScroll - 1);
-          this.needsRender = true;
-          return true;
-        case 'down':
-        case 'j':
-          this.detailScroll += 1;
-          this.needsRender = true;
-          return true;
-        case 'pageup':
-          this.detailScroll = Math.max(0, this.detailScroll - this.getPageSize());
-          this.needsRender = true;
-          return true;
-        case 'pagedown':
-          this.detailScroll += this.getPageSize();
-          this.needsRender = true;
-          return true;
-        case 'home':
-        case 'g':
-          this.detailScroll = 0;
-          this.needsRender = true;
-          return true;
-        default:
-          return false;
-      }
-    }
-
-    // List mode: Enter/→ expands; everything else is list navigation.
-    if (key === 'enter' || key === 'return' || key === 'right' || key === 'l') {
-      if (this.getItems().length === 0) return false;
-      this.expandSelected();
-      return true;
-    }
-    return super.handleInput(key);
-  }
-
-  handleScroll(deltaRows: number): boolean {
-    if (this.expandedItem !== null) {
-      const rows = Math.trunc(deltaRows);
-      if (rows === 0) return false;
-      this.detailScroll = Math.max(0, this.detailScroll + rows);
-      this.needsRender = true;
-      return true;
-    }
-    return super.handleScroll(deltaRows);
-  }
-
-  // -------------------------------------------------------------------------
-  // Render
-  // -------------------------------------------------------------------------
-
-  render(width: number, height: number): Line[] {
-    if (this.expandedItem !== null) {
-      return this.renderDetailView(width, height, this.expandedItem);
-    }
-    return this.renderListView(width, height);
-  }
-
-  /** List-mode body. Override for a custom header; defaults to renderList. */
-  protected renderListView(width: number, height: number): Line[] {
-    return this.renderList(width, height, { hints: this.getListHints() });
-  }
-
-  /** Detail-mode body, scrollable detail lines + standardized chrome. */
-  protected renderDetailView(width: number, height: number, item: T): Line[] {
-    this.needsRender = false;
-    const palette = this.getPalette();
-    const detailLines = [...this.getDetailLines(item, width)];
-    const footer = buildKeyboardHints(width, this.getDetailHints(), palette);
-
-    const resolved = resolveScrollablePanelSection(width, height, {
-      palette,
-      afterSections: [{ lines: [footer] }],
-      section: {
-        scrollableLines: detailLines,
-        scrollOffset: this.detailScroll,
-        appendWindowSummary: detailLines.length > 5 ? { dimColor: palette.dim } : undefined,
-      },
-    });
-    this.detailScroll = resolved.scrollOffset;
-
-    const lines = buildPanelWorkspace(width, height, {
-      title: this.getDetailTitle(item),
-      sections: [resolved.section, { lines: [footer] }],
-      palette,
-    });
-    while (lines.length < height) lines.push(createEmptyLine(width));
-    return lines.slice(0, height);
-  }
-}

package/src/panels/fleet-deep-link.ts

@@ -1,31 +0,0 @@
-// ---------------------------------------------------------------------------
-// fleet-deep-link.ts, item 4.
-//
-// PanelManager.open('fleet', pane, target) hands FleetPanel a
-// PanelDeepLinkTarget (a process id + optional ProcessKind) so a cross-panel
-// jump (the work-plan modal's 'i'/'w' agent/WRFC-chain jumps, the docs
-// modal's tools-tab Enter) can select + reveal a SPECIFIC node instead of
-// just opening Fleet generically. Extracted from fleet-panel.ts (already at
-// the 800-line architecture cap) so the panel stays a thin caller.
-//
-// `kind`, when given, must also match: ProcessNode ids are unique per the
-// SDK's own contract, so this is a cheap extra honesty check, not the
-// primary lookup key. Reveal is "free" once selectedIndex is set,
-// ScrollableListPanel's render-time scroll-window resolution keeps the
-// selected row visible, so FleetPanel.receiveDeepLink does not need its own
-// scroll math.
-//
-// A target that isn't found (pruned, killed, never existed, or a domain,
-// like the docs Tools tab's static tool definitions, that has no
-// corresponding fleet node at all) resolves to -1; the caller degrades
-// honestly (FleetPanel.setError('node no longer present.')) rather than
-// silently landing on an unrelated row.
-// ---------------------------------------------------------------------------
-
-import type { PanelDeepLinkTarget } from './types.ts';
-import type { FleetTreeRow } from './fleet-read-model.ts';
-
-/** The row index matching `target`'s id (+ kind, if given), or -1. Pure, no I/O, no mutation. */
-export function resolveFleetDeepLinkIndex(rows: readonly FleetTreeRow[], target: PanelDeepLinkTarget): number {
-  return rows.findIndex((row) => row.node.id === target.id && (!target.kind || row.node.kind === target.kind));
-}