@pellux/goodvibes-tui 2.0.21 → 2.1.0

package/src/tools/wrfc-agent-guard.ts

@@ -1,5 +1,5 @@
 import type { Tool } from '@pellux/goodvibes-sdk/platform/types';
-import type { ToolRegistry } from '@pellux/goodvibes-sdk/platform/tools';
+import { askDelegatesToAgent, askForbidsWrites, type ToolRegistry } from '@pellux/goodvibes-sdk/platform/tools';
 
 type AgentToolArgs = {
   readonly mode?: unknown;
@@ -92,6 +92,18 @@ export function normalizeWrfcAgentToolInvocation(args: AgentToolArgs, options: W
   const lastUserMessage = cleanText(options.getLastUserMessage?.() ?? null);
   const trace = options.onTrace;
   if (args.mode === 'spawn') {
+    // The user's own "do not modify files" outranks every promotion below: a
+    // write-review-fix chain's fix phase writes files, so a read-only ask
+    // (a review, an audit) runs as a plain agent with the task the model
+    // delegated. The SDK applies the same rule (rootSpawnIsReadOnlyAsk).
+    if (askForbidsWrites(lastUserMessage || cleanText(args.task))) {
+      trace?.({
+        kind: 'spawn-suppressed-wrfc',
+        reason: 'the request forbids writing files',
+        task: cleanText(args.task) || '(no task)',
+      });
+      return { ...args, reviewMode: 'none', dangerously_disable_wrfc: true };
+    }
     if (shouldRouteSpawnToWrfc(args)) {
       const reason = resolveSpawnWrfcReason(args);
       trace?.({
@@ -264,8 +276,16 @@ function isReadOnlyTask(text: string): boolean {
   return /^\s*(?:inspect|research|read|find|list|summarize|analy[sz]e|explain|report|investigate|document|describe|audit|evaluate|assess|check|compare|tell|show)\b/i.test(text);
 }
 
+/**
+ * The chain's task: the user's own words, unless those words are an
+ * instruction to delegate ("Spawn one agent to …"). The agent being spawned
+ * IS that delegation, so its task is the work the model extracted; handed the
+ * delegation instruction itself, an agent without the agent tool can only fail.
+ */
 function selectAuthoritativeTask(candidate: unknown, lastUserMessage: string): string {
-  return lastUserMessage || cleanText(candidate);
+  const delegated = cleanText(candidate);
+  if (lastUserMessage && askDelegatesToAgent(lastUserMessage) && delegated) return delegated;
+  return lastUserMessage || delegated;
 }
 
 function uniqueStrings(groups: readonly unknown[]): string[] | undefined {

package/src/utils/format-duration.ts

@@ -1,22 +1,18 @@
 /**
- * Shared ms-duration formatters for the panel layer.
+ * Shared ms-duration formatters for the view layer.
  *
  * Two families are exported, each matching a distinct behavior cluster.
  * DO NOT replace these with formatElapsed from utils/format-elapsed.ts,
  * formatElapsed floors to integer seconds and lacks the null/'?ms' guards
- * that the latency panels require.
+ * that the latency views require.
  *
- * (the purge): formatShortDuration (used only by incident-review-panel
- * and eval-panel, both removed, RETIRE-INTO-FLEET and DELETE respectively)
- * was removed as a genuinely orphaned export, no remaining caller anywhere
- * in src/.
+ * formatShortDuration was removed as a genuinely orphaned export, with no
+ * remaining caller anywhere in src/.
  */
 
 /**
  * Format a latency value in milliseconds with sub-second precision.
  *
- * Used by: provider-health-panel
- *
  *   ms <= 0     → 'n/a'
  *   ms >= 10000 → '12.3s'    (one decimal)
  *   ms >= 1000  → '1.23s'   (two decimals)

package/src/utils/splash-lines.ts

@@ -23,8 +23,16 @@ const TAGLINE = '[ ｇｏｏｄ ｖｉｂｅｓ ・ Ａ Ｉ ・ いい雰囲気
 const versionLine = (version: string) =>
   `　✦　v${version}　█　terminal AI assistant　█　自動ｺｰﾄﾞ 　✦`;
 
+/**
+ * The splash wordmark gradient, protected: it is part of the GoodVibes mark,
+ * identical under every theme and mode, and must never be routed through the
+ * theme tokens. conversation-rendering.ts interpolates start to end across
+ * each wordmark row.
+ */
+export const SPLASH_GRADIENT = Object.freeze({ start: '#00ffff', end: '#d000ff' } as const);
+
 /** Fixed hint line, the three primary shell entry points. */
-const HINT_LINE = 'Ctrl+P panels  /  ? help  /  F2 fleet';
+const HINT_LINE = 'Ctrl+P commands  /  ? help  /  F2 agents';
 
 export interface SplashOptions {
   workingDir?: string;

package/src/utils/terminal-width.ts

@@ -93,6 +93,13 @@ export function getDisplayWidth(text: string): number {
       // corrupting the following text (the "✕t" glitch on the steer error line).
       code === 0x2715 ||
       code === 0x2716 ||
+      // ✦ (0x2726, the splash star and the modal group marker), ⏎ (0x23ce)
+      // and ⌫ (0x232b, keycap glyphs) have no emoji presentation, so
+      // terminals draw them one cell wide too; the block rules below would
+      // otherwise count them as 2 and shift everything after them.
+      code === 0x2726 ||
+      code === 0x23ce ||
+      code === 0x232b ||
       code === 0x2022 ||
       code === 0x258d ||
       (code >= 0x2500 && code <= 0x257f)
@@ -272,6 +279,55 @@ export function wrapText(text: string, width: number): string[] {
   return lines;
 }
 
+/** Columns one tab takes in a drawn body; the same two spaces a diff body uses (changes-modal.ts wrapTokens). */
+export const BODY_TAB_WIDTH = 2;
+
+/** Replace every tab with BODY_TAB_WIDTH spaces, so width math and drawing agree. */
+export function expandTabs(text: string): string {
+  return text.includes('\t') ? text.replace(/\t/g, ' '.repeat(BODY_TAB_WIDTH)) : text;
+}
+
+/**
+ * Wrap one body line (a file line, command output) to `width` cells without
+ * losing its layout: tabs expand to spaces, a line that fits is returned
+ * exactly as it is (leading indentation and inner runs of spaces kept), and a
+ * longer line wraps at spaces with every continuation row indented like the
+ * first. A word wider than the room left is cut hard. Every returned row is
+ * at most `width` cells.
+ */
+export function wrapPreservingIndent(text: string, width: number): string[] {
+  const out: string[] = [];
+  for (const raw of expandTabs(text).split('\n')) {
+    const line = raw.replace(/\s+$/, '');
+    if (getDisplayWidth(line) <= width) { out.push(line); continue; }
+    const indentText = /^ */.exec(line)![0];
+    // Deep indentation leaves no room: continuation rows start at the left edge.
+    const indent = indentText.length <= Math.floor(width / 2) ? indentText : '';
+    let rest = Array.from(line.slice(indentText.length));
+    let prefix = indentText.length <= width - 1 ? indentText : '';
+    while (rest.length > 0) {
+      const avail = Math.max(1, width - prefix.length);
+      // Longest run of `rest` that fits, preferring to break after a space.
+      let cut = 0;
+      let used = 0;
+      let lastSpace = -1;
+      for (let i = 0; i < rest.length; i++) {
+        const w = getDisplayWidth(rest[i]!);
+        if (used + w > avail) break;
+        used += w;
+        cut = i + 1;
+        if (rest[i] === ' ') lastSpace = i + 1;
+      }
+      const at = cut === rest.length ? cut : lastSpace > 0 ? lastSpace : Math.max(1, cut);
+      out.push((prefix + rest.slice(0, at).join('')).replace(/\s+$/, ''));
+      rest = rest.slice(at);
+      while (rest[0] === ' ') rest.shift();
+      prefix = indent;
+    }
+  }
+  return out;
+}
+
 export function interpolateColor(startHex: string, endHex: string, factor: number): string {
   const parse = (hex: string) => {
     const r = parseInt(hex.slice(1, 3), 16);

package/src/verification/verification-ledger.ts

@@ -1,4 +1,4 @@
-import { readFileSync, readdirSync } from 'node:fs';
+import { readFileSync } from 'node:fs';
 import { join } from 'node:path';
 import { CONFIG_SCHEMA } from '@pellux/goodvibes-sdk/platform/config';
 import { FEATURE_SETTINGS } from '@pellux/goodvibes-sdk/platform/runtime/state';
@@ -564,15 +564,17 @@ function listSlashCommands(): string[] {
   return registry.getAll().map((command) => command.name);
 }
 
-function countBuiltinPanels(root: string): number {
-  const builtinDir = join(root, 'src', 'panels', 'builtin');
-  let count = 0;
-  for (const file of readdirSync(builtinDir)) {
-    if (!file.endsWith('.ts')) continue;
-    const text = readFileSync(join(builtinDir, file), 'utf8');
-    count += [...text.matchAll(/registerType\(\s*\{\s*id:\s*['"][^'"]+['"]/g)].length;
-  }
-  return count;
+/**
+ * Built-in modals and views: every config-modal surface builtin-modals.ts
+ * registers, plus every kit view modal the shell's view openers construct
+ * (Agents, Usage, Changes, Notifications, the masked password prompt).
+ */
+function countBuiltinModals(root: string): number {
+  const surfaces = readFileSync(join(root, 'src', 'views', 'builtin-modals.ts'), 'utf8');
+  const openers = readFileSync(join(root, 'src', 'shell', 'view-openers.ts'), 'utf8');
+  const surfaceCount = [...surfaces.matchAll(/registerModalSurface\(/g)].length;
+  const viewModals = new Set([...openers.matchAll(/new ([A-Za-z]+Modal)\(/g)].map((m) => m[1]));
+  return surfaceCount + viewModals.size;
 }
 
 /**
@@ -590,7 +592,7 @@ export function buildVerificationLedger(root: string): VerificationLedger {
   const slashCommandNames = listSlashCommands();
   const cliCommandNames = listCliCommands();
   const slashCommands = slashCommandNames.length;
-  const panels = countBuiltinPanels(root);
+  const modals = countBuiltinModals(root);
   const cliCommands = cliCommandNames.length;
   const featureFlags = FEATURE_SETTINGS.length;
   const settings = CONFIG_SCHEMA.length;
@@ -623,12 +625,12 @@ export function buildVerificationLedger(root: string): VerificationLedger {
       notes: 'Every command can be routed and invoked with a fake context; external/provider/device commands need live outcome checks.',
     },
     {
-      area: 'Built-in panels',
-      total: panels,
-      localSignalVerified: panels,
-      localBehaviorVerified: panels,
+      area: 'Built-in modals and views',
+      total: modals,
+      localSignalVerified: modals,
+      localBehaviorVerified: modals,
       externalOutcomeRequired: 0,
-      notes: 'Panels can be rendered and input-tested against fake read models and real cached state.',
+      notes: 'Modals and views can be rendered and input-tested against fake read models and real cached state.',
     },
     {
       area: 'Top-level CLI commands',

package/src/{panels → views}/agent-inspector-shared.ts

@@ -7,7 +7,7 @@ export type AgentInspectorEntryKind = 'user' | 'assistant' | 'tool_call' | 'tool
 
 // ---------------------------------------------------------------------------
 // Shared agent status / stall constants
-// Used by the Fleet panel's agent views and read-model consumers (formerly also
+// Used by the Agents modal's agent views and read-model consumers (formerly also
 // AgentDetailModal, which was retired in).
 // ---------------------------------------------------------------------------
 
@@ -22,7 +22,7 @@ export const AGENT_STALL_THRESHOLD_MS = 5 * 60 * 1000;
  * An agent is stalled when it is non-terminal and has been running for at
  * least AGENT_STALL_THRESHOLD_MS without completing.
  *
- * Extracted as a standalone export so read-models and panels can share the
+ * Extracted as a standalone export so read-models and views can share the
  * canonical stall-count logic (TASK-046).
  */
 export function countStalledAgents(

package/src/{panels → views}/builtin-modals.ts

@@ -1,5 +1,5 @@
-import type { PanelManager } from './panel-manager.ts';
-import { requireUiServices, type ResolvedBuiltinPanelDeps } from './builtin/shared.ts';
+import type { ModalSurfaceRegistry } from './modal-surface-registry.ts';
+import type { ResolvedBuiltinViewDeps } from './view-deps.ts';
 import type { ConfigModalSurface, ConfigModalView } from '../input/config-modal-types.ts';
 import { createProviderRuntimeInspectionQuery } from '@/runtime/index.ts';
 import { createRuntimeProviderApi } from '@/runtime/index.ts';
@@ -32,20 +32,23 @@ import { createDevicesModalSurface } from './modals/devices-modal.ts';
 import { createPlanningModalSurface } from './modals/planning-modal.ts';
 
 /**
- * Register the config-modal surfaces + their panel-id redirects, from a prior
- * panel-consolidation cleanup. Called once at startup from registerBuiltinPanels, AFTER the panels'
- * deps are resolved (the surfaces close over the same read-models the retired
- * panels used). For each surface migrated from a standalone panel this does two things:
+ * Register the config-modal surfaces and the old names that open them. Called
+ * once at startup from createShellViews (builtin-views.ts). For each surface
+ * this does two things:
  *   1. registerModalSurface, the data + actions the config-modal host renders.
- *   2. registerModalRedirect, so `/panel open <old-id>`, saved layouts, and any
- *      alias still resolve to the modal.
+ *   2. registerModalRedirect, so `/panel open <old-id>`, notifications and any
+ *      alias still resolve to the modal (views.ts consults these).
  *
- * The Providers & Connectivity + Security subset is registered first, followed by the
- * Ecosystem & Governance set, the 12 ported config-modal
- * surfaces plus the `sessions` fold into the existing session-picker modal.
+ * `openMaskedEntry` opens the local-auth password prompt (a kit modal), which
+ * is how the Local Auth modal's add-user and rotate-password actions keep the
+ * password out of argv, history and the transcript.
  */
-export function registerBuiltinModals(manager: PanelManager, deps: ResolvedBuiltinPanelDeps): void {
-  const ui = requireUiServices(deps);
+export function registerBuiltinModals(
+  manager: ModalSurfaceRegistry,
+  deps: ResolvedBuiltinViewDeps,
+  openMaskedEntry: (kind: 'add-user' | 'rotate-password', username?: string) => void,
+): void {
+  const ui = deps.uiServices;
 
   // ── Providers & Connectivity ─────────────────────────────────────────────────
   manager.registerModalSurface(createServicesModalSurface(deps.serviceRegistry, deps.subscriptionManager));
@@ -71,10 +74,8 @@ export function registerBuiltinModals(manager: PanelManager, deps: ResolvedBuilt
   manager.registerModalSurface(createSettingsSyncModalSurface(deps.configManager));
   manager.registerModalRedirect('settings-sync', 'settings-sync-modal');
 
-  // local-auth-modal is reached via the /local-auth front-door only; no
-  // redirect (the 'local-auth' panel id must keep resolving to LocalAuthPanel
-  // for the masked password-entry path). See builtin/operations.ts.
-  manager.registerModalSurface(createLocalAuthModalSurface(deps.localUserAuthManager));
+  manager.registerModalSurface(createLocalAuthModalSurface(deps.localUserAuthManager, openMaskedEntry));
+  manager.registerModalRedirect('local-auth', 'local-auth-modal');
 
   manager.registerModalSurface(createSandboxModalSurface(deps.configManager, deps.sandboxSessionRegistry, deps.requestRender));
   manager.registerModalRedirect('sandbox', 'sandbox-modal');
@@ -178,7 +179,7 @@ export function registerBuiltinModals(manager: PanelManager, deps: ResolvedBuilt
   }));
   manager.registerModalRedirect('project-planning', 'planning-modal');
 
-  // The retired 'sessions' panel folds into the EXISTING session-picker modal
+  // The retired 'sessions' view folds into the EXISTING session-picker modal
   // (no new config-modal surface); the redirect is a plain hand-off, moved here
   // from the deleted ecosystem bridge.
   manager.registerModalRedirect('sessions', 'sessionPicker');
@@ -188,11 +189,11 @@ export function registerBuiltinModals(manager: PanelManager, deps: ResolvedBuilt
  * Build the companion-pairing connection info lazily (called from the pairing
  * surface's first render, not at registration time) so a missing daemon home
  * degrades to an honest "unavailable" modal instead of throwing at startup.
- * Mirrors the retired QrPanel factory's construction.
+ * Mirrors the retired Qr view factory's construction.
  */
-function buildPairingConnectionInfo(deps: ResolvedBuiltinPanelDeps): PairingModalConnectionInfo | null {
+function buildPairingConnectionInfo(deps: ResolvedBuiltinViewDeps): PairingModalConnectionInfo | null {
   try {
-    const ui = requireUiServices(deps);
+    const ui = deps.uiServices;
     const configManager = deps.configManager;
     // Freeze a stable web origin once (never clobbering a user-set value).
     const webOrigin = ensurePublicBaseUrl(configManager);

package/src/views/builtin-views.ts

@@ -0,0 +1,135 @@
+/**
+ * builtin-views.ts, the always-on pieces behind the built-in modals.
+ *
+ * Built once at startup (runtime/bootstrap-shell.ts):
+ *   - the UsageTracker, collecting per-turn history and costs from the first
+ *     turn whether or not the Usage modal is ever opened;
+ *   - the fleet's action callbacks, acts (pick / conflict / discard) and the
+ *     ACP spawn controller the Agents modal drives;
+ *   - every config-modal surface, registered on the ModalSurfaceRegistry with
+ *     the old names that open it.
+ *
+ * Two things only exist once the input handler does (the kit modal host): the
+ * Changes preview the fleet acts show candidate diffs in, and the local-auth
+ * password prompt. They are late-bound through `bridge`, which the shell fills
+ * in (shell/ui-openers.ts) before any of them can be used.
+ */
+
+import type { UserAuthManager } from '@pellux/goodvibes-sdk/platform/security';
+import type { ConfigManager } from '@pellux/goodvibes-sdk/platform/config';
+import { GOODVIBES_TUI_SURFACE_ROOT } from '../config/surface.ts';
+import { UsageTracker } from '../runtime/usage-tracker.ts';
+import type { FleetActionCallbacks } from '../input/agents-modal.ts';
+import { ModalSurfaceRegistry } from './modal-surface-registry.ts';
+import { registerBuiltinModals } from './builtin-modals.ts';
+import { resolveBuiltinViewDeps, type BuiltinViewDeps } from './view-deps.ts';
+import type { FleetReadModel } from './fleet-read-model.ts';
+import { FleetActs, type FleetDiffSurface } from './fleet-acts.ts';
+import { createFleetGateway } from './fleet-gateway.ts';
+import { FleetSpawn, createAcpSpawnGateway } from './fleet-spawn.ts';
+
+export type MaskedEntryOpener = (kind: 'add-user' | 'rotate-password', username?: string) => void;
+
+export interface ShellViewBridge {
+  /** Show candidate diffs and ask over them (the Changes preview). */
+  diffSurface: FleetDiffSurface | null;
+  /** Open the local-auth password prompt. */
+  openMaskedEntry: MaskedEntryOpener | null;
+}
+
+export interface ShellViews {
+  readonly modalSurfaces: ModalSurfaceRegistry;
+  readonly usage: UsageTracker;
+  readonly fleet: {
+    readonly readModel: FleetReadModel;
+    readonly actions: FleetActionCallbacks;
+    readonly acts: FleetActs;
+    readonly spawn: FleetSpawn;
+  };
+  readonly configManager: ConfigManager;
+  readonly workingDirectory: string;
+  /** Files this session edited. */
+  readonly getSessionFiles: () => string[];
+  readonly localUserAuthManager: UserAuthManager;
+  readonly bridge: ShellViewBridge;
+  dispose(): void;
+}
+
+export function createShellViews(deps: BuiltinViewDeps): ShellViews {
+  const resolved = resolveBuiltinViewDeps(deps);
+  const ui = deps.uiServices;
+  const requestRender = deps.requestRender ?? (() => {});
+  const bridge: ShellViewBridge = { diffSurface: null, openMaskedEntry: null };
+  const fleetReadModel = ui.runtime.fleetReadModel;
+  const notify = deps.fleetActsNotify ?? (() => {});
+
+  const usage = new UsageTracker({
+    turnEvents: ui.events.turns,
+    agentEvents: ui.events.agents,
+    getUsage: () => (deps.orchestrator?.usage ?? { input: 0, output: 0, cacheRead: 0, cacheWrite: 0 }) as { input: number; output: number; cacheRead: number; cacheWrite: number; model?: string },
+    getContextTokens: () => deps.orchestrator?.lastInputTokens ?? 0,
+    getContextWindow: () => deps.getCtxWindow?.() ?? 0,
+    getModelId: () => deps.providerRegistry.getCurrentModel().id,
+    getAgentStatus: (id) => ui.agents.agentManager.getStatus(id),
+    getFleetCost: () => fleetReadModel.getSnapshot().totalCost,
+    configManager: resolved.configManager,
+    sessionMemoryStore: resolved.sessionMemoryStore,
+    sessionReadModel: ui.readModels.session,
+    requestRender,
+  });
+
+  const diffSurface: FleetDiffSurface = {
+    show: (title, diff) => bridge.diffSurface?.show(title, diff),
+    armConfirm: (opts) => {
+      if (bridge.diffSurface) bridge.diffSurface.armConfirm(opts);
+      else opts.onCancel?.();
+    },
+    close: () => bridge.diffSurface?.close(),
+  };
+
+  const acts = new FleetActs({
+    resolveGateway: () => createFleetGateway({
+      configManager: resolved.configManager,
+      homeDirectory: ui.environment.shellPaths.homeDirectory,
+      armFixSessionAttach: deps.armFixSessionAttach ?? (() => {}),
+    }),
+    diffSurface,
+    notify,
+    markDirty: requestRender,
+    findNode: (nodeId: string) => fleetReadModel.getSnapshot().rows.find((r) => r.node.id === nodeId)?.node ?? null,
+  });
+
+  const spawn = new FleetSpawn({
+    resolveGateway: () => createAcpSpawnGateway({
+      configManager: resolved.configManager,
+      homeDirectory: ui.environment.shellPaths.homeDirectory,
+    }),
+    currentDirectory: () => ui.environment.shellPaths.workingDirectory,
+    notify,
+    markDirty: requestRender,
+  });
+
+  const actions: FleetActionCallbacks = {
+    interrupt: (id) => fleetReadModel.interrupt(id),
+    resume: (id) => fleetReadModel.resume(id),
+    kill: (id, opts) => fleetReadModel.kill(id, opts),
+    getConversationSnapshot: (agentId) => ui.agents.agentManager.getConversationSnapshot(agentId),
+    resolveSessionLogPath: (agentId) => ui.environment.shellPaths.resolveProjectPath(GOODVIBES_TUI_SURFACE_ROOT, 'sessions', `${agentId}.jsonl`),
+    steer: (id, text) => fleetReadModel.steer(id, text),
+  };
+
+  const modalSurfaces = new ModalSurfaceRegistry();
+  registerBuiltinModals(modalSurfaces, resolved, (kind, username) => bridge.openMaskedEntry?.(kind, username));
+
+  return {
+    modalSurfaces,
+    usage,
+    fleet: { readModel: fleetReadModel, actions, acts, spawn },
+    configManager: resolved.configManager,
+    workingDirectory: ui.environment.workingDirectory,
+    getSessionFiles: () => deps.sessionChangeTracker?.getChangedFiles() ?? [],
+    localUserAuthManager: resolved.localUserAuthManager,
+    bridge,
+    dispose: () => usage.dispose(),
+  };
+}

package/src/{panels → views}/confirm-state.ts

@@ -1,27 +1,27 @@
 // ---------------------------------------------------------------------------
 // useConfirmState<T>, reusable inline confirm/cancel helper
 //
-// ── Project-standard confirm contract (all panels must match) ──────────────
+// ── Project-standard confirm contract (all views must match) ──────────────
 //
 // CONFIRM:  Enter, Return, or y
 // CANCEL:   Esc or n
 // ABSORBED: any other key while confirm is active (keeps confirm pending)
 //
 // Implementation:
-//   - Composable: any panel holds a ConfirmState<T> field; no new base class
+//   - Composable: any view holds a ConfirmState<T> field; no new base class
 //   - Call handleConfirmInput(confirm, key) BEFORE normal key dispatch.
 //     It handles all four outcomes and returns one of the four result tokens.
 //   - Call renderConfirmLines(width, state) to render the two-line overlay
 //     that replaces normal content while a confirm is pending.
 //
 // ── This file is the canonical contract for all confirm flows ─────────────
-// Any new panel confirm flow must use ConfirmState<T> and handleConfirmInput;
+// Any new view confirm flow must use ConfirmState<T> and handleConfirmInput;
 // do not implement a bespoke two-press or Enter-only variant.
 // ---------------------------------------------------------------------------
 
 import type { Line } from '@pellux/goodvibes-sdk/platform/types';
-import { buildPanelLine } from './polish.ts';
-import { DEFAULT_PANEL_PALETTE } from './polish.ts';
+import { buildViewLine } from './polish.ts';
+import { DEFAULT_VIEW_PALETTE } from './polish.ts';
 
 export interface ConfirmState<T = string> {
   /** The subject of the confirmation (e.g. item name or id). */
@@ -37,7 +37,7 @@ export interface ConfirmState<T = string> {
 }
 
 /**
- * Call this from a panel's handleInput() BEFORE any other key handling.
+ * Call this from a view's handleInput() BEFORE any other key handling.
  *
  * Project-standard confirm contract:
  *   - CONFIRM:  Enter, Return, or y
@@ -66,14 +66,14 @@ export function handleConfirmInput<T = string>(
  * Callers embed these lines in a workspace section titled 'Confirmation'.
  */
 export function renderConfirmLines<T = string>(width: number, state: ConfirmState<T>): Line[] {
-  const palette = DEFAULT_PANEL_PALETTE;
+  const palette = DEFAULT_VIEW_PALETTE;
   const verb = state.verb ?? 'Delete';
   return [
-    buildPanelLine(width, [[
+    buildViewLine(width, [[
       ` ${verb} "${state.label}"?`,
       palette.warn,
     ]]),
-    buildPanelLine(width, [
+    buildViewLine(width, [
       [' Enter / y', palette.info],
       ['  confirm', palette.dim],
       ['   n / Esc', palette.info],

package/src/{panels → views}/diff-review-model.ts

@@ -1,11 +1,11 @@
 // ---------------------------------------------------------------------------
 // Diff review model, pure parsing + steering-payload helpers for the
-// comment-on-hunk review loop (see diff-review-panel.ts).
+// comment-on-hunk review loop (see the diff review view).
 //
 // The diff this operates on is the git working tree vs a base ref (HEAD),
 // filtered to the files the current session actually edited (the SDK's
 // SessionChangeTracker). That is the honest source: it is CURRENT working-tree
-// content, not a turn-start snapshot, the panel labels it exactly that way.
+// content, not a turn-start snapshot, the diff review view labels it exactly that way.
 // ---------------------------------------------------------------------------
 
 /** One hunk of one file's diff, with enough structure to steer a comment at it. */
@@ -169,13 +169,20 @@ export interface HunkComment {
  * patch excerpt so the model knows exactly what the comment targets. The
  * `sourceLabel` states the honest provenance of the diff (working tree vs base).
  */
-export function buildSteerMessage(items: readonly HunkComment[], sourceLabel: string): string {
+export function buildSteerMessage(
+  items: readonly HunkComment[],
+  sourceLabel: string,
+  /** One-line semantic summaries (functions, classes, imports changed) by file path, when known. */
+  semanticByFile?: ReadonlyMap<string, string>,
+): string {
   const blocks = items.map(({ hunk, comment }) => {
     const range = hunkLineRange(hunk);
+    const semantic = semanticByFile?.get(hunk.filePath);
     return [
       `Review comment on ${hunk.filePath} (lines ${range.start}-${range.end}, new file):`,
       comment,
       '',
+      ...(semantic ? [`Structure of this file's change: ${semantic}`, ''] : []),
       'Referenced change:',
       '```diff',
       hunkExcerpt(hunk),

package/src/{panels → views}/eval-registry.ts

@@ -1,7 +1,7 @@
 /**
  * EvalRegistry, holds the latest evaluation harness run state.
  *
- * (the purge): extracted out of eval-panel.ts. 'eval' was
+ * (the purge): extracted out of the eval view. 'eval' was
  * DELETE-disposition (no surviving human surface, the evaluation harness
  * is driven and reviewed via the `/eval` CLI command, input/commands/eval.ts)
  * but this registry is still a live consumer of `/eval run` output, so it