@pellux/goodvibes-tui 1.1.0 → 1.7.0

package/src/shell/ui-openers.ts

@@ -10,8 +10,10 @@ import type { FeatureFlagManager } from '@/runtime/index.ts';
 import type { McpRegistry } from '@pellux/goodvibes-sdk/platform/mcp';
 import type { SubscriptionManager } from '@pellux/goodvibes-sdk/platform/config';
 import type { SecretsManager } from '@pellux/goodvibes-sdk/platform/config';
+import type { MemoryEmbeddingProviderRegistry } from '@pellux/goodvibes-sdk/platform/state';
 import type { ServiceInspectionQuery } from '../runtime/ui-service-queries.ts';
-import type { ModelPickerTargetInfo } from '../input/model-picker.ts';
+import type { EmbeddingProviderPickerEntry, ModelPickerTargetInfo } from '../input/model-picker.ts';
+import type { SelectionItem } from '../input/selection-modal.ts';
 import { syncServiceSettingToPlatform } from './service-settings-sync.ts';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
 
@@ -28,6 +30,8 @@ type WireShellUiOpenersOptions = {
   subscriptionManager: SubscriptionManager;
   secretsManager?: Pick<SecretsManager, 'delete' | 'get' | 'set'>;
   serviceRegistry: Pick<ServiceInspectionQuery, 'getAll'>;
+  /** B29: backs the model picker's 'embeddings' target and its own item-list mode. */
+  memoryEmbeddingRegistry: Pick<MemoryEmbeddingProviderRegistry, 'getDefaultProviderId' | 'setDefaultProvider' | 'status'>;
   workingDirectory: string;
   homeDirectory: string;
   getConfiguredProviderIds: () => string[];
@@ -93,6 +97,7 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     subscriptionManager,
     secretsManager,
     serviceRegistry,
+    memoryEmbeddingRegistry,
     workingDirectory,
     homeDirectory,
     getConfiguredProviderIds,
@@ -125,6 +130,7 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     if (target === 'helper') return String(configManager.get('helper.globalModel') || runtime.model);
     if (target === 'tool') return String(configManager.get('tools.llmModel') || runtime.model);
     if (target === 'tts') return String(configManager.get('tts.llmModel') || runtime.model);
+    if (target === 'embeddings') return memoryEmbeddingRegistry.getDefaultProviderId();
     return runtime.model;
   };
 
@@ -134,10 +140,29 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     if (target === 'helper') return String(configManager.get('helper.globalProvider') || runtime.provider);
     if (target === 'tool') return String(configManager.get('tools.llmProvider') || runtime.provider);
     if (target === 'tts') return String(configManager.get('tts.llmProvider') || runtime.provider);
+    if (target === 'embeddings') return memoryEmbeddingRegistry.getDefaultProviderId();
     return runtime.provider;
   };
 
-  const buildModelPickerTargets = (): ModelPickerTargetInfo[] => {
+  /**
+   * Fetch the embedding-provider status list once per picker-open and shape
+   * it into the picker's own tiny item type. Uses the registry's async
+   * `.status()` (not the sync `.list()`) specifically because `.list()` does
+   * not carry `configured` — and unconfigured providers must be shown
+   * honestly, not hidden.
+   */
+  async function resolveEmbeddingProviderEntries(): Promise<EmbeddingProviderPickerEntry[]> {
+    const statuses = await memoryEmbeddingRegistry.status();
+    return statuses.map((status) => ({
+      id: status.id,
+      label: status.label,
+      dimensions: status.dimensions,
+      configured: status.configured,
+      ...(status.detail ? { detail: status.detail } : {}),
+    }));
+  }
+
+  const buildModelPickerTargets = (embeddingEntries: EmbeddingProviderPickerEntry[]): ModelPickerTargetInfo[] => {
     const mainProvider = getProviderIdFromModel(configManager.get('provider.model') || runtime.provider).trim();
     const mainModel = String(configManager.get('provider.model') || runtime.model || '').trim();
     const helperProvider = String(configManager.get('helper.globalProvider') ?? '').trim();
@@ -146,6 +171,11 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     const toolModel = String(configManager.get('tools.llmModel') ?? '').trim();
     const ttsProvider = String(configManager.get('tts.llmProvider') ?? '').trim();
     const ttsModel = String(configManager.get('tts.llmModel') ?? '').trim();
+    const embeddingProviderId = memoryEmbeddingRegistry.getDefaultProviderId();
+    const embeddingEntry = embeddingEntries.find((entry) => entry.id === embeddingProviderId);
+    const embeddingNote = embeddingEntry
+      ? `${embeddingEntry.id} · ${embeddingEntry.dimensions}d${embeddingEntry.configured ? '' : ' · unconfigured'}`
+      : `${embeddingProviderId} · unregistered`;
 
     return [
       {
@@ -184,6 +214,16 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
         enabled: true,
         inherited: ttsProvider.length === 0 && ttsModel.length === 0,
       },
+      {
+        target: 'embeddings',
+        label: 'Embeddings',
+        description: 'Embedding provider used for memory search and the code index. Not an LLM route — no model concept.',
+        provider: embeddingProviderId,
+        model: '',
+        enabled: true,
+        inherited: false,
+        configuredNote: embeddingNote,
+      },
     ];
   };
 
@@ -199,8 +239,10 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
         input.modelPicker.pinnedIds = new Set(pinned);
       });
       void input.modelPicker.loadRecentModels().catch(() => {}); // best-effort: prefetch for UI, failure is non-visible
+      const embeddingEntries = await resolveEmbeddingProviderEntries();
+      input.modelPicker.embeddingProviders = embeddingEntries;
       input.modalOpened('modelPicker');
-      input.modelPicker.setTargetInfos(buildModelPickerTargets());
+      input.modelPicker.setTargetInfos(buildModelPickerTargets(embeddingEntries));
       input.modelPicker.openAllModels(models, getCurrentModelForPickerTarget());
       render();
     })().catch((error: unknown) => {
@@ -219,8 +261,10 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
       input.modelPicker.configuredProviders = configuredIds;
       const secretProviderIds = await resolveSecretProviderIds();
       input.modelPicker.configuredViaMap = buildConfiguredViaMap(providers, configuredIds, subscriptionManager, secretProviderIds);
+      const embeddingEntries = await resolveEmbeddingProviderEntries();
+      input.modelPicker.embeddingProviders = embeddingEntries;
       input.modalOpened('modelPicker');
-      input.modelPicker.setTargetInfos(buildModelPickerTargets());
+      input.modelPicker.setTargetInfos(buildModelPickerTargets(embeddingEntries));
       input.modelPicker.openProviders(providers, getCurrentProviderForPickerTarget());
       render();
     })().catch((error: unknown) => {
@@ -229,6 +273,15 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     });
   };
 
+  commandContext.completeEmbeddingProviderSelection = (providerId: string) => {
+    try {
+      memoryEmbeddingRegistry.setDefaultProvider(providerId);
+    } catch (error: unknown) {
+      commandContext.print?.(`Failed to set embedding provider: ${summarizeError(error)}`);
+    }
+    render();
+  };
+
   commandContext.openSelection = (title, items, opts, callback) => {
     input.openSelection(title, items, opts, callback);
   };
@@ -281,6 +334,47 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     render();
   };
 
+  // W6.1 (the purge): open a MIGRATE-TO-MODAL surface by name. Fed from both
+  // ctx.openModal(name) (migrated command front-doors) and PanelManager's
+  // open()-time modal-redirect callback (a legacy panel id resolving to a modal
+  // name). Surfaces are registered in builtin-modals.ts; a name with no
+  // registered surface degrades honestly to a print rather than a blank modal.
+  // The stack name is the stable 'config' slot (one config modal at a time —
+  // opening another swaps the surface), so Esc close/return and the modal-stack
+  // machinery need only the single 'config' case (handler-ui-state.ts).
+  // Some panel-id redirects (and migrated front-doors) resolve to a NATIVE
+  // modal that is not a ConfigModalSurface — e.g. `sessions` -> `sessionPicker`,
+  // where 'sessionPicker' is the real session-picker modal opened by
+  // commandContext.openSessionPicker below, NOT a registered config surface.
+  // getModalSurface can never find these, so consult this small name->opener
+  // dispatch FIRST. Each entry reuses the same opener the front-door command
+  // uses (no duplicated open logic); resolved lazily so wiring order does not
+  // matter. Any name that is neither a native modal nor a registered surface
+  // still falls through to the honest "not available" print below.
+  const nativeModalOpeners: Record<string, () => void> = {
+    // openSessionPicker is wired below in this same function; call it lazily
+    // (optional-chained for the type, always present at invoke time).
+    sessionPicker: () => commandContext.openSessionPicker?.(),
+  };
+
+  commandContext.openModal = (name: string) => {
+    const openNative = nativeModalOpeners[name];
+    if (openNative) {
+      openNative();
+      return;
+    }
+    const surface = panelManager.getModalSurface(name);
+    if (!surface) {
+      commandContext.print(`'${name}' is not available yet in this build.`);
+      render();
+      return;
+    }
+    input.modalOpened('config');
+    input.configModal.open(surface, render);
+    render();
+  };
+  panelManager.setOpenModalCallback(commandContext.openModal);
+
   commandContext.openMcpWorkspace = () => {
     input.openMcpWorkspace(commandContext);
     render();
@@ -296,25 +390,43 @@ export function wireShellUiOpeners(options: WireShellUiOpenersOptions): void {
     // Focus ownership lives in PanelManager (focusTarget); read it there rather
     // than tracking a parallel input.panelFocused flag. Toggle semantics: if the
     // workspace is visible AND already focused, hide it; otherwise reveal and
-    // focus it (opening the panel list when nothing is open yet).
+    // focus it (opening a picker when nothing is open yet).
     if (panelManager.isVisible() && panelManager.getFocusTarget() === 'panel') {
       panelManager.hide();
       panelManager.focusPrompt();
       conversation.setSplashSuppressed(false);
       conversation.rebuildHistory();
-    } else {
-      if (panelManager.getAllOpen().length === 0) {
-        try {
-          panelManager.open('panel-list');
-        } catch {
-          // non-fatal
-        }
-      }
-      panelManager.show();
-      panelManager.focusPanels();
-      conversation.setSplashSuppressed(true);
-      conversation.rebuildHistory();
+      render();
+      return;
+    }
+    if (panelManager.getAllOpen().length === 0) {
+      // W6.1 (the purge): 'panel-list' (a browse-all-panels picker PANEL)
+      // was DELETE-disposition — a picker over a handful of panels is dead
+      // weight now. Its replacement is this selection MODAL, built from the
+      // live registry (PanelManager.getRegisteredTypes()) rather than a
+      // hardcoded list, so it can never list a retired/deleted id.
+      const items: SelectionItem[] = panelManager.getRegisteredTypes().map((entry) => ({
+        id: entry.id,
+        label: `${entry.icon} ${entry.name}`,
+        detail: entry.description,
+        category: entry.category,
+        primaryAction: 'select',
+      }));
+      commandContext.openSelection?.('Open Panel', items, { allowSearch: true }, (result) => {
+        if (!result) return;
+        panelManager.open(result.item.id);
+        panelManager.show();
+        panelManager.focusPanels();
+        conversation.setSplashSuppressed(true);
+        conversation.rebuildHistory();
+        render();
+      });
+      return;
     }
+    panelManager.show();
+    panelManager.focusPanels();
+    conversation.setSplashSuppressed(true);
+    conversation.rebuildHistory();
     render();
   };
 

package/src/utils/format-duration.ts

@@ -1,16 +1,21 @@
 /**
  * Shared ms-duration formatters for the panel layer.
  *
- * Three families are exported, each matching a distinct behavior cluster.
+ * Two families are exported, each matching a distinct behavior cluster.
  * DO NOT replace these with formatElapsed from utils/format-elapsed.ts —
  * formatElapsed floors to integer seconds and lacks the null/'?ms' guards
  * that the latency panels require.
+ *
+ * W6.1 (the purge): formatShortDuration (used only by incident-review-panel
+ * and eval-panel, both removed — RETIRE-INTO-FLEET and DELETE respectively)
+ * was removed as a genuinely orphaned export — no remaining caller anywhere
+ * in src/.
  */
 
 /**
  * Format a latency value in milliseconds with sub-second precision.
  *
- * Used by: debug-panel, provider-health-panel
+ * Used by: provider-health-panel
  *
  *   ms <= 0     → 'n/a'
  *   ms >= 10000 → '12.3s'    (one decimal)
@@ -27,7 +32,7 @@ export function formatLatencyMs(ms: number): string {
 /**
  * Format a task/agent duration with minute-rolling notation.
  *
- * Used by: tool-inspector-panel, agent-inspector-shared
+ * Used by: agent-inspector-shared
  *
  *   ms < 1000   → '500ms'
  *   ms < 60000  → '3.5s'
@@ -38,18 +43,3 @@ export function formatDuration(ms: number): string {
   if (ms < 60000) return `${(ms / 1000).toFixed(1)}s`;
   return `${Math.floor(ms / 60000)}m${Math.floor((ms % 60000) / 1000)}s`;
 }
-
-/**
- * Format a short eval/forensics duration; treats undefined as '?ms'.
- *
- * Used by: incident-review-panel, eval-panel
- *
- *   undefined → '?ms'
- *   ms < 1000 → '500ms'
- *   else      → '1.5s'
- */
-export function formatShortDuration(ms: number | undefined): string {
-  if (ms === undefined) return '?ms';
-  if (ms < 1000)        return `${ms}ms`;
-  return `${(ms / 1000).toFixed(1)}s`;
-}

package/src/utils/splash-lines.ts

@@ -24,7 +24,7 @@ const versionLine = (version: string) =>
   `　✦　v${version}　█　terminal AI assistant　█　自動ｺｰﾄﾞ 　✦`;
 
 /** Fixed hint line — the three primary shell entry points. */
-const HINT_LINE = 'Ctrl+P panels  /  ? help  /  F2 processes';
+const HINT_LINE = 'Ctrl+P panels  /  ? help  /  F2 fleet';
 
 export interface SplashOptions {
   workingDir?: string;

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '1.1.0';
+let _version = '1.7.0';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;