@pellux/goodvibes-tui 1.1.0 → 1.7.0

package/src/panels/diff-panel.ts

@@ -8,9 +8,8 @@ import { truncateDisplay, getDisplayWidth } from '../utils/terminal-width.ts';
 import { GitService } from '@pellux/goodvibes-sdk/platform/git';
 import { BasePanel } from './base-panel.ts';
 import { UI_TONES, DIFF_TONES } from '../renderer/ui-primitives.ts';
-import { FilePreviewPanel } from './file-preview-panel.ts';
-import type { PanelIntegrationContext } from './types.ts';
 import { logger } from '@pellux/goodvibes-sdk/platform/utils';
+import { PanelConfirmOverlay } from './panel-confirm-overlay.ts';
 import {
   buildBodyText,
   buildEmptyState,
@@ -262,14 +261,12 @@ export class DiffPanel extends BasePanel {
   private selectedFile = 0;
   private scrollOffset = 0;
 
-  /** Set by the 'o' key; consumed by handlePanelIntegrationAction on the next dispatch. */
-  private pendingOpenPreview = false;
-
   /** One-line confirmation for the 'w'/'h'/'s' self-load hotkeys — otherwise a
    * reload that produces identical content is visually indistinguishable
    * from the keypress doing nothing at all. */
   private hotkeyStatus: string | null = null;
 
+  public readonly confirmOverlay = new PanelConfirmOverlay(() => this.markDirty()); // armed by a command handler (e.g. /rewind); see panel-confirm-overlay.ts
   constructor(
     workingDirectory: string,
     private readonly requestRender: () => void = () => {},
@@ -502,6 +499,7 @@ export class DiffPanel extends BasePanel {
   }
 
   handleInput(key: string): boolean {
+    if (this.confirmOverlay.handleInput(key)) return true; // confirm takes priority (git-panel.ts:284-303 precedent)
     switch (key) {
       case 'up':    this.scrollUp();   return true;
       case 'down':  this.scrollDown(); return true;
@@ -519,48 +517,17 @@ export class DiffPanel extends BasePanel {
       case 'w': this.runHotkeyReload('working tree', () => this.showGitDiff());       return true;
       case 'h': this.runHotkeyReload('HEAD',         () => this.showGitDiff('HEAD')); return true;
       case 's': this.runHotkeyReload('staged',       () => this.showStagedDiff());    return true;
-      case 'o': {
-        if (!this.currentEntry()) return false;
-        this.pendingOpenPreview = true;
-        return true;
-      }
       default: return false;
     }
   }
 
-  /**
-   * Cross-panel integration hook — 'o' opens the currently selected file in
-   * the preview panel via the same open/focus bridge FileExplorerPanel uses
-   * (src/input/panel-integration-actions.ts), without this panel needing to
-   * know about PanelManager pane/focus mechanics beyond what ctx exposes.
-   */
-  handlePanelIntegrationAction(_key: string, ctx: PanelIntegrationContext): boolean {
-    if (!this.pendingOpenPreview) return false;
-    this.pendingOpenPreview = false;
-    const entry = this.currentEntry();
-    if (!entry) return false;
-
-    const pm = ctx.panelManager;
-    let previewPanel = pm.getPanel('preview');
-    if (previewPanel instanceof FilePreviewPanel) {
-      const pane = pm.getPaneOf('preview');
-      pm.activateById('preview');
-      if (pane) pm.focusPane(pane);
-    } else {
-      const targetPane: 'top' | 'bottom' = pm.isBottomPaneVisible()
-        ? (pm.getFocusedPane() === 'top' ? 'bottom' : 'top')
-        : 'bottom';
-      const opened = pm.open('preview', targetPane);
-      pm.show();
-      pm.focusPane(targetPane);
-      previewPanel = opened instanceof FilePreviewPanel ? opened : null;
-    }
-    if (previewPanel instanceof FilePreviewPanel) {
-      previewPanel.openFile(entry.filePath);
-      return true;
-    }
-    return false;
-  }
+  // W6.1 (the purge): 'o' used to open the currently selected file in the
+  // preview panel via a staged pendingOpenPreview flag + a
+  // handlePanelIntegrationAction cross-panel hook (the same bridge
+  // FileExplorerPanel used). 'preview' is DELETE-disposition with no
+  // successor surface (no file-picker-overlay preview to repoint to
+  // either — verified), so the key and the hook were removed rather than
+  // repointed; diff no longer has an 'o' action.
 
   private scrollUp(): void {
     if (this.scrollOffset > 0) {
@@ -618,6 +585,8 @@ export class DiffPanel extends BasePanel {
     return this.trackedRender(() => {
     if (height <= 0 || width <= 0) return [];
 
+    const confirmLines = this.confirmOverlay.renderLines(width);
+    if (confirmLines) return buildPanelWorkspace(width, height, { title: 'Diff Workspace', palette: COLOR, sections: [{ title: 'Confirmation', lines: confirmLines }] });
     if (this.entries.length === 0) {
       return buildPanelWorkspace(width, height, {
         title: 'Diff Workspace',

package/src/panels/eval-registry.ts

@@ -0,0 +1,60 @@
+/**
+ * EvalRegistry — holds the latest evaluation harness run state.
+ *
+ * W6.1 (the purge): extracted out of eval-panel.ts. 'eval' was
+ * DELETE-disposition (no surviving human surface — the evaluation harness
+ * is driven and reviewed via the `/eval` CLI command, input/commands/eval.ts)
+ * but this registry is still a live consumer of `/eval run` output, so it
+ * survives as a standalone read-model rather than being deleted with the
+ * view. See .goodvibes/audit/2026-07-04-wave6-briefs.json (W6.1).
+ */
+
+import type { EvalSuiteResult, EvalGateResult } from '@/runtime/index.ts';
+
+export class EvalRegistry {
+  private _suiteResults: EvalSuiteResult[] = [];
+  private _gateResults: EvalGateResult[] = [];
+  private _running = false;
+  private _lastRunAt: number | null = null;
+  private readonly _subscribers = new Set<() => void>();
+
+  push(result: EvalSuiteResult): void {
+    const idx = this._suiteResults.findIndex((r) => r.suite === result.suite);
+    if (idx >= 0) {
+      this._suiteResults[idx] = result;
+    } else {
+      this._suiteResults.push(result);
+    }
+    this._lastRunAt = Date.now();
+    this._notify();
+  }
+
+  pushGate(gate: EvalGateResult): void {
+    const idx = this._gateResults.findIndex((g) => g.suite === gate.suite);
+    if (idx >= 0) {
+      this._gateResults[idx] = gate;
+    } else {
+      this._gateResults.push(gate);
+    }
+    this._notify();
+  }
+
+  setRunning(running: boolean): void {
+    this._running = running;
+    this._notify();
+  }
+
+  isRunning(): boolean { return this._running; }
+  getLastRunAt(): number | null { return this._lastRunAt; }
+  getSuiteResults(): EvalSuiteResult[] { return this._suiteResults; }
+  getGateResults(): EvalGateResult[] { return this._gateResults; }
+
+  subscribe(cb: () => void): () => void {
+    this._subscribers.add(cb);
+    return () => this._subscribers.delete(cb);
+  }
+
+  private _notify(): void {
+    for (const cb of this._subscribers) cb();
+  }
+}