@pellux/goodvibes-tui 0.20.3 → 0.22.0

package/src/panels/session-maintenance.ts

@@ -1,3 +1,16 @@
+/**
+ * Session maintenance types and local evaluator.
+ *
+ * The canonical evaluator is the SDK version exported from @/runtime/index.ts
+ * (via operations.evaluateSessionMaintenance), which reads from configManager.
+ *
+ * This module provides:
+ *  - The shared type surface used across TUI panels.
+ *  - A thin local evaluator kept in sync with the SDK signature so panel code
+ *    that passes configManager has a coherent call site.
+ */
+import type { ConfigManager } from '@pellux/goodvibes-sdk/platform/config';
+
 export type PanelGuidanceMode = 'off' | 'minimal' | 'guided';
 export type PanelSessionMaintenanceLevel = 'stable' | 'watch' | 'suggest-compact' | 'compacting' | 'needs-repair' | 'unknown';
 
@@ -9,9 +22,12 @@ export interface PanelSessionMaintenanceSession {
   readonly lineage?: readonly PanelSessionMaintenanceLineageEntry[];
   readonly lastCompactedAt?: number;
   readonly compactionMessageCount?: number;
+  readonly compactionState?: string;
 }
 
 export interface PanelSessionMaintenanceInput {
+  /** ConfigManager used to read behavior.autoCompactThreshold and related keys. */
+  readonly configManager: Pick<ConfigManager, 'get'>;
   readonly currentTokens: number;
   readonly contextWindow: number;
   readonly messageCount?: number;
@@ -27,7 +43,15 @@ export interface PanelSessionMaintenanceStatus {
   readonly guidanceMode: PanelGuidanceMode;
   readonly usagePct: number;
   readonly remainingTokens: number;
+  /**
+   * Compact threshold as a percent integer.
+   * SDK schema range is [10, 100]; default is 80.
+   */
   readonly thresholdPct: number;
+  /**
+   * True when autoCompactThreshold is in its valid range (>0).
+   * With SDK default (80), auto-compact is active unless explicitly lowered below 10.
+   */
   readonly autoCompactEnabled: boolean;
   readonly sessionMemoryCount: number;
   readonly compactionCount: number;
@@ -35,19 +59,33 @@ export interface PanelSessionMaintenanceStatus {
   readonly compactRecommended: boolean;
 }
 
+/**
+ * Evaluate session maintenance from config-driven thresholds.
+ *
+ * behavior.autoCompactThreshold (percent integer, SDK schema range [10, 100], default 80):
+ *  - [10, 100] → threshold at that percent; autoCompactEnabled = true.
+ *  - 0 (defensive fallback for null/missing config only; not a valid schema value).
+ *
+ * NOTE: The SDK's evaluateSessionMaintenance (from @/runtime/index.ts) is the
+ * canonical implementation used in production.  This local version exists so
+ * panel tests can import types without crossing the SDK boundary.
+ */
 export function evaluateSessionMaintenance(input: PanelSessionMaintenanceInput): PanelSessionMaintenanceStatus {
-  const guidanceMode: PanelGuidanceMode = 'minimal';
-  const thresholdPct = 80;
-  const autoCompactEnabled = false;
+  const guidanceMode: PanelGuidanceMode = (input.configManager.get('behavior.guidanceMode') as PanelGuidanceMode | undefined) ?? 'minimal';
+  const rawThreshold = Number(input.configManager.get('behavior.autoCompactThreshold') ?? 0);
+  const thresholdPct = Math.max(0, Number.isFinite(rawThreshold) ? rawThreshold : 0);
+  const autoCompactEnabled = thresholdPct > 0;
+
   const usagePct = input.contextWindow > 0 ? Math.min(100, Math.round((Math.max(0, input.currentTokens) / input.contextWindow) * 100)) : 0;
   const remainingTokens = Math.max(0, input.contextWindow - input.currentTokens);
   const sessionMemoryCount = Math.max(0, input.sessionMemoryCount ?? 0);
   const compactionCount = Math.max(0, input.session?.lineage?.filter((entry) => entry.branchReason === 'compaction').length ?? 0);
   const lastCompactedAt = input.session?.lastCompactedAt;
   const messageCount = Math.max(0, input.messageCount ?? 0);
-  const staleByMessageGrowth = compactionCount > 0
+  const staleByMessageGrowth = (input.session?.compactionMessageCount ?? 0) > 0
     ? messageCount - (input.session?.compactionMessageCount ?? 0) >= 12
     : messageCount >= 24;
+
   if (input.contextWindow <= 0) {
     return {
       level: 'unknown',
@@ -66,32 +104,45 @@ export function evaluateSessionMaintenance(input: PanelSessionMaintenanceInput):
     };
   }
 
+  if (input.session?.compactionState === 'failed') {
+    return {
+      level: 'needs-repair',
+      summary: 'Compaction needs operator repair.',
+      reasons: ['Compaction failed and the session may need manual recovery.'],
+      nextSteps: ['/compact', '/health review'],
+      guidanceMode,
+      usagePct,
+      remainingTokens,
+      thresholdPct,
+      autoCompactEnabled,
+      sessionMemoryCount,
+      compactionCount,
+      lastCompactedAt,
+      compactRecommended: true,
+    };
+  }
+
   const reasons: string[] = [];
   const nextSteps: string[] = [];
   let summary = 'Session maintenance is stable.';
   let compactRecommended = false;
   let level: PanelSessionMaintenanceLevel = 'stable';
 
-  if (usagePct >= 90) {
-    level = 'needs-repair';
+  const atThreshold = autoCompactEnabled ? usagePct >= thresholdPct : usagePct >= 80;
+  if (atThreshold || remainingTokens <= 15_000) {
+    level = 'suggest-compact';
     summary = `Compact now to recover context headroom (${usagePct}% used).`;
     reasons.push(`Context pressure is high at ${usagePct}% usage.`);
     nextSteps.push('/compact', '/panel tokens');
     compactRecommended = true;
-  } else if (usagePct >= thresholdPct || remainingTokens <= 15_000) {
-    level = 'suggest-compact';
-    summary = `Watch context growth (${usagePct}% used).`;
-    reasons.push(`Context pressure is climbing at ${usagePct}% usage.`);
-    nextSteps.push('/panel tokens');
-    compactRecommended = true;
-  } else if (usagePct >= 70 || staleByMessageGrowth) {
+  } else if (usagePct >= Math.max(70, autoCompactEnabled ? thresholdPct - 10 : 70) || staleByMessageGrowth) {
     level = 'watch';
     summary = staleByMessageGrowth
       ? `Conversation has grown ${messageCount.toLocaleString()} messages since the last maintenance checkpoint.`
       : `Watch context growth (${usagePct}% used, threshold ${thresholdPct}%).`;
     reasons.push(staleByMessageGrowth
       ? `Conversation has grown ${messageCount.toLocaleString()} messages since the last maintenance checkpoint.`
-      : `Context usage is climbing toward the ${thresholdPct}% maintenance threshold.`);
+      : `Context usage is climbing toward the ${thresholdPct > 0 ? `${thresholdPct}% auto-compact threshold` : 'maintenance band'}.`);
     nextSteps.push('/panel tokens');
   } else {
     reasons.push('Context pressure is currently within the stable operating band.');
@@ -104,7 +155,7 @@ export function evaluateSessionMaintenance(input: PanelSessionMaintenanceInput):
     reasons.push(`Last compaction ran ${lastCompactedAt ? new Date(lastCompactedAt).toISOString() : 'recently'}.`);
   }
   if (!autoCompactEnabled) {
-    reasons.push('Auto-compact is currently disabled; use /compact when you need to recover headroom.');
+    reasons.push('Auto-compaction is disabled; maintenance stays fully manual.');
   }
 
   return {

package/src/panels/subscription-panel.ts

@@ -1,8 +1,10 @@
 import type { Line } from '../types/grid.ts';
 import { createEmptyLine } from '../types/grid.ts';
 import { ScrollableListPanel } from './scrollable-list-panel.ts';
+import type { KeyName } from './types.ts';
 import type { ProviderSubscription, PendingSubscriptionLogin } from '@pellux/goodvibes-sdk/platform/config';
 import { listBuiltinSubscriptionProviders } from '@pellux/goodvibes-sdk/platform/config';
+import { type ConfirmState, handleConfirmInput } from './confirm-state.ts';
 import type { ServiceInspectionQuery, SubscriptionAccessQuery } from '../runtime/ui-service-queries.ts';
 import {
   buildEmptyState,
@@ -57,7 +59,8 @@ export class SubscriptionPanel extends ScrollableListPanel<SubscriptionRow> {
   private readonly serviceRegistry: Pick<ServiceInspectionQuery, 'getAll'>;
   private readonly subscriptionManager: SubscriptionAccessQuery;
   private rows: SubscriptionRow[] = [];
-  private logoutConfirmationTarget: string | null = null;
+  /** Pending logout confirmation — uses project-standard ConfirmState contract. */
+  private confirm: ConfirmState<string> | null = null;
 
   public constructor(
     serviceRegistry: Pick<ServiceInspectionQuery, 'getAll'>,
@@ -98,42 +101,47 @@ export class SubscriptionPanel extends ScrollableListPanel<SubscriptionRow> {
     ], C, { selected, selectedBg: C.selectedBg });
   }
 
-  public handleInput(key: string): boolean {
+  public handleInput(key: KeyName): boolean {
+    // Project-standard confirm contract: Enter/y confirm; n/Esc cancel; other absorbed.
+    const confirmResult = handleConfirmInput(this.confirm, key);
+    if (confirmResult === 'confirmed') {
+      const provider = this.confirm!.subject;
+      this.confirm = null;
+      this.subscriptionManager.logout(provider);
+      this.refresh();
+      this.markDirty();
+      return true;
+    }
+    if (confirmResult === 'cancelled') {
+      this.confirm = null;
+      this.markDirty();
+      return true;
+    }
+    if (confirmResult === 'absorbed') return true;
+
     if (this.rows.length === 0) return false;
     const selected = this.rows[this.selectedIndex] ?? null;
-    if (key === 'ArrowUp' || key === 'k') {
+    if (key === 'up' || key === 'k') {
       this.selectedIndex = Math.max(0, this.selectedIndex - 1);
-      this.logoutConfirmationTarget = null;
+      this.confirm = null;
       this.markDirty();
       return true;
     }
-    if (key === 'ArrowDown' || key === 'j') {
+    if (key === 'down' || key === 'j') {
       this.selectedIndex = Math.min(this.rows.length - 1, this.selectedIndex + 1);
-      this.logoutConfirmationTarget = null;
+      this.confirm = null;
       this.markDirty();
       return true;
     }
-    if (key === 'enter' || key === 'x') {
+    if (key === 'enter' || key === 'return') {
       if (!selected?.subscription) return false;
-      if (this.logoutConfirmationTarget === null || this.logoutConfirmationTarget !== selected.provider) {
-        this.logoutConfirmationTarget = selected.provider;
-        this.markDirty();
-        return true;
-      }
-      this.subscriptionManager.logout(selected.provider);
-      this.logoutConfirmationTarget = null;
-      this.refresh();
-      this.markDirty();
-      return true;
-    }
-    if ((key === 'n' || key === 'escape') && this.logoutConfirmationTarget) {
-      this.logoutConfirmationTarget = null;
+      this.confirm = { subject: selected.provider, label: selected.provider };
       this.markDirty();
       return true;
     }
     if (key === 'r') {
       this.refresh();
-      this.logoutConfirmationTarget = null;
+      this.confirm = null;
       this.markDirty();
       return true;
     }
@@ -206,7 +214,7 @@ export class SubscriptionPanel extends ScrollableListPanel<SubscriptionRow> {
         sections: [{ lines: [...summaryLines, ...emptyLines] }],
         footerLines: [
           buildGuidanceLine(width, '/subscription login <provider> start', 'start browser-based provider login from the packaged subscription surface', C),
-          buildPanelLine(width, [['  Up/Down move  Enter/X sign out selected provider  r refresh', C.dim]]),
+          buildPanelLine(width, [['  Up/Down move  Enter sign out selected provider  y/Esc confirm/cancel  r refresh', C.dim]]),
         ],
         palette: C,
       });
@@ -236,8 +244,8 @@ export class SubscriptionPanel extends ScrollableListPanel<SubscriptionRow> {
             : 'Stored for subscription-backed flows. Ambient API-key resolution remains unchanged.'}`,
           C.dim,
         ]]));
-        if (this.logoutConfirmationTarget === selectedRow.provider) {
-          detailRows.push(buildPanelLine(width, [[` Press Enter or X again to sign out ${selectedRow.provider}.`, C.warn]]));
+        if (this.confirm?.subject === selectedRow.provider) {
+          detailRows.push(buildPanelLine(width, [[` Sign out ${selectedRow.provider}? Press y or Enter to confirm, n or Esc to cancel.`, C.warn]]));
         }
       } else if (selectedRow.pending) {
         detailRows.push(buildPanelLine(width, [[' Login is pending. Finish with /subscription login <provider> finish <code>.', C.warn]]));
@@ -256,7 +264,7 @@ export class SubscriptionPanel extends ScrollableListPanel<SubscriptionRow> {
       footer: [
         ...detailRows,
         buildGuidanceLine(width, '/subscription login <provider> start', 'start browser-based provider login from the packaged subscription surface', C),
-        buildPanelLine(width, [['  Up/Down move  Enter/X sign out selected provider  r refresh', C.dim]]),
+        buildPanelLine(width, [['  Up/Down move  Enter sign out selected provider  y/Esc confirm/cancel  r refresh', C.dim]]),
       ],
     });
   }

package/src/panels/types.ts

@@ -1,6 +1,33 @@
 import type { Line } from '../types/grid.ts';
 import type { ComponentResourceContract, ComponentHealthState } from '../runtime/perf/panel-contracts.ts';
 
+/**
+ * Named logical key identifiers emitted by the input tokenizer.
+ * These are the ONLY key names that will appear in `handleInput` calls;
+ * the tokenizer never emits DOM/browser-style names like 'ArrowUp' or 'Enter'.
+ *
+ * Printable single-character input is passed through as-is; the `string & {}`
+ * fallback preserves that handling while making named-key completions discoverable
+ * in editors and keeping non-null single-character values compatible.
+ */
+export type NamedKey =
+  | 'up' | 'down' | 'left' | 'right'
+  | 'home' | 'end' | 'pageup' | 'pagedown'
+  | 'insert' | 'delete' | 'backspace'
+  | 'enter' | 'return' | 'escape' | 'space' | 'tab'
+  | 'f1' | 'f2' | 'f3' | 'f4' | 'f5' | 'f6'
+  | 'f7' | 'f8' | 'f9' | 'f10' | 'f11' | 'f12';
+
+/**
+ * The full key type accepted by `Panel.handleInput`.
+ *
+ * Named keys (arrow keys, modifiers, function keys) are represented by
+ * lowercase `NamedKey` members. Single printable characters are passed
+ * verbatim via the `string & {}` escape hatch so panels can handle 'j', 'k',
+ * 'r', etc. without losing type safety on the named members.
+ */
+export type KeyName = NamedKey | (string & {});
+
 export type PanelCategory = 'development' | 'agent' | 'monitoring' | 'session' | 'ai';
 
 export interface Panel {
@@ -35,7 +62,7 @@ export interface Panel {
   healthState?: Readonly<ComponentHealthState>;
 
   // Input (optional)
-  handleInput?(key: string): boolean;
+  handleInput?(key: KeyName): boolean;
 
   // Scroll input (optional)
   // Positive delta scrolls down; negative delta scrolls up.