@pellux/goodvibes-tui 0.20.3 → 0.22.0

package/src/panels/eval-panel.ts

@@ -7,6 +7,7 @@
 
 import { BasePanel } from './base-panel.ts';
 import type { Line } from '../types/grid.ts';
+import type { KeyName } from './types.ts';
 import { createEmptyLine } from '../types/grid.ts';
 import {
   buildEmptyState,
@@ -136,21 +137,21 @@ export class EvalPanel extends BasePanel {
     this._unsub = null;
   }
 
-  public handleInput(key: string): boolean {
+  public handleInput(key: KeyName): boolean {
     const suites = this._registry.getSuiteResults();
 
     if (this._mode === 'list') {
-      if (key === 'ArrowUp' || key === 'k') {
+      if (key === 'up' || key === 'k') {
         this._selectedSuiteIdx = Math.max(0, this._selectedSuiteIdx - 1);
         this.markDirty();
         return true;
       }
-      if (key === 'ArrowDown' || key === 'j') {
+      if (key === 'down' || key === 'j') {
         this._selectedSuiteIdx = Math.min(suites.length - 1, this._selectedSuiteIdx + 1);
         this.markDirty();
         return true;
       }
-      if ((key === 'Enter' || key === 'Return' || key === 'l') && suites.length > 0) {
+      if ((key === 'enter' || key === 'return' || key === 'l') && suites.length > 0) {
         this._mode = 'detail';
         this._selectedScenarioIdx = 0;
         this._scrollOffset = 0;
@@ -161,12 +162,12 @@ export class EvalPanel extends BasePanel {
     }
 
     // detail mode
-    if (key === 'Escape' || key === 'q' || key === 'h') {
+    if (key === 'escape' || key === 'q' || key === 'h') {
       this._mode = 'list';
       this.markDirty();
       return true;
     }
-    if (key === 'ArrowUp' || key === 'k') {
+    if (key === 'up' || key === 'k') {
       const suite = suites[this._selectedSuiteIdx];
       if (suite) {
         this._selectedScenarioIdx = Math.max(0, this._selectedScenarioIdx - 1);
@@ -175,7 +176,7 @@ export class EvalPanel extends BasePanel {
       }
       return true;
     }
-    if (key === 'ArrowDown' || key === 'j') {
+    if (key === 'down' || key === 'j') {
       const suite = suites[this._selectedSuiteIdx];
       if (suite) {
         this._selectedScenarioIdx = Math.min(
@@ -187,12 +188,12 @@ export class EvalPanel extends BasePanel {
       }
       return true;
     }
-    if (key === 'PageUp') {
+    if (key === 'pageup') {
       this._scrollOffset = Math.max(0, this._scrollOffset - 5);
       this.markDirty();
       return true;
     }
-    if (key === 'PageDown') {
+    if (key === 'pagedown') {
       this._scrollOffset += 5;
       this.markDirty();
       return true;

package/src/panels/index.ts

@@ -40,7 +40,7 @@ export { SecurityPanel } from './security-panel.ts';
 export { MarketplacePanel } from './marketplace-panel.ts';
 export { SandboxPanel } from './sandbox-panel.ts';
 export { ApprovalPanel } from './approval-panel.ts';
-export { KnowledgePanel } from './knowledge-panel.ts';
+export { KnowledgeGraphPanel } from './knowledge-graph-panel.ts';
 export { SystemMessagesPanel } from './system-messages-panel.ts';
 export { PanelListPanel } from './panel-list-panel.ts';
 export type { SystemMessageEntry, SystemMessagePriority } from './system-messages-panel.ts';

package/src/panels/knowledge-graph-panel.ts

@@ -0,0 +1,84 @@
+/**
+ * KnowledgeGraphPanel — SDK knowledge graph front-door.
+ *
+ * TASK-040: The 'knowledge' panel id is repointed here (the SDK graph), fixing
+ * the naming inversion where the former panel named 'Knowledge' was actually
+ * rendering memory records.
+ *
+ * This panel is a thin information surface that explains the graph's capabilities
+ * and routes the user to the /knowledge command suite for ingest/RAG operations.
+ * The full graph UI is command-driven (/knowledge ask, ingest-url, list, search…).
+ */
+
+import type { Line } from '../types/grid.ts';
+import { BasePanel } from './base-panel.ts';
+import {
+  buildBodyText,
+  buildGuidanceLine,
+  buildPanelLine,
+  buildPanelWorkspace,
+  DEFAULT_PANEL_PALETTE,
+} from './polish.ts';
+
+const C = {
+  ...DEFAULT_PANEL_PALETTE,
+  header: '#94a3b8',
+  headerBg: '#1e293b',
+} as const;
+
+export class KnowledgeGraphPanel extends BasePanel {
+  constructor() {
+    super('knowledge', 'Knowledge', 'K', 'agent');
+  }
+
+  handleInput(_key: string): boolean {
+    return false;
+  }
+
+  render(width: number, height: number): Line[] {
+    const sections = [
+      {
+        title: 'SDK Knowledge Graph',
+        lines: [
+          ...buildBodyText(
+            width,
+            'The knowledge graph stores ingested URLs, bookmarks, and structured facts as nodes and edges. ' +
+            'Use /knowledge commands to ingest sources, search the graph, and build task-context packets.',
+            C,
+            C.value,
+          ),
+          buildPanelLine(width, [['', C.dim]]),
+          buildGuidanceLine(width, '/knowledge status', 'check the graph status and source counts', C),
+          buildGuidanceLine(width, '/knowledge ask <query>', 'ask a question against the ingested knowledge', C),
+          buildGuidanceLine(width, '/knowledge ingest-url <url>', 'ingest a URL as a knowledge source', C),
+          buildGuidanceLine(width, '/knowledge list', 'list ingested sources or graph nodes', C),
+          buildGuidanceLine(width, '/knowledge search <query>', 'search the graph for nodes and sources', C),
+          buildGuidanceLine(width, '/knowledge packet <task>', 'build a compact prompt packet for a task', C),
+        ],
+      },
+      {
+        title: 'Project Memory',
+        lines: [
+          ...buildBodyText(
+            width,
+            'For durable decisions, risks, runbooks, incidents, and architecture records, use the Memory panel ' +
+            'or the /recall command surface. Durable memory is a sub-namespace of the knowledge graph.',
+            C,
+            C.dim,
+          ),
+          buildPanelLine(width, [['', C.dim]]),
+          buildGuidanceLine(width, '/recall add <class> <summary>', 'capture a new memory record', C),
+          buildGuidanceLine(width, '/recall queue', 'show the operator review queue', C),
+          buildGuidanceLine(width, '/project-memory (pmem)', 'project-memory alias for /recall front-door', C),
+        ],
+      },
+    ];
+
+    return buildPanelWorkspace(width, height, {
+      title: 'Knowledge Graph',
+      intro: 'Ingested sources, graph nodes, and the durable memory bridge.',
+      sections,
+      palette: C,
+    });
+  }
+}

package/src/panels/local-auth-panel.ts

@@ -11,8 +11,11 @@ import {
   DEFAULT_PANEL_PALETTE,
   type PanelPalette,
 } from './polish.ts';
-import type { LocalAuthSnapshot } from '@pellux/goodvibes-sdk/platform/security';
+import type { LocalAuthSnapshot, UserAuthManager } from '@pellux/goodvibes-sdk/platform/security';
 import type { LocalAuthInspectionQuery } from '../runtime/ui-service-queries.ts';
+import type { KeyName } from './types.ts';
+import { isTextBackspace } from '../input/delete-key-policy.ts';
+import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils';
 
 const C = {
   ...DEFAULT_PANEL_PALETTE,
@@ -28,8 +31,19 @@ function formatRoles(roles: readonly string[]): string {
 
 type LocalAuthUser = LocalAuthSnapshot['users'][number];
 
+/** Action kind for the masked password entry mode. */
+export type MaskedEntryKind = 'add-user' | 'rotate-password';
+
+interface MaskedEntryState {
+  readonly kind: MaskedEntryKind;
+  readonly username: string;
+  readonly auth: UserAuthManager;
+  buffer: string;
+}
+
 export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
   private readonly authManager: LocalAuthInspectionQuery;
+  private maskedState: MaskedEntryState | null = null;
 
   public constructor(authManager: LocalAuthInspectionQuery) {
     super('local-auth', 'Local Auth', 'U', 'monitoring');
@@ -37,6 +51,81 @@ export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
     this.authManager = authManager;
   }
 
+  /**
+   * Activate masked password-entry mode for the given operation.
+   * The panel's handleInput will capture keystrokes into a private buffer;
+   * no plaintext is ever recorded in input history, transcript, or logs.
+   */
+  public openMaskedEntry(kind: MaskedEntryKind, username: string, auth: UserAuthManager): void {
+    this.maskedState = { kind, username, auth, buffer: '' };
+    this.invalidate();
+  }
+
+  /** Returns true when the panel is in masked-entry mode. */
+  public get isMaskedEntryActive(): boolean {
+    return this.maskedState !== null;
+  }
+
+  public override handleInput(key: KeyName): boolean {
+    if (this.maskedState === null) {
+      // Delegate scroll/selection to ScrollableListPanel when not in masked mode.
+      return super.handleInput?.(key) ?? false;
+    }
+
+    // Masked entry is active — capture all keystrokes.
+    const state = this.maskedState;
+
+    if (key === 'escape') {
+      // Cancel: discard buffer, exit masked mode without persisting.
+      this.maskedState = null;
+      this.invalidate();
+      return true;
+    }
+
+    if (key === 'enter' || key === 'return') {
+      // Submit: call the auth API if a non-empty password was entered.
+      if (state.buffer.length === 0) {
+        return true; // no-op — require at least one character
+      }
+      const password = state.buffer;
+      const { kind, username, auth } = state;
+      // Clear the mutable state *before* the auth call so the secret
+      // never lingers in the buffer after an exception.
+      this.maskedState = null;
+      try {
+        if (kind === 'add-user') {
+          auth.addUser(username, password, ['admin']);
+        } else {
+          auth.rotatePassword(username, password);
+        }
+      } catch (_error) {
+        // Surface errors via the panel's error facility rather than logging.
+        this.setError(summarizeError(_error));
+      }
+      this.invalidate();
+      return true;
+    }
+
+    if (isTextBackspace(key)) {
+      // Remove last character (Ink 6.8.0: raw-stdin raw 'backspace' only).
+      if (state.buffer.length > 0) {
+        state.buffer = state.buffer.slice(0, -1);
+        this.invalidate();
+      }
+      return true;
+    }
+
+    // Single printable character: append to buffer.
+    if (key.length === 1) {
+      state.buffer += key;
+      this.invalidate();
+      return true;
+    }
+
+    // All other named keys are consumed (ignored) while masked mode is active.
+    return true;
+  }
+
   protected override getPalette(): PanelPalette {
     return C;
   }
@@ -57,6 +146,12 @@ export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
   }
 
   public render(width: number, height: number): Line[] {
+    // When masked entry is active, render a dedicated prompt instead of the
+    // normal panel content. No plaintext password appears anywhere in output.
+    if (this.maskedState !== null) {
+      return this.renderMaskedPrompt(width, height);
+    }
+
     const intro = 'Manage local daemon and HTTP-listener auth users, bootstrap state, and active sessions.';
     const snapshot = this.authManager.inspect();
     const users = this.getItems();
@@ -81,7 +176,7 @@ export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
         ...(issueMessages.length > 0
           ? issueMessages.map((issue) => buildPanelLine(width, [[` issue: ${issue}`.slice(0, Math.max(0, width)), C.warn]]))
           : [buildPanelLine(width, [[' local auth posture looks healthy.', C.good]])]),
-        buildGuidanceLine(width, '/auth local rotate-password <user> <password>', 'rotate bootstrap/default credentials and revoke older sessions as needed', C),
+        buildGuidanceLine(width, '/auth local rotate-password <user>', 'open masked password entry for the selected user (no plaintext in history)', C),
       ], C),
     ];
 
@@ -104,7 +199,7 @@ export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
       footerLines.push(
         ...buildDetailBlock(width, 'Selected user', [
           buildPanelLine(width, [[' username ', C.label], [selected.username, C.value], ['  roles ', C.label], [formatRoles(selected.roles).slice(0, Math.max(0, width - 23)), C.info]]),
-          buildPanelLine(width, [[` next: /auth local rotate-password ${selected.username} <password>`.slice(0, Math.max(0, width)), C.dim]]),
+          buildPanelLine(width, [[` next: /auth local rotate-password ${selected.username}`.slice(0, Math.max(0, width)), C.dim]]),
           buildPanelLine(width, [[` next: /auth local delete-user ${selected.username}`.slice(0, Math.max(0, width)), C.dim]]),
         ], C),
       );
@@ -119,7 +214,7 @@ export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
         ])),
       );
     }
-    footerLines.push(buildPanelLine(width, [[' /auth local review  /auth local add-user  /auth local rotate-password  /auth local revoke-session ', C.dim]]));
+    footerLines.push(buildPanelLine(width, [[' /auth local review  /auth local add-user <user>  /auth local rotate-password <user>  (omit password for masked entry) ', C.dim]]));
 
     return this.renderList(width, height, {
       title: 'Local Auth Control Room',
@@ -127,4 +222,29 @@ export class LocalAuthPanel extends ScrollableListPanel<LocalAuthUser> {
       footer: footerLines,
     });
   }
+
+  private renderMaskedPrompt(width: number, height: number): Line[] {
+    const state = this.maskedState!;
+    const actionLabel = state.kind === 'add-user' ? 'Add user' : 'Rotate password';
+    const dots = '•'.repeat(Math.min(32, state.buffer.length));
+    const cursor = '█'; // block cursor
+    const maskedDisplay = state.buffer.length > 0 ? `${dots}${cursor}` : cursor;
+
+    const promptLines: Line[] = [
+      buildPanelLine(width, [[` ${actionLabel}: ${state.username}`, C.value]]),
+      buildPanelLine(width, [['', C.label]]),
+      buildPanelLine(width, [[' Password  ', C.label], [maskedDisplay.slice(0, Math.max(0, width - 12)), C.info]]),
+      buildPanelLine(width, [['', C.label]]),
+      buildPanelLine(width, [[' [Enter] Confirm   [Esc] Cancel   [Backspace] Delete char', C.dim]]),
+    ];
+
+    const workspace = buildPanelWorkspace(width, height, {
+      title: 'Local Auth — Password Entry',
+      intro: `Type a password for ${state.username}. The value is never echoed in plaintext or stored in history.`,
+      sections: [{ lines: promptLines }],
+      palette: C,
+    });
+    while (workspace.length < height) workspace.push(createEmptyLine(width));
+    return workspace;
+  }
 }