@pellux/goodvibes-tui 0.18.11 → 0.18.12

package/src/runtime/perf/slo-collector.ts

@@ -1,375 +0,0 @@
-/**
- * SloCollector — collects SLO duration measurements from runtime events.
- *
- * Listens to the RuntimeEventBus and tracks four critical path latencies:
- * - turn_start_ms: TURN_SUBMITTED → first STREAM_DELTA
- * - cancel_ms: TURN_CANCEL → TURN_COMPLETED or TURN_ERROR
- * - reconnect_recovery_ms: TRANSPORT_RECONNECTING → TRANSPORT_CONNECTED
- * - permission_decision_ms: PERMISSION_REQUESTED → DECISION_EMITTED
- *
- * Maintains a capped rolling window of measurements per SLO and exposes
- * p95 values for PerfMonitor integration via `getMetrics()`.
- */
-
-import type { RuntimeEventBus, RuntimeEventEnvelope, AnyRuntimeEvent } from '@pellux/goodvibes-sdk/platform/runtime/events/index';
-import type { PerfMetric } from '@pellux/goodvibes-sdk/platform/runtime/perf/types';
-
-/** Metric key constants for each SLO measurement. */
-export const SLO_METRICS = {
-  TURN_START: 'slo.turn_start.p95',
-  CANCEL: 'slo.cancel.p95',
-  RECONNECT_RECOVERY: 'slo.reconnect_recovery.p95',
-  PERMISSION_DECISION: 'slo.permission_decision.p95',
-} as const;
-
-/** Maximum number of samples retained in each rolling window. */
-const WINDOW_SIZE = 200;
-
-/**
- * Maximum age for a pending map entry before it is swept as stale.
- * Entries that never receive a follow-up event (e.g. TURN_CANCEL without
- * TURN_COMPLETED due to a connection drop) are evicted after this duration
- * to prevent unbounded memory growth.
- */
-const PENDING_TTL_MS = 60_000;
-
-/** Interval between periodic stale-entry sweeps (ms). */
-const SWEEP_INTERVAL_MS = 30_000;
-
-/**
- * Computes the 95th percentile from a numeric array.
- * Returns 0 for empty arrays.
- */
-function p95(values: readonly number[]): number {
-  if (values.length === 0) return 0;
-  const sorted = [...values].sort((a, b) => a - b);
-  const idx = Math.ceil(sorted.length * 0.95) - 1;
-  return sorted[Math.max(0, idx)] ?? 0;
-}
-
-/**
- * Appends a sample to a capped rolling window.
- * Evicts the oldest entry when the window exceeds WINDOW_SIZE.
- */
-function appendSample(window: number[], sample: number): void {
-  window.push(sample);
-  if (window.length > WINDOW_SIZE) {
-    window.shift();
-  }
-}
-
-/** Minimal shape for an untyped envelope used for payload extraction. */
-type RawEnvelope = RuntimeEventEnvelope<AnyRuntimeEvent['type'], AnyRuntimeEvent>;
-
-/**
- * Coerce a strongly-typed bus callback argument to the raw envelope shape.
- *
- * The RuntimeEventBus `on()` callback receives a per-event typed envelope,
- * but SloCollector reads only generic fields (`.ts`, `.payload.*`). The
- * double-cast is intentional: we lose specificity to gain a uniform access
- * pattern, isolated to this single conversion site.
- */
-function toRaw(env: unknown): RawEnvelope {
-  return env as unknown as RawEnvelope;
-}
-
-/**
- * Safely extract a named field from an envelope payload.
- * Returns `undefined` when the field does not exist on the payload.
- */
-function getField<T>(envelope: RawEnvelope, key: string): T | undefined {
-  const payload = envelope.payload as Record<string, unknown>;
-  return payload[key] as T | undefined;
-}
-
-/**
- * SloCollector subscribes to RuntimeEventBus events and tracks per-SLO
- * duration samples in rolling windows. Call `getMetrics()` to retrieve
- * current p95 values compatible with PerfMonitor's extraMetrics field.
- *
- * @example
- * ```ts
- * const collector = new SloCollector(bus);
- * const metrics = collector.getMetrics();
- * const report = monitor.evaluate({ uiPerf, extraMetrics: Object.fromEntries(
- *   metrics.map(m => [m.name, m.value])
- * )});
- * collector.dispose();
- * ```
- */
-export class SloCollector {
-  /** Rolling window of turn_start_ms samples (TURN_SUBMITTED → first STREAM_DELTA). */
-  private readonly _turnStartSamples: number[] = [];
-  /** Rolling window of cancel_ms samples (TURN_CANCEL → TURN_COMPLETED/ERROR). */
-  private readonly _cancelSamples: number[] = [];
-  /** Rolling window of reconnect_recovery_ms samples (TRANSPORT_RECONNECTING → TRANSPORT_CONNECTED). */
-  private readonly _reconnectSamples: number[] = [];
-  /** Rolling window of permission_decision_ms samples (PERMISSION_REQUESTED → DECISION_EMITTED). */
-  private readonly _permissionSamples: number[] = [];
-
-  /** Pending turn start timestamps keyed by turnId. */
-  private readonly _pendingTurnStart = new Map<string, number>();
-  /** Tracks which turnIds have received their first STREAM_DELTA. */
-  private readonly _seenFirstDelta = new Set<string>();
-  /** Pending cancel timestamps keyed by turnId (set on TURN_CANCEL). */
-  private readonly _pendingCancel = new Map<string, number>();
-  /** Pending reconnect start timestamp. Only the most recent reconnect attempt is tracked. */
-  private _pendingReconnectAt: number | null = null;
-  /** Pending permission request timestamps keyed by callId. */
-  private readonly _pendingPermission = new Map<string, number>();
-
-  /** Registered unsubscribe functions. */
-  private readonly _unsubs: Array<() => void> = [];
-
-  /** Timer handle for the periodic stale-entry sweep. */
-  private _sweepTimer: ReturnType<typeof setInterval> | null = null;
-
-  constructor(bus: RuntimeEventBus) {
-    this._subscribe(bus);
-    this._sweepTimer = setInterval(() => this._sweepPending(), SWEEP_INTERVAL_MS);
-  }
-
-  /**
-   * Attach all event listeners to the bus.
-   */
-  private _subscribe(bus: RuntimeEventBus): void {
-    // ── turn_start_ms ───────────────────────────────────────────────────────
-    this._unsubs.push(
-      bus.on('TURN_SUBMITTED', (env) => {
-        const e = toRaw(env);
-        const turnId = getField<string>(e, 'turnId');
-        if (turnId !== undefined) {
-          this._pendingTurnStart.set(turnId, e.ts);
-          this._seenFirstDelta.delete(turnId);
-        }
-      })
-    );
-
-    this._unsubs.push(
-      bus.on('STREAM_DELTA', (env) => {
-        const e = toRaw(env);
-        const turnId = getField<string>(e, 'turnId');
-        if (turnId === undefined) return;
-        if (this._seenFirstDelta.has(turnId)) return;
-        this._seenFirstDelta.add(turnId);
-        const startAt = this._pendingTurnStart.get(turnId);
-        if (startAt !== undefined) {
-          appendSample(this._turnStartSamples, e.ts - startAt);
-          this._pendingTurnStart.delete(turnId);
-        }
-      })
-    );
-
-    // Clean up stale pending turn starts when a turn ends without streaming
-    this._unsubs.push(
-      bus.on('PREFLIGHT_FAIL', (env) => {
-        const e = toRaw(env);
-        const turnId = getField<string>(e, 'turnId');
-        if (turnId !== undefined) {
-          this._pendingTurnStart.delete(turnId);
-          this._seenFirstDelta.delete(turnId);
-          this._pendingCancel.delete(turnId);
-        }
-      })
-    );
-
-    this._unsubs.push(
-      bus.on('TURN_ERROR', (env) => {
-        const e = toRaw(env);
-        const turnId = getField<string>(e, 'turnId');
-        if (turnId !== undefined) {
-          this._pendingTurnStart.delete(turnId);
-          this._seenFirstDelta.delete(turnId);
-          // Resolve cancel if pending
-          const cancelAt = this._pendingCancel.get(turnId);
-          if (cancelAt !== undefined) {
-            appendSample(this._cancelSamples, e.ts - cancelAt);
-            this._pendingCancel.delete(turnId);
-          }
-        }
-      })
-    );
-
-    this._unsubs.push(
-      bus.on('TURN_COMPLETED', (env) => {
-        const e = toRaw(env);
-        const turnId = getField<string>(e, 'turnId');
-        if (turnId !== undefined) {
-          this._pendingTurnStart.delete(turnId);
-          this._seenFirstDelta.delete(turnId);
-          // Resolve cancel if pending
-          const cancelAt = this._pendingCancel.get(turnId);
-          if (cancelAt !== undefined) {
-            appendSample(this._cancelSamples, e.ts - cancelAt);
-            this._pendingCancel.delete(turnId);
-          }
-        }
-      })
-    );
-
-    // ── cancel_ms ───────────────────────────────────────────────────────────
-    this._unsubs.push(
-      bus.on('TURN_CANCEL', (env) => {
-        const e = toRaw(env);
-        const turnId = getField<string>(e, 'turnId');
-        if (turnId !== undefined) {
-          this._pendingCancel.set(turnId, e.ts);
-        }
-      })
-    );
-
-    // ── reconnect_recovery_ms ───────────────────────────────────────────────
-    this._unsubs.push(
-      bus.on('TRANSPORT_RECONNECTING', (env) => {
-        const e = toRaw(env);
-        const attempt = getField<number>(e, 'attempt');
-        // Track start of reconnect sequence; use first attempt timestamp
-        if (attempt === 1 || this._pendingReconnectAt === null) {
-          this._pendingReconnectAt = e.ts;
-        }
-      })
-    );
-
-    this._unsubs.push(
-      bus.on('TRANSPORT_CONNECTED', (env) => {
-        const e = toRaw(env);
-        if (this._pendingReconnectAt !== null) {
-          appendSample(this._reconnectSamples, e.ts - this._pendingReconnectAt);
-          this._pendingReconnectAt = null;
-        }
-      })
-    );
-
-    // Clear pending reconnect on terminal failure
-    this._unsubs.push(
-      bus.on('TRANSPORT_TERMINAL_FAILURE', () => {
-        this._pendingReconnectAt = null;
-      })
-    );
-
-    // ── permission_decision_ms ──────────────────────────────────────────────
-    this._unsubs.push(
-      bus.on('PERMISSION_REQUESTED', (env) => {
-        const e = toRaw(env);
-        const callId = getField<string>(e, 'callId');
-        if (callId !== undefined) {
-          this._pendingPermission.set(callId, e.ts);
-        }
-      })
-    );
-
-    this._unsubs.push(
-      bus.on('DECISION_EMITTED', (env) => {
-        const e = toRaw(env);
-        const callId = getField<string>(e, 'callId');
-        if (callId !== undefined) {
-          const startAt = this._pendingPermission.get(callId);
-          if (startAt !== undefined) {
-            appendSample(this._permissionSamples, e.ts - startAt);
-            this._pendingPermission.delete(callId);
-          }
-        }
-      })
-    );
-  }
-
-  /**
-   * Sweep all pending maps and evict entries older than PENDING_TTL_MS.
-   *
-   * Called periodically by the sweep timer to prevent unbounded memory growth
-   * when expected follow-up events (e.g. TURN_COMPLETED after TURN_CANCEL)
-   * never arrive due to connection drops or unexpected process termination.
-   */
-  private _sweepPending(): void {
-    const cutoff = Date.now() - PENDING_TTL_MS;
-    for (const [key, ts] of this._pendingTurnStart) {
-      if (ts < cutoff) {
-        this._pendingTurnStart.delete(key);
-        this._seenFirstDelta.delete(key);
-      }
-    }
-    for (const [key, ts] of this._pendingCancel) {
-      if (ts < cutoff) this._pendingCancel.delete(key);
-    }
-    for (const [key, ts] of this._pendingPermission) {
-      if (ts < cutoff) this._pendingPermission.delete(key);
-    }
-    // _pendingReconnectAt is a scalar; clear if stale
-    if (this._pendingReconnectAt !== null && this._pendingReconnectAt < cutoff) {
-      this._pendingReconnectAt = null;
-    }
-  }
-
-  /**
-   * Returns current p95 values for all four SLO metrics as PerfMetric entries.
-   * Metrics with no samples return a value of 0.
-   *
-   * Intended for use with `PerfMonitor.evaluate()` via the `extraMetrics` field:
-   * ```ts
-   * const extras = Object.fromEntries(collector.getMetrics().map(m => [m.name, m.value]));
-   * monitor.evaluate({ uiPerf, extraMetrics: extras });
-   * ```
-   */
-  public getMetrics(): PerfMetric[] {
-    const now = Date.now();
-    return [
-      {
-        name: SLO_METRICS.TURN_START,
-        value: p95(this._turnStartSamples),
-        unit: 'ms',
-        timestamp: now,
-      },
-      {
-        name: SLO_METRICS.CANCEL,
-        value: p95(this._cancelSamples),
-        unit: 'ms',
-        timestamp: now,
-      },
-      {
-        name: SLO_METRICS.RECONNECT_RECOVERY,
-        value: p95(this._reconnectSamples),
-        unit: 'ms',
-        timestamp: now,
-      },
-      {
-        name: SLO_METRICS.PERMISSION_DECISION,
-        value: p95(this._permissionSamples),
-        unit: 'ms',
-        timestamp: now,
-      },
-    ];
-  }
-
-  /**
-   * Returns the number of samples collected for each SLO metric.
-   * Useful for diagnostics to distinguish "no data yet" from an actual 0ms result.
-   */
-  public getSampleCounts(): Readonly<Record<string, number>> {
-    return {
-      [SLO_METRICS.TURN_START]: this._turnStartSamples.length,
-      [SLO_METRICS.CANCEL]: this._cancelSamples.length,
-      [SLO_METRICS.RECONNECT_RECOVERY]: this._reconnectSamples.length,
-      [SLO_METRICS.PERMISSION_DECISION]: this._permissionSamples.length,
-    };
-  }
-
-  /**
-   * Unsubscribes all event listeners and releases resources.
-   * The collector should not be used after disposal.
-   */
-  public dispose(): void {
-    if (this._sweepTimer !== null) {
-      clearInterval(this._sweepTimer);
-      this._sweepTimer = null;
-    }
-    for (const unsub of this._unsubs) {
-      unsub();
-    }
-    this._unsubs.length = 0;
-    this._pendingTurnStart.clear();
-    this._seenFirstDelta.clear();
-    this._pendingCancel.clear();
-    this._pendingPermission.clear();
-    this._pendingReconnectAt = null;
-  }
-}

package/src/runtime/permissions/index.ts

@@ -1,190 +0,0 @@
-/**
- * Runtime permissions public API barrel.
- *
- * Exports the LayeredPolicyEvaluator, all types, rule evaluators, safety checks,
- * and the createPermissionEvaluator() factory function.
- *
- * Feature flag: `permissions-policy-engine` must be enabled to use this module in production.
- */
-
-export { LayeredPolicyEvaluator } from '@pellux/goodvibes-sdk/platform/runtime/permissions/evaluator';
-export { DecisionLog } from '@pellux/goodvibes-sdk/platform/runtime/permissions/decision-log';
-export { runSafetyChecks } from '@pellux/goodvibes-sdk/platform/runtime/permissions/safety-checks';
-export { PermissionSimulator, SimulationEnforcementError } from '@pellux/goodvibes-sdk/platform/runtime/permissions/simulation';
-export { buildDefaultPolicySimulationScenarios, runPolicySimulationScenarios } from '@pellux/goodvibes-sdk/platform/runtime/permissions/simulation-scenarios';
-export { lintPolicyConfig } from '@pellux/goodvibes-sdk/platform/runtime/permissions/lint';
-export { buildPolicyPreflightReview } from '@pellux/goodvibes-sdk/platform/runtime/permissions/preflight';
-export { buildPermissionRuleSuggestions } from '@pellux/goodvibes-sdk/platform/runtime/permissions/rule-suggestions';
-// Policy signing
-export { signBundle, verifyBundle, canonicalise } from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-signer';
-export { loadPolicyBundle, createUnsignedBundle, PolicySignatureError } from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-loader';
-
-export type {
-  PermissionMode,
-  CommandClassification,
-  DecisionReason,
-  SourceLayer,
-  EvaluationStep,
-  PermissionDecision,
-  PolicyRule,
-  PrefixRule,
-  ArgShapeRule,
-  PathScopeRule,
-  NetworkScopeRule,
-  ModeConstraintRule,
-  RuleOrigin,
-  PermissionsConfig,
-  SimulationMode,
-  SimulationResult,
-  DivergenceType,
-  DivergenceRecord,
-  DivergenceStats,
-  DivergenceReport,
-  PermissionSimulatorConfig,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/types';
-
-export type { DecisionLogEntry, DecisionLogQuery } from '@pellux/goodvibes-sdk/platform/runtime/permissions/decision-log';
-export type { SafetyCheckResult } from '@pellux/goodvibes-sdk/platform/runtime/permissions/safety-checks';
-export type { PolicyLintFinding, PolicyLintSeverity } from '@pellux/goodvibes-sdk/platform/runtime/permissions/lint';
-export type { PermissionRuleSuggestion } from '@pellux/goodvibes-sdk/platform/runtime/permissions/rule-suggestions';
-export type {
-  PolicyPreflightStatus,
-  PolicyPreflightServer,
-  PolicyPreflightIssue,
-  PolicyPreflightReview,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/preflight';
-export type {
-  PolicySimulationScenario,
-  PolicySimulationScenarioResult,
-  PolicySimulationSummary,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/simulation-scenarios';
-// Policy signing
-export type {
-  PolicyBundleId,
-  SignatureStatus,
-  ProvenanceSource,
-  SignedPolicyBundle,
-  VerifyResult,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-signer';
-export type {
-  PolicyBundlePayload,
-  BundleProvenance,
-  PolicyLoadResult,
-  PolicyLoaderOptions,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-loader';
-
-export {
-  evaluatePrefixRule,
-  evaluateArgShapeRule,
-  evaluatePathScopeRule,
-  evaluateNetworkScopeRule,
-  evaluateModeConstraintRule,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/rules/index';
-
-// Divergence dashboard
-export {
-  DivergenceDashboard,
-  DivergenceGateError,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/divergence-dashboard';
-export type {
-  DivergenceTrendEntry,
-  EnforceGateStatus,
-  EnforceGateResult,
-  DivergenceDashboardSnapshot,
-  DivergenceDashboardConfig,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/divergence-dashboard';
-
-// Policy-as-Code
-export { PolicyRegistry } from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-registry';
-export {
-  PolicyRuntimeState,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-runtime';
-export type {
-  BundleLifecycleState,
-  PolicyBundleVersion,
-  PolicyDiffResult,
-  PromoteResult,
-  RollbackResult,
-  PolicyRegistryConfig,
-} from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-registry';
-
-// ── Factory ──────────────────────────────────────────────────────────────────────
-
-import { LayeredPolicyEvaluator } from '@pellux/goodvibes-sdk/platform/runtime/permissions/evaluator';
-import { PermissionSimulator } from '@pellux/goodvibes-sdk/platform/runtime/permissions/simulation';
-import type { PermissionsConfig, SimulationMode, PermissionSimulatorConfig } from '@pellux/goodvibes-sdk/platform/runtime/permissions/types';
-import type { FeatureFlagManager } from '@pellux/goodvibes-sdk/platform/runtime/feature-flags/manager';
-import type { BundleProvenance } from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-loader';
-
-/**
- * createPermissionEvaluator — Factory function for the runtime permission evaluator.
- *
- * Returns a LayeredPolicyEvaluator configured with the given options.
- * Designed as the primary entry point for integrating the runtime permissions system.
- *
- * The returned evaluator exposes:
- *   - `evaluate(toolName, args)` — perform a full layered evaluation
- *   - `recordSessionOverride(...)` — cache a user prompt response
- *   - `log` — DecisionLog for audit queries
- *   - `getMode()` — inspect the active mode
- *
- * @example
- * ```ts
- * const perms = createPermissionEvaluator({ mode: 'default', rules: [] });
- * const decision = perms.evaluate('write', { path: '/tmp/out.txt' });
- * if (!decision.allowed) {
- *   console.error('denied:', decision.reason);
- * }
- * ```
- *
- * @param config     — Optional configuration; all fields have safe defaults.
- * @param provenance — Optional bundle provenance (GC-PERM-011).
- */
-export function createPermissionEvaluator(
-  config: PermissionsConfig = {},
-  provenance?: BundleProvenance,
-): LayeredPolicyEvaluator {
-  return new LayeredPolicyEvaluator(config, provenance);
-}
-
-/**
- * createPermissionSimulator — Factory for `PermissionSimulator`.
- *
- * Creates a dual-evaluator simulation pipeline for the runtime permissions system that runs
- * both the actual and simulated evaluators in parallel, tracking divergence.
- *
- * Requires the `permissions-simulation` feature flag to be enabled.
- *
- * @param actualConfig    — Config for the authoritative evaluator.
- * @param simulatedConfig — Config for the candidate evaluator.
- * @param simulationMode  — Controls enforcement and warning behaviour.
- * @param config          — Optional tuning: record limit, divergence threshold.
- *
- * @example
- * ```ts
- * const simulator = createPermissionSimulator(
- *   { mode: 'default', rules: currentRules },
- *   { mode: 'default', rules: candidateRules },
- *   'warn-on-divergence',
- * );
- * const result = simulator.evaluate('write', { path: '/tmp/out.txt' });
- * const report = simulator.getDivergenceReport();
- * ```
- */
-export function createPermissionSimulator(
-  actualConfig: PermissionsConfig,
-  simulatedConfig: PermissionsConfig,
-  simulationMode: SimulationMode,
-  config: PermissionSimulatorConfig = {},
-  flagManager?: FeatureFlagManager,
-): PermissionSimulator {
-  if (flagManager && !flagManager.isEnabled('permissions-simulation')) {
-    throw new Error('Feature flag "permissions-simulation" is not enabled');
-  }
-  return new PermissionSimulator(
-    actualConfig,
-    simulatedConfig,
-    simulationMode,
-    config,
-  );
-}

package/src/runtime/permissions/policy-runtime.ts

@@ -1 +0,0 @@
-export * from '@pellux/goodvibes-sdk/platform/runtime/permissions/policy-runtime';

package/src/runtime/permissions/preflight.ts

@@ -1,101 +0,0 @@
-import type { GoodVibesConfig, DeepReadonly } from '../../config/index.ts';
-import type { PolicyLintFinding } from '@pellux/goodvibes-sdk/platform/runtime/permissions/lint';
-import type { McpServerRole, McpTrustMode } from '@pellux/goodvibes-sdk/platform/runtime/mcp/types';
-
-export type PolicyPreflightStatus = 'pass' | 'warn' | 'block';
-
-export interface PolicyPreflightServer {
-  readonly serverName: string;
-  readonly trustMode: McpTrustMode;
-  readonly role: McpServerRole;
-  readonly allowedPaths: readonly string[];
-  readonly allowedHosts: readonly string[];
-}
-
-export interface PolicyPreflightIssue {
-  readonly severity: 'info' | 'warn' | 'error';
-  readonly source: 'policy' | 'runtime' | 'mcp';
-  readonly message: string;
-  readonly detail?: string;
-  readonly serverName?: string;
-}
-
-export interface PolicyPreflightReview {
-  readonly generatedAt: string;
-  readonly status: PolicyPreflightStatus;
-  readonly summary: string;
-  readonly issueCount: number;
-  readonly issues: readonly PolicyPreflightIssue[];
-}
-
-function summarize(status: PolicyPreflightStatus, issues: readonly PolicyPreflightIssue[]): string {
-  if (issues.length === 0) {
-    return 'No blocking or warning conditions detected for the current policy state.';
-  }
-  const errors = issues.filter((issue) => issue.severity === 'error').length;
-  const warnings = issues.filter((issue) => issue.severity === 'warn').length;
-  if (status === 'block') {
-    return `${errors} blocking issue${errors === 1 ? '' : 's'} and ${warnings} warning${warnings === 1 ? '' : 's'} require attention before high-risk runs.`;
-  }
-  return `${warnings} warning${warnings === 1 ? '' : 's'} detected in the current policy posture.`;
-}
-
-export function buildPolicyPreflightReview(params: {
-  config: DeepReadonly<GoodVibesConfig>;
-  lintFindings: readonly PolicyLintFinding[];
-  mcpServers: readonly PolicyPreflightServer[];
-}): PolicyPreflightReview {
-  const issues: PolicyPreflightIssue[] = [];
-
-  for (const finding of params.lintFindings) {
-    issues.push({
-      severity: finding.severity === 'error' ? 'error' : finding.severity === 'warn' ? 'warn' : 'info',
-      source: 'policy',
-      message: finding.message,
-      detail: finding.ruleId ? `rule=${finding.ruleId}` : undefined,
-    });
-  }
-
-  if (params.config.permissions.mode === 'allow-all') {
-    issues.push({
-      severity: 'error',
-      source: 'runtime',
-      message: 'Permission mode is allow-all.',
-      detail: 'All runtime permission checks are bypassed for local tools.',
-    });
-  }
-
-  for (const server of params.mcpServers) {
-    if (server.trustMode === 'allow-all') {
-      issues.push({
-        severity: 'error',
-        source: 'mcp',
-        serverName: server.serverName,
-        message: `MCP server "${server.serverName}" is in allow-all mode.`,
-        detail: `role=${server.role} paths=${server.allowedPaths.length} hosts=${server.allowedHosts.length}`,
-      });
-    } else if (server.trustMode === 'ask-on-risk') {
-      issues.push({
-        severity: 'warn',
-        source: 'mcp',
-        serverName: server.serverName,
-        message: `MCP server "${server.serverName}" requires approval for risky actions.`,
-        detail: `role=${server.role} paths=${server.allowedPaths.length} hosts=${server.allowedHosts.length}`,
-      });
-    }
-  }
-
-  const status: PolicyPreflightStatus = issues.some((issue) => issue.severity === 'error')
-    ? 'block'
-    : issues.some((issue) => issue.severity === 'warn')
-      ? 'warn'
-      : 'pass';
-
-  return {
-    generatedAt: new Date().toISOString(),
-    status,
-    summary: summarize(status, issues),
-    issueCount: issues.length,
-    issues,
-  };
-}