@pellux/goodvibes-tui 0.18.11 → 0.18.12

package/src/runtime/bootstrap-command-context.ts

@@ -70,12 +70,12 @@ export type CreateBootstrapCommandContextOptions = {
   integrationHelpers?: IntegrationHelperService;
   automationManager?: ShellAutomationManagerRuntimeService;
   knowledgeService?: KnowledgeService;
-  providerOptimizer?: import('../providers/optimizer.ts').ProviderOptimizer;
+  providerOptimizer?: import('@pellux/goodvibes-sdk/platform/providers/optimizer').ProviderOptimizer;
   pluginManager?: PluginManager;
   hookWorkbench?: HookWorkbench;
   agentManager?: ShellAgentManagerService;
   modeManager?: ShellModeManagerService;
-  sessionManager?: import('../sessions/manager.ts').SessionManager;
+  sessionManager?: import('@pellux/goodvibes-sdk/platform/sessions/manager').SessionManager;
   profileManager?: import('@pellux/goodvibes-sdk/platform/profiles/manager').ProfileManager;
   bookmarkManager?: import('@pellux/goodvibes-sdk/platform/bookmarks/manager').BookmarkManager;
   favoritesStore?: import('@pellux/goodvibes-sdk/platform/providers/favorites').FavoritesStore;
@@ -87,7 +87,7 @@ export type CreateBootstrapCommandContextOptions = {
   localUserAuthManager?: import('@pellux/goodvibes-sdk/platform/security/user-auth').UserAuthManager;
   tokenAuditor?: import('@pellux/goodvibes-sdk/platform/security/token-audit').ApiTokenAuditor;
   replayEngine?: import('@pellux/goodvibes-sdk/platform/core/deterministic-replay').DeterministicReplayEngine;
-  webhookNotifier?: import('../integrations/webhooks.ts').WebhookNotifier;
+  webhookNotifier?: import('@pellux/goodvibes-sdk/platform/integrations/webhooks').WebhookNotifier;
   sessionMemoryStore?: import('@pellux/goodvibes-sdk/platform/core/session-memory').SessionMemoryStore;
   changeTracker?: import('@pellux/goodvibes-sdk/platform/sessions/change-tracker').SessionChangeTracker;
   planManager?: ShellPlanManagerService;

package/src/runtime/bootstrap-command-parts.ts

@@ -85,8 +85,8 @@ export interface BootstrapCommandSectionOptions {
   readonly knowledgeService?: KnowledgeService;
   readonly pluginManager?: PluginManager;
   readonly hookWorkbench?: HookWorkbench;
-  readonly providerOptimizer?: import('../providers/optimizer.ts').ProviderOptimizer;
-  readonly sessionManager?: import('../sessions/manager.ts').SessionManager;
+  readonly providerOptimizer?: import('@pellux/goodvibes-sdk/platform/providers/optimizer').ProviderOptimizer;
+  readonly sessionManager?: import('@pellux/goodvibes-sdk/platform/sessions/manager').SessionManager;
   readonly profileManager?: import('@pellux/goodvibes-sdk/platform/profiles/manager').ProfileManager;
   readonly bookmarkManager?: import('@pellux/goodvibes-sdk/platform/bookmarks/manager').BookmarkManager;
   readonly favoritesStore?: import('@pellux/goodvibes-sdk/platform/providers/favorites').FavoritesStore;
@@ -97,7 +97,7 @@ export interface BootstrapCommandSectionOptions {
   readonly localUserAuthManager?: import('@pellux/goodvibes-sdk/platform/security/user-auth').UserAuthManager;
   readonly tokenAuditor?: import('@pellux/goodvibes-sdk/platform/security/token-audit').ApiTokenAuditor;
   readonly replayEngine?: import('@pellux/goodvibes-sdk/platform/core/deterministic-replay').DeterministicReplayEngine;
-  readonly webhookNotifier?: import('../integrations/webhooks.ts').WebhookNotifier;
+  readonly webhookNotifier?: import('@pellux/goodvibes-sdk/platform/integrations/webhooks').WebhookNotifier;
   readonly sessionMemoryStore?: import('@pellux/goodvibes-sdk/platform/core/session-memory').SessionMemoryStore;
   readonly sessionLineageTracker?: import('@pellux/goodvibes-sdk/platform/core/session-lineage').SessionLineageTracker;
   readonly changeTracker?: import('@pellux/goodvibes-sdk/platform/sessions/change-tracker').SessionChangeTracker;

package/src/runtime/bootstrap-core.ts

@@ -19,9 +19,9 @@ import { ForensicsCollector, ForensicsRegistry } from '@pellux/goodvibes-sdk/pla
 import {
   generateUserSessionId,
 } from '@pellux/goodvibes-sdk/platform/runtime/session-persistence';
-import { loadBootstrapSystemPrompt, syncConfiguredServices } from './bootstrap-helpers.ts';
+import { loadBootstrapSystemPrompt, syncConfiguredServices } from '@pellux/goodvibes-sdk/platform/runtime/bootstrap-helpers';
 import { registerBootstrapHookBridge } from './bootstrap-hook-bridge.ts';
-import { registerBootstrapRuntimeEvents } from './bootstrap-runtime-events.ts';
+import { registerBootstrapRuntimeEvents } from '@pellux/goodvibes-sdk/platform/runtime/bootstrap-runtime-events';
 import { createRuntimeServices, type RuntimeServices } from './services.ts';
 import { createUiRuntimeServices, type UiRuntimeServices } from './ui-services.ts';
 

package/src/runtime/bootstrap-hook-bridge.ts

@@ -9,7 +9,7 @@ import { HelperModel } from '@pellux/goodvibes-sdk/platform/config/helper-model'
 import type { ConfigManager } from '@pellux/goodvibes-sdk/platform/config/manager';
 import { formatReturnContextForDisplay, getReturnContextMode, maybeAssistReturnContextSummary } from '@pellux/goodvibes-sdk/platform/runtime/session-return-context';
 import type { SharedSessionBroker } from '@pellux/goodvibes-sdk/platform/control-plane/index';
-import type { SessionManager } from '../sessions/manager.ts';
+import type { SessionManager } from '@pellux/goodvibes-sdk/platform/sessions/manager';
 import type { PanelManager } from '../panels/panel-manager.ts';
 import type { ProviderRegistry } from '@pellux/goodvibes-sdk/platform/providers/registry';
 import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils/error-display';

package/src/runtime/bootstrap-shell.ts

@@ -20,7 +20,7 @@ import { getConfigSnapshot } from '../config/index.ts';
 import { createBootstrapCommandContext } from './bootstrap-command-context.ts';
 import { createResumeSessionHandler } from './bootstrap-hook-bridge.ts';
 import { logger } from '@pellux/goodvibes-sdk/platform/utils/logger';
-import { loadBootstrapSystemPrompt } from './bootstrap-helpers.ts';
+import { loadBootstrapSystemPrompt } from '@pellux/goodvibes-sdk/platform/runtime/bootstrap-helpers';
 import { createShellPlanRuntime, createShellRemoteCommandService } from '@pellux/goodvibes-sdk/platform/runtime/shell-command-services';
 import { createRuntimeFoundationClients } from '@pellux/goodvibes-sdk/platform/runtime/foundation-clients';
 import type { ControlPlaneRecentEvent } from '@pellux/goodvibes-sdk/platform/control-plane/gateway';

package/src/runtime/bootstrap.ts

@@ -32,9 +32,9 @@ import {
   loadLastConversation,
   writeLastSessionPointer,
 } from '@pellux/goodvibes-sdk/platform/runtime/session-persistence';
-import { startBackgroundProviderRegistration } from './bootstrap-background.ts';
-import { restoreSavedModel } from './bootstrap-helpers.ts';
-import { startExternalServices, type ExternalServicesHandle } from './bootstrap-services.ts';
+import { startBackgroundProviderRegistration } from '@pellux/goodvibes-sdk/platform/runtime/bootstrap-background';
+import { restoreSavedModel } from '@pellux/goodvibes-sdk/platform/runtime/bootstrap-helpers';
+import { startExternalServices, type ExternalServicesHandle } from '@pellux/goodvibes-sdk/platform/runtime/bootstrap-services';
 import type { UiRuntimeServices } from './ui-services.ts';
 import { createDeferredStartupCoordinator } from '@pellux/goodvibes-sdk/platform/runtime/deferred-startup';
 import { initializeBootstrapCore } from './bootstrap-core.ts';
@@ -128,7 +128,7 @@ export async function bootstrapRuntime(
   const workingDir = options.workingDir;
   const configManager = options.configManager;
   const controlPlaneRecentEventsRef: {
-    value: (limit: number) => readonly import('../control-plane/gateway.ts').ControlPlaneRecentEvent[];
+    value: (limit: number) => readonly import('@pellux/goodvibes-sdk/platform/control-plane/gateway').ControlPlaneRecentEvent[];
   } = {
     value: (_limit) => [],
   };
@@ -358,6 +358,7 @@ export async function bootstrapRuntime(
     restoreSavedModel,
     systemMessageRouter,
     shellPaths: services.shellPaths,
+    surfaceRoot: 'tui',
   });
   if (configManager.get('automation.enabled')) {
     deferredStartup.schedule({

package/src/runtime/services.ts

@@ -37,7 +37,7 @@ import { HookDispatcher, createHookWorkbench, type HookWorkbench } from '@pellux
 import { PluginManager } from '@pellux/goodvibes-sdk/platform/plugins/manager';
 import { BookmarkManager } from '@pellux/goodvibes-sdk/platform/bookmarks/manager';
 import { ProfileManager } from '@pellux/goodvibes-sdk/platform/profiles/manager';
-import { SessionManager } from '../sessions/manager.ts';
+import { SessionManager } from '@pellux/goodvibes-sdk/platform/sessions/manager';
 import { CrossSessionTaskRegistry } from '@pellux/goodvibes-sdk/platform/sessions/orchestration/index';
 import { ApiTokenAuditor } from '@pellux/goodvibes-sdk/platform/security/token-audit';
 import { UserAuthManager } from '@pellux/goodvibes-sdk/platform/security/user-auth';
@@ -234,7 +234,7 @@ export function createRuntimeServices(options: RuntimeServicesOptions): RuntimeS
   });
   const profileManager = new ProfileManager(shellPaths.resolveUserPath('tui', 'profiles'));
   const bookmarkManager = new BookmarkManager(shellPaths.resolveUserPath('tui', 'bookmarks'));
-  const sessionManager = new SessionManager(workingDirectory);
+  const sessionManager = new SessionManager(workingDirectory, { surfaceRoot: 'tui' });
   const sessionOrchestration = new CrossSessionTaskRegistry(
     shellPaths.resolveProjectPath('tui', 'sessions', 'task-graph.json'),
   );

package/src/runtime/ui-read-models-observability-security.ts

@@ -26,8 +26,8 @@ export interface UiSecuritySnapshot {
     readonly lintFindingCount: number;
   };
   readonly deniedPermissions: number;
-  readonly incidents: ReturnType<import('./forensics/index.ts').ForensicsRegistry['getAll']>;
-  readonly latestIncident: ReturnType<import('./forensics/index.ts').ForensicsRegistry['latest']>;
+  readonly incidents: ReturnType<import('@pellux/goodvibes-sdk/platform/runtime/forensics/index').ForensicsRegistry['getAll']>;
+  readonly latestIncident: ReturnType<import('@pellux/goodvibes-sdk/platform/runtime/forensics/index').ForensicsRegistry['latest']>;
   readonly mcpServers: readonly McpSecuritySnapshot[];
   readonly recentMcpDecisions: readonly McpDecisionRecord[];
   readonly attackPathReview: ReturnType<typeof buildMcpAttackPathReview>;

package/src/runtime/ui-read-models-observability-system.ts

@@ -49,7 +49,7 @@ export interface UiCockpitSnapshot {
   readonly tokenScopeViolationCount: number;
   readonly tokenRotationWarningCount: number;
   readonly incidentCount: number;
-  readonly latestIncident: ReturnType<import('./forensics/index.ts').ForensicsRegistry['latest']>;
+  readonly latestIncident: ReturnType<import('@pellux/goodvibes-sdk/platform/runtime/forensics/index').ForensicsRegistry['latest']>;
   readonly elevatedMcp: number;
   readonly unhealthyMcp: number;
   readonly erroredPlugins: number;

package/src/runtime/ui-service-queries.ts

@@ -8,7 +8,7 @@ import type {
   ProviderSubscription,
 } from '@pellux/goodvibes-sdk/platform/config/subscriptions';
 import type { LocalAuthSnapshot } from '@pellux/goodvibes-sdk/platform/security/user-auth';
-import type { SessionInfo } from '../sessions/manager.ts';
+import type { SessionInfo } from '@pellux/goodvibes-sdk/platform/sessions/manager';
 import type { Tool } from '@pellux/goodvibes-sdk/platform/types/tools';
 import type { ModelDefinition } from '@pellux/goodvibes-sdk/platform/providers/registry';
 import type {

package/src/tools/index.ts

@@ -67,7 +67,7 @@ export function registerAllTools(
     channelRegistry?: ChannelPluginRegistry | null;
     remoteRunnerRegistry?: RemoteRunnerRegistry;
     workflowServices: ReturnType<typeof createWorkflowServices>;
-    mcpRegistry?: import('../mcp/registry.ts').McpRegistry;
+    mcpRegistry?: import('@pellux/goodvibes-sdk/platform/mcp/registry').McpRegistry;
     sessionOrchestration?: CrossSessionTaskRegistry;
     sandboxSessionRegistry?: SandboxSessionRegistry;
     workingDirectory: string;

package/src/version.ts

@@ -6,7 +6,7 @@ import { join } from 'node:path';
 // The prebuild script updates the fallback value before compilation.
 // Uses import.meta.dir (Bun) to locate package.json relative to this file,
 // which is correct regardless of the process working directory.
-let _version = '0.18.11';
+let _version = '0.18.12';
 try {
   const pkg = JSON.parse(readFileSync(join(import.meta.dir, '..', 'package.json'), 'utf-8'));
   _version = pkg.version ?? _version;

package/src/acp/connection.ts

@@ -1,447 +0,0 @@
-/**
- * AcpConnection — Per-subagent ACP connection.
- *
- * Spawns a child process via Bun.spawn and connects to it via ClientSideConnection
- * using ndJsonStream over stdio. Implements the ACP Client interface so the
- * subagent can request permissions and send session updates.
- */
-
-import { ClientSideConnection, ndJsonStream } from '@agentclientprotocol/sdk';
-import type {
-  Client,
-  Agent,
-  SessionNotification,
-  RequestPermissionRequest,
-  RequestPermissionResponse,
-} from '@pellux/goodvibes-sdk/platform/acp/protocol';
-import type { SubagentInfo, SubagentResult, SubagentTask } from '@pellux/goodvibes-sdk/platform/acp/protocol';
-import type { PermissionCategory } from '@pellux/goodvibes-sdk/platform/permissions/manager';
-import type { PermissionRequestHandler } from '@pellux/goodvibes-sdk/platform/permissions/prompt';
-import { logger } from '@pellux/goodvibes-sdk/platform/utils/logger';
-import { analyzePermissionRequest } from '@pellux/goodvibes-sdk/platform/permissions/analysis';
-import { AcpError } from '@pellux/goodvibes-sdk/platform/types/errors';
-import { VERSION } from '../version.ts';
-import type { RuntimeEventBus } from '@pellux/goodvibes-sdk/platform/runtime/events/index';
-import {
-  emitAgentCancelled,
-  emitAgentCompleted,
-  emitAgentFailed,
-  emitAgentStreamDelta,
-  emitTransportAuthenticating,
-  emitTransportConnected,
-  emitTransportDisconnected,
-  emitTransportInitializing,
-  emitTransportSyncing,
-  emitTransportTerminalFailure,
-} from '@pellux/goodvibes-sdk/platform/runtime/emitters/index';
-import type { HookDispatcher } from '@pellux/goodvibes-sdk/platform/hooks/index';
-import type { HookCategory, HookEventPath, HookPhase } from '@pellux/goodvibes-sdk/platform/hooks/types';
-import { summarizeError } from '@pellux/goodvibes-sdk/platform/utils/error-display';
-
-/** Shape of an agent_message_chunk session update that carries text content. */
-interface MessageChunkUpdate {
-  sessionUpdate: 'agent_message_chunk';
-  content?: Array<{ type: string; text?: string }>;
-}
-
-/** Runtime type guard for agent_message_chunk updates. */
-function isMessageChunk(update: { sessionUpdate?: unknown }): update is MessageChunkUpdate {
-  return (
-    update.sessionUpdate === 'agent_message_chunk' &&
-    ('content' in update)
-  );
-}
-
-/**
- * AcpConnection manages the lifecycle of a single subagent child process.
- *
- * Lifecycle:
- *   1. Construct with spawn params
- *   2. Call run() — spawns child, performs ACP handshake, starts a session
- *   3. Resolves with SubagentResult when the subagent completes or is cancelled
- *   4. Call cancel() to abort
- */
-export class AcpConnection {
-  public readonly id: string;
-  private info: SubagentInfo;
-  private spawnCmd: string[];
-  private requestPermission: PermissionRequestHandler;
-  private runtimeBus: RuntimeEventBus | null;
-  private conn: ClientSideConnection | null = null;
-  private sessionId: string | null = null;
-  private childProcess: ReturnType<typeof Bun.spawn> | null = null;
-  private toolCallsMade = 0;
-  private lastProgressText = '';
-  private transportClosed = false;
-  private readonly hookDispatcher: Pick<HookDispatcher, 'fire'> | null;
-
-  constructor(
-    id: string,
-    private task: SubagentTask,
-    spawnCmd: string[],
-    requestPermission: PermissionRequestHandler = async () => ({ approved: false, remember: false }),
-    runtimeBus: RuntimeEventBus | null = null,
-    hookDispatcher: Pick<HookDispatcher, 'fire'> | null = null,
-  ) {
-    this.id = id;
-    this.spawnCmd = spawnCmd;
-    this.requestPermission = requestPermission;
-    this.runtimeBus = runtimeBus;
-    this.hookDispatcher = hookDispatcher;
-    this.info = {
-      id,
-      task: task.description,
-      status: 'running',
-      startedAt: Date.now(),
-    };
-  }
-
-  /** Current info snapshot. */
-  getInfo(): SubagentInfo {
-    return { ...this.info };
-  }
-
-  /**
-   * Spawn the child process, perform the ACP handshake, and run the prompt.
-   * Resolves with SubagentResult when the subagent completes or errors.
-   */
-  async run(): Promise<SubagentResult> {
-    const startedAt = this.info.startedAt;
-
-    try {
-      this.transportClosed = false;
-      this.emitTransportInitializing();
-
-      // 1. Spawn child process with piped stdio
-      this.childProcess = Bun.spawn(this.spawnCmd, {
-        stdin: 'pipe',
-        stdout: 'pipe',
-        stderr: 'pipe',
-      });
-
-      // 2. Build ndJsonStream from child stdio.
-      //
-      // In Bun, childProcess.stdin is a FileSink (not a Web WritableStream).
-      // ndJsonStream requires a Web WritableStream<Uint8Array> so it can call
-      // .getWriter() internally.  Wrap the FileSink in a WritableStream adapter.
-      if (!this.childProcess.stdin) {
-        throw new AcpError('ACP subprocess stdin not available — was it spawned with stdin: "pipe"?');
-      }
-      const bunStdin = this.childProcess.stdin as import('bun').FileSink;
-      const stdinStream = new WritableStream<Uint8Array>({
-        write(chunk) {
-          bunStdin.write(chunk);
-        },
-        close() {
-          bunStdin.end();
-        },
-        abort() {
-          bunStdin.end();
-        },
-      });
-
-      const stream = ndJsonStream(
-        stdinStream,
-        // Bun's piped stdout is ReadableStream-compatible at runtime — getReader() works
-        // correctly. The double-cast is safe here because Bun's ReadStream implements the
-        // same interface, unlike stdin (FileSink) which lacks getWriter().
-        this.childProcess.stdout as unknown as ReadableStream<Uint8Array>,
-      );
-
-      // 3. Build the Client implementation that handles agent callbacks
-      const clientImpl: Client = this.buildClientImpl();
-
-      // 4. Create the ClientSideConnection (TUI = ACP client, child = ACP agent)
-      this.conn = new ClientSideConnection((_agent: Agent) => clientImpl, stream);
-
-      // 5. ACP handshake: initialize (protocolVersion is a number)
-      this.emitTransportAuthenticating();
-      await this.conn.initialize({
-        protocolVersion: 1,
-        clientInfo: { name: 'goodvibes-tui', version: VERSION },
-        clientCapabilities: {},
-      });
-
-      // 6. Create a session (cwd is required, mcpServers is required)
-      const sessionResp = await this.conn.newSession({
-        cwd: this.task.workingDirectory,
-        mcpServers: [],
-      });
-      this.sessionId = sessionResp.sessionId;
-      this.emitTransportConnected();
-      this.emitTransportSyncing();
-
-      // 7. Send the prompt (uses 'prompt' field with ContentBlock array)
-      const promptResp = await this.conn.prompt({
-        sessionId: this.sessionId,
-        prompt: [
-          {
-            type: 'text' as const,
-            text: this.buildPromptText(),
-          },
-        ],
-      });
-
-      const output = this.lastProgressText || `Completed with stop reason: ${promptResp.stopReason}`;
-      const result: SubagentResult = {
-        id: this.id,
-        success: promptResp.stopReason !== 'cancelled',
-        output,
-        toolCallsMade: this.toolCallsMade,
-        duration: Date.now() - startedAt,
-      };
-
-      this.info.status = result.success ? 'complete' : 'error';
-      if (this.runtimeBus) {
-        emitAgentCompleted(this.runtimeBus, this.emitterContext(), {
-          agentId: this.id,
-          durationMs: result.duration,
-          output: result.output,
-          toolCallsMade: result.toolCallsMade,
-        });
-      }
-      this.emitTransportDisconnected('ACP session completed', false);
-      return result;
-    } catch (err) {
-      const error = err instanceof Error ? err : new Error(summarizeError(err));
-      this.info.status = 'error';
-      if (this.runtimeBus) {
-        emitAgentFailed(this.runtimeBus, this.emitterContext(), {
-          agentId: this.id,
-          error: error.message,
-          durationMs: Date.now() - startedAt,
-        });
-      }
-      this.emitTransportTerminalFailure(error.message);
-      return {
-        id: this.id,
-        success: false,
-        output: error.message,
-        toolCallsMade: this.toolCallsMade,
-        duration: Date.now() - startedAt,
-      };
-    } finally {
-      this.cleanup();
-    }
-  }
-
-  /** Cancel the running subagent. */
-  async cancel(): Promise<void> {
-    if (this.conn && this.sessionId) {
-      try {
-        await this.conn.cancel({ sessionId: this.sessionId });
-      } catch (err) {
-        // Best-effort — kill the child if cancel fails
-        logger.error('AcpConnection.cancel: failed to send cancel to subagent', { id: this.id, err: summarizeError(err) });
-      }
-    }
-    this.info.status = 'cancelled';
-    if (this.runtimeBus) {
-      emitAgentCancelled(this.runtimeBus, this.emitterContext(), {
-        agentId: this.id,
-        reason: 'ACP session cancelled',
-      });
-    }
-    this.emitTransportDisconnected('ACP session cancelled', false);
-    this.cleanup();
-  }
-
-  private emitterContext(): import('../runtime/emitters/index.ts').EmitterContext {
-    return {
-      sessionId: 'acp-connection',
-      traceId: `acp-connection:${this.id}`,
-      source: 'acp-connection',
-    };
-  }
-
-  private transportId(): string {
-    return `acp:${this.id}`;
-  }
-
-  private transportEndpoint(): string {
-    return `stdio://subagent/${this.id}`;
-  }
-
-  private emitTransportInitializing(): void {
-    if (!this.runtimeBus) return;
-    emitTransportInitializing(this.runtimeBus, this.emitterContext(), {
-      transportId: this.transportId(),
-      protocol: 'acp-stdio',
-    });
-    void this.fireTransportHook('initializing', {
-      transportId: this.transportId(),
-      protocol: 'acp-stdio',
-    });
-  }
-
-  private emitTransportAuthenticating(): void {
-    if (!this.runtimeBus) return;
-    emitTransportAuthenticating(this.runtimeBus, this.emitterContext(), {
-      transportId: this.transportId(),
-    });
-    void this.fireTransportHook('authenticating', {
-      transportId: this.transportId(),
-    });
-  }
-
-  private emitTransportConnected(): void {
-    if (!this.runtimeBus) return;
-    emitTransportConnected(this.runtimeBus, this.emitterContext(), {
-      transportId: this.transportId(),
-      endpoint: this.transportEndpoint(),
-    });
-    void this.fireTransportHook('connected', {
-      transportId: this.transportId(),
-      endpoint: this.transportEndpoint(),
-    });
-  }
-
-  private emitTransportSyncing(): void {
-    if (!this.runtimeBus) return;
-    emitTransportSyncing(this.runtimeBus, this.emitterContext(), {
-      transportId: this.transportId(),
-    });
-    void this.fireTransportHook('syncing', {
-      transportId: this.transportId(),
-    });
-  }
-
-  private emitTransportDisconnected(reason: string, willRetry: boolean): void {
-    if (!this.runtimeBus || this.transportClosed) return;
-    this.transportClosed = true;
-    emitTransportDisconnected(this.runtimeBus, this.emitterContext(), {
-      transportId: this.transportId(),
-      reason,
-      willRetry,
-    });
-    void this.fireTransportHook('disconnected', {
-      transportId: this.transportId(),
-      reason,
-      willRetry,
-    });
-  }
-
-  private emitTransportTerminalFailure(error: string): void {
-    if (!this.runtimeBus || this.transportClosed) return;
-    this.transportClosed = true;
-    emitTransportTerminalFailure(this.runtimeBus, this.emitterContext(), {
-      transportId: this.transportId(),
-      error,
-    });
-    void this.fireTransportHook('failed', {
-      transportId: this.transportId(),
-      error,
-    });
-  }
-
-  private async fireTransportHook(specific: string, payload: Record<string, unknown>): Promise<void> {
-    if (!this.hookDispatcher) return;
-    try {
-      await this.hookDispatcher.fire({
-        path: `Lifecycle:transport:${specific}` as HookEventPath,
-        phase: 'Lifecycle' as HookPhase,
-        category: 'transport' as HookCategory,
-        specific,
-        sessionId: 'acp-connection',
-        timestamp: Date.now(),
-        payload,
-      });
-    } catch {
-      // Transport hooks are best-effort and must not break ACP transport.
-    }
-  }
-
-  private cleanup(): void {
-    try {
-      this.childProcess?.kill();
-    } catch (err) {
-      logger.error('AcpConnection.cleanup: failed to kill child process', { id: this.id, err: summarizeError(err) });
-    }
-    this.childProcess = null;
-    this.conn = null;
-    this.sessionId = null;
-  }
-
-  private buildClientImpl(): Client {
-    return {
-      /** Forward permission requests through the shell-owned permission controller. */
-      requestPermission: (params: RequestPermissionRequest): Promise<RequestPermissionResponse> => {
-        const category: PermissionCategory = 'delegate';
-        const callId = `acp-${this.id}-${Date.now()}`;
-        const toolTitle = params.toolCall?.title ?? 'unknown';
-        const approveOptionId = params.options[0]?.optionId ?? 'allow';
-
-        return this.requestPermission({
-          callId,
-          tool: toolTitle,
-          args: (params.toolCall?.rawInput as Record<string, unknown>) ?? {},
-          category,
-          analysis: analyzePermissionRequest(
-            toolTitle,
-            (params.toolCall?.rawInput as Record<string, unknown>) ?? {},
-            category,
-          ),
-        }).then(({ approved }) => {
-          if (approved) {
-            return {
-              outcome: {
-                outcome: 'selected',
-                optionId: approveOptionId,
-              },
-            } as RequestPermissionResponse;
-          }
-          return {
-            outcome: { outcome: 'cancelled' },
-          } as RequestPermissionResponse;
-        });
-      },
-
-      /** Handle session update notifications from the subagent. */
-      sessionUpdate: async (params: SessionNotification): Promise<void> => {
-        const update = params.update;
-
-        // Count tool calls
-        if (update.sessionUpdate === 'tool_call') {
-          this.toolCallsMade++;
-        }
-
-        // Collect streamed text chunks as progress
-        if (isMessageChunk(update)) {
-          const text = update.content
-            ?.filter((c) => c.type === 'text')
-            .map((c) => c.text ?? '')
-            .join('') ?? '';
-          if (text) {
-            this.lastProgressText = (this.lastProgressText + text).slice(-1000);
-            this.info.progress = this.lastProgressText.slice(-200);
-            if (this.runtimeBus) {
-              emitAgentStreamDelta(this.runtimeBus, this.emitterContext(), {
-                agentId: this.id,
-                content: text,
-                accumulated: this.lastProgressText,
-              });
-            }
-          }
-        }
-      },
-    };
-  }
-
-  private buildPromptText(): string {
-    const parts: string[] = [`Task: ${this.task.description}`];
-
-    if (this.task.context) {
-      parts.push(`Context:\n${this.task.context}`);
-    }
-
-    if (this.task.tools.length > 0) {
-      parts.push(`Available tools: ${this.task.tools.join(', ')}`);
-    }
-
-    if (this.task.model) {
-      parts.push(`Use model: ${this.task.model}`);
-    }
-
-    return parts.join('\n\n');
-  }
-}

package/src/acp/index.ts

@@ -1,7 +0,0 @@
-export type {
-  SubagentInfo,
-  SubagentResult,
-  SubagentTask,
-  SubagentStatus,
-} from '@pellux/goodvibes-sdk/platform/acp/protocol';
-export { AcpManager } from '@pellux/goodvibes-sdk/platform/acp/manager';

package/src/acp/manager.ts

@@ -1 +0,0 @@
-export * from '@pellux/goodvibes-sdk/platform/acp/manager';