@payez/next-mvp 4.8.1 → 4.8.3

package/scripts/check-publish-eol.mjs

@@ -18,11 +18,14 @@
  * every consumer's CI.
  *
  * WHAT IT CHECKS:
- *   1. `*.sh`, `*.mjs`, `*.cjs` that the package SHIPS (package.json "files") must
- *      contain NO CR bytes. These run on Linux (bash / node with a shebang).
- *   2. The `*.sh text eol=lf` rule is still present in the repo's `.gitattributes` —
- *      so a future edit that quietly drops the rule fails the same check, not just a
- *      future CRLF checkout.
+ *   1. EVERY text file the package SHIPS (package.json "files") must contain NO CR bytes,
+ *      except the Windows-only `*.ps1` helpers. (Until 2026-10-14 only `*.sh`, `*.mjs`, `*.cjs`
+ *      were scanned, so 4.8.1 shipped CRLF in every src/*.ts and in README.md: the tarball is
+ *      packed from the working tree and a Windows checkout with core.autocrlf=true writes CRLF
+ *      there while the index stays LF; BAPert 74792.) A file with a NUL byte is binary and skipped.
+ *   2. The `*.sh text eol=lf` rule AND the catch-all `* text=auto eol=lf` rule are still present in
+ *      the repo's `.gitattributes` — so a future edit that quietly drops a rule fails the same
+ *      check, not just a future CRLF checkout.
  *   3. `*.ps1` is EXEMPT: PowerShell helpers are Windows-only and are deliberately
  *      kept CRLF (mirroring the .gitattributes rule).
  *
@@ -50,8 +53,7 @@ const here = dirname(fileURLToPath(import.meta.url));
 const pkgDir = join(here, '..');            // packages/next-mvp
 const repoRoot = join(pkgDir, '..', '..');  // repo root
 
-// Extensions that MUST be LF (they execute on Linux build agents).
-const LF_EXTS = new Set(['.sh', '.mjs', '.cjs']);
+// Every shipped text file must be LF. Binary files (a NUL byte in them) are skipped; see isBinary().
 // Extensions explicitly allowed to stay CRLF (Windows-only helpers).
 const CRLF_EXTS = new Set(['.ps1']);
 
@@ -65,6 +67,10 @@ function walk(dir, out = []) {
   return out;
 }
 
+function isBinary(buf) {
+  return buf.includes(0x00);
+}
+
 function crCount(buf) {
   let n = 0;
   for (const b of buf) if (b === 0x0d) n++;
@@ -94,19 +100,23 @@ for (const entry of shipped) {
   for (const f of files) {
     const ext = extname(f).toLowerCase();
     if (CRLF_EXTS.has(ext)) { exempt++; continue; }
-    if (!LF_EXTS.has(ext)) continue;
-    scanned++;
-    const crs = crCount(readFileSync(f));
+    const buf = readFileSync(f);
+    if (isBinary(buf)) continue;
+    // package.json always ships, so it cannot be what makes a scan count as non-empty (P9).
+    if (f !== join(pkgDir, 'package.json')) scanned++;
+    const crs = crCount(buf);
     if (crs > 0) offenders.push({ file: f, crs });
   }
 }
 
 // 2. The .gitattributes rule must still be present at the source.
 let gaRulePresent = false;
+let gaAllRulePresent = false;
 let gaPath = join(repoRoot, '.gitattributes');
 try {
   const ga = readFileSync(gaPath, 'utf8');
   gaRulePresent = /^\s*\*\.sh\s+text\s+eol=lf\s*$/m.test(ga);
+  gaAllRulePresent = /^\*\s+text=auto\s+eol=lf\s*$/m.test(ga);
 } catch {
   gaRulePresent = false;
 }
@@ -114,9 +124,11 @@ try {
 const rel = (p) => p.replace(repoRoot + '\\', '').replace(repoRoot + '/', '');
 
 if (offenders.length > 0) {
-  console.error('[publish-eol] FAIL: shipped script(s) contain CR (CRLF) and would break Linux agents.');
-  for (const o of offenders) console.error(`[publish-eol]   ${rel(o.file)}  CR=${o.crs}`);
-  console.error('[publish-eol] Fix: ensure the *.sh/*.mjs/*.cjs rule is in .gitattributes and renormalise (git add --renormalize .).');
+  console.error('[publish-eol] FAIL: shipped text file(s) contain CR (CRLF). Scripts break Linux agents; the rest make the tarball differ from the LF source (4.8.1).');
+  const SHOW = 25;
+  for (const o of offenders.slice(0, SHOW)) console.error(`[publish-eol]   ${rel(o.file)}  CR=${o.crs}`);
+  if (offenders.length > SHOW) console.error(`[publish-eol]   ... and ${offenders.length - SHOW} more (${offenders.length} files in all)`);
+  console.error('[publish-eol] Fix: ensure the "* text=auto eol=lf" rule is in .gitattributes, then re-checkout the working tree as LF (git rm --cached -r . && git reset --hard, or pack from a fresh LF clone).');
   process.exit(1);
 }
 
@@ -126,10 +138,16 @@ if (!gaRulePresent) {
   process.exit(1);
 }
 
+if (!gaAllRulePresent) {
+  console.error(`[publish-eol] FAIL: the catch-all "* text=auto eol=lf" rule is MISSING from ${rel(gaPath)}.`);
+  console.error('[publish-eol] Without it a Windows checkout (core.autocrlf=true) packs CRLF into src/*.ts, README.md and any extension no per-extension rule names (the 4.8.1 tarball).');
+  process.exit(1);
+}
+
 if (scanned === 0) {
-  console.error('[publish-eol] INCONCLUSIVE: scanned 0 LF-required shipped scripts - the scan is broken, not the package. NOT a pass.');
+  console.error('[publish-eol] INCONCLUSIVE: scanned 0 shipped text files - the scan is broken, not the package. NOT a pass.');
   process.exit(2);
 }
 
-console.log(`[publish-eol] OK: ${scanned} shipped script(s) CR-free; ${exempt} Windows-only (*.ps1) exempt; .gitattributes rule present.`);
+console.log(`[publish-eol] OK: ${scanned} shipped text file(s) CR-free; ${exempt} Windows-only (*.ps1) exempt; .gitattributes rule present.`);
 process.exit(0);