@payez/next-mvp 4.4.8 → 4.4.9

package/src/vibe/document-unwrap.ts

@@ -1,103 +1,103 @@
-/**
- * Vibe document wrapper + unwrapping.
- *
- * PAY-1767: extracted from generic.ts into its own module so the typed client (client.ts) can unwrap
- * reads WITHOUT importing generic.ts - generic.ts imports client.ts, so a shared helper there would be
- * a cycle. This module imports nothing from the vibe client.
- *
- * Vibe stores a row's own fields as a JSON STRING under the wrapper's `data` field, alongside storage
- * columns (document_id, owner, timestamps). A caller that renders `response.data` directly sees the
- * wrapper, so `row.name` is undefined. unwrapVibeDocument flattens the row out and keeps the storage
- * document_id as `_vibe_doc_id` for update/delete paths.
- */
-
-/** Vibe document wrapper structure. Vibe stores actual table data as a JSON string in the 'data' field. */
-export interface VibeDocumentWrapper {
-  document_id: number;
-  client_id?: number;
-  user_id?: number;
-  collection?: string;
-  table_name?: string;
-  data: string | Record<string, unknown>;
-  collection_schema_id?: number;
-  created_at?: string;
-  created_by?: number;
-  updated_at?: string | null;
-  updated_by?: number | null;
-  deleted_at?: string | null;
-}
-
-/**
- * Unwrap a Vibe document response.
- *
- * @param doc - Raw Vibe document (wrapper format)
- * @returns Unwrapped document with schema fields only; storage document_id preserved as `_vibe_doc_id`
- *          for update/delete paths. See PayEz-Core/docs/vibe-primary-key-standard.md
- *
- * @example
- * const raw = { document_id: 123, data: '{"user_id":15,"name":"John"}' };
- * unwrapVibeDocument(raw); // => { user_id: 15, name: 'John', _vibe_doc_id: 123 }
- */
-export function unwrapVibeDocument<T extends object = Record<string, unknown>>(
-  doc: VibeDocumentWrapper | Record<string, unknown> | null | undefined
-): (T & { _vibe_doc_id?: number }) | null {
-  if (!doc) return null;
-
-  // Handle case where doc is already unwrapped (has schema fields directly)
-  if (!('document_id' in doc) && !('data' in doc)) {
-    return doc as T & { _vibe_doc_id?: number };
-  }
-
-  const wrapper = doc as VibeDocumentWrapper;
-  let parsedData: Record<string, unknown> = {};
-
-  if (typeof wrapper.data === 'string') {
-    try {
-      parsedData = JSON.parse(wrapper.data);
-    } catch {
-      console.warn('[vibe-document] Failed to parse document data JSON:', wrapper.data);
-      parsedData = {};
-    }
-  } else if (typeof wrapper.data === 'object' && wrapper.data !== null) {
-    parsedData = wrapper.data;
-  }
-
-  // Preserve document_id as _vibe_doc_id for Vibe API update/delete paths only
-  const documentId = wrapper.document_id ?? (doc as { document_id?: number }).document_id;
-  if (documentId != null) {
-    parsedData._vibe_doc_id = documentId;
-  }
-
-  return parsedData as T & { _vibe_doc_id?: number };
-}
-
-/**
- * Extract and unwrap an array of documents from a Vibe response.
- *
- * @param responseData - Raw Vibe API response ({ data: [...] }, { items: [...] }, { documents: [...] } or a bare array)
- * @returns Array of unwrapped documents
- */
-export function extractVibeDocuments<T extends Record<string, unknown> = Record<string, unknown>>(
-  responseData: unknown
-): Array<T & { _vibe_doc_id?: number }> {
-  if (!responseData || typeof responseData !== 'object') {
-    return [];
-  }
-
-  const data = responseData as Record<string, unknown>;
-
-  // Try common response shapes
-  const docs =
-    data.data ??
-    data.items ??
-    data.documents ??
-    (Array.isArray(responseData) ? responseData : null);
-
-  if (!Array.isArray(docs)) {
-    return [];
-  }
-
-  return docs
-    .map((doc) => unwrapVibeDocument<T>(doc))
-    .filter((d): d is T & { _vibe_doc_id?: number } => d !== null);
-}
+/**
+ * Vibe document wrapper + unwrapping.
+ *
+ * PAY-1767: extracted from generic.ts into its own module so the typed client (client.ts) can unwrap
+ * reads WITHOUT importing generic.ts - generic.ts imports client.ts, so a shared helper there would be
+ * a cycle. This module imports nothing from the vibe client.
+ *
+ * Vibe stores a row's own fields as a JSON STRING under the wrapper's `data` field, alongside storage
+ * columns (document_id, owner, timestamps). A caller that renders `response.data` directly sees the
+ * wrapper, so `row.name` is undefined. unwrapVibeDocument flattens the row out and keeps the storage
+ * document_id as `_vibe_doc_id` for update/delete paths.
+ */
+
+/** Vibe document wrapper structure. Vibe stores actual table data as a JSON string in the 'data' field. */
+export interface VibeDocumentWrapper {
+  document_id: number;
+  client_id?: number;
+  user_id?: number;
+  collection?: string;
+  table_name?: string;
+  data: string | Record<string, unknown>;
+  collection_schema_id?: number;
+  created_at?: string;
+  created_by?: number;
+  updated_at?: string | null;
+  updated_by?: number | null;
+  deleted_at?: string | null;
+}
+
+/**
+ * Unwrap a Vibe document response.
+ *
+ * @param doc - Raw Vibe document (wrapper format)
+ * @returns Unwrapped document with schema fields only; storage document_id preserved as `_vibe_doc_id`
+ *          for update/delete paths. See PayEz-Core/docs/vibe-primary-key-standard.md
+ *
+ * @example
+ * const raw = { document_id: 123, data: '{"user_id":15,"name":"John"}' };
+ * unwrapVibeDocument(raw); // => { user_id: 15, name: 'John', _vibe_doc_id: 123 }
+ */
+export function unwrapVibeDocument<T extends object = Record<string, unknown>>(
+  doc: VibeDocumentWrapper | Record<string, unknown> | null | undefined
+): (T & { _vibe_doc_id?: number }) | null {
+  if (!doc) return null;
+
+  // Handle case where doc is already unwrapped (has schema fields directly)
+  if (!('document_id' in doc) && !('data' in doc)) {
+    return doc as T & { _vibe_doc_id?: number };
+  }
+
+  const wrapper = doc as VibeDocumentWrapper;
+  let parsedData: Record<string, unknown> = {};
+
+  if (typeof wrapper.data === 'string') {
+    try {
+      parsedData = JSON.parse(wrapper.data);
+    } catch {
+      console.warn('[vibe-document] Failed to parse document data JSON:', wrapper.data);
+      parsedData = {};
+    }
+  } else if (typeof wrapper.data === 'object' && wrapper.data !== null) {
+    parsedData = wrapper.data;
+  }
+
+  // Preserve document_id as _vibe_doc_id for Vibe API update/delete paths only
+  const documentId = wrapper.document_id ?? (doc as { document_id?: number }).document_id;
+  if (documentId != null) {
+    parsedData._vibe_doc_id = documentId;
+  }
+
+  return parsedData as T & { _vibe_doc_id?: number };
+}
+
+/**
+ * Extract and unwrap an array of documents from a Vibe response.
+ *
+ * @param responseData - Raw Vibe API response ({ data: [...] }, { items: [...] }, { documents: [...] } or a bare array)
+ * @returns Array of unwrapped documents
+ */
+export function extractVibeDocuments<T extends Record<string, unknown> = Record<string, unknown>>(
+  responseData: unknown
+): Array<T & { _vibe_doc_id?: number }> {
+  if (!responseData || typeof responseData !== 'object') {
+    return [];
+  }
+
+  const data = responseData as Record<string, unknown>;
+
+  // Try common response shapes
+  const docs =
+    data.data ??
+    data.items ??
+    data.documents ??
+    (Array.isArray(responseData) ? responseData : null);
+
+  if (!Array.isArray(docs)) {
+    return [];
+  }
+
+  return docs
+    .map((doc) => unwrapVibeDocument<T>(doc))
+    .filter((d): d is T & { _vibe_doc_id?: number } => d !== null);
+}

package/src/vibe/sessions.ts

@@ -33,6 +33,7 @@ import crypto from 'crypto';
 import type { IVibeLoginSession, SessionStatus } from './types';
 import type { LocationInfo } from '../lib/geolocation';
 import type { DeviceInfo } from '../lib/user-agent-parser';
+import { decodeIdpAccessToken } from '../auth/utils/token-utils';
 
 // -----------------------------------------------------------------------------
 // CONFIGURATION
@@ -74,7 +75,7 @@ function generateHmacSignature(
  */
 async function vibeProxyRequest<T>(
   endpoint: string,
-  method: 'GET' | 'POST' | 'PUT' | 'DELETE',
+  method: 'GET' | 'POST' | 'PUT' | 'PATCH' | 'DELETE',
   accessToken: string,
   body?: unknown
 ): Promise<T | null> {
@@ -262,7 +263,9 @@ export async function getUserSessions(
     'POST',
     accessToken,
     {
-      filter: [{ field: 'idp_user_id', operator: 'eq', value: idpUserId }],
+      // PAY-2037: a flat VibeFilterNode OBJECT, as idealresume sends it (vibe-sessions.ts:220). Core binds
+      // QueryRequest.Filter as an object (VibeQueryBuilder.cs IsFlatFilterFormat); an ARRAY does not bind.
+      filter: { field: 'idp_user_id', operator: 'eq', value: idpUserId },
       pageSize: 100,
     }
   );
@@ -288,12 +291,13 @@ export async function getAllSessions(
   const query: Record<string, unknown> = {
     page,
     pageSize,
-    orderBy: 'created_at',
-    orderDir: 'desc',
+    // PAY-2037: Vibe's QueryRequest.OrderBy is an OBJECT; a string is a 400 and vibeProxyRequest
+    // turned that into an empty list. There is no `orderDir` (QAPert 69149).
+    orderBy: { created_at: 'desc' },
   };
 
   if (options.status) {
-    query.filter = [{ field: 'status', operator: 'eq', value: options.status }];
+    query.filter = { field: 'status', operator: 'eq', value: options.status };
   }
 
   const endpoint = `/v1/collections/${COLLECTION}/tables/${TABLE}/query`;
@@ -345,11 +349,11 @@ export async function revokeSession(
   reason?: string
 ): Promise<IVibeLoginSession | null> {
   const now = new Date().toISOString();
-
+  // PAY-2037: PATCH, not PUT - a PUT replaces the row and this body carries 4 of its fields.
   const endpoint = `/v1/collections/${COLLECTION}/tables/${TABLE}/${sessionId}`;
   const session = await vibeProxyRequest<IVibeLoginSession>(
     endpoint,
-    'PUT',
+    'PATCH',
     accessToken,
     {
       status: 'revoked',
@@ -414,7 +418,7 @@ export async function updateSessionActivity(
   const endpoint = `/v1/collections/${COLLECTION}/tables/${TABLE}/${sessionId}`;
   const result = await vibeProxyRequest<IVibeLoginSession>(
     endpoint,
-    'PUT',
+    'PATCH',
     accessToken,
     { last_activity: new Date().toISOString() }
   );
@@ -460,33 +464,296 @@ export async function isSessionValid(
  * @param accessToken - Access token for auth
  * @param sessionTokenHash - Optional token hash to check specific session
  * @returns Revoked session info if enforcement needed, null otherwise
+ *
+ * @deprecated PAY-2037 step 1 (BAPert 69153): kept so no consumer breaks. It is a thin call into the
+ * same hash-first decision as getRevocationStatus; prefer getRevocationStatus, which distinguishes
+ * a failed read ('unknown') from 'active' instead of throwing.
  */
 export async function checkSessionRevocation(
   idpUserId: number,
-  accessToken: string,
+  _accessToken: string,
   sessionTokenHash?: string
 ): Promise<IVibeLoginSession | null> {
-  const sessions = await getUserSessions(idpUserId, accessToken);
+  // PAY-2037 step 1: same decision as getRevocationStatus, same HMAC-only read. The bearer is
+  // accepted for signature compatibility and never sent. A FAILED read throws - it must not read
+  // as "no revoked session" (that is the PAY-1880 fail-open this replaces).
+  const { ok, sessions } = await readSessionRevocationHmac(idpUserId);
+  if (!ok) {
+    throw new Error('[vibe-sessions] session revocation read failed (fail closed)');
+  }
+  return findRevokingSession(sessions, sessionTokenHash);
+}
 
-  // If we have a specific token hash, check that session
-  if (sessionTokenHash) {
-    const matchingSession = sessions.find(s => s.session_token_hash === sessionTokenHash);
-    if (matchingSession && matchingSession.status === 'revoked') {
-      return matchingSession;
+// -----------------------------------------------------------------------------
+// REVOCATION STATUS (PAY-1882 step 4 producer half)
+// -----------------------------------------------------------------------------
+
+/** The four states a viability producer can report (BAPert 66320). */
+export type RevocationStatus = 'active' | 'revoked' | 'unknown' | 'not_configured';
+
+// BAPert 66320: log 'not_configured' ONCE, not per request - a Vibe-less
+// deployment would otherwise emit a warn line on every viability check.
+let warnedNotConfigured = false;
+
+/**
+ * Hash a session token the same way record-login stores it.
+ * SHA256 hex, 64 chars. This must stay byte-identical to
+ * `hashSessionToken` in the consumers (idealresume.online/lib/session-token-hash.ts)
+ * or per-session matching silently falls back to the user-wide path.
+ */
+export function hashSessionToken(token: string): string {
+  return crypto.createHash('sha256').update(token).digest('hex');
+}
+
+/**
+ * BAPert 66480 condition 2 (ruling (ii), 66700; corrected per QAPert 66729):
+ * resolve the NUMERIC IdP user id the Vibe query filters on.
+ *
+ * *** DO NOT READ `sub` FOR THE USER ID. *** In the IdP's bearer token `sub` is the
+ * USERNAME, not the id: AESGCM_Encryption.cs:815 writes `{ "sub", payload.Username }`
+ * and :822 writes `{ "user_id", payload.UserId.ToString() }`. A username is commonly
+ * an email, so reading `sub` yields 0 for the common case - and for a username that
+ * happens to be all digits it yields the WRONG id, which getRevocationStatus answers
+ * 'active' for a user with no rows: a fail-OPEN.
+ *
+ * Resolution order:
+ *   1. the token's `user_id` claim, when it is all digits;
+ *   2. a digits-only session.userId / session.user.id;
+ *   3. otherwise 0 (unresolvable), which the caller reports as 'unknown' (fail closed).
+ *
+ * session.userId is not a safe source on its own either: session-store.ts:143 falls
+ * back to user.email, and better-auth.ts stringifies whichever id it finds.
+ */
+export function resolveNumericIdpUserId(session: unknown, accessToken?: string): number {
+  const isDigits = (v: unknown) => /^[0-9]+$/.test(String(v ?? ''));
+  if (accessToken) {
+    // The raw payload (jwtDecode returns every claim, typed or not); user_id, never sub.
+    const payload = decodeIdpAccessToken(accessToken) as Record<string, unknown> | null;
+    const claim = payload?.user_id;
+    if (isDigits(claim)) return Number(claim);
+  }
+  const s = (session ?? {}) as Record<string, any>;
+  const fromSession = s.userId ?? s.user?.id;
+  return isDigits(fromSession) ? Number(fromSession) : 0;
+}
+
+/**
+ * BAPert 66480 condition 1: WARN once per session when the numeric IdP user id
+ * could not be resolved (userId is email-shaped, empty, or otherwise not all
+ * digits). A non-numeric id must show up as a log line, not as an unexplained
+ * sign-out. Shape only - NEVER the value.
+ *
+ * Keyed on a hash of the session token, so one WARN per session; the set is
+ * bounded so a long-lived process cannot grow it without limit.
+ */
+const warnedNonNumericUserIds = new Set<string>();
+
+function shapeOfUserId(v: unknown): string {
+  const str = String(v ?? '');
+  if (!str) return 'empty:0';
+  const kind = /^[0-9]+$/.test(str) ? 'digits' : str.includes('@') ? 'email' : 'other';
+  return `${kind}:${str.length}`;
+}
+
+function warnNonNumericUserIdOnce(sessionToken: string | undefined, rawUserId: unknown): void {
+  const key = sessionToken ? hashSessionToken(sessionToken).slice(0, 16) : `nosession:${shapeOfUserId(rawUserId)}`;
+  if (warnedNonNumericUserIds.has(key)) return;
+  if (warnedNonNumericUserIds.size > 5000) warnedNonNumericUserIds.clear();
+  warnedNonNumericUserIds.add(key);
+  console.warn('[REVOCATION] non-numeric userId, failing closed', { shape: shapeOfUserId(rawUserId) });
+}
+
+/**
+ * Public entry point for the twins: call this when a session exists but its
+ * userId is not a usable numeric IdP id. Returns 'unknown' (fail closed) and
+ * emits the once-per-session WARN. Shape only, never the value.
+ */
+export function warnNonNumericUserId(sessionToken: string | undefined, rawUserId: unknown): 'unknown' {
+  warnNonNumericUserIdOnce(sessionToken, rawUserId);
+  return 'unknown';
+}
+
+/**
+ * HMAC-ONLY session read for the revocation check (PAY-1882 step 4).
+ *
+ * *** DO NOT "SIMPLIFY" THIS ONTO vibeProxyRequest/getUserSessions. ***
+ * It is deliberately separate and deliberately sends NO Authorization header.
+ *
+ * WHY: the twin this must match is idealresume.online's checkSessionRevocation
+ * read. That repo's vibe-client adds `Authorization: Bearer` ONLY for member
+ * paths (`path.startsWith('/v1/my/')`) - see idealresume.online/lib/vibe-client.ts
+ * :207-210 - so its /v1/collections/.../query for this check goes out HMAC-only.
+ * The comment at vibe-client.ts:188-206 there records why: a bearer on the
+ * collections path caused USER_REQUIRED and broke signups. getUserSessions()
+ * here ALWAYS sends the bearer, so it cannot stand in for this read without
+ * changing the credential the two twins are supposed to share.
+ *
+ * BAPert 66344 (option a): match the twin, HMAC-only.
+ *
+ * Also distinguishes a FAILED read from an EMPTY one - getUserSessions()
+ * collapses a proxy outage and "user has no sessions" to `[]`, which is
+ * fail-OPEN for a revocation decision. Returns `ok:false` on an outage so the
+ * caller fails closed, and `ok:true, sessions:[]` only for a healthy empty.
+ */
+export async function readSessionRevocationHmac(
+  idpUserId: number
+): Promise<{ ok: boolean; sessions: IVibeLoginSession[] }> {
+  const idpUrl = getEnv('IDP_URL');
+  const clientId = getEnv('VIBE_CLIENT_ID');
+  const signingKey = getEnv('VIBE_HMAC_KEY');
+
+  if (!idpUrl || !clientId || !signingKey) {
+    // Caller distinguishes this from a read failure; report ok:false, not [].
+    return { ok: false, sessions: [] };
+  }
+
+  const endpoint = `/v1/collections/${COLLECTION}/tables/${TABLE}/query`;
+  const proxyUrl = `${idpUrl}/api/vibe/proxy`;
+  const timestamp = Math.floor(Date.now() / 1000);
+  const signature = generateHmacSignature(signingKey, timestamp, 'POST', endpoint);
+
+  // NOTE the absence of Authorization. This is the twin's credential.
+  const headers: Record<string, string> = {
+    'Content-Type': 'application/json',
+    'X-Vibe-Client-Id': clientId,
+    'X-Vibe-Timestamp': String(timestamp),
+    'X-Vibe-Signature': signature,
+  };
+
+  try {
+    const response = await fetch(proxyUrl, {
+      method: 'POST',
+      headers,
+      body: JSON.stringify({
+        endpoint,
+        method: 'POST',
+        data: {
+          // PAY-2037: a flat VibeFilterNode OBJECT, as idealresume sends it (vibe-sessions.ts:220). Core binds
+      // QueryRequest.Filter as an object (VibeQueryBuilder.cs IsFlatFilterFormat); an ARRAY does not bind.
+      filter: { field: 'idp_user_id', operator: 'eq', value: idpUserId },
+          pageSize: 100,
+        },
+      }),
+    });
+
+    if (!response.ok) {
+      // PAY-1427: never the raw proxy body - an error page can echo the request.
+      console.error(`[vibe-sessions] Revocation read proxy error ${response.status}`);
+      return { ok: false, sessions: [] };
     }
+
+    const data = await response.json();
+    const unwrapped = (data?.data ?? data) as { data?: IVibeLoginSession[]; items?: IVibeLoginSession[] };
+    return { ok: true, sessions: unwrapped?.data || unwrapped?.items || [] };
+  } catch (error) {
+    console.error('[vibe-sessions] Revocation read failed:', error);
+    return { ok: false, sessions: [] };
+  }
+}
+
+/**
+ * THE one revocation decision (PAY-2037 step 1, BAPert 69150): hash-first, per session.
+ * Returns the row that revokes THIS session, or null when it is not revoked.
+ *
+ * A session whose own token hash matches a row is decided by that row ALONE. A matched ACTIVE
+ * session is never logged out because another device was revoked (idealresume PAY-1882 F3).
+ * Only when no row carries the hash (a legacy row minted before hashing) does the user-wide
+ * rule apply: no active row -> the most recently revoked (none revoked: not revoked); else any revoked inside 2h.
+ */
+function findRevokingSession(
+  sessions: IVibeLoginSession[],
+  sessionTokenHash?: string
+): IVibeLoginSession | null {
+  if (sessions.length === 0) return null;
+
+  if (sessionTokenHash) {
+    const matching = sessions.find(s => s.session_token_hash === sessionTokenHash);
+    if (matching) return matching.status === 'revoked' ? matching : null;
+  }
+
+  // Hash not found (a legacy row minted before hashing) or no hash given: idealresume's user-wide
+  // rules, lib/vibe-sessions.ts:594-651 (BAPert 69189).
+  const revokedAt = (s: IVibeLoginSession) => (s.revoked_at ? new Date(s.revoked_at).getTime() : 0);
+  const newestFirst = (x: IVibeLoginSession, y: IVibeLoginSession) => revokedAt(y) - revokedAt(x);
+
+  // Check 1: no active row. The most recently revoked row (whenever it was revoked) is the verdict.
+  // All rows expired and none revoked is NOT revoked: expiry is not revocation.
+  if (!sessions.some(s => s.status === 'active')) {
+    const revoked = sessions.filter(s => s.status === 'revoked' && s.revoked_at).sort(newestFirst);
+    if (revoked.length > 0) return revoked[0];
   }
 
-  // Otherwise, check if there are any recently revoked sessions
-  // (revoked within the last hour - gives time for enforcement)
-  const oneHourAgo = new Date(Date.now() - 60 * 60 * 1000);
-  const recentlyRevoked = sessions.find(
-    s =>
-      s.status === 'revoked' &&
-      s.revoked_at &&
-      new Date(s.revoked_at) > oneHourAgo
+  // Check 2: any row revoked in the last TWO hours (idealresume's window; 5-minute polling needs the time).
+  const twoHoursAgo = Date.now() - 2 * 60 * 60 * 1000;
+  return (
+    sessions.filter(s => s.status === 'revoked' && revokedAt(s) > twoHoursAgo).sort(newestFirst)[0] ?? null
   );
+}
+
+/**
+ * Determine whether a session is revoked, with an explicit UNKNOWN state
+ * (PAY-1882 step 4 producer half).
+ *
+ * States:
+ *   'not_configured' - this deployment has no revocation source (IDP_URL /
+ *                      VIBE_CLIENT_ID / VIBE_HMAC_KEY absent). Viable; today's
+ *                      behaviour. Logged once, not per request.
+ *   'unknown'        - revocation IS configured but the read FAILED (non-OK,
+ *                      timeout, throw). Enforcing middleware fails this CLOSED
+ *                      by default (revocationFailMode 'closed'); a Vibe-less
+ *                      consumer is 'not_configured', not 'unknown', so it is not
+ *                      signed out.
+ *   'revoked'        - the session's own token hash matches a revoked row, or
+ *                      the user has no active session at all.
+ *   'active'         - read OK and the session is not revoked.
+ *
+ * @param idpUserId - The user's IDP ID
+ * @param sessionToken - The live session token; hashed to match the stored row.
+ *                       When absent, the user-wide check applies (legacy path).
+ */
+export async function getRevocationStatus(
+  idpUserId: number,
+  sessionToken?: string
+): Promise<RevocationStatus> {
+  const idpUrl = getEnv('IDP_URL');
+  const clientId = getEnv('VIBE_CLIENT_ID');
+  const signingKey = getEnv('VIBE_HMAC_KEY');
+
+  // 'not_configured' is reserved for an app with NO revocation source at all:
+  // no VIBE_CLIENT_ID. BAPert 66320 - "the app has no revocation source
+  // (VIBE_CLIENT_ID absent / revocation not enabled)". Such a consumer stays
+  // viable, or a Vibe-less app would sign everyone out on every request.
+  if (!clientId) {
+    if (!warnedNotConfigured) {
+      warnedNotConfigured = true;
+      console.warn(
+        '[vibe-sessions] Revocation check not configured (VIBE_CLIENT_ID absent) - reporting not_configured (logged once)'
+      );
+    }
+    return 'not_configured';
+  }
+
+  // A client id IS present, so this app is a Vibe consumer that intends the
+  // revocation check - but the read is MISCONFIGURED (IDP_URL or VIBE_HMAC_KEY
+  // missing). BAPert 66344 condition 2: FAIL CLOSED. Do NOT fall back to bearer,
+  // do NOT report "no sessions". 'unknown' is the fail-closed state.
+  if (!idpUrl || !signingKey) {
+    console.warn(
+      '[vibe-sessions] Revocation check MISCONFIGURED (VIBE_CLIENT_ID set but IDP_URL/VIBE_HMAC_KEY missing) - reporting unknown (fail closed)'
+    );
+    return 'unknown';
+  }
+
+  const { ok, sessions } = await readSessionRevocationHmac(idpUserId);
+
+  if (!ok) {
+    console.warn('[vibe-sessions] Revocation read failed - reporting unknown');
+    return 'unknown';
+  }
 
-  return recentlyRevoked || null;
+  return findRevokingSession(sessions, sessionToken ? hashSessionToken(sessionToken) : undefined)
+    ? 'revoked'
+    : 'active';
 }
 
 // -----------------------------------------------------------------------------