@pasko70/pibo 3.0.2 → 3.1.1

package/dist/apps/chat/loop-api.js

@@ -2,7 +2,7 @@ import { PiboWebHttpError, readJsonBody, responseJson } from '../../web/http.js'
 import { getPiboLoopService } from '../../loops/channel.js';
 import { listLoopJobTemplates } from '../../loops/templates.js';
 import { isPiboThinkingLevel } from '../../core/thinking.js';
-import { normalizeLoopStopPolicy } from '../../loops/store.js';
+import { normalizeLoopStopPolicy, PiboLoopActiveRunModeChangeError } from '../../loops/store.js';
 import { isPiboRoomArchived } from './types/rooms.js';
 const CHAT_WEB_API_PREFIX = '/api/chat';
 function requireSameOriginJsonRequest(request) { const contentType = request.headers.get('content-type')?.split(';')[0]?.trim().toLowerCase(); if (contentType !== 'application/json')
@@ -184,7 +184,15 @@ export async function handleChatLoopApiRequest(options) {
             throw new PiboWebHttpError('Loop job not found', 404);
         if ((patch.mode ?? existing.mode) === 'ralph' && ((patch.tokenBudget !== undefined && patch.tokenBudget !== null) || (patch.tokenReserve !== undefined && patch.tokenReserve !== null)))
             throw new PiboWebHttpError('tokenBudget and tokenReserve are only available for goal mode', 400);
-        const job = loopStore.updateJob(resource.id, patch);
+        let job;
+        try {
+            job = loopStore.updateJob(resource.id, patch);
+        }
+        catch (error) {
+            if (error instanceof PiboLoopActiveRunModeChangeError)
+                throw new PiboWebHttpError(error.message, 409);
+            throw error;
+        }
         if (!job)
             throw new PiboWebHttpError('Loop job not found', 404);
         return responseJson({ job: serializeJob(job) });

package/dist/apps/chat/web-app.js

@@ -19,7 +19,7 @@ import { DEFAULT_TRACE_EVENTS_PAGE_SIZE, annotateTracePage, etagForVersion, esti
 import { TRACE_V2_DEFAULT_TIMELINE_LIMIT, TRACE_V2_MAX_TIMELINE_LIMIT, TRACE_V2_PAYLOAD_DEFAULT_LIMIT_BYTES, TRACE_V2_PAYLOAD_MAX_LIMIT_BYTES, TRACE_V2_RAW_EVENTS_DEFAULT_LIMIT, TRACE_V2_RAW_EVENTS_MAX_LIMIT, TRACE_V2_TIMELINE_HARD_BYTES, TRACE_IMAGE_MAX_COUNT, parseTracePayloadRef, readTraceImagePayload, readTracePayloadChunk, traceRawEventsPageFromEvents, traceTimelinePageFromView, } from "./trace-v2.js";
 import { isChatWebSessionArchived } from "./session-metadata.js";
 import { withWorkflowSessionKind } from "../../sessions/workflow-session-kind.js";
-import { CustomAgentStore, createDefaultCustomAgentStore, previewCustomAgentCreate, previewCustomAgentUpdate, } from "./agent-store.js";
+import { CustomAgentTargetReferenceError, CustomAgentStore, createDefaultCustomAgentStore, previewCustomAgentCreate, previewCustomAgentUpdate, } from "./agent-store.js";
 import { loadPiboModelDefaults, } from "../../core/model-defaults.js";
 import { inspectPiboContextBuild } from "../../core/context-build.js";
 import { isPiboThinkingLevel } from "../../core/thinking.js";
@@ -35,7 +35,7 @@ import { ScopedUserSkillManager } from "../../user-skills/manager.js";
 import { ChatDataIngestService, outputIdempotencyKey, outputPersistenceDeliveryKey } from "../../data/ingest-service.js";
 import { ChatEventCommandService } from "./data/event-command-service.js";
 import { ChatReadStateService } from "./data/read-state-service.js";
-import { ChatRoomService } from "./data/room-service.js";
+import { ChatRoomService, PiboRoomHierarchyCycleError } from "./data/room-service.js";
 import { ChatSessionQueryService } from "./data/session-query-service.js";
 import { ChatTimelineQueryService } from "./data/timeline-query-service.js";
 import { ChatHistoryQueryService } from "./data/history-query-service.js";
@@ -2352,6 +2352,17 @@ function normalizeAgentDeleteConfirmation(value) {
     }
     return value.trim();
 }
+function requireCustomAgentNotTargeted(state, agent, options = {}) {
+    const dependents = state.agentStore.listReferencingAgents(agent.id)
+        .filter((dependent) => !options.activeOnly || !dependent.archivedAt);
+    if (dependents.length === 0)
+        return;
+    const error = new CustomAgentTargetReferenceError(agent.profileName, dependents.map((dependent) => dependent.profileName));
+    const message = options.activeOnly
+        ? error.message.replace("targeted by custom agents", "targeted by active custom agents")
+        : error.message;
+    throw new PiboWebHttpError(message, 409);
+}
 async function deleteSessionsForAgentProfile(state, context, webSession, profileNames) {
     const deleteSession = context.channelContext.deleteSession;
     if (!deleteSession)
@@ -2371,10 +2382,11 @@ async function deleteSessionsForAgentProfile(state, context, webSession, profile
         }
     }
     const orderedIds = [...ids].sort((left, right) => sessionDepth(sessionsById.get(right), sessionsById) - sessionDepth(sessionsById.get(left), sessionsById));
-    for (const id of orderedIds)
-        await deleteSession(id);
-    state.sessionQuery.deleteSessions(orderedIds);
-    state.eventCommands.deleteSessions(orderedIds);
+    for (const id of orderedIds) {
+        await state.projectService.deleteProjectSessionWithCanonicalDelete(id, () => deleteSession(id));
+        state.sessionQuery.deleteSessions([id]);
+        state.eventCommands.deleteSessions([id]);
+    }
     for (const id of orderedIds)
         disposeSessionStreamState(state, id);
     return orderedIds;
@@ -2397,10 +2409,11 @@ async function deleteSessionSubtree(state, context, webSession, rootSession) {
         }
     }
     const orderedIds = [...ids].sort((left, right) => sessionDepth(sessionsById.get(right), sessionsById) - sessionDepth(sessionsById.get(left), sessionsById));
-    for (const id of orderedIds)
-        await deleteSession(id);
-    state.sessionQuery.deleteSessions(orderedIds);
-    state.eventCommands.deleteSessions(orderedIds);
+    for (const id of orderedIds) {
+        await state.projectService.deleteProjectSessionWithCanonicalDelete(id, () => deleteSession(id));
+        state.sessionQuery.deleteSessions([id]);
+        state.eventCommands.deleteSessions([id]);
+    }
     for (const id of orderedIds)
         disposeSessionStreamState(state, id);
     return orderedIds;
@@ -2437,10 +2450,11 @@ async function deleteRoomTree(state, context, webSession, room, confirmName) {
         }
     }
     const orderedSessionIds = [...ids].sort((left, right) => sessionDepth(sessionsById.get(right), sessionsById) - sessionDepth(sessionsById.get(left), sessionsById));
-    for (const id of orderedSessionIds)
-        await deleteSession(id);
-    state.sessionQuery.deleteSessions(orderedSessionIds);
-    state.eventCommands.deleteSessions(orderedSessionIds);
+    for (const id of orderedSessionIds) {
+        await state.projectService.deleteProjectSessionWithCanonicalDelete(id, () => deleteSession(id));
+        state.sessionQuery.deleteSessions([id]);
+        state.eventCommands.deleteSessions([id]);
+    }
     for (const id of orderedSessionIds)
         disposeSessionStreamState(state, id);
     state.eventCommands.deleteRooms(roomIds);
@@ -3961,7 +3975,9 @@ export function createChatWebApp(options = {}) {
                 const webSession = await requireSession(request, context);
                 const body = await readJsonBody(request);
                 try {
-                    requireSharedProject(state, webSession, projectResource.projectId, { includeArchived: true });
+                    const existingProject = requireSharedProject(state, webSession, projectResource.projectId, { includeArchived: true });
+                    if (existingProject.metadata.default === true)
+                        throw new PiboWebHttpError("Project Manager cannot be changed", 400);
                     const project = state.projectService.updateProject(projectResource.projectId, {
                         ...(body.name !== undefined ? { name: normalizeRoomName(body.name) } : {}),
                         ...(body.description !== undefined ? { description: normalizeProjectDescription(body.description) ?? null } : {}),
@@ -3982,7 +3998,9 @@ export function createChatWebApp(options = {}) {
                 const webSession = await requireSession(request, context);
                 const body = await readJsonBody(request);
                 try {
-                    requireSharedProject(state, webSession, projectResource.projectId, { includeArchived: true });
+                    const project = requireSharedProject(state, webSession, projectResource.projectId, { includeArchived: true });
+                    if (project.metadata.default === true)
+                        throw new PiboWebHttpError("Project Manager cannot be deleted", 400);
                     return responseJson(state.projectService.deleteProject(projectResource.projectId, {
                         confirmName: normalizeRoomDeleteConfirmation(body.confirmName),
                         deleteFiles: body.deleteFiles === true,
@@ -4272,22 +4290,43 @@ export function createChatWebApp(options = {}) {
                 if (!rootPiboSessionId)
                     throw new PiboWebHttpError("rootPiboSessionId is required", 400);
                 requireSharedSession(context, rootPiboSessionId);
-                if (!context.channelContext.snapshotSignalTree || !context.channelContext.subscribeSignalTree) {
+                const includeStatuses = parseBooleanSearchParam(url, "includeStatuses");
+                if (!context.channelContext.snapshotSignalTree
+                    || !context.channelContext.subscribeSignalTree
+                    || (includeStatuses && (!context.channelContext.snapshotSignalStatuses || !context.channelContext.subscribeSignalStatuses))) {
                     throw new PiboWebHttpError("Signal registry is not available", 503);
                 }
-                let unsubscribe;
+                let unsubscribeTree;
+                let unsubscribeStatuses;
                 let heartbeat;
+                let closed = false;
                 const stream = new ReadableStream({
                     start: (controller) => {
                         writeJsonSse(controller, "signal_snapshot", context.channelContext.snapshotSignalTree(rootPiboSessionId));
-                        unsubscribe = context.channelContext.subscribeSignalTree(rootPiboSessionId, (patch) => {
-                            writeJsonSse(controller, "signal_patch", patch, String(patch.toVersion));
+                        unsubscribeTree = context.channelContext.subscribeSignalTree(rootPiboSessionId, (patch) => {
+                            if (!closed)
+                                writeJsonSse(controller, "signal_patch", patch, String(patch.toVersion));
                         });
-                        heartbeat = setInterval(() => writeSseComment(controller, "heartbeat"), 25_000);
+                        if (includeStatuses) {
+                            writeJsonSse(controller, "signal_status_snapshot", context.channelContext.snapshotSignalStatuses());
+                            unsubscribeStatuses = context.channelContext.subscribeSignalStatuses((patch) => {
+                                if (closed)
+                                    return;
+                                const statusPatch = compactSignalStatusPatch(patch);
+                                writeJsonSse(controller, "signal_status_patch", statusPatch, `${patch.rootPiboSessionId}:${patch.toVersion}`);
+                            });
+                        }
+                        heartbeat = setInterval(() => {
+                            if (!closed)
+                                writeSseComment(controller, "heartbeat");
+                        }, 25_000);
                     },
                     cancel: () => {
-                        unsubscribe?.();
-                        unsubscribe = undefined;
+                        closed = true;
+                        unsubscribeTree?.();
+                        unsubscribeTree = undefined;
+                        unsubscribeStatuses?.();
+                        unsubscribeStatuses = undefined;
                         if (heartbeat)
                             clearInterval(heartbeat);
                         heartbeat = undefined;
@@ -4691,6 +4730,9 @@ export function createChatWebApp(options = {}) {
                 if (customAgentUpdateAffectsRuntime(update)) {
                     await requireValidCustomAgentRuntime(previewCustomAgentUpdate(existing, update), context);
                 }
+                if (archived === true && !existing.archivedAt) {
+                    requireCustomAgentNotTargeted(state, existing, { activeOnly: true });
+                }
                 const updated = Object.keys(update).length ? state.agentStore.update(patchAgentId, update) : existing;
                 const afterUpdate = requireSharedAgent(updated);
                 const agent = archived === undefined ? afterUpdate : state.agentStore.setArchived(patchAgentId, archived);
@@ -4717,8 +4759,16 @@ export function createChatWebApp(options = {}) {
                 if (confirmName !== agent.profileName) {
                     throw new PiboWebHttpError(`Type "${agent.profileName}" to permanently delete this agent and its sessions.`, 400);
                 }
+                requireCustomAgentNotTargeted(state, agent);
                 const deletedSessionIds = await deleteSessionsForAgentProfile(state, context, webSession, [agent.profileName, ...agent.profileAliases]);
-                state.agentStore.delete(agent.id);
+                try {
+                    state.agentStore.delete(agent.id);
+                }
+                catch (error) {
+                    if (error instanceof CustomAgentTargetReferenceError)
+                        throw new PiboWebHttpError(error.message, 409);
+                    throw error;
+                }
                 context.channelContext.removeProfile?.(agent.profileName);
                 invalidateBootstrapCatalogCache(state);
                 return responseJson({ deletedAgentId: agent.id, deletedSessionIds });
@@ -4829,7 +4879,16 @@ export function createChatWebApp(options = {}) {
                 const update = createRoomUpdate(existingRoom, body);
                 if (update.parentRoomId)
                     requireRoom(state, update.parentRoomId, webSession, "admin");
-                const room = state.roomService.updateRoom(roomResource.roomId, update);
+                let room;
+                try {
+                    room = state.roomService.updateRoom(roomResource.roomId, update);
+                }
+                catch (error) {
+                    if (error instanceof PiboRoomHierarchyCycleError) {
+                        throw new PiboWebHttpError(error.message, 400);
+                    }
+                    throw error;
+                }
                 if (!room)
                     throw new PiboWebHttpError("Room not found", 404);
                 return responseJson({ room });