@pasko70/pibo 3.0.2 → 3.1.1

package/compute-image/Dockerfile

@@ -0,0 +1,47 @@
+FROM node:24-slim
+
+RUN apt-get update && apt-get install -y \
+    python3 python3-venv python3-dev \
+    build-essential curl git ca-certificates \
+    chromium chromium-driver xvfb xauth x11-xserver-utils \
+    fonts-liberation libappindicator3-1 libasound2 libatk-bridge2.0-0 \
+    libatk1.0-0 libcups2 libdbus-1-3 libdrm2 libgbm1 libgtk-3-0 libnspr4 \
+    libnss3 libxcomposite1 libxdamage1 libxfixes3 libxrandr2 xdg-utils \
+    dbus dbus-x11 \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN curl -LsSf https://astral.sh/uv/install.sh | sh
+ENV PATH="/root/.local/bin:${PATH}"
+ENV DISPLAY=:99
+ENV PIBO_BROWSER_USE_CHROME=/usr/bin/chromium
+
+# The host stages only the published package archive and this Dockerfile, so an
+# installed package's production node_modules never enters the build context.
+COPY pibo-package.tgz /tmp/pibo-package.tgz
+
+WORKDIR /app
+RUN npm init -y >/dev/null && \
+    npm install --omit=dev --no-audit --no-fund /tmp/pibo-package.tgz && \
+    rm -f /tmp/pibo-package.tgz
+
+RUN mkdir -p /root/.pibo/tools/browser-use/home/bin && \
+    uv venv /root/.pibo/tools/browser-use/.venv --python 3.12 && \
+    uv pip install --python /root/.pibo/tools/browser-use/.venv/bin/python \
+    'browser-use[cli]==0.12.6'
+
+RUN mkdir -p /root/.pibo/tools/agent-browser/home/bin \
+    /root/.pibo/tools/agent-browser/home/profiles \
+    /root/.pibo/tools/agent-browser/node && \
+    npm install --prefix /root/.pibo/tools/agent-browser/node agent-browser@0.27.0
+
+WORKDIR /app/node_modules/@pasko70/pibo
+RUN sed -i 's/\r$//' scripts/*.sh && \
+    chmod +x scripts/*.sh && \
+    scripts/prepare-browser-use-wrapper.sh && \
+    scripts/prepare-agent-browser-wrapper.sh && \
+    mkdir -p /root/.pibo /root/.browser-use /root/.pibo/tools/agent-browser/home
+
+EXPOSE 4788 4789 56663
+
+ENTRYPOINT ["/app/node_modules/@pasko70/pibo/scripts/docker-entrypoint.sh"]
+CMD ["gateway:web"]

package/compute-image/Dockerfile.dockerignore

@@ -0,0 +1,5 @@
+node_modules
+node_modules/**
+.pibo
+.pibo/**
+*.log

package/dist/agent-runtime/contract.js

@@ -1,46 +1,96 @@
 import { AgentRuntimeContractError } from "./errors.js";
+import { validateAgentRuntimeCapabilities } from "./capabilities.js";
 import { hasPendingNativeSession } from "../sessions/runtime-binding.js";
+const REQUIRED_SESSION_METHODS = ["getBinding", "subscribe", "prompt", "abort", "dispose", "getStatus"];
+const BINDING_STATES = new Set(["unbound", "bound", "missing", "error"]);
+function isRecord(value) {
+    return Boolean(value && typeof value === "object" && !Array.isArray(value));
+}
 export function validateAgentRuntimeSessionContract(session) {
     const errors = [];
-    const capabilities = session.capabilities;
-    const controls = session.controls;
+    if (!isRecord(session))
+        return ["session must be an object"];
+    for (const field of ["adapterId", "runtimeInstanceId", "cwd"]) {
+        if (typeof session[field] !== "string" || !session[field].trim()) {
+            errors.push(`session.${field} must be a non-empty string`);
+        }
+    }
+    for (const method of REQUIRED_SESSION_METHODS) {
+        if (typeof session[method] !== "function")
+            errors.push(`session.${method}() is required`);
+    }
+    let capabilities;
+    if (!isRecord(session.capabilities)) {
+        errors.push("session.capabilities must be an object");
+    }
+    else {
+        const capabilityErrors = validateAgentRuntimeCapabilities(session.capabilities);
+        errors.push(...capabilityErrors.map((error) => `session.capabilities.${error}`));
+        if (capabilityErrors.length === 0)
+            capabilities = session.capabilities;
+    }
+    const controls = isRecord(session.controls) ? session.controls : undefined;
+    if (session.controls !== undefined && !controls)
+        errors.push("session.controls must be an object when provided");
     const requireMethod = (enabled, path, method) => {
         if (enabled && typeof controls?.[method] !== "function") {
             errors.push(`${path} requires controls.${String(method)}()`);
         }
     };
-    if (capabilities.input.steering && typeof session.steer !== "function") {
+    if (capabilities?.input.steering && typeof session.steer !== "function") {
         errors.push("input.steering requires session.steer()");
     }
-    requireMethod(capabilities.lifecycle.listNativeSessions, "lifecycle.listNativeSessions", "listSessions");
-    requireMethod(capabilities.lifecycle.fork, "lifecycle.fork", "forkSession");
-    requireMethod(capabilities.lifecycle.clone, "lifecycle.clone", "cloneSession");
-    requireMethod(capabilities.lifecycle.tree, "lifecycle.tree", "getSessionTree");
-    requireMethod(capabilities.lifecycle.tree, "lifecycle.tree", "navigateSessionTree");
-    requireMethod(capabilities.models.switchInSession, "models.switchInSession", "setModel");
-    requireMethod(capabilities.reasoning.supported, "reasoning.supported", "getReasoning");
-    requireMethod(capabilities.reasoning.supported, "reasoning.supported", "setReasoning");
-    requireMethod(capabilities.approvals.supported, "approvals.supported", "respondToApproval");
-    requireMethod(capabilities.approvals.structuredUserInput, "approvals.structuredUserInput", "respondToUserInput");
-    requireMethod(capabilities.maintenance.compaction, "maintenance.compaction", "compact");
-    const binding = session.getBinding();
-    if (binding.adapterId !== session.adapterId) {
-        errors.push(`binding.adapterId "${binding.adapterId}" does not match session.adapterId "${session.adapterId}"`);
-    }
-    if (binding.runtimeInstanceId !== session.runtimeInstanceId) {
-        errors.push(`binding.runtimeInstanceId "${binding.runtimeInstanceId}" does not match session.runtimeInstanceId "${session.runtimeInstanceId}"`);
-    }
-    if (binding.state === "bound" && !binding.nativeSessionId) {
-        errors.push("a bound session requires binding.nativeSessionId");
-    }
-    if (binding.state === "unbound" && binding.nativeSessionId && !hasPendingNativeSession(binding)) {
-        errors.push("an unbound session must not expose binding.nativeSessionId");
+    if (capabilities) {
+        requireMethod(capabilities.lifecycle.listNativeSessions, "lifecycle.listNativeSessions", "listSessions");
+        requireMethod(capabilities.lifecycle.fork, "lifecycle.fork", "forkSession");
+        requireMethod(capabilities.lifecycle.clone, "lifecycle.clone", "cloneSession");
+        requireMethod(capabilities.lifecycle.tree, "lifecycle.tree", "getSessionTree");
+        requireMethod(capabilities.lifecycle.tree, "lifecycle.tree", "navigateSessionTree");
+        requireMethod(capabilities.models.switchInSession, "models.switchInSession", "setModel");
+        requireMethod(capabilities.reasoning.supported, "reasoning.supported", "getReasoning");
+        requireMethod(capabilities.reasoning.supported, "reasoning.supported", "setReasoning");
+        requireMethod(capabilities.approvals.supported, "approvals.supported", "respondToApproval");
+        requireMethod(capabilities.approvals.structuredUserInput, "approvals.structuredUserInput", "respondToUserInput");
+        requireMethod(capabilities.maintenance.compaction, "maintenance.compaction", "compact");
+    }
+    if (typeof session.getBinding === "function") {
+        try {
+            const binding = session.getBinding();
+            if (!isRecord(binding)) {
+                errors.push("session.getBinding() must return an object");
+            }
+            else {
+                for (const field of ["piboSessionId", "runtimeInstanceId", "adapterId"]) {
+                    if (typeof binding[field] !== "string" || !binding[field].trim()) {
+                        errors.push(`session.getBinding().${field} must be a non-empty string`);
+                    }
+                }
+                if (!BINDING_STATES.has(String(binding.state))) {
+                    errors.push("session.getBinding().state is invalid");
+                }
+                if (binding.adapterId !== session.adapterId) {
+                    errors.push(`binding.adapterId "${String(binding.adapterId)}" does not match session.adapterId "${String(session.adapterId)}"`);
+                }
+                if (binding.runtimeInstanceId !== session.runtimeInstanceId) {
+                    errors.push(`binding.runtimeInstanceId "${String(binding.runtimeInstanceId)}" does not match session.runtimeInstanceId "${String(session.runtimeInstanceId)}"`);
+                }
+                if (binding.state === "bound" && !binding.nativeSessionId) {
+                    errors.push("a bound session requires binding.nativeSessionId");
+                }
+                if (binding.state === "unbound" && binding.nativeSessionId && !hasPendingNativeSession(binding)) {
+                    errors.push("an unbound session must not expose binding.nativeSessionId");
+                }
+            }
+        }
+        catch {
+            errors.push("session.getBinding() must not throw during contract validation");
+        }
     }
     return errors;
 }
-export function assertAgentRuntimeSessionContract(session) {
+export function assertAgentRuntimeSessionContract(session, runtimeInstanceId) {
     const errors = validateAgentRuntimeSessionContract(session);
     if (errors.length > 0) {
-        throw new AgentRuntimeContractError(session.runtimeInstanceId, `Agent runtime session contract failed: ${errors.join("; ")}`);
+        throw new AgentRuntimeContractError(runtimeInstanceId ?? (isRecord(session) && typeof session.runtimeInstanceId === "string" ? session.runtimeInstanceId : "unknown"), `Agent runtime session contract failed: ${errors.join("; ")}`);
     }
 }

package/dist/agent-runtime/portable-history.js

@@ -46,6 +46,9 @@ function boundedIdentifierText(value, fallback, maxLength = 512) {
 function optionalBoundedIdentifierText(value) {
     return value ? boundedIdentifierText(value, "portable-id") : undefined;
 }
+function toolInvocationKey(turnId, toolCallId) {
+    return JSON.stringify([turnId ?? null, toolCallId]);
+}
 function boundedText(value, maxBytes = MAX_ENTRY_BYTES) {
     if (Buffer.byteLength(value, "utf8") <= maxBytes)
         return value;
@@ -274,18 +277,22 @@ export class PiboDataPortableHistoryProvider {
         for (const row of rows) {
             if (!row.tool_call_id)
                 continue;
+            const invocationKey = toolInvocationKey(row.turn_id, row.tool_call_id);
             if (row.type === "tool_call") {
                 const attributes = parseObject(row.attributes_json);
-                const existing = calls.get(row.tool_call_id);
+                const existing = calls.get(invocationKey);
                 if (!existing || attributes.argsComplete === true)
-                    calls.set(row.tool_call_id, row);
+                    calls.set(invocationKey, row);
             }
             else {
-                results.set(row.tool_call_id, row);
+                results.set(invocationKey, row);
             }
         }
         const entries = [];
-        for (const [toolCallId, row] of calls) {
+        for (const row of calls.values()) {
+            const toolCallId = row.tool_call_id;
+            if (!toolCallId)
+                continue;
             const attributes = parseObject(row.attributes_json);
             const portableToolCallId = boundedIdentifierText(toolCallId, `tool-call-${row.stream_id}`);
             const toolName = boundedIdentifierText(typeof attributes.toolName === "string" ? attributes.toolName : row.preview_text ?? "tool", "tool", 256);
@@ -309,7 +316,10 @@ export class PiboDataPortableHistoryProvider {
                 toolName,
             });
         }
-        for (const [toolCallId, row] of results) {
+        for (const row of results.values()) {
+            const toolCallId = row.tool_call_id;
+            if (!toolCallId)
+                continue;
             const attributes = parseObject(row.attributes_json);
             const portableToolCallId = boundedIdentifierText(toolCallId, `tool-call-${row.stream_id}`);
             const toolName = boundedIdentifierText(typeof attributes.toolName === "string" ? attributes.toolName : row.preview_text ?? "tool", "tool", 256);
@@ -374,18 +384,18 @@ function normalizeToolPairs(entries) {
         if (entry.type !== "message")
             continue;
         if (entry.role === "tool" && entry.toolCallId)
-            resultIds.add(entry.toolCallId);
+            resultIds.add(toolInvocationKey(entry.turnId, entry.toolCallId));
         if (!Array.isArray(entry.content))
             continue;
         for (const part of entry.content) {
             if (part.type === "tool_call")
-                callIds.add(part.toolCallId);
+                callIds.add(toolInvocationKey(entry.turnId, part.toolCallId));
         }
     }
     return entries.map((entry) => {
         if (entry.type !== "message")
             return entry;
-        if (entry.role === "tool" && entry.toolCallId && !callIds.has(entry.toolCallId)) {
+        if (entry.role === "tool" && entry.toolCallId && !callIds.has(toolInvocationKey(entry.turnId, entry.toolCallId))) {
             return {
                 ...entry,
                 role: "user",
@@ -402,7 +412,7 @@ function normalizeToolPairs(entries) {
         if (entry.role !== "assistant" || !Array.isArray(entry.content))
             return entry;
         const content = entry.content.map((part) => {
-            if (part.type !== "tool_call" || resultIds.has(part.toolCallId))
+            if (part.type !== "tool_call" || resultIds.has(toolInvocationKey(entry.turnId, part.toolCallId)))
                 return part;
             return {
                 type: "text",

package/dist/agent-runtime/registry.js

@@ -450,10 +450,16 @@ export class AgentRuntimeAdapterRegistry {
         const adapter = this.requireInstance(instanceId);
         const session = await adapter.openSession(input);
         try {
-            assertAgentRuntimeSessionContract(session);
+            assertAgentRuntimeSessionContract(session, instanceId);
         }
         catch (error) {
-            await session.dispose().catch(() => { });
+            try {
+                if (typeof session?.dispose === "function")
+                    await session.dispose();
+            }
+            catch {
+                // Preserve the admission error when best-effort cleanup also fails.
+            }
             throw error;
         }
         return session;

package/dist/agent-runtime/routed-session.js

@@ -14,7 +14,7 @@ const RUN_REMINDER_CAPABILITY_TOOLS = new Set([
 const RUN_REMINDER_MAX_TOOL_EXECUTIONS = 64;
 const RUN_REMINDER_MAX_PROVIDER_ROUNDS = 64;
 const RUN_REMINDER_MAX_ACTIVE_TOKENS = 2_000_000;
-const RUN_REMINDER_MAX_DURATION_MS = 15 * 60 * 1000;
+export const RUN_REMINDER_MAX_DURATION_MS = 15 * 60 * 1000;
 const RUN_REMINDER_MAX_REPEATED_TOOL_CALLS = 12;
 function serializedToolArgs(value) {
     try {
@@ -208,14 +208,20 @@ export class RuntimeRoutedSession {
         this.assertActive();
         if (event.action === "compact")
             return this.enqueueCompactAction(event);
-        const changesSessionIdentity = event.action === "session.fork" || event.action === "session.clone";
-        if (changesSessionIdentity) {
-            this.assertSessionIdentityOperationIdle(event.action === "session.fork" ? "fork" : "clone");
+        const sessionIdentityOperation = event.action === "session.fork"
+            ? "fork"
+            : event.action === "session.clone"
+                ? "clone"
+                : event.action === "session.switch"
+                    ? "switch"
+                    : undefined;
+        if (sessionIdentityOperation) {
+            this.assertSessionIdentityOperationIdle(sessionIdentityOperation);
             this.sessionIdentityOperationInFlight = true;
             this.notifyState();
         }
         try {
-            if (changesSessionIdentity)
+            if (sessionIdentityOperation)
                 await this.options.onBeforeSessionIdentityOperation?.(event);
             const result = await this.runAction(event);
             if (isSessionOperationResult(result))
@@ -231,7 +237,7 @@ export class RuntimeRoutedSession {
             return output;
         }
         finally {
-            if (changesSessionIdentity) {
+            if (sessionIdentityOperation) {
                 this.sessionIdentityOperationInFlight = false;
                 this.notifyState();
                 this.startDrain();

package/dist/agent-runtimes/pi/routed-session.js

@@ -1107,9 +1107,15 @@ export class RoutedSession {
         if (event.action === "compact") {
             return this.enqueueCompactAction(event);
         }
-        const changesSessionIdentity = event.action === "session.fork" || event.action === "session.clone";
-        if (changesSessionIdentity) {
-            this.assertSessionIdentityOperationIdle(event.action === "session.fork" ? "fork" : "clone");
+        const sessionIdentityOperation = event.action === "session.fork"
+            ? "fork"
+            : event.action === "session.clone"
+                ? "clone"
+                : event.action === "session.switch"
+                    ? "switch"
+                    : undefined;
+        if (sessionIdentityOperation) {
+            this.assertSessionIdentityOperationIdle(sessionIdentityOperation);
             this.sessionIdentityOperationInFlight = true;
         }
         try {
@@ -1127,7 +1133,7 @@ export class RoutedSession {
             return output;
         }
         finally {
-            if (changesSessionIdentity)
+            if (sessionIdentityOperation)
                 this.sessionIdentityOperationInFlight = false;
         }
     }

package/dist/apps/chat/agent-store.js

@@ -6,6 +6,17 @@ import { DatabaseSync } from "node:sqlite";
 import { DEFAULT_AGENT_RUNTIME_INSTANCE_ID, DEFAULT_BUILTIN_TOOL_NAMES } from "../../core/profiles.js";
 import { isPiboThinkingLevel } from "../../core/thinking.js";
 import { findPiPackage } from "../../pi-packages/store.js";
+export class CustomAgentTargetReferenceError extends Error {
+    targetProfileName;
+    dependentProfileNames;
+    constructor(targetProfileName, dependentProfileNames) {
+        const sortedNames = [...dependentProfileNames].sort((left, right) => left.localeCompare(right));
+        super(`Custom agent "${targetProfileName}" is targeted by custom agents: ${sortedNames.join(", ")}`);
+        this.name = "CustomAgentTargetReferenceError";
+        this.targetProfileName = targetProfileName;
+        this.dependentProfileNames = sortedNames;
+    }
+}
 const CUSTOM_AGENT_NAME_PATTERN = /^[a-z][a-z0-9]*(?:-[a-z0-9]+)*$/;
 export function previewCustomAgentCreate(input, options = {}) {
     const now = options.now ?? new Date().toISOString();
@@ -264,10 +275,42 @@ export class CustomAgentStore {
             .run(archivedAt, new Date().toISOString(), id);
         return this.get(id);
     }
+    listReferencingAgents(id) {
+        this.migrateLegacyProfileNames();
+        const target = this.get(id);
+        if (!target)
+            return [];
+        const targetNames = new Set([
+            target.profileName,
+            target.id,
+            `custom-agent:${target.id}`,
+            ...target.profileAliases,
+        ]);
+        return this.list({ includeArchived: true })
+            .filter((agent) => agent.id !== id && agent.subagents.some((subagent) => targetNames.has(subagent.targetProfile)))
+            .sort((left, right) => left.profileName.localeCompare(right.profileName));
+    }
     delete(id) {
-        this.db.prepare("DELETE FROM chat_agent_profile_aliases WHERE agent_id = ?").run(id);
-        const result = this.db.prepare("DELETE FROM chat_agents WHERE id = ?").run(id);
-        return Number(result.changes ?? 0) > 0;
+        this.db.exec("BEGIN IMMEDIATE");
+        try {
+            const target = this.get(id);
+            if (!target) {
+                this.db.exec("COMMIT");
+                return false;
+            }
+            const dependents = this.listReferencingAgents(id);
+            if (dependents.length > 0) {
+                throw new CustomAgentTargetReferenceError(target.profileName, dependents.map((agent) => agent.profileName));
+            }
+            this.db.prepare("DELETE FROM chat_agent_profile_aliases WHERE agent_id = ?").run(id);
+            const result = this.db.prepare("DELETE FROM chat_agents WHERE id = ?").run(id);
+            this.db.exec("COMMIT");
+            return Number(result.changes ?? 0) > 0;
+        }
+        catch (error) {
+            this.db.exec("ROLLBACK");
+            throw error;
+        }
     }
     close() {
         this.db.close();
@@ -369,6 +412,15 @@ export class CustomAgentStore {
                 .prepare("UPDATE chat_agents SET profile_name = ?, display_name = ? WHERE id = ?")
                 .run(nextName, nextName, row.id);
         }
+        this.db.prepare(`
+			DELETE FROM chat_agent_profile_aliases
+			WHERE EXISTS (
+				SELECT 1
+				FROM chat_agents
+				WHERE chat_agents.profile_name = chat_agent_profile_aliases.old_profile_name
+					AND chat_agents.id != chat_agent_profile_aliases.agent_id
+			)
+		`).run();
     }
     migrateAgentFolderColumn() {
         if (!this.tableColumns().has("folder_id")) {

package/dist/apps/chat/data/project-service.js

@@ -1,6 +1,6 @@
 import { randomUUID } from "node:crypto";
-import { mkdirSync, rmSync, statSync } from "node:fs";
-import { dirname, isAbsolute, resolve } from "node:path";
+import { mkdirSync, realpathSync, rmSync, statSync } from "node:fs";
+import { basename, dirname, isAbsolute, relative, resolve, sep } from "node:path";
 import { DatabaseSync } from "node:sqlite";
 import { piboHomePath } from "../../../core/pibo-home.js";
 export class ChatProjectService {
@@ -72,7 +72,7 @@ export class ChatProjectService {
         const projectFolder = resolve(normalizeProjectFolder(input.projectFolder));
         this.assertNameAvailable(name);
         this.assertFolderAvailable(projectFolder);
-        this.ensureProjectFolderUsable(projectFolder);
+        this.ensureProjectFolderUsable(projectFolder, input.createFolder === true);
         const now = new Date().toISOString();
         const id = `prj_${randomUUID()}`;
         this.db.prepare(`INSERT INTO projects (id, name, description, project_folder, configuration_status, metadata_json, created_at, updated_at)
@@ -93,16 +93,26 @@ export class ChatProjectService {
         return this.getProject(id, { includeArchived: true });
     }
     deleteProject(id, options) {
-        const project = this.requireProject(id, { includeArchived: true });
-        if (!project.archivedAt)
-            throw new Error("Archive the project before permanently deleting it.");
-        if (options.confirmName !== project.name)
-            throw new Error(`Type \"${project.name}\" to permanently delete this project.`);
-        this.db.prepare("DELETE FROM project_sessions WHERE project_id = ?").run(id);
-        this.db.prepare("DELETE FROM projects WHERE id = ?").run(id);
-        if (options.deleteFiles)
-            rmSync(project.projectFolder, { recursive: true, force: true });
-        return { deletedProjectId: id };
+        this.db.exec("BEGIN IMMEDIATE");
+        try {
+            const project = this.requireProject(id, { includeArchived: true });
+            if (!project.archivedAt)
+                throw new Error("Archive the project before permanently deleting it.");
+            if (options.confirmName !== project.name)
+                throw new Error(`Type \"${project.name}\" to permanently delete this project.`);
+            if (options.deleteFiles)
+                this.assertFolderDoesNotOverlapAnotherProject(project);
+            this.db.prepare("DELETE FROM project_sessions WHERE project_id = ?").run(id);
+            this.db.prepare("DELETE FROM projects WHERE id = ?").run(id);
+            if (options.deleteFiles)
+                rmSync(project.projectFolder, { recursive: true, force: true });
+            this.db.exec("COMMIT");
+            return { deletedProjectId: id };
+        }
+        catch (error) {
+            this.db.exec("ROLLBACK");
+            throw error;
+        }
     }
     listProjectSessions(projectId, options = {}) {
         const rows = this.db.prepare(`SELECT * FROM project_sessions WHERE project_id = ? ${options.includeArchived ? "" : "AND archived = 0"} ORDER BY created_at`).all(projectId);
@@ -112,6 +122,60 @@ export class ChatProjectService {
         const row = this.db.prepare("SELECT * FROM project_sessions WHERE pibo_session_id = ?").get(piboSessionId);
         return row ? projectSessionFromRow(row) : undefined;
     }
+    deleteProjectSessions(piboSessionIds) {
+        const ids = [...new Set(piboSessionIds.filter(Boolean))];
+        if (ids.length === 0)
+            return 0;
+        this.db.exec("BEGIN IMMEDIATE");
+        try {
+            const deleted = this.deleteProjectSessionsLocked(ids, new Date().toISOString());
+            this.db.exec("COMMIT");
+            return deleted;
+        }
+        catch (error) {
+            this.db.exec("ROLLBACK");
+            throw error;
+        }
+    }
+    async deleteProjectSessionWithCanonicalDelete(piboSessionId, deleteCanonicalSession) {
+        this.db.exec("BEGIN IMMEDIATE");
+        try {
+            this.deleteProjectSessionsLocked([piboSessionId], new Date().toISOString());
+            const result = await deleteCanonicalSession();
+            this.db.exec("COMMIT");
+            return result;
+        }
+        catch (error) {
+            this.db.exec("ROLLBACK");
+            throw error;
+        }
+    }
+    deleteProjectSessionsLocked(ids, now) {
+        const placeholders = ids.map(() => "?").join(", ");
+        const affectedProjects = this.db.prepare(`SELECT DISTINCT id FROM projects
+			WHERE current_main_session_id IN (${placeholders})
+			UNION
+			SELECT DISTINCT project_id AS id FROM project_sessions WHERE pibo_session_id IN (${placeholders})`)
+            .all(...ids, ...ids);
+        const deleted = this.db.prepare(`DELETE FROM project_sessions WHERE pibo_session_id IN (${placeholders})`).run(...ids);
+        for (const project of affectedProjects) {
+            const current = this.db.prepare("SELECT current_main_session_id FROM projects WHERE id = ?")
+                .get(project.id);
+            if (!current?.current_main_session_id)
+                continue;
+            const currentLink = this.db.prepare("SELECT 1 FROM project_sessions WHERE project_id = ? AND pibo_session_id = ?")
+                .get(project.id, current.current_main_session_id);
+            if (currentLink)
+                continue;
+            const replacement = this.db.prepare(`SELECT pibo_session_id FROM project_sessions
+				WHERE project_id = ? AND kind = 'main' AND archived = 0
+				ORDER BY updated_at DESC, created_at DESC, pibo_session_id DESC
+				LIMIT 1`).get(project.id);
+            this.db.prepare("UPDATE projects SET current_main_session_id = ?, updated_at = ? WHERE id = ?")
+                .run(replacement?.pibo_session_id ?? null, now, project.id);
+        }
+        return Number(deleted.changes ?? 0);
+    }
     addProjectSession(input) {
         const existing = this.getProjectSession(input.piboSessionId);
         const now = new Date().toISOString();
@@ -599,9 +663,17 @@ export class ChatProjectService {
         if (existing)
             throw new Error("Project folder already exists");
     }
-    ensureProjectFolderUsable(folder) {
+    assertFolderDoesNotOverlapAnotherProject(project) {
+        const projects = this.db.prepare("SELECT name, project_folder FROM projects WHERE id != ? ORDER BY lower(name), created_at").all(project.id);
+        const overlapping = projects.find((other) => pathsOverlap(project.projectFolder, other.project_folder));
+        if (overlapping) {
+            throw new Error(`Cannot delete project files because its folder overlaps Project \"${overlapping.name}\". Delete without deleting files or choose a non-overlapping folder.`);
+        }
+    }
+    ensureProjectFolderUsable(folder, createFolder) {
         try {
-            mkdirSync(folder, { recursive: true });
+            if (createFolder)
+                mkdirSync(folder, { recursive: true });
             if (!statSync(folder).isDirectory())
                 throw new Error("Project folder is not a directory");
         }
@@ -770,6 +842,38 @@ function normalizeProjectFolder(value) {
         throw new Error("Project folder must be an absolute path, e.g. ~/code/my-project or /home/me/code/my-project");
     return folder;
 }
+function pathsOverlap(left, right) {
+    if (pathContains(left, right) || pathContains(right, left))
+        return true;
+    const canonicalLeft = canonicalProjectPath(left);
+    const canonicalRight = canonicalProjectPath(right);
+    if (!canonicalLeft || !canonicalRight)
+        return true;
+    return pathContains(canonicalLeft, canonicalRight) || pathContains(canonicalRight, canonicalLeft);
+}
+function canonicalProjectPath(path) {
+    let current = resolve(path);
+    const missingSegments = [];
+    while (true) {
+        try {
+            return resolve(realpathSync(current), ...missingSegments);
+        }
+        catch (error) {
+            const code = error && typeof error === "object" && "code" in error ? error.code : undefined;
+            if (code !== "ENOENT" && code !== "ENOTDIR")
+                return undefined;
+            const parent = dirname(current);
+            if (parent === current)
+                return undefined;
+            missingSegments.unshift(basename(current));
+            current = parent;
+        }
+    }
+}
+function pathContains(parent, candidate) {
+    const pathFromParent = relative(resolve(parent), resolve(candidate));
+    return pathFromParent === "" || (pathFromParent !== ".." && !pathFromParent.startsWith(`..${sep}`) && !isAbsolute(pathFromParent));
+}
 const PROJECT_SESSION_STATES = new Set([
     "simple_chat",
     "workflow",

package/dist/apps/chat/data/room-service.js

@@ -1,6 +1,12 @@
 import { randomUUID } from "node:crypto";
 import { roomWorkspaceFromMetadata } from "../types/rooms.js";
 import { roomFromRow } from "./chat-data-mappers.js";
+export class PiboRoomHierarchyCycleError extends Error {
+    constructor() {
+        super("Room parent assignment would create a cycle.");
+        this.name = "PiboRoomHierarchyCycleError";
+    }
+}
 export class ChatRoomService {
     store;
     constructor(store) {
@@ -17,6 +23,9 @@ export class ChatRoomService {
         const existing = this.getRoom(id);
         if (!existing)
             return undefined;
+        if (input.parentRoomId && this.parentAssignmentCreatesCycle(id, input.parentRoomId)) {
+            throw new PiboRoomHierarchyCycleError();
+        }
         const metadata = input.metadata ?? existing.metadata;
         const updated = { ...existing, name: input.name ?? existing.name, topic: input.topic === null ? undefined : input.topic ?? existing.topic, parentRoomId: input.parentRoomId === null ? undefined : input.parentRoomId ?? existing.parentRoomId, retentionPolicyId: input.retentionPolicyId === null ? undefined : input.retentionPolicyId ?? existing.retentionPolicyId, metadata, workspace: roomWorkspaceFromMetadata(metadata), updatedAt: new Date().toISOString() };
         this.store.db.prepare("UPDATE rooms SET name = ?, topic = ?, parent_room_id = ?, workspace = ?, retention_policy_id = ?, metadata_json = ?, updated_at = ? WHERE id = ?").run(updated.name, updated.topic ?? null, updated.parentRoomId ?? null, updated.workspace ?? null, updated.retentionPolicyId ?? null, JSON.stringify(updated.metadata), updated.updatedAt, id);
@@ -49,4 +58,16 @@ export class ChatRoomService {
     requireRoom(roomId) { const room = this.getRoom(roomId); if (!room)
         throw new Error("Room not found"); return room; }
     close() { }
+    parentAssignmentCreatesCycle(roomId, parentRoomId) {
+        const roomsById = new Map(this.listRooms().map((room) => [room.id, room]));
+        const visited = new Set();
+        let currentId = parentRoomId;
+        while (currentId && !visited.has(currentId)) {
+            if (currentId === roomId)
+                return true;
+            visited.add(currentId);
+            currentId = roomsById.get(currentId)?.parentRoomId;
+        }
+        return false;
+    }
 }