@pascal-app/editor 1.0.3 → 1.0.5

package/src/components/tools/stair/stair-click-guard.test.ts

@@ -1,58 +0,0 @@
-import { describe, expect, test } from 'bun:test'
-import { createStairCommitGate, swallowFollowUpBrowserClick } from './stair-click-guard'
-
-describe('createStairCommitGate', () => {
-  test('allows commits until the session exits', () => {
-    const gate = createStairCommitGate()
-    expect(gate.shouldCommit()).toBe(true)
-    // Repeat continuation: consecutive commits stay allowed.
-    expect(gate.shouldCommit()).toBe(true)
-  })
-
-  test('refuses every trigger after a single-continuation exit', () => {
-    const gate = createStairCommitGate()
-    expect(gate.shouldCommit()).toBe(true)
-    gate.markExited()
-    // The native follow-up click / stray node click of the same gesture.
-    expect(gate.shouldCommit()).toBe(false)
-    expect(gate.shouldCommit()).toBe(false)
-  })
-})
-
-describe('swallowFollowUpBrowserClick', () => {
-  test('stops exactly one follow-up click', () => {
-    const target = new EventTarget()
-    swallowFollowUpBrowserClick(target)
-
-    let firstStopped = 0
-    const first = new Event('click', { cancelable: true })
-    Object.defineProperty(first, 'stopPropagation', { value: () => firstStopped++ })
-    target.dispatchEvent(first)
-    expect(firstStopped).toBe(1)
-    expect(first.defaultPrevented).toBe(true)
-
-    // `once: true` — the next click of the next gesture passes through.
-    let secondStopped = 0
-    const second = new Event('click', { cancelable: true })
-    Object.defineProperty(second, 'stopPropagation', { value: () => secondStopped++ })
-    target.dispatchEvent(second)
-    expect(secondStopped).toBe(0)
-    expect(second.defaultPrevented).toBe(false)
-  })
-
-  test('disarms after the timeout when no click follows', async () => {
-    const target = new EventTarget()
-    swallowFollowUpBrowserClick(target, 5)
-    await new Promise((resolve) => setTimeout(resolve, 15))
-
-    let stopped = 0
-    const late = new Event('click', { cancelable: true })
-    Object.defineProperty(late, 'stopPropagation', { value: () => stopped++ })
-    target.dispatchEvent(late)
-    expect(stopped).toBe(0)
-  })
-
-  test('no-ops without a window-like target', () => {
-    expect(() => swallowFollowUpBrowserClick(undefined)).not.toThrow()
-  })
-})

package/src/components/tools/stair/stair-click-guard.ts

@@ -1,72 +0,0 @@
-/**
- * Guards for the stair tool's commit triggers.
- *
- * One physical validation click can reach the stair tool's commit handler
- * twice: node-surface clicks (`slab:click`, `wall:click`, …) are synthesized
- * on *pointerup* by the viewer (`use-node-events`), while `grid:click` rides
- * the browser's native *click* event from a canvas-level DOM listener
- * (`use-grid-events`) that deliberately ignores R3F stopPropagation — and
- * after a single-continuation commit the tool's emitter subscriptions survive
- * until React unmounts it, which lands only after that native click. Without
- * these guards a validation click over any node surface (a deck or floor
- * slab, a wall, another stair) created TWO stairs from one click.
- *
- * Same hazard and same countermeasures as
- * `packages/nodes/src/shared/floor-placement.ts` (`stopPlacementCommitPropagation`)
- * and the `committed` flag in `move-registry-node-tool.tsx` — reimplemented
- * here because `@pascal-app/editor` cannot depend on `@pascal-app/nodes`.
- */
-
-export type StairCommitGate = {
-  /** True while the armed session may still commit. */
-  shouldCommit: () => boolean
-  /**
-   * Mark the session exited (single continuation): every further click
-   * trigger reaching the still-subscribed handler — the native follow-up
-   * click, a stray second node click — is refused.
-   */
-  markExited: () => void
-}
-
-export function createStairCommitGate(): StairCommitGate {
-  let exited = false
-  return {
-    shouldCommit: () => !exited,
-    markExited: () => {
-      exited = true
-    },
-  }
-}
-
-type ClickSwallowTarget = {
-  addEventListener: (
-    type: string,
-    listener: (event: Event) => void,
-    options?: AddEventListenerOptions,
-  ) => void
-  removeEventListener: (
-    type: string,
-    listener: (event: Event) => void,
-    options?: EventListenerOptions,
-  ) => void
-}
-
-/**
- * Eat the one native browser `click` that follows a pointerup-synthesized
- * node click, before it reaches the canvas `grid:click` listener (capture
- * phase on window runs first). Needed in repeat continuation too, where the
- * tool stays armed and the gate above must keep allowing one commit per
- * gesture. Self-disarms after the click or `timeoutMs`, whichever first.
- */
-export function swallowFollowUpBrowserClick(
-  target: ClickSwallowTarget | undefined = typeof window === 'undefined' ? undefined : window,
-  timeoutMs = 300,
-): void {
-  if (!target) return
-  const swallow = (event: Event) => {
-    event.stopPropagation()
-    event.preventDefault()
-  }
-  target.addEventListener('click', swallow, { capture: true, once: true })
-  setTimeout(() => target.removeEventListener('click', swallow, { capture: true }), timeoutMs)
-}

package/src/components/tools/stair/stair-defaults.ts

@@ -1,18 +0,0 @@
-export const DEFAULT_STAIR_TYPE = 'straight' as const
-export const DEFAULT_STAIR_WIDTH = 1.0
-export const DEFAULT_STAIR_LENGTH = 3.0
-export const DEFAULT_STAIR_HEIGHT = 2.5
-export const DEFAULT_STAIR_STEP_COUNT = 10
-export const DEFAULT_STAIR_ATTACHMENT_SIDE = 'front' as const
-export const DEFAULT_STAIR_FILL_TO_FLOOR = true
-export const DEFAULT_STAIR_THICKNESS = 0.25
-export const DEFAULT_STAIR_OPENING_OFFSET = 0
-export const DEFAULT_CURVED_STAIR_INNER_RADIUS = 0.9
-export const DEFAULT_CURVED_STAIR_SWEEP_ANGLE = Math.PI / 2
-export const DEFAULT_SPIRAL_STAIR_SWEEP_ANGLE = (400 * Math.PI) / 180
-export const DEFAULT_SPIRAL_TOP_LANDING_MODE = 'none' as const
-export const DEFAULT_SPIRAL_TOP_LANDING_DEPTH = 0.9
-export const DEFAULT_SPIRAL_SHOW_CENTER_COLUMN = true
-export const DEFAULT_SPIRAL_SHOW_STEP_SUPPORTS = true
-export const DEFAULT_STAIR_RAILING_MODE = 'both' as const
-export const DEFAULT_STAIR_RAILING_HEIGHT = 0.92