@pascal-app/editor 1.0.3 → 1.0.4

package/src/components/editor/slab-hole-highlights.tsx

@@ -417,7 +417,10 @@ function SlabHoleHighlight({
     [holeIndex, metadata, slabId],
   )
 
+  // Only a release that ends a press on a hole is the hole's: any other
+  // (a handle drag let go over the hole) must reach its owner.
   const handlePointerUp = useCallback((event: ThreeEvent<PointerEvent>) => {
+    if (!restoreNodeClickSuppression) return
     releaseNodeClickSuppression()
     stopPointerPropagation(event)
   }, [])

package/src/components/editor/snapshot-capture-overlay.tsx

@@ -29,6 +29,7 @@ import useEditor, {
 import { useFirstPersonHud } from '../../store/use-first-person-hud'
 import { Slider } from '../ui/slider'
 import { WalkthroughCrosshair } from '../walkthrough-hud'
+import { CaptureLevelPicker } from './capture-level-picker'
 import { isOverlaySnapshotSave } from './snapshot-capture'
 
 // Local alias — distinct from `useEditor.captureMode` (which describes *why*
@@ -710,6 +711,9 @@ export function SnapshotCaptureOverlay({ projectId }: { projectId: string }) {
         </div>
       )}
 
+      {/* Top-left: which levels the shot shows (the whole building by default). */}
+      {!isPreset && <CaptureLevelPicker />}
+
       {/* Top-right dismiss button (icon-only on mobile) */}
       <div className="pointer-events-auto absolute top-4 right-4">
         <button

package/src/components/editor/snapshot-capture.test.ts

@@ -1,14 +1,17 @@
 import { describe, expect, test } from 'bun:test'
-import type {
-  SnapshotCaptureFailedEvent,
-  SnapshotCapturePose,
-  ThumbnailGenerateEvent,
+import {
+  emitter,
+  type SnapshotCapturedEvent,
+  type SnapshotCaptureFailedEvent,
+  type SnapshotCapturePose,
+  type ThumbnailGenerateEvent,
 } from '@pascal-app/core'
 import { Euler, PerspectiveCamera, Quaternion, Vector3 } from 'three'
 import {
   applySnapshotCapturePose,
   captureSnapshotScene,
   createSnapshotQueue,
+  deliverSnapshot,
   enqueueSnapshotCapture,
   isOverlaySnapshotSave,
   runSnapshotCapture,
@@ -420,3 +423,48 @@ describe('snapshot request correlation', () => {
     expect(failures).toEqual([])
   })
 })
+
+// An agent looks at the scene from a viewpoint of its own (`view_scene` in the hosted chat): the
+// frame is for the agent only, never a project snapshot or the project's thumbnail.
+describe('an ephemeral capture', () => {
+  const cameraData = { position: [0, 0, 0] as [number, number, number], target: null }
+
+  test('comes back to its caller on snapshot:captured and never reaches the host storage', async () => {
+    const stored: Blob[] = []
+    const received: SnapshotCapturedEvent[] = []
+    const onCaptured = (event: SnapshotCapturedEvent) => received.push(event)
+    emitter.on('snapshot:captured', onCaptured)
+    try {
+      const blob = new Blob(['frame'], { type: 'image/webp' })
+      await deliverSnapshot(
+        { requestId: 'view-1', ephemeral: true },
+        blob,
+        { ...cameraData, resolution: { w: 1280, h: 800 } },
+        (frame) => {
+          stored.push(frame)
+        },
+      )
+      expect(stored).toEqual([])
+      expect(received).toEqual([{ requestId: 'view-1', blob, width: 1280, height: 800 }])
+    } finally {
+      emitter.off('snapshot:captured', onCaptured)
+    }
+  })
+
+  test('an ephemeral frame with no caller to answer is stored nowhere', async () => {
+    const stored: Blob[] = []
+    await deliverSnapshot({ ephemeral: true }, new Blob(['frame']), cameraData, (frame) => {
+      stored.push(frame)
+    })
+    expect(stored).toEqual([])
+  })
+
+  test('any other capture goes to the host as before', async () => {
+    const stored: Blob[] = []
+    const blob = new Blob(['frame'])
+    await deliverSnapshot({ requestId: 'shot-1' }, blob, cameraData, (frame) => {
+      stored.push(frame)
+    })
+    expect(stored).toEqual([blob])
+  })
+})

package/src/components/editor/snapshot-capture.ts

@@ -1,8 +1,9 @@
-import type {
-  SnapshotCaptureFailedEvent,
-  SnapshotCapturePose,
-  SnapshotSavedEvent,
-  ThumbnailGenerateEvent,
+import {
+  emitter,
+  type SnapshotCaptureFailedEvent,
+  type SnapshotCapturePose,
+  type SnapshotSavedEvent,
+  type ThumbnailGenerateEvent,
 } from '@pascal-app/core'
 import { MathUtils, type PerspectiveCamera } from 'three'
 
@@ -143,3 +144,27 @@ export async function runSnapshotCapture(
     busy.current = false
   }
 }
+
+/**
+ * Where a captured frame goes: to the host, which stores it (a snapshot, the project's
+ * thumbnail), or for an ephemeral capture straight back to its caller, stored nowhere.
+ */
+export function deliverSnapshot<T extends object & { resolution?: { w: number; h: number } }>(
+  event: Pick<ThumbnailGenerateEvent, 'requestId' | 'ephemeral'>,
+  blob: Blob,
+  cameraData: T,
+  onCapture: (blob: Blob, cameraData: T) => void | Promise<void>,
+): void | Promise<void> {
+  // An ephemeral frame is never stored: with no caller to answer, it is dropped.
+  if (event.ephemeral) {
+    if (event.requestId)
+      emitter.emit('snapshot:captured', {
+        requestId: event.requestId,
+        blob,
+        width: cameraData.resolution?.w ?? 0,
+        height: cameraData.resolution?.h ?? 0,
+      })
+    return
+  }
+  return onCapture(blob, cameraData)
+}

package/src/components/editor/thumbnail-generator.test.ts

@@ -0,0 +1,308 @@
+import { afterEach, beforeEach, describe, expect, test } from 'bun:test'
+import { type AnyNode, sceneRegistry, useScene } from '@pascal-app/core'
+import { BuildingNode, CeilingNode, LevelNode, WallNode } from '@pascal-app/core/schema'
+import { hideFromScene, SCENE_LAYER, useViewer } from '@pascal-app/viewer'
+import { Group, Layers, Mesh, OrthographicCamera, PerspectiveCamera, Vector2 } from 'three'
+import { CanvasTarget, ClippingGroup, type WebGPURenderer } from 'three/webgpu'
+import {
+  atCaptureSize,
+  capturesOrthographically,
+  interiorCutaway,
+  presentFinished,
+  pumpFrames,
+  tileGrid,
+} from './thumbnail-generator'
+
+type FakeCanvas = { width: number; height: number; style: Record<string, string> }
+
+const realDocument = (globalThis as { document?: unknown }).document
+
+beforeEach(() => {
+  ;(globalThis as { document?: unknown }).document = {
+    createElement: (): FakeCanvas => ({ width: 0, height: 0, style: {} }),
+  }
+})
+
+afterEach(() => {
+  ;(globalThis as { document?: unknown }).document = realDocument
+})
+
+/** The part of three's renderer a capture's passes size themselves from. */
+function fakeRenderer(canvas: FakeCanvas, pixelRatio: number) {
+  const [cssWidth, cssHeight] = [canvas.width / pixelRatio, canvas.height / pixelRatio]
+  let target = new CanvasTarget(canvas as unknown as HTMLCanvasElement)
+  target.setPixelRatio(pixelRatio)
+  target.setSize(cssWidth, cssHeight, false)
+  const renderer = {
+    getCanvasTarget: () => target,
+    setCanvasTarget: (next: CanvasTarget) => {
+      target = next
+    },
+    getDrawingBufferSize: (v: Vector2) => target.getDrawingBufferSize(v),
+    get domElement() {
+      return target.domElement
+    },
+  }
+  return renderer as unknown as WebGPURenderer & typeof renderer
+}
+
+describe('supersampled capture', () => {
+  test('renders at its own size while the live canvas keeps its size', () => {
+    // a 1.5 dpr screen: the old capture resized the live canvas with drawing
+    // buffer pixels where CSS pixels were due — 3× during the capture, 1.5×
+    // after it, compounding capture after capture
+    const live: FakeCanvas = { width: 1156, height: 791, style: {} }
+    const renderer = fakeRenderer(live, 1.5)
+    const liveTarget = renderer.getCanvasTarget()
+
+    const seen = atCaptureSize(renderer, 2312, 1582, () => {
+      expect(live.width).toBe(1156)
+      expect(live.height).toBe(791)
+      return {
+        buffer: renderer.getDrawingBufferSize(new Vector2()).toArray(),
+        canvas: [renderer.domElement.width, renderer.domElement.height],
+      }
+    })
+
+    expect(seen.buffer).toEqual([2312, 1582])
+    expect(seen.canvas).toEqual([2312, 1582])
+    expect(renderer.getCanvasTarget()).toBe(liveTarget)
+    expect([live.width, live.height]).toEqual([1156, 791])
+    expect(renderer.getDrawingBufferSize(new Vector2()).toArray()).toEqual([1156, 791])
+  })
+
+  test('puts the live canvas target back when the render throws', () => {
+    const live: FakeCanvas = { width: 800, height: 600, style: {} }
+    const renderer = fakeRenderer(live, 1)
+    const liveTarget = renderer.getCanvasTarget()
+    expect(() =>
+      atCaptureSize(renderer, 1600, 1200, () => {
+        throw new Error('pipeline failed')
+      }),
+    ).toThrow('pipeline failed')
+    expect(renderer.getCanvasTarget()).toBe(liveTarget)
+    expect([live.width, live.height]).toEqual([800, 600])
+  })
+
+  test('a capture at the canvas size renders through the live target', () => {
+    const live: FakeCanvas = { width: 800, height: 600, style: {} }
+    const renderer = fakeRenderer(live, 1)
+    const liveTarget = renderer.getCanvasTarget()
+    const during = atCaptureSize(renderer, 800, 600, () => renderer.getCanvasTarget())
+    expect(during).toBe(liveTarget)
+  })
+})
+
+/** R3F's `advance` with `frameloop="never"`: the delta is the timestamp less the clock's elapsed time. */
+function fakeLoop(startSeconds: number) {
+  const clock = { elapsedTime: startSeconds, oldTime: startSeconds }
+  const deltas: number[] = []
+  const advance = (timestamp: number) => {
+    deltas.push(timestamp - clock.elapsedTime)
+    clock.oldTime = clock.elapsedTime
+    clock.elapsedTime = timestamp
+  }
+  return { clock, deltas, advance }
+}
+
+describe('frames a capture runs by hand', () => {
+  test('never hand the next real frame a delta it did not earn', async () => {
+    // the viewer's frame limiter drives R3F's clock in seconds since it
+    // mounted; performance.now() is milliseconds since the page loaded
+    const loop = fakeLoop(330.62)
+    await pumpFrames(loop.advance, loop.clock, 2)
+    // the frame limiter's next frame, one 50 fps interval on
+    loop.advance(330.64)
+    expect(loop.deltas).toHaveLength(3)
+    expect(loop.deltas[0]).toBeCloseTo(0.001, 9)
+    expect(loop.deltas[1]).toBeCloseTo(0.001, 9)
+    expect(loop.deltas[2]).toBeCloseTo(0.02, 9)
+    expect(loop.clock.elapsedTime).toBe(330.64)
+  })
+
+  test('put the clock back when a frame throws', async () => {
+    const loop = fakeLoop(12)
+    const failing = () => {
+      throw new Error('a system failed')
+    }
+    await expect(pumpFrames(failing, loop.clock, 1)).rejects.toThrow('a system failed')
+    expect(loop.clock.elapsedTime).toBe(12)
+  })
+})
+
+describe('a sheet capture session', () => {
+  test('shows the finished house whatever view the user was in, then puts the view back', () => {
+    const viewer = useViewer.getState()
+    viewer.setWallMode('down')
+    viewer.setLevelMode('exploded')
+    viewer.setShading('solid')
+    viewer.setTextures(false)
+    viewer.setColorPreset('white')
+    const view = () => {
+      const { wallMode, levelMode, shading, textures, colorPreset } = useViewer.getState()
+      return { wallMode, levelMode, shading, textures, colorPreset }
+    }
+    // the shading stays the user's: the capture brings its own AO
+
+    const restore = presentFinished()
+    expect(view()).toEqual({
+      wallMode: 'up',
+      levelMode: 'stacked',
+      shading: 'solid',
+      textures: true,
+      colorPreset: 'clay',
+    })
+
+    restore()
+    expect(view()).toEqual({
+      wallMode: 'down',
+      levelMode: 'exploded',
+      shading: 'solid',
+      textures: false,
+      colorPreset: 'white',
+    })
+  })
+
+  test('leaves a view already finished untouched', () => {
+    const viewer = useViewer.getState()
+    viewer.setWallMode('up')
+    viewer.setLevelMode('stacked')
+    viewer.setTextures(true)
+    viewer.setColorPreset('clay')
+    let writes = 0
+    const unsubscribe = useViewer.subscribe(() => {
+      writes++
+    })
+    presentFinished()()
+    unsubscribe()
+    expect(writes).toBe(0)
+  })
+})
+
+describe('a print-size picture past one render pass', () => {
+  test('fits one pass: one tile, the whole picture', () => {
+    expect(tileGrid(3209, 2588, 4096)).toEqual([
+      { x: 0, y: 0, w: 3209, h: 2588, inner: { x: 0, y: 0, w: 3209, h: 2588 } },
+    ])
+  })
+
+  test('splits into equal tiles that cover every pixel once, each rendering past its seams', () => {
+    // a 200 ppi elevation on Arch D: 22.1 in across
+    const width = 4423
+    const height = 3567
+    const tiles = tileGrid(width, height, 4096)
+    expect(tiles).toHaveLength(2)
+    let covered = 0
+    for (const tile of tiles) {
+      expect(tile.w).toBeLessThanOrEqual(4096)
+      expect(tile.h).toBeLessThanOrEqual(4096)
+      // the rendered rect holds the contributed one, on the picture
+      expect(tile.x).toBeLessThanOrEqual(tile.inner.x)
+      expect(tile.x + tile.w).toBeGreaterThanOrEqual(tile.inner.x + tile.inner.w)
+      expect(tile.x).toBeGreaterThanOrEqual(0)
+      expect(tile.x + tile.w).toBeLessThanOrEqual(width)
+      covered += tile.inner.w * tile.inner.h
+    }
+    expect(covered).toBe(width * height)
+    const [left, right] = tiles as [(typeof tiles)[number], (typeof tiles)[number]]
+    expect(left.inner.x + left.inner.w).toBe(right.inner.x)
+    // the seam: each side renders the other's first pixels too
+    expect(left.x + left.w - (left.inner.x + left.inner.w)).toBeGreaterThan(0)
+    expect(right.inner.x - right.x).toBeGreaterThan(0)
+  })
+})
+
+describe('an interior view of a floor', () => {
+  /** A two-storey house as the editor holds it: the scene graph, and each node's object. */
+  function house() {
+    const ground = LevelNode.parse({ id: 'level_ground', parentId: 'building_h', level: 0 })
+    const upper = LevelNode.parse({ id: 'level_upper', parentId: 'building_h', level: 1 })
+    const building = BuildingNode.parse({ id: 'building_h', children: [ground.id, upper.id] })
+    const wall = WallNode.parse({
+      id: 'wall_ground',
+      parentId: ground.id,
+      start: [0, 0],
+      end: [6, 0],
+    })
+    const ceiling = CeilingNode.parse({
+      id: 'ceiling_ground',
+      parentId: ground.id,
+      polygon: [
+        [0, 0],
+        [6, 0],
+        [6, 4],
+        [0, 4],
+      ],
+    })
+    ground.children = [wall.id, ceiling.id]
+    const nodes = Object.fromEntries(
+      [building, ground, upper, wall, ceiling].map((node) => [node.id, node]),
+    ) as Record<string, AnyNode>
+    useScene.setState({ nodes } as never)
+    const objects = Object.fromEntries(
+      [ground, upper, ceiling].map((node) => [node.id, new Group()]),
+    ) as Record<string, Group>
+    const wallMesh = new Mesh()
+    wallMesh.layers.set(SCENE_LAYER)
+    objects.level_ground!.add(wallMesh, objects.ceiling_ground!)
+    for (const [id, object] of Object.entries({ ...objects, wall_ground: wallMesh }))
+      sceneRegistry.nodes.set(id, object)
+    return { objects, wallMesh }
+  }
+
+  afterEach(() => {
+    for (const id of ['level_ground', 'level_upper', 'ceiling_ground', 'wall_ground'])
+      sceneRegistry.nodes.delete(id)
+  })
+
+  test('leaves the rest of the house out and cuts the floor, for the one render', () => {
+    const { objects, wallMesh } = house()
+    hideFromScene(wallMesh, 'isolated')
+    const restorers: (() => void)[] = []
+    interiorCutaway('level_ground', (restore) => restorers.push(restore))
+
+    expect(objects.level_upper!.visible).toBe(false)
+    expect(objects.ceiling_ground!.visible).toBe(false)
+    const [cut] = objects.level_ground!.children as ClippingGroup[]
+    expect(objects.level_ground!.children).toHaveLength(1)
+    expect(cut).toBeInstanceOf(ClippingGroup)
+    expect(cut!.clipShadows).toBe(true)
+    // Walls stand below the plane: y = 0.65 × a 2.5 m storey.
+    const [plane] = cut!.clippingPlanes
+    expect(plane!.normal.toArray()).toEqual([0, -1, 0])
+    expect(plane!.constant).toBeCloseTo(1.625, 6)
+    expect(cut!.children).toContain(wallMesh)
+    // The user isolated something else: the floor still shows whole.
+    expect(wallMesh.layers.test(new Layers())).toBe(true)
+
+    for (const restore of restorers.reverse()) restore()
+    expect(objects.level_upper!.visible).toBe(true)
+    expect(objects.ceiling_ground!.visible).toBe(true)
+    expect(objects.level_ground!.children).toEqual([wallMesh, objects.ceiling_ground!])
+    expect(wallMesh.layers.test(new Layers())).toBe(false)
+  })
+
+  test('refuses a floor the editor has not built', () => {
+    house()
+    sceneRegistry.nodes.delete('level_ground')
+    expect(() => interiorCutaway('level_ground', () => {})).toThrow('not built yet')
+  })
+})
+
+describe("a capture's projection", () => {
+  const user = { ortho: new OrthographicCamera(), perspective: new PerspectiveCamera() }
+  const view = { position: [8, 6, 8], target: [0, 1, 0] } as never
+
+  test("a perspective view asked for stays perspective under the user's orthographic camera", () => {
+    // Else view_scene's planned camera, a look into a floor from 55° or a photo's, would give
+    // way to the user's own orthographic view while the result reports the planned one.
+    expect(capturesOrthographically({ perspective: view }, user.ortho)).toBe(false)
+    expect(capturesOrthographically({ ortho: view }, user.perspective)).toBe(true)
+  })
+
+  test("with no view of its own, a capture takes the user's projection", () => {
+    expect(capturesOrthographically({}, user.ortho)).toBe(true)
+    expect(capturesOrthographically({}, user.perspective)).toBe(false)
+    expect(capturesOrthographically({ snapLevels: true }, user.ortho)).toBe(false)
+  })
+})