@pascal-app/core 1.0.7 → 1.1.1

package/dist/store/actions/node-actions.js

@@ -1,5 +1,7 @@
 import { planWallDeletion } from '../../commands/structure/plan-wall-deletion.js';
+import { getWallEffectiveHeightForNodes } from '../../hooks/spatial-grid/spatial-grid-manager.js';
 import { withoutFloorStepOverrideKeys } from '../../lib/floor-step-finish.js';
+import { wouldCreateHierarchyCycle } from '../../lib/hierarchy.js';
 import { isSpaceDetectionPaused } from '../../lib/space-detection.js';
 import { deletedSurfaceSupportPatch } from '../../lib/surface-support-references.js';
 import { nodeRegistry } from '../../registry/registry.js';
@@ -7,7 +9,7 @@ import { validateNodeRelations } from '../../registry/validate-relations.js';
 import { AnyNode as AnyNodeSchema, createDefaultGuttersForSegment, createDefaultRidgeVentsForSegment, DownspoutNode as DownspoutNodeSchema, defaultDownspoutMetadata, generateId, getDefaultGutterSide, isAutoGutterEnabled, isAutoRidgeVentEnabled, isDefaultDownspoutNode, isDefaultGutterNode, isDefaultRidgeVentNode, parseNode, planAutomaticDownspouts, resolveAutomaticDownspoutLength, } from '../../schema/index.js';
 import { Provenance } from '../../schema/provenance.js';
 import { constrainWallCurveOffsetToAvoidIntersections } from '../../systems/wall/wall-curve.js';
-import { areWallStylesCompatible, areWallsCollinearAcrossPoint, buildMergedWallAttachmentUpdates, getWallEndpointAtPoint, mergeWallFaceRegions, planMergedZoneReferences, resolveMergedWallEndpoints, } from '../../systems/wall/wall-merge.js';
+import { areWallStylesCompatible, areWallsCollinearAcrossPoint, buildMergedWallAttachmentUpdates, getWallEndpointAtPoint, mergedWallTop, mergeWallFaceRegions, planMergedZoneReferences, resolveMergedWallEndpoints, } from '../../systems/wall/wall-merge.js';
 import { areSemanticValuesEqual } from '../../utils/semantic-equal.js';
 import { convertDerivedPlateHoleWrites, DERIVED_WRITER_TOKEN, derivedDeletionIntent, derivedDetachPatch, filterDerivedNodeWrites, isDerivedNode, } from '../derived-node-guard.js';
 import { activeSceneCommitNodeIds, addActiveSceneCommitNodeIds, noteDerivedNodeWrites, runWithSceneCommitNodeIds, } from '../history-control.js';
@@ -853,10 +855,12 @@ function buildWallMergePlans(nodes, idsToDelete) {
                 continue;
             }
             const { start, end } = resolveMergedWallEndpoints(primary, secondary, junction);
-            // A heal that would repaint a room or overflow a side's regions leaves the walls split.
+            // A heal that would repaint a room, overflow a side's regions or kink a slope leaves the
+            // walls split.
+            const mergedTop = mergedWallTop(primary, secondary, junction, (wall, t) => getWallEffectiveHeightForNodes(wall, nodes, t));
             const mergedFaceRegions = mergeWallFaceRegions([primary, secondary], start, end);
             const zoneUpdates = planMergedZoneReferences(nodes, primary, secondary, start, end);
-            if (!(mergedFaceRegions && zoneUpdates))
+            if (!(mergedTop && mergedFaceRegions && zoneUpdates))
                 continue;
             const mergedChildren = Array.from(new Set([...(primary.children ?? []), ...(secondary.children ?? [])]));
             const attachmentUpdates = buildMergedWallAttachmentUpdates(primary, secondary, primary.id, start, end, nodes);
@@ -866,6 +870,7 @@ function buildWallMergePlans(nodes, idsToDelete) {
                 mergedStart: start,
                 mergedEnd: end,
                 mergedChildren,
+                mergedTop,
                 mergedFaceRegions: mergedFaceRegions.length > 0 ? mergedFaceRegions : undefined,
                 attachmentUpdates,
                 zoneUpdates,
@@ -893,6 +898,9 @@ const createNodesActionImpl = (set, get, ops, options) => {
         for (const { node, parentId, collectionIds } of ops) {
             const effectiveParentId = parentId ?? node.parentId ?? null;
             const newNode = joinCollections(nextCollections, parseCreatedNode(node, effectiveParentId), collectionIds);
+            if (wouldCreateHierarchyCycle(newNode.id, effectiveParentId, nextNodes)) {
+                throw new Error(`invalid hierarchy: placing "${newNode.id}" under "${effectiveParentId}" would create a cycle`);
+            }
             nextNodes[newNode.id] = newNode;
             // 2. Update the Parent's children list. We append to ANY container
             // parent (kind has `children` in its schema) — if the field is
@@ -1024,6 +1032,10 @@ const applyNodeChangesActionImpl = (set, get, changes, options) => {
             const updatedNode = parseUpdatedNode(currentNode, data);
             addLeanToHostRoofId(updatedNode, nextNodes, roofsToRefresh);
             if (data.parentId !== undefined && data.parentId !== currentNode.parentId) {
+                const newParentId = data.parentId;
+                if (wouldCreateHierarchyCycle(id, newParentId, nextNodes)) {
+                    throw new Error(`invalid hierarchy: placing "${id}" under "${newParentId}" would create a cycle`);
+                }
                 const oldParentId = currentNode.parentId;
                 if (oldParentId && nextNodes[oldParentId]) {
                     const oldParent = nextNodes[oldParentId];
@@ -1033,7 +1045,6 @@ const applyNodeChangesActionImpl = (set, get, changes, options) => {
                     };
                     parentsToMarkDirty.add(oldParent.id);
                 }
-                const newParentId = data.parentId;
                 if (newParentId && nextNodes[newParentId]) {
                     const newParent = nextNodes[newParentId];
                     nextNodes[newParent.id] = {
@@ -1059,6 +1070,9 @@ const applyNodeChangesActionImpl = (set, get, changes, options) => {
         for (const { node, parentId, collectionIds } of createOps) {
             const effectiveParentId = parentId ?? node.parentId ?? null;
             const newNode = joinCollections(nextCollections, parseCreatedNode(node, effectiveParentId), collectionIds);
+            if (wouldCreateHierarchyCycle(newNode.id, effectiveParentId, nextNodes)) {
+                throw new Error(`invalid hierarchy: placing "${newNode.id}" under "${effectiveParentId}" would create a cycle`);
+            }
             nextNodes[newNode.id] = newNode;
             nodesToMarkDirty.add(newNode.id);
             if (newNode.type === 'roof-segment' && effectiveParentId) {
@@ -1187,6 +1201,10 @@ const updateNodesActionImpl = (set, get, updates, options, deferDirty = true) =>
             addLeanToHostRoofId(updatedNode, nextNodes, roofsToRefresh);
             // Handle Reparenting Logic
             if (data.parentId !== undefined && data.parentId !== currentNode.parentId) {
+                const newParentId = data.parentId;
+                if (wouldCreateHierarchyCycle(id, newParentId, nextNodes)) {
+                    throw new Error(`invalid hierarchy: placing "${id}" under "${newParentId}" would create a cycle`);
+                }
                 // 1. Remove from old parent
                 const oldParentId = currentNode.parentId;
                 if (oldParentId && nextNodes[oldParentId]) {
@@ -1206,7 +1224,6 @@ const updateNodesActionImpl = (set, get, updates, options, deferDirty = true) =>
                 // and a spread of `undefined` here throws and aborts the entire
                 // `set` callback. Initialising to `[]` matches what the schema's
                 // default would have produced.
-                const newParentId = data.parentId;
                 if (newParentId && nextNodes[newParentId]) {
                     const newParent = nextNodes[newParentId];
                     const newChildren = Array.isArray(newParent.children)
@@ -1423,6 +1440,7 @@ export function planNodeDeletion(scene, ids, { mintDefaults = true, options, wal
         const { faceRegions: _regions, ...keptWall } = primaryWall;
         nextNodes[plan.primaryWallId] = {
             ...keptWall,
+            ...plan.mergedTop,
             ...(plan.mergedFaceRegions ? { faceRegions: plan.mergedFaceRegions } : {}),
             start: plan.mergedStart,
             end: plan.mergedEnd,

package/dist/store/derived-node-guard.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"derived-node-guard.d.ts","sourceRoot":"","sources":["../../src/store/derived-node-guard.ts"],"names":[],"mappings":"AASA,OAAO,KAAK,EAAE,OAAO,EAAE,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAY,MAAM,WAAW,CAAA;AAKpF;;;;;;;;;;GAUG;AACH,eAAO,MAAM,oBAAoB,EAAE,OAAO,MAAwC,CAAA;AAElF,MAAM,MAAM,mBAAmB,GAAG;IAChC,uEAAuE;IACvE,aAAa,CAAC,EAAE,OAAO,oBAAoB,CAAA;CAC5C,CAAA;AAED,MAAM,MAAM,kBAAkB,GAAG,QAAQ,GAAG,WAAW,CAAA;AAEvD,MAAM,MAAM,qBAAqB,GAAG,QAAQ,GAAG,QAAQ,GAAG,QAAQ,CAAA;AAElE,8FAA8F;AAC9F,qBAAa,qBAAsB,SAAQ,KAAK;IAI5C,QAAQ,CAAC,SAAS,EAAE,qBAAqB;IACzC,QAAQ,CAAC,MAAM,EAAE,MAAM;IACvB,QAAQ,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE;IALpC,QAAQ,CAAC,IAAI,gCAA+B;IAE5C,YACW,SAAS,EAAE,qBAAqB,EAChC,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,SAAS,MAAM,EAAE,EAClC,OAAO,EAAE,MAAM,EAIhB;CACF;AAED;;;;GAIG;AACH,wBAAgB,aAAa,CAAC,IAAI,EAAE,OAAO,GAAG,IAAI,GAAG,SAAS,GAAG,IAAI,IAAI,kBAAkB,CAI1F;AAkBD;;;GAGG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,kBAAkB,GAAG,SAAS,MAAM,EAAE,CAEjF;AAED,0GAA0G;AAC1G,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,OAAO,aAK/C;AAkBD,6EAA6E;AAC7E,wBAAgB,sBAAsB,CACpC,OAAO,EAAE,kBAAkB,EAC3B,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EACtB,KAAK,CAAC,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,GACxC,MAAM,EAAE,CAyEV;AAED,MAAM,MAAM,kBAAkB,GAAG;IAC/B,MAAM,CAAC,EAAE,SAAS;QAAE,IAAI,EAAE,OAAO,CAAA;KAAE,EAAE,CAAA;IACrC,MAAM,CAAC,EAAE,SAAS;QAAE,EAAE,EAAE,SAAS,CAAC;QAAC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,CAAA;KAAE,EAAE,CAAA;CAC9D,CAAA;AAED,KAAK,qBAAqB,GAAG;IAC3B,MAAM,CAAC,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,OAAO,CAAC;QAAC,QAAQ,CAAC,EAAE,SAAS,CAAA;KAAE,CAAC,CAAA;IACvD,MAAM,CAAC,EAAE,KAAK,CAAC;QAAE,EAAE,EAAE,SAAS,CAAC;QAAC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,CAAA;KAAE,CAAC,CAAA;IACzD,MAAM,CAAC,EAAE,SAAS,EAAE,CAAA;CACrB,CAAA;AAyBD,wBAAgB,6BAA6B,CAAC,CAAC,SAAS,qBAAqB,EAC3E,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,OAAO,EAAE,CAAC,EACV,OAAO,CAAC,EAAE,mBAAmB,GAC5B,CAAC,GAAG,qBAAqB,CAiP3B;AAgHD,yFAAyF;AACzF,wBAAgB,uBAAuB,CAAC,CAAC,SAAS,kBAAkB,EAClE,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,OAAO,EAAE,CAAC,EACV,OAAO,CAAC,EAAE,mBAAmB,GAC5B,CAAC,CAgDH;AAED;;;;;;GAMG;AACH,wBAAgB,uBAAuB,CACrC,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,OAAO,EAAE,kBAAkB,EAC3B,OAAO,CAAC,EAAE,mBAAmB,GAC5B,IAAI,CA2CN;AAED,+EAA+E;AAC/E,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,kBAAkB,GAAG,OAAO,CAAC,OAAO,CAAC,CAM7E;AAQD;;;;;;;;;;GAUG;AACH,wBAAgB,qBAAqB,CACnC,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,GAAG,EAAE,SAAS,SAAS,EAAE,GACxB;IAAE,EAAE,EAAE,SAAS,CAAC;IAAC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,CAAA;CAAE,EAAE,CAmB7C"}
+{"version":3,"file":"derived-node-guard.d.ts","sourceRoot":"","sources":["../../src/store/derived-node-guard.ts"],"names":[],"mappings":"AAUA,OAAO,KAAK,EAAE,OAAO,EAAE,SAAS,EAAE,WAAW,EAAE,QAAQ,EAAY,MAAM,WAAW,CAAA;AAKpF;;;;;;;;;;GAUG;AACH,eAAO,MAAM,oBAAoB,EAAE,OAAO,MAAwC,CAAA;AAElF,MAAM,MAAM,mBAAmB,GAAG;IAChC,uEAAuE;IACvE,aAAa,CAAC,EAAE,OAAO,oBAAoB,CAAA;CAC5C,CAAA;AAED,MAAM,MAAM,kBAAkB,GAAG,QAAQ,GAAG,WAAW,CAAA;AAEvD,MAAM,MAAM,qBAAqB,GAAG,QAAQ,GAAG,QAAQ,GAAG,QAAQ,CAAA;AAElE,8FAA8F;AAC9F,qBAAa,qBAAsB,SAAQ,KAAK;IAI5C,QAAQ,CAAC,SAAS,EAAE,qBAAqB;IACzC,QAAQ,CAAC,MAAM,EAAE,MAAM;IACvB,QAAQ,CAAC,MAAM,EAAE,SAAS,MAAM,EAAE;IALpC,QAAQ,CAAC,IAAI,gCAA+B;IAE5C,YACW,SAAS,EAAE,qBAAqB,EAChC,MAAM,EAAE,MAAM,EACd,MAAM,EAAE,SAAS,MAAM,EAAE,EAClC,OAAO,EAAE,MAAM,EAIhB;CACF;AAED;;;;GAIG;AACH,wBAAgB,aAAa,CAAC,IAAI,EAAE,OAAO,GAAG,IAAI,GAAG,SAAS,GAAG,IAAI,IAAI,kBAAkB,CAI1F;AAkBD;;;GAGG;AACH,wBAAgB,qBAAqB,CAAC,IAAI,EAAE,kBAAkB,GAAG,SAAS,MAAM,EAAE,CAEjF;AAED,0GAA0G;AAC1G,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,OAAO,aAK/C;AAkBD,6EAA6E;AAC7E,wBAAgB,sBAAsB,CACpC,OAAO,EAAE,kBAAkB,EAC3B,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,EACtB,KAAK,CAAC,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,GACxC,MAAM,EAAE,CAyEV;AAED,MAAM,MAAM,kBAAkB,GAAG;IAC/B,MAAM,CAAC,EAAE,SAAS;QAAE,IAAI,EAAE,OAAO,CAAA;KAAE,EAAE,CAAA;IACrC,MAAM,CAAC,EAAE,SAAS;QAAE,EAAE,EAAE,SAAS,CAAC;QAAC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,CAAA;KAAE,EAAE,CAAA;CAC9D,CAAA;AAED,KAAK,qBAAqB,GAAG;IAC3B,MAAM,CAAC,EAAE,KAAK,CAAC;QAAE,IAAI,EAAE,OAAO,CAAC;QAAC,QAAQ,CAAC,EAAE,SAAS,CAAA;KAAE,CAAC,CAAA;IACvD,MAAM,CAAC,EAAE,KAAK,CAAC;QAAE,EAAE,EAAE,SAAS,CAAC;QAAC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,CAAA;KAAE,CAAC,CAAA;IACzD,MAAM,CAAC,EAAE,SAAS,EAAE,CAAA;CACrB,CAAA;AAyBD,wBAAgB,6BAA6B,CAAC,CAAC,SAAS,qBAAqB,EAC3E,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,OAAO,EAAE,CAAC,EACV,OAAO,CAAC,EAAE,mBAAmB,GAC5B,CAAC,GAAG,qBAAqB,CAiP3B;AAgHD,yFAAyF;AACzF,wBAAgB,uBAAuB,CAAC,CAAC,SAAS,kBAAkB,EAClE,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,OAAO,EAAE,CAAC,EACV,OAAO,CAAC,EAAE,mBAAmB,GAC5B,CAAC,CAgDH;AAED;;;;;;GAMG;AACH,wBAAgB,uBAAuB,CACrC,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,OAAO,EAAE,kBAAkB,EAC3B,OAAO,CAAC,EAAE,mBAAmB,GAC5B,IAAI,CA2CN;AAED,+EAA+E;AAC/E,wBAAgB,kBAAkB,CAAC,IAAI,EAAE,kBAAkB,GAAG,OAAO,CAAC,OAAO,CAAC,CAM7E;AAQD;;;;;;;;;;GAUG;AACH,wBAAgB,qBAAqB,CACnC,KAAK,EAAE,QAAQ,CAAC,MAAM,CAAC,MAAM,EAAE,OAAO,CAAC,CAAC,EACxC,GAAG,EAAE,SAAS,SAAS,EAAE,GACxB;IAAE,EAAE,EAAE,SAAS,CAAC;IAAC,IAAI,EAAE,OAAO,CAAC,OAAO,CAAC,CAAA;CAAE,EAAE,CAmB7C"}

package/dist/store/derived-node-guard.js

@@ -1,3 +1,4 @@
+import { isDevelopmentOutsideTests } from '../lib/build-mode.js';
 import { floorPlateAtGroundContact, floorPlateHoldsUnderside, supportDerivedFloorHeight, } from '../lib/floor-foundation-datum.js';
 import { expandFloorIntentChanges, floorIntentConflicts } from '../lib/floor-intent-changes.js';
 import { ownFloorIntentChanges } from '../lib/own-floor-intent.js';
@@ -368,7 +369,7 @@ export function convertDerivedPlateHoleWrites(nodes, changes, options) {
 }
 const warnedFields = new Set();
 function warnFilteredFields(nodeId, fields) {
-    if (process.env.NODE_ENV === 'production' || process.env.NODE_ENV === 'test')
+    if (!isDevelopmentOutsideTests())
         return;
     const fresh = fields.filter((field) => !warnedFields.has(`${nodeId}:${field}`));
     if (!fresh.length)