@ottochain/sdk 2.3.0 → 2.5.0

package/dist/esm/apps/governance/state-machines/dao-reputation.js

@@ -1,184 +1,169 @@
-import { defineFiberApp } from "../../../schema/fiber-app.js";
+import { defineFiberApp } from '../../../schema/fiber-app.js';
+import { actorIsSigner, signerInSet } from '../../../schema/guards.js';
 /**
  * Reputation-based governance. Minimum reputation required for participation.
  */
 export const daoReputationDef = defineFiberApp({
     metadata: {
-        name: "DAOReputation",
-        app: "governance",
-        type: "daoReputation",
-        version: "1.0.0",
-        description: "Reputation-based governance. Minimum reputation required for participation.",
-        category: "governance/dao",
+        name: 'DAOReputation',
+        app: 'governance',
+        type: 'daoReputation',
+        version: '1.0.0',
+        description: 'Reputation-based governance. Minimum reputation required for participation.',
+        category: 'governance/dao',
         crossReferences: {
-            Identity: "member verification",
-            Reputation: "threshold checks",
-            Contract: "action execution",
+            Identity: 'member verification',
+            Reputation: 'threshold checks',
+            Contract: 'action execution',
         },
     },
     createSchema: {
-        required: [
-            "memberThreshold",
-            "voteThreshold",
-            "proposeThreshold",
-            "quorum",
-            "votingPeriodMs",
-        ],
+        required: ['memberThreshold', 'voteThreshold', 'proposeThreshold', 'quorum', 'votingPeriodMs'],
         properties: {
             memberThreshold: {
-                type: "number",
-                description: "Min reputation to join as a member",
+                type: 'number',
+                description: 'Min reputation to join as a member',
             },
-            voteThreshold: { type: "number", description: "Min reputation to vote" },
+            voteThreshold: { type: 'number', description: 'Min reputation to vote' },
             proposeThreshold: {
-                type: "number",
-                description: "Min reputation to submit a proposal",
+                type: 'number',
+                description: 'Min reputation to submit a proposal',
             },
             quorum: {
-                type: "number",
-                description: "Min total votes (count) to execute",
+                type: 'number',
+                description: 'Min total votes (count) to execute',
             },
             votingPeriodMs: {
-                type: "number",
-                description: "Voting window in milliseconds",
+                type: 'number',
+                description: 'Voting window in milliseconds',
             },
         },
     },
     stateSchema: {
         properties: {
-            members: { type: "array", computed: true },
-            memberJoinedAt: { type: "object", computed: true },
-            memberThreshold: { type: "number" },
-            voteThreshold: { type: "number" },
-            proposeThreshold: { type: "number" },
-            quorum: { type: "number" },
-            votingPeriodMs: { type: "number" },
-            proposal: { type: "object" },
-            votes: { type: "object", computed: true },
-            history: { type: "array", computed: true },
+            members: { type: 'array', computed: true },
+            memberJoinedAt: { type: 'object', computed: true },
+            memberThreshold: { type: 'number' },
+            voteThreshold: { type: 'number' },
+            proposeThreshold: { type: 'number' },
+            quorum: { type: 'number' },
+            votingPeriodMs: { type: 'number' },
+            proposal: { type: 'object' },
+            votes: { type: 'object', computed: true },
+            history: { type: 'array', computed: true },
         },
     },
     eventSchemas: {
         propose: {
-            description: "Submit a proposal (requires >= proposeThreshold reputation)",
-            required: [
-                "proposalId",
-                "title",
-                "description",
-                "actionType",
-                "payload",
-                "agentReputation",
-            ],
+            description: 'Submit a proposal (requires >= proposeThreshold reputation)',
+            required: ['proposalId', 'title', 'description', 'actionType', 'payload', 'agentReputation'],
             properties: {
-                agent: { type: "address" },
-                agentReputation: { type: "number" },
-                proposalId: { type: "string" },
-                title: { type: "string" },
-                description: { type: "string" },
-                actionType: { type: "string" },
-                payload: { type: "object" },
+                agent: { type: 'address' },
+                agentReputation: { type: 'number' },
+                proposalId: { type: 'string' },
+                title: { type: 'string' },
+                description: { type: 'string' },
+                actionType: { type: 'string' },
+                payload: { type: 'object' },
             },
         },
         vote: {
-            description: "Cast a vote (requires >= voteThreshold, no double-vote, within window)",
-            required: ["vote", "agentReputation"],
+            description: 'Cast a vote (requires >= voteThreshold, no double-vote, within window)',
+            required: ['vote', 'agentReputation'],
             properties: {
-                agent: { type: "address" },
-                agentReputation: { type: "number" },
-                vote: { type: "string", description: '"for" | "against" | "abstain"' },
+                agent: { type: 'address' },
+                agentReputation: { type: 'number' },
+                vote: { type: 'string', description: '"for" | "against" | "abstain"' },
             },
         },
         execute: {
-            description: "Execute a passing proposal after voting ends",
+            description: 'Execute a passing proposal after voting ends',
             properties: {},
         },
         reject: {
-            description: "Formally reject a failed proposal",
+            description: 'Formally reject a failed proposal',
             properties: {},
         },
         join: {
-            description: "Join the DAO (requires >= memberThreshold reputation)",
-            required: ["agentReputation"],
+            description: 'Join the DAO (requires >= memberThreshold reputation)',
+            required: ['agentReputation'],
             properties: {
-                agent: { type: "address" },
-                agentReputation: { type: "number" },
+                agent: { type: 'address' },
+                agentReputation: { type: 'number' },
             },
         },
         leave: {
-            description: "Leave the DAO voluntarily",
+            description: 'Leave the DAO voluntarily',
             properties: {
-                agent: { type: "address" },
+                agent: { type: 'address' },
             },
         },
         propose_threshold_change: {
-            description: "Propose changing reputation thresholds",
-            required: ["proposalId", "agentReputation"],
+            description: 'Propose changing reputation thresholds',
+            required: ['proposalId', 'agentReputation'],
             properties: {
-                agent: { type: "address" },
-                agentReputation: { type: "number" },
-                proposalId: { type: "string" },
-                memberThreshold: { type: "number" },
-                voteThreshold: { type: "number" },
-                proposeThreshold: { type: "number" },
+                agent: { type: 'address' },
+                agentReputation: { type: 'number' },
+                proposalId: { type: 'string' },
+                memberThreshold: { type: 'number' },
+                voteThreshold: { type: 'number' },
+                proposeThreshold: { type: 'number' },
             },
         },
     },
     states: {
         ACTIVE: {
-            id: "ACTIVE",
+            id: 'ACTIVE',
             isFinal: false,
             metadata: {
-                label: "Active",
-                description: "DAO is idle and ready to accept a proposal",
-                category: "initial",
+                label: 'Active',
+                description: 'DAO is idle and ready to accept a proposal',
+                category: 'initial',
             },
         },
         VOTING: {
-            id: "VOTING",
+            id: 'VOTING',
             isFinal: false,
             metadata: {
-                label: "Voting",
-                description: "Members vote with reputation-weighted power",
-                category: "pending",
+                label: 'Voting',
+                description: 'Members vote with reputation-weighted power',
+                category: 'pending',
             },
         },
         DISSOLVED: {
-            id: "DISSOLVED",
+            id: 'DISSOLVED',
             isFinal: true,
             metadata: {
-                label: "Dissolved",
-                description: "Reputation DAO dissolved (terminal)",
-                category: "terminal",
+                label: 'Dissolved',
+                description: 'Reputation DAO dissolved (terminal)',
+                category: 'terminal',
             },
         },
     },
-    initialState: "ACTIVE",
+    initialState: 'ACTIVE',
     transitions: [
         // ACTIVE → VOTING: propose (reputation check)
         {
-            from: "ACTIVE",
-            to: "VOTING",
-            eventName: "propose",
+            from: 'ACTIVE',
+            to: 'VOTING',
+            eventName: 'propose',
             guard: {
-                ">=": [
-                    { var: "event.agentReputation" },
-                    { var: "state.proposeThreshold" },
-                ],
+                '>=': [{ var: 'event.agentReputation' }, { var: 'state.proposeThreshold' }],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         proposal: {
-                            id: { var: "event.proposalId" },
-                            title: { var: "event.title" },
-                            description: { var: "event.description" },
-                            actionType: { var: "event.actionType" },
-                            payload: { var: "event.payload" },
-                            proposer: { var: "event.agent" },
-                            proposedAt: { var: "$timestamp" },
+                            id: { var: 'event.proposalId' },
+                            title: { var: 'event.title' },
+                            description: { var: 'event.description' },
+                            actionType: { var: 'event.actionType' },
+                            payload: { var: 'event.payload' },
+                            proposer: { var: 'event.agent' },
+                            proposedAt: { var: '$ordinal' },
                             deadline: {
-                                "+": [{ var: "$timestamp" }, { var: "state.votingPeriodMs" }],
+                                '+': [{ var: '$ordinal' }, { var: 'state.votingPeriodMs' }],
                             },
                         },
                         votes: { for: [], against: [], abstain: [] },
@@ -189,76 +174,54 @@ export const daoReputationDef = defineFiberApp({
         },
         // VOTING → VOTING: vote (reputation check, no double-vote, within window)
         {
-            from: "VOTING",
-            to: "VOTING",
-            eventName: "vote",
+            from: 'VOTING',
+            to: 'VOTING',
+            eventName: 'vote',
             guard: {
                 and: [
                     {
-                        ">=": [
-                            { var: "event.agentReputation" },
-                            { var: "state.voteThreshold" },
-                        ],
-                    },
-                    {
-                        "!": [{ in: [{ var: "event.agent" }, { var: "state.votes.for" }] }],
-                    },
-                    {
-                        "!": [
-                            { in: [{ var: "event.agent" }, { var: "state.votes.against" }] },
-                        ],
-                    },
-                    {
-                        "!": [
-                            { in: [{ var: "event.agent" }, { var: "state.votes.abstain" }] },
-                        ],
+                        '>=': [{ var: 'event.agentReputation' }, { var: 'state.voteThreshold' }],
                     },
-                    { "<=": [{ var: "$timestamp" }, { var: "state.proposal.deadline" }] },
+                    { '!': [signerInSet('state.votes.for')] },
+                    { '!': [signerInSet('state.votes.against')] },
+                    { '!': [signerInSet('state.votes.abstain')] },
+                    { '<=': [{ var: '$ordinal' }, { var: 'state.proposal.deadline' }] },
                 ],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         votes: {
                             if: [
-                                { "===": [{ var: "event.vote" }, "for"] },
+                                { '===': [{ var: 'event.vote' }, 'for'] },
                                 {
                                     merge: [
-                                        { var: "state.votes" },
+                                        { var: 'state.votes' },
                                         {
                                             for: {
-                                                cat: [
-                                                    { var: "state.votes.for" },
-                                                    [{ var: "event.agent" }],
-                                                ],
+                                                cat: [{ var: 'state.votes.for' }, [{ var: 'event.agent' }]],
                                             },
                                         },
                                     ],
                                 },
-                                { "===": [{ var: "event.vote" }, "against"] },
+                                { '===': [{ var: 'event.vote' }, 'against'] },
                                 {
                                     merge: [
-                                        { var: "state.votes" },
+                                        { var: 'state.votes' },
                                         {
                                             against: {
-                                                cat: [
-                                                    { var: "state.votes.against" },
-                                                    [{ var: "event.agent" }],
-                                                ],
+                                                cat: [{ var: 'state.votes.against' }, [{ var: 'event.agent' }]],
                                             },
                                         },
                                     ],
                                 },
                                 {
                                     merge: [
-                                        { var: "state.votes" },
+                                        { var: 'state.votes' },
                                         {
                                             abstain: {
-                                                cat: [
-                                                    { var: "state.votes.abstain" },
-                                                    [{ var: "event.agent" }],
-                                                ],
+                                                cat: [{ var: 'state.votes.abstain' }, [{ var: 'event.agent' }]],
                                             },
                                         },
                                     ],
@@ -272,87 +235,81 @@ export const daoReputationDef = defineFiberApp({
         },
         // VOTING → ACTIVE: execute (voting ended, for > against, quorum met)
         {
-            from: "VOTING",
-            to: "ACTIVE",
-            eventName: "execute",
+            from: 'VOTING',
+            to: 'ACTIVE',
+            eventName: 'execute',
+            // A2 fix: votes.for/against/abstain are arrays of voter addresses; count with
+            // `length` (size is not a JLVM opcode).
             guard: {
                 and: [
-                    { ">": [{ var: "$timestamp" }, { var: "state.proposal.deadline" }] },
+                    { '>': [{ var: '$ordinal' }, { var: 'state.proposal.deadline' }] },
                     {
-                        ">": [
-                            { size: { var: "state.votes.for" } },
-                            { size: { var: "state.votes.against" } },
-                        ],
+                        '>': [{ length: [{ var: 'state.votes.for' }] }, { length: [{ var: 'state.votes.against' }] }],
                     },
                     {
-                        ">=": [
+                        '>=': [
                             {
-                                "+": [
-                                    { size: { var: "state.votes.for" } },
-                                    { size: { var: "state.votes.against" } },
-                                ],
+                                '+': [{ length: [{ var: 'state.votes.for' }] }, { length: [{ var: 'state.votes.against' }] }],
                             },
-                            { var: "state.quorum" },
+                            { var: 'state.quorum' },
                         ],
                     },
                 ],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         history: {
                             cat: [
-                                { var: "state.history" },
+                                { var: 'state.history' },
                                 [
                                     {
-                                        type: "executed",
-                                        proposal: { var: "state.proposal" },
-                                        votes: { var: "state.votes" },
-                                        at: { var: "$timestamp" },
+                                        type: 'executed',
+                                        proposal: { var: 'state.proposal' },
+                                        votes: { var: 'state.votes' },
+                                        at: { var: '$ordinal' },
                                     },
                                 ],
                             ],
                         },
                         proposal: null,
                         votes: null,
+                        // A3 fix: transition-level `emits` is dropped by the chain; emit from INSIDE the effect
+                        // under the reserved `_emit` key (extracted as an EmittedEvent, stripped from state).
+                        _emit: [
+                            {
+                                name: 'proposal_executed',
+                                data: { action: 'increase', agents: { var: 'state.votes.for' } },
+                                destination: 'Reputation',
+                            },
+                        ],
                     },
                 ],
             },
-            emits: [
-                {
-                    event: "proposal_executed",
-                    to: "Reputation",
-                    payload: { action: "increase", agents: { var: "state.votes.for" } },
-                },
-            ],
             dependencies: [],
         },
         // VOTING → ACTIVE: reject (voting ended, for <= against or quorum not met)
         {
-            from: "VOTING",
-            to: "ACTIVE",
-            eventName: "reject",
+            from: 'VOTING',
+            to: 'ACTIVE',
+            eventName: 'reject',
+            // A2 fix: count the array-shaped vote tallies with `length` (size is not a JLVM
+            // opcode).
             guard: {
                 and: [
-                    { ">": [{ var: "$timestamp" }, { var: "state.proposal.deadline" }] },
+                    { '>': [{ var: '$ordinal' }, { var: 'state.proposal.deadline' }] },
                     {
                         or: [
                             {
-                                "<=": [
-                                    { size: { var: "state.votes.for" } },
-                                    { size: { var: "state.votes.against" } },
-                                ],
+                                '<=': [{ length: [{ var: 'state.votes.for' }] }, { length: [{ var: 'state.votes.against' }] }],
                             },
                             {
-                                "<": [
+                                '<': [
                                     {
-                                        "+": [
-                                            { size: { var: "state.votes.for" } },
-                                            { size: { var: "state.votes.against" } },
-                                        ],
+                                        '+': [{ length: [{ var: 'state.votes.for' }] }, { length: [{ var: 'state.votes.against' }] }],
                                     },
-                                    { var: "state.quorum" },
+                                    { var: 'state.quorum' },
                                 ],
                             },
                         ],
@@ -361,17 +318,17 @@ export const daoReputationDef = defineFiberApp({
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         history: {
                             cat: [
-                                { var: "state.history" },
+                                { var: 'state.history' },
                                 [
                                     {
-                                        type: "rejected",
-                                        proposal: { var: "state.proposal" },
-                                        votes: { var: "state.votes" },
-                                        at: { var: "$timestamp" },
+                                        type: 'rejected',
+                                        proposal: { var: 'state.proposal' },
+                                        votes: { var: 'state.votes' },
+                                        at: { var: '$ordinal' },
                                     },
                                 ],
                             ],
@@ -385,33 +342,35 @@ export const daoReputationDef = defineFiberApp({
         },
         // ACTIVE → ACTIVE: join (reputation check, not already member)
         {
-            from: "ACTIVE",
-            to: "ACTIVE",
-            eventName: "join",
+            from: 'ACTIVE',
+            to: 'ACTIVE',
+            eventName: 'join',
+            // S1/A2: bind event.agent to a verified signer (actorIsSigner) so the member is appended to the
+            // array and keyed into memberJoinedAt under a CHAIN-VERIFIED address (set is the rc.5 map-write
+            // opcode), and dedup on that bound actor.
+            // TODO(#24): event.agentReputation is self-asserted. Replace the reputation clause with
+            // signerHasReputation(registryReputationPath(<registryDep>), "state.memberThreshold") once
+            // runtime-updatable dependencies (#24) let a std-app bind the identity-registry instance — the
+            // same gate as corp-board's removal-resolution. The registry foundation + read helper already
+            // exist (src/apps/identity/state-machines/identity-registry.ts, guards.signerHasReputation).
             guard: {
                 and: [
+                    actorIsSigner(),
                     {
-                        ">=": [
-                            { var: "event.agentReputation" },
-                            { var: "state.memberThreshold" },
-                        ],
+                        '>=': [{ var: 'event.agentReputation' }, { var: 'state.memberThreshold' }],
                     },
-                    { "!": [{ in: [{ var: "event.agent" }, { var: "state.members" }] }] },
+                    { '!': [{ in: [{ var: 'event.agent' }, { var: 'state.members' }] }] },
                 ],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         members: {
-                            cat: [{ var: "state.members" }, [{ var: "event.agent" }]],
+                            cat: [{ var: 'state.members' }, [{ var: 'event.agent' }]],
                         },
                         memberJoinedAt: {
-                            setKey: [
-                                { var: "state.memberJoinedAt" },
-                                { var: "event.agent" },
-                                { var: "$timestamp" },
-                            ],
+                            set: [{ var: 'state.memberJoinedAt' }, { var: 'event.agent' }, { var: '$ordinal' }],
                         },
                     },
                 ],
@@ -420,19 +379,16 @@ export const daoReputationDef = defineFiberApp({
         },
         // ACTIVE → ACTIVE: leave (member only)
         {
-            from: "ACTIVE",
-            to: "ACTIVE",
-            eventName: "leave",
-            guard: { in: [{ var: "event.agent" }, { var: "state.members" }] },
+            from: 'ACTIVE',
+            to: 'ACTIVE',
+            eventName: 'leave',
+            guard: signerInSet('state.members'),
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         members: {
-                            filter: [
-                                { var: "state.members" },
-                                { "!==": [{ var: "" }, { var: "event.agent" }] },
-                            ],
+                            filter: [{ var: 'state.members' }, { '!==': [{ var: '' }, { var: 'event.agent' }] }],
                         },
                     },
                 ],
@@ -441,32 +397,29 @@ export const daoReputationDef = defineFiberApp({
         },
         // ACTIVE → VOTING: propose_threshold_change
         {
-            from: "ACTIVE",
-            to: "VOTING",
-            eventName: "propose_threshold_change",
+            from: 'ACTIVE',
+            to: 'VOTING',
+            eventName: 'propose_threshold_change',
             guard: {
-                ">=": [
-                    { var: "event.agentReputation" },
-                    { var: "state.proposeThreshold" },
-                ],
+                '>=': [{ var: 'event.agentReputation' }, { var: 'state.proposeThreshold' }],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         proposal: {
-                            id: { var: "event.proposalId" },
-                            title: "Threshold Change",
-                            actionType: "threshold_change",
+                            id: { var: 'event.proposalId' },
+                            title: 'Threshold Change',
+                            actionType: 'threshold_change',
                             payload: {
-                                memberThreshold: { var: "event.memberThreshold" },
-                                voteThreshold: { var: "event.voteThreshold" },
-                                proposeThreshold: { var: "event.proposeThreshold" },
+                                memberThreshold: { var: 'event.memberThreshold' },
+                                voteThreshold: { var: 'event.voteThreshold' },
+                                proposeThreshold: { var: 'event.proposeThreshold' },
                             },
-                            proposer: { var: "event.agent" },
-                            proposedAt: { var: "$timestamp" },
+                            proposer: { var: 'event.agent' },
+                            proposedAt: { var: '$ordinal' },
                             deadline: {
-                                "+": [{ var: "$timestamp" }, { var: "state.votingPeriodMs" }],
+                                '+': [{ var: '$ordinal' }, { var: 'state.votingPeriodMs' }],
                             },
                         },
                         votes: { for: [], against: [], abstain: [] },