@ottochain/sdk 2.3.0 → 2.5.0

package/dist/esm/apps/governance/state-machines/dao-multisig.js

@@ -1,174 +1,173 @@
-import { defineFiberApp } from "../../../schema/fiber-app.js";
+import { defineFiberApp } from '../../../schema/fiber-app.js';
+import { actorInSet, signerIsParty } from '../../../schema/guards.js';
 /**
  * N-of-M multisig governance. Requires threshold signatures for actions.
  */
 export const daoMultisigDef = defineFiberApp({
     metadata: {
-        name: "MultisigDAO",
-        app: "governance",
-        type: "daoMultisig",
-        version: "1.0.0",
-        description: "N-of-M multisig governance. Requires threshold signatures for actions.",
-        category: "governance/dao",
+        name: 'MultisigDAO',
+        app: 'governance',
+        type: 'daoMultisig',
+        version: '1.0.0',
+        description: 'N-of-M multisig governance. Requires threshold signatures for actions.',
+        category: 'governance/dao',
         crossReferences: {
-            Identity: "signer verification",
-            Contract: "action execution targets",
-            Treasury: "fund management",
-            Escrow: "controlled release",
+            Identity: 'signer verification',
+            Contract: 'action execution targets',
+            Treasury: 'fund management',
+            Escrow: 'controlled release',
         },
     },
     createSchema: {
-        required: ["signers", "threshold", "proposalTTLMs"],
+        required: ['signers', 'threshold', 'proposalTTLMs'],
         properties: {
             signers: {
-                type: "array",
-                description: "Authorized signer addresses",
+                type: 'array',
+                description: 'Authorized signer addresses',
                 immutable: false,
             },
             threshold: {
-                type: "number",
-                description: "Number of signatures required to execute",
+                type: 'number',
+                description: 'Number of signatures required to execute',
             },
             proposalTTLMs: {
-                type: "number",
-                description: "Proposal expiry window in milliseconds",
+                type: 'number',
+                description: 'Proposal expiry window in milliseconds',
             },
         },
     },
     stateSchema: {
         properties: {
-            signers: { type: "array" },
-            threshold: { type: "number" },
-            proposalTTLMs: { type: "number" },
-            proposal: { type: "object" },
-            signatures: { type: "object", computed: true },
-            actions: { type: "array", computed: true },
-            cancelledProposals: { type: "array", computed: true },
-            status: { type: "string", computed: true },
+            signers: { type: 'array' },
+            threshold: { type: 'number' },
+            proposalTTLMs: { type: 'number' },
+            proposal: { type: 'object' },
+            signatures: { type: 'object', computed: true },
+            actions: { type: 'array', computed: true },
+            cancelledProposals: { type: 'array', computed: true },
+            status: { type: 'string', computed: true },
         },
     },
     eventSchemas: {
         propose: {
-            description: "Propose an action (signer only)",
-            required: ["proposalId", "actionType", "payload"],
+            description: 'Propose an action (signer only)',
+            required: ['proposalId', 'actionType', 'payload'],
             properties: {
-                agent: { type: "address" },
-                proposalId: { type: "string" },
-                actionType: { type: "string" },
-                payload: { type: "object" },
+                agent: { type: 'address' },
+                proposalId: { type: 'string' },
+                actionType: { type: 'string' },
+                payload: { type: 'object' },
             },
         },
         sign: {
-            description: "Sign the current proposal (signer only, no double-signing)",
+            description: 'Sign the current proposal (signer only, no double-signing)',
             properties: {
-                agent: { type: "address" },
+                agent: { type: 'address' },
             },
         },
         execute: {
-            description: "Execute once threshold signatures collected",
+            description: 'Execute once threshold signatures collected',
             properties: {
-                agent: { type: "address" },
+                agent: { type: 'address' },
             },
         },
         cancel: {
-            description: "Cancel proposal (expired or proposer)",
+            description: 'Cancel proposal (expired or proposer)',
             properties: {
-                agent: { type: "address" },
+                agent: { type: 'address' },
             },
         },
         propose_add_signer: {
-            description: "Propose adding a new signer (signer only)",
-            required: ["proposalId", "newSigner"],
+            description: 'Propose adding a new signer (signer only)',
+            required: ['proposalId', 'newSigner'],
             properties: {
-                agent: { type: "address" },
-                proposalId: { type: "string" },
-                newSigner: { type: "address" },
+                agent: { type: 'address' },
+                proposalId: { type: 'string' },
+                newSigner: { type: 'address' },
             },
         },
         propose_remove_signer: {
-            description: "Propose removing a signer (signer only, must keep > threshold signers)",
-            required: ["proposalId", "removeSigner"],
+            description: 'Propose removing a signer (signer only, must keep > threshold signers)',
+            required: ['proposalId', 'removeSigner'],
             properties: {
-                agent: { type: "address" },
-                proposalId: { type: "string" },
-                removeSigner: { type: "address" },
+                agent: { type: 'address' },
+                proposalId: { type: 'string' },
+                removeSigner: { type: 'address' },
             },
         },
         propose_change_threshold: {
-            description: "Propose changing the signature threshold",
-            required: ["proposalId", "newThreshold"],
+            description: 'Propose changing the signature threshold',
+            required: ['proposalId', 'newThreshold'],
             properties: {
-                agent: { type: "address" },
-                proposalId: { type: "string" },
-                newThreshold: { type: "number", minimum: 1 },
+                agent: { type: 'address' },
+                proposalId: { type: 'string' },
+                newThreshold: { type: 'number', minimum: 1 },
             },
         },
         apply_signer_change: {
-            description: "Apply approved signer-set or threshold change",
+            description: 'Apply approved signer-set or threshold change',
             properties: {
-                agent: { type: "address" },
+                agent: { type: 'address' },
             },
         },
         dissolve: {
-            description: "Dissolve the DAO (requires unanimous signer count)",
-            properties: {
-                signatureCount: { type: "number" },
-            },
+            description: 'Dissolve the DAO (requires every signer to sign this op — verified unanimity)',
+            properties: {},
         },
     },
     states: {
         ACTIVE: {
-            id: "ACTIVE",
+            id: 'ACTIVE',
             isFinal: false,
             metadata: {
-                label: "Active",
-                description: "Multisig is idle and ready to propose an action",
-                category: "initial",
+                label: 'Active',
+                description: 'Multisig is idle and ready to propose an action',
+                category: 'initial',
             },
         },
         PENDING: {
-            id: "PENDING",
+            id: 'PENDING',
             isFinal: false,
             metadata: {
-                label: "Pending",
-                description: "An action is awaiting the required signature threshold",
-                category: "pending",
+                label: 'Pending',
+                description: 'An action is awaiting the required signature threshold',
+                category: 'pending',
             },
         },
         DISSOLVED: {
-            id: "DISSOLVED",
+            id: 'DISSOLVED',
             isFinal: true,
             metadata: {
-                label: "Dissolved",
-                description: "Multisig DAO dissolved (terminal)",
-                category: "terminal",
+                label: 'Dissolved',
+                description: 'Multisig DAO dissolved (terminal)',
+                category: 'terminal',
             },
         },
     },
-    initialState: "ACTIVE",
+    initialState: 'ACTIVE',
     transitions: [
         // ACTIVE → PENDING: propose (signer only)
         {
-            from: "ACTIVE",
-            to: "PENDING",
-            eventName: "propose",
-            guard: { in: [{ var: "event.agent" }, { var: "state.signers" }] },
+            from: 'ACTIVE',
+            to: 'PENDING',
+            eventName: 'propose',
+            guard: actorInSet('state.signers'),
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         proposal: {
-                            id: { var: "event.proposalId" },
-                            actionType: { var: "event.actionType" },
-                            payload: { var: "event.payload" },
-                            proposer: { var: "event.agent" },
-                            proposedAt: { var: "$timestamp" },
+                            id: { var: 'event.proposalId' },
+                            actionType: { var: 'event.actionType' },
+                            payload: { var: 'event.payload' },
+                            proposer: { var: 'event.agent' },
+                            proposedAt: { var: '$ordinal' },
                             expiresAt: {
-                                "+": [{ var: "$timestamp" }, { var: "state.proposalTTLMs" }],
+                                '+': [{ var: '$ordinal' }, { var: 'state.proposalTTLMs' }],
                             },
                         },
                         signatures: {
-                            setKey: [{}, { var: "event.agent" }, { var: "$timestamp" }],
+                            set: [{}, { var: 'event.agent' }, { var: '$ordinal' }],
                         },
                     },
                 ],
@@ -177,35 +176,26 @@ export const daoMultisigDef = defineFiberApp({
         },
         // PENDING → PENDING: sign (signer, no double-sign, not yet at threshold)
         {
-            from: "PENDING",
-            to: "PENDING",
-            eventName: "sign",
+            from: 'PENDING',
+            to: 'PENDING',
+            eventName: 'sign',
             guard: {
                 and: [
-                    { in: [{ var: "event.agent" }, { var: "state.signers" }] },
+                    actorInSet('state.signers'),
                     {
-                        "!": [
-                            { getKey: [{ var: "state.signatures" }, { var: "event.agent" }] },
-                        ],
+                        '!': [{ has: [{ var: 'state.signatures' }, { var: 'event.agent' }] }],
                     },
                     {
-                        "<": [
-                            { size: { var: "state.signatures" } },
-                            { var: "state.threshold" },
-                        ],
+                        '<': [{ length: [{ keys: [{ var: 'state.signatures' }] }] }, { var: 'state.threshold' }],
                     },
                 ],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         signatures: {
-                            setKey: [
-                                { var: "state.signatures" },
-                                { var: "event.agent" },
-                                { var: "$timestamp" },
-                            ],
+                            set: [{ var: 'state.signatures' }, { var: 'event.agent' }, { var: '$ordinal' }],
                         },
                     },
                 ],
@@ -214,67 +204,67 @@ export const daoMultisigDef = defineFiberApp({
         },
         // PENDING → ACTIVE: execute (threshold met)
         {
-            from: "PENDING",
-            to: "ACTIVE",
-            eventName: "execute",
+            from: 'PENDING',
+            to: 'ACTIVE',
+            eventName: 'execute',
             guard: {
-                ">=": [
-                    { size: { var: "state.signatures" } },
-                    { var: "state.threshold" },
-                ],
+                '>=': [{ length: [{ keys: [{ var: 'state.signatures' }] }] }, { var: 'state.threshold' }],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         actions: {
                             cat: [
-                                { var: "state.actions" },
+                                { var: 'state.actions' },
                                 [
                                     {
-                                        id: { var: "state.proposal.id" },
-                                        type: { var: "state.proposal.actionType" },
-                                        payload: { var: "state.proposal.payload" },
-                                        signatures: { var: "state.signatures" },
-                                        executedAt: { var: "$timestamp" },
+                                        id: { var: 'state.proposal.id' },
+                                        type: { var: 'state.proposal.actionType' },
+                                        payload: { var: 'state.proposal.payload' },
+                                        signatures: { var: 'state.signatures' },
+                                        executedAt: { var: '$ordinal' },
                                     },
                                 ],
                             ],
                         },
                         proposal: null,
                         signatures: {},
+                        // A3 fix: transition-level `emits` is dropped by the chain; emit from INSIDE the effect
+                        // under the reserved `_emit` key (extracted as an EmittedEvent, stripped from state).
+                        _emit: [
+                            {
+                                name: 'multisig_executed',
+                                data: { proposalId: { var: 'state.proposal.id' } },
+                                destination: 'external',
+                            },
+                        ],
                     },
                 ],
             },
-            emits: [{ event: "multisig_executed", to: "external" }],
             dependencies: [],
         },
         // PENDING → ACTIVE: cancel (expired or proposer)
         {
-            from: "PENDING",
-            to: "ACTIVE",
-            eventName: "cancel",
+            from: 'PENDING',
+            to: 'ACTIVE',
+            eventName: 'cancel',
             guard: {
                 or: [
-                    { ">": [{ var: "$timestamp" }, { var: "state.proposal.expiresAt" }] },
-                    {
-                        "===": [{ var: "event.agent" }, { var: "state.proposal.proposer" }],
-                    },
+                    { '>': [{ var: '$ordinal' }, { var: 'state.proposal.expiresAt' }] },
+                    signerIsParty('state.proposal.proposer'),
                 ],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         cancelledProposals: {
                             cat: [
-                                { var: "state.cancelledProposals" },
+                                { var: 'state.cancelledProposals' },
                                 [
                                     {
-                                        merge: [
-                                            { var: "state.proposal" },
-                                            { cancelledAt: { var: "$timestamp" } },
-                                        ],
+                                        merge: [{ var: 'state.proposal' }, { cancelledAt: { var: '$ordinal' } }],
                                     },
                                 ],
                             ],
@@ -288,26 +278,26 @@ export const daoMultisigDef = defineFiberApp({
         },
         // ACTIVE → PENDING: propose_add_signer
         {
-            from: "ACTIVE",
-            to: "PENDING",
-            eventName: "propose_add_signer",
-            guard: { in: [{ var: "event.agent" }, { var: "state.signers" }] },
+            from: 'ACTIVE',
+            to: 'PENDING',
+            eventName: 'propose_add_signer',
+            guard: actorInSet('state.signers'),
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         proposal: {
-                            id: { var: "event.proposalId" },
-                            actionType: "add_signer",
-                            payload: { newSigner: { var: "event.newSigner" } },
-                            proposer: { var: "event.agent" },
-                            proposedAt: { var: "$timestamp" },
+                            id: { var: 'event.proposalId' },
+                            actionType: 'add_signer',
+                            payload: { newSigner: { var: 'event.newSigner' } },
+                            proposer: { var: 'event.agent' },
+                            proposedAt: { var: '$ordinal' },
                             expiresAt: {
-                                "+": [{ var: "$timestamp" }, { var: "state.proposalTTLMs" }],
+                                '+': [{ var: '$ordinal' }, { var: 'state.proposalTTLMs' }],
                             },
                         },
                         signatures: {
-                            setKey: [{}, { var: "event.agent" }, { var: "$timestamp" }],
+                            set: [{}, { var: 'event.agent' }, { var: '$ordinal' }],
                         },
                     },
                 ],
@@ -316,36 +306,33 @@ export const daoMultisigDef = defineFiberApp({
         },
         // ACTIVE → PENDING: propose_remove_signer (signers > threshold)
         {
-            from: "ACTIVE",
-            to: "PENDING",
-            eventName: "propose_remove_signer",
+            from: 'ACTIVE',
+            to: 'PENDING',
+            eventName: 'propose_remove_signer',
             guard: {
                 and: [
-                    { in: [{ var: "event.agent" }, { var: "state.signers" }] },
+                    actorInSet('state.signers'),
                     {
-                        ">": [
-                            { size: { var: "state.signers" } },
-                            { var: "state.threshold" },
-                        ],
+                        '>': [{ length: [{ var: 'state.signers' }] }, { var: 'state.threshold' }],
                     },
                 ],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         proposal: {
-                            id: { var: "event.proposalId" },
-                            actionType: "remove_signer",
-                            payload: { removeSigner: { var: "event.removeSigner" } },
-                            proposer: { var: "event.agent" },
-                            proposedAt: { var: "$timestamp" },
+                            id: { var: 'event.proposalId' },
+                            actionType: 'remove_signer',
+                            payload: { removeSigner: { var: 'event.removeSigner' } },
+                            proposer: { var: 'event.agent' },
+                            proposedAt: { var: '$ordinal' },
                             expiresAt: {
-                                "+": [{ var: "$timestamp" }, { var: "state.proposalTTLMs" }],
+                                '+': [{ var: '$ordinal' }, { var: 'state.proposalTTLMs' }],
                             },
                         },
                         signatures: {
-                            setKey: [{}, { var: "event.agent" }, { var: "$timestamp" }],
+                            set: [{}, { var: 'event.agent' }, { var: '$ordinal' }],
                         },
                     },
                 ],
@@ -354,37 +341,34 @@ export const daoMultisigDef = defineFiberApp({
         },
         // ACTIVE → PENDING: propose_change_threshold (1 <= new <= signers count)
         {
-            from: "ACTIVE",
-            to: "PENDING",
-            eventName: "propose_change_threshold",
+            from: 'ACTIVE',
+            to: 'PENDING',
+            eventName: 'propose_change_threshold',
             guard: {
                 and: [
-                    { in: [{ var: "event.agent" }, { var: "state.signers" }] },
-                    { ">=": [{ var: "event.newThreshold" }, 1] },
+                    actorInSet('state.signers'),
+                    { '>=': [{ var: 'event.newThreshold' }, 1] },
                     {
-                        "<=": [
-                            { var: "event.newThreshold" },
-                            { size: { var: "state.signers" } },
-                        ],
+                        '<=': [{ var: 'event.newThreshold' }, { length: [{ var: 'state.signers' }] }],
                     },
                 ],
             },
             effect: {
                 merge: [
-                    { var: "state" },
+                    { var: 'state' },
                     {
                         proposal: {
-                            id: { var: "event.proposalId" },
-                            actionType: "change_threshold",
-                            payload: { newThreshold: { var: "event.newThreshold" } },
-                            proposer: { var: "event.agent" },
-                            proposedAt: { var: "$timestamp" },
+                            id: { var: 'event.proposalId' },
+                            actionType: 'change_threshold',
+                            payload: { newThreshold: { var: 'event.newThreshold' } },
+                            proposer: { var: 'event.agent' },
+                            proposedAt: { var: '$ordinal' },
                             expiresAt: {
-                                "+": [{ var: "$timestamp" }, { var: "state.proposalTTLMs" }],
+                                '+': [{ var: '$ordinal' }, { var: 'state.proposalTTLMs' }],
                             },
                         },
                         signatures: {
-                            setKey: [{}, { var: "event.agent" }, { var: "$timestamp" }],
+                            set: [{}, { var: 'event.agent' }, { var: '$ordinal' }],
                         },
                     },
                 ],
@@ -393,56 +377,44 @@ export const daoMultisigDef = defineFiberApp({
         },
         // PENDING → ACTIVE: apply_signer_change (threshold met, signer-type proposal)
         {
-            from: "PENDING",
-            to: "ACTIVE",
-            eventName: "apply_signer_change",
+            from: 'PENDING',
+            to: 'ACTIVE',
+            eventName: 'apply_signer_change',
             guard: {
                 and: [
                     {
-                        ">=": [
-                            { size: { var: "state.signatures" } },
-                            { var: "state.threshold" },
-                        ],
+                        '>=': [{ length: [{ keys: [{ var: 'state.signatures' }] }] }, { var: 'state.threshold' }],
                     },
                     {
-                        in: [
-                            { var: "state.proposal.actionType" },
-                            ["add_signer", "remove_signer", "change_threshold"],
-                        ],
+                        in: [{ var: 'state.proposal.actionType' }, ['add_signer', 'remove_signer', 'change_threshold']],
                     },
                 ],
             },
             effect: {
                 if: [
-                    { "===": [{ var: "state.proposal.actionType" }, "add_signer"] },
+                    { '===': [{ var: 'state.proposal.actionType' }, 'add_signer'] },
                     {
                         merge: [
-                            { var: "state" },
+                            { var: 'state' },
                             {
                                 signers: {
-                                    cat: [
-                                        { var: "state.signers" },
-                                        [{ var: "state.proposal.payload.newSigner" }],
-                                    ],
+                                    cat: [{ var: 'state.signers' }, [{ var: 'state.proposal.payload.newSigner' }]],
                                 },
                                 proposal: null,
                                 signatures: {},
                             },
                         ],
                     },
-                    { "===": [{ var: "state.proposal.actionType" }, "remove_signer"] },
+                    { '===': [{ var: 'state.proposal.actionType' }, 'remove_signer'] },
                     {
                         merge: [
-                            { var: "state" },
+                            { var: 'state' },
                             {
                                 signers: {
                                     filter: [
-                                        { var: "state.signers" },
+                                        { var: 'state.signers' },
                                         {
-                                            "!==": [
-                                                { var: "" },
-                                                { var: "state.proposal.payload.removeSigner" },
-                                            ],
+                                            '!==': [{ var: '' }, { var: 'state.proposal.payload.removeSigner' }],
                                         },
                                     ],
                                 },
@@ -453,9 +425,9 @@ export const daoMultisigDef = defineFiberApp({
                     },
                     {
                         merge: [
-                            { var: "state" },
+                            { var: 'state' },
                             {
-                                threshold: { var: "state.proposal.payload.newThreshold" },
+                                threshold: { var: 'state.proposal.payload.newThreshold' },
                                 proposal: null,
                                 signatures: {},
                             },
@@ -467,20 +439,27 @@ export const daoMultisigDef = defineFiberApp({
         },
         // ACTIVE → DISSOLVED: dissolve (unanimous)
         {
-            from: "ACTIVE",
-            to: "DISSOLVED",
-            eventName: "dissolve",
+            from: 'ACTIVE',
+            to: 'DISSOLVED',
+            eventName: 'dissolve',
+            // S2 fix: dissolution must not trust an attacker-supplied count. Derive
+            // unanimity from the CHAIN-VERIFIED signers — every signer in state.signers
+            // must be among proofs[].address (with a non-empty belt). signers is an array.
             guard: {
-                "===": [
-                    { var: "event.signatureCount" },
-                    { size: { var: "state.signers" } },
+                and: [
+                    { '>': [{ length: [{ var: 'state.signers' }] }, 0] },
+                    {
+                        all: [
+                            { var: 'state.signers' },
+                            {
+                                in: [{ var: '' }, { map: [{ var: 'proofs' }, { var: 'address' }] }],
+                            },
+                        ],
+                    },
                 ],
             },
             effect: {
-                merge: [
-                    { var: "state" },
-                    { dissolvedAt: { var: "$timestamp" }, status: "DISSOLVED" },
-                ],
+                merge: [{ var: 'state' }, { dissolvedAt: { var: '$ordinal' }, status: 'DISSOLVED' }],
             },
             dependencies: [],
         },