@openui5/sap.ui.rta 1.97.1 → 1.100.0

package/src/sap/ui/rta/plugin/DragDrop.js

@@ -33,7 +33,7 @@ function(
 	 * @extends sap.ui.dt.plugin.ControlDragDrop
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/EasyAdd.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	 * @class The EasyAdd Plugin adds an Icon to an Overlay, which allows to trigger add operations directly
 	 * @extends sap.ui.rta.plugin.additionalElements.AdditionalElementsPlugin
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.48

package/src/sap/ui/rta/plugin/EasyRemove.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @class The EasyRemove Plugin adds an Icon to an Overlay, which allows to trigger remove operations directly
 	 * @extends sap.ui.rta.plugin.Remove
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.48

package/src/sap/ui/rta/plugin/LocalReset.js

@@ -35,7 +35,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.90

package/src/sap/ui/rta/plugin/Plugin.js

@@ -69,7 +69,7 @@ function(
 	 * @extends sap.ui.dt.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/RTAElementMover.js

@@ -35,7 +35,7 @@ function(
 	 * The RTAElementMover is responsible for the RTA specific adaptation of element movements.
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/Remove.js

@@ -29,7 +29,7 @@ sap.ui.define([
 	 * @class The Remove allows trigger remove operations on the overlay
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.34
@@ -114,12 +114,25 @@ sap.ui.define([
 	/**
 	 * Checks if Overlay control has a valid parent and if it is
 	 * not the last visible control in the aggregation
+	 * The removal of the last element in the aggregation can
+	 * be defined by the parameter 'removeLastElement' in the
+	 * designtime of the aggregation
 	 *
 	 * @param  {sap.ui.dt.ElementOverlay[]} aElementOverlays - overlays to be removed
 	 * @return {boolean} Returns true if the control can be removed
 	 * @private
 	 */
 	Remove.prototype._canBeRemovedFromAggregation = function(aElementOverlays) {
+		//Check if designtime allows removing last visible element
+		var fnCheckDesignTimeSettings = function (oOverlay) {
+			var oParentOverlay = oOverlay.getParentAggregationOverlay();
+			if (oParentOverlay) {
+				var oAction = this.getAction(oParentOverlay);
+				return !!(oAction && oAction.removeLastElement);
+			}
+			return false;
+		}.bind(this);
+
 		var oOverlay = aElementOverlays[0];
 		var oElement = oOverlay.getElement();
 		var oParent = oElement.getParent();
@@ -130,22 +143,22 @@ sap.ui.define([
 		if (!Array.isArray(aElements)) {
 			return true;
 		}
-		if (aElements.length === 1) {
-			return false;
-		}
-
-		// Fallback to 1 if no overlay is selected
+		// check if selected Overlays are the last visible elements in aggregation
 		var iNumberOfSelectedOverlays = aElementOverlays.length;
 		var aInvisibleElements = aElements.filter(function(oElement) {
 			var oElementOverlay = OverlayRegistry.getOverlay(oElement);
 			return !(oElementOverlay && oElementOverlay.getElementVisibility());
 		});
-		return !(aInvisibleElements.length === (aElements.length - iNumberOfSelectedOverlays));
+		var bIsLastVisibleElement = (aInvisibleElements.length + iNumberOfSelectedOverlays === aElements.length);
+		if (bIsLastVisibleElement) {
+			return fnCheckDesignTimeSettings(oOverlay);
+		}
+		return true;
 	};
 
 	/**
 	 * @param  {sap.ui.dt.Overlay} oOverlay overlay object
-	 * @return {String} Returns the confirmation text
+	 * @return {string} Returns the confirmation text
 	 * @private
 	 */
 	Remove.prototype._getConfirmationText = function(oOverlay) {
@@ -323,4 +336,4 @@ sap.ui.define([
 	};
 
 	return Remove;
-});
+});

package/src/sap/ui/rta/plugin/Rename.js

@@ -28,7 +28,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.plugin.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/RenameHandler.js

@@ -55,7 +55,7 @@ sap.ui.define([
 	 * Provides Rename handling functionality
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/Selection.js

@@ -9,20 +9,16 @@ sap.ui.define([
 	"sap/ui/rta/Utils",
 	"sap/ui/dt/OverlayRegistry",
 	"sap/ui/events/KeyCodes",
-	"sap/ui/dt/Overlay",
 	"sap/base/util/restricted/_intersection",
-	"sap/m/InstanceManager",
-	"sap/ui/Device"
+	"sap/m/InstanceManager"
 ],
 function (
 	Plugin,
 	Utils,
 	OverlayRegistry,
 	KeyCodes,
-	Overlay,
 	_intersection,
-	InstanceManager,
-	Device
+	InstanceManager
 ) {
 	"use strict";
 
@@ -34,7 +30,7 @@ function (
 	 * @class The Selection plugin allows you to select or focus overlays with mouse or keyboard and navigate to others.
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.34
@@ -125,6 +121,18 @@ function (
 		return false;
 	};
 
+	/**
+	 * Sets the value of the isActive property.
+	 * When set to false, de-select all overlays.
+	 * @param {boolean} bValue - Value to be set
+	 */
+	Selection.prototype.setIsActive = function(bValue) {
+		this.setProperty("isActive", bValue);
+		if (bValue === false) {
+			this._deselectOverlays();
+		}
+	};
+
 	/**
 	 * Register an overlay
 	 *
@@ -244,11 +252,14 @@ function (
 	};
 
 	Selection.prototype._selectOverlay = function (oEvent) {
+		var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
 		if (!this.getIsActive()) {
-			preventEventDefaultAndPropagation(oEvent);
+			// Propagation should be stopped at the root overlay to prevent the selection of the underlying elements
+			if (oOverlay.isRoot()) {
+				preventEventDefaultAndPropagation(oEvent);
+			}
 			return;
 		}
-		var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
 		var bMultiSelection = oEvent.metaKey || oEvent.ctrlKey;
 		var bContextMenu = oEvent.type === "contextmenu";
 
@@ -281,7 +292,11 @@ function (
 			// In Visualization Mode we must prevent MouseDown-Event for Overlays
 			// We have to close open PopOvers from the ChangeVisualization because they
 			// should close on MouseDown
-			preventEventDefaultAndPropagation(oEvent);
+			var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
+			// Propagation should be stopped at the root overlay to prevent the selection of the underlying elements
+			if (oOverlay.isRoot()) {
+				preventEventDefaultAndPropagation(oEvent);
+			}
 			InstanceManager.getOpenPopovers().forEach(function(oPopOver) {
 				if (oPopOver._bOpenedByChangeIndicator) {
 					oPopOver.close();
@@ -289,25 +304,6 @@ function (
 			});
 			return;
 		}
-		// set focus after clicking, needed only for internet explorer
-		if (Device.browser.name === "ie") {
-			// when the EasyAdd Button is clicked, we don't want to focus/stopPropagation.
-			// but when the OverlayScrollContainer is the target, we want it to behave like a click on an overlay
-			var oTarget = OverlayRegistry.getOverlay(oEvent.target.id);
-			var bTargetIsScrollContainer = jQuery(oEvent.target).hasClass("sapUiDtOverlayScrollContainer");
-			var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
-			if (
-				oOverlay
-				&& (bTargetIsScrollContainer || oTarget instanceof Overlay)
-			) {
-				if (oOverlay.getSelectable()) {
-					oOverlay.focus();
-					oEvent.stopPropagation();
-				} else {
-					oOverlay.getDomRef().blur();
-				}
-			}
-		}
 	};
 
 	/**
@@ -316,11 +312,14 @@ function (
 	 * @private
 	 */
 	Selection.prototype._onMouseover = function(oEvent) {
+		var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
 		if (!this.getIsActive()) {
-			preventEventDefaultAndPropagation(oEvent);
+			// Propagation should be stopped at the root overlay to prevent the selection of the underlying elements
+			if (oOverlay.isRoot()) {
+				preventEventDefaultAndPropagation(oEvent);
+			}
 			return;
 		}
-		var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
 		if (oOverlay.isSelectable()) {
 			if (oOverlay !== this._oHoverTarget) {
 				this._removePreviousHover();
@@ -337,11 +336,14 @@ function (
 	 * @private
 	 */
 	Selection.prototype._onMouseleave = function(oEvent) {
+		var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
 		if (!this.getIsActive()) {
-			preventEventDefaultAndPropagation(oEvent);
+			// Propagation should be stopped at the root overlay to prevent the selection of the underlying elements
+			if (oOverlay.isRoot()) {
+				preventEventDefaultAndPropagation(oEvent);
+			}
 			return;
 		}
-		var oOverlay = OverlayRegistry.getOverlay(oEvent.currentTarget.id);
 		if (oOverlay.isSelectable()) {
 			this._removePreviousHover();
 			preventEventDefaultAndPropagation(oEvent);

package/src/sap/ui/rta/plugin/Settings.js

@@ -25,7 +25,7 @@ sap.ui.define([
 	 * @class The Settings allows trigger change of settings operations on the overlay
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.44

package/src/sap/ui/rta/plugin/Split.js

@@ -23,7 +23,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.plugin.Plugin
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.46

package/src/sap/ui/rta/plugin/Stretch.js

@@ -31,7 +31,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.plugin.Plugin
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/plugin/additionalElements/ActionExtractor.js

@@ -32,7 +32,7 @@ sap.ui.define([
 	 * handled by the AdditionalElements Plugin (Reveal, Add Via Delegate, Add Custom)
 	 *
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @private
 	 * @since 1.94
 	 * @experimental Since 1.94. This class is experimental and provides only limited functionality. Also the API might be changed in future.
@@ -82,12 +82,20 @@ sap.ui.define([
 	function checkInvalidAddActions(bSibling, oSourceElementOverlay, oPlugin) {
 		var mParents = AdditionalElementsUtils.getParents(bSibling, oSourceElementOverlay, oPlugin);
 		var oDesignTimeMetadata = mParents.parentOverlay && mParents.parentOverlay.getDesignTimeMetadata();
-		var aActions = oDesignTimeMetadata ? oDesignTimeMetadata.getActionDataFromAggregations("addODataProperty", mParents.parent) : [];
-		if (aActions.length > 0) {
+		var aAddODataPropertyActions = oDesignTimeMetadata ? oDesignTimeMetadata.getActionDataFromAggregations("addODataProperty", mParents.parent) : [];
+		if (aAddODataPropertyActions.length > 0) {
 			Log.error("Outdated addODataProperty action in designtime metadata in "
 				+ oDesignTimeMetadata.getData().designtimeModule
 				+ " or propagated or via instance specific designtime metadata.");
 		}
+		var aAddActions = oDesignTimeMetadata ? oDesignTimeMetadata.getActionDataFromAggregations("add", mParents.parent) : [];
+		aAddActions.forEach(function(mAddAction) {
+			if (mAddAction["custom"]) {
+				Log.error("Outdated custom add action in designtime metadata in "
+					+ oDesignTimeMetadata.getData().designtimeModule
+					+ " or propagated or via instance specific designtime metadata.");
+			}
+		});
 	}
 
 	function getInvisibleElements (oParentOverlay, sAggregationName, oPlugin) {
@@ -224,26 +232,27 @@ sap.ui.define([
 	}
 
 	function checkAndEnrichReveal(mReveal, mInvisibleElement, oPlugin, sTargetAggregation) {
-		return Promise.resolve().then(function() {
-			var oInvisibleElement = mInvisibleElement.element;
-			var oDesignTimeMetadata;
-			var mRevealAction;
-			var bRevealEnabled = false;
-			var oHasChangeHandlerPromise = Promise.resolve();
-			var sSourceAggregation = mInvisibleElement.sourceAggregation;
-
-			var oOverlay = OverlayRegistry.getOverlay(oInvisibleElement);
-			if (oOverlay) {
-				oDesignTimeMetadata = oOverlay.getDesignTimeMetadata();
-
-				mRevealAction = oDesignTimeMetadata && oDesignTimeMetadata.getAction("reveal", oInvisibleElement);
-				if (mRevealAction && mRevealAction.changeType) {
-					var oRevealSelector = oInvisibleElement;
-					if (mRevealAction.changeOnRelevantContainer) {
-						oRevealSelector = oOverlay.getRelevantContainer();
-					}
+		var oInvisibleElement = mInvisibleElement.element;
+		var oDesignTimeMetadata;
+		var mRevealAction;
+		var bRevealEnabled = false;
+		var oHasChangeHandlerPromise = Promise.resolve(false);
+		var sSourceAggregation = mInvisibleElement.sourceAggregation;
+
+		var oOverlay = OverlayRegistry.getOverlay(oInvisibleElement);
+		if (oOverlay) {
+			oDesignTimeMetadata = oOverlay.getDesignTimeMetadata();
+
+			mRevealAction = oDesignTimeMetadata && oDesignTimeMetadata.getAction("reveal", oInvisibleElement);
+			if (mRevealAction && mRevealAction.changeType) {
+				var oRevealSelector = oInvisibleElement;
+				if (mRevealAction.changeOnRelevantContainer) {
+					oRevealSelector = oOverlay.getRelevantContainer();
+				}
 
-					oHasChangeHandlerPromise = oPlugin.hasChangeHandler(mRevealAction.changeType, oRevealSelector).then(function(bHasChangeHandler) {
+				oHasChangeHandlerPromise = oPlugin.hasChangeHandler(mRevealAction.changeType, oRevealSelector).then(function(bHasChangeHandler) {
+					// Element can be made invalid while the check is running (e.g. destroyed during undo of split)
+					if (ElementUtil.isElementValid(oInvisibleElement)) {
 						var mParents = AdditionalElementsUtils.getParents(true, oOverlay, oPlugin);
 						if (bHasChangeHandler) {
 							if (mRevealAction.changeOnRelevantContainer) {
@@ -263,32 +272,32 @@ sap.ui.define([
 								return Utils.checkTargetZone(oAggregationOverlay, oOverlay, oPlugin);
 							}
 						}
-						return bRevealEnabled;
-					});
-				}
+					}
+					return bRevealEnabled;
+				});
 			}
+		}
 
-			return oHasChangeHandlerPromise.then(function(bIncludeReveal) {
-				if (bIncludeReveal) {
-					mReveal.elements.push({
-						element: oInvisibleElement,
-						designTimeMetadata: oDesignTimeMetadata,
-						action: mRevealAction,
-						sourceAggregation: sSourceAggregation,
-						targetAggregation: sTargetAggregation
-					});
-					var mName = oDesignTimeMetadata.getName(oInvisibleElement);
-					if (mName) {
-						mReveal.controlTypeNames.push(mName);
-					}
+		return oHasChangeHandlerPromise.then(function(bIncludeReveal) {
+			if (bIncludeReveal) {
+				mReveal.elements.push({
+					element: oInvisibleElement,
+					designTimeMetadata: oDesignTimeMetadata,
+					action: mRevealAction,
+					sourceAggregation: sSourceAggregation,
+					targetAggregation: sTargetAggregation
+				});
+				var mName = oDesignTimeMetadata.getName(oInvisibleElement);
+				if (mName) {
+					mReveal.controlTypeNames.push(mName);
 				}
-				return mReveal;
-			});
+			}
+			return mReveal;
 		});
 	}
 
 	/**
-	 * Calculate a structure with all "add/reveal/custom" action relevant data collected per aggregation:
+	 * Calculate a structure with all "add/reveal" action relevant data collected per aggregation:
 	 * <pre>
 	 * {
 	 *	<aggregationName> : {
@@ -304,11 +313,6 @@ sap.ui.define([
 	 *				sourceAggregation: <aggregation where this element is currently located>
 	 *			}],
 	 *			controlTypeNames : string[] <all controlTypeNames collected via designTimeMetadata>
-	 *		},
-	 *		addViaCustom : {
-	 *			designTimeMetadata : <sap.ui.dt.ElementDesignTimeMetadata of parent>,
-	 *			action : <add.custom action section from designTimeMetadata>
-	 *			items : <add.custom action's array of items from the getItems() function>
 	 *		}
 	 *	},
 	 *	<aggregationName2> : ...
@@ -320,7 +324,7 @@ sap.ui.define([
 	 * @param {sap.ui.rta.plugin.additionalElements.AdditionalElementsPlugin} oPlugin - Instance of the AdditionalElementsPlugin
 	 * @param {boolean} [bInvalidate] - Option to prevent cached actions to be returned
 	 *
-	 * @return {Promise} Resolving to a structure with all "add/reveal/custom" action relevant data collected
+	 * @return {Promise} Resolving to a structure with all "add/reveal" action relevant data collected
 	 */
 	ActionExtractor.getActions = function(bSibling, oSourceElementOverlay, oPlugin, bInvalidate) {
 		var sSiblingOrChild = bSibling ? "asSibling" : "asChild";
@@ -330,16 +334,14 @@ sap.ui.define([
 
 		var oRevealActionsPromise = this._getRevealActions(bSibling, oSourceElementOverlay, oPlugin);
 		var oAddPropertyActionsPromise = this._getAddViaDelegateActions(bSibling, oSourceElementOverlay, oPlugin);
-		var oCustomAddActionsPromise = this._getCustomAddActions(bSibling, oSourceElementOverlay, oPlugin);
 
 		return Promise.all([
 			oRevealActionsPromise,
 			oAddPropertyActionsPromise,
-			oCustomAddActionsPromise,
 			checkInvalidAddActions(bSibling, oSourceElementOverlay, oPlugin)
 		]).then(function(aAllActions) {
 			//join and condense all action data
-			var mAllActions = merge(aAllActions[0], aAllActions[1], aAllActions[2]);
+			var mAllActions = merge(aAllActions[0], aAllActions[1]);
 			oSourceElementOverlay._mAddActions = oSourceElementOverlay._mAddActions || {asSibling: {}, asChild: {}};
 			oSourceElementOverlay._mAddActions[sSiblingOrChild] = mAllActions;
 			return mAllActions;
@@ -350,7 +352,7 @@ sap.ui.define([
 	 * Returns the already calculated actions of an Overlay, or undefined if no actions available
 	 * @param {boolean} bSibling - Indicates if the elements should be added as sibling (true) or child (false) to the overlay
 	 * @param {sap.ui.dt.ElementOverlay} oOverlay - Elements will be added in relation (sibling/parent) to this overlay
-	 * @returns {object/undefined} - Object with all "add/reveal/custom" action relevant data collected or undefined if no actions available
+	 * @returns {object/undefined} - Object with all "add/reveal" action relevant data collected or undefined if no actions available
 	 */
 	ActionExtractor.getActionsOrUndef = function(bSibling, oOverlay) {
 		var sSiblingOrChild = bSibling ? "asSibling" : "asChild";
@@ -431,75 +433,5 @@ sap.ui.define([
 			}.bind(this));
 	};
 
-	/**
-	 * Return the CustomAdd action data (parameters + elements) for an Overlay.
-	 * @param {boolean} bSibling - If source element overlay should be sibling or parent to the newly added fields
-	 * @param {sap.ui.dt.ElementOverlay} oOverlay - Overlay where the action is triggered
-	 * @param {sap.ui.rta.plugin.additionalElements.AdditionalElementsPlugin} oPlugin - Instance of the AdditionalElementsPlugin
-	 *
-	 * @returns {Promise<object>} CustomAdd action data
-	 */
-	ActionExtractor._getCustomAddActions = function(bSibling, oOverlay, oPlugin) {
-		var mParents = AdditionalElementsUtils.getParents(bSibling, oOverlay, oPlugin);
-		var oDesignTimeMetadata = mParents.parentOverlay && mParents.parentOverlay.getDesignTimeMetadata();
-		var aActions = oDesignTimeMetadata && oDesignTimeMetadata.getActionDataFromAggregations("add", mParents.parent, undefined, "custom") || [];
-
-		function getAction(mAction, oCheckElement) {
-			var aItems = [];
-			return Promise.resolve()
-				.then(function () {
-					if (mAction && typeof mAction.getItems === "function") {
-						var oCheckElementOverlay = OverlayRegistry.getOverlay(oCheckElement);
-						if (oPlugin.hasStableId(oCheckElementOverlay)) {
-							return mAction.getItems(oCheckElement);
-						}
-					}
-					return aItems;
-				})
-				.then(function (aItemsFromAction) {
-					aItems = aItemsFromAction || [];
-					var aChangeHandlerPromises = aItems.reduce(function (aPromises, oItem) {
-						// adjust relevant container
-						if (oItem.changeSpecificData.changeOnRelevantContainer) {
-							oCheckElement = mParents.relevantContainer;
-						}
-						if (oItem.changeSpecificData.changeType) {
-							aPromises.push(oPlugin.hasChangeHandler(oItem.changeSpecificData.changeType, oCheckElement));
-						}
-						return aPromises;
-					}, []);
-
-					return Promise.all(aChangeHandlerPromises);
-				})
-				.then(function (aHasChangeHandlerForCustomItems) {
-					if (aHasChangeHandlerForCustomItems.indexOf(false) === -1) {
-						return {
-							aggregationName: mAction.aggregation,
-							addViaCustom: {
-								designTimeMetadata: oDesignTimeMetadata,
-								action: mAction,
-								items: aItems
-							}
-						};
-					}
-					return undefined;
-				});
-		}
-
-		var oCheckElement = mParents.parent;
-		return aActions.reduce(function(oPreviousPromise, oAction) {
-			return oPreviousPromise.then(function(oReturn) {
-				return getAction.call(this, oAction, oCheckElement).then(function(mAction) {
-					if (mAction) {
-						oReturn[mAction.aggregationName] = {
-							addViaCustom: mAction.addViaCustom
-						};
-					}
-					return oReturn;
-				});
-			}.bind(this));
-		}.bind(this), Promise.resolve({}));
-	};
-
 	return ActionExtractor;
 });

package/src/sap/ui/rta/plugin/additionalElements/AddElementsDialog.js

@@ -32,7 +32,7 @@ sap.ui.define([
 	 * @class Context - Dialog for available Fields in Runtime Authoring
 	 * @extends sap.ui.base.ManagedObject
 	 * @author SAP SE
-	 * @version 1.97.1
+	 * @version 1.100.0
 	 * @constructor
 	 * @private
 	 * @since 1.44

package/src/sap/ui/rta/plugin/additionalElements/AdditionalElementsAnalyzer.js

@@ -126,15 +126,6 @@ sap.ui.define([
 		});
 	}
 
-	function _assignCustomItemIds(sParentId, oCustomItem) {
-		oCustomItem.type = "custom";
-		if (oCustomItem.id) {
-			oCustomItem.itemId = sParentId + "-" + oCustomItem.id;
-			oCustomItem.key = oCustomItem.itemId;
-		}
-		return oCustomItem;
-	}
-
 	function _oPropertyToAdditionalElementInfo (oProperty) {
 		return {
 			selected: false,
@@ -409,18 +400,6 @@ sap.ui.define([
 		return bIncludeElement;
 	}
 
-	function _enhanceByCustomItems(oInvisibleElement, mActions, bIncludeElement, oElement) {
-		var mCustom = mActions.addViaCustom;
-		if (mCustom && bIncludeElement) {
-			mCustom.items.forEach(function(oCustomItem) {
-				_assignCustomItemIds(oElement.getParent().getId(), oCustomItem);
-				if (oCustomItem.itemId === oInvisibleElement.getId()) {
-					_enhanceInvisibleElement(oInvisibleElement, oCustomItem);
-				}
-			});
-		}
-	}
-
 	function _getModelName(mAddViaDelegate) {
 		//ManagedObject jsdoc tells to use undefined for default model, therefore it
 		//is necessary to return undefined if modelName or whole delegateInfo is missing
@@ -462,8 +441,6 @@ sap.ui.define([
 
 						var bIncludeElement = _enhanceByMetadata(oElement, sAggregationName, oInvisibleElement, mActions, aRepresentedProperties, aProperties);
 
-						_enhanceByCustomItems(oInvisibleElement, mActions, bIncludeElement, oElement);
-
 						if (bIncludeElement) {
 							aAllElementData.push({
 								element: oInvisibleElement,
@@ -518,50 +495,6 @@ sap.ui.define([
 				}).then(function(aUnrepresentedProperties) {
 					return aUnrepresentedProperties.map(_oPropertyToAdditionalElementInfo);
 				});
-		},
-
-		getCustomAddItems: function(oElement, mAction) {
-			return new Promise(function(fnResolve) {
-				if (Array.isArray(mAction.items)) {
-					// remove items already rendered
-					fnResolve(
-						mAction.items
-							.map(_assignCustomItemIds.bind(null, oElement.getParent().getId()))
-							.filter(function(oCustomItem) {
-								if (!oCustomItem.id) {
-									Log.error("CustomAdd item with label " + oCustomItem.label + " does not contain an 'id' property", "sap.ui.rta.plugin.AdditionalElementsAnalyzer#showAvailableElements");
-									return false;
-								}
-								return !ElementUtil.getElementInstance(oCustomItem.itemId);
-							})
-					);
-				} else {
-					fnResolve();
-				}
-			});
-		},
-
-		getFilteredItemsList: function(aAnalyzerValues) {
-			// promise index 0: invisible, 1: addViaOData/addViaDelegate, 2: custom
-			var aInvisibleElements = aAnalyzerValues[0];
-			var iCustomItemsIndex = 2;
-			var aCustomItems = aAnalyzerValues[iCustomItemsIndex];
-			if (aCustomItems) {
-				var aInvisibleElementIds = aInvisibleElements.map(
-					function (oInvisibleItem) {
-						return oInvisibleItem.elementId;
-					}
-				);
-				// filter for hidden custom items in the array
-				aAnalyzerValues[iCustomItemsIndex] = aCustomItems
-					.filter(function(oCustomItem) {
-						return !oCustomItem.itemId || aInvisibleElementIds.indexOf(oCustomItem.itemId) === -1;
-					});
-			}
-			return aAnalyzerValues
-				.reduce(function (aAllElements, aAnalyzerValue) {
-					return aAllElements.concat(aAnalyzerValue);
-				}, []);
 		}
 	};
 	return oAnalyzer;