@openui5/sap.ui.rta 1.133.1 → 1.135.0

package/src/sap/ui/rta/appVariant/manageApps/webapp/controller/ManageApps.controller.js

@@ -36,19 +36,19 @@ sap.ui.define([
 ) {
 	"use strict";
 
-	var _sIdRunningApp;
-	var _bKeyUser;
-	var _sLayer;
-	var _oCrossAppNavService;
-	var sModulePath;
-	var oI18n;
+	let _sIdRunningApp;
+	let _bKeyUser;
+	let _sLayer;
+	let _oCrossAppNavService;
+	let sModulePath;
+	let oI18n;
 
 	return Controller.extend("sap.ui.rta.appVariant.manageApps.webapp.controller.ManageApps", {
 		onInit() {
 			_sIdRunningApp = this.getOwnerComponent().getIdRunningApp();
 			_bKeyUser = this.getOwnerComponent().getIsOverviewForKeyUser();
 			_sLayer = this.getOwnerComponent().getLayer();
-			var oUShellContainer = FlUtils.getUshellContainer();
+			const oUShellContainer = FlUtils.getUshellContainer();
 
 			if (!oI18n) {
 				this._createResourceBundle();
@@ -79,7 +79,7 @@ sap.ui.define([
 			}.bind(this))
 			.catch(function(oError) {
 				AppVariantUtils.closeOverviewDialog();
-				var oErrorInfo = AppVariantUtils.buildErrorInfo("MSG_MANAGE_APPS_FAILED", oError);
+				const oErrorInfo = AppVariantUtils.buildErrorInfo("MSG_MANAGE_APPS_FAILED", oError);
 				oErrorInfo.overviewDialog = true;
 				BusyIndicator.hide();
 				return AppVariantUtils.showRelevantDialog(oErrorInfo, false);
@@ -100,15 +100,15 @@ sap.ui.define([
 		},
 
 		_highlightNewCreatedAppVariant(aAppVariantOverviewAttributes) {
-			var oTable = this.byId("Table1");
+			const oTable = this.byId("Table1");
 			if (!oTable) {
 				return Promise.resolve();
 			}
 			oTable.focus();
 
-			aAppVariantOverviewAttributes.forEach(function(oAppVariantDescriptor, index) {
-				if (oAppVariantDescriptor.currentStatus === oI18n.getText("MAA_NEW_APP_VARIANT")
-					|| oAppVariantDescriptor.currentStatus === oI18n.getText("MAA_OPERATION_IN_PROGRESS")
+			aAppVariantOverviewAttributes.forEach(function(oAppVariantManifest, index) {
+				if (oAppVariantManifest.currentStatus === oI18n.getText("MAA_NEW_APP_VARIANT")
+					|| oAppVariantManifest.currentStatus === oI18n.getText("MAA_OPERATION_IN_PROGRESS")
 				) {
 					if (oTable.getItems().length >= index) {
 						oTable.getItems()[index].focus();
@@ -120,11 +120,11 @@ sap.ui.define([
 		},
 
 		_arrangeOverviewDataAndBindToModel(aAppVariantOverviewAttributes) {
-			var aAdaptingAppAttributes = aAppVariantOverviewAttributes.filter(function(oAppVariantProperty) {
+			const aAdaptingAppAttributes = aAppVariantOverviewAttributes.filter(function(oAppVariantProperty) {
 				return oAppVariantProperty.appId === _sIdRunningApp;
 			});
 
-			var oAdaptingAppAttributes = aAdaptingAppAttributes[0];
+			const oAdaptingAppAttributes = aAdaptingAppAttributes[0];
 			if (oAdaptingAppAttributes && oAdaptingAppAttributes.appVarStatus !== "R") {
 				oAdaptingAppAttributes.currentStatus = oI18n.getText("MAA_CURRENTLY_ADAPTING");
 			}
@@ -135,11 +135,11 @@ sap.ui.define([
 
 			aAppVariantOverviewAttributes.unshift(oAdaptingAppAttributes);
 
-			var aReferenceAppAttributes = aAppVariantOverviewAttributes.filter(function(oAppVariantProperty) {
+			const aReferenceAppAttributes = aAppVariantOverviewAttributes.filter(function(oAppVariantProperty) {
 				return oAppVariantProperty.isOriginal;
 			});
 
-			var oReferenceAppAttributes = aReferenceAppAttributes[0];
+			const oReferenceAppAttributes = aReferenceAppAttributes[0];
 
 			aAppVariantOverviewAttributes = aAppVariantOverviewAttributes.filter(function(oAppVariantProperty) {
 				return !oAppVariantProperty.isOriginal;
@@ -149,11 +149,11 @@ sap.ui.define([
 
 			// Bind the app variant overview to JSON model
 
-			var oModelData = {
+			const oModelData = {
 				appVariants: aAppVariantOverviewAttributes
 			};
 
-			var oModel = Model.createModel(oModelData);
+			const oModel = Model.createModel(oModelData);
 			this.getView().setModel(oModel);
 
 			return Promise.resolve(aAppVariantOverviewAttributes);
@@ -216,8 +216,8 @@ sap.ui.define([
 		},
 
 		onMenuAction(oEvent) {
-			var oItem = oEvent.getParameter("item");
-			var sItemPath = "";
+			let oItem = oEvent.getParameter("item");
+			let sItemPath = "";
 
 			while (oItem instanceof MenuItem) {
 				sItemPath = `${oItem.getText()} > ${sItemPath}`;
@@ -242,11 +242,11 @@ sap.ui.define([
 		},
 
 		handleUiAdaptation(oEvent) {
-			var sSemanticObject = this.getModelProperty("semanticObject", oEvent.getSource().getBindingContext());
-			var sAction = this.getModelProperty("action", oEvent.getSource().getBindingContext());
-			var oParams = this.getModelProperty("params", oEvent.getSource().getBindingContext());
+			const sSemanticObject = this.getModelProperty("semanticObject", oEvent.getSource().getBindingContext());
+			const sAction = this.getModelProperty("action", oEvent.getSource().getBindingContext());
+			const oParams = this.getModelProperty("params", oEvent.getSource().getBindingContext());
 
-			var oNavigationParams;
+			let oNavigationParams;
 			if (sSemanticObject && sAction && oParams) {
 				oNavigationParams = {
 					target: {
@@ -271,23 +271,23 @@ sap.ui.define([
 		},
 
 		copyId(oEvent) {
-			var sCopiedId = this.getModelProperty("appId", oEvent.getSource().getBindingContext());
+			const sCopiedId = this.getModelProperty("appId", oEvent.getSource().getBindingContext());
 			AppVariantUtils.copyId(sCopiedId);
 			MessageToast.show(oI18n.getText("MAA_COPY_ID_SUCCESS"));
 		},
 
 		deleteAppVariant(oEvent) {
-			var oInfo = {};
+			const oInfo = {};
 			if (!oI18n) {
 				this._createResourceBundle();
 			}
-			var sMessage = oI18n.getText("MSG_APP_VARIANT_DELETE_CONFIRMATION");
+			const sMessage = oI18n.getText("MSG_APP_VARIANT_DELETE_CONFIRMATION");
 			oInfo.text = sMessage;
 			oInfo.deleteAppVariant = true;
 
-			var sAppVarId = this.getModelProperty("appId", oEvent.getSource().getBindingContext());
-			var sCurrentStatus = this.getModelProperty("currentStatus", oEvent.getSource().getBindingContext());
-			var bCurrentlyAdapting = sCurrentStatus === oI18n.getText("MAA_CURRENTLY_ADAPTING");
+			const sAppVarId = this.getModelProperty("appId", oEvent.getSource().getBindingContext());
+			const sCurrentStatus = this.getModelProperty("currentStatus", oEvent.getSource().getBindingContext());
+			const bCurrentlyAdapting = sCurrentStatus === oI18n.getText("MAA_CURRENTLY_ADAPTING");
 
 			return AppVariantUtils.showRelevantDialog(oInfo)
 			.then(function() {

package/src/sap/ui/rta/appVariant/manageApps/webapp/i18n/i18n_fr_CA.properties

@@ -1,9 +1,9 @@
 
 MAA_DIALOG_ICON=Ic\u00F4ne
 MAA_DIALOG_DESCRIPTION=Description
-MAA_DIALOG_COPY_ID_ACTION=Copier l'action d'ID
+MAA_DIALOG_COPY_ID_ACTION=Action Copier l'ID
 MAA_DIALOG_ADAPT_UI_ACTION=Adapter l'action d'IU
-MAA_DIALOG_SAVE_AS_ACTION=Enregistrer en tant qu'action
+MAA_DIALOG_SAVE_AS_ACTION=Action Enregistrer sous
 MAA_DIALOG_ACTIONS=Actions
 MAA_DIALOG_DELETE_APPVAR=Supprimer la variante d'application
 MAA_DIALOG_ADAPT_UI=Adapter l'IU

package/src/sap/ui/rta/command/AddIFrame.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.command.FlexCommand
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.75

package/src/sap/ui/rta/command/AddProperty.js

@@ -14,7 +14,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.command.FlexCommand
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.78

package/src/sap/ui/rta/command/AddXML.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.command.FlexCommand
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.54

package/src/sap/ui/rta/command/AddXMLAtExtensionPoint.js

@@ -24,7 +24,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.command.FlexCommand
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.76

package/src/sap/ui/rta/command/AnnotationCommand.js

@@ -5,10 +5,18 @@
  */
 sap.ui.define([
 	"sap/ui/fl/write/api/ChangesWriteAPI",
+	"sap/ui/fl/write/api/FeaturesAPI",
+	"sap/ui/fl/write/api/LocalResetAPI",
+	"sap/ui/fl/write/api/PersistenceWriteAPI",
+	"sap/ui/fl/LayerUtils",
 	"sap/ui/rta/command/FlexCommand",
 	"sap/ui/rta/library"
 ], function(
 	ChangesWriteAPI,
+	FeaturesAPI,
+	LocalResetAPI,
+	PersistenceWriteAPI,
+	LayerUtils,
 	FlexCommand,
 	rtaLibrary
 ) {
@@ -21,7 +29,7 @@ sap.ui.define([
 	 * @extends sap.ui.rta.command.FlexCommand
 	 *
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private
@@ -40,6 +48,10 @@ sap.ui.define([
 				},
 				content: {
 					type: "any"
+				},
+				changesToDelete: {
+					type: "object[]",
+					defaultValue: []
 				}
 			},
 			events: {}
@@ -47,6 +59,7 @@ sap.ui.define([
 	});
 
 	AnnotationCommand.prototype._createChange = function(mFlexSettings, sVariantManagementReference, sCommand) {
+		this._aToBeResetChanges = [];
 		const mChangeSpecificData = {
 			...this._getChangeSpecificData(),
 			...mFlexSettings,
@@ -55,6 +68,36 @@ sap.ui.define([
 			jsOnly: this.getJsOnly(),
 			generator: mFlexSettings.generator || rtaLibrary.GENERATOR_NAME
 		};
+
+		if (this.getChangesToDelete().length) {
+			// If available, all changes of the current layer must be deleted via the LocalResetAPI
+			// Changes in a lower layer can't be deleted via the LocalResetAPI and must be deleted via the deactivate change
+			const aToBeDeactivatedChanges = [];
+			if (FeaturesAPI.isLocalResetEnabled()) {
+				this.getChangesToDelete().forEach((oFlexObject) => {
+					if (LayerUtils.compareAgainstCurrentLayer(oFlexObject.getLayer(), mFlexSettings.layer) === -1) {
+						aToBeDeactivatedChanges.push(oFlexObject);
+					} else {
+						this._aToBeResetChanges.push(oFlexObject);
+					}
+				});
+			} else {
+				aToBeDeactivatedChanges.push(...this.getChangesToDelete());
+			}
+
+			if (aToBeDeactivatedChanges.length) {
+				this._oDeactivateChange = ChangesWriteAPI.create({
+					changeSpecificData: {
+						changeType: "deactivateChanges",
+						content: { changeIds: aToBeDeactivatedChanges.map((oFlexObject) => oFlexObject.getId()) },
+						generator: mFlexSettings.generator || rtaLibrary.GENERATOR_NAME,
+						layer: mFlexSettings.layer
+					},
+					selector: this.getAppComponent()
+				});
+			}
+		}
+
 		return ChangesWriteAPI.create({
 			changeSpecificData: mChangeSpecificData,
 			annotationChange: true,
@@ -62,12 +105,29 @@ sap.ui.define([
 		});
 	};
 
-	AnnotationCommand.prototype.execute = function() {
-		return Promise.resolve();
+	AnnotationCommand.prototype.execute = async function() {
+		// Annotation changes can only be applied during app start, so execute and undo only have to take care of reset / deactivate changes
+		if (this._aToBeResetChanges.length) {
+			await LocalResetAPI.resetChanges(this._aToBeResetChanges, this.getAppComponent(), true);
+		}
+		if (this._oDeactivateChange) {
+			PersistenceWriteAPI.add({
+				selector: this.getAppComponent(),
+				flexObjects: [this._oDeactivateChange]
+			});
+		}
 	};
 
-	AnnotationCommand.prototype.undo = function() {
-		return Promise.resolve();
+	AnnotationCommand.prototype.undo = async function() {
+		if (this._aToBeResetChanges.length) {
+			await LocalResetAPI.restoreChanges(this._aToBeResetChanges, this.getAppComponent(), true);
+		}
+		if (this._oDeactivateChange) {
+			PersistenceWriteAPI.remove({
+				selector: this.getAppComponent(),
+				flexObjects: [this._oDeactivateChange]
+			});
+		}
 	};
 
 	/**

package/src/sap/ui/rta/command/BaseCommand.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	 * @extends sap.ui.base.ManagedObject
 	 *
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private

package/src/sap/ui/rta/command/BindProperty.js

@@ -26,7 +26,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.command.FlexCommand
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.38

package/src/sap/ui/rta/command/Combine.js

@@ -16,7 +16,7 @@ sap.ui.define([
 	 * @class
 	 * @extends sap.ui.rta.command.FlexCommand
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 * @constructor
 	 * @private
 	 * @since 1.46

package/src/sap/ui/rta/command/CommandFactory.js

@@ -27,19 +27,19 @@ sap.ui.define([
 	"use strict";
 
 	function evaluateTemplateBinding(oElementOverlay) {
-		var mBoundControl = ElementUtil.getAggregationInformation(oElementOverlay.getElement());
+		const mBoundControl = ElementUtil.getAggregationInformation(oElementOverlay.getElement());
 		if (mBoundControl.elementId) {
 			// check for additional binding
-			var oBoundControlOverlay = OverlayRegistry.getOverlay(mBoundControl.elementId);
-			var oParentElementOverlay = oBoundControlOverlay.getParentElementOverlay();
-			var bAdditionalBinding = oParentElementOverlay ?
+			const oBoundControlOverlay = OverlayRegistry.getOverlay(mBoundControl.elementId);
+			const oParentElementOverlay = oBoundControlOverlay.getParentElementOverlay();
+			const bAdditionalBinding = oParentElementOverlay ?
 				!!ElementUtil.getAggregationInformation(oParentElementOverlay.getElement()).templateId : false;
 
 			if (bAdditionalBinding) {
 				throw DtUtil.createError("CommandFactory#evaluateTemplateBinding", "Multiple template bindings are not supported", "sap.ui.rta");
 			}
 
-			var sTemplateId = ElementUtil.extractTemplateId(mBoundControl);
+			const sTemplateId = ElementUtil.extractTemplateId(mBoundControl);
 			if (sTemplateId) {
 				return {
 					templateSelector: mBoundControl.elementId,
@@ -56,10 +56,10 @@ sap.ui.define([
 	// For the Move Action the UI control is already moved while the corresponding object in the binding template is in the source position.
 	// Therefore we have to overwrite the index of the control in the stack with the source index (iIndex) to determine the needed template object.
 	function getTemplateElementId(vElementOrId, iIndex) {
-		var oElement = (typeof vElementOrId === "string") ? Element.getElementById(vElementOrId) : vElementOrId;
-		var oElementOverlay = OverlayRegistry.getOverlay(oElement);
+		const oElement = (typeof vElementOrId === "string") ? Element.getElementById(vElementOrId) : vElementOrId;
+		const oElementOverlay = OverlayRegistry.getOverlay(oElement);
 		if (oElementOverlay) {
-			var mBoundControl = ElementUtil.getAggregationInformation(oElement);
+			const mBoundControl = ElementUtil.getAggregationInformation(oElement);
 			if (typeof iIndex === "number") {
 				mBoundControl.stack[0].index = iIndex;
 			}
@@ -75,9 +75,9 @@ sap.ui.define([
 	}
 
 	function configureActionCommand(oCommand, vAction) {
-		var sChangeType;
-		var bJsOnly = false;
-		var bVariantIndependent = false;
+		let sChangeType;
+		let bJsOnly = false;
+		let bVariantIndependent = false;
 
 		if (typeof vAction === "string") {
 			sChangeType = vAction;
@@ -102,6 +102,20 @@ sap.ui.define([
 	}
 
 	function configureAddXmlCommand(oElement, mSettings, oDesignTimeMetadata) {
+		let vAction;
+		if (oDesignTimeMetadata) {
+			vAction = oDesignTimeMetadata.getAction(mSettings.name, oElement);
+		}
+		// the change type is not configurable via designtime
+		// it can also not be disabled with 'not-adaptable' or null
+		const oAction = vAction || {};
+		Object.assign(oAction, {
+			changeType: mSettings.name
+		});
+		return oAction;
+	}
+
+	function configureExtendControllerCommand(oElement, mSettings, oDesignTimeMetadata) {
 		var vAction;
 		if (oDesignTimeMetadata) {
 			vAction = oDesignTimeMetadata.getAction(mSettings.name, oElement);
@@ -121,8 +135,8 @@ sap.ui.define([
 	}
 
 	function configureCreateContainerCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oNewAddedElement = mSettings.element || Element.getElementById(mSettings.element.id);
-		var oAction = oDesignTimeMetadata.getActionDataFromAggregations("createContainer", oNewAddedElement)[0];
+		const oNewAddedElement = mSettings.element || Element.getElementById(mSettings.element.id);
+		const oAction = oDesignTimeMetadata.getActionDataFromAggregations("createContainer", oNewAddedElement)[0];
 		return oAction;
 	}
 
@@ -134,14 +148,14 @@ sap.ui.define([
 	}
 
 	function configureMoveCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oMovedElement = mSettings.movedElements[0].element || Element.getElementById(mSettings.movedElements[0].id);
-		var oAction = oDesignTimeMetadata.getAction("move", oMovedElement);
+		const oMovedElement = mSettings.movedElements[0].element || Element.getElementById(mSettings.movedElements[0].id);
+		const oAction = oDesignTimeMetadata.getAction("move", oMovedElement);
 		return oAction;
 	}
 
 	function adjustMoveCommand(mSettings) {
-		var aTemplateMovedElements = mSettings.movedElements.map(function(oMovedElement) {
-			var oMovedElementInTemplate = Element.getElementById(getTemplateElementId(oMovedElement.element, oMovedElement.sourceIndex));
+		const aTemplateMovedElements = mSettings.movedElements.map(function(oMovedElement) {
+			const oMovedElementInTemplate = Element.getElementById(getTemplateElementId(oMovedElement.element, oMovedElement.sourceIndex));
 			evaluateResult(oMovedElementInTemplate);
 			return oMovedElementInTemplate;
 		});
@@ -161,8 +175,8 @@ sap.ui.define([
 	}
 
 	function configureRenameCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oRenamedElement = mSettings.renamedElement;
-		var oAction = oDesignTimeMetadata.getAction("rename", oRenamedElement);
+		const oRenamedElement = mSettings.renamedElement;
+		const oAction = oDesignTimeMetadata.getAction("rename", oRenamedElement);
 		return oAction;
 	}
 
@@ -174,13 +188,13 @@ sap.ui.define([
 	}
 
 	function configureRemoveCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oRemovedElement = mSettings.removedElement;
+		let oRemovedElement = mSettings.removedElement;
 		if (!oRemovedElement) {
 			oRemovedElement = oElement;
 		} else if (!(oRemovedElement instanceof ManagedObject)) {
 			throw new Error("No valid 'removedElement' found");
 		}
-		var oAction = oDesignTimeMetadata.getAction("remove", oRemovedElement);
+		const oAction = oDesignTimeMetadata.getAction("remove", oRemovedElement);
 		return oAction;
 	}
 
@@ -192,8 +206,8 @@ sap.ui.define([
 	}
 
 	function configureCombineCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oCombineElement = mSettings.source;
-		var oAction = oDesignTimeMetadata.getAction("combine", oCombineElement);
+		const oCombineElement = mSettings.source;
+		const oAction = oDesignTimeMetadata.getAction("combine", oCombineElement);
 		return oAction;
 	}
 
@@ -202,7 +216,7 @@ sap.ui.define([
 		evaluateResult(mSettings.element);
 		mSettings.source = Element.getElementById(getTemplateElementId(mSettings.source));
 		evaluateResult(mSettings.source);
-		var aTemplateCombineElements = mSettings.combineElements.map(function(oCombineField) {
+		const aTemplateCombineElements = mSettings.combineElements.map(function(oCombineField) {
 			oCombineField = Element.getElementById(getTemplateElementId(oCombineField));
 			evaluateResult(oCombineField);
 			return oCombineField;
@@ -211,8 +225,8 @@ sap.ui.define([
 	}
 
 	function configureSplitCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oSplitElement = mSettings.source;
-		var oAction = oDesignTimeMetadata.getAction("split", oSplitElement);
+		const oSplitElement = mSettings.source;
+		const oAction = oDesignTimeMetadata.getAction("split", oSplitElement);
 		return oAction;
 	}
 
@@ -226,7 +240,7 @@ sap.ui.define([
 	}
 
 	function configureAddDelegatePropertyCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oNewAddedElement = mSettings.element;
+		const oNewAddedElement = mSettings.element;
 		return oDesignTimeMetadata.getAction("add", oNewAddedElement, "delegate");
 	}
 
@@ -238,8 +252,8 @@ sap.ui.define([
 	}
 
 	function configureRevealCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oRevealedElement = mSettings.element;
-		var oAction = oDesignTimeMetadata.getAction("reveal", oRevealedElement);
+		const oRevealedElement = mSettings.element;
+		const oAction = oDesignTimeMetadata.getAction("reveal", oRevealedElement);
 		return oAction;
 	}
 
@@ -257,9 +271,9 @@ sap.ui.define([
 	}
 
 	function configureCustomAddCommand(oElement, mSettings, oDesignTimeMetadata) {
-		var oAddAction = oDesignTimeMetadata.getAction("add", mSettings.element);
+		const oAddAction = oDesignTimeMetadata.getAction("add", mSettings.element);
 		if (oAddAction && oAddAction.custom && typeof oAddAction.custom.getItems === "function") {
-			var oAction = {
+			const oAction = {
 				...oAddAction.custom,
 				changeOnRelevantContainer: mSettings.changeOnRelevantContainer,
 				changeType: mSettings.changeType
@@ -282,7 +296,7 @@ sap.ui.define([
 		return "propertyChange";
 	}
 
-	var mCommands = { 	// Command names lower camel case
+	const mCommands = { 	// Command names lower camel case
 		composite: {
 			clazz: "sap/ui/rta/command/CompositeCommand",
 			noSelector: true
@@ -306,6 +320,11 @@ sap.ui.define([
 			configure: configureAddXmlCommand,
 			adjustForBinding: adjustSelectorForCommand
 		},
+		codeExt: {
+			clazz: "sap/ui/rta/command/ExtendControllerCommand",
+			configure: configureExtendControllerCommand,
+			adjustForBinding: adjustSelectorForCommand
+		},
 		createContainer: {
 			clazz: "sap/ui/rta/command/CreateContainer",
 			configure: configureCreateContainerCommand,
@@ -376,11 +395,16 @@ sap.ui.define([
 			clazz: "sap/ui/rta/command/Settings"
 		},
 		addLibrary: {
-			clazz: "sap/ui/rta/command/appDescriptor/AddLibrary",
+			clazz: "sap/ui/rta/command/manifest/AddLibrary",
 			noSelector: true
 		},
+		// left for compatibility reasons
 		appDescriptor: {
-			clazz: "sap/ui/rta/command/AppDescriptorCommand",
+			clazz: "sap/ui/rta/command/ManifestCommand",
+			noSelector: true
+		},
+		manifest: {
+			clazz: "sap/ui/rta/command/ManifestCommand",
 			noSelector: true
 		},
 		annotation: {
@@ -406,24 +430,24 @@ sap.ui.define([
 	};
 
 	function getCommandFor(vElement, sCommand, mSettings, oDesignTimeMetadata, mFlexSettings, sVariantManagementReference) {
-		var oCommand;
+		let oCommand;
 		sCommand = sCommand[0].toLowerCase() + sCommand.slice(1); // first char of command name is lower case
-		var mCommand = mCommands[sCommand];
-		var mAllFlexSettings = mFlexSettings;
+		const mCommand = mCommands[sCommand];
+		let mAllFlexSettings = mFlexSettings;
 
 		if (!mCommand) {
 			return Promise.reject(DtUtil.createError("CommandFactory#getCommandFor", `Command '${sCommand}' doesn't exist, check typing`, "sap.ui.rta"));
 		}
 
 		return new Promise(function(fnResolve) {
-			var sClassName = mCommand.clazz;
+			const sClassName = mCommand.clazz;
 			sap.ui.require([sClassName], function(Command) {
 				fnResolve(Command);
 			});
 		})
 
 		.then(function(Command) {
-			var bIsUiElement = vElement instanceof ManagedObject;
+			const bIsUiElement = vElement instanceof ManagedObject;
 
 			// only sap.ui.rta.command.FlexCommand requires a selector property
 			if (!mCommand.noSelector && !bIsUiElement) {
@@ -436,12 +460,12 @@ sap.ui.define([
 				name: sCommand
 			};
 
-			var oAction;
+			let oAction;
 			if (mCommand.configure) {
 				oAction = mCommand.configure(vElement, mSettings, oDesignTimeMetadata);
 			}
 
-			var oElementOverlay;
+			let oElementOverlay;
 			if (bIsUiElement) {
 				oElementOverlay = OverlayRegistry.getOverlay(vElement);
 			}
@@ -454,7 +478,7 @@ sap.ui.define([
 				oElementOverlay = OverlayRegistry.getOverlay(vElement);
 			}
 
-			var mTemplateSettings;
+			let mTemplateSettings;
 			if (oElementOverlay && vElement.sParentAggregationName) {
 				mTemplateSettings = evaluateTemplateBinding(oElementOverlay);
 			}
@@ -468,7 +492,7 @@ sap.ui.define([
 
 			oCommand = new Command(mSettings);
 
-			var bSuccessfullyConfigured = true; // configuration is optional
+			let bSuccessfullyConfigured = true; // configuration is optional
 			if (mCommand.configure) {
 				bSuccessfullyConfigured = configureActionCommand(oCommand, oAction);
 			}
@@ -493,14 +517,14 @@ sap.ui.define([
 	 * @extends sap.ui.base.ManagedObject
 	 *
 	 * @author SAP SE
-	 * @version 1.133.1
+	 * @version 1.135.0
 	 *
 	 * @constructor
 	 * @private
 	 * @since 1.34
 	 * @alias sap.ui.rta.command.CommandFactory
 	 */
-	var CommandFactory = ManagedObject.extend("sap.ui.rta.command.CommandFactory", {
+	const CommandFactory = ManagedObject.extend("sap.ui.rta.command.CommandFactory", {
 		metadata: {
 			library: "sap.ui.rta",
 			properties: {
@@ -562,7 +586,7 @@ sap.ui.define([
 		};
 
 		if (mFlexSettings.scenario || mFlexSettings.baseId) {
-			var sLRepRootNamespace = FlexUtils.buildLrepRootNamespace(mFlexSettings.baseId, mFlexSettings.scenario, mFlexSettings.projectId);
+			const sLRepRootNamespace = FlexUtils.buildLrepRootNamespace(mFlexSettings.baseId, mFlexSettings.scenario, mFlexSettings.projectId);
 			mFlexSettings.rootNamespace = sLRepRootNamespace;
 			mFlexSettings.namespace = `${sLRepRootNamespace}changes/`;
 		}
@@ -571,4 +595,4 @@ sap.ui.define([
 	};
 
 	return CommandFactory;
-}, /* bExport= */true);
+}, /* bExport= */true);