@openui5/sap.ui.mdc 1.92.0 → 1.95.0

package/src/sap/ui/mdc/Table.js

@@ -37,8 +37,6 @@ sap.ui.define([
 	"sap/ui/mdc/p13n/subcontroller/GroupController",
 	"sap/ui/mdc/p13n/subcontroller/AggregateController",
 	"sap/m/ColumnPopoverSelectListItem",
-	"sap/m/ColumnPopoverActionItem",
-	"sap/base/util/UriParameters",
 	"sap/ui/mdc/p13n/subcontroller/ColumnWidthController"
 ], function(
 	Control,
@@ -73,8 +71,6 @@ sap.ui.define([
 	GroupController,
 	AggregateController,
 	ColumnPopoverSelectListItem,
-	ColumnPopoverActionItem,
-	SAPUriParameters,
 	ColumnWidthController
 ) {
 	"use strict";
@@ -84,6 +80,7 @@ sap.ui.define([
 	var RowAction = library.RowAction;
 	var ToolbarDesign = MLibrary.ToolbarDesign;
 	var ToolbarStyle = MLibrary.ToolbarStyle;
+	var MultiSelectMode = library.MultiSelectMode;
 	var sFilterInterface = "sap.ui.mdc.IFilter";
 	var internalMap = new window.WeakMap();
 	var internal = function(oTable) {
@@ -354,6 +351,37 @@ sap.ui.define([
 					type: "boolean",
 					group: "Behavior",
 					defaultValue: false
+				},
+				/**
+				 * Defines the multi-selection mode for the control.
+				 * If this property is set to the <code>Default</code> value, the <code>ResponsiveTable</code> type control renders
+				 * the Select All checkbox in the column header, otherwise the Deselect All icon is rendered.
+				 *
+				 * This property is used with the <code>selectionMode="Multi"</code>.
+				 * @since 1.93
+				 */
+				 multiSelectMode : {
+					type: "sap.ui.mdc.MultiSelectMode",
+					group: "Behavior",
+					defaultValue: MultiSelectMode.Default
+				},
+
+				/**
+				 * Enables automatic column width calculation based on metadata information if set to <code>true</code>.
+				 * The column width calculation takes the type, column label, referenced properties, and many other metadata parameters into account.
+				 * Providing a more precise <code>maxLength</code> value for the <code>String</code> type or <code>precision</code> value for numeric types can help this algorithm to produce better results.
+				 * The calculated column widths can have a minimum of 3rem and a maximum of 20rem.
+				 *
+				 * <b>Note:</b> To customize the automatic column width calculation the <code>visualSettings.widthSettings</code> key of the <code>PropertyInfo</code> can be used.
+				 * To avoid the heuristic column width calculation for a particular column, the <code>visualSettings.widthSettings</code> key of the <code>PropertyInfo</code> can be set to <code>false</code>.
+				 * This feature has no effect if the <code>width</code> property of the column is bound or its value is set.
+				 *
+				 * @since 1.95
+				 */
+				enableAutoColumnWidth: {
+					type: "boolean",
+					group: "Behavior",
+					defaultValue: false
 				}
 			},
 			aggregations: {
@@ -519,10 +547,6 @@ sap.ui.define([
 			this._oTableReady = new Deferred();
 			this._oFullInitialize = new Deferred();
 
-			//Note: parameter should be removed once the new p13n is the default
-			var oURLParams = new SAPUriParameters(window.location.search);
-			this._bNewP13n = oURLParams.getAll("sap-ui-xx-mdcTableP13n").length > 0;
-
 			Control.apply(this, arguments);
 			this.bCreated = true;
 			this._doOneTimeOperations();
@@ -627,10 +651,44 @@ sap.ui.define([
 	};
 
 	Table.prototype.getDataStateIndicatorPluginOwner = function(oDataStateIndicator) {
-		oDataStateIndicator.setEnableFiltering(false);
 		return this._oTable || this._oFullInitialize.promise;
 	};
 
+	Table.prototype.setDataStateIndicator = function(oDataStateIndicator) {
+		this._handleDataStateEvents(this.getDataStateIndicator(), "detach");
+		this.setAggregation("dataStateIndicator", oDataStateIndicator, true);
+		this._handleDataStateEvents(this.getDataStateIndicator(), "attach");
+		return this;
+	};
+
+	Table.prototype._handleDataStateEvents = function(oDataStateIndicator, sAction) {
+		if (oDataStateIndicator) {
+			oDataStateIndicator[sAction + "ApplyFilter"](this._onApplyMessageFilter, this);
+			oDataStateIndicator[sAction + "ClearFilter"](this._onClearMessageFilter, this);
+			oDataStateIndicator[sAction + "Event"]("filterInfoPress", onShowFilterDialog, this);
+		}
+	};
+
+	/**
+	 * This gets called from the DataStateIndicator plugin when data state message filter is applied
+	 * @private
+	 */
+	 Table.prototype._onApplyMessageFilter = function(oEvent) {
+		this._oMessageFilter = oEvent.getParameter("filter");
+		oEvent.preventDefault();
+		this.rebind();
+	};
+
+	/**
+	 * This gets called from the DataStateIndicator plugin when the data state message filter is cleared
+	 * @private
+	 */
+	Table.prototype._onClearMessageFilter = function(oEvent) {
+		this._oMessageFilter = null;
+		oEvent.preventDefault();
+		this.rebind();
+	};
+
 	// ----Type----
 	Table.prototype._getStringType = function(oTypeInput) {
 		var sType, oType = sType = oTypeInput || this.getType();
@@ -690,7 +748,7 @@ sap.ui.define([
 				this._oTable.scrollToIndex(iIndex).then(resolve).catch(reject);
 			} else {
 				if (iIndex === -1) {
-					iIndex = this.getRowBinding() ? this.getRowBinding().getLength() : 0;
+					iIndex = this._getRowCount(false);
 				}
 
 				if (this._oTable._setFirstVisibleRowIndex(iIndex)) {
@@ -847,6 +905,15 @@ sap.ui.define([
 		return this;
 	};
 
+	Table.prototype.setMultiSelectMode = function(sMultiSelectMode) {
+		var sOldMultiSelectMode = this.getMultiSelectMode();
+		this.setProperty("multiSelectMode", sMultiSelectMode, true);
+		if (this._oTable && sOldMultiSelectMode != this.getMultiSelectMode()) {
+			this._updateMultiSelectMode();
+		}
+		return this;
+	};
+
 	Table.prototype.setRowAction = function(aActions) {
 		var aOldActions = this.getRowAction();
 
@@ -873,7 +940,7 @@ sap.ui.define([
 		var bOldEnableColumnResize = this.getEnableColumnResize();
 		this.setProperty("enableColumnResize", bEnableColumnResize, true);
 
-		if (bEnableColumnResize !== bOldEnableColumnResize) {
+		if (this.getEnableColumnResize() !== bOldEnableColumnResize) {
 			this._updateColumnResizer();
 			this._updateAdaptation(this.getP13nMode());
 		}
@@ -1023,6 +1090,7 @@ sap.ui.define([
 			}
 
 			oFilterInfoBar.setVisible(false);
+			oTable._oTable.removeAriaLabelledBy(oFilterInfoBarText);
 
 			return;
 		}
@@ -1035,7 +1103,11 @@ sap.ui.define([
 			var oListFormat = ListFormat.getInstance();
 			var sFilterText = oResourceBundle.getText("table.FILTER_INFO", oListFormat.format(aPropertyLabels));
 
-			oFilterInfoBar.setVisible(true);
+			if (!oFilterInfoBar.getVisible()) {
+				oFilterInfoBar.setVisible(true);
+				oTable._oTable.addAriaLabelledBy(oFilterInfoBarText);
+			}
+
 			oFilterInfoBarText.setText(sFilterText);
 		});
 	}
@@ -1054,10 +1126,12 @@ sap.ui.define([
 		if (oTable._bMobileTable) {
 			if (oTable._oTable.getInfoToolbar() !== oFilterInfoBar) {
 				oTable._oTable.setInfoToolbar(oFilterInfoBar);
-				oTable._oTable.addAriaLabelledBy(getFilterInfoBarText(oTable));
 			}
 		} else if (oTable._oTable.indexOfExtension(oFilterInfoBar) === -1) {
 			oTable._oTable.insertExtension(oFilterInfoBar, 1);
+		}
+
+		if (oFilterInfoBar.getVisible()) {
 			oTable._oTable.addAriaLabelledBy(getFilterInfoBarText(oTable));
 		}
 	}
@@ -1081,9 +1155,7 @@ sap.ui.define([
 					wrapping: false
 				})
 			],
-			press: function() {
-				TableSettings.showPanel(oTable, "Filter", oFilterInfoToolbar);
-			}
+			press: [onShowFilterDialog, oTable]
 		});
 
 		// If the toolbar is hidden while it has the focus, the focus moves to the body. This can happen, for example, when all filters are removed in
@@ -1312,6 +1384,12 @@ sap.ui.define([
 		return this;
 	};
 
+	Table.prototype.setShowRowCount = function(bShowCount) {
+		this.setProperty("showRowCount", bShowCount, true);
+		this._updateHeaderText();
+		return this;
+	};
+
 	Table.prototype.setEnableExport = function(bEnableExport) {
 		if (bEnableExport !== this.getEnableExport()) {
 			this.setProperty("enableExport", bEnableExport, true);
@@ -1341,6 +1419,10 @@ sap.ui.define([
 	};
 
 	Table.prototype._createToolbar = function() {
+		if (this.isDestroyStarted() || this.isDestroyed()) {
+			return;
+		}
+
 		if (!this._oToolbar) {
 			// Create Title
 			this._oTitle = new Title(this.getId() + "-title", {
@@ -1497,29 +1579,10 @@ sap.ui.define([
 		var aP13nMode = this.getP13nMode();
 		var aButtons = [];
 
-		// Order should be: Sort, Filter, Group and then Columns as per UX spec
-		if (this.isSortingEnabled() && !this._bNewP13n) {
-			aButtons.push(TableSettings.createSortButton(this.getId(), [
-				this._showSort, this
-			]));
-		}
-
-		if (this.isFilteringEnabled() && !this._bNewP13n) {
-			aButtons.push(TableSettings.createFilterButton(this.getId(), [
-				this._showFilter, this
-			]));
-		}
-
-		if (aP13nMode.indexOf("Column") > -1 || (this._bNewP13n && aP13nMode.length > 0)) {
-			aButtons.push(TableSettings.createColumnsButton(this.getId(), [
-				this._showSettings, this
-			]));
-		}
-
-		if (this.isGroupingEnabled() && !this._bNewP13n) {
-			aButtons.push(TableSettings.createGroupButton(this.getId(), [
-				this._showGroup, this
-			]));
+		// Note: 'Aggregate' does not have a p13n UI, if only 'Aggregate' is enabled no settings icon is necessary
+		var bAggregateP13nOnly = aP13nMode.length === 1 && aP13nMode[0] === "Aggregate";
+		if (aP13nMode.length > 0 && !bAggregateP13nOnly) {
+			aButtons.push(TableSettings.createSettingsButton(this.getId(), [onShowSettingsDialog, this]));
 		}
 
 		return aButtons;
@@ -1527,7 +1590,10 @@ sap.ui.define([
 
 	Table.prototype._getPasteButton = function() {
 		if (this.getShowPasteButton()) {
-			return this._oPasteButton || (this._oPasteButton = TableSettings.createPasteButton(this.getId()));
+			if (!this._oPasteButton) {
+				this._oPasteButton = TableSettings.createPasteButton(this.getId());
+			}
+			return this._oPasteButton;
 		}
 	};
 
@@ -1576,9 +1642,8 @@ sap.ui.define([
 	 * @private
 	 */
 	Table.prototype._updateExportState = function(bUpdateFilename) {
-		var oRowBinding = this._getRowBinding();
 		if (this._oExportButton) {
-			this._oExportButton.setEnabled(!!(oRowBinding && oRowBinding.getLength() > 0));
+			this._oExportButton.setEnabled(this._getRowCount(false) > 0);
 			if (bUpdateFilename && this._cachedExportSettings) {
 				this._cachedExportSettings.fileName = this.getHeader();
 			}
@@ -1815,6 +1880,9 @@ sap.ui.define([
 		// Update the selection handlers
 		this._updateSelectionBehavior();
 
+		// Update the multiSelectMode
+		this._updateMultiSelectMode();
+
 		var oDDI = new DragDropInfo({
 			sourceAggregation: "columns",
 			targetAggregation: "columns",
@@ -1862,6 +1930,12 @@ sap.ui.define([
 		oTableType.updateSelection(this);
 	};
 
+	Table.prototype._updateMultiSelectMode = function() {
+		if (this._bMobileTable) {
+			ResponsiveTableType.updateMultiSelectMode(this);
+		}
+	};
+
 	Table.prototype._onColumnRearrange = function(oEvent) {
 		var oDraggedColumn = oEvent.getParameter("draggedControl");
 		var oDroppedColumn = oEvent.getParameter("droppedControl");
@@ -1877,14 +1951,10 @@ sap.ui.define([
 	};
 
 	Table.prototype._onColumnPress = function(oColumn) {
-		var iIndex,
-			oParent = oColumn.getParent(),
-			oMDCColumn,
-			bResizeButton = window.matchMedia("(hover:none)").matches && this._bMobileTable && this.getEnableColumnResize();
-
-		iIndex = oParent.indexOfColumn(oColumn);
-
-		oMDCColumn = this.getColumns()[iIndex];
+		var oParent = oColumn.getParent(),
+			iIndex = oParent.indexOfColumn(oColumn),
+			oMDCColumn = this.getColumns()[iIndex],
+			bResizeButton = this._bMobileTable && this.getEnableColumnResize();
 
 		this._fullyInitialized().then(function() {
 			var oResourceBundle = Core.getLibraryResourceBundle("sap.ui.mdc");
@@ -1942,25 +2012,19 @@ sap.ui.define([
 				var oFilter = new ColumnPopoverSelectListItem({
 					label: oResourceBundle.getText("table.SETTINGS_FILTER"),
 					icon: "sap-icon://filter",
-					action: [this._showFilter, this]
+					action: [onShowFilterDialog, this]
 				});
 				aHeaderItems.unshift(oFilter);
 			}
 
 			if (bResizeButton) {
-				var oColumnResize = new ColumnPopoverActionItem({
-					text: oResourceBundle.getText("table.SETTINGS_RP_RESIZE"),
-					icon: "sap-icon://resize-horizontal",
-					press: [function() {
-						ResponsiveTableType.startColumnResize(this._oTable, oColumn);
-					}, this]
-				});
-				aHeaderItems.push(oColumnResize);
+				var oColumnResize = ResponsiveTableType.startColumnResize(this._oTable, oColumn);
+				oColumnResize && aHeaderItems.push(oColumnResize);
 			}
 
-			aHeaderItems && aHeaderItems.forEach(function(item) {
-				item && this._createPopover(item, oColumn);
-			}.bind(this));
+			aHeaderItems.forEach(function(oItem) {
+				this._createPopover(oItem, oColumn);
+			}, this);
 			this._oPopover && this._oPopover.openBy(oColumn);
 		}.bind(this));
 	};
@@ -2000,11 +2064,26 @@ sap.ui.define([
 		TableSettings.createAggregation(this, sSortProperty);
 	};
 
+	Table.prototype._setColumnWidth = function(oMDCColumn) {
+		if (!this.getEnableAutoColumnWidth() || oMDCColumn.getWidth() || oMDCColumn.isBound("width")) {
+			return;
+		}
+
+		var oPropertyHelper = this._oPropertyHelper;
+		if (oPropertyHelper) {
+			oPropertyHelper.setColumnWidth(oMDCColumn);
+		} else {
+			this.awaitPropertyHelper().then(this._setColumnWidth.bind(this, oMDCColumn));
+		}
+	};
+
 	Table.prototype._insertInnerColumn = function(oMDCColumn, iIndex) {
 		if (!this._oTable) {
 			return;
 		}
 
+		this._setColumnWidth(oMDCColumn);
+
 		var oColumn = this._createColumn(oMDCColumn);
 		setColumnTemplate(this, oMDCColumn, oColumn, iIndex);
 		this._bForceRebind = true;
@@ -2136,7 +2215,7 @@ sap.ui.define([
 		oMDCColumn = this.removeAggregation("columns", oMDCColumn, true);
 		if (this._oTable) {
 			var oColumn = this._oTable.removeColumn(oMDCColumn.getId() + "-innerColumn");
-			oColumn.destroy(); // TODO: avoid destroy
+			oColumn.destroy("KeepDom");
 
 			// update template for ResponsiveTable
 			if (this._bMobileTable) {
@@ -2326,12 +2405,7 @@ sap.ui.define([
 			return;
 		}
 
-		// TODO: Temporary, until the FE delegate calls updateBindingInfo on the the base delegate. See sap.ui.mdc.TableDelegate.updateBindingInfo
-		var oBindingInfo = {
-			parameters: {},
-			filters: [],
-			sorter: this._getSorters()
-		};
+		var oBindingInfo = {};
 
 		this.getControlDelegate().updateBindingInfo(this, this.getPayload(), oBindingInfo);
 
@@ -2398,9 +2472,9 @@ sap.ui.define([
 		if (this._oTitle && this.getHeader()) {
 			sHeader = this.getHeader();
 			if (this.getShowRowCount()) {
-				iRowCount = this._getRowCount();
-				var sValue = this._oNumberFormatInstance.format(iRowCount);
-				if (sValue) {
+				iRowCount = this._getRowCount(true);
+				if (iRowCount > 0) {
+					var sValue = this._oNumberFormatInstance.format(iRowCount);
 					sHeader += " (" + sValue + ")";
 				}
 			}
@@ -2428,7 +2502,7 @@ sap.ui.define([
 			var sText = this.getHeader();
 
 			// iRowCount will be undefined if table property showRowCount is set to false
-			if (iRowCount === undefined && this._getRowCount() > 0) {
+			if (iRowCount === undefined && this._getRowCount(false) > 0) {
 				oInvisibleMessage.announce(oResourceBundle.getText("table.ANNOUNCEMENT_TABLE_UPDATED", [sText]));
 			} else if (iRowCount > 1) {
 				oInvisibleMessage.announce(oResourceBundle.getText("table.ANNOUNCEMENT_TABLE_UPDATED_MULT", [sText, iRowCount]));
@@ -2473,19 +2547,25 @@ sap.ui.define([
 	 * @private
 	 * @returns {int} the row count
 	 */
-	Table.prototype._getRowCount = function() {
+	Table.prototype._getRowCount = function(bConsiderTotal) {
 		var oRowBinding = this._getRowBinding();
 
 		if (!oRowBinding) {
-			return 0;
+			return bConsiderTotal ? undefined : 0;
 		}
 
 		var iRowCount;
-
-		if (oRowBinding.getCount) {
-			iRowCount = oRowBinding.getCount();
-		} else if (oRowBinding.isLengthFinal()) {
+		if (!bConsiderTotal) {
 			iRowCount = oRowBinding.getLength();
+		} else {
+			if (typeof oRowBinding.getCount === 'function') {
+				iRowCount = oRowBinding.getCount();
+			} else if (oRowBinding.isLengthFinal()) {
+				// This branch is only fallback and for TreeBindings (TreeBindings should be excluded when MDCTable will support TreeBinding,
+				// see corresponding function in SmartTable for reference)
+				// ListBindings should in general get a getCount function in nearer future (5341464)
+				iRowCount = oRowBinding.getLength();
+			}
 		}
 
 		if (iRowCount < 0 || iRowCount === "0") {
@@ -2547,6 +2627,7 @@ sap.ui.define([
 		}
 	};
 
+	// TODO: Delete!
 	Table.prototype.rebindTable = function() {
 		this.rebind();
 	};
@@ -2560,27 +2641,13 @@ sap.ui.define([
 		}
 	};
 
-	/**
-	 * Just for test purpose --> has to be finalised
-	 *
-	 * @param {object} oEvt Event object that gets processed
-	 * @experimental
-	 */
-	Table.prototype._showSettings = function(oEvt) {
-		TableSettings.showPanel(this, "Columns", oEvt.getSource());
-	};
-
-	Table.prototype._showSort = function(oEvt) {
-		TableSettings.showPanel(this, "Sort", oEvt.getSource());
-	};
-
-	Table.prototype._showFilter = function(oEvt) {
-		TableSettings.showPanel(this, "Filter", oEvt.getSource());
-	};
+	function onShowSettingsDialog(oEvent) {
+		TableSettings.showPanel(this, "Columns", oEvent.getSource());
+	}
 
-	Table.prototype._showGroup = function (oEvt) {
-		TableSettings.showPanel(this, "Group", oEvt.getSource());
-	};
+	function onShowFilterDialog(oEvent) {
+		TableSettings.showPanel(this, "Filter", oEvent.getSource());
+	}
 
 	// TODO: move to a base util that can be used by most aggregations
 	Table.prototype._getSorters = function() {
@@ -2611,9 +2678,6 @@ sap.ui.define([
 			this._oTemplate.destroy();
 		}
 
-		//TODO: remove once new p13n is the default
-		this._bNewP13n = null;
-
 		this._oTemplate = null;
 		this._oTable = null;
 		// Destroy toolbar if Table is not yet created, normally it is destroyed automatically due to table being destroyed!

package/src/sap/ui/mdc/TableDelegate.js

@@ -9,8 +9,8 @@
 // ---------------------------------------------------------------------------------------
 // ---------------------------------------------------------------------------------------
 sap.ui.define([
-	"sap/ui/mdc/AggregationBaseDelegate"
-], function(AggregationBaseDelegate) {
+	"sap/ui/mdc/AggregationBaseDelegate", "sap/ui/core/library", "sap/ui/core/Core"
+], function(AggregationBaseDelegate, coreLibrary, Core) {
 	"use strict";
 
 	/**
@@ -25,26 +25,22 @@ sap.ui.define([
 	 */
 	var TableDelegate = Object.assign({}, AggregationBaseDelegate);
 
-	TableDelegate.addItem = function(sPropertyName, oTable, mPropertyBag) {
-		return Promise.resolve(null);
-	};
-
-	TableDelegate.removeItem = function(sPropertyName, oTable, mPropertyBag) {
-		// return true within the Promise for default behaviour (e.g. continue to destroy the column)
-		return Promise.resolve(true);
-	};
-
 	/**
 	 * Provides hook to update the binding info object that is used to bind the table to the model.
 	 *
-	 * @abstract
 	 * @param {sap.ui.mdc.Table} oMDCTable The MDC table instance
 	 * @param {object} oDelegatePayload The delegate payload
 	 * @param {sap.ui.base.ManagedObject.AggregationBindingInfo} oBindingInfo The binding info object to be used to bind the table to the model
+	 * @protected
 	 */
 	TableDelegate.updateBindingInfo = function(oMDCTable, oDelegatePayload, oBindingInfo) {
 		oBindingInfo.parameters = {};
-		oBindingInfo.filters = [];
+
+		if (oMDCTable._oMessageFilter) {
+			oBindingInfo.filters = [oMDCTable._oMessageFilter];
+		} else {
+			oBindingInfo.filters = [];
+		}
 		oBindingInfo.sorter = oMDCTable._getSorters();
 	};
 
@@ -53,20 +49,33 @@ sap.ui.define([
 	 *
 	 * The default implementation rebinds the table but model-specific subclasses must call dedicated binding methods to update the binding instead of using {@link #rebindTable}.
 	 *
-	 * @virtual
 	 * @param {sap.ui.mdc.Table} oMDCTable The MDC table instance
 	 * @param {sap.ui.base.ManagedObject.AggregationBindingInfo} oBindingInfo The binding info object to be used to bind the table to the model
 	 * @param {sap.ui.model.ListBinding} [oBinding] The binding instance of the table
+	 * @protected
 	 */
 	TableDelegate.updateBinding = function(oMDCTable, oBindingInfo, oBinding) {
 		this.rebindTable(oMDCTable, oBindingInfo);
 	};
 
+	TableDelegate.validateState = function(oControl, oState, sKey) {
+		if (sKey == "Filter" && oControl._oMessageFilter) {
+			var oResourceBundle = Core.getLibraryResourceBundle("sap.ui.mdc");
+			return {
+				validation: coreLibrary.MessageType.Information,
+				message: oResourceBundle.getText("table.PERSONALIZATION_DIALOG_FILTER_MESSAGESTRIP")
+			};
+		}
+
+		return  AggregationBaseDelegate.validateState.apply(this, arguments);
+	};
+
 	/**
 	 * Rebinds the table.
 	 *
 	 * @param {sap.ui.mdc.Table} oMDCTable The MDC table instance
 	 * @param {sap.ui.base.ManagedObject.AggregationBindingInfo} oBindingInfo The binding info object to be used to bind the table to the model
+	 * @protected
 	 */
 	TableDelegate.rebindTable = function(oMDCTable, oBindingInfo) {
 		if (oMDCTable._oTable) {
@@ -86,18 +95,18 @@ sap.ui.define([
 	 * 			return oFilterFieldPromise;
 	 * 		}
 	 * }
-	 * @returns {Object} Object for the tables filter personalization
-	 * @public
+	 * @returns {{addItem: (function(string, sap.ui.mdc.Table): Promise<sap.ui.mdc.FilterField>)}} Object for the tables filter personalization
+	 * @protected
 	 */
 	TableDelegate.getFilterDelegate = function() {
 		return {
 			/**
+			 * Creates an instance of a <code>sap.ui.mdc.FilterField</code>.
 			 *
-			 * @param {String} sPropertyName The property name
-			 * @param {Object} oTable Instance of the table
-			 *
-			 * @returns {Promise} Promise that resolves with an instance of a <code>sap.ui.mdc.FilterField</code>.
-			 * For more information, see {@link sap.ui.mdc.AggregationBaseDelegate#addItem AggregationBaseDelegate}.
+			 * @param {string} sPropertyName The property name
+			 * @param {sap.ui.mdc.Table} oTable Instance of the table
+			 * @returns {Promise<sap.ui.mdc.FilterField>} Promise that resolves with an instance of a <code>sap.ui.mdc.FilterField</code>.
+			 * @see sap.ui.mdc.AggregationBaseDelegate#addItem
 			 */
 			addItem: function(sPropertyName, oTable) {
 				return Promise.resolve(null);