@openui5/sap.ui.core 1.92.0 → 1.93.3

package/src/sap/ui/core/routing/async/Target.js

@@ -5,12 +5,11 @@
  */
 sap.ui.define([
 	"sap/base/Log",
-	"sap/ui/core/Component",
-	"sap/ui/core/UIComponent",
+	"sap/ui/base/ManagedObjectMetadata",
 	"sap/ui/core/ComponentContainer",
 	"sap/ui/core/Placeholder",
 	"sap/ui/core/library"
-], function(Log, Component, UIComponent, ComponentContainer, Placeholder, coreLib) {
+], function(Log, ManagedObjectMetadata, ComponentContainer, Placeholder, coreLib) {
 	"use strict";
 
 	// shortcut for sap.ui.core.ComponentLifecycle
@@ -85,6 +84,32 @@ sap.ui.define([
 				Log.warning("The target with name '" + this._oOptions._name + "' can't be suspended because it's being loaded or not loaded yet");
 			}
 
+			return this;
+		},
+
+		/**
+		 * Resumes the object which is loaded by the target.
+		 *
+		 * Currently this function initializes the router of the component without parsing the current hash when
+		 * the object which is loaded by this target is an instance of
+		 * UIComponent.
+		 *
+		 * @return {sap.ui.core.routing.Target} The 'this' to chain the call
+		 * @private
+		 */
+		resume: function() {
+			if (this._oParent) {
+				this._oParent.resume();
+			}
+
+			if (this._isLoaded()) {
+				var oObject = this._get(),
+					oRouter;
+
+				if (oObject.isA("sap.ui.core.UIComponent") && (oRouter = oObject.getRouter()) && oObject.hasNativeRouter()) {
+					oRouter.initialize(true);
+				}
+			}
 
 			return this;
 		},
@@ -221,7 +246,7 @@ sap.ui.define([
 					fnResolve = resolve;
 				});
 				if (bIsComponentTarget) {
-					oTargetCreateInfo.componentId = that._oOptions.id || UIComponent.getMetadata().uid();
+					oTargetCreateInfo.componentId = that._oOptions.id || ManagedObjectMetadata.uid("uicomponent");
 				}
 				pLoaded = this._load(oTargetCreateInfo).then(function (oObject) {
 					if (oObject.isA("sap.ui.core.UIComponent")) {

package/src/sap/ui/core/routing/sync/Target.js

@@ -50,6 +50,21 @@ sap.ui.define(["sap/base/Log"], function(Log) {
 			return this;
 		},
 
+		/**
+		 * Resumes the object which is loaded by the target.
+		 *
+		 * Currently this function doesn't do anything because the sync
+		 * version of the Target can only load Views but no Components.
+		 *
+		 * @return {sap.ui.core.routing.Target} The 'this' to chain the call
+		 * @private
+		 */
+		resume : function () {
+			// the sync target can only load view and not component
+			// therefore it's not needed to do anything in this function
+			return this;
+		},
+
 		/**
 		 * Places the target on the screen
 		 *

package/src/sap/ui/core/rules/App.support.js

@@ -439,5 +439,39 @@ sap.ui.define(["sap/ui/support/library", "sap/ui/core/mvc/View", "sap/ui/core/mv
 		}
 	};
 
-	return [oControllerSyncCodeCheckRule, oGlobalAPIRule, oJquerySapRule, oSyncFactoryLoadingRule, oGlobalSyncXhrRule, oDeprecatedAPIRule, oControllerExtensionRule, oJQueryThreeDeprecationRule, oMissingSuperInitRule, oJSViewRule];
+	/**
+	 * Checks for missing super constructor calls on sap.ui.core.Component and sap.ui.core.mvc.Controller.
+	 */
+	 var oMissingSuperConstructorRule = {
+		id: "missingSuperConstructor",
+		audiences: [Audiences.Application, Audiences.Control, Audiences.Internal],
+		categories: [Categories.Functionality],
+		enabled: true,
+		minversion: "1.93",
+		title: "Missing super constructor call",
+		description: "A sub-class of sap.ui.core.Component or sap.ui.core.mvc.Controller which overrides the constructor must apply the super constructor as well.",
+		resolution: "A bound call to sap.ui.core.Component or sap.ui.core.mvc.Controller must be introduced in the sub-class.",
+		resolutionurls: [{
+			text: "API Documentation: sap.ui.core.mvc.Controller",
+			href: "https://openui5.hana.ondemand.com/api/sap.ui.core.mvc.Controller"
+		},
+		{
+			text: "API Documentation: sap.ui.core.Component",
+			href: "https://openui5.hana.ondemand.com/api/sap.ui.core.Component"
+		}],
+		check: function(oIssueManager, oCoreFacade, oScope) {
+			var oLoggedObjects = oScope.getLoggedObjects("missingSuperConstructor");
+			oLoggedObjects.forEach(function(oLoggedObject) {
+				oIssueManager.addIssue({
+					severity: Severity.High,
+					details: oLoggedObject.message,
+					context: {
+						id: "WEBPAGE"
+					}
+				});
+			});
+		}
+	};
+
+	return [oControllerSyncCodeCheckRule, oGlobalAPIRule, oJquerySapRule, oSyncFactoryLoadingRule, oGlobalSyncXhrRule, oDeprecatedAPIRule, oControllerExtensionRule, oJQueryThreeDeprecationRule, oMissingSuperInitRule, oMissingSuperConstructorRule, oJSViewRule];
 }, true);

package/src/sap/ui/core/search/OpenSearchProvider.js

@@ -26,7 +26,7 @@ sap.ui.define([
 	 * @class
 	 * A SearchProvider which uses the OpenSearch protocol (either JSON or XML).
 	 * @extends sap.ui.core.search.SearchProvider
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @public
 	 * @alias sap.ui.core.search.OpenSearchProvider

package/src/sap/ui/core/search/SearchProvider.js

@@ -23,7 +23,7 @@ sap.ui.define(['sap/ui/core/Element', "sap/base/Log", 'sap/ui/core/library'],
 	 *
 	 * Do not create instances of this class, but use a concrete subclass instead.
 	 * @extends sap.ui.core.Element
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @public
 	 * @alias sap.ui.core.search.SearchProvider

package/src/sap/ui/core/service/Service.js

@@ -71,7 +71,7 @@ sap.ui.define(['sap/ui/base/Object', "sap/base/assert", "sap/base/Log"],
 	 *
 	 * @extends sap.ui.base.Object
 	 * @author SAP SE
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @alias sap.ui.core.service.Service
 	 * @abstract
 	 * @private

package/src/sap/ui/core/service/ServiceFactory.js

@@ -83,7 +83,7 @@ sap.ui.define(['sap/ui/base/Object', 'sap/ui/core/service/Service', "sap/base/as
 	 *
 	 * @extends sap.ui.base.Object
 	 * @author SAP SE
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @alias sap.ui.core.service.ServiceFactory
 	 * @private
 	 * @ui5-restricted sap.ushell

package/src/sap/ui/core/service/ServiceFactoryRegistry.js

@@ -18,7 +18,7 @@ sap.ui.define(['./ServiceFactory', "sap/base/assert"],
 	 * The service factory registry.
 	 *
 	 * @author SAP SE
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @alias sap.ui.core.service.ServiceFactoryRegistry
 	 * @private
 	 * @ui5-restricted sap.ushell

package/src/sap/ui/core/support/Plugin.js

@@ -17,7 +17,7 @@ sap.ui.define(['sap/ui/base/Object', "sap/ui/thirdparty/jquery", "sap/base/util/
 	 *
 	 * @abstract
 	 * @extends sap.ui.base.Object
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @private
 	 * @ui5-restricted
 	 * @alias sap.ui.core.support.Plugin

package/src/sap/ui/core/support/Support.js

@@ -26,7 +26,7 @@ sap.ui.define(['sap/ui/base/EventProvider', './Plugin', "sap/base/util/UriParame
 	 * @class This class provides the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 	 *
 	 * @extends sap.ui.base.EventProvider
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @private
 	 * @alias sap.ui.core.support.Support
 	 */

package/src/sap/ui/core/support/controls/ObjectViewer.js

@@ -322,18 +322,14 @@ function(ManagedObject, encodeXML) {
 			this._oRenderParent.firstChild.addEventListener("change", function(oEvent) {
 
 				var oDomRef = oEvent.target,
-					bResult = false,
 					aReasons = [],
 					sValue = [oDomRef.value, oDomRef];
-				while (!bResult) {
-					if (oDomRef.getAttribute("raise")) {
-						if (oDomRef.getAttribute("args")) {
-							var aArgs = oDomRef.getAttribute("args").split(",");
-							aArgs = aArgs.concat(aReasons,sValue);
-							bResult = that[oDomRef.getAttribute("raise")].apply(that, aArgs);
-						}
+				if (oDomRef.getAttribute("raise")) {
+					if (oDomRef.getAttribute("args")) {
+						var aArgs = oDomRef.getAttribute("args").split(",");
+						aArgs = aArgs.concat(aReasons,sValue);
+						that[oDomRef.getAttribute("raise")].apply(that, aArgs);
 					}
-					break;
 				}
 			});
 			this._oRenderParent.firstChild.addEventListener("mouseout", function(oEvent) {

package/src/sap/ui/core/support/plugins/ControlTree.js

@@ -49,7 +49,7 @@ sap.ui.define([
 		 * @class This class represents the ControlTree plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.ControlTree
 		 */

package/src/sap/ui/core/support/plugins/Interaction.js

@@ -38,7 +38,7 @@ sap.ui.define([
 		 * With this plugIn the performance measurements are displayed
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.Interaction
 		 */

package/src/sap/ui/core/support/plugins/LocalStorage.js

@@ -15,7 +15,7 @@ sap.ui.define(['sap/ui/core/support/Plugin', "sap/base/Log"],
 		 * @class This class represents the LocalStorage plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.LocalStorage
 		 */

package/src/sap/ui/core/support/plugins/MessageTest.js

@@ -20,7 +20,7 @@ sap.ui.define([
 		 * This class is only for testing purposes for support tool communication.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.MessageTest
 		 */

package/src/sap/ui/core/support/plugins/Performance.js

@@ -55,7 +55,7 @@ sap.ui.define([
 		 * With this plugIn the performance measurements are displayed
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.Performance
 		 */

package/src/sap/ui/core/support/plugins/Selector.js

@@ -24,7 +24,7 @@ sap.ui.define([
 		 * @class This class represents the selector plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.Selector
 		 */

package/src/sap/ui/core/support/plugins/TechInfo.js

@@ -23,7 +23,7 @@ sap.ui.define([
 		 * @class This class represents the technical info plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.TechInfo
 		 */

package/src/sap/ui/core/support/plugins/Trace.js

@@ -19,7 +19,7 @@ sap.ui.define([
 		 * @class This class represents the trace plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 *
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.Trace
 		 */

package/src/sap/ui/core/support/plugins/ViewInfo.js

@@ -20,7 +20,7 @@ sap.ui.define([
 		 * Creates an instance of sap.ui.core.support.plugins.ViewInfo.
 		 * @class This class represents the ViewInfo plugin for the support tool functionality of UI5. This class is internal and all its functions must not be used by an application.
 		 * @extends sap.ui.core.support.Plugin
-		 * @version 1.92.0
+		 * @version 1.93.3
 		 * @private
 		 * @alias sap.ui.core.support.plugins.ViewInfo
 		 */

package/src/sap/ui/core/support/trace/E2eTraceLib.js

@@ -213,8 +213,8 @@ sap.ui.define(['sap/ui/Device', 'sap/ui/performance/trace/Passport', 'sap/base/L
 						} else {
 							// alternatively allow upload via form
 							try {
-								var bDone = true;
-								while (bDone) {
+								var bDone = false;
+								while (!bDone) {
 
 									/*eslint-disable no-alert */
 									var sUrl = window.prompt('Please enter a valid URL for the store server', 'http://<host>:<port>');
@@ -232,7 +232,7 @@ sap.ui.define(['sap/ui/Device', 'sap/ui/performance/trace/Passport', 'sap/base/L
 										xmlHttpPost.open("POST", sUrl + '/E2EClientTraceUploadW/UploadForm.jsp', false);
 										xmlHttpPost.setRequestHeader('Content-type', 'multipart/form-data; boundary="' + boundary + '"');
 										xmlHttpPost.send(postBody);
-										break;
+										bDone = true;
 									}
 								}
 							} catch (ex) {

package/src/sap/ui/core/themes/base/LocalBusyIndicator.less

@@ -43,6 +43,11 @@
 	display: none;
 }
 
+.sapUiBlockLayer.sapUiPlaceholder {
+	display: block;
+	z-index: 1;
+}
+
 //  Make sure blocked layers are not "nested", and in case of busy indicators the animations do not overlay each other
 .sapUiLocalBusy .sapUiLocalBusy .sapUiBlockLayer {
 	display: none;

package/src/sap/ui/core/themes/base/SAP-icons.css

@@ -1,5 +1,7 @@
 /**
  * Do NOT use any LESS syntax in this file because it may be used externally without UI5
+ *
+ * NOTE: This file must be kept in sync with SAP-icons.less
  */
 @font-face {
 	font-family: "SAP-icons";

package/src/sap/ui/core/themes/base/SAP-icons.less

@@ -0,0 +1,10 @@
+// NOTE: This file must be kept in sync with SAP-icons.css
+
+@font-face {
+	font-family: "SAP-icons";
+	src:
+		@sapUiIconFontUrl format('woff2'),
+		local('SAP-icons'); /* fallback to local installed font in case it can't be loaded (e.g. font download is disabled due to browser security settings) */
+	font-weight: normal;
+	font-style: normal;
+}