@openui5/sap.ui.core 1.92.0 → 1.93.3

package/src/sap/ui/core/mvc/Controller.js

@@ -84,6 +84,7 @@ sap.ui.define([
 				this["_sapui_Extensions"] = {};
 				Controller.extendByMember(this, false);
 				this._sapui_isExtended = false;
+				this._aDestroyables = [];
 			},
 			/**
 			 * Wether a controller is extended or not
@@ -595,16 +596,60 @@ sap.ui.define([
 			return mPublicFunctions;
 		};
 
+		/**
+		 * Returns the list of Promises for which an automatic destroy is scheduled.
+		 * Logs an error in case the application controller is missing a mandatory
+		 * constructor super call.
+		 * For compatibility reason we must not fail in this obviously broken scenario!
+		 *
+		 * @private
+		 */
+		Controller.prototype._getDestroyables = function() {
+			if (!this._aDestroyables) {
+				Log.error("Mandatory super constructor not called for Controller: '" + this.getMetadata().getName() + "'.",
+					null,
+					"sap.ui.support",
+					function() {
+						return { type: "missingSuperConstructor" };
+					});
+				this._aDestroyables = [];
+			}
+			return this._aDestroyables;
+		};
+
+		/**
+		 * Takes care of async destruction of fragments created with {@link sap.ui.core.Controller.loadFragment loadFragment}
+		 *
+		 * @private
+		 */
+		Controller.prototype.destroyFragments = function() {
+			function fnDestroy(vContent) {
+				vContent = Array.isArray(vContent) ? vContent : [vContent];
+				for (var i = 0; i < vContent.length; i++) {
+					if (!vContent[i].isDestroyed()) {
+						vContent[i].destroy();
+					}
+				}
+			}
+			// chain each cancelable to trigger an async destroy
+			var aDestroyables = this._getDestroyables();
+			for (var i = 0; i < aDestroyables.length; i++ ) {
+				aDestroyables[i] = aDestroyables[i].then(fnDestroy);
+			}
+		};
+
 		/**
 		 * Fire event when destroying a controller to cleanup extensions
 		 * @private
 		 */
 		Controller.prototype.destroy = function() {
-			Object.keys(this["_sapui_Extensions"]).forEach(function(oExtensionInfo) {
-				ObjectPath.set(oExtensionInfo.location, null, this);
-			}.bind(this));
-			delete this["_sapui_Extensions"];
-			delete this["_sapui_Interface"];
+			if (this["_sapui_Extensions"]) {
+				Object.keys(this["_sapui_Extensions"]).forEach(function(sKey) {
+					var oExtensionInfo = this["_sapui_Extensions"][sKey];
+					ObjectPath.set(oExtensionInfo.location, null, this);
+				}.bind(this));
+				delete this["_sapui_Extensions"];
+			}
 			EventProvider.prototype.destroy.apply(this, arguments);
 		};
 
@@ -661,8 +706,12 @@ sap.ui.define([
 		 * @public
 		 */
 		Controller.prototype.getOwnerComponent = function () {
-			var Component = sap.ui.requireSync("sap/ui/core/Component");
-			return Component.getOwnerComponentFor(this.getView());
+			var Component = sap.ui.require("sap/ui/core/Component");
+			if (Component) {
+				return Component.getOwnerComponentFor(this.getView());
+			} else {
+				return undefined;
+			}
 		};
 
 
@@ -674,6 +723,9 @@ sap.ui.define([
 			}
 			if (this.onExit) {
 				oView.attachBeforeExit(this.onExit, this);
+				if (oView.bControllerIsViewManaged) {
+					oView.attachBeforeExit(this.destroyFragments, this);
+				}
 			}
 			if (this.onAfterRendering) {
 				oView.attachAfterRendering(this.onAfterRendering, this);
@@ -681,9 +733,95 @@ sap.ui.define([
 			if (this.onBeforeRendering) {
 				oView.attachBeforeRendering(this.onBeforeRendering, this);
 			}
-			//oView.addDelegate(this);
 		};
 
+		/**
+		 * Loads a Fragment by {@link sap.ui.core.Fragment.load}. If the controller will be destroyed before
+		 * the fragment content creation is done, the controller takes care of an asynchronous destroy of the
+		 * fragment content.
+		 * Otherwise the content must be destroyed by the caller as usual.
+		 * If the controller has an owner component, it is passed to the fragment content.
+		 * The fragment content will be prefixed with the view ID to avoid duplicate ID issues.
+		 * The prefixing is enabled by default and can be switched off by the <code>autoPrefixId</code> option.
+		 *
+		 * When <code>autoPrefixId</code> is enabled, the fragment content can be accessed by calling {@link sap.ui.core.mvc.Controller.byId}.
+		 *
+		 * Example (no mOptions.id given):
+		 * var myCOntrol = this.byId("myControl");
+		 *
+		 * Example (mOptions.id given):
+		 * var myCOntrol = this.byId("prefix--myControl");
+		 *
+		 * The fragment content will be added to the <code>dependents</code> aggregation of the view by default.
+		 * This behavior can be suppressed by setting <code>mOptions.addToDependents</code> to false.
+		 *
+		 * Note: If the fragment content is not aggregated within a control, it must be destroyed manually in
+		 * the exit hook of the controller.
+		 *
+		 * The controller is passed to the Fragment by default so the (event handler) methods referenced in the Fragment will
+		 * be called on this Controller.
+		 *
+		 * @param {object} mOptions Options regarding fragment loading
+		 * @param {string} mOptions.name The Fragment name, which must correspond to a Fragment which can be loaded via the module system
+		 *    (fragmentName + suffix ".fragment.[typeextension]") and which contains the Fragment definition.
+		 * @param {object} [mOptions.addToDependents=true] Whether the fragment content should be added to the <code>dependents</code> aggregation of the view
+		 * @param {object} [mOptions.autoPrefixId=true] Whether the IDs of the fragment content will be prefixed by the view ID
+		 * @param {string} [mOptions.id] the ID of the Fragment
+		 * @param {string} [mOptions.type=XML] the Fragment type, e.g. "XML", "JS", or "HTML" (see above). Default is "XML"
+		 * @return {Promise} A Promise that resolves with the fragment content
+		 *
+		 * @since 1.93
+		 * @public
+		 */
+		Controller.prototype.loadFragment = function(mOptions) {
+			if (!this.getView()) {
+				throw new Error("Calling 'loadFragment' without a view attached is not supported!");
+			} else if (!mOptions || !mOptions.name) {
+				throw new Error("oOptions must provide at least a fragment name!");
+			}
+
+			var oOwnerComponent = this.getOwnerComponent();
+			var bAddToDependents = mOptions.addToDependents !== false;
+			var bAutoPrefixId = mOptions.autoPrefixId !== false;
+
+			var oFragmentOptions = {
+				name: mOptions.name,
+				type: mOptions.type,
+				id: mOptions.id,
+				controller: this
+			};
+
+			var aDestroyables = this._getDestroyables();
+
+			var pRequire = new Promise(function(resolve, reject) {
+				sap.ui.require(["sap/ui/core/Fragment"], function(Fragment) {
+					resolve(Fragment);
+				}, reject);
+			}).then(function(Fragment) {
+				if (!mOptions.id && bAutoPrefixId) {
+					oFragmentOptions.id = this.getView().getId();
+				} else if (bAutoPrefixId) {
+					oFragmentOptions.id = this.createId(mOptions.id);
+				}
+				if (oOwnerComponent) {
+					return oOwnerComponent.runAsOwner(function() {
+						return Fragment.load(oFragmentOptions);
+					});
+				} else {
+					return Fragment.load(oFragmentOptions);
+				}
+			}.bind(this)).then(function(vContent) {
+				if (bAddToDependents) {
+					this.getView().applySettings({"dependents": vContent});
+				}
+				/* if already resolved remove from bookkeeping. App needs to destroy or it is
+				implicitly destroyed via the dependents (or other) aggregation */
+				aDestroyables.splice(aDestroyables.indexOf(pRequire),1);
+				return vContent;
+			}.bind(this));
+			aDestroyables.push(pRequire);
+			return pRequire;
+		};
 
 		/**
 		 * Global extension provider name which will be used to create the

package/src/sap/ui/core/mvc/HTMLView.js

@@ -45,7 +45,7 @@ sap.ui.define([
 	 * @extends sap.ui.core.mvc.View
 	 *
 	 * @author SAP SE
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @public
 	 * @since 1.9.2
@@ -121,6 +121,8 @@ sap.ui.define([
 	/**
 	 * Flag for feature detection of asynchronous loading/rendering
 	 * @public
+	 * @readonly
+	 * @type {boolean}
 	 * @since 1.30
 	 */
 	HTMLView.asyncSupport = true;

package/src/sap/ui/core/mvc/JSONView.js

@@ -43,7 +43,7 @@ sap.ui.define([
 	 * @class
 	 * A View defined using JSON.
 	 * @extends sap.ui.core.mvc.View
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @public
 	 * @alias sap.ui.core.mvc.JSONView
@@ -132,10 +132,12 @@ sap.ui.define([
 	JSONView._sType = ViewType.JSON;
 
 	/**
-	* Flag for feature detection of asynchronous loading/rendering
-	* @public
-	* @since 1.30
-	*/
+	 * Flag for feature detection of asynchronous loading/rendering.
+	 * @public
+	 * @readonly
+	 * @type {boolean}
+	 * @since 1.30
+	 */
 	JSONView.asyncSupport = true;
 
 	JSONView.prototype.initViewSettings = function(mSettings) {

package/src/sap/ui/core/mvc/JSView.js

@@ -27,7 +27,7 @@ sap.ui.define([
 	 * @param {object} [mSettings] initial settings for the new control
 	 *
 	 * @extends sap.ui.core.mvc.View
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @deprecated Since 1.90. Instead use {@link topic:e6bb33d076dc4f23be50c082c271b9f0 Typed Views}
 	 * by defining the view class with {@link sap.ui.core.mvc.View.extend View.extend} and
 	 * creating the view instances with {@link sap.ui.core.mvc.View.create View.create}.
@@ -62,8 +62,10 @@ sap.ui.define([
 
 
 	/**
-	 * Flag for feature detection of asynchronous loading/rendering
+	 * Flag for feature detection of asynchronous loading/rendering.
 	 * @public
+	 * @readonly
+	 * @type {boolean}
 	 * @since 1.30
 	 */
 	JSView.asyncSupport = true;

package/src/sap/ui/core/mvc/TemplateView.js

@@ -29,7 +29,7 @@ function(View, TemplateViewRenderer, ViewType, Log) {
 	 * @extends sap.ui.core.mvc.View
 	 *
 	 * @author SAP SE
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @public
 	 * @deprecated Since version 1.56.0, use {@link sap.ui.core.mvc.XMLView} in combination with

package/src/sap/ui/core/mvc/View.js

@@ -140,7 +140,7 @@ sap.ui.define([
 	 * The default implementation of this method returns <code>false</code>.
 	 *
 	 * @extends sap.ui.core.Control
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @public
 	 * @alias sap.ui.core.mvc.View
@@ -442,6 +442,7 @@ sap.ui.define([
 				bAsync = mSettings.async;
 
 			if (!oController && oThis.getControllerName) {
+				oThis.bControllerIsViewManaged = true;
 				// get optional default controller name
 				var defaultController = oThis.getControllerName();
 				if (defaultController) {
@@ -474,6 +475,7 @@ sap.ui.define([
 					}
 				}
 			} else if (oController) {
+				oThis.bControllerIsViewManaged = false;
 				// if passed controller is not extended yet we need to do it.
 				var sOwnerId = ManagedObject._sOwnerId;
 				if (!oController._isExtended()) {
@@ -742,7 +744,10 @@ sap.ui.define([
 	 */
 	View.prototype.exit = function() {
 		this.fireBeforeExit();
-		delete this.oController;
+		if (this.oController && this.bControllerIsViewManaged) {
+			this.oController.destroy();
+			delete this.oController;
+		}
 		delete this.oPreprocessorInfo;
 		if (this.oAsyncState) {
 			var fnDelete = deleteAsyncState.bind(this);
@@ -1114,6 +1119,7 @@ sap.ui.define([
 	 * @private
 	 * @ui5-restricted sap.ui.core
 	 * @see {sap.ui.view}
+	 * @function
 	 */
 	View._create = viewFactory;
 
@@ -1274,6 +1280,9 @@ sap.ui.define([
 
 		// view creation
 		if (sViewClass) {
+			if (oViewSettings.type) {
+				Log.error("When using the view factory, the 'type' setting must be omitted for typed views. When embedding typed views in XML, don't use the <JSView> tag, use the <View> tag instead.");
+			}
 			return sViewClass;
 		}
 		if (!oViewSettings.type) {
@@ -1448,17 +1457,19 @@ sap.ui.define([
 		};
 
 		return ManagedObject.runWithPreprocessors(function() {
+			var vContent = this.createContent(oController);
 			if (mSettings.async) {
-				var vContent = this.createContent(oController);
-				vContent = vContent instanceof Promise ? vContent : Promise.resolve(vContent);
+				vContent = Promise.resolve(vContent);
 				return vContent.then(function(vContent) {
 					this.applySettings({
 						content : vContent
 					});
 				}.bind(this));
+			} else if (vContent instanceof Promise) {
+				throw new Error("An asynchronous view (createContent) cannot be instantiated synchronously. Affected view: '" + this.getMetadata().getName() + "'.");
 			} else {
 				this.applySettings({
-					content : this.createContent(oController)
+					content : vContent
 				});
 			}
 		}.bind(this), mPreprocessorSettings);

package/src/sap/ui/core/mvc/ViewType.js

@@ -11,6 +11,8 @@ sap.ui.define([], function () {
 	/**
 	 * Specifies possible view types.
 	 *
+	 * <b>Note:</b> Typed views do not rely on a <code>ViewType</code>, it must be omitted in the view settings.
+	 *
 	 * @enum {string}
 	 * @public
 	 * @alias sap.ui.core.mvc.ViewType

package/src/sap/ui/core/mvc/XMLView.js

@@ -96,7 +96,7 @@ sap.ui.define([
 	 * control's dependents aggregation or add it by using {@link sap.ui.core.mvc.XMLView#addDependent}.
 	 *
 	 * @extends sap.ui.core.mvc.View
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @public
 	 * @alias sap.ui.core.mvc.XMLView
@@ -260,6 +260,8 @@ sap.ui.define([
 	/**
 	 * Flag for feature detection of asynchronous loading/rendering
 	 * @public
+	 * @readonly
+	 * @type {boolean}
 	 * @since 1.30
 	 */
 	XMLView.asyncSupport = true;
@@ -350,15 +352,17 @@ sap.ui.define([
 		var Component = sap.ui.require("sap/ui/core/Component"),
 			oComponent;
 
-		while (oSrcElement && Component) {
-			var oCandidateComponent = Component.getOwnerComponentFor(oSrcElement);
-			if (oCandidateComponent) {
-				oSrcElement = oComponent = oCandidateComponent;
-			} else {
-				if (oSrcElement instanceof Component) {
-					oComponent = oSrcElement;
+		if (Component) {
+			while (oSrcElement) {
+				var oCandidateComponent = Component.getOwnerComponentFor(oSrcElement);
+				if (oCandidateComponent) {
+					oSrcElement = oComponent = oCandidateComponent;
+				} else {
+					if (oSrcElement instanceof Component) {
+						oComponent = oSrcElement;
+					}
+					oSrcElement = oSrcElement.getParent && oSrcElement.getParent();
 				}
-				oSrcElement = oSrcElement.getParent && oSrcElement.getParent();
 			}
 		}
 		return oComponent;

package/src/sap/ui/core/plugin/DeclarativeSupport.js

@@ -21,7 +21,7 @@ sap.ui.define([
 	 * @see sap.ui.core.DeclarativeSupport
 	 * @public
 	 * @since 1.7.0
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @alias sap.ui.core.plugin.DeclarativeSupport
 	 */
 	var DeclarativeSupportPlugin = function() {

package/src/sap/ui/core/plugin/LessSupport.js

@@ -37,7 +37,7 @@
 			 *        feature - DO NOT USE IN PRODUCTIVE SCENARIOS!!
 			 *
 			 * @author Peter Muessig
-			 * @version 1.92.0
+			 * @version 1.93.3
 			 * @private
 			 * @alias sap.ui.core.plugin.LessSupport
 			 */

package/src/sap/ui/core/plugin/TemplatingSupport.js

@@ -20,7 +20,7 @@ sap.ui.define([
 	 * @author Peter Muessig
 	 * @public
 	 * @since 1.15.0
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @alias sap.ui.core.plugin.TemplatingSupport
 	 */
 	var TemplatingSupport = function() {

package/src/sap/ui/core/postmessage/Bus.js

@@ -38,7 +38,7 @@ function (
 	 * @alias sap.ui.core.postmessage.Bus
 	 * @author SAP SE
 	 * @since 1.56.0
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 * @private
 	 * @ui5-restricted sap.ui.core.support, sap.ui.support, sap.ui.rta
 	 */

package/src/sap/ui/core/postmessage/confirmationDialog.js

@@ -13,7 +13,7 @@ sap.ui.define(function () {
 	 *
 	 * @author SAP SE
 	 * @since 1.56.0
-	 * @version 1.92.0
+	 * @version 1.93.3
 	 *
 	 * @function
 	 * @param {string} sMessage - Dialog message

package/src/sap/ui/core/routing/History.js

@@ -7,9 +7,8 @@ sap.ui.define([
 	'sap/ui/core/library',
 	'./HashChanger',
 	"sap/base/Log",
-	"sap/base/util/ObjectPath",
-	"sap/ui/thirdparty/hasher"
-], function(library, HashChanger, Log, ObjectPath, hasher) {
+	"sap/base/util/ObjectPath"
+], function(library, HashChanger, Log, ObjectPath) {
 	"use strict";
 
 	// shortcut for enum(s)
@@ -32,27 +31,32 @@ sap.ui.define([
 	 * @alias sap.ui.core.routing.History
 	 */
 	var History = function(oHashChanger) {
+		var that = this;
+
 		this._iHistoryLength = window.history.length;
 		this.aHistory = [];
 		this._bIsInitial = true;
 
-		if (History._bUsePushState && !History.getInstance()) {
-			var oState = window.history.state === null ? {} : window.history.state;
+		function initHistory(sCurrentHash) {
+			if (History._bUsePushState && !History.getInstance()) {
+				var oState = window.history.state === null ? {} : window.history.state;
 
-			if (typeof oState === "object") {
-				var sHash = hasher.getHash();
-				oState.sap = oState.sap ? oState.sap : {};
+				if (typeof oState === "object") {
+					oState.sap = oState.sap ? oState.sap : {};
 
-				if (oState.sap.history && Array.isArray(oState.sap.history) && oState.sap.history[oState.sap.history.length - 1] === sHash) {
-					History._aStateHistory = oState.sap.history;
+					if (oState.sap.history && Array.isArray(oState.sap.history) && oState.sap.history[oState.sap.history.length - 1] === sCurrentHash) {
+						History._aStateHistory = oState.sap.history;
+					} else {
+						History._aStateHistory.push(sCurrentHash);
+						oState.sap.history = History._aStateHistory;
+						window.history.replaceState(oState, window.document.title);
+					}
 				} else {
-					History._aStateHistory.push(sHash);
-					oState.sap.history = History._aStateHistory;
-					window.history.replaceState(oState, window.document.title);
+					Log.debug("Unable to determine HistoryDirection as history.state is already set: " + window.history.state, "sap.ui.core.routing.History");
 				}
-			} else {
-				Log.debug("Unable to determine HistoryDirection as history.state is already set: " + window.history.state, "sap.ui.core.routing.History");
 			}
+
+			that._reset();
 		}
 
 		if (!oHashChanger) {
@@ -61,7 +65,13 @@ sap.ui.define([
 
 		this._setHashChanger(oHashChanger);
 
-		this._reset();
+		if (oHashChanger._initialized) {
+			initHistory(oHashChanger.getHash());
+		} else {
+			oHashChanger.attachEventOnce("hashChanged", function(oEvent) {
+				initHistory(oEvent.getParameter("newHash"));
+			});
+		}
 	};
 
 	/**

package/src/sap/ui/core/routing/Route.js

@@ -234,7 +234,16 @@ sap.ui.define([
 					// suspend the dynamic targets
 					if (this._oConfig.dynamicTarget) {
 						this._oRouter._oTargets.suspend(this._oConfig.dynamicTarget);
-						delete this._oConfig.dynamicTarget;
+					}
+				}
+			},
+
+			_resume: function() {
+				if (this._oRouter._oTargets) {
+					this._oRouter._oTargets.resume(this._oConfig.target);
+
+					if (this._oConfig.dynamicTarget) {
+						this._oRouter._oTargets.resume(this._oConfig.dynamicTarget);
 					}
 				}
 			},

package/src/sap/ui/core/routing/Router.js

@@ -435,10 +435,14 @@ sap.ui.define([
 				// shouldn't be processed.
 				this.oHashChanger.attachEvent("hashChanged", this.fnHashChanged);
 
-				// The HashChanger returns an InvalidHash when one of its ancestors is currently in
-				// the collect mode of preparing the next hash change. In this case, the Router should
-				// not be initialized and wait for the next 'hashChanged' event.
-				if (!bIgnoreInitialHash && sHash !== RouterHashChanger.InvalidHash) {
+				if (bIgnoreInitialHash) {
+					if (this._oMatchedRoute) {
+						this._oMatchedRoute._resume();
+					}
+				} else if (sHash !== RouterHashChanger.InvalidHash) {
+					// The HashChanger returns an InvalidHash when one of its ancestors is currently in
+					// the collect mode of preparing the next hash change. In this case, the Router should
+					// not parse the current hash and wait for the next 'hashChanged' event.
 					this.parse(sHash);
 				}
 
@@ -490,7 +494,6 @@ sap.ui.define([
 
 				if (this._oMatchedRoute) {
 					this._oMatchedRoute._routeSwitched();
-					this._oMatchedRoute = null;
 				}
 
 				this._bIsInitialized = false;

package/src/sap/ui/core/routing/TargetCache.js

@@ -171,7 +171,7 @@ sap.ui.define([
 				}
 
 				function destroyObject(oObject) {
-					if (oObject && oObject.destroy) {
+					if (oObject && oObject.destroy && !oObject._bIsBeingDestroyed) {
 						oObject.destroy();
 					}
 				}

package/src/sap/ui/core/routing/Targets.js

@@ -511,6 +511,32 @@ sap.ui.define([
 				return this;
 			},
 
+			/**
+			 * Resumes the targets which are specified by the parameter
+			 *
+			 * @param {string|string[]|object|object[]} vTargets The key of the target
+			 *  or an object which has the key of the target under property 'name' as
+			 *  specified in the {@link #constructor}. To suspend multiple targets you
+			 *  may also pass an array of keys or objects which have the key saved
+			 *  under the 'name' property
+			 * @return {sap.ui.core.routing.Targets} The 'this' for call chaining
+			 * @private
+			 */
+			resume : function (vTargets) {
+				var aTargetsInfo = this._alignTargetsInfo(vTargets);
+
+				aTargetsInfo.forEach(function(oTargetInfo) {
+					var sTargetName = oTargetInfo.name;
+					var oTarget = this.getTarget(sTargetName);
+
+					if (oTarget) {
+						oTarget.resume();
+					}
+				}.bind(this));
+
+				return this;
+			},
+
 			/**
 			 * Will be fired when a target is displayed.
 			 *

package/src/sap/ui/core/routing/async/Route.js

@@ -35,12 +35,15 @@ sap.ui.define(["sap/base/Log", "sap/base/util/extend", "sap/ui/core/Component"],
 				oTargetData,
 				oCurrentPromise,
 				aAlignedTargets,
-				bRepeated = false;
+				bRepeated = (oRouter._oMatchedRoute === this);
 
 			oRouter._stopWaitingTitleChangedFromChild();
-			if (oRouter._oMatchedRoute === this) {
-				bRepeated = true;
+
+			if (oRouter._oMatchedRoute) {
+				// clear the dynamicTarget of the previous matched route
+				delete oRouter._oMatchedRoute._oConfig.dynamicTarget;
 			}
+
 			oRouter._oMatchedRoute = this;
 			oRouter._bMatchingProcessStarted = true;