@openui5/sap.ui.core 1.116.0 → 1.117.1

package/test/sap/ui/core/demokit/tutorial/odatav4/06/webapp/localService/mockserver.js

@@ -606,6 +606,7 @@ sap.ui.define([
 
 			sResponseBody = '{"@odata.context": "' + getBaseUrl(oXhr.url)
 				+ '$metadata#People/$entity",';
+			oUser.HomeAddress = oUser.HomeAddress || null; // prevents drillDown errors
 			sResponseBody += JSON.stringify(oUser).slice(1);
 
 			// The response to POST requests is http 201 (Created)

package/test/sap/ui/core/demokit/tutorial/odatav4/07/webapp/controller/App.controller.js

@@ -46,12 +46,7 @@ sap.ui.define([
 			var oList = this.byId("peopleList"),
 				oBinding = oList.getBinding("items"),
 				// Create a new entry through the table's list binding
-				oContext = oBinding.create({
-					UserName : "",
-					FirstName : "",
-					LastName : "",
-					Age : "18"
-				});
+				oContext = oBinding.create({Age : "18"});
 
 			this._setUIChanges(true);
 			this.getView().getModel("appView").setProperty("/usernameEmpty", true);

package/test/sap/ui/core/demokit/tutorial/odatav4/07/webapp/localService/mockserver.js

@@ -606,6 +606,7 @@ sap.ui.define([
 
 			sResponseBody = '{"@odata.context": "' + getBaseUrl(oXhr.url)
 				+ '$metadata#People/$entity",';
+			oUser.HomeAddress = oUser.HomeAddress || null; // prevents drillDown errors
 			sResponseBody += JSON.stringify(oUser).slice(1);
 
 			// The response to POST requests is http 201 (Created)

package/test/sap/ui/core/demokit/tutorial/odatav4/08/webapp/controller/App.controller.js

@@ -46,12 +46,7 @@ sap.ui.define([
 			var oList = this.byId("peopleList"),
 				oBinding = oList.getBinding("items"),
 				// Create a new entry through the table's list binding
-				oContext = oBinding.create({
-					UserName : "",
-					FirstName : "",
-					LastName : "",
-					Age : "18"
-				});
+				oContext = oBinding.create({Age : "18"});
 
 			this._setUIChanges(true);
 			this.getView().getModel("appView").setProperty("/usernameEmpty", true);

package/test/sap/ui/core/demokit/tutorial/odatav4/08/webapp/localService/mockserver.js

@@ -606,6 +606,7 @@ sap.ui.define([
 
 			sResponseBody = '{"@odata.context": "' + getBaseUrl(oXhr.url)
 				+ '$metadata#People/$entity",';
+			oUser.HomeAddress = oUser.HomeAddress || null; // prevents drillDown errors
 			sResponseBody += JSON.stringify(oUser).slice(1);
 
 			// The response to POST requests is http 201 (Created)

package/test/sap/ui/core/demokit/tutorial/odatav4/09/webapp/controller/App.controller.js

@@ -46,12 +46,7 @@ sap.ui.define([
 			var oList = this.byId("peopleList"),
 				oBinding = oList.getBinding("items"),
 				// Create a new entry through the table's list binding
-				oContext = oBinding.create({
-					UserName : "",
-					FirstName : "",
-					LastName : "",
-					Age : "18"
-				});
+				oContext = oBinding.create({Age : "18"});
 
 			this._setUIChanges(true);
 			this.getView().getModel("appView").setProperty("/usernameEmpty", true);

package/test/sap/ui/core/demokit/tutorial/odatav4/09/webapp/localService/mockserver.js

@@ -606,6 +606,7 @@ sap.ui.define([
 
 			sResponseBody = '{"@odata.context": "' + getBaseUrl(oXhr.url)
 				+ '$metadata#People/$entity",';
+			oUser.HomeAddress = oUser.HomeAddress || null; // prevents drillDown errors
 			sResponseBody += JSON.stringify(oUser).slice(1);
 
 			// The response to POST requests is http 201 (Created)

package/test/sap/ui/core/demokit/tutorial/odatav4/10/webapp/controller/App.controller.js

@@ -46,12 +46,7 @@ sap.ui.define([
 			var oList = this.byId("peopleList"),
 				oBinding = oList.getBinding("items"),
 				// Create a new entry through the table's list binding
-				oContext = oBinding.create({
-					UserName : "",
-					FirstName : "",
-					LastName : "",
-					Age : "18"
-				});
+				oContext = oBinding.create({Age : "18"});
 
 			this._setUIChanges(true);
 			this.getView().getModel("appView").setProperty("/usernameEmpty", true);
@@ -299,10 +294,10 @@ sap.ui.define([
 			}
 
 			oOldContext = oDetailArea.getBindingContext();
-			if (oOldContext) {
+			if (oOldContext && !oOldContext.isTransient()) {
 				oOldContext.setKeepAlive(false);
 			}
-			if (oUserContext) {
+			if (oUserContext && !oUserContext.isTransient()) {
 				oUserContext.setKeepAlive(true,
 					// hide details if kept entity was refreshed but does not exist any more
 					this._setDetailArea.bind(this));

package/test/sap/ui/core/demokit/tutorial/odatav4/10/webapp/localService/mockserver.js

@@ -607,6 +607,7 @@ sap.ui.define([
 
 			sResponseBody = '{"@odata.context": "' + getBaseUrl(oXhr.url)
 				+ '$metadata#People/$entity",';
+			oUser.HomeAddress = oUser.HomeAddress || null; // prevents drillDown errors
 			sResponseBody += JSON.stringify(oUser).slice(1);
 
 			// The response to POST requests is http 201 (Created)

package/test/sap/ui/core/demokit/tutorial/odatav4/11/webapp/controller/App.controller.js

@@ -46,12 +46,7 @@ sap.ui.define([
 			var oList = this.byId("peopleList"),
 				oBinding = oList.getBinding("items"),
 				// Create a new entry through the table's list binding
-				oContext = oBinding.create({
-					UserName : "",
-					FirstName : "",
-					LastName : "",
-					Age : "18"
-				});
+				oContext = oBinding.create({Age : "18"});
 
 			this._setUIChanges(true);
 			this.getView().getModel("appView").setProperty("/usernameEmpty", true);
@@ -299,10 +294,10 @@ sap.ui.define([
 			}
 
 			oOldContext = oDetailArea.getBindingContext();
-			if (oOldContext) {
+			if (oOldContext && !oOldContext.isTransient()) {
 				oOldContext.setKeepAlive(false);
 			}
-			if (oUserContext) {
+			if (oUserContext && !oUserContext.isTransient()) {
 				oUserContext.setKeepAlive(true,
 					// hide details if kept entity was refreshed but does not exist any more
 					this._setDetailArea.bind(this));

package/test/sap/ui/core/demokit/tutorial/odatav4/11/webapp/localService/mockserver.js

@@ -606,6 +606,7 @@ sap.ui.define([
 
 			sResponseBody = '{"@odata.context": "' + getBaseUrl(oXhr.url)
 				+ '$metadata#People/$entity",';
+			oUser.HomeAddress = oUser.HomeAddress || null; // prevents drillDown errors
 			sResponseBody += JSON.stringify(oUser).slice(1);
 
 			// The response to POST requests is http 201 (Created)

package/test/sap/ui/core/qunit/IconPool.qunit.js

@@ -1,13 +1,15 @@
 
-/* global QUnit */
+/* global sinon QUnit */
 sap.ui.define([
 	"sap/ui/core/IconPool",
+	"sap/ui/core/_IconRegistry",
 	"sap/ui/core/Icon",
+	"sap/ui/core/Theming",
 	"sap/m/Image",
 	"sap/base/Log",
 	"sap/ui/test/TestUtils",
 	"sap/ui/thirdparty/jquery"
-], function(IconPool, Icon, Image, Log, TestUtils, jQuery) {
+], function(IconPool, _IconRegistry, Icon, Theming, Image, Log, TestUtils, jQuery) {
 	"use strict";
 
 	QUnit.config.reorder = false;
@@ -185,7 +187,7 @@ sap.ui.define([
 
 		IconPool.registerFont({
 			fontFamily: sFontFamily,
-			fontURI: sap.ui.require.toUrl("sap/tnt/themes/base/fonts")
+			fontURI: sap.ui.require.toUrl("sap/tnt/themes/base/fonts/")
 		});
 
 		// insert sap-icons-TNT font
@@ -200,7 +202,7 @@ sap.ui.define([
 
 		iFontFaceCount = document.fonts.size;
 		// insert font again
-		IconPool.insertFontFaceStyle(sFontFamily, sap.ui.require.toUrl("sap/tnt/themes/base/fonts"));
+		IconPool.insertFontFaceStyle(sFontFamily, sap.ui.require.toUrl("sap/tnt/themes/base/fonts/"));
 		assert.equal(document.fonts.size, iFontFaceCount, "No new FontFace is created");
 	});
 
@@ -420,6 +422,53 @@ sap.ui.define([
 		assert.strictEqual(IconPool.fontLoaded("invalid"), undefined, "fontLoaded returns undefined");
 	});
 
+	QUnit.module("Theme dependent Icons", {});
+
+	QUnit.test("registerFont with SAP-icons-TNT (Horizon Theme)", function(assert) {
+		const oInsertFontFaceStyleSpy = sinon.spy(_IconRegistry, "insertFontFaceStyle");
+		const oGetThemeStub = sinon.stub(Theming, "getTheme").returns("sap_horizon");
+
+		IconPool.registerFont({
+			collectionName: "my-tnt-icons-horizon",
+			fontFamily: "SAP-icons-TNT",
+			fontURI: sap.ui.require.toUrl("sap/tnt/themes/base/fonts/")
+		});
+
+		return IconPool.fontLoaded("my-tnt-icons-horizon").then(function() {
+			const sExpectedFontURI = sap.ui.require.toUrl("sap/tnt/themes/base/fonts/horizon/");
+			assert.ok(oInsertFontFaceStyleSpy.calledWith("SAP-icons-TNT", sExpectedFontURI, "my-tnt-icons-horizon"), "Correct font face inserted.");
+
+			// restore stubs
+			oGetThemeStub.restore();
+			oInsertFontFaceStyleSpy.restore();
+		});
+	});
+
+	QUnit.test("registerFont with SAP-icons-TNT (switching themes) ", function(assert) {
+		// set initial theme so that we enforce a theme change event
+		Theming.setTheme("sap_belize");
+
+		IconPool.registerFont({
+			collectionName: "sap-tnt-icons-horizon-2",
+			fontFamily: "SAP-icons-TNT",
+			fontURI: sap.ui.require.toUrl("sap/tnt/themes/base/fonts/")
+		});
+
+		return new Promise((res, rej) => {
+			IconPool.fontLoaded("sap-tnt-icons-horizon-2").then(function() {
+				const oInsertFontFaceStyleSpy = sinon.spy(_IconRegistry, "insertFontFaceStyle");
+				const sExpectedFontURI = sap.ui.require.toUrl("sap/tnt/themes/base/fonts/horizon/");
+
+				Theming.attachApplied(() => {
+					assert.ok(oInsertFontFaceStyleSpy.calledWith("SAP-icons-TNT", sExpectedFontURI, "sap-tnt-icons-horizon-2"));
+					res();
+				});
+
+				Theming.setTheme("sap_horizon");
+			});
+		});
+	});
+
 	QUnit.module("Sync getIconInfo");
 
 	QUnit.test("Calling getIconInfo with 'sync' mode on the default icon font returns the result immediately", function(assert) {

package/test/sap/ui/core/qunit/ManagedObjectModel.qunit.js

@@ -1002,18 +1002,56 @@ sap.ui.define([
 		this.spy(oBinding3, "checkUpdate");
 		var fnDone = assert.async();
 		oModel.checkUpdate(true, true, fnFilter);
-		oModel.checkUpdate(false, true, fnFilter); // to test foceUpdate wins
+		oModel.checkUpdate(false, true, fnFilter); // to test forceUpdate wins
 		setTimeout(function() { // wait for Model update
 			assert.equal(aTrueBindings.length, 1, "The test is called an delivers true for one binding");
 			assert.deepEqual(aTrueBindings[0], oBinding1, "And this is exactly the first binding");
-			assert.ok(oBinding1.checkUpdate.calledWith(true), "chechUpdate called as forced");
-			assert.ok(oBinding1.checkUpdate.calledOnce, "chechUpdate called only once");
-			assert.notOk(oBinding2.checkUpdate.called, "chechUpdate not called on other Binding");
-			assert.notOk(oBinding3.checkUpdate.called, "chechUpdate not called on other Binding");
+			assert.ok(oBinding1.checkUpdate.calledWith(true), "checkUpdate called as forced");
+			assert.ok(oBinding1.checkUpdate.calledOnce, "checkUpdate called only once");
+			assert.notOk(oBinding2.checkUpdate.called, "checkUpdate not called on other Binding");
+			assert.notOk(oBinding3.checkUpdate.called, "checkUpdate not called on other Binding");
 			fnDone();
 		}, 0);
 	});
 
+	QUnit.test("Check Update with different binding test function async", function (assert) {
+		var aTrueBindings = [];
+		var oModel = this.oManagedObjectModel;
+		var oBinding1 = oModel.bindProperty("/value");
+		var oBinding2 = oModel.bindProperty("/stringValue");
+		var oBinding3 = oModel.bindProperty("/floatValue");
+		oModel.addBinding(oBinding1);
+		oModel.addBinding(oBinding2);
+		oModel.addBinding(oBinding3);
+
+		assert.equal(oModel.getBindings().length, 3, "There are three bindings");
+
+		var fnFilter1 = function (oBinding) {
+			if (oBinding == oBinding1) {
+				aTrueBindings.push(oBinding);
+				return true;
+			}
+			return false;
+		};
+		var fnFilter2 = function (oBinding) {
+			if (oBinding == oBinding2) {
+				aTrueBindings.push(oBinding);
+				return true;
+			}
+			return false;
+		};
+
+		this.spy(oBinding1, "checkUpdate");
+		this.spy(oBinding2, "checkUpdate");
+		this.spy(oBinding3, "checkUpdate");
+		oModel.checkUpdate(true, true, fnFilter1);
+		oModel.checkUpdate(true, true, fnFilter2);
+		oModel.checkUpdate(false, false, fnFilter2);
+		assert.ok(oBinding1.checkUpdate.calledOnce, "checkUpdate called only once");
+		assert.ok(oBinding2.checkUpdate.calledOnce, "checkUpdate called only once");
+		assert.ok(oBinding3.checkUpdate.calledOnce, "checkUpdate called only once");
+	});
+
 	QUnit.test("ManagedObject Model - handle object properties", function(assert) {
 		var oData = {value: "A string", text: "A text"};
 		var oModel = new JSONModel({

package/test/sap/ui/core/qunit/Theming.qunit.js

@@ -1,11 +1,13 @@
 /* global QUnit, sinon, globalThis */
 
 sap.ui.define([
+	"sap/base/config",
 	"sap/base/Event",
 	"sap/ui/base/config/URLConfigurationProvider",
 	"sap/ui/core/Theming",
 	"sap/ui/qunit/utils/waitForThemeApplied"
 ], function (
+	BaseConfig,
 	BaseEvent,
 	URLConfigurationProvider,
 	Theming,
@@ -74,23 +76,36 @@ sap.ui.define([
 		}
 	});
 
+	/**
+	 * This is regression test for when the initial theme is an empty string ("").
+	 * The empty string is given in the "testsuite.theming.qunit.js" as a bootstrap parameter.
+	 *
+	 * Before fixing this regression, an empty string lead to a "Maximum call stack size exceeded" error.
+	 */
+	QUnit.test("Initial Theme - empty string fallback", function(assert) {
+		assert.equal(Theming.getTheme(), "base", "Initial Theme after bootstrapping should be 'base'");
+	});
+
 	QUnit.test("getTheme", function (assert) {
 		assert.expect(bThemeManagerNotActive ? 28 : 27);
-
+		BaseConfig._.invalidate();
 		mConfigStubValues = {
 			"sapTheme": "sap_test_theme_1",
 			"sapUiTheme": "sap_test_theme_2"
 		};
 		// sapTheme should be first
 		return fnAssert("sap_test_theme_1").then(function() {
+			BaseConfig._.invalidate();
 			mConfigStubValues["sapTheme"] = undefined;
 			// if there is no sapTheme sapUiTheme should be used
 			return fnAssert("sap_test_theme_2");
 		}).then(function() {
+			BaseConfig._.invalidate();
 			mConfigStubValues["sapUiTheme"] = undefined;
 			// use default value 'base' in case there is no theming parameter at all
 			return fnAssert("base");
 		}).then(function() {
+			BaseConfig._.invalidate();
 			mConfigStubValues["sapTheme"] = "sap_test_theme_3@/sap/test/themeroot";
 			// first call with themeroot should trigger a change event for the implicit setThemeRoot call
 			return fnAssert("sap_test_theme_3", [{
@@ -105,6 +120,7 @@ sap.ui.define([
 			return fnAssert("sap_test_theme_3");
 		}).then(function() {
 			// third call with identical theme but different themeroot should trigger a change event for the implicit setThemeRoot call
+			BaseConfig._.invalidate();
 			mConfigStubValues["sapTheme"] = "sap_test_theme_3@/sap/different/test/themeroot";
 			return fnAssert("sap_test_theme_3", [{
 				themeRoots: {
@@ -115,10 +131,12 @@ sap.ui.define([
 			}]);
 		}).then(function() {
 			// sap_corbu theme should be normalized to sap_fiori_3 theme
+			BaseConfig._.invalidate();
 			mConfigStubValues["sapTheme"] = "sap_corbu";
 			return fnAssert("sap_fiori_3");
 		}).then(function() {
 			// sap_corbu theme with specific themeroots should not be normalized and themeroots for sap_corbu should trigger a change event
+			BaseConfig._.invalidate();
 			mConfigStubValues["sapTheme"] = "sap_corbu@/sap/test/themeroot";
 			return fnAssert("sap_corbu", [{
 				themeRoots: {